[{"id":1763817,"web_url":"http://patchwork.ozlabs.org/comment/1763817/","msgid":"","list_archive_url":null,"date":"2017-09-06T05:23:26","subject":"Re: [PATCH v3 2/3] arm: dts: add Nuvoton NPCM750 device tree","submitter":{"id":48628,"url":"http://patchwork.ozlabs.org/api/people/48628/","name":"Joel Stanley","email":"joel@jms.id.au"},"content":"On Wed, Sep 6, 2017 at 10:00 AM, Brendan Higgins\n wrote:\n> +++ b/Documentation/devicetree/bindings/arm/npcm/npcm.txt\n> @@ -0,0 +1,6 @@\n> +NPCM Platforms Device Tree Bindings\n> +-----------------------------------\n> +NPCM750 SoC\n> +Required root node properties:\n> + - compatible = \"nuvoton,npcm750\";\n> +\n\nThis is minimal. I assume there will be more content added as more\nsupport is added?\n\nDoes it need it's own directory?\n\n\n> diff --git a/arch/arm/boot/dts/nuvoton-npcm750-evb.dts b/arch/arm/boot/dts/nuvoton-npcm750-evb.dts\n> new file mode 100644\n> index 000000000000..54df32cff21b\n> --- /dev/null\n> +++ b/arch/arm/boot/dts/nuvoton-npcm750-evb.dts\n\n> +\n> +/dts-v1/;\n> +#include \"nuvoton-npcm750.dtsi\"\n> +\n> +/ {\n> + model = \"Nuvoton npcm750 Development Board (Device Tree)\";\n> + compatible = \"nuvoton,npcm750\";\n> +\n> + chosen {\n> + stdout-path = &serial3;\n> + bootargs = \"earlyprintk=serial,serial3,115200\";\n> + };\n> +\n> + memory {\n> + reg = <0 0x40000000>;\n> + };\n> +\n> + cpus {\n> + enable-method = \"nuvoton,npcm7xx-smp\";\n> + };\n> +\n> + clk: clock-controller@f0801000 {\n> + status = \"okay\";\n> + };\n> +\n> + apb {\n> + watchdog1: watchdog@f0009000 {\n> + status = \"okay\";\n> + };\n\nYou've already got the label for the node, is there are reason you\ndon't use a phandle to set the status?\n\n&watchdog1 {\n status = \"okay\";\n};\n\nSame with the serial nodes below.\n\n> +\n> + serial0: serial0@f0001000 {\n> + status = \"okay\";\n> + };\n> +\n> + serial1: serial1@f0002000 {\n> + status = \"okay\";\n> + };\n> +\n> + serial2: serial2@f0003000 {\n> + status = \"okay\";\n> + };\n> +\n> + serial3: serial3@f0004000 {\n> + status = \"okay\";\n> + };\n> + };","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","openbmc@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","openbmc@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xnBp40qTLz9rxm\n\tfor ;\n\tWed, 6 Sep 2017 15:23:56 +1000 (AEST)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3xnBp36PBRzDrKf\n\tfor ;\n\tWed, 6 Sep 2017 15:23:55 +1000 (AEST)","from mail-lf0-x244.google.com (mail-lf0-x244.google.com\n\t[IPv6:2a00:1450:4010:c07::244])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128\n\tbits)) (No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3xnBnz0B5nzDrJL\n\tfor ; Wed, 6 Sep 2017 15:23:50 +1000 (AEST)","by mail-lf0-x244.google.com with SMTP id m199so2579641lfe.5\n\tfor ; Tue, 05 Sep 2017 22:23:50 -0700 (PDT)","by 10.25.79.70 with HTTP; Tue, 5 Sep 2017 22:23:26 -0700 (PDT)"],"Authentication-Results":["ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"RLrzbEQg\"; dkim-atps=neutral","lists.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"RLrzbEQg\"; dkim-atps=neutral","ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=gmail.com\n\t(client-ip=2a00:1450:4010:c07::244; helo=mail-lf0-x244.google.com;\n\tenvelope-from=joel.stan@gmail.com; receiver=)","lists.ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"RLrzbEQg\"; dkim-atps=neutral"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc;\n\tbh=qnyK7jqYxuHaTUGmbHxO4anZv+T/B2U4mlNeI9IfRKg=;\n\tb=RLrzbEQg/X9mqvOjU0qxa/tGylBFNSh37CCPbWRAD2gL3lTsqjp//NTkbNOTSW1xO4\n\t/zNx80/FoaVrZoHjUIdJxIU/6YBDtfKLlVc7VD2fSSCoZrVUsz0isysVGQqGddeidOm0\n\t97558Sb5TiqW5AwAbHrME+bUhPcpGYdVVjVtrBPKQWe/IzVOb63+WRGAGBzgYgUHdhyR\n\tkte2LbQeAxAIX4sR4/REZsUW/GvMBpNU/RryXgNyH4nDEtgDlpnd0PWhb84vrtcjObQW\n\tti8BsHJbLdoyvUtyO6OITjxZGF5ikAsYH4HFBBaO1NB7d743CCirz2uqsoYEEE27VjwY\n\tajQw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:sender:in-reply-to:references:from\n\t:date:message-id:subject:to:cc;\n\tbh=qnyK7jqYxuHaTUGmbHxO4anZv+T/B2U4mlNeI9IfRKg=;\n\tb=HHUvZnkE7WTmNBNZQp1E0nLRbRoWm1e5HwsbC5S3HqLB4RGufYY2KcsNm3dSn5b75s\n\tHj3n1v0bBOXn8+5Gtqz62SFJymsz53TestxR6e66dgomU0G4BzqjadTEw1Q38zTCWT7C\n\toR1z1ndzNrDoW609UyBBhj8KpX71VkJu2xDD0LQKInetOrK/De4tAOk7JH1kqs9EnlBd\n\tlg5oZ8lv5qZaM0iRfdt37QV70C4pnbLtjkRiRZ/0A3H4dWUsH+3E0nyR8RY+Z0dxaUom\n\tJISogUACIAIrY1oAZLB4FYd670XTLGz80dm+AQ5ynV3nhYHElBw/Qwj2/c418TPfJ4kw\n\tmiFg==","X-Gm-Message-State":"AHPjjUgS28h7u1LZ7JB+rf6WMz7aPOI8hAIV7GNieL1dvft3aGIUhvIc\n\ti3yzutshIES8U81uBqtJKHv3BGDzQg==","X-Google-Smtp-Source":"ADKCNb4HgNlwVOhCTPIUQv1wkJO1fb3uUj4fJaDQrzRJO7b15Ld4cuo2ccQmOdzcYxXlXv97Uih5rUGObbvMFhqa4CI=","X-Received":"by 10.46.71.72 with SMTP id u69mr418470lja.182.1504675427347;\n\tTue, 05 Sep 2017 22:23:47 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<20170906003016.2159-3-brendanhiggins@google.com>","References":"<20170906003016.2159-1-brendanhiggins@google.com>\n\t<20170906003016.2159-3-brendanhiggins@google.com>","From":"Joel Stanley ","Date":"Wed, 6 Sep 2017 14:53:26 +0930","X-Google-Sender-Auth":"2F2ulwkpDLVJdT1FJs9aESVTvp8","Message-ID":"","Subject":"Re: [PATCH v3 2/3] arm: dts: add Nuvoton NPCM750 device tree","To":"Brendan Higgins ","Content-Type":"text/plain; charset=\"UTF-8\"","X-BeenThere":"openbmc@lists.ozlabs.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"Development list for OpenBMC ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Mark Rutland ,\n\tdevicetree ,\n\tFlorian Fainelli , tmaimon77@gmail.com,\n\tavifishman70@gmail.com, OpenBMC Maillist , \n\tRussell King ,\n\tLinux Kernel Mailing List ,\n\tRob Herring , linux-arm-kernel@lists.infradead.org","Errors-To":"openbmc-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org","Sender":"\"openbmc\"\n\t"}},{"id":1763895,"web_url":"http://patchwork.ozlabs.org/comment/1763895/","msgid":"","list_archive_url":null,"date":"2017-09-06T08:19:11","subject":"Re: [PATCH v3 2/3] arm: dts: add Nuvoton NPCM750 device tree","submitter":{"id":69647,"url":"http://patchwork.ozlabs.org/api/people/69647/","name":"Brendan Higgins","email":"brendanhiggins@google.com"},"content":"On Tue, Sep 5, 2017 at 10:23 PM, Joel Stanley wrote:\n> On Wed, Sep 6, 2017 at 10:00 AM, Brendan Higgins\n> wrote:\n>> +++ b/Documentation/devicetree/bindings/arm/npcm/npcm.txt\n>> @@ -0,0 +1,6 @@\n>> +NPCM Platforms Device Tree Bindings\n>> +-----------------------------------\n>> +NPCM750 SoC\n>> +Required root node properties:\n>> + - compatible = \"nuvoton,npcm750\";\n>> +\n>\n> This is minimal. I assume there will be more content added as more\n> support is added?\n\nYep, that's the plan. They have a number of similar BMCs, both those\nbased on different ARM cores and some with different peripheral sets,\nso we will probably want to have different compat strings for those.\n\n>\n> Does it need it's own directory?\n\nNot sure, I saw that some of the other architectures did it, some did\nnot. I don't feel strongly about it.\n\n>\n>\n>> diff --git a/arch/arm/boot/dts/nuvoton-npcm750-evb.dts b/arch/arm/boot/dts/nuvoton-npcm750-evb.dts\n>> new file mode 100644\n>> index 000000000000..54df32cff21b\n>> --- /dev/null\n>> +++ b/arch/arm/boot/dts/nuvoton-npcm750-evb.dts\n>\n>> +\n>> +/dts-v1/;\n>> +#include \"nuvoton-npcm750.dtsi\"\n>> +\n>> +/ {\n>> + model = \"Nuvoton npcm750 Development Board (Device Tree)\";\n>> + compatible = \"nuvoton,npcm750\";\n>> +\n>> + chosen {\n>> + stdout-path = &serial3;\n>> + bootargs = \"earlyprintk=serial,serial3,115200\";\n>> + };\n>> +\n>> + memory {\n>> + reg = <0 0x40000000>;\n>> + };\n>> +\n>> + cpus {\n>> + enable-method = \"nuvoton,npcm7xx-smp\";\n>> + };\n>> +\n>> + clk: clock-controller@f0801000 {\n>> + status = \"okay\";\n>> + };\n>> +\n>> + apb {\n>> + watchdog1: watchdog@f0009000 {\n>> + status = \"okay\";\n>> + };\n>\n> You've already got the label for the node, is there are reason you\n> don't use a phandle to set the status?\n\nAddressed in v4.\n\n>\n> &watchdog1 {\n> status = \"okay\";\n> };\n>\n> Same with the serial nodes below.\n>\n>> +\n>> + serial0: serial0@f0001000 {\n>> + status = \"okay\";\n>> + };\n>> +\n>> + serial1: serial1@f0002000 {\n>> + status = \"okay\";\n>> + };\n>> +\n>> + serial2: serial2@f0003000 {\n>> + status = \"okay\";\n>> + };\n>> +\n>> + serial3: serial3@f0004000 {\n>> + status = \"okay\";\n>> + };\n>> + };","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","openbmc@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","openbmc@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xnGhT57kWz9s8J\n\tfor ;\n\tWed, 6 Sep 2017 18:19:21 +1000 (AEST)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3xnGhT3yzXzDrKk\n\tfor ;\n\tWed, 6 Sep 2017 18:19:21 +1000 (AEST)","from mail-qk0-x233.google.com (mail-qk0-x233.google.com\n\t[IPv6:2607:f8b0:400d:c09::233])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128\n\tbits)) (No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3xnGhM3B4rzDrJ7\n\tfor ; Wed, 6 Sep 2017 18:19:14 +1000 (AEST)","by mail-qk0-x233.google.com with SMTP id z143so17607547qkb.3\n\tfor ; Wed, 06 Sep 2017 01:19:14 -0700 (PDT)","by 10.140.33.197 with HTTP; Wed, 6 Sep 2017 01:19:11 -0700 (PDT)"],"Authentication-Results":["ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=google.com header.i=@google.com\n\theader.b=\"VgOwtIdW\"; dkim-atps=neutral","lists.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=google.com header.i=@google.com\n\theader.b=\"VgOwtIdW\"; dkim-atps=neutral","ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=google.com\n\t(client-ip=2607:f8b0:400d:c09::233; helo=mail-qk0-x233.google.com;\n\tenvelope-from=brendanhiggins@google.com; receiver=)","lists.ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=google.com header.i=@google.com\n\theader.b=\"VgOwtIdW\"; dkim-atps=neutral"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n\ts=20161025; \n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=5Y4fb2QvLTTO0o38qmXh6+NqvCrTLkTYOPSmgk4t/3o=;\n\tb=VgOwtIdWcXRhzmhQqE9WSKF3lCo9W78zppxGp7DtnfKRIE5pHGF0on/7P49419ALhJ\n\tHnIJ5hZTw9T4P+euQT+saEZqPi6i5CUwjz9eexSSg3IV3gLng9k8TO8ZVcYy0ba2byKf\n\tvUCKHTkXdc5hS6WjH22fi/2S3KElfE7KUATleoO6ppowp8mlCAVgwrCe7UgaYeUR5Tw5\n\txuiqZlM9IQBGkipZ95BIZYughMMNUHfnPHlg+AlSj15eEeVl6CISEn+ycW27VLbXRxKT\n\tUstrIxAAdtPRuoBgV8qsSWndkPuAGzXUOzdYLPs3dsmGzL2xdyz4Oo2KQQmmVW/byyCS\n\t4cag==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=5Y4fb2QvLTTO0o38qmXh6+NqvCrTLkTYOPSmgk4t/3o=;\n\tb=EdqxnJJf02TnKlqQ4gh2oQ5c9bOtrgbScJ26J3CNOBZ+DiNXpm35vculWSFt7j6ovK\n\t1OkhY1xDpg8WwNWLHMc2C2f5TMcQa7z/OYwYHfa7QgwH0OaiHW2PL/lVsdECOdyCXImo\n\tVquckLBnSFP+5BiTRwdMCMipIcDCPnggRP593owzkLHqPRYmRfRr9UBdu9Q238MRMgjV\n\tkDtyqgwqce9h63rN2eagtu0nx7eo4j/ACO70ZrJy9cuN3fYOtd6koQRngZOAytPiLjz2\n\tFozaGc6dmG5tACONprt8EKIglgziiGxPTw9u8XCQQA4FaFkQ2itc9ZvVuftcrsPb9KLl\n\tNHTA==","X-Gm-Message-State":"AHPjjUgPsg+HEfMwzsTVOJjx6YaDYYLLyRlJZ+lL1SEfKUUwyykjvi2H\n\tm2PgqrCJ0aoTxGGEfHAKiXL280MyG7y8","X-Google-Smtp-Source":"ADKCNb7GiSGGeGMTEwmx69SxSOfdLRHMym0m9NwpqcZ77exLqJiGLdCAneVbKfc1gI5HQ2hgrJQS1lxDuYVEqGO6Hck=","X-Received":"by 10.55.98.19 with SMTP id w19mr2388279qkb.261.1504685951754;\n\tWed, 06 Sep 2017 01:19:11 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"","References":"<20170906003016.2159-1-brendanhiggins@google.com>\n\t<20170906003016.2159-3-brendanhiggins@google.com>\n\t","From":"Brendan Higgins ","Date":"Wed, 6 Sep 2017 01:19:11 -0700","Message-ID":"","Subject":"Re: [PATCH v3 2/3] arm: dts: add Nuvoton NPCM750 device tree","To":"Joel Stanley ","Content-Type":"text/plain; charset=\"UTF-8\"","X-BeenThere":"openbmc@lists.ozlabs.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"Development list for OpenBMC ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Mark Rutland ,\n\tdevicetree ,\n\tFlorian Fainelli , tmaimon77@gmail.com,\n\tavifishman70@gmail.com, OpenBMC Maillist , \n\tRussell King ,\n\tLinux Kernel Mailing List ,\n\tRob Herring , linux-arm-kernel@lists.infradead.org","Errors-To":"openbmc-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org","Sender":"\"openbmc\"\n\t"}}]