[{"id":1763816,"web_url":"http://patchwork.ozlabs.org/comment/1763816/","msgid":"","list_archive_url":null,"date":"2017-09-06T05:23:26","subject":"Re: [PATCH v3 2/3] arm: dts: add Nuvoton NPCM750 device tree","submitter":{"id":48628,"url":"http://patchwork.ozlabs.org/api/people/48628/","name":"Joel Stanley","email":"joel@jms.id.au"},"content":"On Wed, Sep 6, 2017 at 10:00 AM, Brendan Higgins\n wrote:\n> +++ b/Documentation/devicetree/bindings/arm/npcm/npcm.txt\n> @@ -0,0 +1,6 @@\n> +NPCM Platforms Device Tree Bindings\n> +-----------------------------------\n> +NPCM750 SoC\n> +Required root node properties:\n> + - compatible = \"nuvoton,npcm750\";\n> +\n\nThis is minimal. I assume there will be more content added as more\nsupport is added?\n\nDoes it need it's own directory?\n\n\n> diff --git a/arch/arm/boot/dts/nuvoton-npcm750-evb.dts b/arch/arm/boot/dts/nuvoton-npcm750-evb.dts\n> new file mode 100644\n> index 000000000000..54df32cff21b\n> --- /dev/null\n> +++ b/arch/arm/boot/dts/nuvoton-npcm750-evb.dts\n\n> +\n> +/dts-v1/;\n> +#include \"nuvoton-npcm750.dtsi\"\n> +\n> +/ {\n> + model = \"Nuvoton npcm750 Development Board (Device Tree)\";\n> + compatible = \"nuvoton,npcm750\";\n> +\n> + chosen {\n> + stdout-path = &serial3;\n> + bootargs = \"earlyprintk=serial,serial3,115200\";\n> + };\n> +\n> + memory {\n> + reg = <0 0x40000000>;\n> + };\n> +\n> + cpus {\n> + enable-method = \"nuvoton,npcm7xx-smp\";\n> + };\n> +\n> + clk: clock-controller@f0801000 {\n> + status = \"okay\";\n> + };\n> +\n> + apb {\n> + watchdog1: watchdog@f0009000 {\n> + status = \"okay\";\n> + };\n\nYou've already got the label for the node, is there are reason you\ndon't use a phandle to set the status?\n\n&watchdog1 {\n status = \"okay\";\n};\n\nSame with the serial nodes below.\n\n> +\n> + serial0: serial0@f0001000 {\n> + status = \"okay\";\n> + };\n> +\n> + serial1: serial1@f0002000 {\n> + status = \"okay\";\n> + };\n> +\n> + serial2: serial2@f0003000 {\n> + status = \"okay\";\n> + };\n> +\n> + serial3: serial3@f0004000 {\n> + status = \"okay\";\n> + };\n> + };\n--\nTo unsubscribe from this list: send the line \"unsubscribe devicetree\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"RLrzbEQg\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xnBp05whpz9rxm\n\tfor ;\n\tWed, 6 Sep 2017 15:23:52 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1750819AbdIFFXt (ORCPT\n\t);\n\tWed, 6 Sep 2017 01:23:49 -0400","from mail-lf0-f67.google.com ([209.85.215.67]:35369 \"EHLO\n\tmail-lf0-f67.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1750752AbdIFFXt (ORCPT\n\t); Wed, 6 Sep 2017 01:23:49 -0400","by mail-lf0-f67.google.com with SMTP id c8so2598065lfe.2;\n\tTue, 05 Sep 2017 22:23:48 -0700 (PDT)","by 10.25.79.70 with HTTP; Tue, 5 Sep 2017 22:23:26 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc;\n\tbh=qnyK7jqYxuHaTUGmbHxO4anZv+T/B2U4mlNeI9IfRKg=;\n\tb=RLrzbEQg/X9mqvOjU0qxa/tGylBFNSh37CCPbWRAD2gL3lTsqjp//NTkbNOTSW1xO4\n\t/zNx80/FoaVrZoHjUIdJxIU/6YBDtfKLlVc7VD2fSSCoZrVUsz0isysVGQqGddeidOm0\n\t97558Sb5TiqW5AwAbHrME+bUhPcpGYdVVjVtrBPKQWe/IzVOb63+WRGAGBzgYgUHdhyR\n\tkte2LbQeAxAIX4sR4/REZsUW/GvMBpNU/RryXgNyH4nDEtgDlpnd0PWhb84vrtcjObQW\n\tti8BsHJbLdoyvUtyO6OITjxZGF5ikAsYH4HFBBaO1NB7d743CCirz2uqsoYEEE27VjwY\n\tajQw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:sender:in-reply-to:references:from\n\t:date:message-id:subject:to:cc;\n\tbh=qnyK7jqYxuHaTUGmbHxO4anZv+T/B2U4mlNeI9IfRKg=;\n\tb=QLFrL0RzETkoEWBwztY1D8YE4eTth8jfXuCd2UyoGc0goOjQVVs6468l2C+9rqV/zd\n\tWaOk6ebiWDieFGpE4k+r/RTEKgxM8LWQ+3kQj4rdlDnP9a2ynLJtLrOf+kaZL4Ps+vS5\n\tDoelFGv60BC9aMnlSH4YCVWmaZP3fZgpptP/WpYcuNYc3QPFj+A9o8+TDGGQWTtlwQn2\n\t6Vfa5B7D+bLXeWwp7keSo75CPX0V2YWIwkLJg1wtcfzAY2m/x521oSXgMG2WI6ipLUZ/\n\tPY1cz5NO8bapLQ76QVD8ngIXi1DGyL08Kq2QZONvcTQea9gLreHJ6afeX2My6XafDdum\n\tVitw==","X-Gm-Message-State":"AHPjjUiRICcqHOkH/ceZ7XIvwZAaH1YH1S0CiWTZaTm7GfFACpdF3R+t\n\tljQ0NCzQttSw8BkORJ/o55mOoBq2Jg==","X-Google-Smtp-Source":"ADKCNb4HgNlwVOhCTPIUQv1wkJO1fb3uUj4fJaDQrzRJO7b15Ld4cuo2ccQmOdzcYxXlXv97Uih5rUGObbvMFhqa4CI=","X-Received":"by 10.46.71.72 with SMTP id u69mr418470lja.182.1504675427347;\n\tTue, 05 Sep 2017 22:23:47 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<20170906003016.2159-3-brendanhiggins@google.com>","References":"<20170906003016.2159-1-brendanhiggins@google.com>\n\t<20170906003016.2159-3-brendanhiggins@google.com>","From":"Joel Stanley ","Date":"Wed, 6 Sep 2017 14:53:26 +0930","X-Google-Sender-Auth":"2F2ulwkpDLVJdT1FJs9aESVTvp8","Message-ID":"","Subject":"Re: [PATCH v3 2/3] arm: dts: add Nuvoton NPCM750 device tree","To":"Brendan Higgins ","Cc":"Rob Herring , Mark Rutland ,\n\tRussell King , avifishman70@gmail.com,\n\ttmaimon77@gmail.com, Rick Altherr ,\n\tFlorian Fainelli ,\n\tdevicetree ,\n\tLinux Kernel Mailing List ,\n\tlinux-arm-kernel@lists.infradead.org,\n\tOpenBMC Maillist ","Content-Type":"text/plain; charset=\"UTF-8\"","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}},{"id":1763893,"web_url":"http://patchwork.ozlabs.org/comment/1763893/","msgid":"","list_archive_url":null,"date":"2017-09-06T08:19:11","subject":"Re: [PATCH v3 2/3] arm: dts: add Nuvoton NPCM750 device tree","submitter":{"id":69647,"url":"http://patchwork.ozlabs.org/api/people/69647/","name":"Brendan Higgins","email":"brendanhiggins@google.com"},"content":"On Tue, Sep 5, 2017 at 10:23 PM, Joel Stanley wrote:\n> On Wed, Sep 6, 2017 at 10:00 AM, Brendan Higgins\n> wrote:\n>> +++ b/Documentation/devicetree/bindings/arm/npcm/npcm.txt\n>> @@ -0,0 +1,6 @@\n>> +NPCM Platforms Device Tree Bindings\n>> +-----------------------------------\n>> +NPCM750 SoC\n>> +Required root node properties:\n>> + - compatible = \"nuvoton,npcm750\";\n>> +\n>\n> This is minimal. I assume there will be more content added as more\n> support is added?\n\nYep, that's the plan. They have a number of similar BMCs, both those\nbased on different ARM cores and some with different peripheral sets,\nso we will probably want to have different compat strings for those.\n\n>\n> Does it need it's own directory?\n\nNot sure, I saw that some of the other architectures did it, some did\nnot. I don't feel strongly about it.\n\n>\n>\n>> diff --git a/arch/arm/boot/dts/nuvoton-npcm750-evb.dts b/arch/arm/boot/dts/nuvoton-npcm750-evb.dts\n>> new file mode 100644\n>> index 000000000000..54df32cff21b\n>> --- /dev/null\n>> +++ b/arch/arm/boot/dts/nuvoton-npcm750-evb.dts\n>\n>> +\n>> +/dts-v1/;\n>> +#include \"nuvoton-npcm750.dtsi\"\n>> +\n>> +/ {\n>> + model = \"Nuvoton npcm750 Development Board (Device Tree)\";\n>> + compatible = \"nuvoton,npcm750\";\n>> +\n>> + chosen {\n>> + stdout-path = &serial3;\n>> + bootargs = \"earlyprintk=serial,serial3,115200\";\n>> + };\n>> +\n>> + memory {\n>> + reg = <0 0x40000000>;\n>> + };\n>> +\n>> + cpus {\n>> + enable-method = \"nuvoton,npcm7xx-smp\";\n>> + };\n>> +\n>> + clk: clock-controller@f0801000 {\n>> + status = \"okay\";\n>> + };\n>> +\n>> + apb {\n>> + watchdog1: watchdog@f0009000 {\n>> + status = \"okay\";\n>> + };\n>\n> You've already got the label for the node, is there are reason you\n> don't use a phandle to set the status?\n\nAddressed in v4.\n\n>\n> &watchdog1 {\n> status = \"okay\";\n> };\n>\n> Same with the serial nodes below.\n>\n>> +\n>> + serial0: serial0@f0001000 {\n>> + status = \"okay\";\n>> + };\n>> +\n>> + serial1: serial1@f0002000 {\n>> + status = \"okay\";\n>> + };\n>> +\n>> + serial2: serial2@f0003000 {\n>> + status = \"okay\";\n>> + };\n>> +\n>> + serial3: serial3@f0004000 {\n>> + status = \"okay\";\n>> + };\n>> + };\n--\nTo unsubscribe from this list: send the line \"unsubscribe devicetree\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=google.com header.i=@google.com\n\theader.b=\"VgOwtIdW\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xnGhN42Dwz9sNd\n\tfor ;\n\tWed, 6 Sep 2017 18:19:16 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751875AbdIFITO (ORCPT\n\t);\n\tWed, 6 Sep 2017 04:19:14 -0400","from mail-qk0-f173.google.com ([209.85.220.173]:38769 \"EHLO\n\tmail-qk0-f173.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751626AbdIFITM (ORCPT\n\t); Wed, 6 Sep 2017 04:19:12 -0400","by mail-qk0-f173.google.com with SMTP id a128so17526256qkc.5\n\tfor ;\n\tWed, 06 Sep 2017 01:19:12 -0700 (PDT)","by 10.140.33.197 with HTTP; Wed, 6 Sep 2017 01:19:11 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n\ts=20161025; \n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=5Y4fb2QvLTTO0o38qmXh6+NqvCrTLkTYOPSmgk4t/3o=;\n\tb=VgOwtIdWcXRhzmhQqE9WSKF3lCo9W78zppxGp7DtnfKRIE5pHGF0on/7P49419ALhJ\n\tHnIJ5hZTw9T4P+euQT+saEZqPi6i5CUwjz9eexSSg3IV3gLng9k8TO8ZVcYy0ba2byKf\n\tvUCKHTkXdc5hS6WjH22fi/2S3KElfE7KUATleoO6ppowp8mlCAVgwrCe7UgaYeUR5Tw5\n\txuiqZlM9IQBGkipZ95BIZYughMMNUHfnPHlg+AlSj15eEeVl6CISEn+ycW27VLbXRxKT\n\tUstrIxAAdtPRuoBgV8qsSWndkPuAGzXUOzdYLPs3dsmGzL2xdyz4Oo2KQQmmVW/byyCS\n\t4cag==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=5Y4fb2QvLTTO0o38qmXh6+NqvCrTLkTYOPSmgk4t/3o=;\n\tb=S8ZXd/9FJZJ9FwEL/tcjpKXcikya/5QTsnsPZGvZ1GN+BmiYT6xSsS79AU+9oWduNW\n\tqtOtT12gLUPsJjKJnz1mG//LZS0CN6/V7mHB751FJj5THrovgMyR5RPZW/NOlpFvLdrK\n\tDXKsqWwuqqwSMsa7BP9+IYh98t67pZTsk22vbb29Mh523X0MXaGgHf3YclxSTbwE9TUC\n\tbfDB50+NzUX6FwrVaGbAmddcJwZfCZUv3zspMcW6RlutyzzUHgT49SIzhLZ6HzPSQjRs\n\tnnXj2fJ+rUr3GK/wewSzyyu/hzASBmVBmcxB530gzK7l4Hr5w6WZQB9RpWI9rAOU4o48\n\tlulQ==","X-Gm-Message-State":"AHPjjUhLfFI0gBf5NlBkTErCtqIFPfjguGhu0rENDHhA4VJ5qpkp5nI1\n\tPniEPPIixEKxBrILb5x+F3TmuvNOp258","X-Google-Smtp-Source":"ADKCNb7GiSGGeGMTEwmx69SxSOfdLRHMym0m9NwpqcZ77exLqJiGLdCAneVbKfc1gI5HQ2hgrJQS1lxDuYVEqGO6Hck=","X-Received":"by 10.55.98.19 with SMTP id w19mr2388279qkb.261.1504685951754;\n\tWed, 06 Sep 2017 01:19:11 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"","References":"<20170906003016.2159-1-brendanhiggins@google.com>\n\t<20170906003016.2159-3-brendanhiggins@google.com>\n\t","From":"Brendan Higgins ","Date":"Wed, 6 Sep 2017 01:19:11 -0700","Message-ID":"","Subject":"Re: [PATCH v3 2/3] arm: dts: add Nuvoton NPCM750 device tree","To":"Joel Stanley ","Cc":"Rob Herring , Mark Rutland ,\n\tRussell King , avifishman70@gmail.com,\n\ttmaimon77@gmail.com, Rick Altherr ,\n\tFlorian Fainelli ,\n\tdevicetree ,\n\tLinux Kernel Mailing List ,\n\tlinux-arm-kernel@lists.infradead.org,\n\tOpenBMC Maillist ","Content-Type":"text/plain; charset=\"UTF-8\"","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}}]