[{"id":1766262,"web_url":"http://patchwork.ozlabs.org/comment/1766262/","msgid":"","list_archive_url":null,"date":"2017-09-11T11:56:18","subject":"Re: [Qemu-devel] [RFC v1 2/2] netduino2: Specify the valid CPUs","submitter":{"id":71889,"url":"http://patchwork.ozlabs.org/api/people/71889/","name":"KONRAD Frederic","email":"frederic.konrad@adacore.com"},"content":"On 09/06/2017 02:12 AM, Alistair Francis wrote:\n> Signed-off-by: Alistair Francis \n> ---\n> \n> hw/arm/netduino2.c | 5 +++++\n> 1 file changed, 5 insertions(+)\n> \n> diff --git a/hw/arm/netduino2.c b/hw/arm/netduino2.c\n> index 3cfe332dd1..accca344fd 100644\n> --- a/hw/arm/netduino2.c\n> +++ b/hw/arm/netduino2.c\n> @@ -43,8 +43,13 @@ static void netduino2_init(MachineState *machine)\n> \n> static void netduino2_machine_init(MachineClass *mc)\n> {\n> + const char *val = \"cortex-m3\";\n> +\n> mc->desc = \"Netduino 2 Machine\";\n> mc->init = netduino2_init;\n> +\n> + mc->valid_cpu_types = g_array_new(false, false, sizeof(char *));\n> + g_array_append_val(mc->valid_cpu_types, val);\n> }\n\nHi Alistair,\n\nNice idea! Why not adding an helper function which take a const\nchar** in argument?\n\nFred\n\n> \n> DEFINE_MACHINE(\"netduino2\", netduino2_machine_init)\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xrRv40FQpz9s71\n\tfor ;\n\tMon, 11 Sep 2017 22:24:32 +1000 (AEST)","from localhost ([::1]:57311 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1drNVs-0006Nl-1h\n\tfor incoming@patchwork.ozlabs.org; Mon, 11 Sep 2017 08:08:28 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:60687)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1drNKB-0005M3-CO\n\tfor qemu-devel@nongnu.org; Mon, 11 Sep 2017 07:56:29 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1drNKA-0001Ya-Hc\n\tfor qemu-devel@nongnu.org; Mon, 11 Sep 2017 07:56:23 -0400","from mel.act-europe.fr ([2a02:2ab8:224:1::a0a:d2]:38218\n\thelo=smtp.eu.adacore.com)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1drNKA-0001XA-B8\n\tfor qemu-devel@nongnu.org; Mon, 11 Sep 2017 07:56:22 -0400","from localhost (localhost [127.0.0.1])\n\tby filtered-smtp.eu.adacore.com (Postfix) with ESMTP id EC439822E1;\n\tMon, 11 Sep 2017 13:56:19 +0200 (CEST)","from smtp.eu.adacore.com ([127.0.0.1])\n\tby localhost (smtp.eu.adacore.com [127.0.0.1]) (amavisd-new,\n\tport 10024)\n\twith ESMTP id ghRd5w5RbvKX; Mon, 11 Sep 2017 13:56:19 +0200 (CEST)","from localhost.localdomain (unknown\n\t[IPv6:2a01:e35:87f0:3180:2b18:7e65:c33:7f62])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128\n\tbits)) (No client certificate requested)\n\tby smtp.eu.adacore.com (Postfix) with ESMTPSA id 21DD3822CE;\n\tMon, 11 Sep 2017 13:56:19 +0200 (CEST)"],"X-Virus-Scanned":"Debian amavisd-new at eu.adacore.com","To":"Alistair Francis ","References":"\n\t<16cf589bc0c0431fbba6bbed8d1a50b49d24e867.1504656490.git.alistair.francis@xilinx.com>","From":"KONRAD Frederic ","Message-ID":"","Date":"Mon, 11 Sep 2017 13:56:18 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<16cf589bc0c0431fbba6bbed8d1a50b49d24e867.1504656490.git.alistair.francis@xilinx.com>","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 3.x","X-Received-From":"2a02:2ab8:224:1::a0a:d2","Subject":"Re: [Qemu-devel] [RFC v1 2/2] netduino2: Specify the valid CPUs","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"marcel@redhat.com, alistair23@gmail.com, qemu-devel@nongnu.org,\n\tehabkost@redhat.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1773168,"web_url":"http://patchwork.ozlabs.org/comment/1773168/","msgid":"","list_archive_url":null,"date":"2017-09-21T23:07:31","subject":"Re: [Qemu-devel] [RFC v1 2/2] netduino2: Specify the valid CPUs","submitter":{"id":47878,"url":"http://patchwork.ozlabs.org/api/people/47878/","name":"Alistair Francis","email":"alistair.francis@xilinx.com"},"content":"On Mon, Sep 11, 2017 at 4:56 AM, KONRAD Frederic\n wrote:\n>\n>\n> On 09/06/2017 02:12 AM, Alistair Francis wrote:\n>>\n>> Signed-off-by: Alistair Francis \n>> ---\n>>\n>> hw/arm/netduino2.c | 5 +++++\n>> 1 file changed, 5 insertions(+)\n>>\n>> diff --git a/hw/arm/netduino2.c b/hw/arm/netduino2.c\n>> index 3cfe332dd1..accca344fd 100644\n>> --- a/hw/arm/netduino2.c\n>> +++ b/hw/arm/netduino2.c\n>> @@ -43,8 +43,13 @@ static void netduino2_init(MachineState *machine)\n>> static void netduino2_machine_init(MachineClass *mc)\n>> {\n>> + const char *val = \"cortex-m3\";\n>> +\n>> mc->desc = \"Netduino 2 Machine\";\n>> mc->init = netduino2_init;\n>> +\n>> + mc->valid_cpu_types = g_array_new(false, false, sizeof(char *));\n>> + g_array_append_val(mc->valid_cpu_types, val);\n>> }\n>\n>\n> Hi Alistair,\n>\n> Nice idea! Why not adding an helper function which take a const\n> char** in argument?\n\nThanks Fred.\n\nI'm going to send a v2 with just that :)\n\nThanks,\nAlistair\n\n>\n> Fred\n>\n>> DEFINE_MACHINE(\"netduino2\", netduino2_machine_init)\n>>\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"CCdXRPO/\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xysk23VmQz9t2S\n\tfor ;\n\tFri, 22 Sep 2017 09:08:58 +1000 (AEST)","from localhost ([::1]:55820 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dvAaW-0005M6-EJ\n\tfor incoming@patchwork.ozlabs.org; Thu, 21 Sep 2017 19:08:56 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:33765)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dvAZg-0005Kq-4l\n\tfor qemu-devel@nongnu.org; Thu, 21 Sep 2017 19:08:05 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dvAZe-0000rZ-VO\n\tfor qemu-devel@nongnu.org; Thu, 21 Sep 2017 19:08:04 -0400","from mail-wm0-x243.google.com ([2a00:1450:400c:c09::243]:38153)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from )\n\tid 1dvAZe-0000pm-PI\n\tfor qemu-devel@nongnu.org; Thu, 21 Sep 2017 19:08:02 -0400","by mail-wm0-x243.google.com with SMTP id x17so6405476wmd.5\n\tfor ; Thu, 21 Sep 2017 16:08:02 -0700 (PDT)","by 10.28.191.130 with HTTP; Thu, 21 Sep 2017 16:07:31 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc;\n\tbh=YdoMx29TbwvMo21DZuuIDdXSjdCvEf4qgUstrK7uji8=;\n\tb=CCdXRPO/a0W/iZNR7MzglkURJAfeS88iuccF3DJ0+uqLPeIfqXy/9i1SPyuF7eNhe8\n\tUM5HN+4ERe5Pu6V+WKyEZ+QeB+sN2xA7uZMFZZSfo4EIpLvmkfknfLL+g1hJ2kd25Rc0\n\tMzG/JBdlpifMjyZE7TY38Q3WZBsbre++RbZ2x0sEVLr59hA+mqYb1FEFUXw8Ham/IPvb\n\tlz5eBnyA8IvLL9J21w1MQmK/1snOrNt5HrCYGRrVyW6fLqiLdael5f6pZx/4iFwf29+F\n\tDz5VxLPhlAGkopQtMTOsDTHNij8J97M/wMO4z70K5u2LmficPxg3mRqqMSbt9JnftuKs\n\t9HlQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:sender:in-reply-to:references:from\n\t:date:message-id:subject:to:cc;\n\tbh=YdoMx29TbwvMo21DZuuIDdXSjdCvEf4qgUstrK7uji8=;\n\tb=uGReH1yzljYrRDtJMjGXp5oyAwdNy/yMiwF7rkrThvjysUKfvnBdzYC7mI99J09fHV\n\tL6LlvXBIeyQN2u2qxhCme/PhzuzRpSPvYzwtFaAdXj9wRpa1dfb/2Vl8Tkhiwr0XxpbU\n\tc/zJNKBFFOk7D11g/VmN6SZdFf3ufMG9kSJAX0leklycXBzYMJ6wc2zJ/f2hku84B+rV\n\tVsE1Attl47FdtYG669qFWyKDrVlILiourRADLvfP4ISQl8oTI/ZuGGcEQX/zooB9weJj\n\tzVMyO2/jwXcRhiXBxgQBugj8TJrGT8F8dJHLfr2IXAyrq68YWnpCG50Yk87f/YDxpFws\n\tXSAw==","X-Gm-Message-State":"AHPjjUiH8oj8+Jjim3mKROiIj/V+qxMsma80bONHlcV/s46pWjAqfzEc\n\tj3gVUm71nhy64mykFCIIWct27hOT6o3ndEaLIXo=","X-Google-Smtp-Source":"AOwi7QCSM5o0gD/BBSaRcQhvksCf+9UZr/vtxcFHYxfEwVUDkQQFWQPvJHSDY1vn5jdwVS5oPIKYZWB9uxSm+Cpph7M=","X-Received":"by 10.28.135.209 with SMTP id j200mr2116735wmd.40.1506035281819; \n\tThu, 21 Sep 2017 16:08:01 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"","References":"\n\t<16cf589bc0c0431fbba6bbed8d1a50b49d24e867.1504656490.git.alistair.francis@xilinx.com>\n\t","From":"Alistair Francis ","Date":"Thu, 21 Sep 2017 16:07:31 -0700","X-Google-Sender-Auth":"firy3kk5sPsSjb3AP3QAqwFyUOw","Message-ID":"","To":"KONRAD Frederic ","Content-Type":"text/plain; charset=\"UTF-8\"","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2a00:1450:400c:c09::243","Subject":"Re: [Qemu-devel] [RFC v1 2/2] netduino2: Specify the valid CPUs","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Marcel Apfelbaum ,\n\t\"qemu-devel@nongnu.org Developers\" ,\n\tEduardo Habkost ,\n\tAlistair Francis ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]