[{"id":1763791,"web_url":"http://patchwork.ozlabs.org/comment/1763791/","msgid":"","list_archive_url":null,"date":"2017-09-06T02:47:21","subject":"Re: [ovs-dev] [PATCH] datapath-windows: Increment ct packet\n\tcounters\tbased on ct_state.","submitter":{"id":69910,"url":"http://patchwork.ozlabs.org/api/people/69910/","name":"Shashank Ram","email":"rams@vmware.com"},"content":"Comments inline.","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","ovs-dev@mail.linuxfoundation.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=onevmw.onmicrosoft.com\n\theader.i=@onevmw.onmicrosoft.com header.b=\"A86Kove2\"; \n\tdkim-atps=neutral","spf=none (sender IP is )\n\tsmtp.mailfrom=rams@vmware.com; "],"Received":["from mail.linuxfoundation.org (mail.linuxfoundation.org\n\t[140.211.169.12])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xn7Lj2cRgz9t2R\n\tfor ;\n\tWed, 6 Sep 2017 12:48:29 +1000 (AEST)","from mail.linux-foundation.org (localhost [127.0.0.1])\n\tby mail.linuxfoundation.org (Postfix) with ESMTP id 0620DAB6;\n\tWed, 6 Sep 2017 02:47:27 +0000 (UTC)","from smtp1.linuxfoundation.org (smtp1.linux-foundation.org\n\t[172.17.192.35])\n\tby mail.linuxfoundation.org (Postfix) with ESMTPS id B0093AB6\n\tfor ; Wed, 6 Sep 2017 02:47:25 +0000 (UTC)","from NAM02-CY1-obe.outbound.protection.outlook.com\n\t(mail-cys01nam02on0082.outbound.protection.outlook.com\n\t[104.47.37.82])\n\tby smtp1.linuxfoundation.org (Postfix) with ESMTPS id 379F1140\n\tfor ; Wed, 6 Sep 2017 02:47:25 +0000 (UTC)","from BY2PR0501MB2119.namprd05.prod.outlook.com (10.163.198.17) by\n\tBY2PR0501MB1765.namprd05.prod.outlook.com (10.163.154.27) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id\n\t15.20.35.3; Wed, 6 Sep 2017 02:47:22 +0000","from BY2PR0501MB2119.namprd05.prod.outlook.com ([10.163.198.17]) by\n\tBY2PR0501MB2119.namprd05.prod.outlook.com ([10.163.198.17]) with\n\tmapi id 15.20.0035.010; Wed, 6 Sep 2017 02:47:21 +0000"],"X-Greylist":"whitelisted by SQLgrey-1.7.6","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=onevmw.onmicrosoft.com; s=selector1-vmware-com;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version;\n\tbh=ZoLhOINnXA7WDOdwFGgTLGykNbt79vF7q/F3wafvQeQ=;\n\tb=A86Kove2vEKQ6ZE5zO6AQsvyjKK97siQfjY7t7YABC9G4p2s5Zfbo0hAD+pc6haLGxBl+z7o1397x+qb1vA2q75iEqBctKAvbkNDWLS7HvdeD6v2B2WSmdQVdg4zwPM7HCQn9t7UTFiPdIFtTEdyuzI+0XdD+HTVStg6U1bQEjY=","From":"Shashank Ram ","To":"Anand Kumar , \"dev@openvswitch.org\"\n\t","Thread-Topic":"[ovs-dev] [PATCH] datapath-windows: Increment ct packet\n\tcounters based on ct_state.","Thread-Index":"AQHTJqI0dIt4FsLly023Gl4jOdU2+6KnJlSb","Date":"Wed, 6 Sep 2017 02:47:21 +0000","Message-ID":"","References":"<20170905235304.4016-1-kumaranand@vmware.com>","In-Reply-To":"<20170905235304.4016-1-kumaranand@vmware.com>","Accept-Language":"en-US","Content-Language":"en-US","X-MS-Has-Attach":"","X-MS-TNEF-Correlator":"","x-originating-ip":"[174.62.106.255]","x-ms-publictraffictype":"Email","x-microsoft-exchange-diagnostics":"1; BY2PR0501MB1765;\n\t20:oRiHlGIdjkb/mI83qh9Avmjhjqlnw9R7S46HLPWXvlRTNcQvAcmLjQBNoM7L01sQpx96SBtDQMPWmZY4X/qHB0rtHlN3EFMBjfmZ3a2kzgYFZxPbsPpFf6sDs7o6AoJfpGnlM2FHdW2g6Y/HP0GpGr1pp+Za4hu3CcBj3TGLJkw=","x-ms-exchange-antispam-srfa-diagnostics":"SSOS;SSOR;","x-forefront-antispam-report":"SFV:SKI; SCL:-1; SFV:NSPM;\n\tSFS:(10009020)(6009001)(199003)(189002)(6246003)(2900100001)(76176999)(54356999)(50986999)(2906002)(7696004)(68736007)(33656002)(106356001)(6506006)(77096006)(6436002)(101416001)(14454004)(105586002)(2501003)(6116002)(229853002)(25786009)(74316002)(53936002)(8936002)(3660700001)(81156014)(81166006)(5660300001)(305945005)(97736004)(478600001)(189998001)(66066001)(86362001)(3280700002)(3846002)(9686003)(102836003)(2950100002)(55016002)(7736002)(99286003)(7756004);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:BY2PR0501MB1765;\n\tH:BY2PR0501MB2119.namprd05.prod.outlook.com; FPR:; SPF:None;\n\tPTR:InfoNoRecords; A:1; MX:1; LANG:en; ","x-ms-office365-filtering-correlation-id":"3568f2d7-bb4c-40b8-ec81-08d4f4d198e6","x-microsoft-antispam":"UriScan:; BCL:0; PCL:0;\n\tRULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(300000503095)(300135400095)(2017052603199)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);\n\tSRVR:BY2PR0501MB1765; ","x-ms-traffictypediagnostic":"BY2PR0501MB1765:","authentication-results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=onevmw.onmicrosoft.com\n\theader.i=@onevmw.onmicrosoft.com header.b=\"A86Kove2\"; \n\tdkim-atps=neutral","spf=none (sender IP is )\n\tsmtp.mailfrom=rams@vmware.com; "],"x-exchange-antispam-report-test":"UriScan:(61668805478150);","x-microsoft-antispam-prvs":"","x-exchange-antispam-report-cfa-test":"BCL:0; PCL:0;\n\tRULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(10201501046)(100000703101)(100105400095)(93006095)(93001095)(3002001)(6041248)(20161123560025)(20161123562025)(20161123558100)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123564025)(20161123555025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);\n\tSRVR:BY2PR0501MB1765; BCL:0; PCL:0;\n\tRULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);\n\tSRVR:BY2PR0501MB1765; ","x-forefront-prvs":"0422860ED4","received-spf":"None (protection.outlook.com: vmware.com does not designate\n\tpermitted sender hosts)","spamdiagnosticoutput":"1:99","spamdiagnosticmetadata":"NSPM","MIME-Version":"1.0","X-OriginatorOrg":"vmware.com","X-MS-Exchange-CrossTenant-originalarrivaltime":"06 Sep 2017 02:47:21.4976\n\t(UTC)","X-MS-Exchange-CrossTenant-fromentityheader":"Hosted","X-MS-Exchange-CrossTenant-id":"b39138ca-3cee-4b4a-a4d6-cd83d9dd62f0","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"BY2PR0501MB1765","X-Spam-Status":"No, score=0.0 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,\n\tRCVD_IN_DNSWL_NONE autolearn=disabled version=3.3.1","X-Spam-Checker-Version":"SpamAssassin 3.3.1 (2010-03-16) on\n\tsmtp1.linux-foundation.org","Subject":"Re: [ovs-dev] [PATCH] datapath-windows: Increment ct packet\n\tcounters\tbased on ct_state.","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.12","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"ovs-dev-bounces@openvswitch.org","Errors-To":"ovs-dev-bounces@openvswitch.org"}},{"id":1764286,"web_url":"http://patchwork.ozlabs.org/comment/1764286/","msgid":"","list_archive_url":null,"date":"2017-09-06T17:46:41","subject":"Re: [ovs-dev] [PATCH] datapath-windows: Increment ct\n\tpacket\tcounters\tbased on ct_state.","submitter":{"id":69910,"url":"http://patchwork.ozlabs.org/api/people/69910/","name":"Shashank Ram","email":"rams@vmware.com"},"content":"I guess the Conntrack code is intentionally styled similar to the user space code with the idea of sharing it. I am not sure if this is realistic or even possible now, given that the entire Conntrack code is re-written for the Windows data path. If there is not going to be any code sharing, it does not make sense to style the CT code differently than the rest of the Windows data path code.\n---\n\nAcked-by: Shashank Ram","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","ovs-dev@mail.linuxfoundation.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=onevmw.onmicrosoft.com\n\theader.i=@onevmw.onmicrosoft.com header.b=\"KxV+j2Ew\"; \n\tdkim-atps=neutral","spf=none (sender IP is )\n\tsmtp.mailfrom=rams@vmware.com; "],"Received":["from mail.linuxfoundation.org (mail.linuxfoundation.org\n\t[140.211.169.12])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xnWHD61Mlz9s81\n\tfor ;\n\tThu, 7 Sep 2017 03:46:48 +1000 (AEST)","from mail.linux-foundation.org (localhost [127.0.0.1])\n\tby mail.linuxfoundation.org (Postfix) with ESMTP id 2BD5BAC9;\n\tWed, 6 Sep 2017 17:46:46 +0000 (UTC)","from smtp1.linuxfoundation.org (smtp1.linux-foundation.org\n\t[172.17.192.35])\n\tby mail.linuxfoundation.org (Postfix) with ESMTPS id 3255C96F\n\tfor ; Wed, 6 Sep 2017 17:46:45 +0000 (UTC)","from NAM02-SN1-obe.outbound.protection.outlook.com\n\t(mail-sn1nam02on0075.outbound.protection.outlook.com [104.47.36.75])\n\tby smtp1.linuxfoundation.org (Postfix) with ESMTPS id 21B22467\n\tfor ; Wed, 6 Sep 2017 17:46:44 +0000 (UTC)","from BY2PR0501MB2119.namprd05.prod.outlook.com (10.163.198.17) by\n\tBY2PR0501MB1734.namprd05.prod.outlook.com (10.163.154.20) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id\n\t15.20.35.3; Wed, 6 Sep 2017 17:46:42 +0000","from BY2PR0501MB2119.namprd05.prod.outlook.com ([10.163.198.17]) by\n\tBY2PR0501MB2119.namprd05.prod.outlook.com ([10.163.198.17]) with\n\tmapi id 15.20.0035.010; Wed, 6 Sep 2017 17:46:41 +0000"],"X-Greylist":"whitelisted by SQLgrey-1.7.6","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=onevmw.onmicrosoft.com; s=selector1-vmware-com;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version;\n\tbh=rpkhCkzsH/xKqeZQjPN+T7hh/U81/ZPFH7tgXZfasbg=;\n\tb=KxV+j2EwsF9D0M5frJxFdeWPrrdJKohmlZBum00p5u4QDr5PVoUUxOZBxpRiwpkfmdrIH7/TVGfboAZ79vfdWLllIf43uSQCOtS8KYhPXDCgJ5XVMonUCJnkMW7i22Nz3QQ0IxWLtF/NkfejjwYfOqSe2NhAbp+MmGeb+VKl9/g=","From":"Shashank Ram ","To":"Anand Kumar , \"dev@openvswitch.org\"\n\t","Thread-Topic":"[ovs-dev] [PATCH] datapath-windows: Increment ct\n\tpacket\tcounters based on ct_state.","Thread-Index":"AQHTJzgYVyycW5jON0a58lfjNBlYmg==","Date":"Wed, 6 Sep 2017 17:46:41 +0000","Message-ID":"","References":"<20170905235304.4016-1-kumaranand@vmware.com>,\n\t","In-Reply-To":"","Accept-Language":"en-US","Content-Language":"en-US","X-MS-Has-Attach":"","X-MS-TNEF-Correlator":"","authentication-results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=onevmw.onmicrosoft.com\n\theader.i=@onevmw.onmicrosoft.com header.b=\"KxV+j2Ew\"; \n\tdkim-atps=neutral","spf=none (sender IP is )\n\tsmtp.mailfrom=rams@vmware.com; "],"x-originating-ip":"[208.91.1.34]","x-ms-publictraffictype":"Email","x-microsoft-exchange-diagnostics":"1; BY2PR0501MB1734;\n\t20:gQh+sNKqfTpEue01iB+POxNcdS6vCGaOEce8mxz85N/A/Sv7wmzoI8pZxBVjupsqL33XELLwVnnlz+gAtXq6WW1fODQ+AyPXawjDyY5CmpDUn8tvNZI03z836Zio7EgaMfOP2giZ++mn1wTiplBoTxqQlpNA4cs374nObsCzH5M=","x-ms-exchange-antispam-srfa-diagnostics":"SSOS;SSOR;","x-forefront-antispam-report":"SFV:SKI; SCL:-1; SFV:NSPM;\n\tSFS:(10009020)(6009001)(377454003)(189002)(199003)(5660300001)(97736004)(2940100002)(81166006)(53936002)(81156014)(77096006)(189998001)(106356001)(2950100002)(2501003)(478600001)(3280700002)(8936002)(3660700001)(68736007)(76176999)(25786009)(53546010)(66066001)(101416001)(2900100001)(54356999)(50986999)(6116002)(55016002)(6506006)(99286003)(966005)(102836003)(86362001)(74316002)(3846002)(6436002)(229853002)(2906002)(14454004)(6246003)(9686003)(7696004)(6306002)(305945005)(7736002)(33656002)(105586002);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:BY2PR0501MB1734;\n\tH:BY2PR0501MB2119.namprd05.prod.outlook.com; FPR:; SPF:None;\n\tPTR:InfoNoRecords; MX:1; A:1; LANG:en; ","x-ms-office365-filtering-correlation-id":"e35bd6fb-b127-4582-2078-08d4f54f3b5d","x-microsoft-antispam":"UriScan:; BCL:0; PCL:0;\n\tRULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(300000503095)(300135400095)(2017052603199)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);\n\tSRVR:BY2PR0501MB1734; ","x-ms-traffictypediagnostic":"BY2PR0501MB1734:","x-exchange-antispam-report-test":"UriScan:(61668805478150)(10436049006162)(216315784871565); ","x-microsoft-antispam-prvs":"","x-exchange-antispam-report-cfa-test":"BCL:0; PCL:0;\n\tRULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(3002001)(10201501046)(93006095)(93001095)(100000703101)(100105400095)(6041248)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123564025)(20161123558100)(20161123555025)(20161123562025)(20161123560025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);\n\tSRVR:BY2PR0501MB1734; BCL:0; PCL:0;\n\tRULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);\n\tSRVR:BY2PR0501MB1734; ","x-forefront-prvs":"0422860ED4","received-spf":"None (protection.outlook.com: vmware.com does not designate\n\tpermitted sender hosts)","spamdiagnosticoutput":"1:99","spamdiagnosticmetadata":"NSPM","MIME-Version":"1.0","X-OriginatorOrg":"vmware.com","X-MS-Exchange-CrossTenant-originalarrivaltime":"06 Sep 2017 17:46:41.0762\n\t(UTC)","X-MS-Exchange-CrossTenant-fromentityheader":"Hosted","X-MS-Exchange-CrossTenant-id":"b39138ca-3cee-4b4a-a4d6-cd83d9dd62f0","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"BY2PR0501MB1734","X-Spam-Status":"No, score=0.0 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,\n\tRCVD_IN_DNSWL_NONE autolearn=disabled version=3.3.1","X-Spam-Checker-Version":"SpamAssassin 3.3.1 (2010-03-16) on\n\tsmtp1.linux-foundation.org","Subject":"Re: [ovs-dev] [PATCH] datapath-windows: Increment ct\n\tpacket\tcounters\tbased on ct_state.","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.12","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"ovs-dev-bounces@openvswitch.org","Errors-To":"ovs-dev-bounces@openvswitch.org"}},{"id":1764864,"web_url":"http://patchwork.ozlabs.org/comment/1764864/","msgid":"","list_archive_url":null,"date":"2017-09-07T17:55:01","subject":"Re: [ovs-dev] [PATCH] datapath-windows: Increment ct packet\n\tcounters based on ct_state.","submitter":{"id":67182,"url":"http://patchwork.ozlabs.org/api/people/67182/","name":"Sairam Venugopal","email":"vsairam@vmware.com"},"content":"Acked-by: Sairam Venugopal \n\n\n\n\n\nOn 9/5/17, 4:53 PM, \"ovs-dev-bounces@openvswitch.org on behalf of Anand Kumar\" wrote:\n\n>For a given packet, packet counters in conntrack should be accounted only\n>once, even if the packet is processed multiple times by conntrack.\n>\n>When a packet is processed by conntrack, ct_state flag is set to\n>OVS_CS_F_TRACKED. Use this state to identify if a packet has been\n>processed previously by conntrack.\n>\n>Also update the ct packet counters when ct entry is created.\n>\n>With this patch, the conntrack's packet counters behavior is similar\n>to linux\n>\n>Signed-off-by: Anand Kumar \n>---\n> datapath-windows/ovsext/Conntrack.c | 34 +++++++++++++++++++++-------------\n> 1 file changed, 21 insertions(+), 13 deletions(-)\n>\n>diff --git a/datapath-windows/ovsext/Conntrack.c b/datapath-windows/ovsext/Conntrack.c\n>index 8bcda05..0adb6d5 100644\n>--- a/datapath-windows/ovsext/Conntrack.c\n>+++ b/datapath-windows/ovsext/Conntrack.c\n>@@ -169,6 +169,18 @@ OvsPostCtEventEntry(POVS_CT_ENTRY entry, UINT8 type)\n> OvsPostCtEvent(&ctEventEntry);\n> }\n> \n>+static __inline VOID\n>+OvsCtIncrementCounters(POVS_CT_ENTRY entry, BOOLEAN reply, PNET_BUFFER_LIST nbl)\n>+{\n>+ if (reply) {\n>+ entry->rev_key.byteCount+= OvsPacketLenNBL(nbl);\n>+ entry->rev_key.packetCount++;\n>+ } else {\n>+ entry->key.byteCount += OvsPacketLenNBL(nbl);\n>+ entry->key.packetCount++;\n>+ }\n>+}\n>+\n> static __inline BOOLEAN\n> OvsCtAddEntry(POVS_CT_ENTRY entry, OvsConntrackKeyLookupCtx *ctx,\n> PNAT_ACTION_INFO natInfo, UINT64 now)\n>@@ -287,6 +299,9 @@ OvsCtEntryCreate(OvsForwardingContext *fwdCtx,\n> }\n> \n> OvsCtUpdateFlowKey(key, state, ctx->key.zone, 0, NULL);\n>+ if (entry) {\n>+ OvsCtIncrementCounters(entry, ctx->reply, curNbl);\n>+ }\n> return entry;\n> }\n> \n>@@ -382,18 +397,6 @@ OvsCtKeyAreSame(OVS_CT_KEY ctxKey, OVS_CT_KEY entryKey)\n> (ctxKey.zone == entryKey.zone));\n> }\n> \n>-static __inline VOID\n>-OvsCtIncrementCounters(POVS_CT_ENTRY entry, BOOLEAN reply, PNET_BUFFER_LIST nbl)\n>-{\n>- if (reply) {\n>- entry->rev_key.byteCount+= OvsPacketLenNBL(nbl);\n>- entry->rev_key.packetCount++;\n>- } else {\n>- entry->key.byteCount += OvsPacketLenNBL(nbl);\n>- entry->key.packetCount++;\n>- }\n>-}\n>-\n> POVS_CT_ENTRY\n> OvsCtLookup(OvsConntrackKeyLookupCtx *ctx)\n> {\n>@@ -730,6 +733,12 @@ OvsCtExecute_(OvsForwardingContext *fwdCtx,\n> NdisReleaseRWLock(ovsConntrackLockObj, &lockState);\n> OVS_LOG_ERROR(\"Conntrack Limit hit: %lu\", ctTotalEntries);\n> return NDIS_STATUS_RESOURCES;\n>+\n>+ /* Increment the counters soon after the lookup, since we set ct.state\n>+ * to OVS_CS_F_TRACKED after processing the ct entry.\n>+ */\n>+ if (entry && (!(key->ct.state & OVS_CS_F_TRACKED))) {\n>+ OvsCtIncrementCounters(entry, ctx.reply, curNbl);\n> }\n> \n> if (!entry) {\n>@@ -740,7 +749,6 @@ OvsCtExecute_(OvsForwardingContext *fwdCtx,\n> &entryCreated);\n> } else {\n> /* Process the entry and update CT flags */\n>- OvsCtIncrementCounters(entry, ctx.reply, curNbl);\n> entry = OvsProcessConntrackEntry(fwdCtx, layers->l4Offset, &ctx, key,\n> zone, natInfo, commit, currentTime,\n> &entryCreated);\n>-- \n>2.9.3.windows.1\n>\n>_______________________________________________\n>dev mailing list\n>dev@openvswitch.org\n>https://urldefense.proofpoint.com/v2/url?u=https-3A__mail.openvswitch.org_mailman_listinfo_ovs-2Ddev&d=DwICAg&c=uilaK90D4TOVoH58JNXRgQ&r=Z6vowHUOjP5ysP_g372c49Nqc1vEKqHKNBkR5Q5Z7uo&m=UUkY3ld1vxNjRMbNPm79bHFxEAWK0F9-VhuWaYlU0KM&s=W9Yf7wNSiWN-x1a9C_wSYqDGpCswFcmcyoNzE8rpuwk&e=","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","ovs-dev@mail.linuxfoundation.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=onevmw.onmicrosoft.com\n\theader.i=@onevmw.onmicrosoft.com header.b=\"N5782qD/\"; \n\tdkim-atps=neutral","spf=none (sender IP is )\n\tsmtp.mailfrom=vsairam@vmware.com; "],"Received":["from mail.linuxfoundation.org (mail.linuxfoundation.org\n\t[140.211.169.12])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xp7R52Qp9z9t2R\n\tfor ;\n\tFri, 8 Sep 2017 03:55:45 +1000 (AEST)","from mail.linux-foundation.org (localhost [127.0.0.1])\n\tby mail.linuxfoundation.org (Postfix) with ESMTP id 29910BC3;\n\tThu, 7 Sep 2017 17:55:06 +0000 (UTC)","from smtp1.linuxfoundation.org (smtp1.linux-foundation.org\n\t[172.17.192.35])\n\tby mail.linuxfoundation.org (Postfix) with ESMTPS id E4E5EBC2\n\tfor ; Thu, 7 Sep 2017 17:55:04 +0000 (UTC)","from NAM03-CO1-obe.outbound.protection.outlook.com\n\t(mail-co1nam03on0088.outbound.protection.outlook.com [104.47.40.88])\n\tby smtp1.linuxfoundation.org (Postfix) with ESMTPS id 1B2AC8A\n\tfor ; Thu, 7 Sep 2017 17:55:04 +0000 (UTC)","from CO2PR0501MB823.namprd05.prod.outlook.com (10.141.244.145) by\n\tCO2PR0501MB1014.namprd05.prod.outlook.com (10.160.10.151) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id\n\t15.20.35.3; Thu, 7 Sep 2017 17:55:02 +0000","from CO2PR0501MB823.namprd05.prod.outlook.com ([10.141.244.145]) by\n\tCO2PR0501MB823.namprd05.prod.outlook.com ([10.141.244.145]) with\n\tmapi id 15.20.0035.010; Thu, 7 Sep 2017 17:55:01 +0000"],"X-Greylist":"whitelisted by SQLgrey-1.7.6","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=onevmw.onmicrosoft.com; s=selector1-vmware-com;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version;\n\tbh=7IypH/mzZK0S+slI9r1HEo2x+bFCnBaNJCiNBya4CIE=;\n\tb=N5782qD/57eHdCVaTGlm5BK6THCxdOMU3PXtZ+mD15yS3mUBWz28mAMJa38z1+YVRWP4YjvDHj0eLt7GiJg0FAN+lIEgRoTNIO90PlpSake5dksaYRW7+SWs9CWKjn17ouPuajg3XvQYrdSrOxDBAtlOvTVDi5hJsxRef8JgDQw=","From":"Sairam Venugopal ","To":"Anand Kumar , \"dev@openvswitch.org\"\n\t","Thread-Topic":"[ovs-dev] [PATCH] datapath-windows: Increment ct packet\n\tcounters based on ct_state.","Thread-Index":"AQHTKAJtis/4ixRfwUqpkh738PVmFg==","Date":"Thu, 7 Sep 2017 17:55:01 +0000","Message-ID":"","References":"<20170905235304.4016-1-kumaranand@vmware.com>","In-Reply-To":"<20170905235304.4016-1-kumaranand@vmware.com>","Accept-Language":"en-US","Content-Language":"en-US","X-MS-Has-Attach":"","X-MS-TNEF-Correlator":"","authentication-results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=onevmw.onmicrosoft.com\n\theader.i=@onevmw.onmicrosoft.com header.b=\"N5782qD/\"; \n\tdkim-atps=neutral","spf=none (sender IP is )\n\tsmtp.mailfrom=vsairam@vmware.com; "],"x-originating-ip":"[208.91.1.34]","x-ms-publictraffictype":"Email","x-microsoft-exchange-diagnostics":"1; CO2PR0501MB1014;\n\t20:+8xFvsPIHuSj+MAnmbLv7mBiFXduuvBmooP21t47ZM2K6Hi0AHHgIrN/QCU3f9BETNZ0JFyaE037eAS3+L3NNXk+3kIjTx/JEctjzngqCMJcEuq6dVSDXwkdH8rszWac0xbl87XxfvbsV5UxTC5B2wijHKvTA1MPJI7ITbieWVc=","x-ms-exchange-antispam-srfa-diagnostics":"SSOS;SSOR;","x-forefront-antispam-report":"SFV:SKI; SCL:-1; SFV:NSPM;\n\tSFS:(10009020)(979002)(6009001)(199003)(24454002)(189002)(377454003)(5660300001)(478600001)(6486002)(77096006)(6436002)(106356001)(6506006)(33656002)(8936002)(8676002)(105586002)(2501003)(25786009)(2906002)(3280700002)(81156014)(83716003)(81166006)(101416001)(3846002)(102836003)(6116002)(3660700001)(82746002)(575784001)(2900100001)(54356999)(86362001)(36756003)(50986999)(76176999)(99286003)(97736004)(189998001)(66066001)(53936002)(6306002)(6512007)(229853002)(305945005)(68736007)(6246003)(53546010)(14454004)(2950100002)(7736002)(969003)(989001)(999001)(1009001)(1019001);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:CO2PR0501MB1014;\n\tH:CO2PR0501MB823.namprd05.prod.outlook.com; FPR:; SPF:None;\n\tPTR:InfoNoRecords; A:1; MX:1; LANG:en; ","x-ms-office365-filtering-correlation-id":"1ee83f7e-7d48-4f92-baa7-08d4f6198ffb","x-microsoft-antispam":"UriScan:; BCL:0; PCL:0;\n\tRULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(300000503095)(300135400095)(2017052603199)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);\n\tSRVR:CO2PR0501MB1014; ","x-ms-traffictypediagnostic":"CO2PR0501MB1014:","x-exchange-antispam-report-test":"UriScan:(61668805478150)(10436049006162)(216315784871565); ","x-microsoft-antispam-prvs":"","x-exchange-antispam-report-cfa-test":"BCL:0; PCL:0;\n\tRULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(10201501046)(3002001)(93006095)(93001095)(100000703101)(100105400095)(6041248)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123560025)(20161123564025)(20161123562025)(20161123555025)(20161123558100)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);\n\tSRVR:CO2PR0501MB1014; BCL:0; PCL:0;\n\tRULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);\n\tSRVR:CO2PR0501MB1014; ","x-forefront-prvs":"04238CD941","received-spf":"None (protection.outlook.com: vmware.com does not designate\n\tpermitted sender hosts)","spamdiagnosticoutput":"1:99","spamdiagnosticmetadata":"NSPM","Content-ID":"<37B5CE67C1AB914A9613820F5AB4BE0B@namprd05.prod.outlook.com>","MIME-Version":"1.0","X-OriginatorOrg":"vmware.com","X-MS-Exchange-CrossTenant-originalarrivaltime":"07 Sep 2017 17:55:01.3837\n\t(UTC)","X-MS-Exchange-CrossTenant-fromentityheader":"Hosted","X-MS-Exchange-CrossTenant-id":"b39138ca-3cee-4b4a-a4d6-cd83d9dd62f0","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"CO2PR0501MB1014","X-Spam-Status":"No, score=0.0 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,\n\tRCVD_IN_DNSWL_NONE autolearn=disabled version=3.3.1","X-Spam-Checker-Version":"SpamAssassin 3.3.1 (2010-03-16) on\n\tsmtp1.linux-foundation.org","Subject":"Re: [ovs-dev] [PATCH] datapath-windows: Increment ct packet\n\tcounters based on ct_state.","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.12","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"ovs-dev-bounces@openvswitch.org","Errors-To":"ovs-dev-bounces@openvswitch.org"}},{"id":1764892,"web_url":"http://patchwork.ozlabs.org/comment/1764892/","msgid":"<000601d3280a$b35df6a0$1a19e3e0$@ovn.org>","list_archive_url":null,"date":"2017-09-07T18:54:13","subject":"Re: [ovs-dev] [PATCH] datapath-windows: Increment ct packet\n\tcounters\tbased on ct_state.","submitter":{"id":72181,"url":"http://patchwork.ozlabs.org/api/people/72181/","name":"Alin-Gabriel Serdean","email":"aserdean@ovn.org"},"content":"Acked-by: Alin Serdean \n\n> -----Original Message-----\n> From: ovs-dev-bounces@openvswitch.org [mailto:ovs-dev-\n> bounces@openvswitch.org] On Behalf Of Anand Kumar\n> Sent: Wednesday, September 6, 2017 2:53 AM\n> To: dev@openvswitch.org\n> Subject: [ovs-dev] [PATCH] datapath-windows: Increment ct packet counters\n> based on ct_state.\n> \n> For a given packet, packet counters in conntrack should be accounted only\n> once, even if the packet is processed multiple times by conntrack.\n> \n> When a packet is processed by conntrack, ct_state flag is set to\n> OVS_CS_F_TRACKED. Use this state to identify if a packet has been\n> processed previously by conntrack.\n> \n> Also update the ct packet counters when ct entry is created.\n> \n> With this patch, the conntrack's packet counters behavior is similar to\nlinux\n> \n> Signed-off-by: Anand Kumar \n> ---\n> datapath-windows/ovsext/Conntrack.c | 34 +++++++++++++++++++++-----\n> --------\n> 1 file changed, 21 insertions(+), 13 deletions(-)\n> \n> diff --git a/datapath-windows/ovsext/Conntrack.c b/datapath-\n> windows/ovsext/Conntrack.c\n> index 8bcda05..0adb6d5 100644\n> --- a/datapath-windows/ovsext/Conntrack.c\n> +++ b/datapath-windows/ovsext/Conntrack.c\n> @@ -169,6 +169,18 @@ OvsPostCtEventEntry(POVS_CT_ENTRY entry, UINT8\n> type)\n> OvsPostCtEvent(&ctEventEntry);\n> }\n> \n> +static __inline VOID\n> +OvsCtIncrementCounters(POVS_CT_ENTRY entry, BOOLEAN reply,\n> +PNET_BUFFER_LIST nbl) {\n> + if (reply) {\n> + entry->rev_key.byteCount+= OvsPacketLenNBL(nbl);\n> + entry->rev_key.packetCount++;\n> + } else {\n> + entry->key.byteCount += OvsPacketLenNBL(nbl);\n> + entry->key.packetCount++;\n> + }\n> +}\n> +\n> static __inline BOOLEAN\n> OvsCtAddEntry(POVS_CT_ENTRY entry, OvsConntrackKeyLookupCtx *ctx,\n> PNAT_ACTION_INFO natInfo, UINT64 now) @@ -287,6 +299,9 @@\n> OvsCtEntryCreate(OvsForwardingContext *fwdCtx,\n> }\n> \n> OvsCtUpdateFlowKey(key, state, ctx->key.zone, 0, NULL);\n> + if (entry) {\n> + OvsCtIncrementCounters(entry, ctx->reply, curNbl);\n> + }\n> return entry;\n> }\n> \n> @@ -382,18 +397,6 @@ OvsCtKeyAreSame(OVS_CT_KEY ctxKey,\n> OVS_CT_KEY entryKey)\n> (ctxKey.zone == entryKey.zone)); }\n> \n> -static __inline VOID\n> -OvsCtIncrementCounters(POVS_CT_ENTRY entry, BOOLEAN reply,\n> PNET_BUFFER_LIST nbl) -{\n> - if (reply) {\n> - entry->rev_key.byteCount+= OvsPacketLenNBL(nbl);\n> - entry->rev_key.packetCount++;\n> - } else {\n> - entry->key.byteCount += OvsPacketLenNBL(nbl);\n> - entry->key.packetCount++;\n> - }\n> -}\n> -\n> POVS_CT_ENTRY\n> OvsCtLookup(OvsConntrackKeyLookupCtx *ctx) { @@ -730,6 +733,12 @@\n> OvsCtExecute_(OvsForwardingContext *fwdCtx,\n> NdisReleaseRWLock(ovsConntrackLockObj, &lockState);\n> OVS_LOG_ERROR(\"Conntrack Limit hit: %lu\", ctTotalEntries);\n> return NDIS_STATUS_RESOURCES;\n> +\n> + /* Increment the counters soon after the lookup, since we set\nct.state\n> + * to OVS_CS_F_TRACKED after processing the ct entry.\n> + */\n> + if (entry && (!(key->ct.state & OVS_CS_F_TRACKED))) {\n> + OvsCtIncrementCounters(entry, ctx.reply, curNbl);\n> }\n> \n> if (!entry) {\n> @@ -740,7 +749,6 @@ OvsCtExecute_(OvsForwardingContext *fwdCtx,\n> &entryCreated);\n> } else {\n> /* Process the entry and update CT flags */\n> - OvsCtIncrementCounters(entry, ctx.reply, curNbl);\n> entry = OvsProcessConntrackEntry(fwdCtx, layers->l4Offset, &ctx,\nkey,\n> zone, natInfo, commit,\ncurrentTime,\n> &entryCreated);\n> --\n> 2.9.3.windows.1\n> \n> _______________________________________________\n> dev mailing list\n> dev@openvswitch.org\n> https://mail.openvswitch.org/mailman/listinfo/ovs-dev","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","ovs-dev@mail.linuxfoundation.org"],"Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=)","Received":["from mail.linuxfoundation.org (mail.linuxfoundation.org\n\t[140.211.169.12])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xp8kf55VFz9t2Q\n\tfor ;\n\tFri, 8 Sep 2017 04:54:17 +1000 (AEST)","from mail.linux-foundation.org (localhost [127.0.0.1])\n\tby mail.linuxfoundation.org (Postfix) with ESMTP id 13B73B5D;\n\tThu, 7 Sep 2017 18:54:16 +0000 (UTC)","from smtp1.linuxfoundation.org (smtp1.linux-foundation.org\n\t[172.17.192.35])\n\tby mail.linuxfoundation.org (Postfix) with ESMTPS id 1B1A2A64\n\tfor ; Thu, 7 Sep 2017 18:54:15 +0000 (UTC)","from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net\n\t[217.70.183.197])\n\tby smtp1.linuxfoundation.org (Postfix) with ESMTPS id 923A48A\n\tfor ; Thu, 7 Sep 2017 18:54:14 +0000 (UTC)","from cloudbasealin (unknown [79.114.121.216])\n\t(Authenticated sender: aserdean@ovn.org)\n\tby relay5-d.mail.gandi.net (Postfix) with ESMTPSA id 0532041C086;\n\tThu, 7 Sep 2017 20:54:12 +0200 (CEST)"],"X-Greylist":"domain auto-whitelisted by SQLgrey-1.7.6","X-Originating-IP":"79.114.121.216","From":"","To":"\"'Anand Kumar'\" ,\n\t","References":"<20170905235304.4016-1-kumaranand@vmware.com>","In-Reply-To":"<20170905235304.4016-1-kumaranand@vmware.com>","Date":"Thu, 7 Sep 2017 21:54:13 +0300","Message-ID":"<000601d3280a$b35df6a0$1a19e3e0$@ovn.org>","MIME-Version":"1.0","X-Mailer":"Microsoft Outlook 16.0","Thread-Index":"AQHTJqIt5n+ffBPkDUWjRTjDT6kgWqKpyAAQ","Content-Language":"ro","X-Spam-Status":"No, score=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW\n\tautolearn=disabled version=3.3.1","X-Spam-Checker-Version":"SpamAssassin 3.3.1 (2010-03-16) on\n\tsmtp1.linux-foundation.org","Subject":"Re: [ovs-dev] [PATCH] datapath-windows: Increment ct packet\n\tcounters\tbased on ct_state.","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.12","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"ovs-dev-bounces@openvswitch.org","Errors-To":"ovs-dev-bounces@openvswitch.org"}},{"id":1764925,"web_url":"http://patchwork.ozlabs.org/comment/1764925/","msgid":"<000f01d32814$fdabfb80$f903f280$@ovn.org>","list_archive_url":null,"date":"2017-09-07T20:07:53","subject":"Re: [ovs-dev] [PATCH] datapath-windows: Increment ct\n\tpacket\tcounters\tbased on ct_state.","submitter":{"id":72181,"url":"http://patchwork.ozlabs.org/api/people/72181/","name":"Alin-Gabriel Serdean","email":"aserdean@ovn.org"},"content":"I added a missing curly bracket to make it compile.\n\nThanks Anand I applied it on master and branch-2.8.\n\nAlin.\n\n> -----Original Message-----\n> From: ovs-dev-bounces@openvswitch.org [mailto:ovs-dev-\n> bounces@openvswitch.org] On Behalf Of aserdean@ovn.org\n> Sent: Thursday, September 7, 2017 9:54 PM\n> To: 'Anand Kumar' ; dev@openvswitch.org\n> Subject: Re: [ovs-dev] [PATCH] datapath-windows: Increment ct packet\n> counters based on ct_state.\n> \n> Acked-by: Alin Serdean \n> \n> > -----Original Message-----\n> > From: ovs-dev-bounces@openvswitch.org [mailto:ovs-dev-\n> > bounces@openvswitch.org] On Behalf Of Anand Kumar\n> > Sent: Wednesday, September 6, 2017 2:53 AM\n> > To: dev@openvswitch.org\n> > Subject: [ovs-dev] [PATCH] datapath-windows: Increment ct packet\n> > counters based on ct_state.\n> >\n> > For a given packet, packet counters in conntrack should be accounted\n> > only once, even if the packet is processed multiple times by conntrack.\n> >\n> > When a packet is processed by conntrack, ct_state flag is set to\n> > OVS_CS_F_TRACKED. Use this state to identify if a packet has been\n> > processed previously by conntrack.\n> >\n> > Also update the ct packet counters when ct entry is created.\n> >\n> > With this patch, the conntrack's packet counters behavior is similar\n> > to\n> linux\n> >\n> > Signed-off-by: Anand Kumar \n> > ---\n> > datapath-windows/ovsext/Conntrack.c | 34 +++++++++++++++++++++---\n> --\n> > --------\n> > 1 file changed, 21 insertions(+), 13 deletions(-)\n> >\n> > diff --git a/datapath-windows/ovsext/Conntrack.c b/datapath-\n> > windows/ovsext/Conntrack.c index 8bcda05..0adb6d5 100644\n> > --- a/datapath-windows/ovsext/Conntrack.c\n> > +++ b/datapath-windows/ovsext/Conntrack.c\n> > @@ -169,6 +169,18 @@ OvsPostCtEventEntry(POVS_CT_ENTRY entry,\n> UINT8\n> > type)\n> > OvsPostCtEvent(&ctEventEntry);\n> > }\n> >\n> > +static __inline VOID\n> > +OvsCtIncrementCounters(POVS_CT_ENTRY entry, BOOLEAN reply,\n> > +PNET_BUFFER_LIST nbl) {\n> > + if (reply) {\n> > + entry->rev_key.byteCount+= OvsPacketLenNBL(nbl);\n> > + entry->rev_key.packetCount++;\n> > + } else {\n> > + entry->key.byteCount += OvsPacketLenNBL(nbl);\n> > + entry->key.packetCount++;\n> > + }\n> > +}\n> > +\n> > static __inline BOOLEAN\n> > OvsCtAddEntry(POVS_CT_ENTRY entry, OvsConntrackKeyLookupCtx *ctx,\n> > PNAT_ACTION_INFO natInfo, UINT64 now) @@ -287,6 +299,9\n> > @@ OvsCtEntryCreate(OvsForwardingContext *fwdCtx,\n> > }\n> >\n> > OvsCtUpdateFlowKey(key, state, ctx->key.zone, 0, NULL);\n> > + if (entry) {\n> > + OvsCtIncrementCounters(entry, ctx->reply, curNbl);\n> > + }\n> > return entry;\n> > }\n> >\n> > @@ -382,18 +397,6 @@ OvsCtKeyAreSame(OVS_CT_KEY ctxKey,\n> OVS_CT_KEY\n> > entryKey)\n> > (ctxKey.zone == entryKey.zone)); }\n> >\n> > -static __inline VOID\n> > -OvsCtIncrementCounters(POVS_CT_ENTRY entry, BOOLEAN reply,\n> > PNET_BUFFER_LIST nbl) -{\n> > - if (reply) {\n> > - entry->rev_key.byteCount+= OvsPacketLenNBL(nbl);\n> > - entry->rev_key.packetCount++;\n> > - } else {\n> > - entry->key.byteCount += OvsPacketLenNBL(nbl);\n> > - entry->key.packetCount++;\n> > - }\n> > -}\n> > -\n> > POVS_CT_ENTRY\n> > OvsCtLookup(OvsConntrackKeyLookupCtx *ctx) { @@ -730,6 +733,12 @@\n> > OvsCtExecute_(OvsForwardingContext *fwdCtx,\n> > NdisReleaseRWLock(ovsConntrackLockObj, &lockState);\n> > OVS_LOG_ERROR(\"Conntrack Limit hit: %lu\", ctTotalEntries);\n> > return NDIS_STATUS_RESOURCES;\n> > +\n> > + /* Increment the counters soon after the lookup, since we set\n> ct.state\n> > + * to OVS_CS_F_TRACKED after processing the ct entry.\n> > + */\n> > + if (entry && (!(key->ct.state & OVS_CS_F_TRACKED))) {\n> > + OvsCtIncrementCounters(entry, ctx.reply, curNbl);\n> > }\n> >\n> > if (!entry) {\n> > @@ -740,7 +749,6 @@ OvsCtExecute_(OvsForwardingContext *fwdCtx,\n> > &entryCreated);\n> > } else {\n> > /* Process the entry and update CT flags */\n> > - OvsCtIncrementCounters(entry, ctx.reply, curNbl);\n> > entry = OvsProcessConntrackEntry(fwdCtx, layers->l4Offset,\n> > &ctx,\n> key,\n> > zone, natInfo, commit,\n> currentTime,\n> > &entryCreated);\n> > --\n> > 2.9.3.windows.1\n> >\n> > _______________________________________________\n> > dev mailing list\n> > dev@openvswitch.org\n> > https://mail.openvswitch.org/mailman/listinfo/ovs-dev\n> \n> _______________________________________________\n> dev mailing list\n> dev@openvswitch.org\n> https://mail.openvswitch.org/mailman/listinfo/ovs-dev","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","ovs-dev@mail.linuxfoundation.org"],"Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=)","Received":["from mail.linuxfoundation.org (mail.linuxfoundation.org\n\t[140.211.169.12])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xpBMj456Lz9s83\n\tfor ;\n\tFri, 8 Sep 2017 06:08:01 +1000 (AEST)","from mail.linux-foundation.org (localhost [127.0.0.1])\n\tby mail.linuxfoundation.org (Postfix) with ESMTP id 2BF3DBF2;\n\tThu, 7 Sep 2017 20:07:56 +0000 (UTC)","from smtp1.linuxfoundation.org (smtp1.linux-foundation.org\n\t[172.17.192.35])\n\tby mail.linuxfoundation.org (Postfix) with ESMTPS id D41D5BDE\n\tfor ; Thu, 7 Sep 2017 20:07:54 +0000 (UTC)","from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net\n\t[217.70.183.195])\n\tby smtp1.linuxfoundation.org (Postfix) with ESMTPS id 327AB420\n\tfor ; Thu, 7 Sep 2017 20:07:54 +0000 (UTC)","from cloudbasealin (unknown [79.114.121.216])\n\t(Authenticated sender: aserdean@ovn.org)\n\tby relay3-d.mail.gandi.net (Postfix) with ESMTPSA id 5AF8AA80E9;\n\tThu, 7 Sep 2017 22:07:52 +0200 (CEST)"],"X-Greylist":"domain auto-whitelisted by SQLgrey-1.7.6","X-Originating-IP":"79.114.121.216","From":"","To":", \"'Anand Kumar'\" ,\n\t","References":"<20170905235304.4016-1-kumaranand@vmware.com>\n\t<000601d3280a$b35df6a0$1a19e3e0$@ovn.org>","In-Reply-To":"<000601d3280a$b35df6a0$1a19e3e0$@ovn.org>","Date":"Thu, 7 Sep 2017 23:07:53 +0300","Message-ID":"<000f01d32814$fdabfb80$f903f280$@ovn.org>","MIME-Version":"1.0","X-Mailer":"Microsoft Outlook 16.0","Thread-Index":"AQHTKAq8tRIFRexAJUCdn067TXfkDaKp2EDw","Content-Language":"ro","X-Spam-Status":"No, score=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW\n\tautolearn=disabled version=3.3.1","X-Spam-Checker-Version":"SpamAssassin 3.3.1 (2010-03-16) on\n\tsmtp1.linux-foundation.org","Subject":"Re: [ovs-dev] [PATCH] datapath-windows: Increment ct\n\tpacket\tcounters\tbased on ct_state.","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.12","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"ovs-dev-bounces@openvswitch.org","Errors-To":"ovs-dev-bounces@openvswitch.org"}}]