[{"id":1763729,"web_url":"http://patchwork.ozlabs.org/comment/1763729/","msgid":"<9647310.uGr6pVgWHI@diego>","list_archive_url":null,"date":"2017-09-05T23:13:32","subject":"Re: [U-Boot] rk3188/rock_defconfig sdmmc failures","submitter":{"id":10645,"url":"http://patchwork.ozlabs.org/api/people/10645/","name":"Heiko Stuebner","email":"heiko@sntech.de"},"content":"Hi Artturi,\n\nAm Mittwoch, 6. September 2017, 01:50:38 CEST schrieb Artturi Alm:\n> So, being optimistic, i added compatible found from\n> arch/arm/dts/rk3xxx.dtsi, included by rk3188:\n> \n> diff --git a/drivers/mmc/rockchip_dw_mmc.c b/drivers/mmc/rockchip_dw_mmc.c\n> index e7fcf89..a879fcd 100644\n> --- a/drivers/mmc/rockchip_dw_mmc.c\n> +++ b/drivers/mmc/rockchip_dw_mmc.c\n> @@ -160,6 +160,7 @@ static int rockchip_dwmmc_bind(struct udevice *dev)\n> \n> static const struct udevice_id rockchip_dwmmc_ids[] = {\n> { .compatible = \"rockchip,rk3288-dw-mshc\" },\n> + { .compatible = \"rockchip,rk2928-dw-mshc\" },\n> { }\n> };\n\nThe rk3188 SPL is using OF_PLATDATA which transforms the devicetree entry\ninto a struct during compilation to save space in the image.\nRelevant to this would be the U_BOOT_DRIVER below that compatibles, which\ncurrently binds to the rockchip_rk3288_dw_mshc transformed compatible.\n\nAdding a second U_BOOT_DRIVER entry there might help for the probing,\nbut seeing that the dw-mmc in the Linux kernel behaves differently for\nrk3188 and rk3288 onwards, I'm not sure if it would work out of the box.\n\n[...]\n\n> now i've \"successfully\" enabled usb, but it took like +30tries\n> w/\"usb reset\" until the host ports succesfully found my usb mass storage,\n> and sometimes it leaves the dwc2 otg controller in a state where\n> \"usb tree\" will fault while printing out, and reset the board, so i'd\n> rather have sdmmc working for now instead, as it is enabled already in\n> the default config for the board.\n\nFor usb you might want to make sure the usb host regulator is enabled\nI have the below commands in my netboot uboot for the rock and it is\nworking quite reliable and so far I haven't seen usb-related issues there.\n\nregulator dev host-pwr;\nregulator enable;\nusb start;\n\n\nHope that helps a bit\nHeiko","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xn2Zt3DWJz9t2R\n\tfor ;\n\tWed, 6 Sep 2017 09:13:42 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 1CEF7C21E0A; Tue, 5 Sep 2017 23:13:37 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id C6E1BC21D7E;\n\tTue, 5 Sep 2017 23:13:35 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 29B37C21D7E; Tue, 5 Sep 2017 23:13:34 +0000 (UTC)","from gloria.sntech.de (gloria.sntech.de [95.129.55.99])\n\tby lists.denx.de (Postfix) with ESMTPS id DED71C21D7A\n\tfor ; Tue, 5 Sep 2017 23:13:33 +0000 (UTC)","from ip9234ad97.dynamic.kabel-deutschland.de ([146.52.173.151]\n\thelo=diego.localnet) by gloria.sntech.de with esmtpsa\n\t(TLS1.1:DHE_RSA_AES_256_CBC_SHA1:256)\n\t(Exim 4.80) (envelope-from )\n\tid 1dpN2C-0001cX-Re; Wed, 06 Sep 2017 01:13:33 +0200"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=0.0 required=5.0 tests=RCVD_IN_DNSWL_NONE\n\tautolearn=unavailable autolearn_force=no version=3.4.0","From":"Heiko =?iso-8859-1?q?St=FCbner?= ","To":"Artturi Alm ","Date":"Wed, 06 Sep 2017 01:13:32 +0200","Message-ID":"<9647310.uGr6pVgWHI@diego>","User-Agent":"KMail/5.2.3 (Linux/4.11.0-1-amd64; KDE/5.28.0; x86_64; ; )","In-Reply-To":"<20170905225038.GA89171@gmail.com>","References":"<20170905225038.GA89171@gmail.com>","MIME-Version":"1.0","Cc":"u-boot@lists.denx.de","Subject":"Re: [U-Boot] rk3188/rock_defconfig sdmmc failures","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}}]