[{"id":1763859,"web_url":"http://patchwork.ozlabs.org/comment/1763859/","msgid":"<20170906072924.GA27916@quack2.suse.cz>","list_archive_url":null,"date":"2017-09-06T07:29:24","subject":"Re: [PATCH 1/9] ext4: remove duplicate extended attributes defs","submitter":{"id":363,"url":"http://patchwork.ozlabs.org/api/people/363/","name":"Jan Kara","email":"jack@suse.cz"},"content":"On Tue 05-09-17 16:35:33, Ross Zwisler wrote:\n> The following commit:\n> \n> commit 9b7365fc1c82 (\"ext4: add FS_IOC_FSSETXATTR/FS_IOC_FSGETXATTR\n> interface support\")\n> \n> added several defines related to extended attributes to ext4.h. They were\n> added within an #ifndef FS_IOC_FSGETXATTR block with the comment:\n> \n> /* Until the uapi changes get merged for project quota... */\n> \n> Those uapi changes were merged by this commit:\n> \n> commit 334e580a6f97 (\"fs: XFS_IOC_FS[SG]SETXATTR to FS_IOC_FS[SG]ETXATTR\n> promotion\")\n> \n> so all the definitions needed by ext4 are available in\n> include/uapi/linux/fs.h. Remove the duplicates from ext4.h.\n> \n> Signed-off-by: Ross Zwisler \n> Cc: Li Xi \n> Cc: Theodore Ts'o \n> Cc: Andreas Dilger \n> Cc: Jan Kara \n> Cc: Dave Chinner \n\nYeah, good cleanup. You can add:\n\nReviewed-by: Jan Kara \n\n\t\t\t\t\t\t\t\tHonza\n\n> ---\n> fs/ext4/ext4.h | 37 -------------------------------------\n> 1 file changed, 37 deletions(-)\n> \n> diff --git a/fs/ext4/ext4.h b/fs/ext4/ext4.h\n> index a2bb7d2..c950278 100644\n> --- a/fs/ext4/ext4.h\n> +++ b/fs/ext4/ext4.h\n> @@ -644,43 +644,6 @@ enum {\n> #define EXT4_IOC_GET_ENCRYPTION_PWSALT\tFS_IOC_GET_ENCRYPTION_PWSALT\n> #define EXT4_IOC_GET_ENCRYPTION_POLICY\tFS_IOC_GET_ENCRYPTION_POLICY\n> \n> -#ifndef FS_IOC_FSGETXATTR\n> -/* Until the uapi changes get merged for project quota... */\n> -\n> -#define FS_IOC_FSGETXATTR\t\t_IOR('X', 31, struct fsxattr)\n> -#define FS_IOC_FSSETXATTR\t\t_IOW('X', 32, struct fsxattr)\n> -\n> -/*\n> - * Structure for FS_IOC_FSGETXATTR and FS_IOC_FSSETXATTR.\n> - */\n> -struct fsxattr {\n> -\t__u32\t\tfsx_xflags;\t/* xflags field value (get/set) */\n> -\t__u32\t\tfsx_extsize;\t/* extsize field value (get/set)*/\n> -\t__u32\t\tfsx_nextents;\t/* nextents field value (get)\t*/\n> -\t__u32\t\tfsx_projid;\t/* project identifier (get/set) */\n> -\tunsigned char\tfsx_pad[12];\n> -};\n> -\n> -/*\n> - * Flags for the fsx_xflags field\n> - */\n> -#define FS_XFLAG_REALTIME\t0x00000001\t/* data in realtime volume */\n> -#define FS_XFLAG_PREALLOC\t0x00000002\t/* preallocated file extents */\n> -#define FS_XFLAG_IMMUTABLE\t0x00000008\t/* file cannot be modified */\n> -#define FS_XFLAG_APPEND\t\t0x00000010\t/* all writes append */\n> -#define FS_XFLAG_SYNC\t\t0x00000020\t/* all writes synchronous */\n> -#define FS_XFLAG_NOATIME\t0x00000040\t/* do not update access time */\n> -#define FS_XFLAG_NODUMP\t\t0x00000080\t/* do not include in backups */\n> -#define FS_XFLAG_RTINHERIT\t0x00000100\t/* create with rt bit set */\n> -#define FS_XFLAG_PROJINHERIT\t0x00000200\t/* create with parents projid */\n> -#define FS_XFLAG_NOSYMLINKS\t0x00000400\t/* disallow symlink creation */\n> -#define FS_XFLAG_EXTSIZE\t0x00000800\t/* extent size allocator hint */\n> -#define FS_XFLAG_EXTSZINHERIT\t0x00001000\t/* inherit inode extent size */\n> -#define FS_XFLAG_NODEFRAG\t0x00002000 \t/* do not defragment */\n> -#define FS_XFLAG_FILESTREAM\t0x00004000\t/* use filestream allocator */\n> -#define FS_XFLAG_HASATTR\t0x80000000\t/* no DIFLAG for this */\n> -#endif /* !defined(FS_IOC_FSGETXATTR) */\n> -\n> #define EXT4_IOC_FSGETXATTR\t\tFS_IOC_FSGETXATTR\n> #define EXT4_IOC_FSSETXATTR\t\tFS_IOC_FSSETXATTR\n> \n> -- \n> 2.9.5\n>","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-ext4-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xnFbC4RJZz9t2R\n\tfor ;\n\tWed, 6 Sep 2017 17:29:43 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751737AbdIFH33 (ORCPT );\n\tWed, 6 Sep 2017 03:29:29 -0400","from mx2.suse.de ([195.135.220.15]:46942 \"EHLO mx1.suse.de\"\n\trhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP\n\tid S1751675AbdIFH32 (ORCPT );\n\tWed, 6 Sep 2017 03:29:28 -0400","from relay2.suse.de (charybdis-ext.suse.de [195.135.220.254])\n\tby mx1.suse.de (Postfix) with ESMTP id F386AAD71;\n\tWed, 6 Sep 2017 07:29:26 +0000 (UTC)","by quack2.suse.cz (Postfix, from userid 1000)\n\tid E5DC71E07DE; Wed, 6 Sep 2017 09:29:24 +0200 (CEST)"],"X-Virus-Scanned":"by amavisd-new at test-mx.suse.de","Date":"Wed, 6 Sep 2017 09:29:24 +0200","From":"Jan Kara ","To":"Ross Zwisler ","Cc":"Andrew Morton , linux-kernel@vger.kernel.org,\n\t\"Darrick J. Wong\" ,\n\tTheodore Ts'o , Andreas Dilger ,\n\tChristoph Hellwig , Dan Williams ,\n\tDave Chinner , Jan Kara ,\n\tlinux-ext4@vger.kernel.org, linux-nvdimm@lists.01.org,\n\tlinux-xfs@vger.kernel.org, Li Xi ,\n\tAndreas Dilger , Dave Chinner ","Subject":"Re: [PATCH 1/9] ext4: remove duplicate extended attributes defs","Message-ID":"<20170906072924.GA27916@quack2.suse.cz>","References":"<20170905223541.20594-1-ross.zwisler@linux.intel.com>\n\t<20170905223541.20594-2-ross.zwisler@linux.intel.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20170905223541.20594-2-ross.zwisler@linux.intel.com>","User-Agent":"Mutt/1.5.24 (2015-08-30)","Sender":"linux-ext4-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-ext4@vger.kernel.org"}}]