[{"id":1763820,"web_url":"http://patchwork.ozlabs.org/comment/1763820/","msgid":"<24E74671-DF9F-4FCC-A116-C7FD79F9AE58@suse.de>","list_archive_url":null,"date":"2017-09-06T05:24:45","subject":"Re: [PATCH] Fix ICE in categorize_decl_for_section with TLS decl\n\t(PR middle-end/82095)","submitter":{"id":4338,"url":"http://patchwork.ozlabs.org/api/people/4338/","name":"Richard Biener","email":"rguenther@suse.de"},"content":"On September 5, 2017 11:16:53 PM GMT+02:00, Jakub Jelinek wrote:\n>Hi!\n>\n>If a DECL_THREAD_LOCAL_P decl has NULL DECL_INITIAL and\n>-fzero-initialized-in-bss (the default), we ICE starting with\n>r251602, which changed bss_initializer_p:\n>+ /* Do not put constants into the .bss section, they belong in a\n>readonly\n>+ section. */\n>+ return (!TREE_READONLY (decl)\n>+\t &&\n>to:\n> (DECL_INITIAL (decl) == NULL\n> /* In LTO we have no errors in program; error_mark_node is used\n> to mark offlined constructors. */\n> || (DECL_INITIAL (decl) == error_mark_node\n> && !in_lto_p)\n> || (flag_zero_initialized_in_bss\n> && initializer_zerop (DECL_INITIAL (decl))))\n>Previously because bss_initializer_p for these returned true, ret was\n>SECCAT_BSS and therefore we set it to SECCAT_TBSS as intended, but now\n>ret\n>is not SECCAT_BSS, but as TLS has only tbss and tdata possibilities, we\n>still want to use tbss. DECL_INITIAL NULL for a decl means implicit\n>zero\n>initialization.\n>\n>Fixed thusly, bootstrapped/regtested on x86_64-linux and i686-linux, ok\n>for\n>trunk?\n\nOK. \n\nRichard. \n\n>2017-09-05 Jakub Jelinek \n>\n>\tPR middle-end/82095\n>\t* varasm.c (categorize_decl_for_section): Use SECCAT_TBSS for TLS vars\n>with\n>\tNULL DECL_INITIAL.\n>\n>\t* gcc.dg/tls/pr82095.c: New test.\n>\n>--- gcc/varasm.c.jj\t2017-09-01 18:43:29.000000000 +0200\n>+++ gcc/varasm.c\t2017-09-04 12:29:10.166564776 +0200\n>@@ -6562,8 +6562,9 @@ categorize_decl_for_section (const_tree\n> /* Note that this would be *just* SECCAT_BSS, except that there's\n> \t no concept of a read-only thread-local-data section. */\n> if (ret == SECCAT_BSS\n>-\t || (flag_zero_initialized_in_bss\n>-\t\t && initializer_zerop (DECL_INITIAL (decl))))\n>+\t || DECL_INITIAL (decl) == NULL\n>+\t || (flag_zero_initialized_in_bss\n>+\t && initializer_zerop (DECL_INITIAL (decl))))\n> \tret = SECCAT_TBSS;\n> else\n> \tret = SECCAT_TDATA;\n>--- gcc/testsuite/gcc.dg/tls/pr82095.c.jj\t2017-09-04 12:44:16.650538220\n>+0200\n>+++ gcc/testsuite/gcc.dg/tls/pr82095.c\t2017-09-04 12:44:08.000000000\n>+0200\n>@@ -0,0 +1,16 @@\n>+/* PR middle-end/82095 */\n>+/* { dg-do compile } */\n>+/* { dg-options \"-Og -fno-tree-ccp\" } */\n>+/* { dg-require-effective-target tls } */\n>+/* { dg-add-options tls } */\n>+\n>+static int b;\n>+static __thread int c;\n>+\n>+void\n>+foo (void)\n>+{\n>+ if (b)\n>+ if (c)\n>+ b = 1;\n>+}\n>\n>\tJakub","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","mailing list gcc-patches@gcc.gnu.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=gcc.gnu.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=gcc-patches-return-461550-incoming=patchwork.ozlabs.org@gcc.gnu.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org\n\theader.b=\"Q8I8IVYT\"; dkim-atps=neutral","sourceware.org; auth=none"],"Received":["from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xnBqJ1qG6z9ryT\n\tfor ;\n\tWed, 6 Sep 2017 15:25:00 +1000 (AEST)","(qmail 5367 invoked by alias); 6 Sep 2017 05:24:52 -0000","(qmail 4744 invoked by uid 89); 6 Sep 2017 05:24:52 -0000","from mx2.suse.de (HELO mx1.suse.de) (195.135.220.15) by\n\tsourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP;\n\tWed, 06 Sep 2017 05:24:50 +0000","from relay1.suse.de (charybdis-ext.suse.de [195.135.220.254])\tby\n\tmx1.suse.de (Postfix) with ESMTP id 5C28AAF2A;\n\tWed, 6 Sep 2017 05:24:48 +0000 (UTC)"],"DomainKey-Signature":"a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id\n\t:list-unsubscribe:list-archive:list-post:list-help:sender:date\n\t:in-reply-to:references:mime-version:content-type\n\t:content-transfer-encoding:subject:to:cc:from:message-id; q=dns;\n\ts=default; b=TQ3k53tbLxBw/T3mlYe9PMkbgQ6ecrapAwDnpjSFTUZfY2BQ7o\n\teZlfrA5IGl2wE7oM46UASNIsz4qvjPb2F6nQY+bkQ6QB/nQ/+V7b7Ri0GZWDQ8ZC\n\t9h15nOj0uRq09b+zkz289LxCFRzu7MOSRIyVz/oxod5pOU/1MpWNHUBYA=","DKIM-Signature":"v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id\n\t:list-unsubscribe:list-archive:list-post:list-help:sender:date\n\t:in-reply-to:references:mime-version:content-type\n\t:content-transfer-encoding:subject:to:cc:from:message-id; s=\n\tdefault; bh=RUCpfqYWS3pjAHQ88O7URmSNlBs=; b=Q8I8IVYTDQLeK0aUoVks\n\tRFXAvBe4XxakxQd9R1fsI37OD87IbpLaBU9ZsYMNEvCuuVPhye0RJ5u29k2U5n/2\n\tiyI6jiTwdYY0Cfqjgb0Y+tPd4UjN0cf7Jvt4ZcU3j3p+e+5+7iikLpPx1TgwHb3f\n\tIQrinovaVnzntCTYOqlYhp8=","Mailing-List":"contact gcc-patches-help@gcc.gnu.org; run by ezmlm","Precedence":"bulk","List-Id":"","List-Unsubscribe":"","List-Archive":"","List-Post":"","List-Help":"","Sender":"gcc-patches-owner@gcc.gnu.org","X-Virus-Found":"No","X-Spam-SWARE-Status":"No, score=-11.9 required=5.0 tests=BAYES_00, GIT_PATCH_2,\n\tGIT_PATCH_3, RP_MATCHES_RCVD,\n\tSPF_PASS autolearn=ham version=3.3.2 spammy=","X-HELO":"mx1.suse.de","Date":"Wed, 06 Sep 2017 07:24:45 +0200","User-Agent":"K-9 Mail for Android","In-Reply-To":"<20170905211653.GH2323@tucnak>","References":"<20170905211653.GH2323@tucnak>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"quoted-printable","Subject":"Re: [PATCH] Fix ICE in categorize_decl_for_section with TLS decl\n\t(PR middle-end/82095)","To":"Jakub Jelinek ,Jeff Law ","CC":"gcc-patches@gcc.gnu.org","From":"Richard Biener ","Message-ID":"<24E74671-DF9F-4FCC-A116-C7FD79F9AE58@suse.de>"}},{"id":1764198,"web_url":"http://patchwork.ozlabs.org/comment/1764198/","msgid":"<2f9aa4fb-7749-7ab4-aaca-6c2a8bd627c3@redhat.com>","list_archive_url":null,"date":"2017-09-06T15:29:25","subject":"Re: [PATCH] Fix ICE in categorize_decl_for_section with TLS decl\n\t(PR middle-end/82095)","submitter":{"id":4400,"url":"http://patchwork.ozlabs.org/api/people/4400/","name":"Jeff Law","email":"law@redhat.com"},"content":"On 09/05/2017 03:16 PM, Jakub Jelinek wrote:\n> Hi!\n> \n> If a DECL_THREAD_LOCAL_P decl has NULL DECL_INITIAL and\n> -fzero-initialized-in-bss (the default), we ICE starting with\n> r251602, which changed bss_initializer_p:\n> + /* Do not put constants into the .bss section, they belong in a readonly\n> + section. */\n> + return (!TREE_READONLY (decl)\n> +\t &&\n> to:\n> (DECL_INITIAL (decl) == NULL\n> /* In LTO we have no errors in program; error_mark_node is used\n> to mark offlined constructors. */\n> || (DECL_INITIAL (decl) == error_mark_node\n> && !in_lto_p)\n> || (flag_zero_initialized_in_bss\n> && initializer_zerop (DECL_INITIAL (decl))))\n> Previously because bss_initializer_p for these returned true, ret was\n> SECCAT_BSS and therefore we set it to SECCAT_TBSS as intended, but now ret\n> is not SECCAT_BSS, but as TLS has only tbss and tdata possibilities, we\n> still want to use tbss. DECL_INITIAL NULL for a decl means implicit zero\n> initialization.\n> \n> Fixed thusly, bootstrapped/regtested on x86_64-linux and i686-linux, ok for\n> trunk?\n> \n> 2017-09-05 Jakub Jelinek \n> \n> \tPR middle-end/82095\n> \t* varasm.c (categorize_decl_for_section): Use SECCAT_TBSS for TLS vars with\n> \tNULL DECL_INITIAL.\n> \n> \t* gcc.dg/tls/pr82095.c: New test.\nTHanks. Sorry about the breakage. TLS didn't even cross my mind.\nPresumably the TLS initialization sections are readonly and copied into\nthe actual thread specific locations.\n\nJeff","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","mailing list gcc-patches@gcc.gnu.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=gcc.gnu.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=gcc-patches-return-461623-incoming=patchwork.ozlabs.org@gcc.gnu.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org\n\theader.b=\"N8h2woNQ\"; dkim-atps=neutral","sourceware.org; auth=none","ext-mx06.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx06.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=law@redhat.com"],"Received":["from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xnSDx6N5Mz9s03\n\tfor ;\n\tThu, 7 Sep 2017 01:29:37 +1000 (AEST)","(qmail 112729 invoked by alias); 6 Sep 2017 15:29:30 -0000","(qmail 112715 invoked by uid 89); 6 Sep 2017 15:29:30 -0000","from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by\n\tsourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP;\n\tWed, 06 Sep 2017 15:29:29 +0000","from smtp.corp.redhat.com\n\t(int-mx02.intmail.prod.int.phx2.redhat.com\n\t[10.5.11.12])\t(using TLSv1.2 with cipher AECDH-AES256-SHA\n\t(256/256 bits))\t(No client certificate requested)\tby\n\tmx1.redhat.com (Postfix) with ESMTPS id 28D6020A89;\n\tWed, 6 Sep 2017 15:29:28 +0000 (UTC)","from localhost.localdomain (ovpn-112-2.rdu2.redhat.com\n\t[10.10.112.2])\tby smtp.corp.redhat.com (Postfix) with ESMTP\n\tid 0010E85F71; Wed, 6 Sep 2017 15:29:26 +0000 (UTC)"],"DomainKey-Signature":"a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id\n\t:list-unsubscribe:list-archive:list-post:list-help:sender\n\t:subject:to:cc:references:from:message-id:date:mime-version\n\t:in-reply-to:content-type:content-transfer-encoding; q=dns; s=\n\tdefault; b=u8WrbX9ejqmJ1jaBRjSEWPrwu2W2sCqMAx6HKOEeSNYWz5O/cWgdt\n\tiuDhZ6iZwJLbpOBv+v50xugGJiFtgQHxnwjedwiLG9F4SthdWZtXiSmuYGrokCyI\n\tsK5mF7kKJf4eLNsUjSK5KW/iCbpj2UkCKbjkxjVR8Uh6pAKbHgFGxM=","DKIM-Signature":"v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id\n\t:list-unsubscribe:list-archive:list-post:list-help:sender\n\t:subject:to:cc:references:from:message-id:date:mime-version\n\t:in-reply-to:content-type:content-transfer-encoding; s=default;\n\tbh=6mlx/HsemAJAOn4eYGwxF0AkxJU=; b=N8h2woNQKzj3DFRKbaXyxw2xa19y\n\taaTWA4hO/RdBpMu+EL7d8O2X2r5yv+2L78LaCHyjD4ym3VjJ8nC1CUYmzHfwThlF\n\tEX4syOHzyiw0SVXTaCuulm+e8OYv0IGq6IBsAMR6thKnELkU0GzMgIFTgTCGwTK5\n\t6e9PeOMWIMSIaTk=","Mailing-List":"contact gcc-patches-help@gcc.gnu.org; run by ezmlm","Precedence":"bulk","List-Id":"","List-Unsubscribe":"","List-Archive":"","List-Post":"","List-Help":"","Sender":"gcc-patches-owner@gcc.gnu.org","X-Virus-Found":"No","X-Spam-SWARE-Status":"No, score=-1.9 required=5.0 tests=BAYES_00,\n\tRP_MATCHES_RCVD,\n\tSPF_HELO_PASS autolearn=ham version=3.3.2 spammy=","X-HELO":"mx1.redhat.com","DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 28D6020A89","Subject":"Re: [PATCH] Fix ICE in categorize_decl_for_section with TLS decl\n\t(PR middle-end/82095)","To":"Jakub Jelinek , Richard Biener ","Cc":"gcc-patches@gcc.gnu.org","References":"<20170905211653.GH2323@tucnak>","From":"Jeff Law ","Message-ID":"<2f9aa4fb-7749-7ab4-aaca-6c2a8bd627c3@redhat.com>","Date":"Wed, 6 Sep 2017 09:29:25 -0600","User-Agent":"Mozilla/5.0 (X11; Linux x86_64;\n\trv:52.0) Gecko/20100101 Thunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<20170905211653.GH2323@tucnak>","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"7bit","X-IsSubscribed":"yes"}},{"id":1764207,"web_url":"http://patchwork.ozlabs.org/comment/1764207/","msgid":"<20170906153946.GP2323@tucnak>","list_archive_url":null,"date":"2017-09-06T15:39:46","subject":"Re: [PATCH] Fix ICE in categorize_decl_for_section with TLS decl\n\t(PR middle-end/82095)","submitter":{"id":671,"url":"http://patchwork.ozlabs.org/api/people/671/","name":"Jakub Jelinek","email":"jakub@redhat.com"},"content":"On Wed, Sep 06, 2017 at 09:29:25AM -0600, Jeff Law wrote:\n> > Fixed thusly, bootstrapped/regtested on x86_64-linux and i686-linux, ok for\n> > trunk?\n> > \n> > 2017-09-05 Jakub Jelinek \n> > \n> > \tPR middle-end/82095\n> > \t* varasm.c (categorize_decl_for_section): Use SECCAT_TBSS for TLS vars with\n> > \tNULL DECL_INITIAL.\n> > \n> > \t* gcc.dg/tls/pr82095.c: New test.\n> THanks. Sorry about the breakage. TLS didn't even cross my mind.\n> Presumably the TLS initialization sections are readonly and copied into\n> the actual thread specific locations.\n\n.tbss section is just in headers (it implies zeroing the corresponding\nthread private chunk) and .tdata is in relro part (the image; it might\ncontain relocations and we don't support separate images for parts without\nand with relocations), copied to the thread private chunk.\n\n\tJakub","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","mailing list gcc-patches@gcc.gnu.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=gcc.gnu.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=gcc-patches-return-461626-incoming=patchwork.ozlabs.org@gcc.gnu.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org\n\theader.b=\"HI+Y+PPV\"; dkim-atps=neutral","sourceware.org; auth=none","ext-mx07.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx07.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=jakub@redhat.com"],"Received":["from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xnSSx38Mkz9s81\n\tfor ;\n\tThu, 7 Sep 2017 01:40:01 +1000 (AEST)","(qmail 1465 invoked by alias); 6 Sep 2017 15:39:54 -0000","(qmail 1436 invoked by uid 89); 6 Sep 2017 15:39:53 -0000","from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by\n\tsourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP;\n\tWed, 06 Sep 2017 15:39:52 +0000","from smtp.corp.redhat.com\n\t(int-mx05.intmail.prod.int.phx2.redhat.com\n\t[10.5.11.15])\t(using TLSv1.2 with cipher AECDH-AES256-SHA\n\t(256/256 bits))\t(No client certificate requested)\tby\n\tmx1.redhat.com (Postfix) with ESMTPS id 889A6C04B924;\n\tWed, 6 Sep 2017 15:39:51 +0000 (UTC)","from tucnak.zalov.cz (ovpn-116-33.ams2.redhat.com\n\t[10.36.116.33])\tby smtp.corp.redhat.com (Postfix) with ESMTPS\n\tid 2EA7D6B24A; Wed, 6 Sep 2017 15:39:50 +0000 (UTC)","from tucnak.zalov.cz (localhost [127.0.0.1])\tby tucnak.zalov.cz\n\t(8.15.2/8.15.2) with ESMTP id v86FdmXP013019;\n\tWed, 6 Sep 2017 17:39:48 +0200","(from jakub@localhost)\tby tucnak.zalov.cz (8.15.2/8.15.2/Submit)\n\tid v86FdkrO013018; Wed, 6 Sep 2017 17:39:46 +0200"],"DomainKey-Signature":"a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id\n\t:list-unsubscribe:list-archive:list-post:list-help:sender:date\n\t:from:to:cc:subject:message-id:reply-to:references:mime-version\n\t:content-type:in-reply-to; q=dns; s=default; b=bbBRkvrSbfDmeiZ8j\n\tQaaUjUsEv799ItmaFXrs6wpE/B0VKyjbg8p8UOyQu70f8xgJub5cwPuBlnrpx2FZ\n\tkjQQKUwAUa4f7rqFNY6X7NbYWJYuW+VfpkvohAjZX5/I8dGCgo8cWLMnAP7eoVVR\n\th8W7TVigm497xlio7+vEz6eS2g=","DKIM-Signature":"v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id\n\t:list-unsubscribe:list-archive:list-post:list-help:sender:date\n\t:from:to:cc:subject:message-id:reply-to:references:mime-version\n\t:content-type:in-reply-to; s=default; bh=ugCq4shUYMdobmph7BRPigg\n\tEhHU=; b=HI+Y+PPVbnqYAvTddDZbtm+imM+WQIAZHtABgr0pYa/Bko9c8NqqJ0y\n\tGO60YQd00/PYBNjvresH7wKsKSnw1p5ht/UMLT9qDJGnY3hqGwMf3SPzV7uvIv8p\n\tOREBnUsJTH7E58EZsjIl6jRg4nZDTdggNRBliWqO3xOZqK5/Xgcg=","Mailing-List":"contact gcc-patches-help@gcc.gnu.org; run by ezmlm","Precedence":"bulk","List-Id":"","List-Unsubscribe":"","List-Archive":"","List-Post":"","List-Help":"","Sender":"gcc-patches-owner@gcc.gnu.org","X-Virus-Found":"No","X-Spam-SWARE-Status":"No, score=-0.9 required=5.0 tests=BAYES_00,\n\tKAM_LAZY_DOMAIN_SECURITY, RP_MATCHES_RCVD,\n\tSPF_HELO_PASS autolearn=no version=3.3.2 spammy=images","X-HELO":"mx1.redhat.com","DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 889A6C04B924","Date":"Wed, 6 Sep 2017 17:39:46 +0200","From":"Jakub Jelinek ","To":"Jeff Law ","Cc":"Richard Biener , gcc-patches@gcc.gnu.org","Subject":"Re: [PATCH] Fix ICE in categorize_decl_for_section with TLS decl\n\t(PR middle-end/82095)","Message-ID":"<20170906153946.GP2323@tucnak>","Reply-To":"Jakub Jelinek ","References":"<20170905211653.GH2323@tucnak>\n\t<2f9aa4fb-7749-7ab4-aaca-6c2a8bd627c3@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<2f9aa4fb-7749-7ab4-aaca-6c2a8bd627c3@redhat.com>","User-Agent":"Mutt/1.7.1 (2016-10-04)","X-IsSubscribed":"yes"}}]