[{"id":1763772,"web_url":"http://patchwork.ozlabs.org/comment/1763772/","msgid":"","list_archive_url":null,"date":"2017-09-06T01:30:26","subject":"Re: [PATCH 8/9] posix: Use enum for __glob_pattern_type result","submitter":{"id":4434,"url":"http://patchwork.ozlabs.org/api/people/4434/","name":"Paul Eggert","email":"eggert@CS.UCLA.EDU"},"content":"'git am' complained about this patch:\n\n.git/rebase-apply/patch:60: trailing whitespace.\n __GLOB_BRACKET = 0x4\nwarning: 1 line adds whitespace errors.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","mailing list libc-alpha@sourceware.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=sourceware.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=libc-alpha-return-84225-incoming=patchwork.ozlabs.org@sourceware.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tsecure) header.d=sourceware.org header.i=@sourceware.org\n\theader.b=\"G8k4ftyU\"; dkim-atps=neutral","sourceware.org; auth=none"],"Received":["from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xn5cy45dFz9s2G\n\tfor ;\n\tWed, 6 Sep 2017 11:30:42 +1000 (AEST)","(qmail 98227 invoked by alias); 6 Sep 2017 01:30:35 -0000","(qmail 98199 invoked by uid 89); 6 Sep 2017 01:30:33 -0000"],"DomainKey-Signature":"a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:subject:to:references:from:message-id:date\n\t:mime-version:in-reply-to:content-type\n\t:content-transfer-encoding; q=dns; s=default; b=wpeslC1bnpy6EfuJ\n\tcNfS6oJRPJitBYml0IsqcXcSZ+Ey3Dy8jpeQqwmuwoD36DhCoV264ejMlg4rb3wt\n\tU6sdu/F1VNyNJAQlSHMzrgKZNkXQPSenodQKQvPiYXxWqtAqiEbC4iE6G1ScrPZp\n\tdoGXS3O8BoS5hD9jG4w1m7ZInWc=","DKIM-Signature":"v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:subject:to:references:from:message-id:date\n\t:mime-version:in-reply-to:content-type\n\t:content-transfer-encoding; s=default; bh=ijzpdvxrg/IbSRcW0YCLOC\n\tswXJQ=; b=G8k4ftyUtTLpabdbtfihld8qGKf3NkN3ixxfovfuKK2WPp/ntR5BRK\n\tNkP5GPYmD+A1gTNE6kIMqkz+WOYUbSgFz/NdfGJro55D/7NUHGIu0SIXjtmmxF5q\n\tTMqRhNjXzF4Y+Nf1duXOOIRWac2LkZhOGRale1ya8W88n+zTJ0PAw=","Mailing-List":"contact libc-alpha-help@sourceware.org; run by ezmlm","Precedence":"bulk","List-Id":"","List-Unsubscribe":"","List-Subscribe":"","List-Archive":"","List-Post":"","List-Help":",\n\t","Sender":"libc-alpha-owner@sourceware.org","X-Virus-Found":"No","X-Spam-SWARE-Status":"No, score=-2.2 required=5.0 tests=AWL, BAYES_00,\n\tRP_MATCHES_RCVD, SPF_PASS autolearn=ham version=3.3.2 spammy=","X-HELO":"zimbra.cs.ucla.edu","Subject":"Re: [PATCH 8/9] posix: Use enum for __glob_pattern_type result","To":"Adhemerval Zanella ,\n\tlibc-alpha@sourceware.org","References":"<1504643122-14874-1-git-send-email-adhemerval.zanella@linaro.org>\n\t<1504643122-14874-9-git-send-email-adhemerval.zanella@linaro.org>","From":"Paul Eggert ","Message-ID":"","Date":"Tue, 5 Sep 2017 18:30:26 -0700","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<1504643122-14874-9-git-send-email-adhemerval.zanella@linaro.org>","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Transfer-Encoding":"7bit"}},{"id":1763804,"web_url":"http://patchwork.ozlabs.org/comment/1763804/","msgid":"<018ac06d-cb0a-edb9-7de5-560f614fda80@cs.ucla.edu>","list_archive_url":null,"date":"2017-09-06T04:18:08","subject":"Re: [PATCH 8/9] posix: Use enum for __glob_pattern_type result","submitter":{"id":4434,"url":"http://patchwork.ozlabs.org/api/people/4434/","name":"Paul Eggert","email":"eggert@CS.UCLA.EDU"},"content":"Adhemerval Zanella wrote:\n> +enum glob_pattern_type_t\n> +{\n> + __GLOB_NONE = 0x0,\n> + __GLOB_SPECIAL = 0x1,\n> + __GLOB_BACKSLASH = 0x2,\n> + __GLOB_BRACKET = 0x4\n> +};\n\nThe identifier glob_pattern_type_t is not used elsewhere, so let's omit it. This \nmakes it clearer that we're merely defining handy names for int constants, as \nopposed to defining a new type.\n\nAlso, names like __GLOB_NONE could cause problems when Gnulib is used on non-GNU \nplatforms, which might use those names for other purposes. As glob_internal.h is \nnot user-visible, let's use ordinary names. I suggest GLOBPAT_NONE, \nGLOBPAT_SPECIAL, etc., as done in the attached patch, which I installed into Gnulib.\nFrom 36102f8d365655b5d9693ccff0349acc73c60433 Mon Sep 17 00:00:00 2001\nFrom: Paul Eggert \nDate: Tue, 5 Sep 2017 21:14:51 -0700\nSubject: [PATCH] glob: Use enum for __glob_pattern_type result\n\nFrom a patch proposed by Adhemerval Zanella in:\nhttps://sourceware.org/ml/libc-alpha/2017-09/msg00212.html\n* lib/glob_internal.h (GLOBPAT_NONE, GLOBPAT_SPECIAL)\n(GLOBPAT_BACKSLASH, GLOBPAT_BRACKET): New constants.\n* lib/glob_internal.h (__glob_pattern_type):\n* lib/glob.c (glob):\n* lib/glob_pattern_p.c (__glob_pattern_p):\nUse them.\n---\n ChangeLog | 10 ++++++++++\n lib/glob.c | 8 ++++----\n lib/glob_internal.h | 18 +++++++++++++-----\n lib/glob_pattern_p.c | 2 +-\n 4 files changed, 28 insertions(+), 10 deletions(-)\n\ndiff --git a/ChangeLog b/ChangeLog\nindex 61e3e8c..448bad2 100644\n--- a/ChangeLog\n+++ b/ChangeLog\n@@ -1,5 +1,15 @@\n 2017-09-05 Paul Eggert \n \n+\tglob: Use enum for __glob_pattern_type result\n+\tFrom a patch proposed by Adhemerval Zanella in:\n+\thttps://sourceware.org/ml/libc-alpha/2017-09/msg00212.html\n+\t* lib/glob_internal.h (GLOBPAT_NONE, GLOBPAT_SPECIAL)\n+\t(GLOBPAT_BACKSLASH, GLOBPAT_BRACKET): New constants.\n+\t* lib/glob_internal.h (__glob_pattern_type):\n+\t* lib/glob.c (glob):\n+\t* lib/glob_pattern_p.c (__glob_pattern_p):\n+\tUse them.\n+\n \tglob: fix for use in glibc\n \tProblem reported by Adhemerval Zanella in:\n \thttps://sourceware.org/ml/libc-alpha/2017-09/msg00213.html\ndiff --git a/lib/glob.c b/lib/glob.c\nindex ddab535..4c6c31b 100644\n--- a/lib/glob.c\n+++ b/lib/glob.c\n@@ -903,7 +903,7 @@ glob (const char *pattern, int flags, int (*errfunc) (const char *, int),\n [ which we handle the same, using fnmatch. Broken unterminated\n pattern bracket expressions ought to be rare enough that it is\n not worth special casing them, fnmatch will do the right thing. */\n- if (meta & 5)\n+ if (meta & (GLOBPAT_SPECIAL | GLOBPAT_BRACKET))\n {\n /* The directory name contains metacharacters, so we\n have to glob for the directory, and then glob for\n@@ -1044,7 +1044,7 @@ glob (const char *pattern, int flags, int (*errfunc) (const char *, int),\n size_t old_pathc = pglob->gl_pathc;\n int orig_flags = flags;\n \n- if (meta & 2)\n+ if (meta & GLOBPAT_BACKSLASH)\n {\n char *p = strchr (dirname, '\\\\'), *q;\n /* We need to unescape the dirname string. It is certainly\n@@ -1242,14 +1242,14 @@ glob_in_dir (const char *pattern, const char *directory, int flags,\n / sizeof init_names->name[0]);\n \n meta = __glob_pattern_type (pattern, !(flags & GLOB_NOESCAPE));\n- if (meta == 0 && (flags & (GLOB_NOCHECK|GLOB_NOMAGIC)))\n+ if (meta == GLOBPAT_NONE && (flags & (GLOB_NOCHECK|GLOB_NOMAGIC)))\n {\n /* We need not do any tests. The PATTERN contains no meta\n characters and we must not return an error therefore the\n result will always contain exactly one name. */\n flags |= GLOB_NOCHECK;\n }\n- else if (meta == 0)\n+ else if (meta == GLOBPAT_NONE)\n {\n union\n {\ndiff --git a/lib/glob_internal.h b/lib/glob_internal.h\nindex 12c93660..d118b35 100644\n--- a/lib/glob_internal.h\n+++ b/lib/glob_internal.h\n@@ -19,35 +19,43 @@\n #ifndef GLOB_INTERNAL_H\n # define GLOB_INTERNAL_H\n \n+enum\n+{\n+ GLOBPAT_NONE = 0x0,\n+ GLOBPAT_SPECIAL = 0x1,\n+ GLOBPAT_BACKSLASH = 0x2,\n+ GLOBPAT_BRACKET = 0x4\n+};\n+\n static inline int\n __glob_pattern_type (const char *pattern, int quote)\n {\n const char *p;\n- int ret = 0;\n+ int ret = GLOBPAT_NONE;\n \n for (p = pattern; *p != '\\0'; ++p)\n switch (*p)\n {\n case '?':\n case '*':\n- return 1;\n+ return GLOBPAT_SPECIAL;\n \n case '\\\\':\n if (quote)\n {\n if (p[1] != '\\0')\n ++p;\n- ret |= 2;\n+ ret |= GLOBPAT_BACKSLASH;\n }\n break;\n \n case '[':\n- ret |= 4;\n+ ret |= GLOBPAT_BRACKET;\n break;\n \n case ']':\n if (ret & 4)\n- return 1;\n+ return GLOBPAT_SPECIAL;\n break;\n }\n \ndiff --git a/lib/glob_pattern_p.c b/lib/glob_pattern_p.c\nindex a17d337..8489106 100644\n--- a/lib/glob_pattern_p.c\n+++ b/lib/glob_pattern_p.c\n@@ -28,6 +28,6 @@\n int\n __glob_pattern_p (const char *pattern, int quote)\n {\n- return __glob_pattern_type (pattern, quote) == 1;\n+ return __glob_pattern_type (pattern, quote) == GLOBPAT_SPECIAL;\n }\n weak_alias (__glob_pattern_p, glob_pattern_p)","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","mailing list libc-alpha@sourceware.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=sourceware.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=libc-alpha-return-84228-incoming=patchwork.ozlabs.org@sourceware.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tsecure) header.d=sourceware.org header.i=@sourceware.org\n\theader.b=\"NmSJk9HI\"; dkim-atps=neutral","sourceware.org; auth=none"],"Received":["from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xn9LQ305Nz9sNc\n\tfor ;\n\tWed, 6 Sep 2017 14:18:21 +1000 (AEST)","(qmail 11901 invoked by alias); 6 Sep 2017 04:18:14 -0000","(qmail 10100 invoked by uid 89); 6 Sep 2017 04:18:13 -0000"],"DomainKey-Signature":"a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:subject:to:references:from:message-id:date\n\t:mime-version:in-reply-to:content-type; q=dns; s=default; b=KNte\n\tnbSEj7bCBGS9iW4AMneump4xxXbzVNNfbMJv+vOcaaPHLDDwkZ9kpLgd/zs396Nq\n\tACJDcKuVvcqyNZeCr0uPJ5fNufY1oWn40wck0JnmN1rX0gCMA74KPl2yYIAHoFCO\n\tI7o1R8FDyaiIdWtv/KvVSjwotU/w0n/AIn4ckCk=","DKIM-Signature":"v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:subject:to:references:from:message-id:date\n\t:mime-version:in-reply-to:content-type; s=default; bh=KIhZidq4ic\n\tVfNQxZuQ9thq4JtJ0=; b=NmSJk9HItiMkO8INQg/D0mrfx3lG+/Qb8/BY77+aQO\n\tNBI74IVy0rOMuA3OBCSfBeQkFAu8csbl/INJC13pvbWWzTM9JE2zPFyph/gBhGRf\n\tROyEsLROGP53sl2WBNP3hIzkh1p7UMPFpXaHhG5UA53s7uTci7iQKpEkmZ2LHlvV\n\tk=","Mailing-List":"contact libc-alpha-help@sourceware.org; run by ezmlm","Precedence":"bulk","List-Id":"","List-Unsubscribe":"","List-Subscribe":"","List-Archive":"","List-Post":"","List-Help":",\n\t","Sender":"libc-alpha-owner@sourceware.org","X-Virus-Found":"No","X-Spam-SWARE-Status":"No, score=-24.8 required=5.0 tests=AWL, BAYES_00,\n\tGIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3,\n\tRP_MATCHES_RCVD, SPF_PASS autolearn=ham version=3.3.2 spammy=","X-HELO":"zimbra.cs.ucla.edu","Subject":"Re: [PATCH 8/9] posix: Use enum for __glob_pattern_type result","To":"Adhemerval Zanella ,\n\tlibc-alpha@sourceware.org, Gnulib bugs ","References":"<1504643122-14874-1-git-send-email-adhemerval.zanella@linaro.org>\n\t<1504643122-14874-9-git-send-email-adhemerval.zanella@linaro.org>","From":"Paul Eggert ","Message-ID":"<018ac06d-cb0a-edb9-7de5-560f614fda80@cs.ucla.edu>","Date":"Tue, 5 Sep 2017 21:18:08 -0700","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<1504643122-14874-9-git-send-email-adhemerval.zanella@linaro.org>","Content-Type":"multipart/mixed;\n\tboundary=\"------------2C34B955F1C7669A1775BD52\""}},{"id":1764097,"web_url":"http://patchwork.ozlabs.org/comment/1764097/","msgid":"","list_archive_url":null,"date":"2017-09-06T13:03:53","subject":"Re: [PATCH 8/9] posix: Use enum for __glob_pattern_type result","submitter":{"id":66065,"url":"http://patchwork.ozlabs.org/api/people/66065/","name":"Adhemerval Zanella Netto","email":"adhemerval.zanella@linaro.org"},"content":"On 06/09/2017 01:18, Paul Eggert wrote:\n> Adhemerval Zanella wrote:\n>> +enum glob_pattern_type_t\n>> +{\n>> + __GLOB_NONE = 0x0,\n>> + __GLOB_SPECIAL = 0x1,\n>> + __GLOB_BACKSLASH = 0x2,\n>> + __GLOB_BRACKET = 0x4\n>> +};\n> \n> The identifier glob_pattern_type_t is not used elsewhere, so let's omit it. This makes it clearer that we're merely defining handy names for int constants, as opposed to defining a new type.\n\nAck.\n\n> \n> Also, names like __GLOB_NONE could cause problems when Gnulib is used on non-GNU platforms, which might use those names for other purposes. As glob_internal.h is not user-visible, let's use ordinary names. I suggest GLOBPAT_NONE, GLOBPAT_SPECIAL, etc., as done in the attached patch, which I installed into Gnulib.\n\nMy understanding was double underscore identifiers are reserved for implementation\n(C99 7.1.3 Reserved identifiers). But I do not have a strong opinion here, I am \nok with your approach.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","mailing list libc-alpha@sourceware.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=sourceware.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=libc-alpha-return-84246-incoming=patchwork.ozlabs.org@sourceware.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tsecure) header.d=sourceware.org header.i=@sourceware.org\n\theader.b=\"kAGqtYUz\"; dkim-atps=neutral","sourceware.org; auth=none"],"Received":["from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xnP1B2jt3z9sBd\n\tfor ;\n\tWed, 6 Sep 2017 23:04:14 +1000 (AEST)","(qmail 95897 invoked by alias); 6 Sep 2017 13:04:07 -0000","(qmail 95886 invoked by uid 89); 6 Sep 2017 13:04:06 -0000"],"DomainKey-Signature":"a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:subject:to:references:from:message-id:date\n\t:mime-version:in-reply-to:content-type\n\t:content-transfer-encoding; q=dns; s=default; b=ONSBNNdVif4eKGg9\n\tFijBWYKjHMJM7Ef0FJ92MBlFQ3UjYfNQhEEVn8MM/1oLRZbJxRJkE9G/cQCle0am\n\tS19A+4Axe4bBzwE96M2nJyQV3rxVyMgXtNZcVncoRwvkzmKmLjpxBinaI11KrOBN\n\ti2PLBz5nM/MH96CW9fi0q6D5gEk=","DKIM-Signature":"v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:subject:to:references:from:message-id:date\n\t:mime-version:in-reply-to:content-type\n\t:content-transfer-encoding; s=default; bh=+Br7M6LlDxzU11PRpVQgFo\n\tvLiCc=; b=kAGqtYUzH68CBGvCx4dQ5yIoeNBKYSlK3KLq1HrLA4tG2S6l/IbUrJ\n\tIlJfh/Cfovyaxm2LaeeI1XQ6JFP1gCc5MCnD7fDw7NZpy5aOpYO7l9N+d/pUupYJ\n\tH6yjGB4Xbk0goayMIOcGcJITDMSPolOq82Xb/1xbu9F3GVDoPLRUY=","Mailing-List":"contact libc-alpha-help@sourceware.org; run by ezmlm","Precedence":"bulk","List-Id":"","List-Unsubscribe":"","List-Subscribe":"","List-Archive":"","List-Post":"","List-Help":",\n\t","Sender":"libc-alpha-owner@sourceware.org","X-Virus-Found":"No","X-Spam-SWARE-Status":"No, score=-1.4 required=5.0 tests=BAYES_00,\n\tRCVD_IN_DNSWL_NONE, RCVD_IN_SORBS_SPAM,\n\tSPF_PASS autolearn=no version=3.3.2 spammy=reserved,\n\tHContent-Transfer-Encoding:8bit","X-HELO":"mail-qk0-f176.google.com","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=7EkeYVrrI4a5/vzxA9l57TB+dawaqDOaL4v2x1hb/as=;\n\tb=JGiGe4JyuwJ/zgpelL9BrZvnr1GMR/puj/1GvTG6J16xFXQotu0Kc0XeJBRe5b5bYa\n\t9VVHrSZW49+bOzC1t3yyWEnIj07zzR1z0+8goZNNui6ISSt9jTdr467zZFlUoUYLKrB+\n\tVx99KPbAxQHyispxMvNJaMrj3FFDyX9m9oYgAzDBO0wRWBocZ2vAgl18RojTdrj9N/5E\n\tWGTuYGvCWLv3aji+F7FDwddtUm80smstwkyMX/4M9BdnXvqUghmU494PmEfpEfhAa6+k\n\thAl0YJL7BKEmpRnqOQZlts9ZqbcYntbr/mh1k/kdl86+jIR5SxNbJwYqv4275zkgH7JF\n\tvxuA==","X-Gm-Message-State":"AHPjjUjtCtbwJLZmPzsR4xLu+tEGOcKejRT7ZN0dPU84Uo4P9+C4NAlS\n\t1mzK+buSES4daKCz2gMG/Q==","X-Google-Smtp-Source":"ADKCNb6SqIK8UWuESzzneHHoT4wRSwrk0bJp0S6V/KT9tO1I++bvpod/iIhQmKN8fCTU2zsvHVJmDA==","X-Received":"by 10.55.31.80 with SMTP id f77mr3104591qkf.95.1504703039256;\n\tWed, 06 Sep 2017 06:03:59 -0700 (PDT)","Subject":"Re: [PATCH 8/9] posix: Use enum for __glob_pattern_type result","To":"Paul Eggert , libc-alpha@sourceware.org,\n\tGnulib bugs ","References":"<1504643122-14874-1-git-send-email-adhemerval.zanella@linaro.org>\n\t<1504643122-14874-9-git-send-email-adhemerval.zanella@linaro.org>\n\t<018ac06d-cb0a-edb9-7de5-560f614fda80@cs.ucla.edu>","From":"Adhemerval Zanella ","Message-ID":"","Date":"Wed, 6 Sep 2017 10:03:53 -0300","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<018ac06d-cb0a-edb9-7de5-560f614fda80@cs.ucla.edu>","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"8bit"}},{"id":1764233,"web_url":"http://patchwork.ozlabs.org/comment/1764233/","msgid":"","list_archive_url":null,"date":"2017-09-06T16:18:55","subject":"Re: [PATCH 8/9] posix: Use enum for __glob_pattern_type result","submitter":{"id":4434,"url":"http://patchwork.ozlabs.org/api/people/4434/","name":"Paul Eggert","email":"eggert@CS.UCLA.EDU"},"content":"Adhemerval Zanella wrote:\n> My understanding was double underscore identifiers are reserved for implementation\n> (C99 7.1.3 Reserved identifiers).\n\nYes, and that's the point. When this code is used as part of Gnulib, it is used \nwithin an application, so any identifiers it uses that start with __ might \ncollide with the implementation, which means it's safer to avoid them when it's \neasy, as is the case here.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","mailing list libc-alpha@sourceware.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=sourceware.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=libc-alpha-return-84269-incoming=patchwork.ozlabs.org@sourceware.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tsecure) header.d=sourceware.org header.i=@sourceware.org\n\theader.b=\"J/oJzerK\"; dkim-atps=neutral","sourceware.org; auth=none"],"Received":["from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xnTL2167Nz9s7c\n\tfor ;\n\tThu, 7 Sep 2017 02:19:05 +1000 (AEST)","(qmail 81695 invoked by alias); 6 Sep 2017 16:18:59 -0000","(qmail 81682 invoked by uid 89); 6 Sep 2017 16:18:58 -0000"],"DomainKey-Signature":"a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:subject:to:references:from:message-id:date\n\t:mime-version:in-reply-to:content-type\n\t:content-transfer-encoding; q=dns; s=default; b=ujB0fqyAvFADcKkN\n\tXLH/5j0Y5nUwImCGkDF/+/wuYq0Pwic1kYWtDMMcWElim0nsBKiMlHzq8RR4S1Cx\n\tTRlHxquvJHMoD4CHj2cBcANuWu0nfs5pInPJHSzO6W4Op9vvFHlBkVaHCErkfq5d\n\t870wHmTWjR2H0aEkoEoYYgwdPq4=","DKIM-Signature":"v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:subject:to:references:from:message-id:date\n\t:mime-version:in-reply-to:content-type\n\t:content-transfer-encoding; s=default; bh=zdjthCB66LSojWqNKICeen\n\tZdA+k=; b=J/oJzerKSTGpAgq4PEcXiIEu/m1qb2SaS30VdC+3bwVWpBx6EOP25z\n\tiT1BhxEgh7y7OvC7P1Jq0hruiS6G7DdKpfyHKrmkfIOQDTLJMmZsnS0Mep59naXj\n\tVKMAjSDcc7wBnvxkE/ocvJeU/ZQGt5JEEVFV4kEN3bHBQvkh6yzFs=","Mailing-List":"contact libc-alpha-help@sourceware.org; run by ezmlm","Precedence":"bulk","List-Id":"","List-Unsubscribe":"","List-Subscribe":"","List-Archive":"","List-Post":"","List-Help":",\n\t","Sender":"libc-alpha-owner@sourceware.org","X-Virus-Found":"No","X-Spam-SWARE-Status":"No, score=-2.4 required=5.0 tests=AWL, BAYES_00,\n\tRP_MATCHES_RCVD,\n\tSPF_PASS autolearn=ham version=3.3.2 spammy=reserved","X-HELO":"zimbra.cs.ucla.edu","Subject":"Re: [PATCH 8/9] posix: Use enum for __glob_pattern_type result","To":"Adhemerval Zanella ,\n\tlibc-alpha@sourceware.org, Gnulib bugs ","References":"<1504643122-14874-1-git-send-email-adhemerval.zanella@linaro.org>\n\t<1504643122-14874-9-git-send-email-adhemerval.zanella@linaro.org>\n\t<018ac06d-cb0a-edb9-7de5-560f614fda80@cs.ucla.edu>\n\t","From":"Paul Eggert ","Message-ID":"","Date":"Wed, 6 Sep 2017 09:18:55 -0700","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Transfer-Encoding":"7bit"}},{"id":1764261,"web_url":"http://patchwork.ozlabs.org/comment/1764261/","msgid":"","list_archive_url":null,"date":"2017-09-06T16:54:23","subject":"Re: [PATCH 8/9] posix: Use enum for __glob_pattern_type result","submitter":{"id":66065,"url":"http://patchwork.ozlabs.org/api/people/66065/","name":"Adhemerval Zanella Netto","email":"adhemerval.zanella@linaro.org"},"content":"On 06/09/2017 13:18, Paul Eggert wrote:\n> Adhemerval Zanella wrote:\n>> My understanding was double underscore identifiers are reserved for implementation\n>> (C99 7.1.3 Reserved identifiers).\n> \n> Yes, and that's the point. When this code is used as part of Gnulib, it is used within an application, so any identifiers it uses that start with __ might collide with the implementation, which means it's safer to avoid them when it's easy, as is the case here.\n\nRight, I got your point.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","mailing list libc-alpha@sourceware.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=sourceware.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=libc-alpha-return-84271-incoming=patchwork.ozlabs.org@sourceware.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tsecure) header.d=sourceware.org header.i=@sourceware.org\n\theader.b=\"r5uwD27i\"; dkim-atps=neutral","sourceware.org; auth=none"],"Received":["from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xnV745bhzz9t2d\n\tfor ;\n\tThu, 7 Sep 2017 02:54:40 +1000 (AEST)","(qmail 96282 invoked by alias); 6 Sep 2017 16:54:33 -0000","(qmail 96272 invoked by uid 89); 6 Sep 2017 16:54:33 -0000"],"DomainKey-Signature":"a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:subject:to:references:from:message-id:date\n\t:mime-version:in-reply-to:content-type\n\t:content-transfer-encoding; q=dns; s=default; b=h+xt4GqVs0TZgSyg\n\tXRIK6xX3kZOTlhWYpr9r2InTrxMkKfF2fEYoJGBGppBFLPC0UwWj3/eL+W3F0CMs\n\taJD/Q8qKy9S5zc1doOID+qpY2vyDLCwoRtVNNPkf2Fj2vigqghxiBt6v38QcdQDc\n\tIxbdU3CXMBeuvkKBDbDWMD68Tts=","DKIM-Signature":"v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:subject:to:references:from:message-id:date\n\t:mime-version:in-reply-to:content-type\n\t:content-transfer-encoding; s=default; bh=q86oeDXietyYLUAYu/hioE\n\t0NvYw=; b=r5uwD27iVDFmh/hQuIQb00UX4XRaIT/LY+zow+JasPVD4pixwaEX6T\n\tfehChYoxafzL9OLV75Z8WsOvA0fYlaQbsQ1zpGb972ZcqJdEwa8EcoDmzlI719Of\n\t/BrSP9VwdrbBRTne88V2dl+frq+dvB7UTtkzPwlRug0uLrm6zGxe8=","Mailing-List":"contact libc-alpha-help@sourceware.org; run by ezmlm","Precedence":"bulk","List-Id":"","List-Unsubscribe":"","List-Subscribe":"","List-Archive":"","List-Post":"","List-Help":",\n\t","Sender":"libc-alpha-owner@sourceware.org","X-Virus-Found":"No","X-Spam-SWARE-Status":"No, score=-1.4 required=5.0 tests=BAYES_00,\n\tRCVD_IN_DNSWL_NONE, RCVD_IN_SORBS_SPAM,\n\tSPF_PASS autolearn=no version=3.3.2 spammy=reserved","X-HELO":"mail-qk0-f177.google.com","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=SMEyNH1LYnxmVkF4RiRwq1Gz8QGU65j7Uo9PHFs9mS8=;\n\tb=fZuPHHpn9xFGBiCr9CoVNYOEtslpsRcRdui+nFUc/xAhdrv2Y2MpN+ckE/UxordWcK\n\tmFdywlwLPgRpiTUxDjvePuRCn2zKfE/IzrV9vp0wp4CgyQ+jysl4MDSkbUP0/BDntrpc\n\tzgglUBUuLndxKUeCm3jevvEqAiov9HRW75/wAlHjLGzT4I0pqAnQ/2JDy41hXDwxp+Ai\n\tXTlzGW+GDmZc33HBevjdD08LS7kCKmdhjAhptYkIjylmekfFswzDDz4VwQSH8NC+Gnzo\n\tzhQYvrJ20lR6oe++rwVecTnTEINhb66kYnIgujbfsJaIMG4KpoJPMM8ALqkT11ppcJ3K\n\tBa3w==","X-Gm-Message-State":"AHPjjUidFyNrsbxw3StVEz622/umH19LJflKih9lyDq9xytTqajWbfSq\n\t6CZ7Aqrj+IuzdDQr","X-Google-Smtp-Source":"ADKCNb4w2uLEAwUDrUmiV7s7Jx33FgiTl9ghcbEOWG+jQQblTfIT1/ikBOG5l2Fmlf7zrYu6yvtgYQ==","X-Received":"by 10.55.24.161 with SMTP id 33mr4065811qky.220.1504716870246;\n\tWed, 06 Sep 2017 09:54:30 -0700 (PDT)","Subject":"Re: [PATCH 8/9] posix: Use enum for __glob_pattern_type result","To":"Paul Eggert , libc-alpha@sourceware.org,\n\tGnulib bugs ","References":"<1504643122-14874-1-git-send-email-adhemerval.zanella@linaro.org>\n\t<1504643122-14874-9-git-send-email-adhemerval.zanella@linaro.org>\n\t<018ac06d-cb0a-edb9-7de5-560f614fda80@cs.ucla.edu>\n\t\n\t","From":"Adhemerval Zanella ","Message-ID":"","Date":"Wed, 6 Sep 2017 13:54:23 -0300","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"7bit"}}]