[{"id":1766718,"web_url":"http://patchwork.ozlabs.org/comment/1766718/","msgid":"","list_archive_url":null,"date":"2017-09-12T07:35:17","subject":"Re: [PATCH 7/9] posix: Consolidate glob implementation","submitter":{"id":37,"url":"http://patchwork.ozlabs.org/api/people/37/","name":"Andreas Schwab","email":"schwab@suse.de"},"content":"On Sep 05 2017, Adhemerval Zanella wrote:\n\n> * On Linux all implementation now uses a default one with the exception\n> of alpha (which requires specific versioning) and s390-32 (which\n> different than other 32 bits with support for v2.1 symbol does not\n> add a compat one).\n\nThis drops the default glob64 symbol from s390 (the glob64@GLIBC_2.1\nsymbol is now hidden).\n\nAndreas.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","mailing list libc-alpha@sourceware.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=sourceware.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=libc-alpha-return-84476-incoming=patchwork.ozlabs.org@sourceware.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tsecure) header.d=sourceware.org header.i=@sourceware.org\n\theader.b=\"ehkhGizV\"; dkim-atps=neutral","sourceware.org; auth=none"],"Received":["from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xrxRC2fbcz9s8J\n\tfor ;\n\tTue, 12 Sep 2017 17:35:34 +1000 (AEST)","(qmail 12670 invoked by alias); 12 Sep 2017 07:35:26 -0000","(qmail 1559 invoked by uid 89); 12 Sep 2017 07:35:21 -0000"],"DomainKey-Signature":"a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:from:to:cc:subject:references:date:in-reply-to\n\t:message-id:mime-version:content-type; q=dns; s=default; b=GlTXA\n\t0O/RGYPKiNXwwr1FXbqpx9+Q3URZ0Kco5tYUGupmqj1R1PcKGN7z3b3lBmemyrTL\n\tyL5iWrFU7Jsh49I2TW+DDCVpe1N6qhOQ02iwMREbKYq2aR9EDGUp0NhlVzDa4AOM\n\tCQ0PyGu2sSKA0oRhtCDOIF+v48vpeyJYnguD/k=","DKIM-Signature":"v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:from:to:cc:subject:references:date:in-reply-to\n\t:message-id:mime-version:content-type; s=default; bh=Rkv5NpTejg1\n\tYQQ1hBDrlYMTWKMY=; b=ehkhGizVWs7/AyUM3L5Qm7fPRyu9QqlBGl+FecVjkXI\n\tdNCwET6O9YWcj4Xqz5B2aXEaKpMl7ApoZMYAAiR8ouCsjvqQg8NqulLi8pzw8aKq\n\tEDb8uE7XmiU4+biZEXBkcfB3Yw4M9fV0nawURilKlFllGsmK4P+ohEnPpweJIuTU\n\t=","Mailing-List":"contact libc-alpha-help@sourceware.org; run by ezmlm","Precedence":"bulk","List-Id":"","List-Unsubscribe":"","List-Subscribe":"","List-Archive":"","List-Post":"","List-Help":",\n\t","Sender":"libc-alpha-owner@sourceware.org","X-Virus-Found":"No","X-Spam-SWARE-Status":"No, score=-1.9 required=5.0 tests=BAYES_00,\n\tRP_MATCHES_RCVD, SPF_PASS autolearn=ham version=3.3.2 spammy=","X-HELO":"mx1.suse.de","From":"Andreas Schwab ","To":"Adhemerval Zanella ","Cc":"libc-alpha@sourceware.org, Paul Eggert ","Subject":"Re: [PATCH 7/9] posix: Consolidate glob implementation","References":"<1504643122-14874-1-git-send-email-adhemerval.zanella@linaro.org>\n\t<1504643122-14874-8-git-send-email-adhemerval.zanella@linaro.org>","X-Yow":"My CODE of ETHICS is vacationing at famed SCHROON LAKE\n\tin upstate New York!!","Date":"Tue, 12 Sep 2017 09:35:17 +0200","In-Reply-To":"<1504643122-14874-8-git-send-email-adhemerval.zanella@linaro.org>\n\t(Adhemerval Zanella's message of \"Tue, 5 Sep 2017 17:25:20 -0300\")","Message-ID":"","User-Agent":"Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux)","MIME-Version":"1.0","Content-Type":"text/plain"}},{"id":1766991,"web_url":"http://patchwork.ozlabs.org/comment/1766991/","msgid":"","list_archive_url":null,"date":"2017-09-12T12:56:37","subject":"Re: [PATCH 7/9] posix: Consolidate glob implementation","submitter":{"id":37,"url":"http://patchwork.ozlabs.org/api/people/37/","name":"Andreas Schwab","email":"schwab@suse.de"},"content":"On Sep 05 2017, Adhemerval Zanella wrote:\n\n> diff --git a/sysdeps/unix/sysv/linux/oldglob.c b/sysdeps/unix/sysv/linux/oldglob.c\n> index 8233e57..5402450 100644\n> --- a/sysdeps/unix/sysv/linux/oldglob.c\n> +++ b/sysdeps/unix/sysv/linux/oldglob.c\n> @@ -1,12 +1,13 @@\n> #include \n> \n> -#if SHLIB_COMPAT(libc, GLIBC_2_1, GLIBC_2_2)\n> +#if SHLIB_COMPAT(libc, GLIBC_2_1, GLIBC_2_2) \\\n> + && !defined(GLOB_NO_OLD_VERSION)\n\nThere is nothing that defines GLOB_NO_OLD_VERSION for s390-32.\n\nAndreas.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","mailing list libc-alpha@sourceware.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=sourceware.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=libc-alpha-return-84496-incoming=patchwork.ozlabs.org@sourceware.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tsecure) header.d=sourceware.org header.i=@sourceware.org\n\theader.b=\"uA335ll6\"; dkim-atps=neutral","sourceware.org; auth=none"],"Received":["from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xs4Yw2JPCz9t2l\n\tfor ;\n\tTue, 12 Sep 2017 22:56:52 +1000 (AEST)","(qmail 127432 invoked by alias); 12 Sep 2017 12:56:46 -0000","(qmail 127419 invoked by uid 89); 12 Sep 2017 12:56:46 -0000"],"DomainKey-Signature":"a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:from:to:cc:subject:references:date:in-reply-to\n\t:message-id:mime-version:content-type; q=dns; s=default; b=Ffztf\n\tgD7Oe1px/8lI5a9WD1/Tk4Fuig2UeQSOphrZ91k7mxcd6HVoK9q6UASL/G2B9sq7\n\tyPvGVfj0gFpQaUD4drd54Gp3k4xKlnwrLjVWov2LhQVH7ZPIY/sfwvReveStP8Z/\n\ttKFjlCaJp5EvFrOed0RO4ZKfztZgxyNWle73bU=","DKIM-Signature":"v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:from:to:cc:subject:references:date:in-reply-to\n\t:message-id:mime-version:content-type; s=default; bh=S1Detna9fdg\n\thtAtQmjqL/CE4uYk=; b=uA335ll6pGKm0ed7QLwsllZbnj7vS5bMaMwT/8B60w+\n\tmBC9bbqZnzeie5O+fYbpaCPTMqlbbf3f6qiWJF1X47ZAGBXBVDwWz4m6Ex5xUe6w\n\tniA1aH5OSMdGGIWIIJAC9XLRmduoY5MgJ/85Iri6mJgVQG2BTZ94ZpgKnkojxfvw\n\t=","Mailing-List":"contact libc-alpha-help@sourceware.org; run by ezmlm","Precedence":"bulk","List-Id":"","List-Unsubscribe":"","List-Subscribe":"","List-Archive":"","List-Post":"","List-Help":",\n\t","Sender":"libc-alpha-owner@sourceware.org","X-Virus-Found":"No","X-Spam-SWARE-Status":"No, score=-26.9 required=5.0 tests=BAYES_00, GIT_PATCH_0,\n\tGIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RP_MATCHES_RCVD,\n\tSPF_PASS autolearn=ham version=3.3.2 spammy=","X-HELO":"mx1.suse.de","From":"Andreas Schwab ","To":"Adhemerval Zanella ","Cc":"libc-alpha@sourceware.org, Paul Eggert ","Subject":"Re: [PATCH 7/9] posix: Consolidate glob implementation","References":"<1504643122-14874-1-git-send-email-adhemerval.zanella@linaro.org>\n\t<1504643122-14874-8-git-send-email-adhemerval.zanella@linaro.org>","X-Yow":"UH-OH!! We're out of AUTOMOBILE PARTS and RUBBER GOODS!","Date":"Tue, 12 Sep 2017 14:56:37 +0200","In-Reply-To":"<1504643122-14874-8-git-send-email-adhemerval.zanella@linaro.org>\n\t(Adhemerval Zanella's message of \"Tue, 5 Sep 2017 17:25:20 -0300\")","Message-ID":"","User-Agent":"Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux)","MIME-Version":"1.0","Content-Type":"text/plain"}},{"id":1767097,"web_url":"http://patchwork.ozlabs.org/comment/1767097/","msgid":"<320fff7d-b831-f00a-88ac-95e6367d5a0b@linaro.org>","list_archive_url":null,"date":"2017-09-12T14:08:46","subject":"Re: [PATCH 7/9] posix: Consolidate glob implementation","submitter":{"id":66065,"url":"http://patchwork.ozlabs.org/api/people/66065/","name":"Adhemerval Zanella Netto","email":"adhemerval.zanella@linaro.org"},"content":"On 12/09/2017 04:35, Andreas Schwab wrote:\n> On Sep 05 2017, Adhemerval Zanella wrote:\n> \n>> * On Linux all implementation now uses a default one with the exception\n>> of alpha (which requires specific versioning) and s390-32 (which\n>> different than other 32 bits with support for v2.1 symbol does not\n>> add a compat one).\n> \n> This drops the default glob64 symbol from s390 (the glob64@GLIBC_2.1\n> symbol is now hidden).\n> \n> Andreas.\n> \n\nThat was not what I am seeing from master:\n\n$ file libc.so\nlibc.so: ELF 32-bit MSB shared object, IBM S/390, version 1 (GNU/Linux), dynamically linked, interpreter /lib/ld.so.1, for GNU/Linux 3.2.0, not stripped\n$ s390x-glibc-linux-gnu-objdump -t libc.so | grep glob64\n00000000 l df *ABS* 00000000 glob64.os\n001221c8 l F .text 0000144e __GI___old_glob64\n000b3330 l F .text 0000144e glob64\n000b3330 l F .text 0000144e __GI_glob64\n000b3330 l F .text 0000144e __glob64\n001221c8 l F .text 0000144e __old_glob64\n001221c8 g F .text 0000144e glob64@GLIBC_2.1\n\nAnd checking the build of glob64.os for s390 I do see:\n\n[...]\nextern __typeof (__glob64) glob64 __attribute__ ((alias (\"__glob64\")));\nextern __typeof (glob64) __EI_glob64 __asm__(\"\" \"glob64\"); extern __typeof (glob64) __EI_glob64 __attribute__((alias (\"\" \"__GI_glob64\")));\n[...]\n\n$ s390x-glibc-linux-gnu-objdump -t posix/glob64.os | grep glob64\nposix/glob64.os: file format elf32-s390\n000009b0 g F .text 0000144e __glob64\n000009b0 g F .text 0000144e .hidden __GI_glob64\n000009b0 g F .text 0000144e glob64\n\nAnd make check/check-abi does not report this issue as well. That kind of issue\nshould be reported by make check-abi, shouldn't it? Are you seeing with on \nmake check?","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","mailing list libc-alpha@sourceware.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=sourceware.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=libc-alpha-return-84500-incoming=patchwork.ozlabs.org@sourceware.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tsecure) header.d=sourceware.org header.i=@sourceware.org\n\theader.b=\"KRcobhPD\"; dkim-atps=neutral","sourceware.org; auth=none"],"Received":["from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xs69G6H6Sz9s82\n\tfor ;\n\tWed, 13 Sep 2017 00:09:06 +1000 (AEST)","(qmail 98038 invoked by alias); 12 Sep 2017 14:08:59 -0000","(qmail 98029 invoked by uid 89); 12 Sep 2017 14:08:59 -0000"],"DomainKey-Signature":"a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:subject:to:cc:references:from:message-id:date\n\t:mime-version:in-reply-to:content-type\n\t:content-transfer-encoding; q=dns; s=default; b=ZXyDWp2Bbt3WVuYr\n\t/B8BXm3JoSdvjKpejAftzR5WUCq1REMU6C5YrbQPwqOsJozWv6OWj7NRHFhgnKaX\n\teq0yWVqVrmw9tG1r9FsA2S1ww/G1Whl6KddDSLiF4TdIpWCnqm4GVvw6kprZJZ2u\n\ttOuZfWCxcF/2szssid4cxrv7JKM=","DKIM-Signature":"v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:subject:to:cc:references:from:message-id:date\n\t:mime-version:in-reply-to:content-type\n\t:content-transfer-encoding; s=default; bh=YdIsIx8pgW829n+arbYWFt\n\ti6X8M=; b=KRcobhPDIzDHheTbRHzrFts+DhFNOMW00C5sAptPNkh/HaY4LIje4I\n\tnBYTqyzRJY84BRz0jClHTHorkbMUnCvlzDU0cBL4t5lvM1BgFro/EkA8XXMV7SSJ\n\tZYSHRBQzh7oTF3/Ew8mHvXm/HVJURsz0KJfTmc982HW9CDChr7SoE=","Mailing-List":"contact libc-alpha-help@sourceware.org; run by ezmlm","Precedence":"bulk","List-Id":"","List-Unsubscribe":"","List-Subscribe":"","List-Archive":"","List-Post":"","List-Help":",\n\t","Sender":"libc-alpha-owner@sourceware.org","X-Virus-Found":"No","X-Spam-SWARE-Status":"No, score=-1.9 required=5.0 tests=BAYES_00,\n\tRCVD_IN_DNSWL_NONE,\n\tSPF_PASS autolearn=ham version=3.3.2 spammy=H*M:b831","X-HELO":"mail-qk0-f178.google.com","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:cc:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=Q6MI0MfYzNon8Zu18iqfN1cM301LLj4u8QiYWtiBgkc=;\n\tb=TAb2wi1JEyVTTe06oonMr8/8mTJqfS9NBQH5SKjTVIvXsl8qwtzyOTfeq/2xK1CjAl\n\tm/Ckj22HtFaffanbVPEqLGl8zoaXoerOwYdrU6ynDVaDyiTUYSrWmjymxDgLjsjNPxIz\n\tuc2xLwU1qS5YZPr5up+rzStJcHx+QNg/4lOiddH9FKmYLlLHPMMXLY+eOPadP+bR2Dmd\n\trE4Sb3DKbV/8Q+EmpH47ODR58L5ifhT3P3TcU9C/vq3rVA8eb1xTuwcW2e4k6j4TnkWJ\n\tYj9hQtHFun4WzW4zIyZ48XE+HdJ0+WtSt2tlm4H/DFbI2l/5+o+2RJsftdsaMQT6z3Jb\n\tYmdA==","X-Gm-Message-State":"AHPjjUhHSYhWe+3Uz9GpzNc2SoNIHxjoPh/M3LfT5EFW7YK1WMuIgKYI\n\t+/xHlk3Llicv5lF4BXOygA==","X-Google-Smtp-Source":"AOwi7QBRV8kQYU9u1i/gnb/36g7xJtoInod/iutGFhZdw52x5oaDZfXht7LJVVOw2iGKoFfb7IXJoA==","X-Received":"by 10.55.19.136 with SMTP id 8mr19973149qkt.144.1505225334628;\n\tTue, 12 Sep 2017 07:08:54 -0700 (PDT)","Subject":"Re: [PATCH 7/9] posix: Consolidate glob implementation","To":"Andreas Schwab ","Cc":"libc-alpha@sourceware.org, Paul Eggert ","References":"<1504643122-14874-1-git-send-email-adhemerval.zanella@linaro.org>\n\t<1504643122-14874-8-git-send-email-adhemerval.zanella@linaro.org>\n\t","From":"Adhemerval Zanella ","Message-ID":"<320fff7d-b831-f00a-88ac-95e6367d5a0b@linaro.org>","Date":"Tue, 12 Sep 2017 11:08:46 -0300","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"8bit"}},{"id":1767109,"web_url":"http://patchwork.ozlabs.org/comment/1767109/","msgid":"","list_archive_url":null,"date":"2017-09-12T14:17:48","subject":"Re: [PATCH 7/9] posix: Consolidate glob implementation","submitter":{"id":37,"url":"http://patchwork.ozlabs.org/api/people/37/","name":"Andreas Schwab","email":"schwab@suse.de"},"content":"On Sep 12 2017, Adhemerval Zanella wrote:\n\n> That was not what I am seeing from master:\n\nIt comes from oldglob.\n\n> And make check/check-abi does not report this issue as well. That kind of issue\n> should be reported by make check-abi, shouldn't it?\n\nNo, this is part of the API, not the ABI (which is still correct).\n\nAndreas.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","mailing list libc-alpha@sourceware.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=sourceware.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=libc-alpha-return-84502-incoming=patchwork.ozlabs.org@sourceware.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tsecure) header.d=sourceware.org header.i=@sourceware.org\n\theader.b=\"IaD5Himy\"; dkim-atps=neutral","sourceware.org; auth=none"],"Received":["from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xs6MW6D5Lz9s0Z\n\tfor ;\n\tWed, 13 Sep 2017 00:17:59 +1000 (AEST)","(qmail 127060 invoked by alias); 12 Sep 2017 14:17:53 -0000","(qmail 126878 invoked by uid 89); 12 Sep 2017 14:17:53 -0000"],"DomainKey-Signature":"a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:from:to:cc:subject:references:date:in-reply-to\n\t:message-id:mime-version:content-type; q=dns; s=default; b=uoYVr\n\tY1Vn5bxSHvh12TDA83AIn08vx1h5p/sxViis+InjZifSAaGrZSrwP6+k4na50pPB\n\ti5yft/otzkH8YVqVJl931mIE/LMvgy5zqr9AJE4PRNGmvp2L8mKB5VNW/sVYFJlE\n\tuL8U9k8J7rPJ9DRiqmJ/cIpln4TpG1EqIt71Qs=","DKIM-Signature":"v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:from:to:cc:subject:references:date:in-reply-to\n\t:message-id:mime-version:content-type; s=default; bh=DyaijbCGZ1e\n\tUdFpoOJesz5dBpZ8=; b=IaD5HimyJJVRmMsHXgtyoJpeuBnHRXraqJVGXe4YDC5\n\tkLUKXxjSXiNjwEeJPImRyOHwbAXJHLN/o+gXcUhu4Kun5EefagEF9zCJkFsTsT0x\n\tjdBvdmGtQcT0O1ZAFJ7be+G86sawxXnrj/Ybo0A+q8xZBgpP2zUalBdkkA22BfNU\n\t=","Mailing-List":"contact libc-alpha-help@sourceware.org; run by ezmlm","Precedence":"bulk","List-Id":"","List-Unsubscribe":"","List-Subscribe":"","List-Archive":"","List-Post":"","List-Help":",\n\t","Sender":"libc-alpha-owner@sourceware.org","X-Virus-Found":"No","X-Spam-SWARE-Status":"No, score=-1.9 required=5.0 tests=BAYES_00,\n\tRP_MATCHES_RCVD, SPF_PASS autolearn=ham version=3.3.2 spammy=","X-HELO":"mx1.suse.de","From":"Andreas Schwab ","To":"Adhemerval Zanella ","Cc":"libc-alpha@sourceware.org, Paul Eggert ","Subject":"Re: [PATCH 7/9] posix: Consolidate glob implementation","References":"<1504643122-14874-1-git-send-email-adhemerval.zanella@linaro.org>\n\t<1504643122-14874-8-git-send-email-adhemerval.zanella@linaro.org>\n\t\n\t<320fff7d-b831-f00a-88ac-95e6367d5a0b@linaro.org>","X-Yow":"Is this where people are HOT and NICE and they give you TOAST for\n\tFREE??","Date":"Tue, 12 Sep 2017 16:17:48 +0200","In-Reply-To":"<320fff7d-b831-f00a-88ac-95e6367d5a0b@linaro.org> (Adhemerval\n\tZanella's message of \"Tue, 12 Sep 2017 11:08:46 -0300\")","Message-ID":"","User-Agent":"Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux)","MIME-Version":"1.0","Content-Type":"text/plain"}},{"id":1767118,"web_url":"http://patchwork.ozlabs.org/comment/1767118/","msgid":"<29c0bb72-189f-f8db-328e-05b9cdd84261@linaro.org>","list_archive_url":null,"date":"2017-09-12T14:21:52","subject":"Re: [PATCH 7/9] posix: Consolidate glob implementation","submitter":{"id":66065,"url":"http://patchwork.ozlabs.org/api/people/66065/","name":"Adhemerval Zanella Netto","email":"adhemerval.zanella@linaro.org"},"content":"On 12/09/2017 09:56, Andreas Schwab wrote:\n> On Sep 05 2017, Adhemerval Zanella wrote:\n> \n>> diff --git a/sysdeps/unix/sysv/linux/oldglob.c b/sysdeps/unix/sysv/linux/oldglob.c\n>> index 8233e57..5402450 100644\n>> --- a/sysdeps/unix/sysv/linux/oldglob.c\n>> +++ b/sysdeps/unix/sysv/linux/oldglob.c\n>> @@ -1,12 +1,13 @@\n>> #include \n>> \n>> -#if SHLIB_COMPAT(libc, GLIBC_2_1, GLIBC_2_2)\n>> +#if SHLIB_COMPAT(libc, GLIBC_2_1, GLIBC_2_2) \\\n>> + && !defined(GLOB_NO_OLD_VERSION)\n> \n> There is nothing that defines GLOB_NO_OLD_VERSION for s390-32.\n> \n> Andreas.\n> \n\nYes, this is wrong since oldglob.c as default will create symbol where\nfor s390 it should not. S390 requires a arch-specific oldglob.c as\n\n#define GLOB_NO_OLD_VERSION\n#include \n\nSo glob64.os will the only object providing glob64 symbols. With this\nfile now I see:\n\n$ /s390x-glibc-linux-gnu-objdump -t posix/glob64.os | grep glob64\nposix/glob64.os: file format elf32-s390\n000009b0 g F .text 0000144e __glob64\n000009b0 g F .text 0000144e .hidden __GI_glob64\n000009b0 g F .text 0000144e glob64\n$ s390x-glibc-linux-gnu-objdump -t posix/oldglob.os | grep glob64\n$ \n\nI will fix it and maybe it is confusing the linker and making you seem\nthe missing glob64 (since oldglob.os and glob64.os both provide the\nsame symbol).","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","mailing list libc-alpha@sourceware.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=sourceware.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=libc-alpha-return-84504-incoming=patchwork.ozlabs.org@sourceware.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tsecure) header.d=sourceware.org header.i=@sourceware.org\n\theader.b=\"OT8uFmjz\"; dkim-atps=neutral","sourceware.org; auth=none"],"Received":["from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xs6SK0YPYz9s0Z\n\tfor ;\n\tWed, 13 Sep 2017 00:22:08 +1000 (AEST)","(qmail 35797 invoked by alias); 12 Sep 2017 14:22:02 -0000","(qmail 35762 invoked by uid 89); 12 Sep 2017 14:22:02 -0000"],"DomainKey-Signature":"a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:subject:to:cc:references:from:message-id:date\n\t:mime-version:in-reply-to:content-type\n\t:content-transfer-encoding; q=dns; s=default; b=ePvNROCmX+5s0pa3\n\tWG1vHqKscm7ifbc812ZiIaCubbPvZG3ohEP4ipPSe16lNNpeaDacj9tg4zfqmwOh\n\tQfMlshbBDnCh9Q4bvsTYDO6j00BmHet7AzX68zHrshwzFItbbPjWcW6xgNiFCCjQ\n\tPDn9wQ3/phWWJuomlLXtpoqpj7M=","DKIM-Signature":"v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:subject:to:cc:references:from:message-id:date\n\t:mime-version:in-reply-to:content-type\n\t:content-transfer-encoding; s=default; bh=0EF0r9FFILGpAKbSDZlYlm\n\t3nKks=; b=OT8uFmjzT5a/FmEjnhhLLK4PfrdDhHa1S/spCZNZvtcKWOrKjCx+bP\n\t03TOYwE1J333yPOlBgDffFPaQdHOsuGuklJDOXIzLsZPL+RgEXHIDg4cuadFfY9+\n\tUakSSk8qpwE87DBBI7CUNDyhHhAgT3EdK73cv4myLUPOqhma+skg4=","Mailing-List":"contact libc-alpha-help@sourceware.org; run by ezmlm","Precedence":"bulk","List-Id":"","List-Unsubscribe":"","List-Subscribe":"","List-Archive":"","List-Post":"","List-Help":",\n\t","Sender":"libc-alpha-owner@sourceware.org","X-Virus-Found":"No","X-Spam-SWARE-Status":"No, score=-26.9 required=5.0 tests=BAYES_00, GIT_PATCH_0,\n\tGIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE,\n\tSPF_PASS autolearn=ham version=3.3.2 spammy=H*M:f8db","X-HELO":"mail-qk0-f172.google.com","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:cc:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=OFIHpIQUCp+4ceky0a+il4exb6JeYjcI6aqmQ26ueYU=;\n\tb=Kh3rpRmah8COO0Yi3n9dlBfd4zJOoR7fCgybB+f1/SvXoYkEZxAQwQTZvnOKev8YLZ\n\t+LwdbZ6WAUvOUyqCiN7bKi8if8s3QgXGjp9slVvYxPWIS4yJ3W3VkIJftw/8Vaq8a/vv\n\tvOdQkONXdGodtrFqSha7QNsvngl44vYKJFhdtaYAMMA4SZ936yrDbjTmYEOKD+76FuBk\n\tPj3B3Pqj/kfoD711ZiJEpxxbRR9cvNjrISWHyq3jwr2+vj+eejDsZMrRfhhfYg3T2u7d\n\tU3tssQ+ZBUP/KmaK3GKgRplDv6i1SGPBNtA/pZdL5VdWWC2ueGYoRpNYBZ3szPjTXuKi\n\tG2wg==","X-Gm-Message-State":"AHPjjUh2qZoXsFjLBh0nF2psnmTjHZuTXyOCfPCSjKsNlP3PA5EHn046\n\tq9Gc7dKNoDrndA8u","X-Google-Smtp-Source":"AOwi7QDPShv0J6j/canYGtj79pv31wNqMugQgtyR2j9RkT8Zjhjcap6oLZC77e5JbmkARAjYN8lPgA==","X-Received":"by 10.55.54.12 with SMTP id d12mr18734467qka.20.1505226119091;\n\tTue, 12 Sep 2017 07:21:59 -0700 (PDT)","Subject":"Re: [PATCH 7/9] posix: Consolidate glob implementation","To":"Andreas Schwab ","Cc":"libc-alpha@sourceware.org, Paul Eggert ","References":"<1504643122-14874-1-git-send-email-adhemerval.zanella@linaro.org>\n\t<1504643122-14874-8-git-send-email-adhemerval.zanella@linaro.org>\n\t","From":"Adhemerval Zanella ","Message-ID":"<29c0bb72-189f-f8db-328e-05b9cdd84261@linaro.org>","Date":"Tue, 12 Sep 2017 11:21:52 -0300","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"8bit"}},{"id":1767126,"web_url":"http://patchwork.ozlabs.org/comment/1767126/","msgid":"","list_archive_url":null,"date":"2017-09-12T14:28:57","subject":"Re: [PATCH 7/9] posix: Consolidate glob implementation","submitter":{"id":4349,"url":"http://patchwork.ozlabs.org/api/people/4349/","name":"Joseph Myers","email":"joseph@codesourcery.com"},"content":"On Tue, 12 Sep 2017, Andreas Schwab wrote:\n\n> On Sep 05 2017, Adhemerval Zanella wrote:\n> \n> > * On Linux all implementation now uses a default one with the exception\n> > of alpha (which requires specific versioning) and s390-32 (which\n> > different than other 32 bits with support for v2.1 symbol does not\n> > add a compat one).\n> \n> This drops the default glob64 symbol from s390 (the glob64@GLIBC_2.1\n> symbol is now hidden).\n\nDoes this mean we don't have any tests that verify a call to glob64 can be \nlinked (and works)? If so, such tests should be added (generally, all \nnon-compat symbols ought to be tested).","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","mailing list libc-alpha@sourceware.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=sourceware.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=libc-alpha-return-84506-incoming=patchwork.ozlabs.org@sourceware.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tsecure) header.d=sourceware.org header.i=@sourceware.org\n\theader.b=\"x251rPoQ\"; dkim-atps=neutral","sourceware.org; auth=none"],"Received":["from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xs6cW4X1Bz9s0Z\n\tfor ;\n\tWed, 13 Sep 2017 00:29:15 +1000 (AEST)","(qmail 60683 invoked by alias); 12 Sep 2017 14:29:09 -0000","(qmail 60662 invoked by uid 89); 12 Sep 2017 14:29:08 -0000"],"DomainKey-Signature":"a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:date:from:to:cc:subject:in-reply-to:message-id\n\t:references:mime-version:content-type; q=dns; s=default; b=cbkmZ\n\twdfO22OIm8GdgDJ76vtcGlj/AlqvQNlHgyZA+H5jtkOGKIdAuqTasTSr+sKFeERH\n\t1eoDTCVMUsIZQofqUbn3BXYmHDLS4FzA0t00IeXXvkZJRTlV6djEsHw2WNMYGMpm\n\tJBLgJFXq2M3nov+4tw9ytm/YWy9OB45N0G0Trg=","DKIM-Signature":"v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:date:from:to:cc:subject:in-reply-to:message-id\n\t:references:mime-version:content-type; s=default; bh=kpPmrDbrq8R\n\tAmXfebMmeDyVoGDA=; b=x251rPoQL2EMNhqfG4yIyL3LzQ+2xTO8hA23HkfrKXL\n\tAqlZVREerPP03dNOYV3obQtGc3nl71z0HnX5QsMhPsXWmNxCDghmyQ6x3PDozXCC\n\tbuGsoCF3WUG3MfhuysdUo88rvra9cWXTFiqnhkLnOrwIbJc+4oos0Rusgt0wqi54\n\t=","Mailing-List":"contact libc-alpha-help@sourceware.org; run by ezmlm","Precedence":"bulk","List-Id":"","List-Unsubscribe":"","List-Subscribe":"","List-Archive":"","List-Post":"","List-Help":",\n\t","Sender":"libc-alpha-owner@sourceware.org","X-Virus-Found":"No","X-Spam-SWARE-Status":"No, score=-2.0 required=5.0 tests=AWL, BAYES_00,\n\tRCVD_IN_DNSWL_NONE, SPF_PASS,\n\tURIBL_RED autolearn=ham version=3.3.2 spammy=","X-HELO":"relay1.mentorg.com","Date":"Tue, 12 Sep 2017 14:28:57 +0000","From":"Joseph Myers ","To":"Andreas Schwab ","CC":"Adhemerval Zanella ,\n\t, Paul Eggert ","Subject":"Re: [PATCH 7/9] posix: Consolidate glob implementation","In-Reply-To":"","Message-ID":"","References":"<1504643122-14874-1-git-send-email-adhemerval.zanella@linaro.org>\n\t<1504643122-14874-8-git-send-email-adhemerval.zanella@linaro.org>\n\t","User-Agent":"Alpine 2.20 (DEB 67 2015-01-07)","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"US-ASCII\"","X-ClientProxiedBy":"svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) To\n\tsvr-ies-mbx-01.mgc.mentorg.com (139.181.222.1)"}},{"id":1767130,"web_url":"http://patchwork.ozlabs.org/comment/1767130/","msgid":"","list_archive_url":null,"date":"2017-09-12T14:34:10","subject":"Re: [PATCH 7/9] posix: Consolidate glob implementation","submitter":{"id":37,"url":"http://patchwork.ozlabs.org/api/people/37/","name":"Andreas Schwab","email":"schwab@suse.de"},"content":"On Sep 12 2017, Adhemerval Zanella wrote:\n\n> I will fix it and maybe it is confusing the linker and making you seem\n> the missing glob64 (since oldglob.os and glob64.os both provide the\n> same symbol).\n\nglob64@GLIBC_2.1 is the only version and it isn't the default, thus\nbecomes hidden.\n\nAndreas.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","mailing list libc-alpha@sourceware.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=sourceware.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=libc-alpha-return-84508-incoming=patchwork.ozlabs.org@sourceware.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tsecure) header.d=sourceware.org header.i=@sourceware.org\n\theader.b=\"mjpiWlL0\"; dkim-atps=neutral","sourceware.org; auth=none"],"Received":["from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xs6kS1J3Qz9s3T\n\tfor ;\n\tWed, 13 Sep 2017 00:34:23 +1000 (AEST)","(qmail 85755 invoked by alias); 12 Sep 2017 14:34:15 -0000","(qmail 85722 invoked by uid 89); 12 Sep 2017 14:34:14 -0000"],"DomainKey-Signature":"a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:from:to:cc:subject:references:date:in-reply-to\n\t:message-id:mime-version:content-type; q=dns; s=default; b=v+ulc\n\ty4Zke4bDQdIJwB7CxaXcmcCIQ3SJw8JJ3PQ1GcFrbO+e7Fqdz9TV1MoZOAbKExWm\n\tbU4K/MWsI32eNBrWzEijDC+U34aDIrQfWysMaBXLZdTBHGl4fE0GzuJTYm3dO0Pr\n\tFOZd9dptJIeT+VZO5AeuJ7C17iCcRE01bM6Rzg=","DKIM-Signature":"v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:from:to:cc:subject:references:date:in-reply-to\n\t:message-id:mime-version:content-type; s=default; bh=yZcfXZa1JB/\n\to+Qm3X0O/IpE0PyM=; b=mjpiWlL0BYOp38/YwUXPFkZmA/xedLhEzN/zTn4lmxU\n\tRiiy7j/Xq8OG4OtcsexaM1oqvA+P5LKr72pCbU9P9lxRvgy9RDFLbV3hWx5DElXv\n\tGkIE4+2TbOffcalZxh3+ElWkZI7Pp/7/9D8DaU5nZxDTSDxQP0YSQNrO3lShQXp8\n\t=","Mailing-List":"contact libc-alpha-help@sourceware.org; run by ezmlm","Precedence":"bulk","List-Id":"","List-Unsubscribe":"","List-Subscribe":"","List-Archive":"","List-Post":"","List-Help":",\n\t","Sender":"libc-alpha-owner@sourceware.org","X-Virus-Found":"No","X-Spam-SWARE-Status":"No, score=-1.9 required=5.0 tests=BAYES_00,\n\tRP_MATCHES_RCVD, SPF_PASS autolearn=ham version=3.3.2 spammy=","X-HELO":"mx1.suse.de","From":"Andreas Schwab ","To":"Adhemerval Zanella ","Cc":"libc-alpha@sourceware.org, Paul Eggert ","Subject":"Re: [PATCH 7/9] posix: Consolidate glob implementation","References":"<1504643122-14874-1-git-send-email-adhemerval.zanella@linaro.org>\n\t<1504643122-14874-8-git-send-email-adhemerval.zanella@linaro.org>\n\t\n\t<29c0bb72-189f-f8db-328e-05b9cdd84261@linaro.org>","X-Yow":"...It's REAL ROUND.. And it's got a POINTY PART right in the MIDDLE!!\n\tThe shape is SMOOTH.. ..And COLD.. It feels very COMFORTABLE on my\n\tCHEEK.. I'm getting EMOTIONAL..","Date":"Tue, 12 Sep 2017 16:34:10 +0200","In-Reply-To":"<29c0bb72-189f-f8db-328e-05b9cdd84261@linaro.org> (Adhemerval\n\tZanella's message of \"Tue, 12 Sep 2017 11:21:52 -0300\")","Message-ID":"","User-Agent":"Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux)","MIME-Version":"1.0","Content-Type":"text/plain"}},{"id":1767134,"web_url":"http://patchwork.ozlabs.org/comment/1767134/","msgid":"","list_archive_url":null,"date":"2017-09-12T14:39:27","subject":"Re: [PATCH 7/9] posix: Consolidate glob implementation","submitter":{"id":37,"url":"http://patchwork.ozlabs.org/api/people/37/","name":"Andreas Schwab","email":"schwab@suse.de"},"content":"On Sep 12 2017, Joseph Myers wrote:\n\n> Does this mean we don't have any tests that verify a call to glob64 can be \n> linked (and works)? If so, such tests should be added (generally, all \n> non-compat symbols ought to be tested).\n\nIt's a long standing bug that we don't verify the API. See the various\nincidences about missing symbols on some architectures.\n\nAndreas.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","mailing list libc-alpha@sourceware.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=sourceware.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=libc-alpha-return-84510-incoming=patchwork.ozlabs.org@sourceware.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tsecure) header.d=sourceware.org header.i=@sourceware.org\n\theader.b=\"A54VXwkH\"; dkim-atps=neutral","sourceware.org; auth=none"],"Received":["from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xs6rV1wBxz9s3T\n\tfor ;\n\tWed, 13 Sep 2017 00:39:38 +1000 (AEST)","(qmail 125346 invoked by alias); 12 Sep 2017 14:39:32 -0000","(qmail 125332 invoked by uid 89); 12 Sep 2017 14:39:31 -0000"],"DomainKey-Signature":"a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:from:to:cc:subject:references:date:in-reply-to\n\t:message-id:mime-version:content-type; q=dns; s=default; b=hBYab\n\t7UQ+6RzusJI/FEod2sCPuo4bejDhXp7RjdLcl3dI15xkFck6b4X/O99nc+qYCnoG\n\tfZCjpTb+pjejgtMjRUSz9gVmILSWql0oTAQrRNjLNc3xqoB84EZZRb4AdkVVxcxh\n\tZPfOYW1N0VU10PYKwJymhhkJjnJqSRpLW9bV0E=","DKIM-Signature":"v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:from:to:cc:subject:references:date:in-reply-to\n\t:message-id:mime-version:content-type; s=default; bh=P6bXvu6/Bqf\n\tg/CU7U1/QoMSRoow=; b=A54VXwkHl2ggW6UBqAdjB3eQ0t9T5OEEMcYwX6UIwSt\n\t+Af3wORZ2WY1N/QLXAgfxevTC9ZhZjXm8JghEeanqm+WJYeTKTAHPM036RraKnZg\n\tvwoUJu4rf4fbjuyTjoRZgJby4sR9l/amzbL2Cpd2H14rWezkDyFyDIkbcA6vpaQs\n\t=","Mailing-List":"contact libc-alpha-help@sourceware.org; run by ezmlm","Precedence":"bulk","List-Id":"","List-Unsubscribe":"","List-Subscribe":"","List-Archive":"","List-Post":"","List-Help":",\n\t","Sender":"libc-alpha-owner@sourceware.org","X-Virus-Found":"No","X-Spam-SWARE-Status":"No, score=-1.9 required=5.0 tests=BAYES_00,\n\tRP_MATCHES_RCVD, SPF_PASS,\n\tURIBL_RED autolearn=ham version=3.3.2 spammy=","X-HELO":"mx1.suse.de","From":"Andreas Schwab ","To":"Joseph Myers ","Cc":"Adhemerval Zanella ,\n\t, Paul Eggert ","Subject":"Re: [PATCH 7/9] posix: Consolidate glob implementation","References":"<1504643122-14874-1-git-send-email-adhemerval.zanella@linaro.org>\n\t<1504643122-14874-8-git-send-email-adhemerval.zanella@linaro.org>\n\t\n\t","X-Yow":"Impudent.. Yet possessing a certain ALUMINUM SILICATE\n\toverbite....Needs REDDY-WHIP!!","Date":"Tue, 12 Sep 2017 16:39:27 +0200","In-Reply-To":"\n\t(Joseph Myers's message of \"Tue, 12 Sep 2017 14:28:57 +0000\")","Message-ID":"","User-Agent":"Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux)","MIME-Version":"1.0","Content-Type":"text/plain"}},{"id":1767142,"web_url":"http://patchwork.ozlabs.org/comment/1767142/","msgid":"","list_archive_url":null,"date":"2017-09-12T14:50:15","subject":"Re: [PATCH 7/9] posix: Consolidate glob implementation","submitter":{"id":4349,"url":"http://patchwork.ozlabs.org/api/people/4349/","name":"Joseph Myers","email":"joseph@codesourcery.com"},"content":"On Tue, 12 Sep 2017, Andreas Schwab wrote:\n\n> On Sep 12 2017, Joseph Myers wrote:\n> \n> > Does this mean we don't have any tests that verify a call to glob64 can be \n> > linked (and works)? If so, such tests should be added (generally, all \n> > non-compat symbols ought to be tested).\n> \n> It's a long standing bug that we don't verify the API. See the various\n> incidences about missing symbols on some architectures.\n\nWell, I think of it as a large number of bugs that some symbol X is \nmissing test coverage. In general, each of those bugs can be addressed \nindependently by adding a test or tests of an untested interface. See \n for some \nscripts I used to produce a list of untested symbols. Ideally, everything \nin the API would indeed be tested and documented.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","mailing list libc-alpha@sourceware.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=sourceware.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=libc-alpha-return-84516-incoming=patchwork.ozlabs.org@sourceware.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tsecure) header.d=sourceware.org header.i=@sourceware.org\n\theader.b=\"caFslf6s\"; dkim-atps=neutral","sourceware.org; auth=none"],"Received":["from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xs7550HK3z9sNV\n\tfor ;\n\tWed, 13 Sep 2017 00:50:32 +1000 (AEST)","(qmail 20291 invoked by alias); 12 Sep 2017 14:50:27 -0000","(qmail 20264 invoked by uid 89); 12 Sep 2017 14:50:26 -0000"],"DomainKey-Signature":"a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:date:from:to:cc:subject:in-reply-to:message-id\n\t:references:mime-version:content-type; q=dns; s=default; b=uYn/W\n\t0Hnkx9nei/ZVwhQ4f+EOe5+L61nm0k6nu9oqlib74PhDCJnt7K8ZJ9GNwlU0ngYh\n\trlHQDkXCsiIAV4d7MpuMN/RUNyDmyvFkz+nOpn3tzKEbHKXfdTj5EitHD+5m8tr6\n\tjzUqZVSibWTQOgHLI6Pbb6WUM+UhbHN8zAYkgA=","DKIM-Signature":"v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:date:from:to:cc:subject:in-reply-to:message-id\n\t:references:mime-version:content-type; s=default; bh=ssQGEc6pnuF\n\tSM2ZL0cTyMcQI+Ac=; b=caFslf6sdthfO3IrEYP2fiz4nPGHFBYFX26jCHmCJKy\n\tQCtPlYMfSx79qn3xCxRbLcdcKs6fVOYz0Ol6FPp0ZyF1p1m/kX5p87BsR/9hwdQo\n\tlDm7Pja9UPVH1jnk/NzLBAwiQLDR8NbWvSColEQ4akhnU0szs3JXEJAqubKVk+Xg\n\t=","Mailing-List":"contact libc-alpha-help@sourceware.org; run by ezmlm","Precedence":"bulk","List-Id":"","List-Unsubscribe":"","List-Subscribe":"","List-Archive":"","List-Post":"","List-Help":",\n\t","Sender":"libc-alpha-owner@sourceware.org","X-Virus-Found":"No","X-Spam-SWARE-Status":"No, score=-2.0 required=5.0 tests=AWL, BAYES_00,\n\tRCVD_IN_DNSWL_NONE, SPF_PASS,\n\tURIBL_RED autolearn=ham version=3.3.2 spammy=","X-HELO":"relay1.mentorg.com","Date":"Tue, 12 Sep 2017 14:50:15 +0000","From":"Joseph Myers ","To":"Andreas Schwab ","CC":"Adhemerval Zanella ,\n\t, Paul Eggert ","Subject":"Re: [PATCH 7/9] posix: Consolidate glob implementation","In-Reply-To":"","Message-ID":"","References":"<1504643122-14874-1-git-send-email-adhemerval.zanella@linaro.org>\n\t<1504643122-14874-8-git-send-email-adhemerval.zanella@linaro.org>\n\t\n\t\n\t","User-Agent":"Alpine 2.20 (DEB 67 2015-01-07)","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"US-ASCII\"","X-ClientProxiedBy":"svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) To\n\tsvr-ies-mbx-01.mgc.mentorg.com (139.181.222.1)"}},{"id":1767845,"web_url":"http://patchwork.ozlabs.org/comment/1767845/","msgid":"<4e53c914-8264-7501-3577-0757c7e15c3c@linaro.org>","list_archive_url":null,"date":"2017-09-13T12:26:20","subject":"Re: [PATCH 7/9] posix: Consolidate glob implementation","submitter":{"id":66065,"url":"http://patchwork.ozlabs.org/api/people/66065/","name":"Adhemerval Zanella Netto","email":"adhemerval.zanella@linaro.org"},"content":"On 12/09/2017 11:34, Andreas Schwab wrote:\n> On Sep 12 2017, Adhemerval Zanella wrote:\n> \n>> I will fix it and maybe it is confusing the linker and making you seem\n>> the missing glob64 (since oldglob.os and glob64.os both provide the\n>> same symbol).\n> \n> glob64@GLIBC_2.1 is the only version and it isn't the default, thus\n> becomes hidden.\n> \n> Andreas.\n> \n\nI pushed the patch below. It removes the alpha rule to add the oldglob\nand refrain s390 to build the compat code.\n\n---\n\ndiff --git a/sysdeps/unix/sysv/linux/alpha/Makefile b/sysdeps/unix/sysv/linux/alpha/Makefile\nindex 47bd189..50f4fb1 100644\n--- a/sysdeps/unix/sysv/linux/alpha/Makefile\n+++ b/sysdeps/unix/sysv/linux/alpha/Makefile\n@@ -1,7 +1,3 @@\n-ifeq ($(subdir),posix)\n-sysdep_routines += oldglob\n-endif\n-\n ifeq ($(subdir),stdlib)\n gen-as-const-headers += ucontext-offsets.sym\n endif\ndiff --git a/sysdeps/unix/sysv/linux/s390/s390-32/oldglob.c b/sysdeps/unix/sysv/linux/s390/s390-32/oldglob.c\nnew file mode 100644\nindex 0000000..56d7d12\n--- /dev/null\n+++ b/sysdeps/unix/sysv/linux/s390/s390-32/oldglob.c\n@@ -0,0 +1,2 @@\n+#define GLOB_NO_OLD_VERSION\n+#include ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","mailing list libc-alpha@sourceware.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=sourceware.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=libc-alpha-return-84547-incoming=patchwork.ozlabs.org@sourceware.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tsecure) header.d=sourceware.org header.i=@sourceware.org\n\theader.b=\"bLQ3klJo\"; dkim-atps=neutral","sourceware.org; auth=none"],"Received":["from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xsgrX4fpSz9sNr\n\tfor ;\n\tWed, 13 Sep 2017 22:26:36 +1000 (AEST)","(qmail 39381 invoked by alias); 13 Sep 2017 12:26:29 -0000","(qmail 38944 invoked by uid 89); 13 Sep 2017 12:26:29 -0000"],"DomainKey-Signature":"a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:subject:to:cc:references:from:message-id:date\n\t:mime-version:in-reply-to:content-type\n\t:content-transfer-encoding; q=dns; s=default; b=q7WzNLDQb5S1HYdm\n\tFM/mN2GLocV3YjOjNQy1wB6qocaAHEyCDj2MfH724aqYz8kSfDGmG36yiNOzpqHJ\n\tVR9SBl9axnUEoTMBsPczFGwGvJzMSSr80P6UyeZ1vLTn3VCtooYd27IqCU0iGZi8\n\tMmO6GlDNaT0RSTG7Fs77yNqioPY=","DKIM-Signature":"v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:subject:to:cc:references:from:message-id:date\n\t:mime-version:in-reply-to:content-type\n\t:content-transfer-encoding; s=default; bh=HIHIwmBuqamJFR764CYlBq\n\t6Ls1E=; b=bLQ3klJo12tCAABIIl4BHX/q155Zqj/HOkKhqxoLLN2a7fWXOTSZps\n\t0bXk1ymG6Ps16yV5/73ic+7ZyEz0pBfq6nWfnvqcU6XeBG74/kwBj+uwDr7tts9r\n\tx66D1hADeOnoFGh8LpLqUDCjZQNvrHCUi3VcvJk7wNfnd+nYQAKew=","Mailing-List":"contact libc-alpha-help@sourceware.org; run by ezmlm","Precedence":"bulk","List-Id":"","List-Unsubscribe":"","List-Subscribe":"","List-Archive":"","List-Post":"","List-Help":",\n\t","Sender":"libc-alpha-owner@sourceware.org","X-Virus-Found":"No","X-Spam-SWARE-Status":"No, score=-26.4 required=5.0 tests=BAYES_00, GIT_PATCH_0,\n\tGIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE,\n\tRCVD_IN_SORBS_SPAM,\n\tSPF_PASS autolearn=ham version=3.3.2 spammy=","X-HELO":"mail-qk0-f170.google.com","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:cc:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=8gSlmow4XdELLaLsHestIxJHRcPLo5zQDDBU9Nna4KI=;\n\tb=i3FINiHzWMmV3a83Y0RkIM9KJZovTg+/+W+RCQ6rABR6kbHQMAYDB08c1rA4bxgUzz\n\tIQQMk13HTlmPELTU9yNWGno5stGDw6E0aRtptF9bO7JExuPhloCCHiJN9xxLlM6w0Xmy\n\tUajglM9jBwObqd3XiD+Jo8L7JxHX4Pqz4HgR61vwFXd2lzj5bSd5qkFUCv7gwzCJ8uAW\n\trwjptsmjJ/AB+mMTjjrfoGGFYpZUY6bXUoTmGCgBE0SM4hDRL6giccNmut2vrJVTgTUZ\n\tuQk99MN+hMOd/7x95NPNA9OF40BagAclQu9m7cS6Lf+c7EpsYoIpNOzR1If18F0EScje\n\t1ZVw==","X-Gm-Message-State":"AHPjjUhPVx1Faw5uQSahqHiJyAfYupdZA8eUdVpqFWYf2KCy0r5F047Y\n\t/KL9jdju9NTjbfZ8","X-Google-Smtp-Source":"AOwi7QDWPzle1Dj9BUYEHbHVNYvekjlh/smkXQN40YQL+2L0kCED/v18rCKDd9MXKeleOirqlE+1XA==","X-Received":"by 10.55.79.68 with SMTP id d65mr25712714qkb.110.1505305586124; \n\tWed, 13 Sep 2017 05:26:26 -0700 (PDT)","Subject":"Re: [PATCH 7/9] posix: Consolidate glob implementation","To":"Andreas Schwab ","Cc":"libc-alpha@sourceware.org, Paul Eggert ","References":"<1504643122-14874-1-git-send-email-adhemerval.zanella@linaro.org>\n\t<1504643122-14874-8-git-send-email-adhemerval.zanella@linaro.org>\n\t\n\t<29c0bb72-189f-f8db-328e-05b9cdd84261@linaro.org>\n\t","From":"Adhemerval Zanella ","Message-ID":"<4e53c914-8264-7501-3577-0757c7e15c3c@linaro.org>","Date":"Wed, 13 Sep 2017 09:26:20 -0300","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"7bit"}}]