[{"id":1763780,"web_url":"http://patchwork.ozlabs.org/comment/1763780/","msgid":"<c8e463b3-72e1-93b3-29b1-742da1a3eddf@cs.ucla.edu>","list_archive_url":null,"date":"2017-09-06T02:01:54","subject":"Re: [PATCH 1/9] posix: Sync glob with gnulib [BZ #1062]","submitter":{"id":4434,"url":"http://patchwork.ozlabs.org/api/people/4434/","name":"Paul Eggert","email":"eggert@CS.UCLA.EDU"},"content":"Adhemerval Zanella wrote:\n> +/* Any distinct values will do here.\n> +   Undef any existing macros out of the way.  */\n> +#ifndef DT_UNKNOWN\n> +# define DT_UNKNOWN 0\n> +#endif\n> +#ifndef DT_DIR\n> +# define DT_DIR 1\n> +#endif\n> +#ifndef DT_LNK\n> +# define DT_LNK 2\n> +#endif\n\nThe comment here does not match the code, as nothing is being undeffed. Instead \nof this change, how about the following?\n\n#if !defined _LIBC && !defined HAVE_STRUCT_DIRENT_D_TYPE\n/* Any distinct values will do here.\n    Undef any existing macros out of the way.  */\n# undef DT_UNKNOWN\n# undef DT_DIR\n# undef DT_LNK\n# define DT_UNKNOWN 0\n# define DT_DIR 1\n# define DT_LNK 2\n#endif\n\nThis makes it more clear to the casual reader that this code is for use only \noutside glibc. Also, it's more robust for hopefully only-hypothetical non-glibc \nplatforms that define some DT_ symbols but not others, because it guarantees \ntheir uniqueness in that case. I installed the attached patch into Gnulib, along \nthese lines.\nFrom e73addd2704d4eb68b126210f5b41b428d5d4956 Mon Sep 17 00:00:00 2001\nFrom: Paul Eggert <eggert@cs.ucla.edu>\nDate: Tue, 5 Sep 2017 18:58:50 -0700\nSubject: [PATCH] glob: fix for use in glibc\n\nProblem reported by Adhemerval Zanella in:\nhttps://sourceware.org/ml/libc-alpha/2017-09/msg00213.html\n* lib/glob.c (DT_UNKNOWN, DT_DIR, DT_LINK):\nDo not redefine if _LIBC.\n---\n ChangeLog  | 8 ++++++++\n lib/glob.c | 2 +-\n 2 files changed, 9 insertions(+), 1 deletion(-)\n\ndiff --git a/ChangeLog b/ChangeLog\nindex 351495b..61e3e8c 100644\n--- a/ChangeLog\n+++ b/ChangeLog\n@@ -1,3 +1,11 @@\n+2017-09-05  Paul Eggert  <eggert@cs.ucla.edu>\n+\n+\tglob: fix for use in glibc\n+\tProblem reported by Adhemerval Zanella in:\n+\thttps://sourceware.org/ml/libc-alpha/2017-09/msg00213.html\n+\t* lib/glob.c (DT_UNKNOWN, DT_DIR, DT_LINK):\n+\tDo not redefine if _LIBC.\n+\n 2017-09-02  Paul Eggert  <eggert@cs.ucla.edu>\n \n \tglob: fix bugs with long login names\ndiff --git a/lib/glob.c b/lib/glob.c\nindex 8eb2b97..ddab535 100644\n--- a/lib/glob.c\n+++ b/lib/glob.c\n@@ -80,7 +80,7 @@ static const char *next_brace_sub (const char *begin, int flags) __THROWNL;\n \n typedef uint_fast8_t dirent_type;\n \n-#ifndef HAVE_STRUCT_DIRENT_D_TYPE\n+#if !defined _LIBC && !defined HAVE_STRUCT_DIRENT_D_TYPE\n /* Any distinct values will do here.\n    Undef any existing macros out of the way.  */\n # undef DT_UNKNOWN","headers":{"Return-Path":"<libc-alpha-return-84226-incoming=patchwork.ozlabs.org@sourceware.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","mailing list libc-alpha@sourceware.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=sourceware.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=libc-alpha-return-84226-incoming=patchwork.ozlabs.org@sourceware.org;\n\treceiver=<UNKNOWN>)","ozlabs.org; dkim=pass (1024-bit key;\n\tsecure) header.d=sourceware.org header.i=@sourceware.org\n\theader.b=\"AwuMQdMN\"; dkim-atps=neutral","sourceware.org; auth=none"],"Received":["from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xn6KG1dh3z9sR9\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed,  6 Sep 2017 12:02:10 +1000 (AEST)","(qmail 127799 invoked by alias); 6 Sep 2017 02:01:59 -0000","(qmail 127788 invoked by uid 89); 6 Sep 2017 02:01:58 -0000"],"DomainKey-Signature":"a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:subject:to:references:from:message-id:date\n\t:mime-version:in-reply-to:content-type; q=dns; s=default; b=jonv\n\t5c4Fj1tj7HJMO3qg26W1p5YSNNtOX754EpgEUTRDBnRZk6qTT4UbLCCJl3aLpm1x\n\tQkf1OV6XGCBp3A9a1+1GpuwxdwpbgW21wTFTdh8Ik8jX7xIPLCUbg4VzMd7m3SxF\n\tzPCfpY7O7Zh35qPcqjkmp0Fpgp5RwP4P0lD7Jgk=","DKIM-Signature":"v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:subject:to:references:from:message-id:date\n\t:mime-version:in-reply-to:content-type; s=default; bh=MO1b6JItNV\n\t0e7P0Ar/xF0kyjeIY=; b=AwuMQdMNW2WE4SxQpNUuyzyb5c42DhL4a05Xo1hofP\n\tlBVyDY2JMDheuttg+Rime9HGSBqYB3lqvQvWcq5uVPifCPfFyGZVDQyU09+cY21c\n\tWgH6HysY9HSmlLJIisVHwf9GmdeM14qx3LHVLXzZFqrKeqQMpcNte3Bqm1JErECq\n\tw=","Mailing-List":"contact libc-alpha-help@sourceware.org; run by ezmlm","Precedence":"bulk","List-Id":"<libc-alpha.sourceware.org>","List-Unsubscribe":"<mailto:libc-alpha-unsubscribe-incoming=patchwork.ozlabs.org@sourceware.org>","List-Subscribe":"<mailto:libc-alpha-subscribe@sourceware.org>","List-Archive":"<http://sourceware.org/ml/libc-alpha/>","List-Post":"<mailto:libc-alpha@sourceware.org>","List-Help":"<mailto:libc-alpha-help@sourceware.org>,\n\t<http://sourceware.org/ml/#faqs>","Sender":"libc-alpha-owner@sourceware.org","X-Virus-Found":"No","X-Spam-SWARE-Status":"No, score=-24.7 required=5.0 tests=AWL, BAYES_00,\n\tGIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3,\n\tRP_MATCHES_RCVD,\n\tSPF_PASS autolearn=ham version=3.3.2 spammy=reader","X-HELO":"zimbra.cs.ucla.edu","Subject":"Re: [PATCH 1/9] posix: Sync glob with gnulib [BZ #1062]","To":"Adhemerval Zanella <adhemerval.zanella@linaro.org>,\n\tlibc-alpha@sourceware.org","References":"<1504643122-14874-1-git-send-email-adhemerval.zanella@linaro.org>\n\t<1504643122-14874-2-git-send-email-adhemerval.zanella@linaro.org>","From":"Paul Eggert <eggert@cs.ucla.edu>","Message-ID":"<c8e463b3-72e1-93b3-29b1-742da1a3eddf@cs.ucla.edu>","Date":"Tue, 5 Sep 2017 19:01:54 -0700","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<1504643122-14874-2-git-send-email-adhemerval.zanella@linaro.org>","Content-Type":"multipart/mixed;\n\tboundary=\"------------2F583CBAF324AE387AEFFC57\""}},{"id":1764082,"web_url":"http://patchwork.ozlabs.org/comment/1764082/","msgid":"<3d1e0b00-accd-88d9-7867-56ae1aeee61d@linaro.org>","list_archive_url":null,"date":"2017-09-06T12:52:23","subject":"Re: [PATCH 1/9] posix: Sync glob with gnulib [BZ #1062]","submitter":{"id":66065,"url":"http://patchwork.ozlabs.org/api/people/66065/","name":"Adhemerval Zanella Netto","email":"adhemerval.zanella@linaro.org"},"content":"On 05/09/2017 23:01, Paul Eggert wrote:\n> Adhemerval Zanella wrote:\n>> +/* Any distinct values will do here.\n>> +   Undef any existing macros out of the way.  */\n>> +#ifndef DT_UNKNOWN\n>> +# define DT_UNKNOWN 0\n>> +#endif\n>> +#ifndef DT_DIR\n>> +# define DT_DIR 1\n>> +#endif\n>> +#ifndef DT_LNK\n>> +# define DT_LNK 2\n>> +#endif\n> \n> The comment here does not match the code, as nothing is being undeffed. Instead of this change, how about the following?\n\nIndeed, I forgot to update the comments after the fix.\n\n> #if !defined _LIBC && !defined HAVE_STRUCT_DIRENT_D_TYPE\n> /* Any distinct values will do here.\n>    Undef any existing macros out of the way.  */\n> # undef DT_UNKNOWN\n> # undef DT_DIR\n> # undef DT_LNK\n> # define DT_UNKNOWN 0\n> # define DT_DIR 1\n> # define DT_LNK 2\n> #endif\n> \n> This makes it more clear to the casual reader that this code is for use only outside glibc. Also, it's more robust for hopefully only-hypothetical non-glibc platforms that define some DT_ symbols but not others, because it guarantees their uniqueness in that case. I installed the attached patch into Gnulib, along these lines.\n\nI do not have a strong preference here, I am ok with your approach and I will\nupdate my patch with this change. In fact I would prefer that all this \nboilerplate that is non required for glibc code to be on a specific header\n(maybe glob-gnulib.h or something), but we can think about it later.","headers":{"Return-Path":"<libc-alpha-return-84241-incoming=patchwork.ozlabs.org@sourceware.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","mailing list libc-alpha@sourceware.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=sourceware.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=libc-alpha-return-84241-incoming=patchwork.ozlabs.org@sourceware.org;\n\treceiver=<UNKNOWN>)","ozlabs.org; dkim=pass (1024-bit key;\n\tsecure) header.d=sourceware.org header.i=@sourceware.org\n\theader.b=\"YJB7cOiA\"; dkim-atps=neutral","sourceware.org; auth=none"],"Received":["from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xnNlz23J5z9sBd\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed,  6 Sep 2017 22:52:47 +1000 (AEST)","(qmail 36124 invoked by alias); 6 Sep 2017 12:52:41 -0000","(qmail 36096 invoked by uid 89); 6 Sep 2017 12:52:41 -0000"],"DomainKey-Signature":"a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:subject:to:references:from:message-id:date\n\t:mime-version:in-reply-to:content-type\n\t:content-transfer-encoding; q=dns; s=default; b=lBOvGtnVq3ndKQc1\n\tKwGH9VJ9XjmKxq796d+Jl00zRRzNbKqpeoFSEG4NYyPIGfZMipK599U4o4cRVeSm\n\tK2r5vwnAGAzGB99Psnh/naFGBJ6hHBKXmzNWfuiuVsNtULW2pbpNQYG8p7zyRmBI\n\t5294hXuKMLzyMS8vyA+DmXUV30M=","DKIM-Signature":"v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:subject:to:references:from:message-id:date\n\t:mime-version:in-reply-to:content-type\n\t:content-transfer-encoding; s=default; bh=JwwBFyHvhRQD3D+GDaKxsC\n\tGYqVE=; b=YJB7cOiAr6pGKTAdOU1qc374mByPfg0GWjegyx2jpIaX+zdfuQFiaT\n\tH58z/UbVFzaEdA3BqSwySCCtYmQugi45ej/+KpnkSR4MRTa4pOEbcqemuC6P0J2/\n\tRSyHEme/2cPfl8+2RxXnA/2ZFliY2qDW+yXTNIMt309TXg/lzK0tM=","Mailing-List":"contact libc-alpha-help@sourceware.org; run by ezmlm","Precedence":"bulk","List-Id":"<libc-alpha.sourceware.org>","List-Unsubscribe":"<mailto:libc-alpha-unsubscribe-incoming=patchwork.ozlabs.org@sourceware.org>","List-Subscribe":"<mailto:libc-alpha-subscribe@sourceware.org>","List-Archive":"<http://sourceware.org/ml/libc-alpha/>","List-Post":"<mailto:libc-alpha@sourceware.org>","List-Help":"<mailto:libc-alpha-help@sourceware.org>,\n\t<http://sourceware.org/ml/#faqs>","Sender":"libc-alpha-owner@sourceware.org","X-Virus-Found":"No","X-Spam-SWARE-Status":"No, score=-1.4 required=5.0 tests=BAYES_00,\n\tRCVD_IN_DNSWL_NONE, RCVD_IN_SORBS_SPAM,\n\tSPF_PASS autolearn=no version=3.3.2 spammy=Hx-languages-length:1461,\n\tH*r:sk:51.2017, reader","X-HELO":"mail-qt0-f172.google.com","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=rfDBKzdzDStBd4tvi1cr+ch1o4o7tMV0RqDIxnQxkwY=;\n\tb=rNBagK42P6hB+apUvF7jd9QXk++uTGYzFeDHqM+UhzdC68hRml7ZqgZonItWzLmRh/\n\tDjIgGE2bI60UGR2aCvQfSo9VdKipIijB7iY3yz0UssYERLroTpLQYyckkm+uD2/RC836\n\tjFQnmaFH0BS34J51EbUuMhF+9z5xN5MI1sPseW9dOHnQd8Hgvej7WI2Wysx7pkZqQwv+\n\tGE+Nr1sheWJBUy7FPm9mn8qpDYn1RrUA9v+mxoIPr3RSSzWdYaCz9a8KtX2NPMoMSgYQ\n\tl7lXY+ewHYPw9i5Sho3QO67AKHRGHZ3MK2iPSqv/NvBM89ECv3aSqrR8VRt/8XVsSclK\n\tDs4A==","X-Gm-Message-State":"AHPjjUiemUrcnXvsF4LMmlGgFppfNYgznSWV/2N0izEknNG2cioeD05d\n\tlnsi2ng+38cMXAT5lcAeKw==","X-Google-Smtp-Source":"ADKCNb7YadtpC7/OPqMpqiiLqiVECeeRDpafMEqEfZ6tKB91xNpAx/WT6is6PW9bxPDSmLOaRBs34w==","X-Received":"by 10.200.43.188 with SMTP id m57mr3299253qtm.192.1504702349223; \n\tWed, 06 Sep 2017 05:52:29 -0700 (PDT)","Subject":"Re: [PATCH 1/9] posix: Sync glob with gnulib [BZ #1062]","To":"Paul Eggert <eggert@cs.ucla.edu>, libc-alpha@sourceware.org","References":"<1504643122-14874-1-git-send-email-adhemerval.zanella@linaro.org>\n\t<1504643122-14874-2-git-send-email-adhemerval.zanella@linaro.org>\n\t<c8e463b3-72e1-93b3-29b1-742da1a3eddf@cs.ucla.edu>","From":"Adhemerval Zanella <adhemerval.zanella@linaro.org>","Message-ID":"<3d1e0b00-accd-88d9-7867-56ae1aeee61d@linaro.org>","Date":"Wed, 6 Sep 2017 09:52:23 -0300","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<c8e463b3-72e1-93b3-29b1-742da1a3eddf@cs.ucla.edu>","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"7bit"}},{"id":1767114,"web_url":"http://patchwork.ozlabs.org/comment/1767114/","msgid":"<mvmlglk80dk.fsf@suse.de>","list_archive_url":null,"date":"2017-09-12T14:20:07","subject":"Re: [PATCH 1/9] posix: Sync glob with gnulib [BZ #1062]","submitter":{"id":37,"url":"http://patchwork.ozlabs.org/api/people/37/","name":"Andreas Schwab","email":"schwab@suse.de"},"content":"On Sep 05 2017, Adhemerval Zanella <adhemerval.zanella@linaro.org> wrote:\n\n> diff --git a/sysdeps/unix/sysv/linux/Makefile b/sysdeps/unix/sysv/linux/Makefile\n> index e571fe2..30bd167 100644\n> --- a/sysdeps/unix/sysv/linux/Makefile\n> +++ b/sysdeps/unix/sysv/linux/Makefile\n> @@ -137,7 +137,7 @@ endif\n>  ifeq ($(subdir),posix)\n>  sysdep_headers += bits/initspin.h\n>  \n> -sysdep_routines += sched_getcpu\n> +sysdep_routines += sched_getcpu oldglob\n\nThis means that oldglob is now added twice on alpha.\n\nAndreas.","headers":{"Return-Path":"<libc-alpha-return-84503-incoming=patchwork.ozlabs.org@sourceware.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","mailing list libc-alpha@sourceware.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=sourceware.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=libc-alpha-return-84503-incoming=patchwork.ozlabs.org@sourceware.org;\n\treceiver=<UNKNOWN>)","ozlabs.org; dkim=pass (1024-bit key;\n\tsecure) header.d=sourceware.org header.i=@sourceware.org\n\theader.b=\"R51Uen0O\"; dkim-atps=neutral","sourceware.org; auth=none"],"Received":["from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xs6Q84m8lz9s0Z\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 13 Sep 2017 00:20:16 +1000 (AEST)","(qmail 22891 invoked by alias); 12 Sep 2017 14:20:11 -0000","(qmail 22874 invoked by uid 89); 12 Sep 2017 14:20:10 -0000"],"DomainKey-Signature":"a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:from:to:cc:subject:references:date:in-reply-to\n\t:message-id:mime-version:content-type; q=dns; s=default; b=c70G6\n\tOwm27MegdPTzOvgcDRL51IWAoqsnFKZFSYSKAP5Ofd43dxqpj1wFxY2gmPxm36aJ\n\t9RSCpmTPiGbFyBD5Hc9gUnaXp6qlE7F3NDeeiGnR2iaTyqFqM1YvHZyn6uubwSR2\n\tfuXQxERbOD3CU7bszk95Vaf6ADLZy0Fwgv4C9s=","DKIM-Signature":"v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:from:to:cc:subject:references:date:in-reply-to\n\t:message-id:mime-version:content-type; s=default; bh=J6hQkPguQPU\n\trWAHmEsyGkoctcA4=; b=R51Uen0O25kWW5Lg5lUz0FwfCnuXzxiq1rhvqXePceP\n\tgcHgpnd9s0g1RBzxNaoYJ6t4dwyXerhf2aeR5KAu+Zg0d9ETM8HbXYfy6jXLOYF9\n\tceyjg6y/kvJK2WtDwHrXWMss4fE4hybQbZOcvWioDJw2BCPZ3ERbOEe7yKh81kwQ\n\t=","Mailing-List":"contact libc-alpha-help@sourceware.org; run by ezmlm","Precedence":"bulk","List-Id":"<libc-alpha.sourceware.org>","List-Unsubscribe":"<mailto:libc-alpha-unsubscribe-incoming=patchwork.ozlabs.org@sourceware.org>","List-Subscribe":"<mailto:libc-alpha-subscribe@sourceware.org>","List-Archive":"<http://sourceware.org/ml/libc-alpha/>","List-Post":"<mailto:libc-alpha@sourceware.org>","List-Help":"<mailto:libc-alpha-help@sourceware.org>,\n\t<http://sourceware.org/ml/#faqs>","Sender":"libc-alpha-owner@sourceware.org","X-Virus-Found":"No","X-Spam-SWARE-Status":"No, score=-26.9 required=5.0 tests=BAYES_00, GIT_PATCH_0,\n\tGIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RP_MATCHES_RCVD,\n\tSPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:726","X-HELO":"mx1.suse.de","From":"Andreas Schwab <schwab@suse.de>","To":"Adhemerval Zanella <adhemerval.zanella@linaro.org>","Cc":"libc-alpha@sourceware.org,  Paul Eggert <eggert@cs.ucla.edu>","Subject":"Re: [PATCH 1/9] posix: Sync glob with gnulib [BZ #1062]","References":"<1504643122-14874-1-git-send-email-adhemerval.zanella@linaro.org>\n\t<1504643122-14874-2-git-send-email-adhemerval.zanella@linaro.org>","X-Yow":"I fill MY industrial waste containers with old copies\n\tof the ``WATCHTOWER'' and then add HAWAIIAN PUNCH to\n\tthe top..  They look NICE in the yard--","Date":"Tue, 12 Sep 2017 16:20:07 +0200","In-Reply-To":"<1504643122-14874-2-git-send-email-adhemerval.zanella@linaro.org>\n\t(Adhemerval Zanella's message of \"Tue, 5 Sep 2017 17:25:14 -0300\")","Message-ID":"<mvmlglk80dk.fsf@suse.de>","User-Agent":"Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux)","MIME-Version":"1.0","Content-Type":"text/plain"}},{"id":1767256,"web_url":"http://patchwork.ozlabs.org/comment/1767256/","msgid":"<dceb1b6b-1f86-ba9b-5881-898f21e1cb5b@linaro.org>","list_archive_url":null,"date":"2017-09-12T17:06:15","subject":"Re: [PATCH 1/9] posix: Sync glob with gnulib [BZ #1062]","submitter":{"id":66065,"url":"http://patchwork.ozlabs.org/api/people/66065/","name":"Adhemerval Zanella Netto","email":"adhemerval.zanella@linaro.org"},"content":"On 12/09/2017 11:20, Andreas Schwab wrote:\n> On Sep 05 2017, Adhemerval Zanella <adhemerval.zanella@linaro.org> wrote:\n> \n>> diff --git a/sysdeps/unix/sysv/linux/Makefile b/sysdeps/unix/sysv/linux/Makefile\n>> index e571fe2..30bd167 100644\n>> --- a/sysdeps/unix/sysv/linux/Makefile\n>> +++ b/sysdeps/unix/sysv/linux/Makefile\n>> @@ -137,7 +137,7 @@ endif\n>>  ifeq ($(subdir),posix)\n>>  sysdep_headers += bits/initspin.h\n>>  \n>> -sysdep_routines += sched_getcpu\n>> +sysdep_routines += sched_getcpu oldglob\n> \n> This means that oldglob is now added twice on alpha.\n> \n> Andreas.\n> \n\nAck, I will fix it along with s390.","headers":{"Return-Path":"<libc-alpha-return-84522-incoming=patchwork.ozlabs.org@sourceware.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","mailing list libc-alpha@sourceware.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=sourceware.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=libc-alpha-return-84522-incoming=patchwork.ozlabs.org@sourceware.org;\n\treceiver=<UNKNOWN>)","ozlabs.org; dkim=pass (1024-bit key;\n\tsecure) header.d=sourceware.org header.i=@sourceware.org\n\theader.b=\"jiXgJkzc\"; dkim-atps=neutral","sourceware.org; auth=none"],"Received":["from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xsB603GJVz9sNV\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 13 Sep 2017 03:06:32 +1000 (AEST)","(qmail 123344 invoked by alias); 12 Sep 2017 17:06:25 -0000","(qmail 123044 invoked by uid 89); 12 Sep 2017 17:06:25 -0000"],"DomainKey-Signature":"a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:subject:to:cc:references:from:message-id:date\n\t:mime-version:in-reply-to:content-type\n\t:content-transfer-encoding; q=dns; s=default; b=Dsq//vHUeWuHlTLp\n\tTEEn+YuYLw/Xvuk4h5iqkoVxL5pf4S1x37Ij9eFwpl6bd1dwVPZXL7R5gC7M+ZFU\n\tt2H6xVnjLj1qKIretZdHdhVpt9CNELjCEdVFPSCvOllQla4Qb1JRSQMNHFEFaTp0\n\togGHofDCJKxUIPeo68NeHOg6vzA=","DKIM-Signature":"v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:subject:to:cc:references:from:message-id:date\n\t:mime-version:in-reply-to:content-type\n\t:content-transfer-encoding; s=default; bh=SGR5HiH4EDSY3/HEtmgGvI\n\tHVS48=; b=jiXgJkzcag4Rn7fHTmBRGsCQ79XdEIixWqK+kQxT8YGqqT2Z2lRn/H\n\tB4zsOG6m7bqO66W61ebP14LsHW4HkDA/dXwLnQCFt+ijxFQC4hB4piSG7Ybq4Gt+\n\txayUcOO0SAYAXOoEc3bYQ5d4GwmbF7swavDWIwxrfMZafhgZkJdcU=","Mailing-List":"contact libc-alpha-help@sourceware.org; run by ezmlm","Precedence":"bulk","List-Id":"<libc-alpha.sourceware.org>","List-Unsubscribe":"<mailto:libc-alpha-unsubscribe-incoming=patchwork.ozlabs.org@sourceware.org>","List-Subscribe":"<mailto:libc-alpha-subscribe@sourceware.org>","List-Archive":"<http://sourceware.org/ml/libc-alpha/>","List-Post":"<mailto:libc-alpha@sourceware.org>","List-Help":"<mailto:libc-alpha-help@sourceware.org>,\n\t<http://sourceware.org/ml/#faqs>","Sender":"libc-alpha-owner@sourceware.org","X-Virus-Found":"No","X-Spam-SWARE-Status":"No, score=-27.1 required=5.0 tests=BAYES_00, GIT_PATCH_0,\n\tGIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_LOW,\n\tRCVD_IN_SORBS_SPAM,\n\tSPF_PASS autolearn=ham version=3.3.2 spammy=H*M:1f86","X-HELO":"mail-qt0-f179.google.com","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:cc:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=u8lArOdMc88CR86so7EoQ08f/e4oInvjuvWOtkc5cI0=;\n\tb=HFwUewCIsHH6gmNLkbv7b+JnJq3Uk2bRUHZr9FDD0XxLAEc3zYNejSNJpZPO6rep6U\n\trdU/WExeO0G/J1YyNc9bwW5bvOUgnKzG2eeO5bmLyJvfGglnPf2Lx2GcaNiisU7LXXWw\n\tq39nEzc01GNHSHa7Xxw5ZddOYw96yJMP2Mk+o67XvYvSYSZR5B3gfAU2UJu76H9CkR+z\n\tTkHcSksLbeMyyFxkk/XUeOyus9yR4BllIl1VxlIAbw7L68ac7Sry7sRKkoUc2aLpzlru\n\tGHYOp430jQOxL9T3DPf1qCoHijjM335gXn94tGULBjcqIOac09miACDNq3RduAitfS9P\n\teyrg==","X-Gm-Message-State":"AHPjjUjefd3IPJqI3VAxrAYWaA82xmdq2Av+sQ/IjnEX8mnWP3m1WPsN\n\tKtEvcpgP0sTbraWz","X-Google-Smtp-Source":"AOwi7QDU7efh3lbkxYKIaXTUSXQmA7H9faSlMfcNguGZeOjl2x2Hm+6VVMp1iYS+MOON8yWNCcW+zQ==","X-Received":"by 10.237.63.82 with SMTP id q18mr23282046qtf.274.1505235981116; \n\tTue, 12 Sep 2017 10:06:21 -0700 (PDT)","Subject":"Re: [PATCH 1/9] posix: Sync glob with gnulib [BZ #1062]","To":"Andreas Schwab <schwab@suse.de>","Cc":"libc-alpha@sourceware.org, Paul Eggert <eggert@cs.ucla.edu>","References":"<1504643122-14874-1-git-send-email-adhemerval.zanella@linaro.org>\n\t<1504643122-14874-2-git-send-email-adhemerval.zanella@linaro.org>\n\t<mvmlglk80dk.fsf@suse.de>","From":"Adhemerval Zanella <adhemerval.zanella@linaro.org>","Message-ID":"<dceb1b6b-1f86-ba9b-5881-898f21e1cb5b@linaro.org>","Date":"Tue, 12 Sep 2017 14:06:15 -0300","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<mvmlglk80dk.fsf@suse.de>","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"7bit"}}]