[{"id":1763605,"web_url":"http://patchwork.ozlabs.org/comment/1763605/","msgid":"<20170905214447.7e75c2da@windsurf.lan>","list_archive_url":null,"date":"2017-09-05T19:44:47","subject":"Re: [Buildroot] [PATCH 1/2] shairport-sync: fix static link with\n\tmbedtls","submitter":{"id":2230,"url":"http://patchwork.ozlabs.org/api/people/2230/","name":"Thomas Petazzoni","email":"thomas.petazzoni@free-electrons.com"},"content":"Hello,\n\nOn Tue, 5 Sep 2017 22:05:25 +0300, Baruch Siach wrote:\n\n> # Avahi or tinysvcmdns (shaiport-sync bundles its own version of tinysvcmdns).\n> # Avahi support needs libavahi-client, which is built by avahi if avahi-daemon\n> # and dbus is selected. Since there is no BR2_PACKAGE_LIBAVAHI_CLIENT config\n> @@ -38,6 +40,10 @@ SHAIRPORT_SYNC_CONF_OPTS += --with-ssl=openssl\n> else\n> SHAIRPORT_SYNC_DEPENDENCIES += mbedtls\n> SHAIRPORT_SYNC_CONF_OPTS += --with-ssl=mbedtls\n> +SHAIRPORT_SYNC_CONF_LIBS += -lmbedx509 -lmbedcrypto\n> +ifeq ($(BR2_PACKAGE_MBEDTLS_COMPRESSION),y)\n> +SHAIRPORT_SYNC_CONF_LIBS += -lz\n> +endif\n> endif\n\nThis is crazy. Can we submit a mbedtls patch adding a pkg-config file ?\nThey are open to it it seems:\nhttps://github.com/ARMmbed/mbedtls/issues/228. Of course,\nshairport-sync would have to be modified to use it.\n\nThomas","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","buildroot@lists.busybox.net"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","buildroot@osuosl.org"],"Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=busybox.net\n\t(client-ip=140.211.166.133; helo=hemlock.osuosl.org;\n\tenvelope-from=buildroot-bounces@busybox.net;\n\treceiver=)","Received":["from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xmxxx1f8Rz9sNV\n\tfor ;\n\tWed, 6 Sep 2017 05:44:53 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 9560781C7E;\n\tTue, 5 Sep 2017 19:44:51 +0000 (UTC)","from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id kC+hjYo7uoW9; Tue, 5 Sep 2017 19:44:51 +0000 (UTC)","from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 0740B81C87;\n\tTue, 5 Sep 2017 19:44:51 +0000 (UTC)","from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id B39AF1C104C\n\tfor ;\n\tTue, 5 Sep 2017 19:44:49 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id A80F387836\n\tfor ;\n\tTue, 5 Sep 2017 19:44:49 +0000 (UTC)","from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id NMAI+wlN7Uec for ;\n\tTue, 5 Sep 2017 19:44:49 +0000 (UTC)","from mail.free-electrons.com (mail.free-electrons.com [62.4.15.54])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id EAFB587828\n\tfor ; Tue, 5 Sep 2017 19:44:48 +0000 (UTC)","by mail.free-electrons.com (Postfix, from userid 110)\n\tid 1E5C3209DF; Tue, 5 Sep 2017 21:44:47 +0200 (CEST)","from windsurf.lan (LFbn-1-15130-153.w86-206.abo.wanadoo.fr\n\t[86.206.236.153])\n\tby mail.free-electrons.com (Postfix) with ESMTPSA id E53A0209B9;\n\tTue, 5 Sep 2017 21:44:46 +0200 (CEST)"],"X-Virus-Scanned":["amavisd-new at osuosl.org","amavisd-new at osuosl.org"],"X-Greylist":"domain auto-whitelisted by SQLgrey-1.7.6","Date":"Tue, 5 Sep 2017 21:44:47 +0200","From":"Thomas Petazzoni ","To":"Baruch Siach ","Message-ID":"<20170905214447.7e75c2da@windsurf.lan>","In-Reply-To":"<87aa32f0dbacc3252ade43fc605e7f2c310e6465.1504638326.git.baruch@tkos.co.il>","References":"<87aa32f0dbacc3252ade43fc605e7f2c310e6465.1504638326.git.baruch@tkos.co.il>","Organization":"Free Electrons","X-Mailer":"Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-redhat-linux-gnu)","MIME-Version":"1.0","Cc":"buildroot@busybox.net","Subject":"Re: [Buildroot] [PATCH 1/2] shairport-sync: fix static link with\n\tmbedtls","X-BeenThere":"buildroot@busybox.net","X-Mailman-Version":"2.1.18-1","Precedence":"list","List-Id":"Discussion and development of buildroot ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"buildroot-bounces@busybox.net","Sender":"\"buildroot\" "}},{"id":1763822,"web_url":"http://patchwork.ozlabs.org/comment/1763822/","msgid":"<20170906053032.tdj2seviftc5dbxz@sapphire.tkos.co.il>","list_archive_url":null,"date":"2017-09-06T05:30:32","subject":"Re: [Buildroot] [PATCH 1/2] shairport-sync: fix static link with\n\tmbedtls","submitter":{"id":1458,"url":"http://patchwork.ozlabs.org/api/people/1458/","name":"Baruch Siach","email":"baruch@tkos.co.il"},"content":"Hi Thomas,\n\nOn Tue, Sep 05, 2017 at 09:44:47PM +0200, Thomas Petazzoni wrote:\n> On Tue, 5 Sep 2017 22:05:25 +0300, Baruch Siach wrote:\n> \n> > # Avahi or tinysvcmdns (shaiport-sync bundles its own version of tinysvcmdns).\n> > # Avahi support needs libavahi-client, which is built by avahi if avahi-daemon\n> > # and dbus is selected. Since there is no BR2_PACKAGE_LIBAVAHI_CLIENT config\n> > @@ -38,6 +40,10 @@ SHAIRPORT_SYNC_CONF_OPTS += --with-ssl=openssl\n> > else\n> > SHAIRPORT_SYNC_DEPENDENCIES += mbedtls\n> > SHAIRPORT_SYNC_CONF_OPTS += --with-ssl=mbedtls\n> > +SHAIRPORT_SYNC_CONF_LIBS += -lmbedx509 -lmbedcrypto\n> > +ifeq ($(BR2_PACKAGE_MBEDTLS_COMPRESSION),y)\n> > +SHAIRPORT_SYNC_CONF_LIBS += -lz\n> > +endif\n> > endif\n> \n> This is crazy. Can we submit a mbedtls patch adding a pkg-config file ?\n> They are open to it it seems:\n> https://github.com/ARMmbed/mbedtls/issues/228. Of course,\n> shairport-sync would have to be modified to use it.\n\nCrazy indeed. I'll see if I can do something about mbedtls pkg-config as time \npermits. But I think we'll need this workaround for now.\n\nBTW, this fix is independent of the mbedtls security bump, since the static \nbuild issue affects the current mbedtls version as well.\n\nbaruch","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","buildroot@lists.busybox.net"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","buildroot@osuosl.org"],"Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=busybox.net\n\t(client-ip=140.211.166.133; helo=hemlock.osuosl.org;\n\tenvelope-from=buildroot-bounces@busybox.net;\n\treceiver=)","Received":["from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xnBy31CCbz9t2R\n\tfor ;\n\tWed, 6 Sep 2017 15:30:49 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id A5EF9894F1;\n\tWed, 6 Sep 2017 05:30:44 +0000 (UTC)","from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id CXx5svKnMk8q; Wed, 6 Sep 2017 05:30:39 +0000 (UTC)","from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id B00D8894E6;\n\tWed, 6 Sep 2017 05:30:39 +0000 (UTC)","from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id D83C41CE935\n\tfor ;\n\tWed, 6 Sep 2017 05:30:38 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id CE8038843F\n\tfor ;\n\tWed, 6 Sep 2017 05:30:38 +0000 (UTC)","from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 0kBxVmcelUvO for ;\n\tWed, 6 Sep 2017 05:30:37 +0000 (UTC)","from mx.tkos.co.il (guitar.tcltek.co.il [192.115.133.116])\n\tby whitealder.osuosl.org (Postfix) with ESMTPS id C612288391\n\tfor ; Wed, 6 Sep 2017 05:30:36 +0000 (UTC)","from sapphire.tkos.co.il (unknown [10.0.4.3])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby mx.tkos.co.il (Postfix) with ESMTPS id C1EE64405FD;\n\tWed, 6 Sep 2017 08:30:33 +0300 (IDT)"],"X-Virus-Scanned":["amavisd-new at osuosl.org","amavisd-new at osuosl.org"],"X-Greylist":"domain auto-whitelisted by SQLgrey-1.7.6","Date":"Wed, 6 Sep 2017 08:30:32 +0300","From":"Baruch Siach ","To":"Thomas Petazzoni ","Message-ID":"<20170906053032.tdj2seviftc5dbxz@sapphire.tkos.co.il>","References":"<87aa32f0dbacc3252ade43fc605e7f2c310e6465.1504638326.git.baruch@tkos.co.il>\n\t<20170905214447.7e75c2da@windsurf.lan>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20170905214447.7e75c2da@windsurf.lan>","User-Agent":"NeoMutt/20170609 (1.8.3)","Cc":"buildroot@busybox.net","Subject":"Re: [Buildroot] [PATCH 1/2] shairport-sync: fix static link with\n\tmbedtls","X-BeenThere":"buildroot@busybox.net","X-Mailman-Version":"2.1.18-1","Precedence":"list","List-Id":"Discussion and development of buildroot ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"buildroot-bounces@busybox.net","Sender":"\"buildroot\" "}},{"id":1774138,"web_url":"http://patchwork.ozlabs.org/comment/1774138/","msgid":"<908ec92f-0bbc-8d76-b9e0-232c43ec6d6a@mind.be>","list_archive_url":null,"date":"2017-09-24T11:52:38","subject":"Re: [Buildroot] [PATCH 1/2] shairport-sync: fix static link with\n\tmbedtls","submitter":{"id":11809,"url":"http://patchwork.ozlabs.org/api/people/11809/","name":"Arnout Vandecappelle","email":"arnout@mind.be"},"content":"On 05-09-17 21:05, Baruch Siach wrote:\n> mbedtls provided libraries are interdependent. libmbedtls depends on\n> libmbedx509. Both depend on libmbedcrypto. When compression is enabled\n> libz is also needed.\n> \n> Fixes:\n> http://autobuild.buildroot.net/results/79d/79d9aff5edb6a767c38efb54256a4f20fc36a6ee/\n> \n> Cc: Jörg Krause \n> Signed-off-by: Baruch Siach \n\n Applied to master, thanks.\n\n I also double-checked that shairport-sync is the only package that suffers from\nthis problem. Other packages (e.g. hiawatha, curl, ...) build fine statically.\n\n Regards,\n Arnout\n\n> ---\n> package/shairport-sync/shairport-sync.mk | 6 ++++++\n> 1 file changed, 6 insertions(+)\n> \n> diff --git a/package/shairport-sync/shairport-sync.mk b/package/shairport-sync/shairport-sync.mk\n> index 208a9b3b1e33..75e1ae85e3d2 100644\n> --- a/package/shairport-sync/shairport-sync.mk\n> +++ b/package/shairport-sync/shairport-sync.mk\n> @@ -19,6 +19,8 @@ SHAIRPORT_SYNC_CONF_OPTS = --with-alsa \\\n> \t--with-pipe \\\n> \t--with-stdout\n> \n> +SHAIRPORT_SYNC_CONF_ENV += LIBS=\"$(SHAIRPORT_SYNC_CONF_LIBS)\"\n> +\n> # Avahi or tinysvcmdns (shaiport-sync bundles its own version of tinysvcmdns).\n> # Avahi support needs libavahi-client, which is built by avahi if avahi-daemon\n> # and dbus is selected. Since there is no BR2_PACKAGE_LIBAVAHI_CLIENT config\n> @@ -38,6 +40,10 @@ SHAIRPORT_SYNC_CONF_OPTS += --with-ssl=openssl\n> else\n> SHAIRPORT_SYNC_DEPENDENCIES += mbedtls\n> SHAIRPORT_SYNC_CONF_OPTS += --with-ssl=mbedtls\n> +SHAIRPORT_SYNC_CONF_LIBS += -lmbedx509 -lmbedcrypto\n> +ifeq ($(BR2_PACKAGE_MBEDTLS_COMPRESSION),y)\n> +SHAIRPORT_SYNC_CONF_LIBS += -lz\n> +endif\n> endif\n> \n> ifeq ($(BR2_PACKAGE_SHAIRPORT_SYNC_LIBSOXR),y)\n>","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","buildroot@lists.busybox.net"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","buildroot@osuosl.org"],"Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=busybox.net\n\t(client-ip=140.211.166.138; helo=whitealder.osuosl.org;\n\tenvelope-from=buildroot-bounces@busybox.net;\n\treceiver=)","Received":["from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y0Qb30GZwz9sxR\n\tfor ;\n\tSun, 24 Sep 2017 21:53:19 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 89281884E9;\n\tSun, 24 Sep 2017 11:53:15 +0000 (UTC)","from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id DGbna8gHI5u6; Sun, 24 Sep 2017 11:53:13 +0000 (UTC)","from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 9BDC4884B1;\n\tSun, 24 Sep 2017 11:53:13 +0000 (UTC)","from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id E80A31C0021\n\tfor ;\n\tSun, 24 Sep 2017 11:53:12 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id E3CB6884B1\n\tfor ;\n\tSun, 24 Sep 2017 11:53:12 +0000 (UTC)","from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id gzMzgiwE6ZLB for ;\n\tSun, 24 Sep 2017 11:53:11 +0000 (UTC)","from exchange.essensium.com (220.77.144.195.ipv4.evonet.be\n\t[195.144.77.220])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 8E2B78673C\n\tfor ; Sun, 24 Sep 2017 11:53:11 +0000 (UTC)","from [10.8.0.14] (10.3.7.11) by beleexch01.local.ess-mail.com\n\t(10.3.7.8) with Microsoft SMTP Server (TLS) id 15.0.847.32;\n\tSun, 24 Sep 2017 13:52:40 +0200"],"X-Virus-Scanned":["amavisd-new at osuosl.org","amavisd-new at osuosl.org"],"X-Greylist":"domain auto-whitelisted by SQLgrey-1.7.6","To":"Baruch Siach , ","References":"<87aa32f0dbacc3252ade43fc605e7f2c310e6465.1504638326.git.baruch@tkos.co.il>","From":"Arnout Vandecappelle ","Organization":"Essensium/Mind","Message-ID":"<908ec92f-0bbc-8d76-b9e0-232c43ec6d6a@mind.be>","Date":"Sun, 24 Sep 2017 13:52:38 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<87aa32f0dbacc3252ade43fc605e7f2c310e6465.1504638326.git.baruch@tkos.co.il>","Content-Language":"en-GB","X-Originating-IP":"[10.3.7.11]","X-ClientProxiedBy":"beleexch01.local.ess-mail.com (10.3.7.8) To\n\tbeleexch01.local.ess-mail.com (10.3.7.8)","Subject":"Re: [Buildroot] [PATCH 1/2] shairport-sync: fix static link with\n\tmbedtls","X-BeenThere":"buildroot@busybox.net","X-Mailman-Version":"2.1.18-1","Precedence":"list","List-Id":"Discussion and development of buildroot ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"buildroot-bounces@busybox.net","Sender":"\"buildroot\" "}}]