[{"id":1763680,"web_url":"http://patchwork.ozlabs.org/comment/1763680/","msgid":"<CAL_JsqJhEaZkcBA6qnC3rVduQJ9Yesrz_h9i_WXo1bRaq1NT4Q@mail.gmail.com>","list_archive_url":null,"date":"2017-09-05T21:47:26","subject":"Re: [PATCH v5 3/3] Bluetooth: btqcomsmd: retieve BD address from DT","submitter":{"id":67416,"url":"http://patchwork.ozlabs.org/api/people/67416/","name":"Rob Herring","email":"robh+dt@kernel.org"},"content":"On Tue, Sep 5, 2017 at 1:58 PM, Loic Poulain <loic.poulain@linaro.org> wrote:\n> Retrieve BD address from the DT local-bd-address property.\n> This address must be unique and is usually added in the DT\n> by the bootloader which has access to the provisioned data.\n>\n> Signed-off-by: Loic Poulain <loic.poulain@linaro.org>\n> ---\n>  v2: Set device as unconfigured if default address detected\n>      Add warning if BD addr retrieved from DT\n>  v3: if no addr retrieved from DT, unconditionally set\n>      the invalid BD addr flag.\n>      swap and set bdaddr in the platform probe\n>  v4: Add dt-bindings documentation\n>      split patch in two parts (setup, dt prop)\n>      use local-bd-address name instead of local-mac-address\n>  v5: remove 2/3 merged in bluetooth-next tree\n>      Add bluetooth.txt for common BT bindings\n>      expect local-bd-address in little-endian format\n>\n>  drivers/bluetooth/btqcomsmd.c | 12 ++++++++++++\n>  1 file changed, 12 insertions(+)\n>\n> diff --git a/drivers/bluetooth/btqcomsmd.c b/drivers/bluetooth/btqcomsmd.c\n> index bd810d0..c6d3fd9 100644\n> --- a/drivers/bluetooth/btqcomsmd.c\n> +++ b/drivers/bluetooth/btqcomsmd.c\n> @@ -15,6 +15,8 @@\n>  #include <linux/module.h>\n>  #include <linux/slab.h>\n>  #include <linux/rpmsg.h>\n> +#include <linux/of.h>\n> +\n>  #include <linux/soc/qcom/wcnss_ctrl.h>\n>  #include <linux/platform_device.h>\n>\n> @@ -135,6 +137,7 @@ static int btqcomsmd_setup(struct hci_dev *hdev)\n>\n>  static int btqcomsmd_probe(struct platform_device *pdev)\n>  {\n> +       const bdaddr_t *bdaddr;\n>         struct btqcomsmd *btq;\n>         struct hci_dev *hdev;\n>         void *wcnss;\n> @@ -156,6 +159,15 @@ static int btqcomsmd_probe(struct platform_device *pdev)\n>         if (IS_ERR(btq->cmd_channel))\n>                 return PTR_ERR(btq->cmd_channel);\n>\n> +       /* The local-bd-address DT property is usually injected by the\n> +        * bootloader which has access to the allocated BD address.\n> +        */\n> +       bdaddr = of_get_property(pdev->dev.of_node, \"local-bd-address\", &ret);\n> +       if (bdaddr && ret == sizeof(bdaddr_t)) {\n> +               BT_INFO(\"BD address %pMR retrieved from device-tree\", bdaddr);\n> +               bacpy(&btq->bdaddr, bdaddr);\n> +       }\n\nCan we put all this into a helper function before we get more\ninstances. And use the u8 array property function. We're trying to\nmake of_get_property an internal function.\n\nRob\n--\nTo unsubscribe from this list: send the line \"unsubscribe devicetree\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at  http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"<devicetree-owner@vger.kernel.org>","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=<UNKNOWN>)","mail.kernel.org;\n\tdmarc=none (p=none dis=none) header.from=kernel.org","mail.kernel.org;\n\tspf=none smtp.mailfrom=robh+dt@kernel.org"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xn0gq00tSz9t2R\n\tfor <incoming-dt@patchwork.ozlabs.org>;\n\tWed,  6 Sep 2017 07:47:50 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752408AbdIEVrt (ORCPT\n\t<rfc822;incoming-dt@patchwork.ozlabs.org>);\n\tTue, 5 Sep 2017 17:47:49 -0400","from mail.kernel.org ([198.145.29.99]:42672 \"EHLO mail.kernel.org\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1751413AbdIEVrs (ORCPT <rfc822;devicetree@vger.kernel.org>);\n\tTue, 5 Sep 2017 17:47:48 -0400","from mail-qk0-f179.google.com (mail-qk0-f179.google.com\n\t[209.85.220.179])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128\n\tbits)) (No client certificate requested)\n\tby mail.kernel.org (Postfix) with ESMTPSA id A740521E91;\n\tTue,  5 Sep 2017 21:47:47 +0000 (UTC)","by mail-qk0-f179.google.com with SMTP id z143so15300982qkb.3;\n\tTue, 05 Sep 2017 14:47:47 -0700 (PDT)","by 10.12.153.1 with HTTP; Tue, 5 Sep 2017 14:47:26 -0700 (PDT)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mail.kernel.org A740521E91","X-Gm-Message-State":"AHPjjUhhKPIwMWNfAj4VR2PBX2m82HjO5sKQ5zGGUqGO8er7gTu/pqqK\n\tHzzsXUxK/WI7haKm0m5e6puJW+QOBg==","X-Google-Smtp-Source":"ADKCNb7GNCOZAHCEG4FJ/cCXnBT3Ota7Fc5eod4FEbZ455sXG81w/AYJMpECxCL0MnTPi0FB6EsVA6Xhkhs+XMJJ7RE=","X-Received":"by 10.233.239.69 with SMTP id d66mr707736qkg.296.1504648066887; \n\tTue, 05 Sep 2017 14:47:46 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<1504637923-21652-3-git-send-email-loic.poulain@linaro.org>","References":"<1504637923-21652-1-git-send-email-loic.poulain@linaro.org>\n\t<1504637923-21652-3-git-send-email-loic.poulain@linaro.org>","From":"Rob Herring <robh+dt@kernel.org>","Date":"Tue, 5 Sep 2017 16:47:26 -0500","X-Gmail-Original-Message-ID":"<CAL_JsqJhEaZkcBA6qnC3rVduQJ9Yesrz_h9i_WXo1bRaq1NT4Q@mail.gmail.com>","Message-ID":"<CAL_JsqJhEaZkcBA6qnC3rVduQJ9Yesrz_h9i_WXo1bRaq1NT4Q@mail.gmail.com>","Subject":"Re: [PATCH v5 3/3] Bluetooth: btqcomsmd: retieve BD address from DT","To":"Loic Poulain <loic.poulain@linaro.org>","Cc":"Marcel Holtmann <marcel@holtmann.org>,\n\tJohan Hedberg <johan.hedberg@gmail.com>,\n\t\"open list:BLUETOOTH DRIVERS\" <linux-bluetooth@vger.kernel.org>,\n\tlinux-arm-msm <linux-arm-msm@vger.kernel.org>,\n\t\"devicetree@vger.kernel.org\" <devicetree@vger.kernel.org>,\n\tBjorn Andersson <bjorn.andersson@linaro.org>","Content-Type":"text/plain; charset=\"UTF-8\"","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"<devicetree.vger.kernel.org>","X-Mailing-List":"devicetree@vger.kernel.org"}},{"id":1763849,"web_url":"http://patchwork.ozlabs.org/comment/1763849/","msgid":"<46A7D7AE-FDBB-424D-8E85-7180FEE24A14@holtmann.org>","list_archive_url":null,"date":"2017-09-06T07:04:30","subject":"Re: [PATCH v5 3/3] Bluetooth: btqcomsmd: retieve BD address from DT","submitter":{"id":384,"url":"http://patchwork.ozlabs.org/api/people/384/","name":"Marcel Holtmann","email":"marcel@holtmann.org"},"content":"Hi Rob,\n\n>> Retrieve BD address from the DT local-bd-address property.\n>> This address must be unique and is usually added in the DT\n>> by the bootloader which has access to the provisioned data.\n>> \n>> Signed-off-by: Loic Poulain <loic.poulain@linaro.org>\n>> ---\n>> v2: Set device as unconfigured if default address detected\n>>     Add warning if BD addr retrieved from DT\n>> v3: if no addr retrieved from DT, unconditionally set\n>>     the invalid BD addr flag.\n>>     swap and set bdaddr in the platform probe\n>> v4: Add dt-bindings documentation\n>>     split patch in two parts (setup, dt prop)\n>>     use local-bd-address name instead of local-mac-address\n>> v5: remove 2/3 merged in bluetooth-next tree\n>>     Add bluetooth.txt for common BT bindings\n>>     expect local-bd-address in little-endian format\n>> \n>> drivers/bluetooth/btqcomsmd.c | 12 ++++++++++++\n>> 1 file changed, 12 insertions(+)\n>> \n>> diff --git a/drivers/bluetooth/btqcomsmd.c b/drivers/bluetooth/btqcomsmd.c\n>> index bd810d0..c6d3fd9 100644\n>> --- a/drivers/bluetooth/btqcomsmd.c\n>> +++ b/drivers/bluetooth/btqcomsmd.c\n>> @@ -15,6 +15,8 @@\n>> #include <linux/module.h>\n>> #include <linux/slab.h>\n>> #include <linux/rpmsg.h>\n>> +#include <linux/of.h>\n>> +\n>> #include <linux/soc/qcom/wcnss_ctrl.h>\n>> #include <linux/platform_device.h>\n>> \n>> @@ -135,6 +137,7 @@ static int btqcomsmd_setup(struct hci_dev *hdev)\n>> \n>> static int btqcomsmd_probe(struct platform_device *pdev)\n>> {\n>> +       const bdaddr_t *bdaddr;\n>>        struct btqcomsmd *btq;\n>>        struct hci_dev *hdev;\n>>        void *wcnss;\n>> @@ -156,6 +159,15 @@ static int btqcomsmd_probe(struct platform_device *pdev)\n>>        if (IS_ERR(btq->cmd_channel))\n>>                return PTR_ERR(btq->cmd_channel);\n>> \n>> +       /* The local-bd-address DT property is usually injected by the\n>> +        * bootloader which has access to the allocated BD address.\n>> +        */\n>> +       bdaddr = of_get_property(pdev->dev.of_node, \"local-bd-address\", &ret);\n>> +       if (bdaddr && ret == sizeof(bdaddr_t)) {\n>> +               BT_INFO(\"BD address %pMR retrieved from device-tree\", bdaddr);\n>> +               bacpy(&btq->bdaddr, bdaddr);\n>> +       }\n> \n> Can we put all this into a helper function before we get more\n> instances. And use the u8 array property function. We're trying to\n> make of_get_property an internal function.\n\nusing of_property_read_u8_array seems sensible since that would shorten this into\n\n\tif (!of_property_read_u8_array(pdev->dev.of_node, “local-bd-address”, &btq->bdaddr, 6))\n\t\tbt_dev_info(pdev->dev, “BD address %pMR ..”, &btq->bdaddr);\n\nCreating a Bluetooth internal helper function seems rather pointless at this stage. If more users appears, then we might need to move this into the Bluetooth core to deal with this. However as said before, I am not a big fan of IEEE address assignment via DT since that forces to have the smarts in the boot loader and the boot loader doing the right thing. There are too many boards and DT where this will not be true. In a lot of cases it would make more sense to store the BD address as part of your file system. Since we do support this in a total generic fashion, I rather push for that method and have the QCOM SMD based SoC being the exception.\n\nRegards\n\nMarcel\n\n--\nTo unsubscribe from this list: send the line \"unsubscribe devicetree\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at  http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"<devicetree-owner@vger.kernel.org>","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=<UNKNOWN>)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xnF2C22pWz9sNd\n\tfor <incoming-dt@patchwork.ozlabs.org>;\n\tWed,  6 Sep 2017 17:04:35 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751797AbdIFHEd convert rfc822-to-8bit (ORCPT\n\t<rfc822;incoming-dt@patchwork.ozlabs.org>);\n\tWed, 6 Sep 2017 03:04:33 -0400","from coyote.holtmann.net ([212.227.132.17]:33589 \"EHLO\n\tmail.holtmann.org\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751345AbdIFHEc (ORCPT\n\t<rfc822; devicetree@vger.kernel.org>); Wed, 6 Sep 2017 03:04:32 -0400","from marcel-macpro.fritz.box (p4FF9F7CE.dip0.t-ipconnect.de\n\t[79.249.247.206])\n\tby mail.holtmann.org (Postfix) with ESMTPSA id 35E32CF2AD;\n\tWed,  6 Sep 2017 09:09:54 +0200 (CEST)"],"Content-Type":"text/plain; charset=utf-8","Mime-Version":"1.0 (Mac OS X Mail 10.3 \\(3273\\))","Subject":"Re: [PATCH v5 3/3] Bluetooth: btqcomsmd: retieve BD address from DT","From":"Marcel Holtmann <marcel@holtmann.org>","In-Reply-To":"<CAL_JsqJhEaZkcBA6qnC3rVduQJ9Yesrz_h9i_WXo1bRaq1NT4Q@mail.gmail.com>","Date":"Wed, 6 Sep 2017 09:04:30 +0200","Cc":"Loic Poulain <loic.poulain@linaro.org>,\n\tJohan Hedberg <johan.hedberg@gmail.com>,\n\t\"open list:BLUETOOTH DRIVERS\" <linux-bluetooth@vger.kernel.org>,\n\tlinux-arm-msm <linux-arm-msm@vger.kernel.org>,\n\t\"devicetree@vger.kernel.org\" <devicetree@vger.kernel.org>,\n\tBjorn Andersson <bjorn.andersson@linaro.org>","Content-Transfer-Encoding":"8BIT","Message-Id":"<46A7D7AE-FDBB-424D-8E85-7180FEE24A14@holtmann.org>","References":"<1504637923-21652-1-git-send-email-loic.poulain@linaro.org>\n\t<1504637923-21652-3-git-send-email-loic.poulain@linaro.org>\n\t<CAL_JsqJhEaZkcBA6qnC3rVduQJ9Yesrz_h9i_WXo1bRaq1NT4Q@mail.gmail.com>","To":"Rob Herring <robh+dt@kernel.org>","X-Mailer":"Apple Mail (2.3273)","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"<devicetree.vger.kernel.org>","X-Mailing-List":"devicetree@vger.kernel.org"}},{"id":1764794,"web_url":"http://patchwork.ozlabs.org/comment/1764794/","msgid":"<CAL_JsqLVQeC9TX6g+JbYq6gX7LbRT_-oeTevwDMeX8VHRrEcXg@mail.gmail.com>","list_archive_url":null,"date":"2017-09-07T15:50:32","subject":"Re: [PATCH v5 3/3] Bluetooth: btqcomsmd: retieve BD address from DT","submitter":{"id":67416,"url":"http://patchwork.ozlabs.org/api/people/67416/","name":"Rob Herring","email":"robh+dt@kernel.org"},"content":"On Wed, Sep 6, 2017 at 2:04 AM, Marcel Holtmann <marcel@holtmann.org> wrote:\n> Hi Rob,\n>\n>>> Retrieve BD address from the DT local-bd-address property.\n>>> This address must be unique and is usually added in the DT\n>>> by the bootloader which has access to the provisioned data.\n>>>\n>>> Signed-off-by: Loic Poulain <loic.poulain@linaro.org>\n\n[...]\n\n>>> +       /* The local-bd-address DT property is usually injected by the\n>>> +        * bootloader which has access to the allocated BD address.\n>>> +        */\n>>> +       bdaddr = of_get_property(pdev->dev.of_node, \"local-bd-address\", &ret);\n>>> +       if (bdaddr && ret == sizeof(bdaddr_t)) {\n>>> +               BT_INFO(\"BD address %pMR retrieved from device-tree\", bdaddr);\n>>> +               bacpy(&btq->bdaddr, bdaddr);\n>>> +       }\n>>\n>> Can we put all this into a helper function before we get more\n>> instances. And use the u8 array property function. We're trying to\n>> make of_get_property an internal function.\n>\n> using of_property_read_u8_array seems sensible since that would shorten this into\n>\n>         if (!of_property_read_u8_array(pdev->dev.of_node, “local-bd-address”, &btq->bdaddr, 6))\n>                 bt_dev_info(pdev->dev, “BD address %pMR ..”, &btq->bdaddr);\n>\n\nYes.\n\n> Creating a Bluetooth internal helper function seems rather pointless at this stage. If more users appears, then we might need to move this into the Bluetooth core to deal with this. However as said before, I am not a big fan of IEEE address assignment via DT since that forces to have the smarts in the boot loader and the boot loader doing the right thing. There are too many boards and DT where this will not be true. In a lot of cases it would make more sense to store the BD address as part of your file system. Since we do support this in a total generic fashion, I rather push for that method and have the QCOM SMD based SoC being the exception.\n\nOkay, sounds reasonable and it's your call anyway.\n\nRob\n\nBTW, your mails are always quoted-printable encoding which shouldn't\nbe used on lists AIUI.\n--\nTo unsubscribe from this list: send the line \"unsubscribe devicetree\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at  http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"<devicetree-owner@vger.kernel.org>","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=<UNKNOWN>)","mail.kernel.org;\n\tdmarc=none (p=none dis=none) header.from=kernel.org","mail.kernel.org;\n\tspf=none smtp.mailfrom=robh+dt@kernel.org"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xp4g50fyZz9sMN\n\tfor <incoming-dt@patchwork.ozlabs.org>;\n\tFri,  8 Sep 2017 01:50:57 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1755228AbdIGPuz convert rfc822-to-8bit (ORCPT\n\t<rfc822;incoming-dt@patchwork.ozlabs.org>);\n\tThu, 7 Sep 2017 11:50:55 -0400","from mail.kernel.org ([198.145.29.99]:33470 \"EHLO mail.kernel.org\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1752200AbdIGPuy (ORCPT <rfc822;devicetree@vger.kernel.org>);\n\tThu, 7 Sep 2017 11:50:54 -0400","from mail-qt0-f178.google.com (mail-qt0-f178.google.com\n\t[209.85.216.178])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128\n\tbits)) (No client certificate requested)\n\tby mail.kernel.org (Postfix) with ESMTPSA id 004F221D29;\n\tThu,  7 Sep 2017 15:50:54 +0000 (UTC)","by mail-qt0-f178.google.com with SMTP id b52so294789qtb.3;\n\tThu, 07 Sep 2017 08:50:53 -0700 (PDT)","by 10.12.153.1 with HTTP; Thu, 7 Sep 2017 08:50:32 -0700 (PDT)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mail.kernel.org 004F221D29","X-Gm-Message-State":"AHPjjUjtfs+8+aWjbKZ1rq4sRzTcMMsgNSlhRTorw5ZRqKqoNROy5hKr\n\tiqXmuyUVvkPiS+yzutZt879dZEuhbA==","X-Google-Smtp-Source":"ADKCNb6P+B1NCDGfuL2q8zoyMFa6FPXzczOIcwLf+L3pTpvntaB726eDMKWSowS93t0U1KUwWyisue4w5X/QeTS1e3s=","X-Received":"by 10.237.45.193 with SMTP id i59mr1701390qtd.87.1504799453057; \n\tThu, 07 Sep 2017 08:50:53 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<46A7D7AE-FDBB-424D-8E85-7180FEE24A14@holtmann.org>","References":"<1504637923-21652-1-git-send-email-loic.poulain@linaro.org>\n\t<1504637923-21652-3-git-send-email-loic.poulain@linaro.org>\n\t<CAL_JsqJhEaZkcBA6qnC3rVduQJ9Yesrz_h9i_WXo1bRaq1NT4Q@mail.gmail.com>\n\t<46A7D7AE-FDBB-424D-8E85-7180FEE24A14@holtmann.org>","From":"Rob Herring <robh+dt@kernel.org>","Date":"Thu, 7 Sep 2017 10:50:32 -0500","X-Gmail-Original-Message-ID":"<CAL_JsqLVQeC9TX6g+JbYq6gX7LbRT_-oeTevwDMeX8VHRrEcXg@mail.gmail.com>","Message-ID":"<CAL_JsqLVQeC9TX6g+JbYq6gX7LbRT_-oeTevwDMeX8VHRrEcXg@mail.gmail.com>","Subject":"Re: [PATCH v5 3/3] Bluetooth: btqcomsmd: retieve BD address from DT","To":"Marcel Holtmann <marcel@holtmann.org>","Cc":"Loic Poulain <loic.poulain@linaro.org>,\n\tJohan Hedberg <johan.hedberg@gmail.com>,\n\t\"open list:BLUETOOTH DRIVERS\" <linux-bluetooth@vger.kernel.org>,\n\tlinux-arm-msm <linux-arm-msm@vger.kernel.org>,\n\t\"devicetree@vger.kernel.org\" <devicetree@vger.kernel.org>,\n\tBjorn Andersson <bjorn.andersson@linaro.org>","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"8BIT","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"<devicetree.vger.kernel.org>","X-Mailing-List":"devicetree@vger.kernel.org"}},{"id":1768003,"web_url":"http://patchwork.ozlabs.org/comment/1768003/","msgid":"<20170913162113.exrujqwdecq524zf@rob-hp-laptop>","list_archive_url":null,"date":"2017-09-13T16:21:13","subject":"Re: [PATCH v5 1/3] DT: net: document Bluetooth bindings in one place","submitter":{"id":62529,"url":"http://patchwork.ozlabs.org/api/people/62529/","name":"Rob Herring (Arm)","email":"robh@kernel.org"},"content":"On Tue, Sep 05, 2017 at 08:58:41PM +0200, Loic Poulain wrote:\n> From: lpoulain <loic.poulain@gmail.com>\n> \n> In the same way as Ethernet, gather the Bluetooth related bindings in\n> one file. Introduce the bluetooth-bd-address property which can be used\n> to store the assigned BD address.\n> \n> Signed-off-by: lpoulain <loic.poulain@gmail.com>\n> ---\n>  v2: Set device as unconfigured if default address detected\n>      Add warning if BD addr retrieved from DT\n>  v3: if no addr retrieved from DT, unconditionally set\n>      the invalid BD addr flag.\n>      swap and set bdaddr in the platform probe\n>  v4: Add dt-bindings documentation\n>      split patch in two parts (setup, dt prop)\n>      use local-bd-address name instead of local-mac-address\n>  v5: remove 2/3 merged in bluetooth-next tree\n>      Add bluetooth.txt for common BT bindings\n>      expect local-bd-address in little-endian format\n> \n>  Documentation/devicetree/bindings/net/bluetooth.txt | 5 +++++\n>  1 file changed, 5 insertions(+)\n>  create mode 100644 Documentation/devicetree/bindings/net/bluetooth.txt\n\nAcked-by: Rob Herring <robh@kernel.org>\n--\nTo unsubscribe from this list: send the line \"unsubscribe devicetree\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at  http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"<devicetree-owner@vger.kernel.org>","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=<UNKNOWN>)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xsn3M2wvRz9sPm\n\tfor <incoming-dt@patchwork.ozlabs.org>;\n\tThu, 14 Sep 2017 02:21:19 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751946AbdIMQVQ (ORCPT\n\t<rfc822;incoming-dt@patchwork.ozlabs.org>);\n\tWed, 13 Sep 2017 12:21:16 -0400","from mail-io0-f195.google.com ([209.85.223.195]:33823 \"EHLO\n\tmail-io0-f195.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751648AbdIMQVP (ORCPT\n\t<rfc822; devicetree@vger.kernel.org>); Wed, 13 Sep 2017 12:21:15 -0400","by mail-io0-f195.google.com with SMTP id g32so690346ioj.1;\n\tWed, 13 Sep 2017 09:21:14 -0700 (PDT)","from localhost (216-188-254-6.dyn.grandenetworks.net.\n\t[216.188.254.6]) by smtp.gmail.com with ESMTPSA id\n\ts142sm5714526oie.49.2017.09.13.09.21.13\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tWed, 13 Sep 2017 09:21:13 -0700 (PDT)"],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:in-reply-to:user-agent;\n\tbh=EpmHlsnw5c3repI1L4PYVUxKKaex+4GvZIcG2GNA2hc=;\n\tb=ku1BuWMEAP8gLpcMESWGWkEIbJnLewTa4dqD3mA0toJyjgog2RX8WZ6pyNTejH2law\n\tWL75NgstH4FCTY9nWMmVJ9mk3NYHOwDzaPdrC5Wc5KL5Dzgf/5AdCuxWQF6PzJEbZWjt\n\tjfWX38iR40tNCuDL3BOdEceQOy9ksFsriqUJOgqKyrT7A9XMseVujQ01Do8EQn9WohV8\n\tynKH/YK4aH2F+rPkr+RWYq3PG3X2VGZNFZN/vk2HnRVEWq/PRsQt2K8riaY41Rey9/gj\n\tOHF0S4XrzQ1cZJD10PJgEjau4KUrGXETzSZJlYA1nrbDOENVs2B+kdXHphUTj/6AxQaN\n\tlqXw==","X-Gm-Message-State":"AHPjjUgKtNLZNPt71IzDzJbh6GZpD02c5WuQ7uR/pp+8+EUGutJDDr/u\n\t8dLloJLEVX46xg==","X-Google-Smtp-Source":"AOwi7QCylbjInls2ZrJGj1Kz+rjPNipFfxqtW/EOSEDz1CjyOTEhkYbGTeUsH+D0fwdzZavUiJct/Q==","X-Received":"by 10.202.252.11 with SMTP id a11mr17942091oii.117.1505319674350;\n\tWed, 13 Sep 2017 09:21:14 -0700 (PDT)","Date":"Wed, 13 Sep 2017 11:21:13 -0500","From":"Rob Herring <robh@kernel.org>","To":"Loic Poulain <loic.poulain@linaro.org>","Cc":"marcel@holtmann.org, johan.hedberg@gmail.com,\n\tlinux-bluetooth@vger.kernel.org, linux-arm-msm@vger.kernel.org,\n\tdevicetree@vger.kernel.org, bjorn.andersson@linaro.org,\n\tlpoulain <loic.poulain@gmail.com>","Subject":"Re: [PATCH v5 1/3] DT: net: document Bluetooth bindings in one place","Message-ID":"<20170913162113.exrujqwdecq524zf@rob-hp-laptop>","References":"<1504637923-21652-1-git-send-email-loic.poulain@linaro.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<1504637923-21652-1-git-send-email-loic.poulain@linaro.org>","User-Agent":"NeoMutt/20170113 (1.7.2)","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"<devicetree.vger.kernel.org>","X-Mailing-List":"devicetree@vger.kernel.org"}}]