[{"id":1765262,"web_url":"http://patchwork.ozlabs.org/comment/1765262/","msgid":"<6d9454ac-d238-fc64-04f2-4534b0a419de@free.fr>","list_archive_url":null,"date":"2017-09-08T11:26:21","subject":"Re: [PATCH 4/4] PCI: xgene: Clean up whitespace","submitter":{"id":66150,"url":"http://patchwork.ozlabs.org/api/people/66150/","name":"Mason","email":"slash.tmp@free.fr"},"content":"On 05/09/2017 20:27, Bjorn Helgaas wrote:\n\n> Use tabs (not spaces) for indentation. No functional change intended.\n\ngit diff -b should be empty, right?\n\n> @@ -280,12 +280,12 @@ static int xgene_v2_pcie_ecam_init(struct pci_config_window *cfg)\n> }\n> \n> struct pci_ecam_ops xgene_v2_pcie_ecam_ops = {\n> -\t.bus_shift = 16,\n> -\t.init = xgene_v2_pcie_ecam_init,\n> -\t.pci_ops = {\n> -\t\t.map_bus = xgene_pcie_map_bus,\n> -\t\t.read = xgene_pcie_config_read32,\n> -\t\t.write = pci_generic_config_write,\n> +\t.bus_shift\t= 16,\n> +\t.init\t\t= xgene_v2_pcie_ecam_init,\n> +\t.pci_ops\t= {\n> +\t\t.map_bus\t= xgene_pcie_map_bus,\n> +\t\t.read\t\t= xgene_pcie_config_read32,\n> +\t\t.writei\t\t= pci_generic_config_write,\n> \t}\n> };\n> #endif\n\nSpurious 'i' in '.writei' ;-)\n\nRegards.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-pci-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xpZlk1Y7rz9s83\n\tfor ;\n\tFri, 8 Sep 2017 21:26:42 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752204AbdIHL0k (ORCPT );\n\tFri, 8 Sep 2017 07:26:40 -0400","from smtp5-g21.free.fr ([212.27.42.5]:19534 \"EHLO\n\tsmtp5-g21.free.fr\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1751577AbdIHL0k (ORCPT );\n\tFri, 8 Sep 2017 07:26:40 -0400","from [172.27.0.114] (unknown [92.154.11.170])\n\t(Authenticated sender: slash.tmp)\n\tby smtp5-g21.free.fr (Postfix) with ESMTPSA id D34CD5FFA2;\n\tFri, 8 Sep 2017 13:26:21 +0200 (CEST)"],"Subject":"Re: [PATCH 4/4] PCI: xgene: Clean up whitespace","To":"Bjorn Helgaas ,\n\tJon Mason , Ray Jui ,\n\tOza Pawandeep , Tanmay Inamdar ,\n\tScott Branden ","Cc":"linux-pci ,\n\tbcm-kernel-feedback-list@broadcom.com","References":"<20170905181602.27030.65715.stgit@bhelgaas-glaptop.roam.corp.google.com>\n\t<20170905182721.27030.75771.stgit@bhelgaas-glaptop.roam.corp.google.com>","From":"Mason ","Message-ID":"<6d9454ac-d238-fc64-04f2-4534b0a419de@free.fr>","Date":"Fri, 8 Sep 2017 13:26:21 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tFirefox/52.0 SeaMonkey/2.49.1","MIME-Version":"1.0","In-Reply-To":"<20170905182721.27030.75771.stgit@bhelgaas-glaptop.roam.corp.google.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","Sender":"linux-pci-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-pci@vger.kernel.org"}},{"id":1765468,"web_url":"http://patchwork.ozlabs.org/comment/1765468/","msgid":"<20170908155141.GC29570@bhelgaas-glaptop.roam.corp.google.com>","list_archive_url":null,"date":"2017-09-08T15:51:41","subject":"Re: [PATCH 4/4] PCI: xgene: Clean up whitespace","submitter":{"id":67298,"url":"http://patchwork.ozlabs.org/api/people/67298/","name":"Bjorn Helgaas","email":"helgaas@kernel.org"},"content":"On Fri, Sep 08, 2017 at 01:26:21PM +0200, Mason wrote:\n> On 05/09/2017 20:27, Bjorn Helgaas wrote:\n> \n> >Use tabs (not spaces) for indentation. No functional change intended.\n> \n> git diff -b should be empty, right?\n\nEmpty except for a line join.\n\n> >@@ -280,12 +280,12 @@ static int xgene_v2_pcie_ecam_init(struct pci_config_window *cfg)\n> > }\n> > struct pci_ecam_ops xgene_v2_pcie_ecam_ops = {\n> >-\t.bus_shift = 16,\n> >-\t.init = xgene_v2_pcie_ecam_init,\n> >-\t.pci_ops = {\n> >-\t\t.map_bus = xgene_pcie_map_bus,\n> >-\t\t.read = xgene_pcie_config_read32,\n> >-\t\t.write = pci_generic_config_write,\n> >+\t.bus_shift\t= 16,\n> >+\t.init\t\t= xgene_v2_pcie_ecam_init,\n> >+\t.pci_ops\t= {\n> >+\t\t.map_bus\t= xgene_pcie_map_bus,\n> >+\t\t.read\t\t= xgene_pcie_config_read32,\n> >+\t\t.writei\t\t= pci_generic_config_write,\n> > \t}\n> > };\n> > #endif\n> \n> Spurious 'i' in '.writei' ;-)\n\nIndeed, \"git diff -b\" would have saved me a trip through the\nauto-builder. But this is fixed.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-pci-owner@vger.kernel.org;\n\treceiver=)","mail.kernel.org;\n\tdmarc=none (p=none dis=none) header.from=kernel.org","mail.kernel.org;\n\tspf=none smtp.mailfrom=helgaas@kernel.org"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xphdX6gfXz9s7f\n\tfor ;\n\tSat, 9 Sep 2017 01:51:44 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751543AbdIHPvn (ORCPT );\n\tFri, 8 Sep 2017 11:51:43 -0400","from mail.kernel.org ([198.145.29.99]:53420 \"EHLO mail.kernel.org\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1750966AbdIHPvn (ORCPT );\n\tFri, 8 Sep 2017 11:51:43 -0400","from localhost (unknown [69.55.156.165])\n\t(using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits))\n\t(No client certificate requested)\n\tby mail.kernel.org (Postfix) with ESMTPSA id 61B4021EAD;\n\tFri, 8 Sep 2017 15:51:42 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mail.kernel.org 61B4021EAD","Date":"Fri, 8 Sep 2017 10:51:41 -0500","From":"Bjorn Helgaas ","To":"Mason ","Cc":"Bjorn Helgaas ,\n\tJon Mason , Ray Jui ,\n\tOza Pawandeep , Tanmay Inamdar ,\n\tScott Branden ,\n\tlinux-pci ,\n\tbcm-kernel-feedback-list@broadcom.com","Subject":"Re: [PATCH 4/4] PCI: xgene: Clean up whitespace","Message-ID":"<20170908155141.GC29570@bhelgaas-glaptop.roam.corp.google.com>","References":"<20170905181602.27030.65715.stgit@bhelgaas-glaptop.roam.corp.google.com>\n\t<20170905182721.27030.75771.stgit@bhelgaas-glaptop.roam.corp.google.com>\n\t<6d9454ac-d238-fc64-04f2-4534b0a419de@free.fr>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<6d9454ac-d238-fc64-04f2-4534b0a419de@free.fr>","User-Agent":"Mutt/1.5.21 (2010-09-15)","Sender":"linux-pci-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-pci@vger.kernel.org"}}]