[{"id":1763942,"web_url":"http://patchwork.ozlabs.org/comment/1763942/","msgid":"<0e1ab5e4-2c59-b626-9dad-9c694867923e@wwsnet.net>","list_archive_url":null,"date":"2017-09-06T09:08:24","subject":"Re: [LEDE-DEV] [PATCH uclient] uclient-http: fix Host: header for\n\tliteral IPv6 addresses","submitter":{"id":69137,"url":"http://patchwork.ozlabs.org/api/people/69137/","name":"Jo-Philipp Wich","email":"jo@wwsnet.net"},"content":"Hi Matthias,\n\n> For literal IPv6 addresses, the host header must have the form\n> \n> Host: [...]\n> \n> including the square brackets, as it may also contain a port. Some \n> webservers ignore the missing brackets, while others will return\n> error 400.\n> \n> IPv6 addresses are determined by searching for ':' characters in the\n> host, as neither IPv4 addresses nor DNS names can contain colons. An\n> alternative would be to add a flag to the uclient_url struct; but as\n> this struct is exposed in public headers, such a change could be\n> considered an ABI change, making a backport difficult.\n> \n> Signed-off-by: Matthias Schiffer \n\nI would've solved it the same way so ...\n\nAcked-by: Jo-Philipp Wich \n\n~ Jo","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org; spf=none (mailfrom)\n\tsmtp.mailfrom=lists.infradead.org (client-ip=65.50.211.133;\n\thelo=bombadil.infradead.org;\n\tenvelope-from=lede-dev-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"jfpGnakU\"; \n\tdkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xnHp36f0Yz9s7c\n\tfor ;\n\tWed, 6 Sep 2017 19:09:15 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dpWKQ-00021A-BK; Wed, 06 Sep 2017 09:08:58 +0000","from mxout01.bytecamp.net ([212.204.60.217])\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dpWKK-0001vT-Dz\n\tfor lede-dev@lists.infradead.org; Wed, 06 Sep 2017 09:08:55 +0000","by mxout01.bytecamp.net (Postfix, from userid 1001)\n\tid B2C23575750; Wed, 6 Sep 2017 11:08:25 +0200 (CEST)","from mail.bytecamp.net (mail.bytecamp.net [212.204.60.9])\n\tby mxout01.bytecamp.net (Postfix) with ESMTP id 78DE557574A\n\tfor ;\n\tWed, 6 Sep 2017 11:08:25 +0200 (CEST)","(qmail 83656 invoked from network); 6 Sep 2017 11:08:25 +0200","from unknown (HELO ?172.29.4.249?) (jo%wwsnet.net@213.61.250.146)\n\tby mail.bytecamp.net with ESMTPS (DHE-RSA-AES128-SHA encrypted);\n\t6 Sep 2017 11:08:25 +0200"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:Subject:In-Reply-To:MIME-Version:Date:\n\tMessage-ID:From:References:To:Reply-To:Cc:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=3UEwzCNYOpG1zOFYtIL7cYDJcZUkARsnynq01yroM3Y=;\n\tb=jfpGnakUftRSvO\n\tdzlg5d1VLU6bN6OiQrXVDAXkYXVIcaDEDU6PkDAcuiNKDJ8T/YWswG1zx8/rbfiHPUYlIyF2mu2Vc\n\t+qOsZm1KUu69qoB2zcSct3IZp7HjIa6JUxHFAaGwJ/AAvxnMjTuDJuDKW7sCk+GuOkcxob1Tc4fLC\n\tVs98NY95C9N31EJgEzO4HZjKegbD1v+30WxcpwXZxEeHgUMD1nX1ar6XAzHYXBuohUip1RqcawBTx\n\t9VsJe3wI3IJb9yt2/Slbh4etoX9VNrgUwC1h9nHgyt4G7nya7gVTcW+6EyyLsQi6nLLuGprTYkMIz\n\tlQAVPtHDZ82wVlpCdpbQ==;","To":"lede-dev@lists.infradead.org","References":"<20d72a4907c5ebf06ca1f54ae79efc2e4000e4d5.1504634305.git.mschiffer@universe-factory.net>","From":"Jo-Philipp Wich ","Message-ID":"<0e1ab5e4-2c59-b626-9dad-9c694867923e@wwsnet.net>","Date":"Wed, 6 Sep 2017 11:08:24 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20d72a4907c5ebf06ca1f54ae79efc2e4000e4d5.1504634305.git.mschiffer@universe-factory.net>","Content-Language":"en-US","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170906_020852_657663_B21B1DB0 ","X-CRM114-Status":"UNSURE ( 7.59 )","X-CRM114-Notice":"Please train this message.","X-Spam-Score":"-2.6 (--)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-2.6 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/,\n\tlow trust [212.204.60.217 listed in list.dnswl.org]\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]","Subject":"Re: [LEDE-DEV] [PATCH uclient] uclient-http: fix Host: header for\n\tliteral IPv6 addresses","X-BeenThere":"lede-dev@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"Lede-dev\" ","Errors-To":"lede-dev-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org"}}]