[{"id":1763513,"web_url":"http://patchwork.ozlabs.org/comment/1763513/","msgid":"","list_archive_url":null,"date":"2017-09-05T17:11:27","subject":"Re: [Qemu-devel] [PATCH] vhost-user: disable broken test","submitter":{"id":5111,"url":"http://patchwork.ozlabs.org/api/people/5111/","name":"Peter Maydell","email":"peter.maydell@linaro.org"},"content":"On 5 September 2017 at 18:08, Philippe Mathieu-Daudé wrote:\n> tests/vhost-user-test keeps failing on build-system since Aug 15:\n>\n> ERROR:tests/vhost-user-test.c:835:test_flags_mismatch: child process (/i386/vhost-user/flags-mismatch/subprocess [4836]) failed unexpectedly\n> ...\n> ERROR:tests/vhost-user-test.c:807:test_connect_fail: child process (/x86_64/vhost-user/connect-fail/subprocess [58910]) failed unexpectedly\n>\n> The test can still be build for debug session using:\n>\n> $ FORCE_VHOST_USER_NET_TEST=1 ./configure ...\n>\n> Suggested-by: Peter Maydell \n> Signed-off-by: Philippe Mathieu-Daudé \n> ---\n> configure | 7 ++++++-\n> 1 file changed, 6 insertions(+), 1 deletion(-)\n>\n> diff --git a/configure b/configure\n> index fb7e34a901..d3b895b167 100755\n> --- a/configure\n> +++ b/configure\n> @@ -6386,7 +6386,12 @@ if supported_kvm_target $target; then\n> if test \"$vhost_net\" = \"yes\" ; then\n> echo \"CONFIG_VHOST_NET=y\" >> $config_target_mak\n> if test \"$vhost_user\" = \"yes\" ; then\n> - echo \"CONFIG_VHOST_USER_NET_TEST_$target_name=y\" >> $config_host_mak\n> + if test -n \"${FORCE_VHOST_USER_NET_TEST}\"; then\n> + echo \"CONFIG_VHOST_USER_NET_TEST_$target_name=y\" >> $config_host_mak\n> + elif test -z \"${VHOST_USER_NET_TEST_WARNED}\"; then\n> + echo \"warning: vhost-user tests disabled\" >&2\n> + VHOST_USER_NET_TEST_WARNED=\"warned\"\n> + fi\n\nPlease don't make this print a warning -- that will just create\nnoise in my test logs to no useful effect.\n\nthanks\n-- PMM","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"N+rP8j2U\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xmtZ967XNz9t16\n\tfor ;\n\tWed, 6 Sep 2017 03:12:33 +1000 (AEST)","from localhost ([::1]:60283 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dpHOp-00042T-Tu\n\tfor incoming@patchwork.ozlabs.org; Tue, 05 Sep 2017 13:12:31 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:42617)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dpHOD-0003xW-VA\n\tfor qemu-devel@nongnu.org; Tue, 05 Sep 2017 13:11:58 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dpHO9-0002Mg-7k\n\tfor qemu-devel@nongnu.org; Tue, 05 Sep 2017 13:11:53 -0400","from mail-wr0-x232.google.com ([2a00:1450:400c:c0c::232]:33115)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from )\n\tid 1dpHO9-0002Lk-27\n\tfor qemu-devel@nongnu.org; Tue, 05 Sep 2017 13:11:49 -0400","by mail-wr0-x232.google.com with SMTP id a43so10067283wrc.0\n\tfor ; Tue, 05 Sep 2017 10:11:49 -0700 (PDT)","by 10.223.159.68 with HTTP; Tue, 5 Sep 2017 10:11:27 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc:content-transfer-encoding;\n\tbh=V6Scr0spdOtuf5uV4XEscWwB5zNpco3nRRm/7LcmUJI=;\n\tb=N+rP8j2UcIMtatu2eUPp7eAKpvPh6GpgxKTbqhcH0VCjQuAfWFE/f6OJsmJyM5Xy8H\n\tQUwCz2CZp3b1MbnZaupHtsGGf09VrceXLG/sU0WAxV5DMpIztkbYF48Gp+leSf4KbBsf\n\t0e4xlzoAUfIjSBxOspdZgKAJrrxRWT3o6nb9k=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc:content-transfer-encoding;\n\tbh=V6Scr0spdOtuf5uV4XEscWwB5zNpco3nRRm/7LcmUJI=;\n\tb=ZjjIcq7mAyrw1SMk6kHqdd1xZZUKXbIWSLtwId3j7eJ+hfiNIbDs4DZQEnyQQJK0Me\n\tibuJd4VzmMOlkH4voVvDLKYWm+MXj8z4cveO4ArpahUNRY6mTVBJr7XTM9Ryj6srAAW7\n\thyq5++yzty1Wk6zBTRy4x+0jQLdZwzQxUovPDDd8uiEaCGnYuSzUcLCogtmnQ7MPOSdC\n\tqo9/Gu7m+ttDUv/FkIx/Cd1vjQ+Z25t4Bmz5UEJcu4FypafZ4NaIT9C0/4yRoYojHgZT\n\tgiKa7M6zass+Dl6ToVaN+2Zu2CBmG96rp8QQ3IhuTtVT0CtjCt52GIiwHkYRwQ907DHX\n\td4QA==","X-Gm-Message-State":"AHPjjUhxaN8pCob+ylJ7iLdP21ZYvW4DTqgLwkcdCfMRe+cmQ3myxh0F\n\tKneGc+oOjiCtcjLwpsSNkX5eEw1s/TES","X-Google-Smtp-Source":"ADKCNb5C7Y1Er3UDxWVL85numROXn2qqdGCFRDoKJu0WE7uVeCTRTXx21EVjh8sa5nS9k8MnyNRW7+KDVbfd3Cj3PK0=","X-Received":"by 10.223.187.211 with SMTP id z19mr2590257wrg.97.1504631508108; \n\tTue, 05 Sep 2017 10:11:48 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<20170905170822.9109-1-f4bug@amsat.org>","References":"<20170905170822.9109-1-f4bug@amsat.org>","From":"Peter Maydell ","Date":"Tue, 5 Sep 2017 18:11:27 +0100","Message-ID":"","To":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2a00:1450:400c:c0c::232","Subject":"Re: [Qemu-devel] [PATCH] vhost-user: disable broken test","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"QEMU Developers ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1763519,"web_url":"http://patchwork.ozlabs.org/comment/1763519/","msgid":"<20170905171746.GI311@redhat.com>","list_archive_url":null,"date":"2017-09-05T17:17:46","subject":"Re: [Qemu-devel] [PATCH] vhost-user: disable broken test","submitter":{"id":2694,"url":"http://patchwork.ozlabs.org/api/people/2694/","name":"Daniel P. Berrangé","email":"berrange@redhat.com"},"content":"On Tue, Sep 05, 2017 at 02:08:22PM -0300, Philippe Mathieu-Daudé wrote:\n> tests/vhost-user-test keeps failing on build-system since Aug 15:\n> \n> ERROR:tests/vhost-user-test.c:835:test_flags_mismatch: child process (/i386/vhost-user/flags-mismatch/subprocess [4836]) failed unexpectedly\n> ...\n> ERROR:tests/vhost-user-test.c:807:test_connect_fail: child process (/x86_64/vhost-user/connect-fail/subprocess [58910]) failed unexpectedly\n\nSeems like it is always the subprocess tests which fail\nfrom what I see. So rather than disable the entire test,\njust put\n\n if (1) {\n g_test_skip(\"Skipping unreliable subprocess test\");\n return;\n }\n\nat the top of each test_*_subprocess() method\n\n> \n> The test can still be build for debug session using:\n> \n> $ FORCE_VHOST_USER_NET_TEST=1 ./configure ...\n> \n> Suggested-by: Peter Maydell \n> Signed-off-by: Philippe Mathieu-Daudé \n> ---\n> configure | 7 ++++++-\n> 1 file changed, 6 insertions(+), 1 deletion(-)\n> \n> diff --git a/configure b/configure\n> index fb7e34a901..d3b895b167 100755\n> --- a/configure\n> +++ b/configure\n> @@ -6386,7 +6386,12 @@ if supported_kvm_target $target; then\n> if test \"$vhost_net\" = \"yes\" ; then\n> echo \"CONFIG_VHOST_NET=y\" >> $config_target_mak\n> if test \"$vhost_user\" = \"yes\" ; then\n> - echo \"CONFIG_VHOST_USER_NET_TEST_$target_name=y\" >> $config_host_mak\n> + if test -n \"${FORCE_VHOST_USER_NET_TEST}\"; then\n> + echo \"CONFIG_VHOST_USER_NET_TEST_$target_name=y\" >> $config_host_mak\n> + elif test -z \"${VHOST_USER_NET_TEST_WARNED}\"; then\n> + echo \"warning: vhost-user tests disabled\" >&2\n> + VHOST_USER_NET_TEST_WARNED=\"warned\"\n> + fi\n> fi\n> fi\n> fi\n> -- \n> 2.14.1\n> \n> \n\nRegards,\nDaniel","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx07.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx07.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=berrange@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xmthy0jsBz9sNq\n\tfor ;\n\tWed, 6 Sep 2017 03:18:24 +1000 (AEST)","from localhost ([::1]:60301 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dpHUT-0006GI-QP\n\tfor incoming@patchwork.ozlabs.org; Tue, 05 Sep 2017 13:18:21 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:45573)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dpHU3-0006Ek-RZ\n\tfor qemu-devel@nongnu.org; Tue, 05 Sep 2017 13:18:00 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dpHTy-0005WQ-Tl\n\tfor qemu-devel@nongnu.org; Tue, 05 Sep 2017 13:17:55 -0400","from mx1.redhat.com ([209.132.183.28]:41684)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dpHTy-0005WG-NQ\n\tfor qemu-devel@nongnu.org; Tue, 05 Sep 2017 13:17:50 -0400","from smtp.corp.redhat.com\n\t(int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 9A592C013C4F;\n\tTue, 5 Sep 2017 17:17:49 +0000 (UTC)","from redhat.com (unknown [10.33.36.63])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id CC71B868AF;\n\tTue, 5 Sep 2017 17:17:48 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 9A592C013C4F","Date":"Tue, 5 Sep 2017 18:17:46 +0100","From":"\"Daniel P. Berrange\" ","To":"Philippe =?utf-8?q?Mathieu-Daud=C3=A9?= ","Message-ID":"<20170905171746.GI311@redhat.com>","References":"<20170905170822.9109-1-f4bug@amsat.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20170905170822.9109-1-f4bug@amsat.org>","User-Agent":"Mutt/1.8.3 (2017-05-23)","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.13","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.31]);\n\tTue, 05 Sep 2017 17:17:49 +0000 (UTC)","Content-Transfer-Encoding":"quoted-printable","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH] vhost-user: disable broken test","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"\"Daniel P. Berrange\" ","Cc":"Peter Maydell , qemu-devel@nongnu.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]