[{"id":1766835,"web_url":"http://patchwork.ozlabs.org/comment/1766835/","msgid":"<21bbf85a-5afb-1d83-ae40-a5ec98e7e061@redhat.com>","list_archive_url":null,"date":"2017-09-12T10:00:28","subject":"Re: [RFC][PATCH 2/4][BZ 17083] NSS: Parse zone identifier of IPv6\n\taddresses in /etc/hosts","submitter":{"id":14312,"url":"http://patchwork.ozlabs.org/api/people/14312/","name":"Florian Weimer","email":"fweimer@redhat.com"},"content":"On 09/05/2017 06:05 PM, Łukasz Stelmach wrote:\n> +\t ret = getaddrinfo(addr, NULL, &hints, &res);\n\nThat makes me rather nervous due to the potential for recursion. Can we\nfactor out the AI_NUMERICHOST code into a separate function instead?\n\nThanks,\nFlorian","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","mailing list libc-alpha@sourceware.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=sourceware.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=libc-alpha-return-84480-incoming=patchwork.ozlabs.org@sourceware.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tsecure) header.d=sourceware.org header.i=@sourceware.org\n\theader.b=\"XIyPtN7x\"; dkim-atps=neutral","sourceware.org; auth=none","ext-mx06.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx06.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=fweimer@redhat.com"],"Received":["from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xs0fj0Vjrz9s4s\n\tfor ;\n\tTue, 12 Sep 2017 20:00:44 +1000 (AEST)","(qmail 98103 invoked by alias); 12 Sep 2017 10:00:38 -0000","(qmail 98088 invoked by uid 89); 12 Sep 2017 10:00:37 -0000"],"DomainKey-Signature":"a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:subject:to:references:cc:from:message-id:date\n\t:mime-version:in-reply-to:content-type\n\t:content-transfer-encoding; q=dns; s=default; b=MwJ7Ia1ZXGbPta+l\n\tiQzyaGyiYu6roPnlgWmrMMdPm44sX+ptIwPoA+DmWJDVZQFih3cI/4rRAdeIFerq\n\tZvTyJB3CJS4z2hDqVobM0gBeCWuPIsxipLdYL+Cd6uiU5E4jWDYB53ggQlV3vii6\n\tLU1nI4njoJApZFxVr4bt1ByW1ZQ=","DKIM-Signature":"v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:subject:to:references:cc:from:message-id:date\n\t:mime-version:in-reply-to:content-type\n\t:content-transfer-encoding; s=default; bh=dqQSRx5GSRCrVTkjRC4OWp\n\tTTkso=; b=XIyPtN7xWsIQJjoCOpeq2ePlW9IKSTedl7ntyuYcXgUilJOiL/AdQD\n\tqDaH2D484uk9N50rWEHB/razOdTJrBy01Ty6I3brHqy71nnhhNUDgq4StLjmBcyk\n\tU+Ho9l/0Kkpo1RNSWxieFbJBCVIA9p+239Z7FsxcLjSM3flxptLQ4=","Mailing-List":"contact libc-alpha-help@sourceware.org; run by ezmlm","Precedence":"bulk","List-Id":"","List-Unsubscribe":"","List-Subscribe":"","List-Archive":"","List-Post":"","List-Help":",\n\t","Sender":"libc-alpha-owner@sourceware.org","X-Virus-Found":"No","X-Spam-SWARE-Status":"No, score=-1.9 required=5.0 tests=BAYES_00,\n\tRP_MATCHES_RCVD,\n\tSPF_HELO_PASS autolearn=ham version=3.3.2\n\tspammy=Hx-languages-length:347,\n\tHContent-Transfer-Encoding:8bit","X-HELO":"mx1.redhat.com","DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com C8C43356CD","Subject":"Re: [RFC][PATCH 2/4][BZ 17083] NSS: Parse zone identifier of IPv6\n\taddresses in /etc/hosts","To":"=?utf-8?q?=C5=81ukasz_Stelmach?= ","References":"<20170905160530.19525-1-stlman@poczta.fm>\n\t<20170905160530.19525-3-stlman@poczta.fm>","Cc":"libc-alpha@sourceware.org","From":"Florian Weimer ","Message-ID":"<21bbf85a-5afb-1d83-ae40-a5ec98e7e061@redhat.com>","Date":"Tue, 12 Sep 2017 12:00:28 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170905160530.19525-3-stlman@poczta.fm>","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"8bit"}},{"id":1766863,"web_url":"http://patchwork.ozlabs.org/comment/1766863/","msgid":"<451F792A-F4B0-4F9A-8964-522B72A31F0D@poczta.fm>","list_archive_url":null,"date":"2017-09-12T10:40:23","subject":"Re: [RFC][PATCH 2/4][BZ 17083] NSS: Parse zone identifier of IPv6\n\taddresses in /etc/hosts","submitter":{"id":72297,"url":"http://patchwork.ozlabs.org/api/people/72297/","name":"Łukasz Stelmach","email":"stlman@poczta.fm"},"content":"Dnia 12 września 2017 12:00:28 CEST, Florian Weimer napisał(a):\n>On 09/05/2017 06:05 PM, Łukasz Stelmach wrote:\n>> +\t ret = getaddrinfo(addr, NULL, &hints, &res);\n>\n>That makes me rather nervous due to the potential for recursion. Can\n>we\n>factor out the AI_NUMERICHOST code into a separate function instead?\n\nIt appears there is little code to be factored-out in gaih_inet(),\nwhich is the workhorse. There several attempts to parse\na hostname as numeric and the flag prevents from going\nfurther.\n\nYet another issue I can see, is that the factored out code\nwould have to be public (?) to be available to NSS module.\n\nNow I can see there is __inet6_scopeid__pton(). I'll try it but I am\nafraid probably it won't be visible in the NSS module.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","mailing list libc-alpha@sourceware.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=sourceware.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=libc-alpha-return-84483-incoming=patchwork.ozlabs.org@sourceware.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tsecure) header.d=sourceware.org header.i=@sourceware.org\n\theader.b=\"HORIQFdU\"; dkim-atps=neutral","sourceware.org; auth=none"],"Received":["from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xs1Xy65qvz9s7g\n\tfor ;\n\tTue, 12 Sep 2017 20:40:50 +1000 (AEST)","(qmail 39821 invoked by alias); 12 Sep 2017 10:40:45 -0000","(qmail 38752 invoked by uid 89); 12 Sep 2017 10:40:44 -0000"],"DomainKey-Signature":"a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:date:in-reply-to:references:mime-version\n\t:content-type:content-transfer-encoding:subject:to:cc:from\n\t:message-id; q=dns; s=default; b=S/lGdy0Aiew/6UdSg9Lo7fV9GfZ67hU\n\tknvxyt1LSBVTU0EQFCubURuC8YN0FPYthUNlF9z771LBQ+upRry7ZcCf25m0xdI9\n\ta4H6kdgRBKNu5ll5VraUbUG1nU7lD44B3+wyK0gov3ouVmTEDJBFns7M7GV8byT1\n\tC/XwiNGIXg44=","DKIM-Signature":"v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:date:in-reply-to:references:mime-version\n\t:content-type:content-transfer-encoding:subject:to:cc:from\n\t:message-id; s=default; bh=I5F9botqj2X4IGd+vrYyu4bfV7U=; b=HORIQ\n\tFdUca2j//7AeC9vVqSZiBwcCGkoPjpebTsne0r0ixm3Wuziy+rIut0nisUdwPJBh\n\tHNp3hBaCW+XCz6YejvjU/WDX2ROFPFZCxkIbMVxlCLdeBf4roaIaYgbTn3n8qjOY\n\tJqTO0fcUjYBfHZ/eVnZKdkJkzviPHVUMFfGwTg=","Mailing-List":"contact libc-alpha-help@sourceware.org; run by ezmlm","Precedence":"bulk","List-Id":"","List-Unsubscribe":"","List-Subscribe":"","List-Archive":"","List-Post":"","List-Help":",\n\t","Sender":"libc-alpha-owner@sourceware.org","X-Virus-Found":"No","X-Spam-SWARE-Status":"No, score=-1.9 required=5.0 tests=BAYES_00,\n\tFREEMAIL_FROM,\n\tSPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:888","X-HELO":"smtpo.poczta.interia.pl","X-Interia-R":"Interia","X-Interia-R-IP":"158.255.7.61","X-Interia-R-Helo":"<[10.10.10.1]>","Date":"Tue, 12 Sep 2017 10:40:23 +0000","User-Agent":"K-9 Mail for Android","In-Reply-To":"<21bbf85a-5afb-1d83-ae40-a5ec98e7e061@redhat.com>","References":"<20170905160530.19525-1-stlman@poczta.fm>\n\t<20170905160530.19525-3-stlman@poczta.fm>\n\t<21bbf85a-5afb-1d83-ae40-a5ec98e7e061@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain;\n charset=utf-8","Content-Transfer-Encoding":"quoted-printable","Subject":"Re: [RFC][PATCH 2/4][BZ 17083] NSS: Parse zone identifier of IPv6\n\taddresses in /etc/hosts","To":"Florian Weimer ","CC":"libc-alpha@sourceware.org","From":"=?utf-8?q?=C5=81ukasz_Stelmach?= ","Message-ID":"<451F792A-F4B0-4F9A-8964-522B72A31F0D@poczta.fm>","X-Interia-Antivirus":"OK"}},{"id":1766875,"web_url":"http://patchwork.ozlabs.org/comment/1766875/","msgid":"","list_archive_url":null,"date":"2017-09-12T10:51:19","subject":"Re: [RFC][PATCH 2/4][BZ 17083] NSS: Parse zone identifier of IPv6\n\taddresses in /etc/hosts","submitter":{"id":14312,"url":"http://patchwork.ozlabs.org/api/people/14312/","name":"Florian Weimer","email":"fweimer@redhat.com"},"content":"On 09/12/2017 12:40 PM, Łukasz Stelmach wrote:\n> Yet another issue I can see, is that the factored out code\n> would have to be public (?) to be available to NSS module.\n\nWe have GLIBC_PRIVATE for that.\n\n> Now I can see there is __inet6_scopeid__pton(). I'll try it but I am\n> afraid probably it won't be visible in the NSS module.\n\nIt's exported because getaddrinfo is also compiled into nscd (outside\nlibc) and it has to reference __inet6_scopeid__pton somehow.\n\nThanks,\nFlorian","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","mailing list libc-alpha@sourceware.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=sourceware.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=libc-alpha-return-84485-incoming=patchwork.ozlabs.org@sourceware.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tsecure) header.d=sourceware.org header.i=@sourceware.org\n\theader.b=\"K4hNLTa9\"; dkim-atps=neutral","sourceware.org; auth=none","ext-mx06.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx06.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=fweimer@redhat.com"],"Received":["from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xs1nG6m7kz9s7g\n\tfor ;\n\tTue, 12 Sep 2017 20:51:30 +1000 (AEST)","(qmail 125099 invoked by alias); 12 Sep 2017 10:51:25 -0000","(qmail 125089 invoked by uid 89); 12 Sep 2017 10:51:24 -0000"],"DomainKey-Signature":"a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:subject:to:cc:references:from:message-id:date\n\t:mime-version:in-reply-to:content-type\n\t:content-transfer-encoding; q=dns; s=default; b=etC7Tk6l8GrWEe9d\n\t8+Szi/bC3x7JXpbgoGIltLbwY5apxgicxapvV6/PKIj5WdTaqAy2YobT99T8Y04b\n\toYtEVxlJu1VVMpe+TFwEiWkyPoXrNsdhum94Rxms9BBeBWyH/MlaGxyPdjNEtNmW\n\tOk01YTncyD+zxYSZNfYCZwTE/3I=","DKIM-Signature":"v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:subject:to:cc:references:from:message-id:date\n\t:mime-version:in-reply-to:content-type\n\t:content-transfer-encoding; s=default; bh=yfWacjkituEPmeMLO7H+Tz\n\t3+Ejg=; b=K4hNLTa9DUPsAOSLO0mboudLlIXrAFJmMXmc9PvCG2xqXoyHYMEeAg\n\t0q8sdNEple2tua8cwKrKEN45xd0xNgrTsDRy/QRp5z0Kumh+AYUB6iYauD4HTd8o\n\t7bP7BWcl+aVebEprvgPEBjIKD6JYfSfLZuLpXssp3hLWr7Usgxs+c=","Mailing-List":"contact libc-alpha-help@sourceware.org; run by ezmlm","Precedence":"bulk","List-Id":"","List-Unsubscribe":"","List-Subscribe":"","List-Archive":"","List-Post":"","List-Help":",\n\t","Sender":"libc-alpha-owner@sourceware.org","X-Virus-Found":"No","X-Spam-SWARE-Status":"No, score=-1.9 required=5.0 tests=BAYES_00,\n\tRP_MATCHES_RCVD,\n\tSPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Yet,\n\tHx-languages-length:572, H*M:7fa6,\n\tHContent-Transfer-Encoding:8bit","X-HELO":"mx1.redhat.com","DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 4B268356C9","Subject":"Re: [RFC][PATCH 2/4][BZ 17083] NSS: Parse zone identifier of IPv6\n\taddresses in /etc/hosts","To":"=?utf-8?q?=C5=81ukasz_Stelmach?= ","Cc":"libc-alpha@sourceware.org","References":"<20170905160530.19525-1-stlman@poczta.fm>\n\t<20170905160530.19525-3-stlman@poczta.fm>\n\t<21bbf85a-5afb-1d83-ae40-a5ec98e7e061@redhat.com>\n\t<451F792A-F4B0-4F9A-8964-522B72A31F0D@poczta.fm>","From":"Florian Weimer ","Message-ID":"","Date":"Tue, 12 Sep 2017 12:51:19 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<451F792A-F4B0-4F9A-8964-522B72A31F0D@poczta.fm>","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"8bit"}},{"id":1767668,"web_url":"http://patchwork.ozlabs.org/comment/1767668/","msgid":"","list_archive_url":null,"date":"2017-09-13T08:19:16","subject":"Re: [RFC][PATCH 2/4][BZ 17083] NSS: Parse zone identifier of IPv6\n\taddresses in /etc/hosts","submitter":{"id":72297,"url":"http://patchwork.ozlabs.org/api/people/72297/","name":"Łukasz Stelmach","email":"stlman@poczta.fm"},"content":"Dnia 12 września 2017 12:51:19 CEST, Florian Weimer napisał(a):\n>On 09/12/2017 12:40 PM, Łukasz Stelmach wrote:\n>> Now I can see there is __inet6_scopeid__pton(). I'll try it but I am\n>> afraid probably it won't be visible in the NSS module.\n>\n>It's exported because getaddrinfo is also compiled into nscd (outside\n>libc) and it has to reference __inet6_scopeid__pton somehow.\n\nYes it is visible.\n\nI have identified the code that does what I need. This is more or less the else-if\nin getaddrinfo.c:531 (commit 620ff9eea6).\n\nPractical question: what would be the preferred way of (re)using thiscode in files-hosts.c?","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","mailing list libc-alpha@sourceware.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=sourceware.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=libc-alpha-return-84537-incoming=patchwork.ozlabs.org@sourceware.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tsecure) header.d=sourceware.org header.i=@sourceware.org\n\theader.b=\"iiWF56+K\"; dkim-atps=neutral","sourceware.org; auth=none"],"Received":["from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xsZMw1W0Vz9s7B\n\tfor ;\n\tWed, 13 Sep 2017 18:19:55 +1000 (AEST)","(qmail 112238 invoked by alias); 13 Sep 2017 08:19:48 -0000","(qmail 112156 invoked by uid 89); 13 Sep 2017 08:19:40 -0000"],"DomainKey-Signature":"a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:date:in-reply-to:references:mime-version\n\t:content-type:content-transfer-encoding:subject:to:cc:from\n\t:message-id; q=dns; s=default; b=mmXFrYqLAcDcRlv72xpKGgpVCqLvhp/\n\toFMVnmv2l6AppI2Z9qB0kg5irVnzAPEIIWxQxMkn2t60uwXZrLlVXSpZFh4ZDKCE\n\tx9IAiSDsmhjd16rLmmef10h3OKoy1e1Vj0jsVVAtGadzTJvEs3dkda/dNjN5qnZv\n\ttgA045wSV7zY=","DKIM-Signature":"v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:date:in-reply-to:references:mime-version\n\t:content-type:content-transfer-encoding:subject:to:cc:from\n\t:message-id; s=default; bh=HZlQXBdnLla4u34DMhm8oh4DNDQ=; b=iiWF5\n\t6+Kl8KM+nO7WBVOeDp8u+EqSyWHy6ZcIfYRzIDkpLSMOhxwU8CYgV7BTfz394Zv/\n\tQ9NyzKYggeJNtC1D55XVif32jlL6wUEnMEQWpqFyFsvR2v9WFWolhsNoLr+X087m\n\tBzKJl7sa8DRNw3cUcsZ4lKBgt8hrNMt/VEWWB0=","Mailing-List":"contact libc-alpha-help@sourceware.org; run by ezmlm","Precedence":"bulk","List-Id":"","List-Unsubscribe":"","List-Subscribe":"","List-Archive":"","List-Post":"","List-Help":",\n\t","Sender":"libc-alpha-owner@sourceware.org","X-Virus-Found":"No","X-Spam-SWARE-Status":"No, score=-1.9 required=5.0 tests=BAYES_00,\n\tFREEMAIL_FROM,\n\tSPF_PASS autolearn=ham version=3.3.2 spammy=H*RU:sk:62-210-,\n\tHx-spam-relays-external:sk:62-210-, H*r:sk:62-210-","X-HELO":"smtpo.poczta.interia.pl","X-Interia-R":"Interia","X-Interia-R-IP":"62.210.105.116","X-Interia-R-Helo":"<[10.10.10.1]>","Date":"Wed, 13 Sep 2017 08:19:16 +0000","User-Agent":"K-9 Mail for Android","In-Reply-To":"","References":"<20170905160530.19525-1-stlman@poczta.fm>\n\t<20170905160530.19525-3-stlman@poczta.fm>\n\t<21bbf85a-5afb-1d83-ae40-a5ec98e7e061@redhat.com>\n\t<451F792A-F4B0-4F9A-8964-522B72A31F0D@poczta.fm>\n\t","MIME-Version":"1.0","Content-Type":"text/plain;\n charset=utf-8","Content-Transfer-Encoding":"quoted-printable","Subject":"Re: [RFC][PATCH 2/4][BZ 17083] NSS: Parse zone identifier of IPv6\n\taddresses in /etc/hosts","To":"Florian Weimer ","CC":"libc-alpha@sourceware.org","From":"=?utf-8?q?=C5=81ukasz_Stelmach?= ","Message-ID":"","X-Interia-Antivirus":"OK"}}]