[{"id":1763855,"web_url":"http://patchwork.ozlabs.org/comment/1763855/","msgid":"<21f52be4-164c-ea1b-4d6e-802ea423d2a9@linux.vnet.ibm.com>","list_archive_url":null,"date":"2017-09-06T07:19:01","subject":"Re: [Qemu-devel] [PATCH 2/3] iotests: use -ccw on s390x for 051","submitter":{"id":70124,"url":"http://patchwork.ozlabs.org/api/people/70124/","name":"QingFeng Hao","email":"haoqf@linux.vnet.ibm.com"},"content":"在 2017/9/5 23:16, Cornelia Huck 写道:\n> The default cpu model on s390x does not provide zPCI, which is\n> not yet wired up on tcg. Moreover, virtio-ccw is the standard\n> on s390x, so use the -ccw instead of the -pci versions of virtio\n> devices on s390x.\n>\n> Provide an output file for s390x.\n>\n> Signed-off-by: Cornelia Huck \n> ---\n> tests/qemu-iotests/051 | 9 +-\n> tests/qemu-iotests/051.s390-ccw-virtio.out | 434 +++++++++++++++++++++++++++++\n> 2 files changed, 442 insertions(+), 1 deletion(-)\n> create mode 100644 tests/qemu-iotests/051.s390-ccw-virtio.out\n>\n> diff --git a/tests/qemu-iotests/051 b/tests/qemu-iotests/051\n> index c8cfc764bc..f6ad0f4f0b 100755\n> --- a/tests/qemu-iotests/051\n> +++ b/tests/qemu-iotests/051\n> @@ -103,7 +103,14 @@ echo\n> echo === Device without drive ===\n> echo\n>\n> -run_qemu -device virtio-scsi-pci -device scsi-hd\n> +case \"$QEMU_DEFAULT_MACHINE\" in\n> + s390-ccw-virtio)\n> + run_qemu -device virtio-scsi-ccw -device scsi-hd\n> + ;;\n> + *)\n> + run_qemu -device virtio-scsi-pci -device scsi-hd\n> + ;;\n> +esac\n>\n> echo\n> echo === Overriding backing file ===\nRegarding the new output file, I have a doubt that why there is no \nchange on \"check\"\nscript where the result check is located:\nif diff -w \"$reference\" $tmp.out >/dev/null 2>&1\nThanks!\n> diff --git a/tests/qemu-iotests/051.s390-ccw-virtio.out b/tests/qemu-iotests/051.s390-ccw-virtio.out\n> new file mode 100644\n> index 0000000000..7555f0b73e\n> --- /dev/null\n> +++ b/tests/qemu-iotests/051.s390-ccw-virtio.out\n[...]","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xnFMg2QMHz9sNd\n\tfor ;\n\tWed, 6 Sep 2017 17:19:43 +1000 (AEST)","from localhost ([::1]:34547 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dpUcf-0007EJ-Fu\n\tfor incoming@patchwork.ozlabs.org; Wed, 06 Sep 2017 03:19:41 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:50972)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dpUcL-0007D0-L3\n\tfor qemu-devel@nongnu.org; Wed, 06 Sep 2017 03:19:22 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dpUcH-0007VA-6G\n\tfor qemu-devel@nongnu.org; Wed, 06 Sep 2017 03:19:21 -0400","from mx0a-001b2d01.pphosted.com ([148.163.156.1]:55653)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dpUcG-0007UU-Tz\n\tfor qemu-devel@nongnu.org; Wed, 06 Sep 2017 03:19:17 -0400","from pps.filterd (m0098399.ppops.net [127.0.0.1])\n\tby mx0a-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id\n\tv867JE3B145621\n\tfor ; Wed, 6 Sep 2017 03:19:14 -0400","from e18.ny.us.ibm.com (e18.ny.us.ibm.com [129.33.205.208])\n\tby mx0a-001b2d01.pphosted.com with ESMTP id 2ctcd50hsw-1\n\t(version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT)\n\tfor ; Wed, 06 Sep 2017 03:19:14 -0400","from localhost\n\tby e18.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use\n\tOnly! Violators will be prosecuted\n\tfor from ;\n\tWed, 6 Sep 2017 03:19:12 -0400","from b01cxnp22034.gho.pok.ibm.com (9.57.198.24)\n\tby e18.ny.us.ibm.com (146.89.104.205) with IBM ESMTP SMTP Gateway:\n\tAuthorized Use Only! Violators will be prosecuted; \n\tWed, 6 Sep 2017 03:19:10 -0400","from b01ledav005.gho.pok.ibm.com (b01ledav005.gho.pok.ibm.com\n\t[9.57.199.110])\n\tby b01cxnp22034.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP\n\tid v867JAPH23134280; Wed, 6 Sep 2017 07:19:10 GMT","from b01ledav005.gho.pok.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id 95516AE034;\n\tWed, 6 Sep 2017 03:19:36 -0400 (EDT)","from [9.125.65.66] (unknown [9.125.65.66])\n\tby b01ledav005.gho.pok.ibm.com (Postfix) with ESMTPS id 874B7AE04B;\n\tWed, 6 Sep 2017 03:19:33 -0400 (EDT)"],"To":"Cornelia Huck , kwolf@redhat.com, mreitz@redhat.com","References":"<20170905151614.31303-1-cohuck@redhat.com>\n\t<20170905151614.31303-3-cohuck@redhat.com>","From":"QingFeng Hao ","Date":"Wed, 6 Sep 2017 15:19:01 +0800","User-Agent":"Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170905151614.31303-3-cohuck@redhat.com>","Content-Type":"text/plain; charset=gbk; format=flowed","X-TM-AS-GCONF":"00","x-cbid":"17090607-0044-0000-0000-000003889C78","X-IBM-SpamModules-Scores":"","X-IBM-SpamModules-Versions":"BY=3.00007675; HX=3.00000241; KW=3.00000007;\n\tPH=3.00000004; SC=3.00000226; SDB=6.00912963; UDB=6.00458169;\n\tIPR=6.00693226; \n\tBA=6.00005573; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009;\n\tZB=6.00000000; \n\tZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00017028;\n\tXFM=3.00000015; UTC=2017-09-06 07:19:12","X-IBM-AV-DETECTION":"SAVI=unused REMOTE=unused XFE=unused","x-cbparentid":"17090607-0045-0000-0000-000007B6B79C","Message-Id":"<21f52be4-164c-ea1b-4d6e-802ea423d2a9@linux.vnet.ibm.com>","X-Proofpoint-Virus-Version":"vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-09-06_02:, , signatures=0","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n\tspamscore=0 suspectscore=0\n\tmalwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam\n\tadjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000\n\tdefinitions=main-1709060099","Content-Transfer-Encoding":"quoted-printable","X-MIME-Autoconverted":"from 8bit to quoted-printable by\n\tmx0a-001b2d01.pphosted.com id v867JE3B145621","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 3.x [generic] [fuzzy]","X-Received-From":"148.163.156.1","Subject":"Re: [Qemu-devel] [PATCH 2/3] iotests: use -ccw on s390x for 051","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"thuth@redhat.com, Yi Min Zhao ,\n\tqemu-block@nongnu.org, david@redhat.com, qemu-devel@nongnu.org,\n\tagraf@suse.de, borntraeger@de.ibm.com, bjsdjshi@linux.vnet.ibm.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1763860,"web_url":"http://patchwork.ozlabs.org/comment/1763860/","msgid":"<20170906093259.44beab37.cohuck@redhat.com>","list_archive_url":null,"date":"2017-09-06T07:32:59","subject":"Re: [Qemu-devel] [PATCH 2/3] iotests: use -ccw on s390x for 051","submitter":{"id":71914,"url":"http://patchwork.ozlabs.org/api/people/71914/","name":"Cornelia Huck","email":"cohuck@redhat.com"},"content":"On Wed, 6 Sep 2017 15:19:01 +0800\nQingFeng Hao wrote:\n\n> 在 2017/9/5 23:16, Cornelia Huck 写道:\n> > The default cpu model on s390x does not provide zPCI, which is\n> > not yet wired up on tcg. Moreover, virtio-ccw is the standard\n> > on s390x, so use the -ccw instead of the -pci versions of virtio\n> > devices on s390x.\n> >\n> > Provide an output file for s390x.\n> >\n> > Signed-off-by: Cornelia Huck \n> > ---\n> > tests/qemu-iotests/051 | 9 +-\n> > tests/qemu-iotests/051.s390-ccw-virtio.out | 434 +++++++++++++++++++++++++++++\n> > 2 files changed, 442 insertions(+), 1 deletion(-)\n> > create mode 100644 tests/qemu-iotests/051.s390-ccw-virtio.out\n> >\n> > diff --git a/tests/qemu-iotests/051 b/tests/qemu-iotests/051\n> > index c8cfc764bc..f6ad0f4f0b 100755\n> > --- a/tests/qemu-iotests/051\n> > +++ b/tests/qemu-iotests/051\n> > @@ -103,7 +103,14 @@ echo\n> > echo === Device without drive ===\n> > echo\n> >\n> > -run_qemu -device virtio-scsi-pci -device scsi-hd\n> > +case \"$QEMU_DEFAULT_MACHINE\" in\n> > + s390-ccw-virtio)\n> > + run_qemu -device virtio-scsi-ccw -device scsi-hd\n> > + ;;\n> > + *)\n> > + run_qemu -device virtio-scsi-pci -device scsi-hd\n> > + ;;\n> > +esac\n> >\n> > echo\n> > echo === Overriding backing file === \n> Regarding the new output file, I have a doubt that why there is no \n> change on \"check\"\n> script where the result check is located:\n> if diff -w \"$reference\" $tmp.out >/dev/null 2>&1\n\nThe right output reference should be picked as of\n\ncommit e166b4148208656635ea2fe39df8b1e875a34fb8\nAuthor: Bo Tu \nDate: Fri Jul 3 15:28:46 2015 +0800\n\n qemu-iotests: qemu machine type support\n \n This patch adds qemu machine type support to the io test suite.\n Based on the qemu default machine type and alias of the default machine\n type the reference output file can now vary from the default to a\n machine specific output file if necessary. When using a machine specific\n reference file if the default machine has an alias then use the alias as the output\n file name otherwise use the default machine name as the output file name.\n \n Reviewed-by: Max Reitz \n Reviewed-by: Michael Mueller \n Reviewed-by: Sascha Silbe \n Signed-off-by: Xiao Guang Chen \n Signed-off-by: Kevin Wolf ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx08.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx08.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=cohuck@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xnFgy1x5Pz9sBZ\n\tfor ;\n\tWed, 6 Sep 2017 17:33:49 +1000 (AEST)","from localhost ([::1]:34594 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dpUqH-0001nd-5w\n\tfor incoming@patchwork.ozlabs.org; Wed, 06 Sep 2017 03:33:45 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:55323)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dpUpm-0001lH-Bt\n\tfor qemu-devel@nongnu.org; Wed, 06 Sep 2017 03:33:20 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dpUpl-00077P-EV\n\tfor qemu-devel@nongnu.org; Wed, 06 Sep 2017 03:33:14 -0400","from mx1.redhat.com ([209.132.183.28]:48202)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dpUpf-00074V-52; Wed, 06 Sep 2017 03:33:07 -0400","from smtp.corp.redhat.com\n\t(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id CF8DBC0587D6;\n\tWed, 6 Sep 2017 07:33:05 +0000 (UTC)","from gondolin (dhcp-192-215.str.redhat.com [10.33.192.215])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 900E519C95;\n\tWed, 6 Sep 2017 07:33:01 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com CF8DBC0587D6","Date":"Wed, 6 Sep 2017 09:32:59 +0200","From":"Cornelia Huck ","To":"QingFeng Hao ","Message-ID":"<20170906093259.44beab37.cohuck@redhat.com>","In-Reply-To":"<21f52be4-164c-ea1b-4d6e-802ea423d2a9@linux.vnet.ibm.com>","References":"<20170905151614.31303-1-cohuck@redhat.com>\n\t<20170905151614.31303-3-cohuck@redhat.com>\n\t<21f52be4-164c-ea1b-4d6e-802ea423d2a9@linux.vnet.ibm.com>","Organization":"Red Hat GmbH","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"quoted-printable","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.11","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.32]);\n\tWed, 06 Sep 2017 07:33:06 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH 2/3] iotests: use -ccw on s390x for 051","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"kwolf@redhat.com, thuth@redhat.com,\n\tYi Min Zhao , \n\tqemu-block@nongnu.org, david@redhat.com, agraf@suse.de,\n\tqemu-devel@nongnu.org, borntraeger@de.ibm.com,\n\tbjsdjshi@linux.vnet.ibm.com, mreitz@redhat.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1763918,"web_url":"http://patchwork.ozlabs.org/comment/1763918/","msgid":"<3cc7752d-2056-771b-18d4-d8b0a7dc6412@linux.vnet.ibm.com>","list_archive_url":null,"date":"2017-09-06T08:42:16","subject":"Re: [Qemu-devel] [PATCH 2/3] iotests: use -ccw on s390x for 051","submitter":{"id":70124,"url":"http://patchwork.ozlabs.org/api/people/70124/","name":"QingFeng Hao","email":"haoqf@linux.vnet.ibm.com"},"content":"在 2017/9/6 15:32, Cornelia Huck 写道:\n> On Wed, 6 Sep 2017 15:19:01 +0800\n> QingFeng Hao wrote:\n>\n>> 在 2017/9/5 23:16, Cornelia Huck 写道:\n>>> The default cpu model on s390x does not provide zPCI, which is\n>>> not yet wired up on tcg. Moreover, virtio-ccw is the standard\n>>> on s390x, so use the -ccw instead of the -pci versions of virtio\n>>> devices on s390x.\n>>>\n>>> Provide an output file for s390x.\n>>>\n>>> Signed-off-by: Cornelia Huck \n>>> ---\n>>> tests/qemu-iotests/051 | 9 +-\n>>> tests/qemu-iotests/051.s390-ccw-virtio.out | 434 +++++++++++++++++++++++++++++\n>>> 2 files changed, 442 insertions(+), 1 deletion(-)\n>>> create mode 100644 tests/qemu-iotests/051.s390-ccw-virtio.out\n>>>\n>>> diff --git a/tests/qemu-iotests/051 b/tests/qemu-iotests/051\n>>> index c8cfc764bc..f6ad0f4f0b 100755\n>>> --- a/tests/qemu-iotests/051\n>>> +++ b/tests/qemu-iotests/051\n>>> @@ -103,7 +103,14 @@ echo\n>>> echo === Device without drive ===\n>>> echo\n>>>\n>>> -run_qemu -device virtio-scsi-pci -device scsi-hd\n>>> +case \"$QEMU_DEFAULT_MACHINE\" in\n>>> + s390-ccw-virtio)\n>>> + run_qemu -device virtio-scsi-ccw -device scsi-hd\n>>> + ;;\n>>> + *)\n>>> + run_qemu -device virtio-scsi-pci -device scsi-hd\n>>> + ;;\n>>> +esac\n>>>\n>>> echo\n>>> echo === Overriding backing file ===\n>> Regarding the new output file, I have a doubt that why there is no\n>> change on \"check\"\n>> script where the result check is located:\n>> if diff -w \"$reference\" $tmp.out >/dev/null 2>&1\nGot it. It makes sense.\n> The right output reference should be picked as of\n>\n> commit e166b4148208656635ea2fe39df8b1e875a34fb8\n> Author: Bo Tu \n> Date: Fri Jul 3 15:28:46 2015 +0800\n>\n> qemu-iotests: qemu machine type support\n> \n> This patch adds qemu machine type support to the io test suite.\n> Based on the qemu default machine type and alias of the default machine\n> type the reference output file can now vary from the default to a\n> machine specific output file if necessary. When using a machine specific\n> reference file if the default machine has an alias then use the alias as the output\n> file name otherwise use the default machine name as the output file name.\n> \n> Reviewed-by: Max Reitz \n> Reviewed-by: Michael Mueller \n> Reviewed-by: Sascha Silbe \n> Signed-off-by: Xiao Guang Chen \n> Signed-off-by: Kevin Wolf \n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xnHCy6jMyz9s9Y\n\tfor ;\n\tWed, 6 Sep 2017 18:43:09 +1000 (AEST)","from localhost ([::1]:34994 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dpVvO-0003gX-AT\n\tfor incoming@patchwork.ozlabs.org; Wed, 06 Sep 2017 04:43:06 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:52453)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dpVus-0003fg-Lt\n\tfor qemu-devel@nongnu.org; Wed, 06 Sep 2017 04:42:35 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dpVup-0001C0-Cg\n\tfor qemu-devel@nongnu.org; Wed, 06 Sep 2017 04:42:34 -0400","from mx0a-001b2d01.pphosted.com ([148.163.156.1]:55968)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dpVup-00019N-3R\n\tfor qemu-devel@nongnu.org; Wed, 06 Sep 2017 04:42:31 -0400","from pps.filterd (m0098410.ppops.net [127.0.0.1])\n\tby mx0a-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id\n\tv868fLAf130297\n\tfor ; Wed, 6 Sep 2017 04:42:29 -0400","from e14.ny.us.ibm.com (e14.ny.us.ibm.com [129.33.205.204])\n\tby mx0a-001b2d01.pphosted.com with ESMTP id 2ctbwfdqnu-1\n\t(version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT)\n\tfor ; Wed, 06 Sep 2017 04:42:29 -0400","from localhost\n\tby e14.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use\n\tOnly! Violators will be prosecuted\n\tfor from ;\n\tWed, 6 Sep 2017 04:42:28 -0400","from b01cxnp23032.gho.pok.ibm.com (9.57.198.27)\n\tby e14.ny.us.ibm.com (146.89.104.201) with IBM ESMTP SMTP Gateway:\n\tAuthorized Use Only! Violators will be prosecuted; \n\tWed, 6 Sep 2017 04:42:25 -0400","from b01ledav005.gho.pok.ibm.com (b01ledav005.gho.pok.ibm.com\n\t[9.57.199.110])\n\tby b01cxnp23032.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP\n\tid v868gPwI25821276; Wed, 6 Sep 2017 08:42:25 GMT","from b01ledav005.gho.pok.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id E0C2AAE03B;\n\tWed, 6 Sep 2017 04:42:51 -0400 (EDT)","from [9.125.65.66] (unknown [9.125.65.66])\n\tby b01ledav005.gho.pok.ibm.com (Postfix) with ESMTPS id DB205AE034;\n\tWed, 6 Sep 2017 04:42:48 -0400 (EDT)"],"To":"Cornelia Huck ","References":"<20170905151614.31303-1-cohuck@redhat.com>\n\t<20170905151614.31303-3-cohuck@redhat.com>\n\t<21f52be4-164c-ea1b-4d6e-802ea423d2a9@linux.vnet.ibm.com>\n\t<20170906093259.44beab37.cohuck@redhat.com>","From":"QingFeng Hao ","Date":"Wed, 6 Sep 2017 16:42:16 +0800","User-Agent":"Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170906093259.44beab37.cohuck@redhat.com>","Content-Type":"text/plain; charset=utf-8; format=flowed","X-TM-AS-GCONF":"00","x-cbid":"17090608-0052-0000-0000-0000025B8027","X-IBM-SpamModules-Scores":"","X-IBM-SpamModules-Versions":"BY=3.00007676; HX=3.00000241; KW=3.00000007;\n\tPH=3.00000004; SC=3.00000226; SDB=6.00912991; UDB=6.00458185;\n\tIPR=6.00693254; \n\tBA=6.00005573; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009;\n\tZB=6.00000000; \n\tZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00017028;\n\tXFM=3.00000015; UTC=2017-09-06 08:42:28","X-IBM-AV-DETECTION":"SAVI=unused REMOTE=unused XFE=unused","x-cbparentid":"17090608-0053-0000-0000-000051E73C3F","Message-Id":"<3cc7752d-2056-771b-18d4-d8b0a7dc6412@linux.vnet.ibm.com>","X-Proofpoint-Virus-Version":"vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-09-06_02:, , signatures=0","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n\tspamscore=0 suspectscore=0\n\tmalwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam\n\tadjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000\n\tdefinitions=main-1709060119","Content-Transfer-Encoding":"quoted-printable","X-MIME-Autoconverted":"from 8bit to quoted-printable by\n\tmx0a-001b2d01.pphosted.com id v868fLAf130297","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 3.x [generic] [fuzzy]","X-Received-From":"148.163.156.1","Subject":"Re: [Qemu-devel] [PATCH 2/3] iotests: use -ccw on s390x for 051","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"kwolf@redhat.com, thuth@redhat.com,\n\tYi Min Zhao , \n\tqemu-block@nongnu.org, david@redhat.com, agraf@suse.de,\n\tqemu-devel@nongnu.org, borntraeger@de.ibm.com,\n\tbjsdjshi@linux.vnet.ibm.com, mreitz@redhat.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1765250,"web_url":"http://patchwork.ozlabs.org/comment/1765250/","msgid":"<20170908110425.GC3283@localhost.localdomain>","list_archive_url":null,"date":"2017-09-08T11:04:25","subject":"Re: [Qemu-devel] [PATCH 2/3] iotests: use -ccw on s390x for 051","submitter":{"id":2714,"url":"http://patchwork.ozlabs.org/api/people/2714/","name":"Kevin Wolf","email":"kwolf@redhat.com"},"content":"Am 05.09.2017 um 17:16 hat Cornelia Huck geschrieben:\n> The default cpu model on s390x does not provide zPCI, which is\n> not yet wired up on tcg. Moreover, virtio-ccw is the standard\n> on s390x, so use the -ccw instead of the -pci versions of virtio\n> devices on s390x.\n> \n> Provide an output file for s390x.\n> \n> Signed-off-by: Cornelia Huck \n> ---\n> tests/qemu-iotests/051 | 9 +-\n> tests/qemu-iotests/051.s390-ccw-virtio.out | 434 +++++++++++++++++++++++++++++\n> 2 files changed, 442 insertions(+), 1 deletion(-)\n> create mode 100644 tests/qemu-iotests/051.s390-ccw-virtio.out\n\nIt's already a pain to have two separate output files for 051, let's try\nto avoid adding a third one. Even more so since I think that the split\nbetween 051.out and 051.pc.out was already made for s390, so I'm not\nsure if anyone would actually still make use of the plain 051.out\noutput if s390 got it's own one.\n\n> diff --git a/tests/qemu-iotests/051 b/tests/qemu-iotests/051\n> index c8cfc764bc..f6ad0f4f0b 100755\n> --- a/tests/qemu-iotests/051\n> +++ b/tests/qemu-iotests/051\n> @@ -103,7 +103,14 @@ echo\n> echo === Device without drive ===\n> echo\n> \n> -run_qemu -device virtio-scsi-pci -device scsi-hd\n> +case \"$QEMU_DEFAULT_MACHINE\" in\n> + s390-ccw-virtio)\n> + run_qemu -device virtio-scsi-ccw -device scsi-hd\n> + ;;\n> + *)\n> + run_qemu -device virtio-scsi-pci -device scsi-hd\n> + ;;\n> +esac\n\nThe only real difference between 051.out and 051.s390-ccw-virtio.out is\nin this one command line. So if we don't want to just skip this part of\nthe test for non-pc like we already skip ther parts, we generally solve\nthis kind of thing by just filtering out strings that differ between\nsetups.\n\nFor example:\n\n case \"$QEMU_DEFAULT_MACHINE\" in\n s390-ccw-virtio)\n virtio_scsi=virtio-scsi-ccw\n ;;\n *)\n virtio_scsi=virtio-scsi-pci\n ;;\n esac\n\n run_qemu -device $virtio_scsi -device scsi-hd |\n sed -e \"s/$virtio_scsi/VIRTIO-SCSI/\"\n\nKevin","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx06.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx06.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=kwolf@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xpZYR6H30z9s8J\n\tfor ;\n\tFri, 8 Sep 2017 21:17:47 +1000 (AEST)","from localhost ([::1]:44703 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dqHI9-0005Ej-Un\n\tfor incoming@patchwork.ozlabs.org; Fri, 08 Sep 2017 07:17:46 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:42461)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dqH5l-0002T9-OZ\n\tfor qemu-devel@nongnu.org; Fri, 08 Sep 2017 07:05:07 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dqH5h-0000jX-0T\n\tfor qemu-devel@nongnu.org; Fri, 08 Sep 2017 07:04:57 -0400","from mx1.redhat.com ([209.132.183.28]:34170)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dqH5X-0000a2-0a; Fri, 08 Sep 2017 07:04:43 -0400","from smtp.corp.redhat.com\n\t(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id DAF031F591;\n\tFri, 8 Sep 2017 11:04:41 +0000 (UTC)","from localhost.localdomain (ovpn-116-113.ams2.redhat.com\n\t[10.36.116.113])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id 45E415C7C5;\n\tFri, 8 Sep 2017 11:04:26 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com DAF031F591","Date":"Fri, 8 Sep 2017 13:04:25 +0200","From":"Kevin Wolf ","To":"Cornelia Huck ","Message-ID":"<20170908110425.GC3283@localhost.localdomain>","References":"<20170905151614.31303-1-cohuck@redhat.com>\n\t<20170905151614.31303-3-cohuck@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20170905151614.31303-3-cohuck@redhat.com>","User-Agent":"Mutt/1.8.3 (2017-05-23)","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.11","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.30]);\n\tFri, 08 Sep 2017 11:04:42 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH 2/3] iotests: use -ccw on s390x for 051","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"thuth@redhat.com, haoqf@linux.vnet.ibm.com, qemu-block@nongnu.org,\n\tdavid@redhat.com, agraf@suse.de, qemu-devel@nongnu.org,\n\tborntraeger@de.ibm.com, mreitz@redhat.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1765264,"web_url":"http://patchwork.ozlabs.org/comment/1765264/","msgid":"<20170908132439.3ab53d7d.cohuck@redhat.com>","list_archive_url":null,"date":"2017-09-08T11:24:39","subject":"Re: [Qemu-devel] [PATCH 2/3] iotests: use -ccw on s390x for 051","submitter":{"id":71914,"url":"http://patchwork.ozlabs.org/api/people/71914/","name":"Cornelia Huck","email":"cohuck@redhat.com"},"content":"On Fri, 8 Sep 2017 13:04:25 +0200\nKevin Wolf wrote:\n\n> Am 05.09.2017 um 17:16 hat Cornelia Huck geschrieben:\n> > The default cpu model on s390x does not provide zPCI, which is\n> > not yet wired up on tcg. Moreover, virtio-ccw is the standard\n> > on s390x, so use the -ccw instead of the -pci versions of virtio\n> > devices on s390x.\n> > \n> > Provide an output file for s390x.\n> > \n> > Signed-off-by: Cornelia Huck \n> > ---\n> > tests/qemu-iotests/051 | 9 +-\n> > tests/qemu-iotests/051.s390-ccw-virtio.out | 434 +++++++++++++++++++++++++++++\n> > 2 files changed, 442 insertions(+), 1 deletion(-)\n> > create mode 100644 tests/qemu-iotests/051.s390-ccw-virtio.out \n> \n> It's already a pain to have two separate output files for 051, let's try\n> to avoid adding a third one. Even more so since I think that the split\n> between 051.out and 051.pc.out was already made for s390, so I'm not\n> sure if anyone would actually still make use of the plain 051.out\n> output if s390 got it's own one.\n\nAre there no non-pc and non-s390 machines for which this is run?\n\n> \n> > diff --git a/tests/qemu-iotests/051 b/tests/qemu-iotests/051\n> > index c8cfc764bc..f6ad0f4f0b 100755\n> > --- a/tests/qemu-iotests/051\n> > +++ b/tests/qemu-iotests/051\n> > @@ -103,7 +103,14 @@ echo\n> > echo === Device without drive ===\n> > echo\n> > \n> > -run_qemu -device virtio-scsi-pci -device scsi-hd\n> > +case \"$QEMU_DEFAULT_MACHINE\" in\n> > + s390-ccw-virtio)\n> > + run_qemu -device virtio-scsi-ccw -device scsi-hd\n> > + ;;\n> > + *)\n> > + run_qemu -device virtio-scsi-pci -device scsi-hd\n> > + ;;\n> > +esac \n> \n> The only real difference between 051.out and 051.s390-ccw-virtio.out is\n> in this one command line. So if we don't want to just skip this part of\n> the test for non-pc like we already skip ther parts, \n\nI don't think there's a reason to skip this: The only difference is\nthat we (currently) don't have a by-default usable virtio-pci\nimplementation on s390 - but any virtio transport should do.\n\nAnother approach would be to drop the -pci postfix, but I don't want to\nintroduce more usage of aliases.\n\n> we generally solve\n> this kind of thing by just filtering out strings that differ between\n> setups.\n> \n> For example:\n> \n> case \"$QEMU_DEFAULT_MACHINE\" in\n> s390-ccw-virtio)\n> virtio_scsi=virtio-scsi-ccw\n> ;;\n> *)\n> virtio_scsi=virtio-scsi-pci\n> ;;\n> esac\n> \n> run_qemu -device $virtio_scsi -device scsi-hd |\n> sed -e \"s/$virtio_scsi/VIRTIO-SCSI/\"\n\nYes, I can try this.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx01.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx01.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=cohuck@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xpZnm350Gz9s83\n\tfor ;\n\tFri, 8 Sep 2017 21:28:28 +1000 (AEST)","from localhost ([::1]:44763 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dqHSU-0008OV-F1\n\tfor incoming@patchwork.ozlabs.org; Fri, 08 Sep 2017 07:28:26 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:50774)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dqHPB-0005CI-O4\n\tfor qemu-devel@nongnu.org; Fri, 08 Sep 2017 07:25:11 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dqHP7-00006c-2r\n\tfor qemu-devel@nongnu.org; Fri, 08 Sep 2017 07:25:01 -0400","from mx1.redhat.com ([209.132.183.28]:50036)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dqHOw-0008Sm-Qt; Fri, 08 Sep 2017 07:24:47 -0400","from smtp.corp.redhat.com\n\t(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id DE79381DF7;\n\tFri, 8 Sep 2017 11:24:45 +0000 (UTC)","from gondolin (dhcp-192-215.str.redhat.com [10.33.192.215])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id CADFE619C0;\n\tFri, 8 Sep 2017 11:24:41 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com DE79381DF7","Date":"Fri, 8 Sep 2017 13:24:39 +0200","From":"Cornelia Huck ","To":"Kevin Wolf ","Message-ID":"<20170908132439.3ab53d7d.cohuck@redhat.com>","In-Reply-To":"<20170908110425.GC3283@localhost.localdomain>","References":"<20170905151614.31303-1-cohuck@redhat.com>\n\t<20170905151614.31303-3-cohuck@redhat.com>\n\t<20170908110425.GC3283@localhost.localdomain>","Organization":"Red Hat GmbH","MIME-Version":"1.0","Content-Type":"text/plain; charset=US-ASCII","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.12","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.25]);\n\tFri, 08 Sep 2017 11:24:46 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH 2/3] iotests: use -ccw on s390x for 051","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"thuth@redhat.com, haoqf@linux.vnet.ibm.com, qemu-block@nongnu.org,\n\tdavid@redhat.com, agraf@suse.de, qemu-devel@nongnu.org,\n\tborntraeger@de.ibm.com, mreitz@redhat.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1765277,"web_url":"http://patchwork.ozlabs.org/comment/1765277/","msgid":"<20170908115414.GF3283@localhost.localdomain>","list_archive_url":null,"date":"2017-09-08T11:54:14","subject":"Re: [Qemu-devel] [PATCH 2/3] iotests: use -ccw on s390x for 051","submitter":{"id":2714,"url":"http://patchwork.ozlabs.org/api/people/2714/","name":"Kevin Wolf","email":"kwolf@redhat.com"},"content":"Am 08.09.2017 um 13:24 hat Cornelia Huck geschrieben:\n> On Fri, 8 Sep 2017 13:04:25 +0200\n> Kevin Wolf wrote:\n> \n> > Am 05.09.2017 um 17:16 hat Cornelia Huck geschrieben:\n> > > The default cpu model on s390x does not provide zPCI, which is\n> > > not yet wired up on tcg. Moreover, virtio-ccw is the standard\n> > > on s390x, so use the -ccw instead of the -pci versions of virtio\n> > > devices on s390x.\n> > > \n> > > Provide an output file for s390x.\n> > > \n> > > Signed-off-by: Cornelia Huck \n> > > ---\n> > > tests/qemu-iotests/051 | 9 +-\n> > > tests/qemu-iotests/051.s390-ccw-virtio.out | 434 +++++++++++++++++++++++++++++\n> > > 2 files changed, 442 insertions(+), 1 deletion(-)\n> > > create mode 100644 tests/qemu-iotests/051.s390-ccw-virtio.out \n> > \n> > It's already a pain to have two separate output files for 051, let's try\n> > to avoid adding a third one. Even more so since I think that the split\n> > between 051.out and 051.pc.out was already made for s390, so I'm not\n> > sure if anyone would actually still make use of the plain 051.out\n> > output if s390 got it's own one.\n> \n> Are there no non-pc and non-s390 machines for which this is run?\n\nWho knows? But I'm not aware of anyone who is interested in something\nelse and has contributed to the test cases until now.\n\n> > > diff --git a/tests/qemu-iotests/051 b/tests/qemu-iotests/051\n> > > index c8cfc764bc..f6ad0f4f0b 100755\n> > > --- a/tests/qemu-iotests/051\n> > > +++ b/tests/qemu-iotests/051\n> > > @@ -103,7 +103,14 @@ echo\n> > > echo === Device without drive ===\n> > > echo\n> > > \n> > > -run_qemu -device virtio-scsi-pci -device scsi-hd\n> > > +case \"$QEMU_DEFAULT_MACHINE\" in\n> > > + s390-ccw-virtio)\n> > > + run_qemu -device virtio-scsi-ccw -device scsi-hd\n> > > + ;;\n> > > + *)\n> > > + run_qemu -device virtio-scsi-pci -device scsi-hd\n> > > + ;;\n> > > +esac \n> > \n> > The only real difference between 051.out and 051.s390-ccw-virtio.out is\n> > in this one command line. So if we don't want to just skip this part of\n> > the test for non-pc like we already skip ther parts, \n> \n> I don't think there's a reason to skip this: The only difference is\n> that we (currently) don't have a by-default usable virtio-pci\n> implementation on s390 - but any virtio transport should do.\n\nWell, any SCSI controller should do, really. Or in fact, any block\ndevice that doesn't have removable media.\n\nI agree that there's no real reason to skip the test for s390. On the\nother hand, testing it on s390 doesn't really contribute anything to the\ntest coverage as long as the suite is run for PC, too (because there is\nnothing machine dependent in the tested code path), so not running it\nwould be tolerable.\n\n> Another approach would be to drop the -pci postfix, but I don't want to\n> introduce more usage of aliases.\n\nMaybe that would indeed be the easiest way. As long as we don't intend\nto remove the alias from qemu, there's no reason not to use it in tests.\n\n> > we generally solve\n> > this kind of thing by just filtering out strings that differ between\n> > setups.\n> > \n> > For example:\n> > \n> > case \"$QEMU_DEFAULT_MACHINE\" in\n> > s390-ccw-virtio)\n> > virtio_scsi=virtio-scsi-ccw\n> > ;;\n> > *)\n> > virtio_scsi=virtio-scsi-pci\n> > ;;\n> > esac\n> > \n> > run_qemu -device $virtio_scsi -device scsi-hd |\n> > sed -e \"s/$virtio_scsi/VIRTIO-SCSI/\"\n> \n> Yes, I can try this.\n\nKevin","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx03.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx03.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=kwolf@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xpbNB2PTLz9s83\n\tfor ;\n\tFri, 8 Sep 2017 21:54:50 +1000 (AEST)","from localhost ([::1]:44881 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dqHs0-0007EZ-H0\n\tfor incoming@patchwork.ozlabs.org; Fri, 08 Sep 2017 07:54:48 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:34162)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dqHre-0007DD-0f\n\tfor qemu-devel@nongnu.org; Fri, 08 Sep 2017 07:54:27 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dqHrc-0005hW-Vp\n\tfor qemu-devel@nongnu.org; Fri, 08 Sep 2017 07:54:26 -0400","from mx1.redhat.com ([209.132.183.28]:34126)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dqHrY-0005eZ-RP; Fri, 08 Sep 2017 07:54:21 -0400","from smtp.corp.redhat.com\n\t(int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id B95D783F44;\n\tFri, 8 Sep 2017 11:54:19 +0000 (UTC)","from localhost.localdomain (ovpn-116-113.ams2.redhat.com\n\t[10.36.116.113])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id 97C0060605;\n\tFri, 8 Sep 2017 11:54:15 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com B95D783F44","Date":"Fri, 8 Sep 2017 13:54:14 +0200","From":"Kevin Wolf ","To":"Cornelia Huck ","Message-ID":"<20170908115414.GF3283@localhost.localdomain>","References":"<20170905151614.31303-1-cohuck@redhat.com>\n\t<20170905151614.31303-3-cohuck@redhat.com>\n\t<20170908110425.GC3283@localhost.localdomain>\n\t<20170908132439.3ab53d7d.cohuck@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20170908132439.3ab53d7d.cohuck@redhat.com>","User-Agent":"Mutt/1.8.3 (2017-05-23)","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.13","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.27]);\n\tFri, 08 Sep 2017 11:54:19 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH 2/3] iotests: use -ccw on s390x for 051","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"thuth@redhat.com, haoqf@linux.vnet.ibm.com, qemu-block@nongnu.org,\n\tdavid@redhat.com, agraf@suse.de, qemu-devel@nongnu.org,\n\tborntraeger@de.ibm.com, mreitz@redhat.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1765471,"web_url":"http://patchwork.ozlabs.org/comment/1765471/","msgid":"<4374d570-cee8-5f82-7187-dcb7bf57bf55@redhat.com>","list_archive_url":null,"date":"2017-09-08T15:55:29","subject":"Re: [Qemu-devel] [PATCH 2/3] iotests: use -ccw on s390x for 051","submitter":{"id":66152,"url":"http://patchwork.ozlabs.org/api/people/66152/","name":"Thomas Huth","email":"thuth@redhat.com"},"content":"On 08.09.2017 13:54, Kevin Wolf wrote:\n> Am 08.09.2017 um 13:24 hat Cornelia Huck geschrieben:\n>> On Fri, 8 Sep 2017 13:04:25 +0200\n>> Kevin Wolf wrote:\n>>\n>>> Am 05.09.2017 um 17:16 hat Cornelia Huck geschrieben:\n>>>> The default cpu model on s390x does not provide zPCI, which is\n>>>> not yet wired up on tcg. Moreover, virtio-ccw is the standard\n>>>> on s390x, so use the -ccw instead of the -pci versions of virtio\n>>>> devices on s390x.\n>>>>\n>>>> Provide an output file for s390x.\n>>>>\n>>>> Signed-off-by: Cornelia Huck \n>>>> ---\n>>>> tests/qemu-iotests/051 | 9 +-\n>>>> tests/qemu-iotests/051.s390-ccw-virtio.out | 434 +++++++++++++++++++++++++++++\n>>>> 2 files changed, 442 insertions(+), 1 deletion(-)\n>>>> create mode 100644 tests/qemu-iotests/051.s390-ccw-virtio.out \n>>>\n>>> It's already a pain to have two separate output files for 051, let's try\n>>> to avoid adding a third one. Even more so since I think that the split\n>>> between 051.out and 051.pc.out was already made for s390, so I'm not\n>>> sure if anyone would actually still make use of the plain 051.out\n>>> output if s390 got it's own one.\n>>\n>> Are there no non-pc and non-s390 machines for which this is run?\n> \n> Who knows? But I'm not aware of anyone who is interested in something\n> else and has contributed to the test cases until now.\n\nFWIW, as far as I know, Lukáš is running this test also on ppc64 in our\nweekly regression run. So it would be good to keep that working, please :-)\n\n>> Another approach would be to drop the -pci postfix, but I don't want to\n>> introduce more usage of aliases.\n> \n> Maybe that would indeed be the easiest way. As long as we don't intend\n> to remove the alias from qemu, there's no reason not to use it in tests.\n\nMaybe we should even use it in a couple of places on purpose - so we get\nsome test coverage for them?\n\n Thomas","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx05.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx05.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=thuth@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xphky34Tdz9s7f\n\tfor ;\n\tSat, 9 Sep 2017 01:56:26 +1000 (AEST)","from localhost ([::1]:46078 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dqLdo-0007pr-Hi\n\tfor incoming@patchwork.ozlabs.org; Fri, 08 Sep 2017 11:56:24 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:53631)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dqLd7-0007k0-Hb\n\tfor qemu-devel@nongnu.org; Fri, 08 Sep 2017 11:55:42 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dqLd6-00050V-Mq\n\tfor qemu-devel@nongnu.org; Fri, 08 Sep 2017 11:55:41 -0400","from mx1.redhat.com ([209.132.183.28]:31715)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dqLd1-0004wq-Nz; Fri, 08 Sep 2017 11:55:35 -0400","from smtp.corp.redhat.com\n\t(int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 9FBF591FD0;\n\tFri, 8 Sep 2017 15:55:34 +0000 (UTC)","from [10.36.116.107] (ovpn-116-107.ams2.redhat.com [10.36.116.107])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id A26D06AD35;\n\tFri, 8 Sep 2017 15:55:31 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 9FBF591FD0","To":"Kevin Wolf , Cornelia Huck ","References":"<20170905151614.31303-1-cohuck@redhat.com>\n\t<20170905151614.31303-3-cohuck@redhat.com>\n\t<20170908110425.GC3283@localhost.localdomain>\n\t<20170908132439.3ab53d7d.cohuck@redhat.com>\n\t<20170908115414.GF3283@localhost.localdomain>","From":"Thomas Huth ","Message-ID":"<4374d570-cee8-5f82-7187-dcb7bf57bf55@redhat.com>","Date":"Fri, 8 Sep 2017 17:55:29 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170908115414.GF3283@localhost.localdomain>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.15","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.29]);\n\tFri, 08 Sep 2017 15:55:34 +0000 (UTC)","Content-Transfer-Encoding":"quoted-printable","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH 2/3] iotests: use -ccw on s390x for 051","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"=?utf-8?b?THVrw6HFoSBEb2t0b3I=?= ,\n\tqemu-block@nongnu.org, borntraeger@de.ibm.com, david@redhat.com, \n\tqemu-devel@nongnu.org, agraf@suse.de, haoqf@linux.vnet.ibm.com, \n\tmreitz@redhat.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1766208,"web_url":"http://patchwork.ozlabs.org/comment/1766208/","msgid":"<7cb74027-4998-ff80-ae0a-69997df31d8c@redhat.com>","list_archive_url":null,"date":"2017-09-11T10:29:17","subject":"Re: [Qemu-devel] [PATCH 2/3] iotests: use -ccw on s390x for 051","submitter":{"id":72013,"url":"http://patchwork.ozlabs.org/api/people/72013/","name":"Lukáš Doktor","email":"ldoktor@redhat.com"},"content":"Dne 8.9.2017 v 17:55 Thomas Huth napsal(a):\n> On 08.09.2017 13:54, Kevin Wolf wrote:\n>> Am 08.09.2017 um 13:24 hat Cornelia Huck geschrieben:\n>>> On Fri, 8 Sep 2017 13:04:25 +0200\n>>> Kevin Wolf wrote:\n>>>\n>>>> Am 05.09.2017 um 17:16 hat Cornelia Huck geschrieben:\n>>>>> The default cpu model on s390x does not provide zPCI, which is\n>>>>> not yet wired up on tcg. Moreover, virtio-ccw is the standard\n>>>>> on s390x, so use the -ccw instead of the -pci versions of virtio\n>>>>> devices on s390x.\n>>>>>\n>>>>> Provide an output file for s390x.\n>>>>>\n>>>>> Signed-off-by: Cornelia Huck \n>>>>> ---\n>>>>> tests/qemu-iotests/051 | 9 +-\n>>>>> tests/qemu-iotests/051.s390-ccw-virtio.out | 434 +++++++++++++++++++++++++++++\n>>>>> 2 files changed, 442 insertions(+), 1 deletion(-)\n>>>>> create mode 100644 tests/qemu-iotests/051.s390-ccw-virtio.out \n>>>>\n>>>> It's already a pain to have two separate output files for 051, let's try\n>>>> to avoid adding a third one. Even more so since I think that the split\n>>>> between 051.out and 051.pc.out was already made for s390, so I'm not\n>>>> sure if anyone would actually still make use of the plain 051.out\n>>>> output if s390 got it's own one.\n>>>\n>>> Are there no non-pc and non-s390 machines for which this is run?\n>>\n>> Who knows? But I'm not aware of anyone who is interested in something\n>> else and has contributed to the test cases until now.\n> \n> FWIW, as far as I know, Lukáš is running this test also on ppc64 in our\n> weekly regression run. So it would be good to keep that working, please :-)\n> \n\nYes, works well on ppc64(le) and would be nice to keep it that way...\n\nLukáš\n\n>>> Another approach would be to drop the -pci postfix, but I don't want to\n>>> introduce more usage of aliases.\n>>\n>> Maybe that would indeed be the easiest way. As long as we don't intend\n>> to remove the alias from qemu, there's no reason not to use it in tests.\n> \n> Maybe we should even use it in a couple of places on purpose - so we get\n> some test coverage for them?\n> \n> Thomas\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx05.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx05.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=ldoktor@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xrPM86N1jz9s7f\n\tfor ;\n\tMon, 11 Sep 2017 20:30:11 +1000 (AEST)","from localhost ([::1]:56576 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1drLyj-0006rz-CW\n\tfor incoming@patchwork.ozlabs.org; Mon, 11 Sep 2017 06:30:09 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:32801)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1drLyB-0006rW-Oo\n\tfor qemu-devel@nongnu.org; Mon, 11 Sep 2017 06:29:37 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1drLyA-0002F8-RX\n\tfor qemu-devel@nongnu.org; Mon, 11 Sep 2017 06:29:35 -0400","from mx1.redhat.com ([209.132.183.28]:37100)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1drLy6-0002Bk-CJ; Mon, 11 Sep 2017 06:29:30 -0400","from smtp.corp.redhat.com\n\t(int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 8CCCD302483;\n\tMon, 11 Sep 2017 10:29:28 +0000 (UTC)","from localhost.localdomain (unknown [10.40.205.69])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 5549961B78;\n\tMon, 11 Sep 2017 10:29:22 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 8CCCD302483","To":"Thomas Huth , Kevin Wolf ,\n\tCornelia Huck ","References":"<20170905151614.31303-1-cohuck@redhat.com>\n\t<20170905151614.31303-3-cohuck@redhat.com>\n\t<20170908110425.GC3283@localhost.localdomain>\n\t<20170908132439.3ab53d7d.cohuck@redhat.com>\n\t<20170908115414.GF3283@localhost.localdomain>\n\t<4374d570-cee8-5f82-7187-dcb7bf57bf55@redhat.com>","From":"=?utf-8?b?THVrw6HFoSBEb2t0b3I=?= ","Message-ID":"<7cb74027-4998-ff80-ae0a-69997df31d8c@redhat.com>","Date":"Mon, 11 Sep 2017 12:29:17 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<4374d570-cee8-5f82-7187-dcb7bf57bf55@redhat.com>","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\";\n\tboundary=\"03963JhE7eti18mOCwgbNKrb3geIiedh6\"","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.14","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.29]);\n\tMon, 11 Sep 2017 10:29:28 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","X-Content-Filtered-By":"Mailman/MimeDel 2.1.21","Subject":"Re: [Qemu-devel] [PATCH 2/3] iotests: use -ccw on s390x for 051","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"qemu-block@nongnu.org, borntraeger@de.ibm.com, david@redhat.com,\n\tqemu-devel@nongnu.org, agraf@suse.de, haoqf@linux.vnet.ibm.com,\n\tmreitz@redhat.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1767196,"web_url":"http://patchwork.ozlabs.org/comment/1767196/","msgid":"<20170912180527.1f0e80b5.cohuck@redhat.com>","list_archive_url":null,"date":"2017-09-12T16:05:27","subject":"Re: [Qemu-devel] [PATCH 2/3] iotests: use -ccw on s390x for 051","submitter":{"id":71914,"url":"http://patchwork.ozlabs.org/api/people/71914/","name":"Cornelia Huck","email":"cohuck@redhat.com"},"content":"On Fri, 8 Sep 2017 17:55:29 +0200\nThomas Huth wrote:\n\n> On 08.09.2017 13:54, Kevin Wolf wrote:\n> > Am 08.09.2017 um 13:24 hat Cornelia Huck geschrieben: \n> >> On Fri, 8 Sep 2017 13:04:25 +0200\n> >> Kevin Wolf wrote:\n> >> \n> >>> Am 05.09.2017 um 17:16 hat Cornelia Huck geschrieben: \n> >>>> The default cpu model on s390x does not provide zPCI, which is\n> >>>> not yet wired up on tcg. Moreover, virtio-ccw is the standard\n> >>>> on s390x, so use the -ccw instead of the -pci versions of virtio\n> >>>> devices on s390x.\n> >>>>\n> >>>> Provide an output file for s390x.\n> >>>>\n> >>>> Signed-off-by: Cornelia Huck \n> >>>> ---\n> >>>> tests/qemu-iotests/051 | 9 +-\n> >>>> tests/qemu-iotests/051.s390-ccw-virtio.out | 434 +++++++++++++++++++++++++++++\n> >>>> 2 files changed, 442 insertions(+), 1 deletion(-)\n> >>>> create mode 100644 tests/qemu-iotests/051.s390-ccw-virtio.out \n> >>>\n> >>> It's already a pain to have two separate output files for 051, let's try\n> >>> to avoid adding a third one. Even more so since I think that the split\n> >>> between 051.out and 051.pc.out was already made for s390, so I'm not\n> >>> sure if anyone would actually still make use of the plain 051.out\n> >>> output if s390 got it's own one. \n> >>\n> >> Are there no non-pc and non-s390 machines for which this is run? \n> > \n> > Who knows? But I'm not aware of anyone who is interested in something\n> > else and has contributed to the test cases until now. \n> \n> FWIW, as far as I know, Lukáš is running this test also on ppc64 in our\n> weekly regression run. So it would be good to keep that working, please :-)\n> \n> >> Another approach would be to drop the -pci postfix, but I don't want to\n> >> introduce more usage of aliases. \n> > \n> > Maybe that would indeed be the easiest way. As long as we don't intend\n> > to remove the alias from qemu, there's no reason not to use it in tests. \n> \n> Maybe we should even use it in a couple of places on purpose - so we get\n> some test coverage for them?\n\nFWIW, using the the sed post-run filtering works well for 051, but it\nis driving me bonkers on 067 (or maybe I should just call it a day...)\n\nWe could use the sed approach for 051 and the alias approach on 067 -\nthat way we would also test aliases :)\n\nAny preferences by the iotest maintainers?\n\n[I'd be happy if iotests worked again on s390x...]","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx07.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx07.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=cohuck@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xs8mW4Wmdz9s82\n\tfor ;\n\tWed, 13 Sep 2017 02:06:18 +1000 (AEST)","from localhost ([::1]:36789 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1drnhY-0007GZ-0A\n\tfor incoming@patchwork.ozlabs.org; Tue, 12 Sep 2017 12:06:16 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:58113)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1drnh2-0007F9-O4\n\tfor qemu-devel@nongnu.org; Tue, 12 Sep 2017 12:05:48 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1drngy-0005oH-LY\n\tfor qemu-devel@nongnu.org; Tue, 12 Sep 2017 12:05:44 -0400","from mx1.redhat.com ([209.132.183.28]:46506)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1drngt-0005kD-PU; Tue, 12 Sep 2017 12:05:35 -0400","from smtp.corp.redhat.com\n\t(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id A6102C04B328;\n\tTue, 12 Sep 2017 16:05:34 +0000 (UTC)","from gondolin (dhcp-192-215.str.redhat.com [10.33.192.215])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id C44A16E21C;\n\tTue, 12 Sep 2017 16:05:29 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com A6102C04B328","Date":"Tue, 12 Sep 2017 18:05:27 +0200","From":"Cornelia Huck ","To":"Thomas Huth ","Message-ID":"<20170912180527.1f0e80b5.cohuck@redhat.com>","In-Reply-To":"<4374d570-cee8-5f82-7187-dcb7bf57bf55@redhat.com>","References":"<20170905151614.31303-1-cohuck@redhat.com>\n\t<20170905151614.31303-3-cohuck@redhat.com>\n\t<20170908110425.GC3283@localhost.localdomain>\n\t<20170908132439.3ab53d7d.cohuck@redhat.com>\n\t<20170908115414.GF3283@localhost.localdomain>\n\t<4374d570-cee8-5f82-7187-dcb7bf57bf55@redhat.com>","Organization":"Red Hat GmbH","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"quoted-printable","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.11","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.31]);\n\tTue, 12 Sep 2017 16:05:34 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH 2/3] iotests: use -ccw on s390x for 051","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Kevin Wolf , =?utf-8?b?THVrw6HFoQ==?=\n\tDoktor , qemu-block@nongnu.org, david@redhat.com,\n\tqemu-devel@nongnu.org, agraf@suse.de, haoqf@linux.vnet.ibm.com,\n\tmreitz@redhat.com, \tborntraeger@de.ibm.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1767215,"web_url":"http://patchwork.ozlabs.org/comment/1767215/","msgid":"<20170912161631.GL29136@localhost.localdomain>","list_archive_url":null,"date":"2017-09-12T16:16:31","subject":"Re: [Qemu-devel] [PATCH 2/3] iotests: use -ccw on s390x for 051","submitter":{"id":2714,"url":"http://patchwork.ozlabs.org/api/people/2714/","name":"Kevin Wolf","email":"kwolf@redhat.com"},"content":"Am 12.09.2017 um 18:05 hat Cornelia Huck geschrieben:\n> On Fri, 8 Sep 2017 17:55:29 +0200\n> Thomas Huth wrote:\n> \n> > On 08.09.2017 13:54, Kevin Wolf wrote:\n> > > Am 08.09.2017 um 13:24 hat Cornelia Huck geschrieben: \n> > >> On Fri, 8 Sep 2017 13:04:25 +0200\n> > >> Kevin Wolf wrote:\n> > >> \n> > >>> Am 05.09.2017 um 17:16 hat Cornelia Huck geschrieben: \n> > >>>> The default cpu model on s390x does not provide zPCI, which is\n> > >>>> not yet wired up on tcg. Moreover, virtio-ccw is the standard\n> > >>>> on s390x, so use the -ccw instead of the -pci versions of virtio\n> > >>>> devices on s390x.\n> > >>>>\n> > >>>> Provide an output file for s390x.\n> > >>>>\n> > >>>> Signed-off-by: Cornelia Huck \n> > >>>> ---\n> > >>>> tests/qemu-iotests/051 | 9 +-\n> > >>>> tests/qemu-iotests/051.s390-ccw-virtio.out | 434 +++++++++++++++++++++++++++++\n> > >>>> 2 files changed, 442 insertions(+), 1 deletion(-)\n> > >>>> create mode 100644 tests/qemu-iotests/051.s390-ccw-virtio.out \n> > >>>\n> > >>> It's already a pain to have two separate output files for 051, let's try\n> > >>> to avoid adding a third one. Even more so since I think that the split\n> > >>> between 051.out and 051.pc.out was already made for s390, so I'm not\n> > >>> sure if anyone would actually still make use of the plain 051.out\n> > >>> output if s390 got it's own one. \n> > >>\n> > >> Are there no non-pc and non-s390 machines for which this is run? \n> > > \n> > > Who knows? But I'm not aware of anyone who is interested in something\n> > > else and has contributed to the test cases until now. \n> > \n> > FWIW, as far as I know, Lukáš is running this test also on ppc64 in our\n> > weekly regression run. So it would be good to keep that working, please :-)\n> > \n> > >> Another approach would be to drop the -pci postfix, but I don't want to\n> > >> introduce more usage of aliases. \n> > > \n> > > Maybe that would indeed be the easiest way. As long as we don't intend\n> > > to remove the alias from qemu, there's no reason not to use it in tests. \n> > \n> > Maybe we should even use it in a couple of places on purpose - so we get\n> > some test coverage for them?\n> \n> FWIW, using the the sed post-run filtering works well for 051, but it\n> is driving me bonkers on 067 (or maybe I should just call it a day...)\n> \n> We could use the sed approach for 051 and the alias approach on 067 -\n> that way we would also test aliases :)\n> \n> Any preferences by the iotest maintainers?\n\nSure, that works for me. I'm happy with anything that works and doesn't\nsplit the reference output in two versions. (Not splitting is also in\nyour own interest; if anything bitrots, it's the non-pc version.)\n\nKevin","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx08.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx08.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=kwolf@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xs9110LM7z9s7f\n\tfor ;\n\tWed, 13 Sep 2017 02:17:09 +1000 (AEST)","from localhost ([::1]:36850 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1drns3-00050o-5x\n\tfor incoming@patchwork.ozlabs.org; Tue, 12 Sep 2017 12:17:07 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:34788)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1drnrj-0004yu-0I\n\tfor qemu-devel@nongnu.org; Tue, 12 Sep 2017 12:16:48 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1drnrh-00038i-T7\n\tfor qemu-devel@nongnu.org; Tue, 12 Sep 2017 12:16:46 -0400","from mx1.redhat.com ([209.132.183.28]:50192)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1drnrd-00033T-OZ; Tue, 12 Sep 2017 12:16:41 -0400","from smtp.corp.redhat.com\n\t(int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id E8112C0587F8;\n\tTue, 12 Sep 2017 16:16:39 +0000 (UTC)","from localhost.localdomain (ovpn-117-138.ams2.redhat.com\n\t[10.36.117.138])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id 0340417B54;\n\tTue, 12 Sep 2017 16:16:32 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com E8112C0587F8","Date":"Tue, 12 Sep 2017 18:16:31 +0200","From":"Kevin Wolf ","To":"Cornelia Huck ","Message-ID":"<20170912161631.GL29136@localhost.localdomain>","References":"<20170905151614.31303-1-cohuck@redhat.com>\n\t<20170905151614.31303-3-cohuck@redhat.com>\n\t<20170908110425.GC3283@localhost.localdomain>\n\t<20170908132439.3ab53d7d.cohuck@redhat.com>\n\t<20170908115414.GF3283@localhost.localdomain>\n\t<4374d570-cee8-5f82-7187-dcb7bf57bf55@redhat.com>\n\t<20170912180527.1f0e80b5.cohuck@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20170912180527.1f0e80b5.cohuck@redhat.com>","User-Agent":"Mutt/1.8.3 (2017-05-23)","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.14","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.32]);\n\tTue, 12 Sep 2017 16:16:40 +0000 (UTC)","Content-Transfer-Encoding":"quoted-printable","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH 2/3] iotests: use -ccw on s390x for 051","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"=?utf-8?b?THVrw6HFoQ==?= Doktor ,\n\tThomas Huth , qemu-block@nongnu.org, \n\tdavid@redhat.com, qemu-devel@nongnu.org, agraf@suse.de, \n\thaoqf@linux.vnet.ibm.com, mreitz@redhat.com, borntraeger@de.ibm.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]