[{"id":1781991,"web_url":"http://patchwork.ozlabs.org/comment/1781991/","msgid":"<20171007030541.GA29421@gondor.apana.org.au>","list_archive_url":null,"date":"2017-10-07T03:05:41","subject":"Re: [PATCH v8 01/20] crypto: change transient busy return code to\n\t-EAGAIN","submitter":{"id":357,"url":"http://patchwork.ozlabs.org/api/people/357/","name":"Herbert Xu","email":"herbert@gondor.apana.org.au"},"content":"On Tue, Sep 05, 2017 at 03:38:40PM +0300, Gilad Ben-Yossef wrote:\n>\n> diff --git a/crypto/algif_hash.c b/crypto/algif_hash.c\n> index 5e92bd2..3b3c154 100644\n> --- a/crypto/algif_hash.c\n> +++ b/crypto/algif_hash.c\n> @@ -39,6 +39,20 @@ struct algif_hash_tfm {\n> \tbool has_key;\n> };\n> \n> +/* Previous versions of crypto_* ops used to return -EBUSY\n> + * rather than -EAGAIN to indicate being tied up. The in\n> + * kernel API changed but we don't want to break the user\n> + * space API. As only the hash user interface exposed this\n> + * error ever to the user, do the translation here.\n> + */\n> +static inline int crypto_user_err(int err)\n> +{\n> +\tif (err == -EAGAIN)\n> +\t\treturn -EBUSY;\n> +\n> +\treturn err;\n\nI don't see the need to carry along this baggage. Does anyone\nin user-space actually rely on EBUSY?\n\nCheers,","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3y8BJm3y7rz9t5w\n\tfor ;\n\tSat, 7 Oct 2017 14:07:52 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1753037AbdJGDHh (ORCPT );\n\tFri, 6 Oct 2017 23:07:37 -0400","from orcrist.hmeau.com ([104.223.48.154]:57144 \"EHLO\n\tdeadmen.hmeau.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1752191AbdJGDHd (ORCPT\n\t); Fri, 6 Oct 2017 23:07:33 -0400","from gondobar.mordor.me.apana.org.au ([192.168.128.4]\n\thelo=gondobar)\n\tby deadmen.hmeau.com with esmtp (Exim 4.84_2 #2 (Debian))\n\tid 1e0fRG-0000aQ-7c; Sat, 07 Oct 2017 11:06:06 +0800","from herbert by gondobar with local (Exim 4.84_2)\n\t(envelope-from )\n\tid 1e0fQr-0007fa-DT; Sat, 07 Oct 2017 11:05:41 +0800"],"Date":"Sat, 7 Oct 2017 11:05:41 +0800","From":"Herbert Xu ","To":"Gilad Ben-Yossef ","Cc":"\"David S. Miller\" ,\n\tJonathan Corbet , David Howells ,\n\tTom Lendacky , Gary Hook ,\n\tBoris Brezillon ,\n\tArnaud Ebalard ,\n\tMatthias Brugger ,\n\tAlasdair Kergon ,\n\tMike Snitzer , dm-devel@redhat.com,\n\tShaohua Li , Steve French ,\n\t\"Theodore Y. Ts'o\" , Jaegeuk Kim ,\n\tSteffen Klassert ,\n\tAlexey Kuznetsov ,\n\tHideaki YOSHIFUJI ,\n\tMimi Zohar ,\n\tDmitry Kasatkin ,\n\tJames Morris ,\n\t\"Serge E. Hallyn\" , linux-crypto@vger.kernel.org,\n\tlinux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,\n\tkeyrings@vger.kernel.org, linux-arm-kernel@lists.infradead.org,\n\tlinux-mediatek@lists.infradead.org, linux-raid@vger.kernel.org,\n\tlinux-cifs@vger.kernel.org, samba-technical@lists.samba.org,\n\tlinux-fscrypt@vger.kernel.org, netdev@vger.kernel.org,\n\tlinux-ima-devel@lists.sourceforge.net,\n\tlinux-ima-user@lists.sourceforge.net,\n\tlinux-security-module@vger.kernel.org, Ofir Drang ","Subject":"Re: [PATCH v8 01/20] crypto: change transient busy return code to\n\t-EAGAIN","Message-ID":"<20171007030541.GA29421@gondor.apana.org.au>","References":"<1504615144-29770-1-git-send-email-gilad@benyossef.com>\n\t<1504615144-29770-2-git-send-email-gilad@benyossef.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<1504615144-29770-2-git-send-email-gilad@benyossef.com>","User-Agent":"Mutt/1.5.23 (2014-03-12)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1782035,"web_url":"http://patchwork.ozlabs.org/comment/1782035/","msgid":"","list_archive_url":null,"date":"2017-10-07T07:51:42","subject":"Re: [PATCH v8 01/20] crypto: change transient busy return code to\n\t-EAGAIN","submitter":{"id":11198,"url":"http://patchwork.ozlabs.org/api/people/11198/","name":"Gilad Ben-Yossef","email":"gilad@benyossef.com"},"content":"On Sat, Oct 7, 2017 at 6:05 AM, Herbert Xu wrote:\n> On Tue, Sep 05, 2017 at 03:38:40PM +0300, Gilad Ben-Yossef wrote:\n>>\n>> diff --git a/crypto/algif_hash.c b/crypto/algif_hash.c\n>> index 5e92bd2..3b3c154 100644\n>> --- a/crypto/algif_hash.c\n>> +++ b/crypto/algif_hash.c\n>> @@ -39,6 +39,20 @@ struct algif_hash_tfm {\n>> bool has_key;\n>> };\n>>\n>> +/* Previous versions of crypto_* ops used to return -EBUSY\n>> + * rather than -EAGAIN to indicate being tied up. The in\n>> + * kernel API changed but we don't want to break the user\n>> + * space API. As only the hash user interface exposed this\n>> + * error ever to the user, do the translation here.\n>> + */\n>> +static inline int crypto_user_err(int err)\n>> +{\n>> + if (err == -EAGAIN)\n>> + return -EBUSY;\n>> +\n>> + return err;\n>\n> I don't see the need to carry along this baggage. Does anyone\n> in user-space actually rely on EBUSY?\n\n\nI am not aware of anyone who does. I was just trying to avoid\nchanging the user ABI.\n\nShall I roll a new revision without this patch?\n\nThanks,\nGilad\n\n>\n> Cheers,\n> --\n> Email: Herbert Xu \n> Home Page: http://gondor.apana.org.au/~herbert/\n> PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=benyossef-com.20150623.gappssmtp.com\n\theader.i=@benyossef-com.20150623.gappssmtp.com\n\theader.b=\"pPniklwi\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3y8Jcg2nV5z9t5w\n\tfor ;\n\tSat, 7 Oct 2017 18:52:03 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751631AbdJGHvr (ORCPT );\n\tSat, 7 Oct 2017 03:51:47 -0400","from mail-oi0-f66.google.com ([209.85.218.66]:54916 \"EHLO\n\tmail-oi0-f66.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751425AbdJGHvn (ORCPT\n\t); Sat, 7 Oct 2017 03:51:43 -0400","by mail-oi0-f66.google.com with SMTP id u130so32867730oib.11\n\tfor ; Sat, 07 Oct 2017 00:51:43 -0700 (PDT)","by 10.157.61.52 with HTTP; Sat, 7 Oct 2017 00:51:42 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=benyossef-com.20150623.gappssmtp.com; s=20150623;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=SR7PT+NpWmM56pEkOYUMjTdZHxtjdBfqEWMZ5hd3TC8=;\n\tb=pPniklwilNdZmMtR02CGVYdVu4WP7cJUA06U2wIxaeoy5sXW5yypthIynPl3xuHgfD\n\tPpwVjF+Vw6A9OH2AzZTJOP2mFw3e2UqsryUNdmjxkk9vul76xm1bDwvR11Xn7LemZyPx\n\t9Si9LmZA4zjPql/IXhbMhLpbs6NvkXi6d6s7p/i7UCrjPGJoksXMRNVLnFVvU4hJ0jyI\n\tKtxEQb9qPrjPYuc8TIvGO3LWDJZS+q0p24uDXpgZoqPpx9aa54+puNF7reVnsSUN0hPt\n\tWLgEIQ3fF35u5lIlE+DgjIqcXlSPWPqMJVeIC6Xst30Hs0z7lWytX2l/KfVSr9MfHFJv\n\tjTfA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=SR7PT+NpWmM56pEkOYUMjTdZHxtjdBfqEWMZ5hd3TC8=;\n\tb=hfjYthImuDCjpQKQFtbDbdg2Mi7WlFJ6c+GuDSjxnYjlf0OSkDMbcqHPRYKZVZ4ZQX\n\tqqkmg1+DRVVnoF/Af0LJOcUBSm37nggNHMVgeWJQXmqQ3pcNiQIJi1yoefj0TSU1Ygeu\n\tCsohfFjV9UTMlHv9C/395j8fiZpWU4TI2AtJcOWm2H7X5W8jqJXVABMtb6PyMLTfdYBS\n\t69swNbRCricoerKOK0AFD4asUyGv8wAYfZH+AXYuOtnhil04PvyNVw+vjferVLEhKQEO\n\tT21J0I5R3WLfXWN3Go2ALxkdyeLDVIAajfoDXOFjF4Ki0RWxO/0MdYOGfFx+2I+UgjdV\n\tKP3A==","X-Gm-Message-State":"AMCzsaUZjXSClTapHmvPpgXXn0Y/pUyJAAVKzRqKQrnWbJuKsEzgwrCH\n\ts6NMoIdX05yNuXIqd0uo0NwoCFwMvPCw2b4II7vA5w==","X-Google-Smtp-Source":"AOwi7QDzxXXxtk0jE4PuJLFWNSLEAsgUvKzjWWRn9xoyOfioxYWtoW/uzgVFr5j/YYeyOWm8y7TdQ7l5nzzT4nO9O88=","X-Received":"by 10.202.92.197 with SMTP id q188mr2011346oib.69.1507362702719; \n\tSat, 07 Oct 2017 00:51:42 -0700 (PDT)","MIME-Version":"1.0","X-Originating-IP":"[82.81.71.2]","In-Reply-To":"<20171007030541.GA29421@gondor.apana.org.au>","References":"<1504615144-29770-1-git-send-email-gilad@benyossef.com>\n\t<1504615144-29770-2-git-send-email-gilad@benyossef.com>\n\t<20171007030541.GA29421@gondor.apana.org.au>","From":"Gilad Ben-Yossef ","Date":"Sat, 7 Oct 2017 10:51:42 +0300","Message-ID":"","Subject":"Re: [PATCH v8 01/20] crypto: change transient busy return code to\n\t-EAGAIN","To":"Herbert Xu ","Cc":"\"David S. Miller\" ,\n\tJonathan Corbet , David Howells ,\n\tTom Lendacky , Gary Hook ,\n\tBoris Brezillon ,\n\tArnaud Ebalard ,\n\tMatthias Brugger ,\n\tAlasdair Kergon , Mike Snitzer ,\n\tdevice-mapper development ,\n\tShaohua Li , Steve French ,\n\t\"Theodore Y. Ts'o\" , Jaegeuk Kim ,\n\tSteffen Klassert ,\n\tAlexey Kuznetsov ,\n\tHideaki YOSHIFUJI ,\n\tMimi Zohar ,\n\tDmitry Kasatkin ,\n\tJames Morris ,\n\t\"Serge E. Hallyn\" ,\n\tLinux Crypto Mailing List ,\n\tlinux-doc@vger.kernel.org,\n\tLinux kernel mailing list ,\n\tkeyrings@vger.kernel.org, linux-arm-kernel@lists.infradead.org,\n\tlinux-mediatek@lists.infradead.org, linux-raid@vger.kernel.org,\n\tlinux-cifs@vger.kernel.org, samba-technical@lists.samba.org,\n\tlinux-fscrypt@vger.kernel.org, netdev@vger.kernel.org,\n\tlinux-ima-devel@lists.sourceforge.net,\n\tlinux-ima-user@lists.sourceforge.net,\n\tlinux-security-module@vger.kernel.org, Ofir Drang ","Content-Type":"text/plain; charset=\"UTF-8\"","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1784310,"web_url":"http://patchwork.ozlabs.org/comment/1784310/","msgid":"<20171011062651.GA18664@gondor.apana.org.au>","list_archive_url":null,"date":"2017-10-11T06:26:51","subject":"Re: [PATCH v8 01/20] crypto: change transient busy return code to\n\t-EAGAIN","submitter":{"id":357,"url":"http://patchwork.ozlabs.org/api/people/357/","name":"Herbert Xu","email":"herbert@gondor.apana.org.au"},"content":"On Sat, Oct 07, 2017 at 10:51:42AM +0300, Gilad Ben-Yossef wrote:\n> On Sat, Oct 7, 2017 at 6:05 AM, Herbert Xu wrote:\n> > On Tue, Sep 05, 2017 at 03:38:40PM +0300, Gilad Ben-Yossef wrote:\n> >>\n> >> diff --git a/crypto/algif_hash.c b/crypto/algif_hash.c\n> >> index 5e92bd2..3b3c154 100644\n> >> --- a/crypto/algif_hash.c\n> >> +++ b/crypto/algif_hash.c\n> >> @@ -39,6 +39,20 @@ struct algif_hash_tfm {\n> >> bool has_key;\n> >> };\n> >>\n> >> +/* Previous versions of crypto_* ops used to return -EBUSY\n> >> + * rather than -EAGAIN to indicate being tied up. The in\n> >> + * kernel API changed but we don't want to break the user\n> >> + * space API. As only the hash user interface exposed this\n> >> + * error ever to the user, do the translation here.\n> >> + */\n> >> +static inline int crypto_user_err(int err)\n> >> +{\n> >> + if (err == -EAGAIN)\n> >> + return -EBUSY;\n> >> +\n> >> + return err;\n> >\n> > I don't see the need to carry along this baggage. Does anyone\n> > in user-space actually rely on EBUSY?\n> \n> \n> I am not aware of anyone who does. I was just trying to avoid\n> changing the user ABI.\n> \n> Shall I roll a new revision without this patch?\n\nYes please. I'd rather not carry this around for eternity unless\nit was actually required.\n\nThanks,","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3yBkbT5PCdz9t7r\n\tfor ;\n\tWed, 11 Oct 2017 17:29:25 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S932647AbdJKG3N (ORCPT );\n\tWed, 11 Oct 2017 02:29:13 -0400","from orcrist.hmeau.com ([104.223.48.154]:33248 \"EHLO\n\tdeadmen.hmeau.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1755552AbdJKG3I (ORCPT\n\t); Wed, 11 Oct 2017 02:29:08 -0400","from gondobar.mordor.me.apana.org.au ([192.168.128.4]\n\thelo=gondobar)\n\tby deadmen.hmeau.com with esmtp (Exim 4.84_2 #2 (Debian))\n\tid 1e2AU8-0007XM-Qs; Wed, 11 Oct 2017 14:27:16 +0800","from herbert by gondobar with local (Exim 4.84_2)\n\t(envelope-from )\n\tid 1e2ATj-0004sA-MA; Wed, 11 Oct 2017 14:26:51 +0800"],"Date":"Wed, 11 Oct 2017 14:26:51 +0800","From":"Herbert Xu ","To":"Gilad Ben-Yossef ","Cc":"\"David S. Miller\" ,\n\tJonathan Corbet , David Howells ,\n\tTom Lendacky , Gary Hook ,\n\tBoris Brezillon ,\n\tArnaud Ebalard ,\n\tMatthias Brugger ,\n\tAlasdair Kergon , Mike Snitzer ,\n\tdevice-mapper development ,\n\tShaohua Li , Steve French ,\n\t\"Theodore Y. Ts'o\" , Jaegeuk Kim ,\n\tSteffen Klassert ,\n\tAlexey Kuznetsov ,\n\tHideaki YOSHIFUJI ,\n\tMimi Zohar ,\n\tDmitry Kasatkin ,\n\tJames Morris ,\n\t\"Serge E. Hallyn\" ,\n\tLinux Crypto Mailing List ,\n\tlinux-doc@vger.kernel.org,\n\tLinux kernel mailing list ,\n\tkeyrings@vger.kernel.org, linux-arm-kernel@lists.infradead.org,\n\tlinux-mediatek@lists.infradead.org, linux-raid@vger.kernel.org,\n\tlinux-cifs@vger.kernel.org, samba-technical@lists.samba.org,\n\tlinux-fscrypt@vger.kernel.org, netdev@vger.kernel.org,\n\tlinux-ima-devel@lists.sourceforge.net,\n\tlinux-ima-user@lists.sourceforge.net,\n\tlinux-security-module@vger.kernel.org, Ofir Drang ","Subject":"Re: [PATCH v8 01/20] crypto: change transient busy return code to\n\t-EAGAIN","Message-ID":"<20171011062651.GA18664@gondor.apana.org.au>","References":"<1504615144-29770-1-git-send-email-gilad@benyossef.com>\n\t<1504615144-29770-2-git-send-email-gilad@benyossef.com>\n\t<20171007030541.GA29421@gondor.apana.org.au>\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"","User-Agent":"Mutt/1.5.23 (2014-03-12)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}}]