[{"id":1764201,"web_url":"http://patchwork.ozlabs.org/comment/1764201/","msgid":"<VI1PR04MB20787FDC28E53BF15DF8E3949A970@VI1PR04MB2078.eurprd04.prod.outlook.com>","date":"2017-09-06T15:34:11","subject":"Re: [PATCH] fsl_pci: Correct fsl_pci_mcheck_exception","submitter":{"id":67822,"url":"http://patchwork.ozlabs.org/api/people/67822/","name":"York Sun","email":"york.sun@nxp.com"},"content":"On 09/05/2017 04:59 AM, Joakim Tjernlund wrote:\n> get_user() had it args reversed causing NIP to be NULL:ed instead\n> of fixing up the PCI access.\n> \n> Note: This still hangs my P1020 Freescale CPU hard, but at least\n> I get a NIP now.\n> \n> Signed-off-by: Joakim Tjernlund <joakim.tjernlund@infinera.com>\n> ---\n>   arch/powerpc/sysdev/fsl_pci.c | 2 +-\n>   1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/arch/powerpc/sysdev/fsl_pci.c b/arch/powerpc/sysdev/fsl_pci.c\n> index 7c8b779c329a..9e64c12dff6a 100644\n> --- a/arch/powerpc/sysdev/fsl_pci.c\n> +++ b/arch/powerpc/sysdev/fsl_pci.c\n> @@ -996,7 +996,7 @@ int fsl_pci_mcheck_exception(struct pt_regs *regs)\n>   \tif (is_in_pci_mem_space(addr)) {\n>   \t\tif (user_mode(regs)) {\n>   \t\t\tpagefault_disable();\n> -\t\t\tret = get_user(regs->nip, &inst);\n> +\t\t\tret = get_user(inst, (__u32 __user *)regs->nip);\n>   \t\t\tpagefault_enable();\n>   \t\t} else {\n>   \t\t\tret = probe_kernel_address(regs->nip, inst);\n> \n\nLeo,\n\nCan you take a look, or assign it to someone who is familiar with this code?\n\nYork","headers":{"Return-Path":"<linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org>","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xnSN871TLz9t43\n\tfor <patchwork-incoming@ozlabs.org>;\n\tThu,  7 Sep 2017 01:35:52 +1000 (AEST)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3xnSN85nmvzDrSb\n\tfor <patchwork-incoming@ozlabs.org>;\n\tThu,  7 Sep 2017 01:35:52 +1000 (AEST)","from EUR01-DB5-obe.outbound.protection.outlook.com\n\t(mail-db5eur01on061b.outbound.protection.outlook.com\n\t[IPv6:2a01:111:f400:fe02::61b])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3xnSLM2B0DzDrKj\n\tfor <linuxppc-dev@lists.ozlabs.org>;\n\tThu,  7 Sep 2017 01:34:17 +1000 (AEST)","from VI1PR04MB2078.eurprd04.prod.outlook.com (10.166.43.18) by\n\tVI1PR04MB1056.eurprd04.prod.outlook.com (10.161.109.150) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id\n\t15.20.13.10; Wed, 6 Sep 2017 15:34:11 +0000","from VI1PR04MB2078.eurprd04.prod.outlook.com\n\t([fe80::6943:4a49:ab20:5920]) by\n\tVI1PR04MB2078.eurprd04.prod.outlook.com\n\t([fe80::6943:4a49:ab20:5920%13]) with mapi id 15.20.0013.018;\n\tWed, 6 Sep 2017 15:34:11 +0000"],"Authentication-Results":["ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=nxp.com header.i=@nxp.com header.b=\"OUirBo7O\";\n\tdkim-atps=neutral","lists.ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=nxp.com header.i=@nxp.com header.b=\"OUirBo7O\";\n\tdkim-atps=neutral","ozlabs.org;\n\tspf=permerror (mailfrom) smtp.mailfrom=nxp.com\n\t(client-ip=2a01:111:f400:fe02::61b;\n\thelo=eur01-db5-obe.outbound.protection.outlook.com;\n\tenvelope-from=york.sun@nxp.com; receiver=<UNKNOWN>)","lists.ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=nxp.com header.i=@nxp.com header.b=\"OUirBo7O\"; \n\tdkim-atps=neutral","spf=none (sender IP is )\n\tsmtp.mailfrom=york.sun@nxp.com; "],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version;\n\tbh=sSjgWAuu5tKISYMah38lHdwlpeMOQl+ORQ+RyaYcvD4=;\n\tb=OUirBo7OH4RKxsxcuY7r/dn8FOJ7NYjOc+7tOLPvmkGyQGhMJ/dwlgSUIdhd4GhwGSFbX3Ba7IVrvLycs0EHv4XEkL7J5mFVcCZgF+GpNFfKIjuYQBjXjklSQf8RnE6avjVuMgobClgeXi4sTgHhTGfP+msjefOJ6YNRxQNIICs=","From":"York Sun <york.sun@nxp.com>","To":"Leo Li <leoyang.li@nxp.com>","Subject":"Re: [PATCH] fsl_pci: Correct fsl_pci_mcheck_exception","Thread-Topic":"[PATCH] fsl_pci: Correct fsl_pci_mcheck_exception","Thread-Index":"AQHTJj55GWp/Tn4pW0qu/vTKzQfAZg==","Date":"Wed, 6 Sep 2017 15:34:11 +0000","Message-ID":"<VI1PR04MB20787FDC28E53BF15DF8E3949A970@VI1PR04MB2078.eurprd04.prod.outlook.com>","References":"<20170905115943.19919-1-joakim.tjernlund@infinera.com>","Accept-Language":"en-US","Content-Language":"en-US","X-MS-Has-Attach":"","X-MS-TNEF-Correlator":"","authentication-results":["ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=nxp.com header.i=@nxp.com header.b=\"OUirBo7O\";\n\tdkim-atps=neutral","lists.ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=nxp.com header.i=@nxp.com header.b=\"OUirBo7O\";\n\tdkim-atps=neutral","ozlabs.org;\n\tspf=permerror (mailfrom) smtp.mailfrom=nxp.com\n\t(client-ip=2a01:111:f400:fe02::61b;\n\thelo=eur01-db5-obe.outbound.protection.outlook.com;\n\tenvelope-from=york.sun@nxp.com; receiver=<UNKNOWN>)","lists.ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=nxp.com header.i=@nxp.com header.b=\"OUirBo7O\"; \n\tdkim-atps=neutral","spf=none (sender IP is )\n\tsmtp.mailfrom=york.sun@nxp.com; "],"x-originating-ip":"[24.56.243.53]","x-ms-publictraffictype":"Email","x-microsoft-exchange-diagnostics":"1; VI1PR04MB1056;\n\t6:0DEATjrGLXvLX1pxCfWhsVSQyo49r83W/6G8x+/h2V3uZ/giSPh3XlXCxuEPI3SGv7F3JEw1j/9LSLvcRllhQA1v6KKRTRcFP41NI/9CG5XAM3MoFh2G/meu11ePjsvlU2/zPGDvbovSnIliWDY/ulOpCi0Ga2GWJ1cOmHdrlQXWhCpU36+wB9aEy81GdEdAgdY7DAzZkdwBNaZTlD5WcCzSDWoipnGdnc0tmvAMb1FQTmmn4q/kRQuld2cI5b+eWsMgONr5ircDCJUOYTLRVgiAfzQe9T5+9f0z+7wnp/X5N3XdiedXdqDklXNXu6KCpY1qoKxyt5gUyvHIQw7JQw==;\n\t5:GUbMTbl8OQ0Tycdu5dfK+gtojzxGD3LIfpJPH3Rs0nWDPFdxQiLuLlfqBcTrEzzcebasCJNNsMbNJKKsREAyKWJmPQrTb9+iRwmoI9+oeGS+50Ct8zZ7cPkq9hRn5wWC7p+79Vs8tUN8dDYmEQR45g==;\n\t24:pLhhnFzZW0g4L+nWM+UbHrosFm7JGzqqhuhENkFUaBwIHfpPhAhsp5bhlrkS8nBRp0R0HhR4r8KLXRgUbRpjkM+nY5fGy9tO7quL8i3FBAQ=;\n\t7:QzYlU8Uf3cDOj7EYjkL3ZapncA4EtrcL4z7BrzvzS42Croj4KZBP3U7xnvN2FpBH/kPRArAhEPTG7nCzxjJ/v8QClxApdCgELmoTQiL/2FinZROxslD+nJwev3nIA2wJxTwHZM95UyRyvkbotO/VfcY/7RvX5/F4W2U5SqfbIY5IWWOhHO6ElyxP4VOReOMaK2a4373piEZYxBsrrz7dn0X0AWa0cbU7BtTXnLq14Pc=","x-ms-exchange-antispam-srfa-diagnostics":"SSOS;SSOR;","x-forefront-antispam-report":"SFV:SKI; SCL:-1; SFV:NSPM;\n\tSFS:(10009020)(6009001)(39860400002)(199003)(189002)(377454003)(24454002)(74316002)(68736007)(43066003)(99286003)(54906002)(3660700001)(305945005)(55016002)(3450700001)(4326008)(76176999)(7696004)(66066001)(25786009)(33656002)(3280700002)(54356999)(5660300001)(50986999)(105586002)(101416001)(106356001)(8676002)(5250100002)(6636002)(81156014)(81166006)(2900100001)(478600001)(6246003)(6862004)(53936002)(189998001)(53546010)(229853002)(6116002)(97736004)(8936002)(6436002)(9686003)(86362001)(2906002)(14454004)(102836003)(6506006)(7736002)(110136004)(3846002);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR04MB1056;\n\tH:VI1PR04MB2078.eurprd04.prod.outlook.com; FPR:; SPF:None;\n\tPTR:InfoNoRecords; A:1; MX:1; LANG:en; ","x-ms-office365-filtering-correlation-id":"334c3a06-f5b7-4262-2f5c-08d4f53cb8c1","x-ms-office365-filtering-ht":"Tenant","x-microsoft-antispam":"UriScan:; BCL:0; PCL:0;\n\tRULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(48565401081)(300000503095)(300135400095)(2017052603199)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);\n\tSRVR:VI1PR04MB1056; ","x-ms-traffictypediagnostic":"VI1PR04MB1056:","x-exchange-antispam-report-test":"UriScan:;","x-microsoft-antispam-prvs":"<VI1PR04MB1056D8C2C11531638245547F9A970@VI1PR04MB1056.eurprd04.prod.outlook.com>","x-exchange-antispam-report-cfa-test":"BCL:0; PCL:0;\n\tRULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(93006095)(93001095)(10201501046)(100000703101)(100105400095)(3002001)(6055026)(6041248)(20161123562025)(20161123558100)(20161123555025)(20161123564025)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);\n\tSRVR:VI1PR04MB1056; BCL:0; PCL:0;\n\tRULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);\n\tSRVR:VI1PR04MB1056; ","x-forefront-prvs":"0422860ED4","received-spf":"None (protection.outlook.com: nxp.com does not designate\n\tpermitted sender hosts)","spamdiagnosticoutput":"1:99","spamdiagnosticmetadata":"NSPM","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"quoted-printable","MIME-Version":"1.0","X-OriginatorOrg":"nxp.com","X-MS-Exchange-CrossTenant-originalarrivaltime":"06 Sep 2017 15:34:11.1343\n\t(UTC)","X-MS-Exchange-CrossTenant-fromentityheader":"Hosted","X-MS-Exchange-CrossTenant-id":"686ea1d3-bc2b-4c6f-a92c-d99c5c301635","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"VI1PR04MB1056","X-BeenThere":"linuxppc-dev@lists.ozlabs.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List\n\t<linuxppc-dev.lists.ozlabs.org>","List-Unsubscribe":"<https://lists.ozlabs.org/options/linuxppc-dev>,\n\t<mailto:linuxppc-dev-request@lists.ozlabs.org?subject=unsubscribe>","List-Archive":"<http://lists.ozlabs.org/pipermail/linuxppc-dev/>","List-Post":"<mailto:linuxppc-dev@lists.ozlabs.org>","List-Help":"<mailto:linuxppc-dev-request@lists.ozlabs.org?subject=help>","List-Subscribe":"<https://lists.ozlabs.org/listinfo/linuxppc-dev>,\n\t<mailto:linuxppc-dev-request@lists.ozlabs.org?subject=subscribe>","Reply-To":"York Sun <york.sun@nxp.com>","Cc":"linuxppc-dev\n linuxppc-dev <linuxppc-dev@lists.ozlabs.org>","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org","Sender":"\"Linuxppc-dev\"\n\t<linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org>"}},{"id":1764320,"web_url":"http://patchwork.ozlabs.org/comment/1764320/","msgid":"<AM4PR0401MB16991E3E16496C848E3AB9078F970@AM4PR0401MB1699.eurprd04.prod.outlook.com>","date":"2017-09-06T19:19:43","subject":"RE: [PATCH] fsl_pci: Correct fsl_pci_mcheck_exception","submitter":{"id":68093,"url":"http://patchwork.ozlabs.org/api/people/68093/","name":"Leo Li","email":"leoyang.li@nxp.com"},"content":"> -----Original Message-----\n> From: York Sun\n> Sent: Wednesday, September 06, 2017 10:34 AM\n> To: Leo Li <leoyang.li@nxp.com>\n> Cc: Joakim Tjernlund <Joakim.Tjernlund@infinera.com>; linuxppc-dev linuxppc-\n> dev <linuxppc-dev@lists.ozlabs.org>\n> Subject: Re: [PATCH] fsl_pci: Correct fsl_pci_mcheck_exception\n> \n> On 09/05/2017 04:59 AM, Joakim Tjernlund wrote:\n> > get_user() had it args reversed causing NIP to be NULL:ed instead of\n> > fixing up the PCI access.\n> >\n> > Note: This still hangs my P1020 Freescale CPU hard, but at least I get\n> > a NIP now.\n> >\n> > Signed-off-by: Joakim Tjernlund <joakim.tjernlund@infinera.com>\n> > ---\n> >   arch/powerpc/sysdev/fsl_pci.c | 2 +-\n> >   1 file changed, 1 insertion(+), 1 deletion(-)\n> >\n> > diff --git a/arch/powerpc/sysdev/fsl_pci.c\n> > b/arch/powerpc/sysdev/fsl_pci.c index 7c8b779c329a..9e64c12dff6a\n> > 100644\n> > --- a/arch/powerpc/sysdev/fsl_pci.c\n> > +++ b/arch/powerpc/sysdev/fsl_pci.c\n> > @@ -996,7 +996,7 @@ int fsl_pci_mcheck_exception(struct pt_regs *regs)\n> >   \tif (is_in_pci_mem_space(addr)) {\n> >   \t\tif (user_mode(regs)) {\n> >   \t\t\tpagefault_disable();\n> > -\t\t\tret = get_user(regs->nip, &inst);\n> > +\t\t\tret = get_user(inst, (__u32 __user *)regs->nip);\n> >   \t\t\tpagefault_enable();\n> >   \t\t} else {\n> >   \t\t\tret = probe_kernel_address(regs->nip, inst);\n> >\n> \n> Leo,\n> \n> Can you take a look, or assign it to someone who is familiar with this code?\n\nAcked-by: Li Yang <leoyang.li@nxp.com>\n\nRegards,\nLeo","headers":{"Return-Path":"<linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org>","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xnYVZ5xFjz9s4q\n\tfor <patchwork-incoming@ozlabs.org>;\n\tThu,  7 Sep 2017 05:26:46 +1000 (AEST)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3xnYVZ45VGzDrTn\n\tfor <patchwork-incoming@ozlabs.org>;\n\tThu,  7 Sep 2017 05:26:46 +1000 (AEST)","from EUR03-DB5-obe.outbound.protection.outlook.com\n\t(mail-eopbgr40066.outbound.protection.outlook.com [40.107.4.66])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3xnYLf65NjzDrT1\n\tfor <linuxppc-dev@lists.ozlabs.org>;\n\tThu,  7 Sep 2017 05:19:52 +1000 (AEST)","from AM4PR0401MB1699.eurprd04.prod.outlook.com (10.165.244.21) by\n\tAM4PR0401MB2257.eurprd04.prod.outlook.com (10.165.44.154) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id\n\t15.20.13.10; Wed, 6 Sep 2017 19:19:44 +0000","from AM4PR0401MB1699.eurprd04.prod.outlook.com\n\t([fe80::818f:8b3:fdc4:359c]) by\n\tAM4PR0401MB1699.eurprd04.prod.outlook.com\n\t([fe80::818f:8b3:fdc4:359c%14]) with mapi id 15.20.0013.018;\n\tWed, 6 Sep 2017 19:19:43 +0000"],"Authentication-Results":["ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=nxp.com header.i=@nxp.com header.b=\"jfJJ+J/D\";\n\tdkim-atps=neutral","lists.ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=nxp.com header.i=@nxp.com header.b=\"jfJJ+J/D\";\n\tdkim-atps=neutral","ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nxp.com\n\t(client-ip=40.107.4.66;\n\thelo=eur03-db5-obe.outbound.protection.outlook.com; \n\tenvelope-from=leoyang.li@nxp.com; receiver=<UNKNOWN>)","lists.ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=nxp.com header.i=@nxp.com header.b=\"jfJJ+J/D\"; \n\tdkim-atps=neutral","spf=none (sender IP is )\n\tsmtp.mailfrom=leoyang.li@nxp.com; "],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version;\n\tbh=t3qzoBySZ6Ipj3RRg0MpplJk4UsKI30nsiBFlffteYE=;\n\tb=jfJJ+J/DIO6gVywwmdtKzPDE2pOVQH3YUC2Mnx2glPXzcuGNU0cHlqQ0vnMUF2ERjSJ1HbjSY60cdGMFqr3BhC3KC2Ps0EMfWh6E7vEBW9acHmt+Dq0DcUspSnEohh3CX/fbms85792Iu7dOmPK+Z2yPwUbT7DKFAjqlCnoBvWI=","From":"Leo Li <leoyang.li@nxp.com>","To":"York Sun <york.sun@nxp.com>","Subject":"RE: [PATCH] fsl_pci: Correct fsl_pci_mcheck_exception","Thread-Topic":"[PATCH] fsl_pci: Correct fsl_pci_mcheck_exception","Thread-Index":"AQHTJj9uNZ42RRDrNkK9GpVlraiD8qKoPYzg","Date":"Wed, 6 Sep 2017 19:19:43 +0000","Message-ID":"<AM4PR0401MB16991E3E16496C848E3AB9078F970@AM4PR0401MB1699.eurprd04.prod.outlook.com>","References":"<20170905115943.19919-1-joakim.tjernlund@infinera.com>\n\t<VI1PR04MB20787FDC28E53BF15DF8E3949A970@VI1PR04MB2078.eurprd04.prod.outlook.com>","In-Reply-To":"<VI1PR04MB20787FDC28E53BF15DF8E3949A970@VI1PR04MB2078.eurprd04.prod.outlook.com>","Accept-Language":"en-US","Content-Language":"en-US","X-MS-Has-Attach":"","X-MS-TNEF-Correlator":"","authentication-results":["ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=nxp.com header.i=@nxp.com header.b=\"jfJJ+J/D\";\n\tdkim-atps=neutral","lists.ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=nxp.com header.i=@nxp.com header.b=\"jfJJ+J/D\";\n\tdkim-atps=neutral","ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nxp.com\n\t(client-ip=40.107.4.66;\n\thelo=eur03-db5-obe.outbound.protection.outlook.com; \n\tenvelope-from=leoyang.li@nxp.com; receiver=<UNKNOWN>)","lists.ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=nxp.com header.i=@nxp.com header.b=\"jfJJ+J/D\"; \n\tdkim-atps=neutral","spf=none (sender IP is )\n\tsmtp.mailfrom=leoyang.li@nxp.com; "],"x-originating-ip":"[192.88.168.1]","x-ms-publictraffictype":"Email","x-microsoft-exchange-diagnostics":"1; AM4PR0401MB2257;\n\t6:Ot32lHCKL8B8HEGi8GEikzLlNHrrM3qpGbPgpdYzTnVdTrTC+dznG+a6lermqlK2tt3EAXZAXecI2l262ZleExxzzlWY6iPnXegMRelfW5K4uP+2XYwi46yJWA2uapACl1dx11WIsnwyWDWzlg2SdiBfKUuDsbxL8sDSvySe7S73xtelDi6lvmC70aWYA5HHHzG1oSkB0ymE7/y0CyEz++gBBkHwpGHX15BxPDHRa7cgAIPkvhNmE7wtzL/1M+6QpBba0CHpUPJ0C7ofd0aJ4pFT77YMhmjo4VQW3X1CjvBZsfB3kxSpy2RQcQMhRQclxb0CaRv2mvvaGVU3sFwATw==;\n\t5:vzrz/Jb05DS/mBN8VSFamNCUew2zXcc6+eY8/ZqOOerZi/Rpefz/Uqm1UGh4d6o1gl7HbikYWiAH5jYgvFAN19+m26IrtoJ2x2vX6I0RQ2zQhQY6MOFCPTabSi8PMA0xghHDRs6XjFY/csz70y0TPA==;\n\t24:XrKBcWdVfWc4z1R1AxSn4LzY23uD1w0lTn7gu1NyFYl3OcAT4mwp/mnwSDFPiGphVvEEjdtq2Ma1pxOrAdJC6OsNH0U70l/h04iup3vCJxA=;\n\t7:ar5YwwU5Ayk+YNV184f5BlStPRu7I13Uv9tPSNn04m7hzMV9htqAj/FNj9Sw4h8geQFyxhU1XJzfFEPpKVKBTBmGe77Ypz+IlJ54T31n2shj0s3jFAoVvdAXcqlucS/bhpfRl3EI2UaZumoJAT2f/Kgnz7J4tPxqs50OrGqPmTQj4lf5MfhkNfQgn3wo9HtuWymo1FbLEf83LbJ3K1SOrXdJF2kfiinHOaT1Gmilt0g=","x-ms-exchange-antispam-srfa-diagnostics":"SSOS;SSOR;","x-forefront-antispam-report":"SFV:SKI; SCL:-1; SFV:NSPM;\n\tSFS:(10009020)(6009001)(39860400002)(377454003)(189002)(13464003)(199003)(24454002)(81156014)(81166006)(8676002)(6506006)(6436002)(229853002)(53546010)(74316002)(478600001)(8936002)(25786009)(2906002)(9686003)(54906002)(66066001)(53936002)(7696004)(99286003)(2900100001)(7736002)(5660300001)(97736004)(55016002)(5250100002)(3280700002)(50986999)(54356999)(76176999)(68736007)(101416001)(33656002)(106356001)(6636002)(2950100002)(189998001)(6246003)(4326008)(3846002)(14454004)(102836003)(6862004)(110136004)(305945005)(3660700001)(105586002)(86362001)(6116002);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:AM4PR0401MB2257;\n\tH:AM4PR0401MB1699.eurprd04.prod.outlook.com; FPR:; SPF:None;\n\tPTR:InfoNoRecords; MX:1; A:1; LANG:en; ","x-ms-office365-filtering-correlation-id":"f4943a14-50ad-41f5-5864-08d4f55c3ab3","x-ms-office365-filtering-ht":"Tenant","x-microsoft-antispam":"UriScan:; BCL:0; PCL:0;\n\tRULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(48565401081)(300000503095)(300135400095)(2017052603199)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);\n\tSRVR:AM4PR0401MB2257; ","x-ms-traffictypediagnostic":"AM4PR0401MB2257:","x-exchange-antispam-report-test":"UriScan:(65623756079841)(185117386973197);","x-microsoft-antispam-prvs":"<AM4PR0401MB22573257CAD92341C158E9CC8F970@AM4PR0401MB2257.eurprd04.prod.outlook.com>","x-exchange-antispam-report-cfa-test":"BCL:0; PCL:0;\n\tRULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(10201501046)(3002001)(100000703101)(100105400095)(93006095)(93001095)(6055026)(6041248)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123564025)(20161123555025)(20161123562025)(20161123560025)(20161123558100)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);\n\tSRVR:AM4PR0401MB2257; BCL:0; PCL:0;\n\tRULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);\n\tSRVR:AM4PR0401MB2257; ","x-forefront-prvs":"0422860ED4","received-spf":"None (protection.outlook.com: nxp.com does not designate\n\tpermitted sender hosts)","spamdiagnosticoutput":"1:99","spamdiagnosticmetadata":"NSPM","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"quoted-printable","MIME-Version":"1.0","X-OriginatorOrg":"nxp.com","X-MS-Exchange-CrossTenant-originalarrivaltime":"06 Sep 2017 19:19:43.5304\n\t(UTC)","X-MS-Exchange-CrossTenant-fromentityheader":"Hosted","X-MS-Exchange-CrossTenant-id":"686ea1d3-bc2b-4c6f-a92c-d99c5c301635","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"AM4PR0401MB2257","X-BeenThere":"linuxppc-dev@lists.ozlabs.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List\n\t<linuxppc-dev.lists.ozlabs.org>","List-Unsubscribe":"<https://lists.ozlabs.org/options/linuxppc-dev>,\n\t<mailto:linuxppc-dev-request@lists.ozlabs.org?subject=unsubscribe>","List-Archive":"<http://lists.ozlabs.org/pipermail/linuxppc-dev/>","List-Post":"<mailto:linuxppc-dev@lists.ozlabs.org>","List-Help":"<mailto:linuxppc-dev-request@lists.ozlabs.org?subject=help>","List-Subscribe":"<https://lists.ozlabs.org/listinfo/linuxppc-dev>,\n\t<mailto:linuxppc-dev-request@lists.ozlabs.org?subject=subscribe>","Cc":"linuxppc-dev\n linuxppc-dev <linuxppc-dev@lists.ozlabs.org>","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org","Sender":"\"Linuxppc-dev\"\n\t<linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org>"}},{"id":1808238,"web_url":"http://patchwork.ozlabs.org/comment/1808238/","msgid":"<1511284624.4775.138.camel@infinera.com>","date":"2017-11-21T17:17:06","subject":"Re: [PATCH] fsl_pci: Correct fsl_pci_mcheck_exception","submitter":{"id":67550,"url":"http://patchwork.ozlabs.org/api/people/67550/","name":"Joakim Tjernlund","email":"Joakim.Tjernlund@infinera.com"},"content":"On Wed, 2017-09-06 at 19:19 +0000, Leo Li wrote:\n> > -----Original Message-----\n> > From: York Sun\n> > Sent: Wednesday, September 06, 2017 10:34 AM\n> > To: Leo Li <leoyang.li@nxp.com>\n> > Cc: Joakim Tjernlund <Joakim.Tjernlund@infinera.com>; linuxppc-dev linuxppc-\n> > dev <linuxppc-dev@lists.ozlabs.org>\n> > Subject: Re: [PATCH] fsl_pci: Correct fsl_pci_mcheck_exception\n> > \n> > On 09/05/2017 04:59 AM, Joakim Tjernlund wrote:\n> > > get_user() had it args reversed causing NIP to be NULL:ed instead of\n> > > fixing up the PCI access.\n> > > \n> > > Note: This still hangs my P1020 Freescale CPU hard, but at least I get\n> > > a NIP now.\n> > > \n> > > Signed-off-by: Joakim Tjernlund <joakim.tjernlund@infinera.com>\n> > > ---\n> > >   arch/powerpc/sysdev/fsl_pci.c | 2 +-\n> > >   1 file changed, 1 insertion(+), 1 deletion(-)\n> > > \n> > > diff --git a/arch/powerpc/sysdev/fsl_pci.c\n> > > b/arch/powerpc/sysdev/fsl_pci.c index 7c8b779c329a..9e64c12dff6a\n> > > 100644\n> > > --- a/arch/powerpc/sysdev/fsl_pci.c\n> > > +++ b/arch/powerpc/sysdev/fsl_pci.c\n> > > @@ -996,7 +996,7 @@ int fsl_pci_mcheck_exception(struct pt_regs *regs)\n> > >   \tif (is_in_pci_mem_space(addr)) {\n> > >   \t\tif (user_mode(regs)) {\n> > >   \t\t\tpagefault_disable();\n> > > -\t\t\tret = get_user(regs->nip, &inst);\n> > > +\t\t\tret = get_user(inst, (__u32 __user *)regs->nip);\n> > >   \t\t\tpagefault_enable();\n> > >   \t\t} else {\n> > >   \t\t\tret = probe_kernel_address(regs->nip, inst);\n> > > \n> > \n> > Leo,\n> > \n> > Can you take a look, or assign it to someone who is familiar with this code?\n> \n> Acked-by: Li Yang <leoyang.li@nxp.com>\n> \n> Regards,\n> Leo\n\nI think this is forgotten, cannot se it in Linus tree.","headers":{"Return-Path":"<linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org>","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3yhC4X34Lbz9s8J\n\tfor <patchwork-incoming@ozlabs.org>;\n\tWed, 22 Nov 2017 04:19:24 +1100 (AEDT)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3yhC4X1LJ0zDrZw\n\tfor <patchwork-incoming@ozlabs.org>;\n\tWed, 22 Nov 2017 04:19:24 +1100 (AEDT)","from NAM03-DM3-obe.outbound.protection.outlook.com\n\t(mail-dm3nam03on0070.outbound.protection.outlook.com [104.47.41.70])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3yhC240R8XzDrZ4\n\tfor <linuxppc-dev@lists.ozlabs.org>;\n\tWed, 22 Nov 2017 04:17:14 +1100 (AEDT)","from MWHPR10CA0072.namprd10.prod.outlook.com (10.169.238.34) by\n\tSN1PR10MB1008.namprd10.prod.outlook.com (10.164.24.154) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id\n\t15.20.239.5; Tue, 21 Nov 2017 17:17:08 +0000","from DM3NAM03FT016.eop-NAM03.prod.protection.outlook.com\n\t(2a01:111:f400:7e49::201) by MWHPR10CA0072.outlook.office365.com\n\t(2603:10b6:300:2c::34) with Microsoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.239.5 via\n\tFrontend Transport; Tue, 21 Nov 2017 17:17:08 +0000","from owa.infinera.com (204.128.141.23) by\n\tDM3NAM03FT016.mail.protection.outlook.com (10.152.82.198) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id\n\t15.20.239.4 via Frontend Transport; Tue, 21 Nov 2017 17:17:07 +0000","from SV-EX13-PRD2.infinera.com (10.100.103.229) by\n\tsv-ex13-prd1.infinera.com (10.100.103.228) with Microsoft SMTP Server\n\t(TLS) id 15.0.1178.4; Tue, 21 Nov 2017 09:17:06 -0800","from SV-EX13-PRD2.infinera.com ([10.100.101.111]) by\n\tsv-ex13-prd2.infinera.com ([10.100.101.111]) with mapi id\n\t15.00.1178.000; Tue, 21 Nov 2017 09:17:06 -0800"],"Authentication-Results":["ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=infinera.onmicrosoft.com\n\theader.i=@infinera.onmicrosoft.com header.b=\"DKH0Nmse\"; \n\tdkim-atps=neutral","lists.ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=infinera.onmicrosoft.com\n\theader.i=@infinera.onmicrosoft.com header.b=\"DKH0Nmse\"; \n\tdkim-atps=neutral","ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=infinera.com\n\t(client-ip=104.47.41.70;\n\thelo=nam03-dm3-obe.outbound.protection.outlook.com; \n\tenvelope-from=joakim.tjernlund@infinera.com; receiver=<UNKNOWN>)","lists.ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=infinera.onmicrosoft.com\n\theader.i=@infinera.onmicrosoft.com header.b=\"DKH0Nmse\"; \n\tdkim-atps=neutral","spf=pass (sender IP is 204.128.141.23)\n\tsmtp.mailfrom=infinera.com; nxp.com; dkim=none (message not signed)\n\theader.d=none;nxp.com; dmarc=bestguesspass action=none\n\theader.from=infinera.com;"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=infinera.onmicrosoft.com; s=selector1-infinera-com;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version;\n\tbh=AuysoUeAT0ZEKtmOs6z9yxoimeftv+7AreNTepG08MA=;\n\tb=DKH0NmseQn6rlv7db/W2Vd5TIgsplbjWe8iyCD1g8+tDW9L/DfFEhQLnD6TNakqAIBBl0let4l+pH+KNFQWSD4L81AhnG/brfh/Zz+d/qzK3XiH1f72XJArSongkXYQ5lXvcKrTXyrv2Ce0xlZc2EXU3ilZL8iBsP+zxqupsALY=","Received-SPF":"Pass (protection.outlook.com: domain of infinera.com designates\n\t204.128.141.23 as permitted sender)\n\treceiver=protection.outlook.com; \n\tclient-ip=204.128.141.23; helo=owa.infinera.com;","From":"Joakim Tjernlund <Joakim.Tjernlund@infinera.com>","To":"\"leoyang.li@nxp.com\" <leoyang.li@nxp.com>, \"york.sun@nxp.com\"\n\t<york.sun@nxp.com>","Subject":"Re: [PATCH] fsl_pci: Correct fsl_pci_mcheck_exception","Thread-Topic":"[PATCH] fsl_pci: Correct fsl_pci_mcheck_exception","Thread-Index":"AQHTJj54y2Nt/xcYb0KqLeyLRyyQeaKoswuAgHdfrgA=","Date":"Tue, 21 Nov 2017 17:17:06 +0000","Message-ID":"<1511284624.4775.138.camel@infinera.com>","References":"<20170905115943.19919-1-joakim.tjernlund@infinera.com>\n\t<VI1PR04MB20787FDC28E53BF15DF8E3949A970@VI1PR04MB2078.eurprd04.prod.outlook.com>\n\t<AM4PR0401MB16991E3E16496C848E3AB9078F970@AM4PR0401MB1699.eurprd04.prod.outlook.com>","In-Reply-To":"<AM4PR0401MB16991E3E16496C848E3AB9078F970@AM4PR0401MB1699.eurprd04.prod.outlook.com>","Accept-Language":"en-GB, en-US","Content-Language":"en-US","X-MS-Has-Attach":"","X-MS-TNEF-Correlator":"","x-ms-exchange-messagesentrepresentingtype":"1","x-ms-exchange-transport-fromentityheader":"Hosted","x-originating-ip":"[10.100.99.93]","Content-Type":"text/plain; charset=\"iso-8859-15\"","Content-ID":"<F5321C75EF41F94D8E17229C697C491F@infinera.com>","Content-Transfer-Encoding":"quoted-printable","MIME-Version":"1.0","X-EOPAttributedMessage":"0","X-Forefront-Antispam-Report":"CIP:204.128.141.23; IPV:NLI; CTRY:US; EFV:NLI; \n\tSFV:NSPM;\n\tSFS:(10009020)(6009001)(346002)(376002)(2980300002)(438002)(24454002)(377424004)(13464003)(189002)(199003)(229853002)(8936002)(189998001)(2501003)(316002)(50466002)(110136005)(478600001)(8656006)(14454004)(23756003)(86362001)(77096006)(53546010)(36756003)(72206003)(47776003)(246002)(53416004)(7736002)(76176999)(8676002)(54356999)(50986999)(356003)(305945005)(106466001)(7636002)(106002)(5660300001)(8746002)(2900100001)(2906002)(33646002)(3846002)(102836003)(6246003)(103116003)(2950100002)(6116002)(4326008);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:SN1PR10MB1008; H:owa.infinera.com; FPR:;\n\tSPF:Pass; PTR:outgoingmail1.infinera.com; MX:1; A:1; LANG:en; ","X-Microsoft-Exchange-Diagnostics":["1; DM3NAM03FT016;\n\t1:7fzvk82t+lFPlA4UfmaVAIy+Hu28+RUx9uPWcKesZCkNvrFm0d/11VA2L7q2zCVAL3AP1bLC5Sh5LyVQQcy1KNzcX6UXdK6vhzAcxfPEUUTHH237KK+23BcQq66BLhm4","1; SN1PR10MB1008;\n\t3:+IVMkEl4o6QZtMsyrITV4kaYAOaOBj2JlrfkufZ1ZS3djH87N1sQRV54pcNkk/O/WGj7OzvRIcAyjSkCxdty4Hf00hUx9O4ngZAIJd2b3zgNEOBnX+BKTU33iGjyyLiEyzI3YBtyjS+kenyopOHrSa5cS/cI/ge9fi74azfdFiXa69HOmqf3LlwScnjNZGbKYRoUTNanpqMVljk/q93A2tXSnjaaZpbTwY/1hwf77p3eyWD+ri/ScZrHVFh2uztAY/ehR56D/DHUVn1nw67MO/gOmU52dU5FhxoACidfs5fmYYHRLjAc/eCrq8Wdyigu2x+goxxfrA/67G25yDks+T0ARAstRIEmP+/4MzCgY18=;\n\t25:OV/FbKB1ALa/lJBwpiWb0pTkWEcuBO+vlu1wdPyi4JG18qIoWEJ1fML0ZD931Oav3+a4XzNrjK0v866osFpkVahA14BTZNdc8FIcpu5UDkFMrlaSWcn6/T6dJi2tUtm4nCD26W7lLgivAt56Pbayc59pu/pZJ0OvBZVktwL2vtTOsFle1jpvhRUu6L7SFKr+zRjRo8i8R0trJcHlLzgLMnTBobadmkttGv1icWM4cBXUmFqZI50PO73U8+XslkP4w2NERwmufzZGgzpw7xPVY/MtkQ+BSJwepN7tYss/e/N0WTYGZRm55kpH8orFaAzseXlS6wAEOBAXy0j1tQGjBQ==","1; SN1PR10MB1008;\n\t31:nvfaWOhExP5Qv7WNdUdiKvUx3Ij6nOZeAVks1uvyuZDUpoDgpk7kZDJslOO7XZuMIcruZPSc4QpqjCLSbdaWE3T/0y2ypIxNdG/9/cAPtsBgAFyEj+IBsvnVe9yjmAvpO2a2LDB81pv9JOQZoYYlCz6l6qdb/iLGsYh9p9maG2ptbpFgxkIW6SxTbdpbOgkbZ79qnYLVxuye8M/82mWhctCeAFassZQYK5N98X+LMd4=;\n\t20:8UgNPQyFrjoyOPsqUQna4dzpf1+DhTZlzFFAopFe3UygjUjufgQsNqRSueewJxdV/gktAUGpSJjIGecunandgSqBzrYFjkasoj7RjcO4mlVGFoCa/g0HKeEfsbXjev/7jo3vG/Wy6QCYS+/l3xvmLCAzyzR5Pho8JiEfNJgt+4U7JvujQEVApB9fvoTPjDUkFUYwWkpg9uO9PNvcVne4QWl52NJueMQEsLWnacsQnkI4koMkVmBetubrd7ifuZGus9x8N6QoVFQXvoYZniDexjHprV1kqV/sIzpNynn9/yma2kJN68TMBaxwHf6eekaZTDPDA8svFxodVpil0Dq/tKcEp73l1zTxzdohVRXbEkg5fgXdMZ9+bocIcY5yRCTg4mfg+Gv6PkrxxlcDo9IWXwiHVPt/8a+P13iNp6KCp0c=","1; SN1PR10MB1008;\n\t4:eE3wn9e2TcXh1xSVSm+ljB1X+Tt4rEVbLt8n2+vf+wIKHDha1m6Fdq+y6gcj3xhcxZDcw7O2zBPRC1eQhgEUbgMU0drGtUi94LJjMrVzbPdNLu2MT8Vo7EDeZnwwSPqv7S5LNMBKvrAQ+IA0Lc1HhIIF51CD+fg0QMS40TzpUZ/gkCDBoGn9tG/u8JLZ8lTZ/P2IR2/C4q5/CIJmsGar8T/HfrO1A2DvINd9ldi9v0JAdW9Pw4wCQ7ByZ/q/Z7VG8ZsX3eQLGgNyKAmU3uNLaRw/jwX5nEcNV5EPgEqoqW6MU6JOInMeYhO3gxyozqS5ckUQdhigPGMV15ND8PyL3h+bExFWmyd3PX/mw5o6OAs=","=?iso-8859-15?Q?1; SN1PR10MB1008;\n\t23:nfZLvXmF8j2LRcOjW7eDXD0yfkeHwcR/RasHMv?=\n\t=?iso-8859-15?q?NOiETP6jhvTAusNInGhG5CNb?=\n\t=?iso-8859-15?q?lChcSgYVTQ/xuM02dmHIZgXjksFxY0/VNPq2vAN7PUoS6aEnsV?=\n\t=?iso-8859-15?q?n1NI6zlL98WVqTzrD2lQa8EzOHsu5ARMmcLiWSwFJ/O9TnRef1?=\n\t=?iso-8859-15?q?WvMIo7/yIyGqP4VAtYnIaGopxXl7te+BbAJABhB98iQ16I89AY?=\n\t=?iso-8859-15?q?eErFPZyBnHsk8W8ehackOk89COaFFzhrUHkT5rsUMULtNrCvkj?=\n\t=?iso-8859-15?q?7nzb5pwH6OCAKDmBlIx7HhNSJDK2VkS8vCOe/qIhYBYMgIgu/Z?=\n\t=?iso-8859-15?q?ezmdwKl/w8aovqo7jSnzYvx0wnCYBkthQ6vg/3UxnXInhq1sXo?=\n\t=?iso-8859-15?q?gt5ENgLN9R2WcLtm085RXywdX9NcxPxnkwPqoTz3XzIzGvBQDJ?=\n\t=?iso-8859-15?q?dTzuXRceuhpf5wA0Xzm6O1xTls5o2D22yeWhupuAZYkezAdebd?=\n\t=?iso-8859-15?q?bY/p5/CAZHT7fc1BYf4L8rTDkds9jEdZ9btjsBkfZv/lwJV321?=\n\t=?iso-8859-15?q?NIonPdjEf3hFB1GdbLoNVMdjHIqMMyx9qf1BqyH7DGThvmZXP9?=\n\t=?iso-8859-15?q?/wlM4nrhLT7qQVVxyDlcbJM9tx9dNQVZyRpJWsBlZJW5L3GYKu?=\n\t=?iso-8859-15?q?wJcx3iDayrDfG/4+6UrvzYaGzbF0k4fwbix6cnns/dG5b+Fq57?=\n\t=?iso-8859-15?q?mWkq6J5c3Trft8o4k6Jf+MA3ngkXLQv4WFWowIqAbaGjXhNlaV?=\n\t=?iso-8859-15?q?uJtTqpwKY8L0slTaP3pNg7tnLTVWPL6J6QC+P4M6XX6QmSiEww?=\n\t=?iso-8859-15?q?MGd31tXgZeOMUxghQANqxPksEw7mCSC9K1N6Q++ccNJKgFB9yN?=\n\t=?iso-8859-15?q?s4P6YJUf2qLtUsoxfDXDau77D/wWDou5XJXCq1RvsFRKgsc1m8?=\n\t=?iso-8859-15?q?8ggkHla7Jt1rEdR6MSMpsN6rIqQ+sOP0xUlq5IQk0oSZAP/Hjl?=\n\t=?iso-8859-15?q?oGTOOPt+I/qC+wIxleKe9HWCRitQQBSK7e+zbTOteElp8t9AZD?=\n\t=?iso-8859-15?q?zl16UVhHdQX4sQHrnd5ODfIytuHFIa6GAV+1zUj4R7T0PpnVGn?=\n\t=?iso-8859-15?q?4IrafjNoALuNinVz+eHsPRELoTuKyRWBaThv07JUW2pth3dA2u?=\n\t=?iso-8859-15?q?SYYgkLtsyoCaiwAPLXP1YAOmX/KCev+wBFwkPC1iFL92jkyqsR?=\n\t=?iso-8859-15?q?8ZicXhubBMlED6sabEXdhR6F+XCOuZG3anrsmlSyrh5tDuDi9f?=\n\t=?iso-8859-15?q?LE8vGjPTweTw=3D=3D?=","1; SN1PR10MB1008;\n\t6:qYh0McBsuEYIBEfTuAddUMdl/1fkMoMiBYqVTNJmbk2Bb5QPO6hZ/9FqPyAioMm/ubOAxLGeVCT10/MmVAORzefnv97Au6u8dpGwxRzFhAUQ/kH+j61rKHwahnwteMapNeH/LZ4stQ3fmriZ2Tphqefv2zcVGgAK9LbprxTT1U4acNsXSknDvB3rnrpbT1DBR2vvFK+2j4dCqLEjukMbXPQ/13V460aM7gBybyUAhDkdo3O48r2squBpq0BHcmmnFpQFmBMfzJ9WcK2IJQ5ORDpG48Xwy2h1MF1lgVnf24DbFuhG6Wz+FmQw3kyFAuxWnL6F4riu12DpDPp92Pv90ZMA3KknvVKUFnPp1IzeOF8=;\n\t5:kTLF3nGNUsDU9y3SrI3X5lubJ9zDOrk7UYU9bdC7D9dv3E6HEFcmFsABtVXBssx1/nRApJcfmDPArnh1d9Hdr6EHf/8MxL5Flqph1JLUCxbTINSXW+0BHe0kuC+nDzOgvP5Kw/yaGgB5eIkw7Y78LYYimCovd0zVIfOw1twAKSA=;\n\t24:GcqrTw4wJLCHaxLLjb8KvrLZ4M+iYnVoM2c1d4NqBoWu27p9VJQ36rylIRFcpyBCu4iUQQ4D5J5URD4NvKQyvIV/BKKx852q/PxmRdo0mRI=;\n\t7:JuoeSXPh/5HRYJ1/dcZcEU19PJeH8f7NWvQG9DzSLOHvV44anSYz/GSJoBcKCrKbRMAWZfbLVm9M5oebFv3EvnbA0h/Mqs+A/bO3hwTuHmvvboca7xYLZCWc+LVrSh64CPTKVxLXZrTVBJPagJkbdW5F16ZAbj+c0mvxRmF+AD2gjiCrHulpdTVmUlA+jdS32UtrSYGiL+wg/PCdT7/ESxGG9dQbrf2kKElNfJ6vVQQ3vIU+j4Ej60MnNl0lKn1z"],"X-MS-PublicTrafficType":"Email","X-MS-Office365-Filtering-Correlation-Id":"be6c0f83-d54a-4ab7-8ea4-08d53103b1b9","X-Microsoft-Antispam":"UriScan:; BCL:0; PCL:0;\n\tRULEID:(22001)(8251501002)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(2017052603258);\n\tSRVR:SN1PR10MB1008; ","X-MS-TrafficTypeDiagnostic":"SN1PR10MB1008:","X-Microsoft-Antispam-PRVS":"<SN1PR10MB1008FE6CB6006DF7E98C7DB4F4230@SN1PR10MB1008.namprd10.prod.outlook.com>","X-Exchange-Antispam-Report-Test":"UriScan:(65623756079841)(185117386973197);","X-Exchange-Antispam-Report-CFA-Test":"BCL:0; PCL:0;\n\tRULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(93006095)(93004095)(100000703101)(100105400095)(3231022)(10201501046)(3002001)(6041248)(20161123558100)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123562025)(20161123555025)(20161123564025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);\n\tSRVR:SN1PR10MB1008; BCL:0; PCL:0;\n\tRULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);\n\tSRVR:SN1PR10MB1008; ","X-Forefront-PRVS":"049897979A","SpamDiagnosticOutput":"1:99","SpamDiagnosticMetadata":"NSPM","X-OriginatorOrg":"infinera.com","X-MS-Exchange-CrossTenant-OriginalArrivalTime":"21 Nov 2017 17:17:07.7308\n\t(UTC)","X-MS-Exchange-CrossTenant-Network-Message-Id":"be6c0f83-d54a-4ab7-8ea4-08d53103b1b9","X-MS-Exchange-CrossTenant-Id":"285643de-5f5b-4b03-a153-0ae2dc8aaf77","X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp":"TenantId=285643de-5f5b-4b03-a153-0ae2dc8aaf77;\n\tIp=[204.128.141.23]; \n\tHelo=[owa.infinera.com]","X-MS-Exchange-CrossTenant-FromEntityHeader":"HybridOnPrem","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"SN1PR10MB1008","X-BeenThere":"linuxppc-dev@lists.ozlabs.org","X-Mailman-Version":"2.1.24","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List\n\t<linuxppc-dev.lists.ozlabs.org>","List-Unsubscribe":"<https://lists.ozlabs.org/options/linuxppc-dev>,\n\t<mailto:linuxppc-dev-request@lists.ozlabs.org?subject=unsubscribe>","List-Archive":"<http://lists.ozlabs.org/pipermail/linuxppc-dev/>","List-Post":"<mailto:linuxppc-dev@lists.ozlabs.org>","List-Help":"<mailto:linuxppc-dev-request@lists.ozlabs.org?subject=help>","List-Subscribe":"<https://lists.ozlabs.org/listinfo/linuxppc-dev>,\n\t<mailto:linuxppc-dev-request@lists.ozlabs.org?subject=subscribe>","Cc":"\"linuxppc-dev@lists.ozlabs.org\" <linuxppc-dev@lists.ozlabs.org>","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org","Sender":"\"Linuxppc-dev\"\n\t<linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org>"}},{"id":1816138,"web_url":"http://patchwork.ozlabs.org/comment/1816138/","msgid":"<AM4PR0401MB1699F76EB10DD25705C4A8B98F3D0@AM4PR0401MB1699.eurprd04.prod.outlook.com>","date":"2017-12-05T15:16:28","subject":"RE: [PATCH] fsl_pci: Correct fsl_pci_mcheck_exception","submitter":{"id":68093,"url":"http://patchwork.ozlabs.org/api/people/68093/","name":"Leo Li","email":"leoyang.li@nxp.com"},"content":"> -----Original Message-----\n> From: Joakim Tjernlund [mailto:Joakim.Tjernlund@infinera.com]\n> Sent: Tuesday, November 21, 2017 11:17 AM\n> To: Leo Li <leoyang.li@nxp.com>; York Sun <york.sun@nxp.com>\n> Cc: linuxppc-dev@lists.ozlabs.org\n> Subject: Re: [PATCH] fsl_pci: Correct fsl_pci_mcheck_exception\n> \n> On Wed, 2017-09-06 at 19:19 +0000, Leo Li wrote:\n> > > -----Original Message-----\n> > > From: York Sun\n> > > Sent: Wednesday, September 06, 2017 10:34 AM\n> > > To: Leo Li <leoyang.li@nxp.com>\n> > > Cc: Joakim Tjernlund <Joakim.Tjernlund@infinera.com>; linuxppc-dev\n> > > linuxppc- dev <linuxppc-dev@lists.ozlabs.org>\n> > > Subject: Re: [PATCH] fsl_pci: Correct fsl_pci_mcheck_exception\n> > >\n> > > On 09/05/2017 04:59 AM, Joakim Tjernlund wrote:\n> > > > get_user() had it args reversed causing NIP to be NULL:ed instead\n> > > > of fixing up the PCI access.\n> > > >\n> > > > Note: This still hangs my P1020 Freescale CPU hard, but at least I\n> > > > get a NIP now.\n> > > >\n> > > > Signed-off-by: Joakim Tjernlund <joakim.tjernlund@infinera.com>\n> > > > ---\n> > > >   arch/powerpc/sysdev/fsl_pci.c | 2 +-\n> > > >   1 file changed, 1 insertion(+), 1 deletion(-)\n> > > >\n> > > > diff --git a/arch/powerpc/sysdev/fsl_pci.c\n> > > > b/arch/powerpc/sysdev/fsl_pci.c index 7c8b779c329a..9e64c12dff6a\n> > > > 100644\n> > > > --- a/arch/powerpc/sysdev/fsl_pci.c\n> > > > +++ b/arch/powerpc/sysdev/fsl_pci.c\n> > > > @@ -996,7 +996,7 @@ int fsl_pci_mcheck_exception(struct pt_regs\n> *regs)\n> > > >   \tif (is_in_pci_mem_space(addr)) {\n> > > >   \t\tif (user_mode(regs)) {\n> > > >   \t\t\tpagefault_disable();\n> > > > -\t\t\tret = get_user(regs->nip, &inst);\n> > > > +\t\t\tret = get_user(inst, (__u32 __user *)regs->nip);\n> > > >   \t\t\tpagefault_enable();\n> > > >   \t\t} else {\n> > > >   \t\t\tret = probe_kernel_address(regs->nip, inst);\n> > > >\n> > >\n> > > Leo,\n> > >\n> > > Can you take a look, or assign it to someone who is familiar with this\n> code?\n> >\n> > Acked-by: Li Yang <leoyang.li@nxp.com>\n> >\n> > Regards,\n> > Leo\n> \n> I think this is forgotten, cannot se it in Linus tree.\n\nHi Scott,\n\nCould you help to review this patch and pick it up?  Thanks.\n\nRegards,\nLeo","headers":{"Return-Path":"<linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org>","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3yrlqy43g5z9rxl\n\tfor <patchwork-incoming@ozlabs.org>;\n\tWed,  6 Dec 2017 02:23:10 +1100 (AEDT)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3yrlqy2QPwzDrbY\n\tfor <patchwork-incoming@ozlabs.org>;\n\tWed,  6 Dec 2017 02:23:10 +1100 (AEDT)","from EUR02-AM5-obe.outbound.protection.outlook.com\n\t(mail-eopbgr00041.outbound.protection.outlook.com [40.107.0.41])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3yrlhQ2FvnzDrJY\n\tfor <linuxppc-dev@lists.ozlabs.org>;\n\tWed,  6 Dec 2017 02:16:35 +1100 (AEDT)","from AM4PR0401MB1699.eurprd04.prod.outlook.com (10.165.244.21) by\n\tVI1PR04MB2079.eurprd04.prod.outlook.com (10.166.43.19) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id\n\t15.20.282.5; Tue, 5 Dec 2017 15:16:29 +0000","from AM4PR0401MB1699.eurprd04.prod.outlook.com\n\t([fe80::2c0c:c456:ebad:7ab1]) by\n\tAM4PR0401MB1699.eurprd04.prod.outlook.com\n\t([fe80::2c0c:c456:ebad:7ab1%13]) with mapi id 15.20.0282.010;\n\tTue, 5 Dec 2017 15:16:28 +0000"],"Authentication-Results":["ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=nxp.com header.i=@nxp.com header.b=\"n4V2DWzp\";\n\tdkim-atps=neutral","lists.ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=nxp.com header.i=@nxp.com header.b=\"n4V2DWzp\";\n\tdkim-atps=neutral","ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nxp.com\n\t(client-ip=40.107.0.41;\n\thelo=eur02-am5-obe.outbound.protection.outlook.com; \n\tenvelope-from=leoyang.li@nxp.com; receiver=<UNKNOWN>)","lists.ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=nxp.com header.i=@nxp.com header.b=\"n4V2DWzp\"; \n\tdkim-atps=neutral","spf=none (sender IP is )\n\tsmtp.mailfrom=leoyang.li@nxp.com; "],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version;\n\tbh=CTKrUFQTFX8bdbJv8EyhCqoYPczh2D/lPYOpBdG3Cqo=;\n\tb=n4V2DWzpKD3fIcI6H4aFS3VHHRtbSVLgwNpBd8St3jlDhJv8HWMi6dTFZoxMMdagACa7Y0YX3raVaD0Z/8Uj7nPAqaAQBUBs5BV61tsldh2hYYaffq3u8dHZrLNsyAMVuI0w9WdG/nX0PPW2VZjaf5mGC15fvpQKMQFNBqHn6dA=","From":"Leo Li <leoyang.li@nxp.com>","To":"\"oss@buserror.net\" <oss@buserror.net>, Joakim Tjernlund\n\t<Joakim.Tjernlund@infinera.com>, York Sun <york.sun@nxp.com>","Subject":"RE: [PATCH] fsl_pci: Correct fsl_pci_mcheck_exception","Thread-Topic":"[PATCH] fsl_pci: Correct fsl_pci_mcheck_exception","Thread-Index":"AQHTJj9uNZ42RRDrNkK9GpVlraiD8qKoPYzggHdPEQCAFd6G0A==","Date":"Tue, 5 Dec 2017 15:16:28 +0000","Message-ID":"<AM4PR0401MB1699F76EB10DD25705C4A8B98F3D0@AM4PR0401MB1699.eurprd04.prod.outlook.com>","References":"<20170905115943.19919-1-joakim.tjernlund@infinera.com>\n\t<VI1PR04MB20787FDC28E53BF15DF8E3949A970@VI1PR04MB2078.eurprd04.prod.outlook.com>\n\t<AM4PR0401MB16991E3E16496C848E3AB9078F970@AM4PR0401MB1699.eurprd04.prod.outlook.com>\n\t<1511284624.4775.138.camel@infinera.com>","In-Reply-To":"<1511284624.4775.138.camel@infinera.com>","Accept-Language":"en-US","Content-Language":"en-US","X-MS-Has-Attach":"","X-MS-TNEF-Correlator":"","authentication-results":["ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=nxp.com header.i=@nxp.com header.b=\"n4V2DWzp\";\n\tdkim-atps=neutral","lists.ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=nxp.com header.i=@nxp.com header.b=\"n4V2DWzp\";\n\tdkim-atps=neutral","ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nxp.com\n\t(client-ip=40.107.0.41;\n\thelo=eur02-am5-obe.outbound.protection.outlook.com; \n\tenvelope-from=leoyang.li@nxp.com; receiver=<UNKNOWN>)","lists.ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=nxp.com header.i=@nxp.com header.b=\"n4V2DWzp\"; \n\tdkim-atps=neutral","spf=none (sender IP is )\n\tsmtp.mailfrom=leoyang.li@nxp.com; "],"x-originating-ip":"[192.88.168.1]","x-ms-publictraffictype":"Email","x-microsoft-exchange-diagnostics":"1; VI1PR04MB2079;\n\t6:do02VMy4y8+S5PhcJZ+vy7D6zYSCSF7V9W44fkcOmMBSvt9ssUsCgwt0+ZpemG5SyzyaPBmplqFqUdVvIxexkJbu318v5SfkX1frIYvXuozd8vdm3Ls3W5hoKOJmG6xXlwleM8aTjHju/ZOoGEGY56IntpYTH27QZ/Xby7qhXwboa4CLXE8XA4D/qygCmL/dBkH5s7/iNnjjyhNszI4cX27VY/XfO+6w+/DSGJa/5Fodrojv1z5MAcrRtXey5LbnPm9vije+KcCVdM98LS+G+ZJWF7ZaO6FKFR3r18nVDW7AblHqFJO46UH3/QwOH7ycxzNHbdmsR9w6CVtINxl2/VjciUx3EY/SqZb5LMnkA08=;\n\t5:VW3JGVtoNd/NIA93b7u9IkosOfJ6w2wwZLzr2l/1EAeMxUaL4eotkfTCjoyjIBEOQw2++t/KqzFQ32PrubSPswTr0x5ac6pDl0+jWnFJ9XCps/bbCWt1fyY1BGCBib/meN8MzA2bLYERRA649+O9txgQRyxfkPcWSmBOFGvpEbI=;\n\t24:6aMIoupxHcSeYzJ0KZ/IC5FLw1pbRONP38nc4QndeDsrvbcK7ahAMZJWi9cHaOHo7P9i4sD4BIs7G5sZl8/1QhVupjV9jYPqEJ/pJ5Jihb8=;\n\t7:roGqKwE1Cx/8c7QZ5rVRyFRqFjIB7U57AA/GBUy+p8xYngLXjBNxWbNH88dbz2znnRAW/2ccgjxx/LvwU/NCjJOKmOlUzuL9KTYTjXc0BePDy8mTU32OEQhEmkng3wzGxcpeZJ3UydXVUtW7jQG40GBw91P/l92mowkTjLyP9ojDInDSKmPBIQuw5J8ePnrOjaFKvI/2ovDVBQbbeqjDeH0Rwsvf1f4j08WJ/RxYEFfgGdUHKXxrrCAFwkQRtlrA","x-ms-exchange-antispam-srfa-diagnostics":"SSOS;SSOR;","x-forefront-antispam-report":"SFV:SKI; SCL:-1; SFV:NSPM;\n\tSFS:(10009020)(6009001)(366004)(39860400002)(376002)(346002)(377424004)(24454002)(189002)(199003)(13464003)(86362001)(110136005)(97736004)(478600001)(99286004)(14454004)(7696005)(2906002)(189998001)(54356011)(2900100001)(76176011)(6246003)(53546010)(316002)(93886005)(3660700001)(6116002)(6506006)(2501003)(25786009)(101416001)(74316002)(53936002)(33656002)(6636002)(81156014)(2950100002)(3280700002)(55016002)(7736002)(66066001)(8936002)(8676002)(229853002)(6436002)(5660300001)(106356001)(9686003)(105586002)(81166006)(3846002)(102836003)(68736007)(5250100002)(4326008)(305945005);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR04MB2079;\n\tH:AM4PR0401MB1699.eurprd04.prod.outlook.com; FPR:; SPF:None;\n\tPTR:InfoNoRecords; MX:1; A:1; LANG:en; ","x-ms-office365-filtering-ht":"Tenant","x-ms-office365-filtering-correlation-id":"845b6fd6-cedf-42f6-f9e1-08d53bf32862","x-microsoft-antispam":"UriScan:; BCL:0; PCL:0;\n\tRULEID:(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(48565401081)(5600026)(4604075)(2017052603286);\n\tSRVR:VI1PR04MB2079; ","x-ms-traffictypediagnostic":"VI1PR04MB2079:","x-microsoft-antispam-prvs":"<VI1PR04MB207918E85B0FD437D58EE5488F3D0@VI1PR04MB2079.eurprd04.prod.outlook.com>","x-exchange-antispam-report-test":"UriScan:(65623756079841)(185117386973197);","x-exchange-antispam-report-cfa-test":"BCL:0; PCL:0;\n\tRULEID:(6040450)(2401047)(5005006)(8121501046)(93006095)(93001095)(3002001)(3231022)(10201501046)(6055026)(6041248)(20161123558100)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123564025)(20161123555025)(20161123560025)(20161123562025)(6072148)(201708071742011);\n\tSRVR:VI1PR04MB2079; BCL:0; PCL:0; RULEID:(100000803101)(100110400095);\n\tSRVR:VI1PR04MB2079; ","x-forefront-prvs":"0512CC5201","received-spf":"None (protection.outlook.com: nxp.com does not designate\n\tpermitted sender hosts)","spamdiagnosticoutput":"1:99","spamdiagnosticmetadata":"NSPM","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"quoted-printable","MIME-Version":"1.0","X-OriginatorOrg":"nxp.com","X-MS-Exchange-CrossTenant-Network-Message-Id":"845b6fd6-cedf-42f6-f9e1-08d53bf32862","X-MS-Exchange-CrossTenant-originalarrivaltime":"05 Dec 2017 15:16:28.2522\n\t(UTC)","X-MS-Exchange-CrossTenant-fromentityheader":"Hosted","X-MS-Exchange-CrossTenant-id":"686ea1d3-bc2b-4c6f-a92c-d99c5c301635","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"VI1PR04MB2079","X-BeenThere":"linuxppc-dev@lists.ozlabs.org","X-Mailman-Version":"2.1.24","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List\n\t<linuxppc-dev.lists.ozlabs.org>","List-Unsubscribe":"<https://lists.ozlabs.org/options/linuxppc-dev>,\n\t<mailto:linuxppc-dev-request@lists.ozlabs.org?subject=unsubscribe>","List-Archive":"<http://lists.ozlabs.org/pipermail/linuxppc-dev/>","List-Post":"<mailto:linuxppc-dev@lists.ozlabs.org>","List-Help":"<mailto:linuxppc-dev-request@lists.ozlabs.org?subject=help>","List-Subscribe":"<https://lists.ozlabs.org/listinfo/linuxppc-dev>,\n\t<mailto:linuxppc-dev-request@lists.ozlabs.org?subject=subscribe>","Cc":"\"linuxppc-dev@lists.ozlabs.org\" <linuxppc-dev@lists.ozlabs.org>","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org","Sender":"\"Linuxppc-dev\"\n\t<linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org>"}},{"id":1816440,"web_url":"http://patchwork.ozlabs.org/comment/1816440/","msgid":"<1512504621.10062.10.camel@buserror.net>","date":"2017-12-05T20:10:21","subject":"Re: [PATCH] fsl_pci: Correct fsl_pci_mcheck_exception","submitter":{"id":67983,"url":"http://patchwork.ozlabs.org/api/people/67983/","name":"Crystal Wood","email":"oss@buserror.net"},"content":"On Tue, 2017-12-05 at 15:16 +0000, Leo Li wrote:\n> > -----Original Message-----\n> > From: Joakim Tjernlund [mailto:Joakim.Tjernlund@infinera.com]\n> > Sent: Tuesday, November 21, 2017 11:17 AM\n> > To: Leo Li <leoyang.li@nxp.com>; York Sun <york.sun@nxp.com>\n> > Cc: linuxppc-dev@lists.ozlabs.org\n> > Subject: Re: [PATCH] fsl_pci: Correct fsl_pci_mcheck_exception\n> > \n> > On Wed, 2017-09-06 at 19:19 +0000, Leo Li wrote:\n> > > > -----Original Message-----\n> > > > From: York Sun\n> > > > Sent: Wednesday, September 06, 2017 10:34 AM\n> > > > To: Leo Li <leoyang.li@nxp.com>\n> > > > Cc: Joakim Tjernlund <Joakim.Tjernlund@infinera.com>; linuxppc-dev\n> > > > linuxppc- dev <linuxppc-dev@lists.ozlabs.org>\n> > > > Subject: Re: [PATCH] fsl_pci: Correct fsl_pci_mcheck_exception\n> > > > \n> > > > On 09/05/2017 04:59 AM, Joakim Tjernlund wrote:\n> > > > > get_user() had it args reversed causing NIP to be NULL:ed instead\n> > > > > of fixing up the PCI access.\n> > > > > \n> > > > > Note: This still hangs my P1020 Freescale CPU hard, but at least I\n> > > > > get a NIP now.\n> > > > > \n> > > > > Signed-off-by: Joakim Tjernlund <joakim.tjernlund@infinera.com>\n> > > > > ---\n> > > > >   arch/powerpc/sysdev/fsl_pci.c | 2 +-\n> > > > >   1 file changed, 1 insertion(+), 1 deletion(-)\n> > > > > \n> > > > > diff --git a/arch/powerpc/sysdev/fsl_pci.c\n> > > > > b/arch/powerpc/sysdev/fsl_pci.c index 7c8b779c329a..9e64c12dff6a\n> > > > > 100644\n> > > > > --- a/arch/powerpc/sysdev/fsl_pci.c\n> > > > > +++ b/arch/powerpc/sysdev/fsl_pci.c\n> > > > > @@ -996,7 +996,7 @@ int fsl_pci_mcheck_exception(struct pt_regs\n> > \n> > *regs)\n> > > > >   \tif (is_in_pci_mem_space(addr)) {\n> > > > >   \t\tif (user_mode(regs)) {\n> > > > >   \t\t\tpagefault_disable();\n> > > > > -\t\t\tret = get_user(regs->nip, &inst);\n> > > > > +\t\t\tret = get_user(inst, (__u32 __user *)regs-\n> > > > > >nip);\n> > > > >   \t\t\tpagefault_enable();\n> > > > >   \t\t} else {\n> > > > >   \t\t\tret = probe_kernel_address(regs->nip,\n> > > > > inst);\n> > > > > \n> > > > \n> > > > Leo,\n> > > > \n> > > > Can you take a look, or assign it to someone who is familiar with this\n> > \n> > code?\n> > > \n> > > Acked-by: Li Yang <leoyang.li@nxp.com>\n> > > \n> > > Regards,\n> > > Leo\n> > \n> > I think this is forgotten, cannot se it in Linus tree.\n> \n> Hi Scott,\n> \n> Could you help to review this patch and pick it up?  Thanks.\n\nSure... In the future please CC me on patches you want me to pick up.\n\n-Scott","headers":{"Return-Path":"<linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org>","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3yrtxx5l1Mz9s7B\n\tfor <patchwork-incoming@ozlabs.org>;\n\tWed,  6 Dec 2017 07:43:49 +1100 (AEDT)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3yrtxx3KDGzDwNN\n\tfor <patchwork-incoming@ozlabs.org>;\n\tWed,  6 Dec 2017 07:43:49 +1100 (AEDT)","from baldur.buserror.net (baldur.buserror.net [165.227.176.147])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3yrtw84pCbzDrcP\n\tfor <linuxppc-dev@lists.ozlabs.org>;\n\tWed,  6 Dec 2017 07:42:16 +1100 (AEDT)","from [2601:449:8400:7293:12bf:48ff:fe84:c9a0] (helo=snotra)\n\tby baldur.buserror.net with esmtpsa\n\t(TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n\t(Exim 4.89) (envelope-from <oss@buserror.net>)\n\tid 1eMJXq-0005Io-B0; Tue, 05 Dec 2017 14:10:23 -0600"],"Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=buserror.net\n\t(client-ip=165.227.176.147; helo=baldur.buserror.net;\n\tenvelope-from=oss@buserror.net; receiver=<UNKNOWN>)","X-Greylist":"delayed 1779 seconds by postgrey-1.36 at bilbo;\n\tWed, 06 Dec 2017 07:42:16 AEDT","Message-ID":"<1512504621.10062.10.camel@buserror.net>","From":"Scott Wood <oss@buserror.net>","To":"Leo Li <leoyang.li@nxp.com>, Joakim Tjernlund\n\t<Joakim.Tjernlund@infinera.com>, York Sun <york.sun@nxp.com>","Date":"Tue, 05 Dec 2017 14:10:21 -0600","In-Reply-To":"<AM4PR0401MB1699F76EB10DD25705C4A8B98F3D0@AM4PR0401MB1699.eurprd04.prod.outlook.com>","References":"<20170905115943.19919-1-joakim.tjernlund@infinera.com>\n\t<VI1PR04MB20787FDC28E53BF15DF8E3949A970@VI1PR04MB2078.eurprd04.prod.outlook.com>\n\t<AM4PR0401MB16991E3E16496C848E3AB9078F970@AM4PR0401MB1699.eurprd04.prod.outlook.com>\n\t<1511284624.4775.138.camel@infinera.com>\n\t<AM4PR0401MB1699F76EB10DD25705C4A8B98F3D0@AM4PR0401MB1699.eurprd04.prod.outlook.com>","Organization":"Red Hat","Content-Type":"text/plain; charset=\"UTF-8\"","X-Mailer":"Evolution 3.22.6-1ubuntu1 ","Mime-Version":"1.0","Content-Transfer-Encoding":"8bit","X-SA-Exim-Connect-IP":"2601:449:8400:7293:12bf:48ff:fe84:c9a0","X-SA-Exim-Rcpt-To":"leoyang.li@nxp.com, Joakim.Tjernlund@infinera.com,\n\tyork.sun@nxp.com, linuxppc-dev@lists.ozlabs.org","X-SA-Exim-Mail-From":"oss@buserror.net","X-Spam-Checker-Version":"SpamAssassin 3.4.1 (2015-04-28) on baldur.localdomain","X-Spam-Level":"","X-Spam-Status":"No, score=-16.0 required=5.0 tests=ALL_TRUSTED,BAYES_00\n\tautolearn=ham autolearn_force=no version=3.4.1","X-Spam-Report":"* -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP\n\t*  -15 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t*      [score: 0.0000]","Subject":"Re: [PATCH] fsl_pci: Correct fsl_pci_mcheck_exception","X-SA-Exim-Version":"4.2.1 (built Tue, 02 Aug 2016 21:08:31 +0000)","X-SA-Exim-Scanned":"Yes (on baldur.buserror.net)","X-BeenThere":"linuxppc-dev@lists.ozlabs.org","X-Mailman-Version":"2.1.24","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List\n\t<linuxppc-dev.lists.ozlabs.org>","List-Unsubscribe":"<https://lists.ozlabs.org/options/linuxppc-dev>,\n\t<mailto:linuxppc-dev-request@lists.ozlabs.org?subject=unsubscribe>","List-Archive":"<http://lists.ozlabs.org/pipermail/linuxppc-dev/>","List-Post":"<mailto:linuxppc-dev@lists.ozlabs.org>","List-Help":"<mailto:linuxppc-dev-request@lists.ozlabs.org?subject=help>","List-Subscribe":"<https://lists.ozlabs.org/listinfo/linuxppc-dev>,\n\t<mailto:linuxppc-dev-request@lists.ozlabs.org?subject=subscribe>","Cc":"\"linuxppc-dev@lists.ozlabs.org\" <linuxppc-dev@lists.ozlabs.org>","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org","Sender":"\"Linuxppc-dev\"\n\t<linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org>"}}]