[{"id":1763621,"web_url":"http://patchwork.ozlabs.org/comment/1763621/","msgid":"","list_archive_url":null,"date":"2017-09-05T20:05:56","subject":"Re: [LEDE-DEV] [PATCH] netifd-proto.sh: add ip4table & ip6table to\n\t`proto_add_dynamic_defaults()`","submitter":{"id":65331,"url":"http://patchwork.ozlabs.org/api/people/65331/","name":"Hans Dedecker","email":"dedeckeh@gmail.com"},"content":"On Tue, Sep 5, 2017 at 1:39 PM, Alexandru Ardelean\n wrote:\n> The `proto_add_dynamic_defaults()` seems to be called mostly\n> in the context of LTE/3G modems (via wwan, qmi, etc) setup.\n>\n> When they get setup, these devices override default routes.\n>\n> However, depending on setup, we want these modems to\n> be part of a another routing table.\n> This change allows that.\n>\n> ip4table/ip6table are of string type in netifd to allow\n> for `default`, `local` routing table names to be specified.\n>\n> Signed-off-by: Alexandru Ardelean \n> ---\n> scripts/netifd-proto.sh | 2 ++\n> 1 file changed, 2 insertions(+)\n>\n> diff --git a/scripts/netifd-proto.sh b/scripts/netifd-proto.sh\n> index cc7031a..fd7b596 100644\n> --- a/scripts/netifd-proto.sh\n> +++ b/scripts/netifd-proto.sh\n> @@ -26,6 +26,8 @@ proto_add_dynamic_defaults() {\n> [ -n \"$defaultroute\" ] && json_add_boolean defaultroute \"$defaultroute\"\n> [ -n \"$peerdns\" ] && json_add_boolean peerdns \"$peerdns\"\n> [ -n \"$metric\" ] && json_add_int metric \"$metric\"\n> + [ -n \"$ip4table\" ] && json_add_string ip4table \"$ip4table\"\n> + [ -n \"$ip6table\" ] && json_add_string ip6table \"$ip6table\"\nI doubt this is a correct approach as the defaults defaultroute,\npeerdns and metric are common defaults for all IPv4/IPv6 interfaces\nwhile ip4table is only relevant for IPv4 interface while ip6table only\nfor IPv6 interfaces.\nLooking into directip.sh and the usage of proto_add_dynamic_defaults\nthis change would add both ip4table but also ip6table (if defined) to\nthe dynamic created DHCP interface.\nA better approach would be to add ip4table and ip6table individually\nsimilar as is done for the extendprefix option (which is also only\nrelevant for the DHCPv6 interfaces)\n\nHans\n> }\n>\n> _proto_do_teardown() {\n> --\n> 2.11.0\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org; spf=none (mailfrom)\n\tsmtp.mailfrom=lists.infradead.org (client-ip=65.50.211.133;\n\thelo=bombadil.infradead.org;\n\tenvelope-from=lede-dev-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"l1WjtyC7\"; \n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"Zt+hlbEZ\"; dkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xmyR101mkz9sNq\n\tfor ;\n\tWed, 6 Sep 2017 06:06:37 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dpK75-00014z-NT; Tue, 05 Sep 2017 20:06:23 +0000","from mail-pg0-x241.google.com ([2607:f8b0:400e:c05::241])\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dpK72-0000y4-MP\n\tfor lede-dev@lists.infradead.org; Tue, 05 Sep 2017 20:06:22 +0000","by mail-pg0-x241.google.com with SMTP id q68so2455873pgq.2\n\tfor ;\n\tTue, 05 Sep 2017 13:05:57 -0700 (PDT)","by 10.100.154.66 with HTTP; Tue, 5 Sep 2017 13:05:56 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:Subject:To:Message-ID:Date:From:\n\tReferences:In-Reply-To:MIME-Version:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=ADdF+BmbAgC1eg3ykzKlCPLm7wLVmXgBJvCiv6EhqWU=;\n\tb=l1WjtyC7e8HigY\n\tPccwhcw95jQX5z5RNbYNB2yRmU5g+E3doiunedA7Y6xyXhjz9v2deFL1HIDP6qklBwAb451dEtJ/a\n\totaixci7Z4Y6aOjcpvOj9pNJ7WgZI0KntU/QWmSg5rtkvdYOzfrBe8Pkhq0U0g6fWaTM250AxX0G7\n\tR0R7i5LUJKAm/kRztLE8xCH9cNgpVqQ/ylb+57C+2cdgNb1ORM0toPXFjUwblGQH4fhswEIIlbHDv\n\tALzLhwEfJpje6F92YrzLBjEiMj1KcIKNFJVd9Q1pHMAFign476PYR/VcKjURyB0P4+KuH3CXcw1tK\n\tXdqqcGL/R5c2dv6Q05xw==;","v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=Xg4Ve1GzMVRT9/ccMvuYHkMQ8/o5RAl0r7nIoBdZkiI=;\n\tb=Zt+hlbEZsP47S382kbAyLuFzt1uvKojY4zSwQvTtfyszmFjRmIYSHaiIEgwABKM1dN\n\tmShvkyFFqFuQdWOwVGewsdrYGD0Abv0LG5JIBc5GxklHoK6zs4XGRe7EG8ZTYOAZXFr1\n\tLoxOsU+3og/yrNVs2iGsFvXgEI5fw74QU9CGy3DZB/p+8SVz1zLUUL5TtsFbisV+G+JR\n\tvdEqZsXB4ddOVp3rg+ui+H9+3o77syAha1uvhdNJ13UfKWdtnUk1OyHo3iYZ+8sBdDRv\n\tl6RsMpsI2GEDf+mGGIYdSHiG6WAxrahIS2021Ikyq71JEHgyXwGpzOkQKh021FGDquxZ\n\tHK1w=="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=Xg4Ve1GzMVRT9/ccMvuYHkMQ8/o5RAl0r7nIoBdZkiI=;\n\tb=ZQc916rOj5Zn0KFBNfFD9RkpfmSv7Zhsf5/k6l5x99nkEnLnWaVVGI5sQdgw61VkLf\n\tqsCgdD8ovyemjZrj2VBBdxpmleMvNucTYd15pwOn/MSMDJFUcGBsPWFhw0SB+1+QbcnR\n\tiyfVYtQ0jqyIvNbwM6imMr3PxKklPNjjH9Jj4ke3Dsbu/Ub9mN+cED6JViGxRIJcvI4f\n\tmoHHYh/D3WA1j4BEP2EoM5EqifkcDyB7Ds99oWDRDJINQph9TbQ/JVf7oPH/AzU9gXoV\n\tSDV6ZJtg0IUQ373h0zbK2igrdv3BcbjyS53kWfqu8YNdbPs3/IoDG6Xr2OApuryHJviX\n\t4c9A==","X-Gm-Message-State":"AHPjjUgaa2dOGX/x4ZWyTqmrSgEeFvgyhCTviKqV/qfR9Zh2GloP43b4\n\txFTQEc+8tBE24i6kvuS74k8stDfwUg==","X-Google-Smtp-Source":"ADKCNb4IbnIBcYFq/jJUe7W48Pp1d3IM2GJeY2qAzfnBSTw2FGloo99Z+PnqdB4cmYUAFU5cCXOgnXNOOddyDMwTtjU=","X-Received":"by 10.99.119.133 with SMTP id s127mr5318721pgc.271.1504641956740;\n\tTue, 05 Sep 2017 13:05:56 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<20170905113906.19438-1-ardeleanalex@gmail.com>","References":"<20170905113906.19438-1-ardeleanalex@gmail.com>","From":"Hans Dedecker ","Date":"Tue, 5 Sep 2017 22:05:56 +0200","Message-ID":"","To":"Alexandru Ardelean ","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170905_130620_796521_B0414E40 ","X-CRM114-Status":"GOOD ( 12.62 )","X-Spam-Score":"-2.0 (--)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-2.0 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/,\n\tno\n\ttrust [2607:f8b0:400e:c05:0:0:0:241 listed in] [list.dnswl.org]\n\t-0.0 SPF_PASS SPF: sender matches SPF record\n\t0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail\n\tprovider (dedeckeh[at]gmail.com)\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]\n\t-0.1 DKIM_VALID Message has at least one valid DKIM or DK signature\n\t0.1 DKIM_SIGNED Message has a DKIM or DK signature,\n\tnot necessarily valid\n\t-0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from\n\tauthor's domain","Subject":"Re: [LEDE-DEV] [PATCH] netifd-proto.sh: add ip4table & ip6table to\n\t`proto_add_dynamic_defaults()`","X-BeenThere":"lede-dev@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"LEDE Development List ,\n\tFelix Fietkau ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"Lede-dev\" ","Errors-To":"lede-dev-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org"}},{"id":1763826,"web_url":"http://patchwork.ozlabs.org/comment/1763826/","msgid":"","list_archive_url":null,"date":"2017-09-06T05:57:58","subject":"Re: [LEDE-DEV] [PATCH] netifd-proto.sh: add ip4table & ip6table to\n\t`proto_add_dynamic_defaults()`","submitter":{"id":65503,"url":"http://patchwork.ozlabs.org/api/people/65503/","name":"Alexandru Ardelean","email":"ardeleanalex@gmail.com"},"content":"On Tue, Sep 5, 2017 at 11:05 PM, Hans Dedecker wrote:\n> On Tue, Sep 5, 2017 at 1:39 PM, Alexandru Ardelean\n> wrote:\n>> The `proto_add_dynamic_defaults()` seems to be called mostly\n>> in the context of LTE/3G modems (via wwan, qmi, etc) setup.\n>>\n>> When they get setup, these devices override default routes.\n>>\n>> However, depending on setup, we want these modems to\n>> be part of a another routing table.\n>> This change allows that.\n>>\n>> ip4table/ip6table are of string type in netifd to allow\n>> for `default`, `local` routing table names to be specified.\n>>\n>> Signed-off-by: Alexandru Ardelean \n>> ---\n>> scripts/netifd-proto.sh | 2 ++\n>> 1 file changed, 2 insertions(+)\n>>\n>> diff --git a/scripts/netifd-proto.sh b/scripts/netifd-proto.sh\n>> index cc7031a..fd7b596 100644\n>> --- a/scripts/netifd-proto.sh\n>> +++ b/scripts/netifd-proto.sh\n>> @@ -26,6 +26,8 @@ proto_add_dynamic_defaults() {\n>> [ -n \"$defaultroute\" ] && json_add_boolean defaultroute \"$defaultroute\"\n>> [ -n \"$peerdns\" ] && json_add_boolean peerdns \"$peerdns\"\n>> [ -n \"$metric\" ] && json_add_int metric \"$metric\"\n>> + [ -n \"$ip4table\" ] && json_add_string ip4table \"$ip4table\"\n>> + [ -n \"$ip6table\" ] && json_add_string ip6table \"$ip6table\"\n> I doubt this is a correct approach as the defaults defaultroute,\n> peerdns and metric are common defaults for all IPv4/IPv6 interfaces\n> while ip4table is only relevant for IPv4 interface while ip6table only\n> for IPv6 interfaces.\n> Looking into directip.sh and the usage of proto_add_dynamic_defaults\n> this change would add both ip4table but also ip6table (if defined) to\n> the dynamic created DHCP interface.\n> A better approach would be to add ip4table and ip6table individually\n> similar as is done for the extendprefix option (which is also only\n> relevant for the DHCPv6 interfaces)\n>\n> Hans\n\nThanks for the quick reply.\n\nWill check on your proposed alternative.\n\nThanks\nAlex\n\n>> }\n>>\n>> _proto_do_teardown() {\n>> --\n>> 2.11.0\n>>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org; spf=none (mailfrom)\n\tsmtp.mailfrom=lists.infradead.org (client-ip=65.50.211.133;\n\thelo=bombadil.infradead.org;\n\tenvelope-from=lede-dev-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"tkpJA7Vv\"; \n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"rhND9iRt\"; dkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xnCZS5Ff0z9sBd\n\tfor ;\n\tWed, 6 Sep 2017 15:58:56 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dpTMK-0007Lk-7K; Wed, 06 Sep 2017 05:58:44 +0000","from mail-pg0-x244.google.com ([2607:f8b0:400e:c05::244])\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dpTMG-0007Ht-Uz\n\tfor lede-dev@lists.infradead.org; Wed, 06 Sep 2017 05:58:42 +0000","by mail-pg0-x244.google.com with SMTP id d8so3022574pgt.3\n\tfor ;\n\tTue, 05 Sep 2017 22:58:20 -0700 (PDT)","by 10.100.160.236 with HTTP; Tue, 5 Sep 2017 22:57:58 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:Subject:To:Message-ID:Date:From:\n\tReferences:In-Reply-To:MIME-Version:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=3R/TTZSmZhZam2HrM/ydNVdMQJ28saW3qXhQUNXhXNE=;\n\tb=tkpJA7VvakOjbN\n\tAN3FkRrveBLUqrCW4cqFqqoxysKlKTyiFwS4uuWlSs8phNnRXEcNs3xP5jXvJYsrYhSZHaqP/OW7b\n\tReKHVqwHxrudbEvZ+kmyYZ6pBc+MDFspoeUb7+Q28li91c3pJr3aS834qM8IGTPejUajls/HITBKb\n\t+nFGJrZMbSPXWyHQouFeV+g8sNWI61Ceyvk8p1KoUj5+Rp/hOAeGaZtsZ+dgdbFAeeUNT2IL43Z9T\n\taJp7wlfYW8RxUJDuoWpaWEEaDWi8mGekoUltaiMKiaZ66ovIL29E+gOtk8B+2wW6ABGsqcMwJv67B\n\tWb3TOWZXAyDnOF2OXniQ==;","v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=S3GErK8A88fLT+uRmYUPSZQqh7WhJ0YtjKSxsPMjh38=;\n\tb=rhND9iRtJ3+c6QMCGBBQ5RptAp7GqzicDbMtiVVeWW1Z/GBrWOlt8olO3XfTpYOdSV\n\t3wPAyXB3Lhyvg2rH6d2I3SYs5pRDI11E5vqWM3mhZ56YgvdOCKuCw2KGUT8wA9f5w1aB\n\tGVDOhgHA75j21lUq75Eimt5FPmEz62TdlOsmVP5jrjI9fpPIp9CwSzLeATAtQf3H2QsN\n\t4K8IXdXA7pfZ+HpK3utIqKynuBcwXt6X655kgm/mfKAb/D0s1dvu359wZmsT1onYbP30\n\tVN+GVM6L3esfNL0bhHEy3RvIGLM5mQbYfBUBs9fzHI9021X7AkOfXPmONohrTUXbQVhc\n\tR5aw=="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=S3GErK8A88fLT+uRmYUPSZQqh7WhJ0YtjKSxsPMjh38=;\n\tb=HC5BCxOhDvLhY9eQEl6+jIRL6nOyibqvCgtLuhvPbswKK/AGEUKmayOYe7yO4JlVQf\n\tl6qFf1D7qs9O/klYeckXoeWPulYgbEBSkh6qECm1P6qvgq17jBT9AHfZ/HUHYqr+/Lva\n\tiKWY8JAtr0y7rvvoUTsebKLalcNYukKXm2UBIfV8edgGKBfKxjr6BJtX9XqEb1AWvrzs\n\tjnJR1Kp+MTUIFFzKnDuk+SiRS/biQuP4qIBmaBvhVfJ6SwOUfz3xjGhYk5a7E/elnyvF\n\t6NrBPUbG0VqcA6rNNjYnW/GqefMaSqaKzBG15AI5D+AqN5SeaofwrBSWb8aRwt3xTD2V\n\tbMwQ==","X-Gm-Message-State":"AHPjjUhNuUL6xuaUI1SDHVJzVRXydSoZEUtAUKR3IX7fL4zUFLwKnbrb\n\tT0+1eG40XoQqx0DEMIGqhqceUsUt1A==","X-Google-Smtp-Source":"ADKCNb7WgIfUtmsCELLWE/732m7FvA6vdFIxanYw9p5vW52FQcH/XWiLI8yZ2zbUldXkYKxLB4IIoQEiuThnvZwoivs=","X-Received":"by 10.98.48.194 with SMTP id w185mr6137573pfw.231.1504677499733; \n\tTue, 05 Sep 2017 22:58:19 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"","References":"<20170905113906.19438-1-ardeleanalex@gmail.com>\n\t","From":"Alexandru Ardelean ","Date":"Wed, 6 Sep 2017 08:57:58 +0300","Message-ID":"","To":"Hans Dedecker ","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170905_225841_060595_36BA424C ","X-CRM114-Status":"GOOD ( 11.70 )","X-Spam-Score":"-2.0 (--)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-2.0 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/,\n\tno\n\ttrust [2607:f8b0:400e:c05:0:0:0:244 listed in] [list.dnswl.org]\n\t-0.0 SPF_PASS SPF: sender matches SPF record\n\t0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail\n\tprovider (ardeleanalex[at]gmail.com)\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]\n\t-0.1 DKIM_VALID Message has at least one valid DKIM or DK signature\n\t0.1 DKIM_SIGNED Message has a DKIM or DK signature,\n\tnot necessarily valid\n\t-0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from\n\tauthor's domain","Subject":"Re: [LEDE-DEV] [PATCH] netifd-proto.sh: add ip4table & ip6table to\n\t`proto_add_dynamic_defaults()`","X-BeenThere":"lede-dev@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"LEDE Development List ,\n\tFelix Fietkau ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"Lede-dev\" ","Errors-To":"lede-dev-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org"}},{"id":1765841,"web_url":"http://patchwork.ozlabs.org/comment/1765841/","msgid":"<20170909194650.GA7869@lud.polynome.dn42>","list_archive_url":null,"date":"2017-09-09T19:46:51","subject":"Re: [LEDE-DEV] [PATCH] netifd-proto.sh: add ip4table & ip6table to\n\t`proto_add_dynamic_defaults()`","submitter":{"id":67238,"url":"http://patchwork.ozlabs.org/api/people/67238/","name":"Baptiste Jonglez","email":"baptiste@bitsofnetworks.org"},"content":"Hi,\n\nOn 05-09-17, Alexandru Ardelean wrote:\n> The `proto_add_dynamic_defaults()` seems to be called mostly\n> in the context of LTE/3G modems (via wwan, qmi, etc) setup.\n> \n> When they get setup, these devices override default routes.\n> \n> However, depending on setup, we want these modems to\n> be part of a another routing table.\n> This change allows that.\n> \n> ip4table/ip6table are of string type in netifd to allow\n> for `default`, `local` routing table names to be specified.\n\nJust a remark on the names: \"ip4table\" and \"ip6table\" make it looks like\nit's related to firewall. But this has nothing to do with firewalls.\n\nMaybe use \"routingtable\" and \"routingtablev6\" instead? Or just\n\"table\"/\"tablev6\"?\n\n> Signed-off-by: Alexandru Ardelean \n> ---\n> scripts/netifd-proto.sh | 2 ++\n> 1 file changed, 2 insertions(+)\n> \n> diff --git a/scripts/netifd-proto.sh b/scripts/netifd-proto.sh\n> index cc7031a..fd7b596 100644\n> --- a/scripts/netifd-proto.sh\n> +++ b/scripts/netifd-proto.sh\n> @@ -26,6 +26,8 @@ proto_add_dynamic_defaults() {\n> \t[ -n \"$defaultroute\" ] && json_add_boolean defaultroute \"$defaultroute\"\n> \t[ -n \"$peerdns\" ] && json_add_boolean peerdns \"$peerdns\"\n> \t[ -n \"$metric\" ] && json_add_int metric \"$metric\"\n> +\t[ -n \"$ip4table\" ] && json_add_string ip4table \"$ip4table\"\n> +\t[ -n \"$ip6table\" ] && json_add_string ip6table \"$ip6table\"\n> }\n> \n> _proto_do_teardown() {","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org; spf=none (mailfrom)\n\tsmtp.mailfrom=lists.infradead.org (client-ip=65.50.211.133;\n\thelo=bombadil.infradead.org;\n\tenvelope-from=lede-dev-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"PfaqUTt9\"; \n\tdkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xqQDd62Wrz9s7G\n\tfor ;\n\tSun, 10 Sep 2017 06:06:09 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dqm0q-0006JW-7q; Sat, 09 Sep 2017 20:05:56 +0000","from [193.33.56.227] (helo=mails.bitsofnetworks.org)\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dqm0m-0006BE-NL\n\tfor lede-dev@lists.infradead.org; Sat, 09 Sep 2017 20:05:54 +0000","from [172.23.184.97] (helo=lud.polynome.dn42)\n\tby mails.bitsofnetworks.org with esmtps\n\t(TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89)\n\t(envelope-from )\n\tid 1dqliO-00046G-4z; Sat, 09 Sep 2017 21:46:52 +0200"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:Cc:\n\tList-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:\n\tSubject:In-Reply-To:MIME-Version:References:Message-ID:To:From:Date:Reply-To:\n\tContent-Transfer-Encoding:Content-ID:Content-Description:Resent-Date:\n\tResent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner;\n\tbh=F/EXG9K63Nlggm7o8HUr8WJsyK5wWvhBEMs9IeZc6+Q=;\n\tb=PfaqUTt9gABmp2wxBE1lZqdvJ\n\tE6i/mwX0NjZN9L6lFVkABT5z8xjp2eYfsxgTiMLZ6hRECEPJKZoSD+sXuJi8PVeMMBEUDLHgXM5x5\n\t/80k7Boe3kIyP9T/JX4/7wnZ38ImIXhUR+Tddo58MzLrIiyeHa/Z1hMLz6fjNH3DzmCsYePWgRswe\n\tWtnydBzXY6VA+unfWvLYqdyepIzx+ZYAMZn5zJl8WwyEFCzHhHWG8fSb6xpMB6zbvc3Yfzv2irORU\n\tWg+TPRv3tJ0BsdC4LyGtUiZOINHnrd4d2cZVGiwadlEg3VoEMMUo24Y7XSiDXfForVU5N8vVQlkBx\n\tuliVtxDLg==;","Date":"Sat, 9 Sep 2017 21:46:51 +0200","From":"Baptiste Jonglez ","To":"Alexandru Ardelean ","Message-ID":"<20170909194650.GA7869@lud.polynome.dn42>","References":"<20170905113906.19438-1-ardeleanalex@gmail.com>","MIME-Version":"1.0","In-Reply-To":"<20170905113906.19438-1-ardeleanalex@gmail.com>","User-Agent":"Mutt/1.5.24 (2015-08-30)","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170909_130553_100112_8874776A ","X-CRM114-Status":"GOOD ( 10.91 )","X-Spam-Score":"-1.1 (-)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-1.1 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t0.0 SPF_FAIL SPF: sender does not match SPF record (fail)\n\t[SPF failed: Please see http://www.openspf.org/Why?s=mfrom;\n\tid=baptiste%40bitsofnetworks.org; ip=193.33.56.227;\n\tr=bombadil.infradead.org]\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]\n\t0.8 RDNS_NONE Delivered to internal network by a host with no rDNS","Subject":"Re: [LEDE-DEV] [PATCH] netifd-proto.sh: add ip4table & ip6table to\n\t`proto_add_dynamic_defaults()`","X-BeenThere":"lede-dev@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"dedeckeh@gmail.com, lede-dev@lists.infradead.org, nbd@nbd.name","Content-Type":"multipart/mixed;\n\tboundary=\"===============5163900704446270136==\"","Sender":"\"Lede-dev\" ","Errors-To":"lede-dev-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org"}},{"id":1765848,"web_url":"http://patchwork.ozlabs.org/comment/1765848/","msgid":"<20170909195116.GB7869@lud.polynome.dn42>","list_archive_url":null,"date":"2017-09-09T19:51:16","subject":"Re: [LEDE-DEV] [PATCH] netifd-proto.sh: add ip4table & ip6table to\n\t`proto_add_dynamic_defaults()`","submitter":{"id":67238,"url":"http://patchwork.ozlabs.org/api/people/67238/","name":"Baptiste Jonglez","email":"baptiste@bitsofnetworks.org"},"content":"On 09-09-17, Baptiste Jonglez wrote:\n> On 05-09-17, Alexandru Ardelean wrote:\n> > The `proto_add_dynamic_defaults()` seems to be called mostly\n> > in the context of LTE/3G modems (via wwan, qmi, etc) setup.\n> > \n> > When they get setup, these devices override default routes.\n> > \n> > However, depending on setup, we want these modems to\n> > be part of a another routing table.\n> > This change allows that.\n> > \n> > ip4table/ip6table are of string type in netifd to allow\n> > for `default`, `local` routing table names to be specified.\n> \n> Just a remark on the names: \"ip4table\" and \"ip6table\" make it looks like\n> it's related to firewall. But this has nothing to do with firewalls.\n> \n> Maybe use \"routingtable\" and \"routingtablev6\" instead? Or just\n> \"table\"/\"tablev6\"?\n\nIt seems that \"ip4table\" and \"ip6table\" is already understood by other\nprotocols, so you can disregard my remark:\n\nhttps://wiki.openwrt.org/doc/uci/network#options_valid_for_all_protocol_types\n\n\n> > Signed-off-by: Alexandru Ardelean \n> > ---\n> > scripts/netifd-proto.sh | 2 ++\n> > 1 file changed, 2 insertions(+)\n> > \n> > diff --git a/scripts/netifd-proto.sh b/scripts/netifd-proto.sh\n> > index cc7031a..fd7b596 100644\n> > --- a/scripts/netifd-proto.sh\n> > +++ b/scripts/netifd-proto.sh\n> > @@ -26,6 +26,8 @@ proto_add_dynamic_defaults() {\n> > \t[ -n \"$defaultroute\" ] && json_add_boolean defaultroute \"$defaultroute\"\n> > \t[ -n \"$peerdns\" ] && json_add_boolean peerdns \"$peerdns\"\n> > \t[ -n \"$metric\" ] && json_add_int metric \"$metric\"\n> > +\t[ -n \"$ip4table\" ] && json_add_string ip4table \"$ip4table\"\n> > +\t[ -n \"$ip6table\" ] && json_add_string ip6table \"$ip6table\"\n> > }\n> > \n> > _proto_do_teardown() {","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org; spf=none (mailfrom)\n\tsmtp.mailfrom=lists.infradead.org (client-ip=65.50.211.133;\n\thelo=bombadil.infradead.org;\n\tenvelope-from=lede-dev-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"FLjYvy5j\"; \n\tdkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xqQLt06gbz9s7G\n\tfor ;\n\tSun, 10 Sep 2017 06:11:34 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dqm5z-0000JH-U9; Sat, 09 Sep 2017 20:11:15 +0000","from [193.33.56.227] (helo=mails.bitsofnetworks.org)\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dqm5b-0000DO-6E\n\tfor lede-dev@lists.infradead.org; Sat, 09 Sep 2017 20:10:53 +0000","from [172.23.184.97] (helo=lud.polynome.dn42)\n\tby mails.bitsofnetworks.org with esmtps\n\t(TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89)\n\t(envelope-from )\n\tid 1dqlmf-00048t-PB; Sat, 09 Sep 2017 21:51:17 +0200"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:Cc:\n\tList-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:\n\tSubject:In-Reply-To:MIME-Version:References:Message-ID:To:From:Date:Reply-To:\n\tContent-Transfer-Encoding:Content-ID:Content-Description:Resent-Date:\n\tResent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner;\n\tbh=9tDoGjQRIgv5nzzLLt7J5HGqZqwNDbBCXJqS11gxrJ0=;\n\tb=FLjYvy5jmmxQmbe+vBzSbRzeV\n\tZ9+Hiflw3n009VWv49T4D23vngFGdh+ViOs5jNxhdxpE+tnauGuJv+0+SYFjL6C3hrzYfbCGRi5sE\n\tfjlu6YBiPNgO/ooDN2iS0j6ks0bxDHZBR33/tcoG10YKSpIzW68tSVQotVoQ9NemAG+29WUJ9HZ9U\n\twCeYwxaEasmdFD9m4IMjYigA9gSiXHs5LFuHIThNhGFZCbqoA7DHPZiZQQyuCiHMxjiaT0qYSapYA\n\tt4dWj6Ocm1PrRhhQjji/U3iA2RHrRUt9Ot8DuHQ2cXZa/eFI9E3uF+5iHTtydXvXRilPh7xZ54duE\n\tyZCBEJyHw==;","Date":"Sat, 9 Sep 2017 21:51:16 +0200","From":"Baptiste Jonglez ","To":"Alexandru Ardelean ","Message-ID":"<20170909195116.GB7869@lud.polynome.dn42>","References":"<20170905113906.19438-1-ardeleanalex@gmail.com>\n\t<20170909194650.GA7869@lud.polynome.dn42>","MIME-Version":"1.0","In-Reply-To":"<20170909194650.GA7869@lud.polynome.dn42>","User-Agent":"Mutt/1.5.24 (2015-08-30)","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170909_131051_568310_79336906 ","X-CRM114-Status":"GOOD ( 13.99 )","X-Spam-Score":"-1.1 (-)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-1.1 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t0.0 SPF_FAIL SPF: sender does not match SPF record (fail)\n\t[SPF failed: Please see http://www.openspf.org/Why?s=mfrom;\n\tid=baptiste%40bitsofnetworks.org; ip=193.33.56.227;\n\tr=bombadil.infradead.org]\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]\n\t0.8 RDNS_NONE Delivered to internal network by a host with no rDNS","Subject":"Re: [LEDE-DEV] [PATCH] netifd-proto.sh: add ip4table & ip6table to\n\t`proto_add_dynamic_defaults()`","X-BeenThere":"lede-dev@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"dedeckeh@gmail.com, lede-dev@lists.infradead.org, nbd@nbd.name","Content-Type":"multipart/mixed;\n\tboundary=\"===============7358644307562581380==\"","Sender":"\"Lede-dev\" ","Errors-To":"lede-dev-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org"}},{"id":1765914,"web_url":"http://patchwork.ozlabs.org/comment/1765914/","msgid":"","list_archive_url":null,"date":"2017-09-10T08:02:16","subject":"Re: [LEDE-DEV] [PATCH] netifd-proto.sh: add ip4table & ip6table to\n\t`proto_add_dynamic_defaults()`","submitter":{"id":65503,"url":"http://patchwork.ozlabs.org/api/people/65503/","name":"Alexandru Ardelean","email":"ardeleanalex@gmail.com"},"content":"On Sat, Sep 9, 2017 at 10:51 PM, Baptiste Jonglez\n wrote:\n> On 09-09-17, Baptiste Jonglez wrote:\n>> On 05-09-17, Alexandru Ardelean wrote:\n>> > The `proto_add_dynamic_defaults()` seems to be called mostly\n>> > in the context of LTE/3G modems (via wwan, qmi, etc) setup.\n>> >\n>> > When they get setup, these devices override default routes.\n>> >\n>> > However, depending on setup, we want these modems to\n>> > be part of a another routing table.\n>> > This change allows that.\n>> >\n>> > ip4table/ip6table are of string type in netifd to allow\n>> > for `default`, `local` routing table names to be specified.\n>>\n>> Just a remark on the names: \"ip4table\" and \"ip6table\" make it looks like\n>> it's related to firewall. But this has nothing to do with firewalls.\n>>\n>> Maybe use \"routingtable\" and \"routingtablev6\" instead? Or just\n>> \"table\"/\"tablev6\"?\n>\n> It seems that \"ip4table\" and \"ip6table\" is already understood by other\n> protocols, so you can disregard my remark:\n>\n> https://wiki.openwrt.org/doc/uci/network#options_valid_for_all_protocol_types\n\nThis got into my spam folder for some reason.\nGMail is weird sometimes.\n\nI still have to try this out a bit more.\nI'm load-balancing various stuff, so I did not get to try out stuff in depth.\n\nAtm I'm doing:\nconfig interface 'usb0_1'\n option ifname 'usb0'\n option proto 'wwan'\n option ip4table 100\n option ip6table 100\n\nThis seems to make an interface [in netifd] called\nnetwork.interface.usb0_1 which adds the ip4table/ip6table to usb0.\nHowever, for some reason [likely a bug with my config generation code]\nthe DHCP part is not initializing properly ; well for some reason no\nRX packets are incoming.\nI'll dig into that.\n\nMy trip through getting LTE setup on our system was a bit interesting.\nAt some point, I've found that the modem needs a backport from the\nupstream kernel.\nFor the 4.4 kernel, this is needed for some QMI modems:\nhttps://github.com/torvalds/linux/commit/93725149794d3d418cf1eddcae60c7b536c5faa1\n\nOtherwise, the modem does not init. That patch should be in 4.5 though.\n\n\n>\n>\n>> > Signed-off-by: Alexandru Ardelean \n>> > ---\n>> > scripts/netifd-proto.sh | 2 ++\n>> > 1 file changed, 2 insertions(+)\n>> >\n>> > diff --git a/scripts/netifd-proto.sh b/scripts/netifd-proto.sh\n>> > index cc7031a..fd7b596 100644\n>> > --- a/scripts/netifd-proto.sh\n>> > +++ b/scripts/netifd-proto.sh\n>> > @@ -26,6 +26,8 @@ proto_add_dynamic_defaults() {\n>> > [ -n \"$defaultroute\" ] && json_add_boolean defaultroute \"$defaultroute\"\n>> > [ -n \"$peerdns\" ] && json_add_boolean peerdns \"$peerdns\"\n>> > [ -n \"$metric\" ] && json_add_int metric \"$metric\"\n>> > + [ -n \"$ip4table\" ] && json_add_string ip4table \"$ip4table\"\n>> > + [ -n \"$ip6table\" ] && json_add_string ip6table \"$ip6table\"\n>> > }\n>> >\n>> > _proto_do_teardown() {\n>\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org; spf=none (mailfrom)\n\tsmtp.mailfrom=lists.infradead.org (client-ip=65.50.211.133;\n\thelo=bombadil.infradead.org;\n\tenvelope-from=lede-dev-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"Lsqd4Mdr\"; \n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"m/v22Zev\"; dkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xqk884vMPz9sNc\n\tfor ;\n\tSun, 10 Sep 2017 18:03:18 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dqxCo-0004ja-SD; Sun, 10 Sep 2017 08:03:02 +0000","from mail-pg0-x241.google.com ([2607:f8b0:400e:c05::241])\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dqxCl-0004eq-38\n\tfor lede-dev@lists.infradead.org; Sun, 10 Sep 2017 08:03:01 +0000","by mail-pg0-x241.google.com with SMTP id i130so1245407pgc.0\n\tfor ;\n\tSun, 10 Sep 2017 01:02:37 -0700 (PDT)","by 10.100.160.236 with HTTP; Sun, 10 Sep 2017 01:02:16 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:Subject:To:Message-ID:Date:From:\n\tReferences:In-Reply-To:MIME-Version:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=z46gNp0VDjBbL9OHMQeF40TuZ7SkbGvKythxE0BDaBo=;\n\tb=Lsqd4MdrJXBJY5\n\tQGZdS6SVK+L/rHCnl1SMk4fUa5QDNGRZhdb16V/t6SYjU2/0HDdSQ6t1wWiIBbyEajaZHhNWBCNsc\n\tXZPbTdFNXhKUjHc2odI5ggrD8tv9eciy0rNwdkV1iPN85VzxB+z2D5ZImZiT6bn+af28bL8ZEkKa7\n\tLmOKXyqYyo9vFadXa7CYAEosUvMo/OeCaH5x+6dnSsfzYBtThxdIqW8syMTns/Ukfkr6puVM1WALq\n\tTdr7WXVX1oX0lnZkNwPkmiIzPSsQNLBzNJwkfxDNgcArKgzfQMYbnrgTkinV/XEqFIlPfhd3D+GvC\n\tXbtZ+Hk4gXAiCyyFETRA==;","v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=f8pgFQKEWZgIyeSXdNU3KEN3oZistCHRwtqNOKjXHHw=;\n\tb=m/v22Zev6SXqJSIljvleJmULKlkcXUciWKIH5EZYAO/Qnd4pgXvj5U48SiJfUBA526\n\tZm8EQFYKAziNumI/jKzGV7fn61sSqY1NdwYdqIdzTD++Dv6q7cNTC/vrTbvLGoLztPya\n\tiOMV8hCMSpBEY7m7h++u4QSSEYOn3fOfKoV9FNX/0ZcTPdeOX12TBFqYFBn4JeytguBe\n\tHEwplP1rR63F/oOdj4dc128c83EYlZgIJ5uinvFxvFdLq/UtZWt45rOvelVJTfMcBY8g\n\tFkW5rXwVCJgS204peys+r/bw+PaZuSSS4iSI2eqwehD4mrB7GG7vRmNT9oOEVwSkg6Be\n\tawhQ=="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=f8pgFQKEWZgIyeSXdNU3KEN3oZistCHRwtqNOKjXHHw=;\n\tb=bGdaDR+to3X8qq18/WdEiWqA98pxf1q19eJ3B6P6G8ZAMkHuPnvhQ16S38huvpbNwk\n\t1ArBuH9MuXvXciRJDcRoNNkNHB4VHKAkTd7O5uJee+nscBGZBnpqnaPXdvDfnCkWLqwy\n\ta50GBUtKUfRdYmB0NSCeALJUcGHEgqVTHQCgP53Gh1J70v8AugD0/TBMmw+ZAU18uSQu\n\t6L2e+5Rd6VwipJComh3UIirXNo/hoJt0EA+rc05PYRoLSQgroIRWNuPr8RBx1iis9ghg\n\tRsgJUfum6WnmiX5R+lG9NIqWXn/jWgl6aJIUZ6VYu+QBL/WCL1jqfP4q9ChvyeHoc6F8\n\tDNWA==","X-Gm-Message-State":"AHPjjUhNA7acaaHL78cazAcbOqQeT4uPKW9s9HMwBUa8qsLOiHr5SEkX\n\t8AdUM5ZtVOtcfRr/cmmQgz9Pys2ZPt43","X-Google-Smtp-Source":"ADKCNb7FThK7ZHQRqbQuYyBBYo0K+4ZAO14xP7r2x2UZzOPpzde2E+Cw0s3egdqvHJmpbgdqQ9E3sJHO8f8x9FSuohc=","X-Received":"by 10.84.177.131 with SMTP id x3mr9566424plb.123.1505030557021; \n\tSun, 10 Sep 2017 01:02:37 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<20170909195116.GB7869@lud.polynome.dn42>","References":"<20170905113906.19438-1-ardeleanalex@gmail.com>\n\t<20170909194650.GA7869@lud.polynome.dn42>\n\t<20170909195116.GB7869@lud.polynome.dn42>","From":"Alexandru Ardelean ","Date":"Sun, 10 Sep 2017 11:02:16 +0300","Message-ID":"","To":"Baptiste Jonglez ","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170910_010259_227149_FD900608 ","X-CRM114-Status":"GOOD ( 18.10 )","X-Spam-Score":"-2.0 (--)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-2.0 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/,\n\tno\n\ttrust [2607:f8b0:400e:c05:0:0:0:241 listed in] [list.dnswl.org]\n\t-0.0 SPF_PASS SPF: sender matches SPF record\n\t0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail\n\tprovider (ardeleanalex[at]gmail.com)\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]\n\t-0.1 DKIM_VALID Message has at least one valid DKIM or DK signature\n\t0.1 DKIM_SIGNED Message has a DKIM or DK signature,\n\tnot necessarily valid\n\t-0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from\n\tauthor's domain","Subject":"Re: [LEDE-DEV] [PATCH] netifd-proto.sh: add ip4table & ip6table to\n\t`proto_add_dynamic_defaults()`","X-BeenThere":"lede-dev@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Hans Dedecker ,\n\tLEDE Development List ,\n\tFelix Fietkau ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"Lede-dev\" ","Errors-To":"lede-dev-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org"}}]