[{"id":1763258,"web_url":"http://patchwork.ozlabs.org/comment/1763258/","msgid":"<87bmmpe5d2.fsf@linux.vnet.ibm.com>","list_archive_url":null,"date":"2017-09-05T11:45:29","subject":"Re: [Skiboot] [PATCH] capi: Mask Psl Credit timeout error for P9","submitter":{"id":48041,"url":"http://patchwork.ozlabs.org/api/people/48041/","name":"Stewart Smith","email":"stewart@linux.vnet.ibm.com"},"content":"Vaibhav Jain <vaibhav@linux.vnet.ibm.com> writes:\n> Mask the PSL credit timeout error in CAPP FIR Mask register\n> bit(46). As per the h/w team this error is now deprecated and shouldn't\n> cause any fir-action for P9.\n>\n> Signed-off-by: Vaibhav Jain <vaibhav@linux.vnet.ibm.com>\n> ---\n>  hw/phb4.c | 5 +++++\n>  1 file changed, 5 insertions(+)\n>\n> diff --git a/hw/phb4.c b/hw/phb4.c\n> index 1e148e0b..cddb8521 100644\n> --- a/hw/phb4.c\n> +++ b/hw/phb4.c\n> @@ -3431,6 +3431,11 @@ static void phb4_init_capp_regs(struct phb4 *p)\n>  \t\t\t    0xFFFFF00E00000000);\n>  \t}\n>  \n> +\t/* Mask the CAPP PSL Credit Timeout Register error */\n> +\txscom_read(p->chip_id, CAPP_FIR_MASK + offset, &reg);\n> +\treg |= PPC_BIT(46);\n> +\txscom_write(p->chip_id, CAPP_FIR_MASK + offset, reg);\n> +\n>  \t/* Deassert TLBI_FENCED and tlbi_psl_is_dead */\n>  \txscom_write(p->chip_id, CAPP_ERR_STATUS_CTRL + offset, 0);\n\nThis looks like a prime candidate for xscom_write_mask() that Alistair\nintroduced in:\ncommit e3f7d42c77bfc3b899d3d636b372e1292b790656\nAuthor: Alistair Popple <alistair@popple.id.au>\nDate:   Fri Aug 4 14:15:19 2017 +1000\n\n    xscom: Add xscom_write_mask() function\n    \n    It is common for xscom registers to only contain specific bit fields that\n    need to be modified without altering the rest of the register. This adds a\n    convenience function to perform xscom read-modify-write operations under a\n    mask.","headers":{"Return-Path":"<skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org>","X-Original-To":["incoming@patchwork.ozlabs.org","skiboot@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","skiboot@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xmlKy6kwnz9s7m\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue,  5 Sep 2017 21:46:30 +1000 (AEST)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3xmlKy1yTZzDq8f\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue,  5 Sep 2017 21:46:30 +1000 (AEST)","from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com\n\t[148.163.158.5])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3xmlK623MvzDrJF\n\tfor <skiboot@lists.ozlabs.org>; Tue,  5 Sep 2017 21:45:46 +1000 (AEST)","from pps.filterd (m0098421.ppops.net [127.0.0.1])\n\tby mx0a-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id\n\tv85BiY8L130593\n\tfor <skiboot@lists.ozlabs.org>; Tue, 5 Sep 2017 07:45:43 -0400","from e32.co.us.ibm.com (e32.co.us.ibm.com [32.97.110.150])\n\tby mx0a-001b2d01.pphosted.com with ESMTP id 2cspu37u7k-1\n\t(version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT)\n\tfor <skiboot@lists.ozlabs.org>; Tue, 05 Sep 2017 07:45:43 -0400","from localhost\n\tby e32.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use\n\tOnly! Violators will be prosecuted\n\tfor <skiboot@lists.ozlabs.org> from <stewart@linux.vnet.ibm.com>;\n\tTue, 5 Sep 2017 05:45:42 -0600","from b03cxnp08027.gho.boulder.ibm.com (9.17.130.19)\n\tby e32.co.us.ibm.com (192.168.1.132) with IBM ESMTP SMTP Gateway:\n\tAuthorized Use Only! Violators will be prosecuted; \n\tTue, 5 Sep 2017 05:45:41 -0600","from b03ledav003.gho.boulder.ibm.com\n\t(b03ledav003.gho.boulder.ibm.com [9.17.130.234])\n\tby b03cxnp08027.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with\n\tESMTP id v85BjaU464225350; Tue, 5 Sep 2017 04:45:36 -0700","from b03ledav003.gho.boulder.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id 37B286A03D;\n\tTue,  5 Sep 2017 05:45:36 -0600 (MDT)","from birb.localdomain (unknown [9.81.220.173])\n\tby b03ledav003.gho.boulder.ibm.com (Postfix) with SMTP id C9E5B6A03C; \n\tTue,  5 Sep 2017 05:45:34 -0600 (MDT)","by birb.localdomain (Postfix, from userid 1000)\n\tid C2C324F0CA5; Tue,  5 Sep 2017 21:45:29 +1000 (AEST)"],"Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=linux.vnet.ibm.com\n\t(client-ip=148.163.158.5; helo=mx0a-001b2d01.pphosted.com;\n\tenvelope-from=stewart@linux.vnet.ibm.com; receiver=<UNKNOWN>)","From":"Stewart Smith <stewart@linux.vnet.ibm.com>","To":"Vaibhav Jain <vaibhav@linux.vnet.ibm.com>, skiboot@lists.ozlabs.org,\n\tChristophe Lombard <christophe_lombard@fr.ibm.com>","In-Reply-To":"<20170905113156.2851-1-vaibhav@linux.vnet.ibm.com>","References":"<20170905113156.2851-1-vaibhav@linux.vnet.ibm.com>","Date":"Tue, 05 Sep 2017 21:45:29 +1000","MIME-Version":"1.0","X-TM-AS-GCONF":"00","x-cbid":"17090511-0004-0000-0000-000012DFBE95","X-IBM-SpamModules-Scores":"","X-IBM-SpamModules-Versions":"BY=3.00007670; HX=3.00000241; KW=3.00000007;\n\tPH=3.00000004; SC=3.00000226; SDB=6.00912572; UDB=6.00457934;\n\tIPR=6.00692835; \n\tBA=6.00005572; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009;\n\tZB=6.00000000; \n\tZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00017015;\n\tXFM=3.00000015; UTC=2017-09-05 11:45:42","X-IBM-AV-DETECTION":"SAVI=unused REMOTE=unused XFE=unused","x-cbparentid":"17090511-0005-0000-0000-000080FDFB94","Message-Id":"<87bmmpe5d2.fsf@linux.vnet.ibm.com>","X-Proofpoint-Virus-Version":"vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-09-05_06:, , signatures=0","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n\tspamscore=0 suspectscore=1\n\tmalwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam\n\tadjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000\n\tdefinitions=main-1709050179","Subject":"Re: [Skiboot] [PATCH] capi: Mask Psl Credit timeout error for P9","X-BeenThere":"skiboot@lists.ozlabs.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"Mailing list for skiboot development <skiboot.lists.ozlabs.org>","List-Unsubscribe":"<https://lists.ozlabs.org/options/skiboot>,\n\t<mailto:skiboot-request@lists.ozlabs.org?subject=unsubscribe>","List-Archive":"<http://lists.ozlabs.org/pipermail/skiboot/>","List-Post":"<mailto:skiboot@lists.ozlabs.org>","List-Help":"<mailto:skiboot-request@lists.ozlabs.org?subject=help>","List-Subscribe":"<https://lists.ozlabs.org/listinfo/skiboot>,\n\t<mailto:skiboot-request@lists.ozlabs.org?subject=subscribe>","Cc":"Philippe Bergheaud <philippe.bergheaud@fr.ibm.com>,\n\tAndrew Donnellan <andrew.donnellan@au1.ibm.com>","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org","Sender":"\"Skiboot\"\n\t<skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org>"}},{"id":1763837,"web_url":"http://patchwork.ozlabs.org/comment/1763837/","msgid":"<87zia89vcb.fsf@vajain21.in.ibm.com>","list_archive_url":null,"date":"2017-09-06T06:47:48","subject":"Re: [Skiboot] [PATCH] capi: Mask Psl Credit timeout error for P9","submitter":{"id":66174,"url":"http://patchwork.ozlabs.org/api/people/66174/","name":"Vaibhav Jain","email":"vaibhav@linux.vnet.ibm.com"},"content":"Stewart Smith <stewart@linux.vnet.ibm.com> writes:\n\n>> +\t/* Mask the CAPP PSL Credit Timeout Register error */\n>> +\txscom_read(p->chip_id, CAPP_FIR_MASK + offset, &reg);\n>> +\treg |= PPC_BIT(46);\n>> +\txscom_write(p->chip_id, CAPP_FIR_MASK + offset, reg);\n>> +\n>>  \t/* Deassert TLBI_FENCED and tlbi_psl_is_dead */\n>>  \txscom_write(p->chip_id, CAPP_ERR_STATUS_CTRL + offset, 0);\n>\n> This looks like a prime candidate for xscom_write_mask() that Alistair\n> introduced in:\n\nThanks for pointing to this new function Steward. I will send a v2 with\nthe update.","headers":{"Return-Path":"<skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org>","X-Original-To":["incoming@patchwork.ozlabs.org","skiboot@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","skiboot@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xnDgH3C8mz9sNd\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed,  6 Sep 2017 16:48:11 +1000 (AEST)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3xnDgH2N4xzDrSB\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed,  6 Sep 2017 16:48:11 +1000 (AEST)","from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com\n\t[148.163.158.5])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3xnDg62GytzDrJL\n\tfor <skiboot@lists.ozlabs.org>; Wed,  6 Sep 2017 16:48:00 +1000 (AEST)","from pps.filterd (m0098416.ppops.net [127.0.0.1])\n\tby mx0b-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id\n\tv866jDR4189684\n\tfor <skiboot@lists.ozlabs.org>; Wed, 6 Sep 2017 02:47:57 -0400","from e23smtp01.au.ibm.com (e23smtp01.au.ibm.com [202.81.31.143])\n\tby mx0b-001b2d01.pphosted.com with ESMTP id 2ctc14r410-1\n\t(version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT)\n\tfor <skiboot@lists.ozlabs.org>; Wed, 06 Sep 2017 02:47:57 -0400","from localhost\n\tby e23smtp01.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use\n\tOnly! Violators will be prosecuted\n\tfor <skiboot@lists.ozlabs.org> from <vaibhav@linux.vnet.ibm.com>;\n\tWed, 6 Sep 2017 16:47:54 +1000","from d23relay10.au.ibm.com (202.81.31.229)\n\tby e23smtp01.au.ibm.com (202.81.31.207) with IBM ESMTP SMTP Gateway:\n\tAuthorized Use Only! Violators will be prosecuted; \n\tWed, 6 Sep 2017 16:47:53 +1000","from d23av05.au.ibm.com (d23av05.au.ibm.com [9.190.234.119])\n\tby d23relay10.au.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id\n\tv866lrdH40108280\n\tfor <skiboot@lists.ozlabs.org>; Wed, 6 Sep 2017 16:47:53 +1000","from d23av05.au.ibm.com (localhost [127.0.0.1])\n\tby d23av05.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id\n\tv866lqxY025628\n\tfor <skiboot@lists.ozlabs.org>; Wed, 6 Sep 2017 16:47:53 +1000","from vajain21.in.ibm.com (vajain21.in.ibm.com [9.124.35.21])\n\tby d23av05.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with SMTP id\n\tv866lnkW025514; Wed, 6 Sep 2017 16:47:49 +1000","by vajain21.in.ibm.com (sSMTP sendmail emulation);\n\tWed, 06 Sep 2017 12:17:48 +0530"],"Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=linux.vnet.ibm.com\n\t(client-ip=148.163.158.5; helo=mx0a-001b2d01.pphosted.com;\n\tenvelope-from=vaibhav@linux.vnet.ibm.com; receiver=<UNKNOWN>)","From":"Vaibhav Jain <vaibhav@linux.vnet.ibm.com>","To":"Stewart Smith <stewart@linux.vnet.ibm.com>, skiboot@lists.ozlabs.org,\n\tChristophe Lombard <christophe_lombard@fr.ibm.com>","In-Reply-To":"<87bmmpe5d2.fsf@linux.vnet.ibm.com>","References":"<20170905113156.2851-1-vaibhav@linux.vnet.ibm.com>\n\t<87bmmpe5d2.fsf@linux.vnet.ibm.com>","Date":"Wed, 06 Sep 2017 12:17:48 +0530","MIME-Version":"1.0","X-TM-AS-MML":"disable","x-cbid":"17090606-1617-0000-0000-000001FDD33D","X-IBM-AV-DETECTION":"SAVI=unused REMOTE=unused XFE=unused","x-cbparentid":"17090606-1618-0000-0000-0000484A89F0","Message-Id":"<87zia89vcb.fsf@vajain21.in.ibm.com>","X-Proofpoint-Virus-Version":"vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-09-06_02:, , signatures=0","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n\tspamscore=0 suspectscore=1\n\tmalwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam\n\tadjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000\n\tdefinitions=main-1709060091","Subject":"Re: [Skiboot] [PATCH] capi: Mask Psl Credit timeout error for P9","X-BeenThere":"skiboot@lists.ozlabs.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"Mailing list for skiboot development <skiboot.lists.ozlabs.org>","List-Unsubscribe":"<https://lists.ozlabs.org/options/skiboot>,\n\t<mailto:skiboot-request@lists.ozlabs.org?subject=unsubscribe>","List-Archive":"<http://lists.ozlabs.org/pipermail/skiboot/>","List-Post":"<mailto:skiboot@lists.ozlabs.org>","List-Help":"<mailto:skiboot-request@lists.ozlabs.org?subject=help>","List-Subscribe":"<https://lists.ozlabs.org/listinfo/skiboot>,\n\t<mailto:skiboot-request@lists.ozlabs.org?subject=subscribe>","Cc":"Philippe Bergheaud <philippe.bergheaud@fr.ibm.com>,\n\tAndrew Donnellan <andrew.donnellan@au1.ibm.com>","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org","Sender":"\"Skiboot\"\n\t<skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org>"}},{"id":1763948,"web_url":"http://patchwork.ozlabs.org/comment/1763948/","msgid":"<bb6d993a-68a6-2a11-7b6a-8bf2ac54cb1d@au1.ibm.com>","list_archive_url":null,"date":"2017-09-06T09:22:19","subject":"Re: [Skiboot] [PATCH] capi: Mask Psl Credit timeout error for P9","submitter":{"id":66955,"url":"http://patchwork.ozlabs.org/api/people/66955/","name":"Andrew Donnellan","email":"andrew.donnellan@au1.ibm.com"},"content":"On 05/09/17 21:45, Stewart Smith wrote:\n> This looks like a prime candidate for xscom_write_mask() that Alistair\n> introduced in:\n> commit e3f7d42c77bfc3b899d3d636b372e1292b790656\n> Author: Alistair Popple <alistair@popple.id.au>\n> Date:   Fri Aug 4 14:15:19 2017 +1000\n> \n>      xscom: Add xscom_write_mask() function\n>      \n>      It is common for xscom registers to only contain specific bit fields that\n>      need to be modified without altering the rest of the register. This adds a\n>      convenience function to perform xscom read-modify-write operations under a\n>      mask.\n> \n> \n\n\nHmm, I wonder if Coccinelle could help here...","headers":{"Return-Path":"<skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org>","X-Original-To":["incoming@patchwork.ozlabs.org","skiboot@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","skiboot@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xnJ5Q5SWVz9s82\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed,  6 Sep 2017 19:22:34 +1000 (AEST)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3xnJ5Q4cWzzDrJq\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed,  6 Sep 2017 19:22:34 +1000 (AEST)","from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com\n\t[148.163.158.5])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3xnJ5J4FpYzDrJZ\n\tfor <skiboot@lists.ozlabs.org>; Wed,  6 Sep 2017 19:22:27 +1000 (AEST)","from pps.filterd (m0098417.ppops.net [127.0.0.1])\n\tby mx0a-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id\n\tv869KYoE135611\n\tfor <skiboot@lists.ozlabs.org>; Wed, 6 Sep 2017 05:22:25 -0400","from e23smtp02.au.ibm.com (e23smtp02.au.ibm.com [202.81.31.144])\n\tby mx0a-001b2d01.pphosted.com with ESMTP id 2ctc04y4fu-1\n\t(version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT)\n\tfor <skiboot@lists.ozlabs.org>; Wed, 06 Sep 2017 05:22:24 -0400","from localhost\n\tby e23smtp02.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use\n\tOnly! Violators will be prosecuted\n\tfor <skiboot@lists.ozlabs.org> from <andrew.donnellan@au1.ibm.com>;\n\tWed, 6 Sep 2017 19:22:22 +1000","from d23relay06.au.ibm.com (202.81.31.225)\n\tby e23smtp02.au.ibm.com (202.81.31.208) with IBM ESMTP SMTP Gateway:\n\tAuthorized Use Only! Violators will be prosecuted; \n\tWed, 6 Sep 2017 19:22:21 +1000","from d23av01.au.ibm.com (d23av01.au.ibm.com [9.190.234.96])\n\tby d23relay06.au.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id\n\tv869MK5P40698068\n\tfor <skiboot@lists.ozlabs.org>; Wed, 6 Sep 2017 19:22:20 +1000","from d23av01.au.ibm.com (localhost [127.0.0.1])\n\tby d23av01.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id\n\tv869MK9Q004409\n\tfor <skiboot@lists.ozlabs.org>; Wed, 6 Sep 2017 19:22:20 +1000","from ozlabs.au.ibm.com (ozlabs.au.ibm.com [9.192.253.14])\n\tby d23av01.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id\n\tv869MK9c004401; Wed, 6 Sep 2017 19:22:20 +1000","from [10.61.2.125] (haven.au.ibm.com [9.192.254.114])\n\t(using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits))\n\t(No client certificate requested)\n\tby ozlabs.au.ibm.com (Postfix) with ESMTPSA id B9B58A0117;\n\tWed,  6 Sep 2017 19:22:19 +1000 (AEST)"],"Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=au1.ibm.com\n\t(client-ip=148.163.158.5; helo=mx0a-001b2d01.pphosted.com;\n\tenvelope-from=andrew.donnellan@au1.ibm.com; receiver=<UNKNOWN>)","To":"Stewart Smith <stewart@linux.vnet.ibm.com>,\n\tVaibhav Jain <vaibhav@linux.vnet.ibm.com>, skiboot@lists.ozlabs.org, \n\tChristophe Lombard <christophe_lombard@fr.ibm.com>","References":"<20170905113156.2851-1-vaibhav@linux.vnet.ibm.com>\n\t<87bmmpe5d2.fsf@linux.vnet.ibm.com>","From":"Andrew Donnellan <andrew.donnellan@au1.ibm.com>","Date":"Wed, 6 Sep 2017 19:22:19 +1000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<87bmmpe5d2.fsf@linux.vnet.ibm.com>","Content-Language":"en-AU","X-TM-AS-MML":"disable","x-cbid":"17090609-0004-0000-0000-0000022C2A1F","X-IBM-AV-DETECTION":"SAVI=unused REMOTE=unused XFE=unused","x-cbparentid":"17090609-0005-0000-0000-00005E13401F","Message-Id":"<bb6d993a-68a6-2a11-7b6a-8bf2ac54cb1d@au1.ibm.com>","X-Proofpoint-Virus-Version":"vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-09-06_03:, , signatures=0","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n\tspamscore=0 suspectscore=0\n\tmalwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam\n\tadjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000\n\tdefinitions=main-1709060128","Subject":"Re: [Skiboot] [PATCH] capi: Mask Psl Credit timeout error for P9","X-BeenThere":"skiboot@lists.ozlabs.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"Mailing list for skiboot development <skiboot.lists.ozlabs.org>","List-Unsubscribe":"<https://lists.ozlabs.org/options/skiboot>,\n\t<mailto:skiboot-request@lists.ozlabs.org?subject=unsubscribe>","List-Archive":"<http://lists.ozlabs.org/pipermail/skiboot/>","List-Post":"<mailto:skiboot@lists.ozlabs.org>","List-Help":"<mailto:skiboot-request@lists.ozlabs.org?subject=help>","List-Subscribe":"<https://lists.ozlabs.org/listinfo/skiboot>,\n\t<mailto:skiboot-request@lists.ozlabs.org?subject=subscribe>","Cc":"Philippe Bergheaud <philippe.bergheaud@fr.ibm.com>","Content-Transfer-Encoding":"base64","Content-Type":"text/plain; charset=\"utf-8\"; Format=\"flowed\"","Errors-To":"skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org","Sender":"\"Skiboot\"\n\t<skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org>"}},{"id":1764523,"web_url":"http://patchwork.ozlabs.org/comment/1764523/","msgid":"<87o9qnniqx.fsf@linux.vnet.ibm.com>","list_archive_url":null,"date":"2017-09-07T06:08:22","subject":"Re: [Skiboot] [PATCH] capi: Mask Psl Credit timeout error for P9","submitter":{"id":48041,"url":"http://patchwork.ozlabs.org/api/people/48041/","name":"Stewart Smith","email":"stewart@linux.vnet.ibm.com"},"content":"Andrew Donnellan <andrew.donnellan@au1.ibm.com> writes:\n> On 05/09/17 21:45, Stewart Smith wrote:\n>> This looks like a prime candidate for xscom_write_mask() that Alistair\n>> introduced in:\n>> commit e3f7d42c77bfc3b899d3d636b372e1292b790656\n>> Author: Alistair Popple <alistair@popple.id.au>\n>> Date:   Fri Aug 4 14:15:19 2017 +1000\n>> \n>>      xscom: Add xscom_write_mask() function\n>>      \n>>      It is common for xscom registers to only contain specific bit fields that\n>>      need to be modified without altering the rest of the register. This adds a\n>>      convenience function to perform xscom read-modify-write operations under a\n>>      mask.\n>> \n>> \n>\n>\n> Hmm, I wonder if Coccinelle could help here...\n\nYeah, it could. I've started to poke at it a bit more, but I'm not\nconvinced I would get it right for\nnot-directly-copying-and-hacking-a-trivial-example yet :)","headers":{"Return-Path":"<skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org>","X-Original-To":["incoming@patchwork.ozlabs.org","skiboot@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","skiboot@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xnqlP0D0Gz9sRV\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu,  7 Sep 2017 16:08:49 +1000 (AEST)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3xnqlN6H4xzDrWS\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu,  7 Sep 2017 16:08:48 +1000 (AEST)","from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com\n\t[148.163.156.1])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3xnqlD0D53zDrVp\n\tfor <skiboot@lists.ozlabs.org>; Thu,  7 Sep 2017 16:08:39 +1000 (AEST)","from pps.filterd (m0098394.ppops.net [127.0.0.1])\n\tby mx0a-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id\n\tv8768AlS038326\n\tfor <skiboot@lists.ozlabs.org>; Thu, 7 Sep 2017 02:08:36 -0400","from e19.ny.us.ibm.com (e19.ny.us.ibm.com [129.33.205.209])\n\tby mx0a-001b2d01.pphosted.com with ESMTP id 2ctxspc9rg-1\n\t(version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT)\n\tfor <skiboot@lists.ozlabs.org>; Thu, 07 Sep 2017 02:08:36 -0400","from localhost\n\tby e19.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use\n\tOnly! Violators will be prosecuted\n\tfor <skiboot@lists.ozlabs.org> from <stewart@linux.vnet.ibm.com>;\n\tThu, 7 Sep 2017 02:08:35 -0400","from b01cxnp22033.gho.pok.ibm.com (9.57.198.23)\n\tby e19.ny.us.ibm.com (146.89.104.206) with IBM ESMTP SMTP Gateway:\n\tAuthorized Use Only! Violators will be prosecuted; \n\tThu, 7 Sep 2017 02:08:32 -0400","from b01ledav006.gho.pok.ibm.com (b01ledav006.gho.pok.ibm.com\n\t[9.57.199.111])\n\tby b01cxnp22033.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP\n\tid v8768S6B24248512; Thu, 7 Sep 2017 06:08:28 GMT","from b01ledav006.gho.pok.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id 88693AC040;\n\tThu,  7 Sep 2017 02:08:55 -0400 (EDT)","from birb.localdomain (unknown [9.192.255.220])\n\tby b01ledav006.gho.pok.ibm.com (Postfix) with ESMTP id F1054AC03A;\n\tThu,  7 Sep 2017 02:08:54 -0400 (EDT)","by birb.localdomain (Postfix, from userid 1000)\n\tid 9679B4E87E0; Thu,  7 Sep 2017 16:08:22 +1000 (AEST)"],"Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=linux.vnet.ibm.com\n\t(client-ip=148.163.156.1; helo=mx0a-001b2d01.pphosted.com;\n\tenvelope-from=stewart@linux.vnet.ibm.com; receiver=<UNKNOWN>)","From":"Stewart Smith <stewart@linux.vnet.ibm.com>","To":"Andrew Donnellan <andrew.donnellan@au1.ibm.com>,\n\tVaibhav Jain <vaibhav@linux.vnet.ibm.com>, skiboot@lists.ozlabs.org, \n\tChristophe Lombard <christophe_lombard@fr.ibm.com>","In-Reply-To":"<bb6d993a-68a6-2a11-7b6a-8bf2ac54cb1d@au1.ibm.com>","References":"<20170905113156.2851-1-vaibhav@linux.vnet.ibm.com>\n\t<87bmmpe5d2.fsf@linux.vnet.ibm.com>\n\t<bb6d993a-68a6-2a11-7b6a-8bf2ac54cb1d@au1.ibm.com>","Date":"Thu, 07 Sep 2017 16:08:22 +1000","MIME-Version":"1.0","X-TM-AS-GCONF":"00","x-cbid":"17090706-0056-0000-0000-000003C48E5C","X-IBM-SpamModules-Scores":"","X-IBM-SpamModules-Versions":"BY=3.00007681; HX=3.00000241; KW=3.00000007;\n\tPH=3.00000004; SC=3.00000226; SDB=6.00913420; UDB=6.00458441;\n\tIPR=6.00693678; \n\tBA=6.00005574; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009;\n\tZB=6.00000000; \n\tZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00017045;\n\tXFM=3.00000015; UTC=2017-09-07 06:08:33","X-IBM-AV-DETECTION":"SAVI=unused REMOTE=unused XFE=unused","x-cbparentid":"17090706-0057-0000-0000-000007FB8E66","Message-Id":"<87o9qnniqx.fsf@linux.vnet.ibm.com>","X-Proofpoint-Virus-Version":"vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-09-07_04:, , signatures=0","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n\tspamscore=0 suspectscore=1\n\tmalwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam\n\tadjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000\n\tdefinitions=main-1709070089","Subject":"Re: [Skiboot] [PATCH] capi: Mask Psl Credit timeout error for P9","X-BeenThere":"skiboot@lists.ozlabs.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"Mailing list for skiboot development <skiboot.lists.ozlabs.org>","List-Unsubscribe":"<https://lists.ozlabs.org/options/skiboot>,\n\t<mailto:skiboot-request@lists.ozlabs.org?subject=unsubscribe>","List-Archive":"<http://lists.ozlabs.org/pipermail/skiboot/>","List-Post":"<mailto:skiboot@lists.ozlabs.org>","List-Help":"<mailto:skiboot-request@lists.ozlabs.org?subject=help>","List-Subscribe":"<https://lists.ozlabs.org/listinfo/skiboot>,\n\t<mailto:skiboot-request@lists.ozlabs.org?subject=subscribe>","Cc":"Philippe Bergheaud <philippe.bergheaud@fr.ibm.com>","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org","Sender":"\"Skiboot\"\n\t<skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org>"}}]