[{"id":1763209,"web_url":"http://patchwork.ozlabs.org/comment/1763209/","msgid":"<20170905115948.2fd38785@cakuba.netronome.com>","list_archive_url":null,"date":"2017-09-05T10:59:48","subject":"Re: [PATCH net] net: sched: don't use GFP_KERNEL under spin lock","submitter":{"id":17220,"url":"http://patchwork.ozlabs.org/api/people/17220/","name":"Jakub Kicinski","email":"kubakici@wp.pl"},"content":"Jiri, FWIW I also just noticed these, but they seem related to the\nearlier TC chain work?\n\nunreferenced object 0xffff8807466f70c8 (size 64):\n comm \"tc\", pid 1812, jiffies 4294932641 (age 1537.192s)\n hex dump (first 32 bytes):\n 00 00 00 00 00 00 00 00 a0 83 e1 31 07 88 ff ff ...........1....\n d8 70 6f 46 07 88 ff ff d8 70 6f 46 07 88 ff ff .poF.....poF....\n backtrace:\n [] kmemleak_alloc+0x28/0x50\n [] kmem_cache_alloc_trace+0x1e6/0x550\n [] tcf_chain_create+0x97/0x460\n [] tcf_block_get+0x127/0x230\n [] ingress_init+0x76/0x110 [sch_ingress]\n [] qdisc_create+0x2ec/0x1100\n [] tc_modify_qdisc+0x4ea/0x1ae0\n [] rtnetlink_rcv_msg+0xa3c/0x1400\n [] netlink_rcv_skb+0x22b/0x4e0\n [] rtnetlink_rcv+0x15/0x20\n [] netlink_unicast+0x47d/0x710\n [] netlink_sendmsg+0xa7f/0x1140\n [] sock_sendmsg+0xe2/0x170\n [] ___sys_sendmsg+0x72d/0xcc0\n [] __sys_sendmsg+0xe2/0x260\n [] SyS_sendmsg+0x12/0x20\nunreferenced object 0xffff88074db6c008 (size 64):\n comm \"tc\", pid 2097, jiffies 4294953636 (age 1453.212s)\n hex dump (first 32 bytes):\n 00 00 00 00 00 00 00 00 60 a6 d1 31 07 88 ff ff ........`..1....\n 18 c0 b6 4d 07 88 ff ff 18 c0 b6 4d 07 88 ff ff ...M.......M....\n backtrace:\n [] kmemleak_alloc+0x28/0x50\n [] kmem_cache_alloc_trace+0x1e6/0x550\n [] tcf_chain_create+0x97/0x460\n [] tcf_block_get+0x127/0x230\n [] ingress_init+0x76/0x110 [sch_ingress]\n [] qdisc_create+0x2ec/0x1100\n [] tc_modify_qdisc+0x4ea/0x1ae0\n [] rtnetlink_rcv_msg+0xa3c/0x1400\n [] netlink_rcv_skb+0x22b/0x4e0\n [] rtnetlink_rcv+0x15/0x20\n [] netlink_unicast+0x47d/0x710\n [] netlink_sendmsg+0xa7f/0x1140\n [] sock_sendmsg+0xe2/0x170\n [] ___sys_sendmsg+0x72d/0xcc0\n [] __sys_sendmsg+0xe2/0x260\n [] SyS_sendmsg+0x12/0x20\nunreferenced object 0xffff880749f82a48 (size 64):\n comm \"tc\", pid 2381, jiffies 4294972986 (age 1375.812s)\n hex dump (first 32 bytes):\n 00 00 00 00 00 00 00 00 c0 b7 31 31 07 88 ff ff ..........11....\n 58 2a f8 49 07 88 ff ff 58 2a f8 49 07 88 ff ff X*.I....X*.I....\n backtrace:\n [] kmemleak_alloc+0x28/0x50\n [] kmem_cache_alloc_trace+0x1e6/0x550\n [] tcf_chain_create+0x97/0x460\n [] tcf_block_get+0x127/0x230\n [] ingress_init+0x76/0x110 [sch_ingress]\n [] qdisc_create+0x2ec/0x1100\n [] tc_modify_qdisc+0x4ea/0x1ae0\n [] rtnetlink_rcv_msg+0xa3c/0x1400\n [] netlink_rcv_skb+0x22b/0x4e0\n [] rtnetlink_rcv+0x15/0x20\n [] netlink_unicast+0x47d/0x710\n [] netlink_sendmsg+0xa7f/0x1140\n [] sock_sendmsg+0xe2/0x170\n [] ___sys_sendmsg+0x72d/0xcc0\n [] __sys_sendmsg+0xe2/0x260\n [] SyS_sendmsg+0x12/0x20\nunreferenced object 0xffff8803fd855a08 (size 64):\n comm \"tc\", pid 2663, jiffies 4294992152 (age 1299.328s)\n hex dump (first 32 bytes):\n 00 00 00 00 00 00 00 00 20 49 80 31 07 88 ff ff ........ I.1....\n 18 5a 85 fd 03 88 ff ff 18 5a 85 fd 03 88 ff ff .Z.......Z......\n backtrace:\n [] kmemleak_alloc+0x28/0x50\n [] kmem_cache_alloc_trace+0x1e6/0x550\n [] tcf_chain_create+0x97/0x460\n [] tcf_block_get+0x127/0x230\n [] ingress_init+0x76/0x110 [sch_ingress]\n [] qdisc_create+0x2ec/0x1100\n [] tc_modify_qdisc+0x4ea/0x1ae0\n [] rtnetlink_rcv_msg+0xa3c/0x1400\n [] netlink_rcv_skb+0x22b/0x4e0\n [] rtnetlink_rcv+0x15/0x20\n [] netlink_unicast+0x47d/0x710\n [] netlink_sendmsg+0xa7f/0x1140\n [] sock_sendmsg+0xe2/0x170\n [] ___sys_sendmsg+0x72d/0xcc0\n [] __sys_sendmsg+0xe2/0x260\n [] SyS_sendmsg+0x12/0x20\nunreferenced object 0xffff88071b096f28 (size 64):\n comm \"tc\", pid 2943, jiffies 4295013397 (age 1214.352s)\n hex dump (first 32 bytes):\n 00 00 00 00 00 00 00 00 c0 37 e7 30 07 88 ff ff .........7.0....\n 38 6f 09 1b 07 88 ff ff 38 6f 09 1b 07 88 ff ff 8o......8o......\n backtrace:\n [] kmemleak_alloc+0x28/0x50\n [] kmem_cache_alloc_trace+0x1e6/0x550\n [] tcf_chain_create+0x97/0x460\n [] tcf_block_get+0x127/0x230\n [] ingress_init+0x76/0x110 [sch_ingress]\n [] qdisc_create+0x2ec/0x1100\n [] tc_modify_qdisc+0x4ea/0x1ae0\n [] rtnetlink_rcv_msg+0xa3c/0x1400\n [] netlink_rcv_skb+0x22b/0x4e0\n [] rtnetlink_rcv+0x15/0x20\n [] netlink_unicast+0x47d/0x710\n [] netlink_sendmsg+0xa7f/0x1140\n [] sock_sendmsg+0xe2/0x170\n [] ___sys_sendmsg+0x72d/0xcc0\n [] __sys_sendmsg+0xe2/0x260\n [] SyS_sendmsg+0x12/0x20\nunreferenced object 0xffff880731f66568 (size 64):\n comm \"tc\", pid 3263, jiffies 4295033366 (age 1134.480s)\n hex dump (first 32 bytes):\n 00 00 00 00 00 00 00 00 00 95 64 65 07 88 ff ff ..........de....\n 78 65 f6 31 07 88 ff ff 78 65 f6 31 07 88 ff ff xe.1....xe.1....\n backtrace:\n [] kmemleak_alloc+0x28/0x50\n [] kmem_cache_alloc_trace+0x1e6/0x550\n [] tcf_chain_create+0x97/0x460\n [] tcf_block_get+0x127/0x230\n [] ingress_init+0x76/0x110 [sch_ingress]\n [] qdisc_create+0x2ec/0x1100\n [] tc_modify_qdisc+0x4ea/0x1ae0\n [] rtnetlink_rcv_msg+0xa3c/0x1400\n [] netlink_rcv_skb+0x22b/0x4e0\n [] rtnetlink_rcv+0x15/0x20\n [] netlink_unicast+0x47d/0x710\n [] netlink_sendmsg+0xa7f/0x1140\n [] sock_sendmsg+0xe2/0x170\n [] ___sys_sendmsg+0x72d/0xcc0\n [] __sys_sendmsg+0xe2/0x260\n [] SyS_sendmsg+0x12/0x20","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=wp.pl header.i=@wp.pl header.b=\"S/ySCmii\";\n\tdkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xmkJD74ypz9sP3\n\tfor ;\n\tTue, 5 Sep 2017 20:59:56 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751129AbdIEK7z (ORCPT );\n\tTue, 5 Sep 2017 06:59:55 -0400","from mx3.wp.pl ([212.77.101.9]:32981 \"EHLO mx3.wp.pl\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1750748AbdIEK7y (ORCPT );\n\tTue, 5 Sep 2017 06:59:54 -0400","(wp-smtpd smtp.wp.pl 23872 invoked from network);\n\t5 Sep 2017 12:59:51 +0200","from host-79-78-33-110.static.as9105.net (HELO\n\tcakuba.netronome.com) (kubakici@wp.pl@[79.78.33.110])\n\t(envelope-sender )\n\tby smtp.wp.pl (WP-SMTPD) with ECDHE-RSA-AES256-GCM-SHA384 encrypted\n\tSMTP for ; 5 Sep 2017 12:59:51 +0200"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=wp.pl; s=1024a;\n\tt=1504609191; bh=3xB0aK5A6rt/z4jGyYxXZEN8fvAGP8AouF4H3sgkwu0=;\n\th=From:To:Cc:Subject;\n\tb=S/ySCmiiljlKpO+DTdndwVaJ+36gzrGqytftKCTR3HnuV63lpvHElxymYl8aHvTwv\n\t22p8oUqeMzL3Bgmtf64vO+69xWqTEjsfTE1og4AHAibUQVyOdMRiH3nDhNdJAh/QSm\n\tL9ii5C549Pssh7oAvJJRNP9bQLbUDt24XUdAziSE=","Date":"Tue, 5 Sep 2017 11:59:48 +0100","From":"Jakub Kicinski ","To":"netdev@vger.kernel.org","Cc":"jiri@resnulli.us, oss-drivers@netronome.com","Subject":"Re: [PATCH net] net: sched: don't use GFP_KERNEL under spin lock","Message-ID":"<20170905115948.2fd38785@cakuba.netronome.com>","In-Reply-To":"<20170905105442.30972-1-jakub.kicinski@netronome.com>","References":"<20170905105442.30972-1-jakub.kicinski@netronome.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=US-ASCII","Content-Transfer-Encoding":"7bit","X-WP-MailID":"006633e296eb3687ffeeac2d09b31650","X-WP-AV":"skaner antywirusowy Poczty Wirtualnej Polski","X-WP-SPAM":"NO 000000A [saNk] ","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1763322,"web_url":"http://patchwork.ozlabs.org/comment/1763322/","msgid":"<20170905125221.GA7936@nanopsycho>","list_archive_url":null,"date":"2017-09-05T12:52:21","subject":"Re: [PATCH net] net: sched: don't use GFP_KERNEL under spin lock","submitter":{"id":15321,"url":"http://patchwork.ozlabs.org/api/people/15321/","name":"Jiri Pirko","email":"jiri@resnulli.us"},"content":"Tue, Sep 05, 2017 at 12:59:48PM CEST, kubakici@wp.pl wrote:\n>Jiri, FWIW I also just noticed these, but they seem related to the\n>earlier TC chain work?\n\nWhat do you do to trigger this?\n\n>\n>unreferenced object 0xffff8807466f70c8 (size 64):\n> comm \"tc\", pid 1812, jiffies 4294932641 (age 1537.192s)\n> hex dump (first 32 bytes):\n> 00 00 00 00 00 00 00 00 a0 83 e1 31 07 88 ff ff ...........1....\n> d8 70 6f 46 07 88 ff ff d8 70 6f 46 07 88 ff ff .poF.....poF....\n> backtrace:\n> [] kmemleak_alloc+0x28/0x50\n> [] kmem_cache_alloc_trace+0x1e6/0x550\n> [] tcf_chain_create+0x97/0x460\n> [] tcf_block_get+0x127/0x230\n> [] ingress_init+0x76/0x110 [sch_ingress]\n> [] qdisc_create+0x2ec/0x1100\n> [] tc_modify_qdisc+0x4ea/0x1ae0\n> [] rtnetlink_rcv_msg+0xa3c/0x1400\n> [] netlink_rcv_skb+0x22b/0x4e0\n> [] rtnetlink_rcv+0x15/0x20\n> [] netlink_unicast+0x47d/0x710\n> [] netlink_sendmsg+0xa7f/0x1140\n> [] sock_sendmsg+0xe2/0x170\n> [] ___sys_sendmsg+0x72d/0xcc0\n> [] __sys_sendmsg+0xe2/0x260\n> [] SyS_sendmsg+0x12/0x20\n>unreferenced object 0xffff88074db6c008 (size 64):\n> comm \"tc\", pid 2097, jiffies 4294953636 (age 1453.212s)\n> hex dump (first 32 bytes):\n> 00 00 00 00 00 00 00 00 60 a6 d1 31 07 88 ff ff ........`..1....\n> 18 c0 b6 4d 07 88 ff ff 18 c0 b6 4d 07 88 ff ff ...M.......M....\n> backtrace:\n> [] kmemleak_alloc+0x28/0x50\n> [] kmem_cache_alloc_trace+0x1e6/0x550\n> [] tcf_chain_create+0x97/0x460\n> [] tcf_block_get+0x127/0x230\n> [] ingress_init+0x76/0x110 [sch_ingress]\n> [] qdisc_create+0x2ec/0x1100\n> [] tc_modify_qdisc+0x4ea/0x1ae0\n> [] rtnetlink_rcv_msg+0xa3c/0x1400\n> [] netlink_rcv_skb+0x22b/0x4e0\n> [] rtnetlink_rcv+0x15/0x20\n> [] netlink_unicast+0x47d/0x710\n> [] netlink_sendmsg+0xa7f/0x1140\n> [] sock_sendmsg+0xe2/0x170\n> [] ___sys_sendmsg+0x72d/0xcc0\n> [] __sys_sendmsg+0xe2/0x260\n> [] SyS_sendmsg+0x12/0x20\n>unreferenced object 0xffff880749f82a48 (size 64):\n> comm \"tc\", pid 2381, jiffies 4294972986 (age 1375.812s)\n> hex dump (first 32 bytes):\n> 00 00 00 00 00 00 00 00 c0 b7 31 31 07 88 ff ff ..........11....\n> 58 2a f8 49 07 88 ff ff 58 2a f8 49 07 88 ff ff X*.I....X*.I....\n> backtrace:\n> [] kmemleak_alloc+0x28/0x50\n> [] kmem_cache_alloc_trace+0x1e6/0x550\n> [] tcf_chain_create+0x97/0x460\n> [] tcf_block_get+0x127/0x230\n> [] ingress_init+0x76/0x110 [sch_ingress]\n> [] qdisc_create+0x2ec/0x1100\n> [] tc_modify_qdisc+0x4ea/0x1ae0\n> [] rtnetlink_rcv_msg+0xa3c/0x1400\n> [] netlink_rcv_skb+0x22b/0x4e0\n> [] rtnetlink_rcv+0x15/0x20\n> [] netlink_unicast+0x47d/0x710\n> [] netlink_sendmsg+0xa7f/0x1140\n> [] sock_sendmsg+0xe2/0x170\n> [] ___sys_sendmsg+0x72d/0xcc0\n> [] __sys_sendmsg+0xe2/0x260\n> [] SyS_sendmsg+0x12/0x20\n>unreferenced object 0xffff8803fd855a08 (size 64):\n> comm \"tc\", pid 2663, jiffies 4294992152 (age 1299.328s)\n> hex dump (first 32 bytes):\n> 00 00 00 00 00 00 00 00 20 49 80 31 07 88 ff ff ........ I.1....\n> 18 5a 85 fd 03 88 ff ff 18 5a 85 fd 03 88 ff ff .Z.......Z......\n> backtrace:\n> [] kmemleak_alloc+0x28/0x50\n> [] kmem_cache_alloc_trace+0x1e6/0x550\n> [] tcf_chain_create+0x97/0x460\n> [] tcf_block_get+0x127/0x230\n> [] ingress_init+0x76/0x110 [sch_ingress]\n> [] qdisc_create+0x2ec/0x1100\n> [] tc_modify_qdisc+0x4ea/0x1ae0\n> [] rtnetlink_rcv_msg+0xa3c/0x1400\n> [] netlink_rcv_skb+0x22b/0x4e0\n> [] rtnetlink_rcv+0x15/0x20\n> [] netlink_unicast+0x47d/0x710\n> [] netlink_sendmsg+0xa7f/0x1140\n> [] sock_sendmsg+0xe2/0x170\n> [] ___sys_sendmsg+0x72d/0xcc0\n> [] __sys_sendmsg+0xe2/0x260\n> [] SyS_sendmsg+0x12/0x20\n>unreferenced object 0xffff88071b096f28 (size 64):\n> comm \"tc\", pid 2943, jiffies 4295013397 (age 1214.352s)\n> hex dump (first 32 bytes):\n> 00 00 00 00 00 00 00 00 c0 37 e7 30 07 88 ff ff .........7.0....\n> 38 6f 09 1b 07 88 ff ff 38 6f 09 1b 07 88 ff ff 8o......8o......\n> backtrace:\n> [] kmemleak_alloc+0x28/0x50\n> [] kmem_cache_alloc_trace+0x1e6/0x550\n> [] tcf_chain_create+0x97/0x460\n> [] tcf_block_get+0x127/0x230\n> [] ingress_init+0x76/0x110 [sch_ingress]\n> [] qdisc_create+0x2ec/0x1100\n> [] tc_modify_qdisc+0x4ea/0x1ae0\n> [] rtnetlink_rcv_msg+0xa3c/0x1400\n> [] netlink_rcv_skb+0x22b/0x4e0\n> [] rtnetlink_rcv+0x15/0x20\n> [] netlink_unicast+0x47d/0x710\n> [] netlink_sendmsg+0xa7f/0x1140\n> [] sock_sendmsg+0xe2/0x170\n> [] ___sys_sendmsg+0x72d/0xcc0\n> [] __sys_sendmsg+0xe2/0x260\n> [] SyS_sendmsg+0x12/0x20\n>unreferenced object 0xffff880731f66568 (size 64):\n> comm \"tc\", pid 3263, jiffies 4295033366 (age 1134.480s)\n> hex dump (first 32 bytes):\n> 00 00 00 00 00 00 00 00 00 95 64 65 07 88 ff ff ..........de....\n> 78 65 f6 31 07 88 ff ff 78 65 f6 31 07 88 ff ff xe.1....xe.1....\n> backtrace:\n> [] kmemleak_alloc+0x28/0x50\n> [] kmem_cache_alloc_trace+0x1e6/0x550\n> [] tcf_chain_create+0x97/0x460\n> [] tcf_block_get+0x127/0x230\n> [] ingress_init+0x76/0x110 [sch_ingress]\n> [] qdisc_create+0x2ec/0x1100\n> [] tc_modify_qdisc+0x4ea/0x1ae0\n> [] rtnetlink_rcv_msg+0xa3c/0x1400\n> [] netlink_rcv_skb+0x22b/0x4e0\n> [] rtnetlink_rcv+0x15/0x20\n> [] netlink_unicast+0x47d/0x710\n> [] netlink_sendmsg+0xa7f/0x1140\n> [] sock_sendmsg+0xe2/0x170\n> [] ___sys_sendmsg+0x72d/0xcc0\n> [] __sys_sendmsg+0xe2/0x260\n> [] SyS_sendmsg+0x12/0x20","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=resnulli-us.20150623.gappssmtp.com\n\theader.i=@resnulli-us.20150623.gappssmtp.com\n\theader.b=\"w77X7BrN\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xmmp40SGdz9sRV\n\tfor ;\n\tTue, 5 Sep 2017 22:52:28 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751454AbdIEMw0 (ORCPT );\n\tTue, 5 Sep 2017 08:52:26 -0400","from mail-wr0-f194.google.com ([209.85.128.194]:34381 \"EHLO\n\tmail-wr0-f194.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751002AbdIEMwZ (ORCPT\n\t); Tue, 5 Sep 2017 08:52:25 -0400","by mail-wr0-f194.google.com with SMTP id n33so1453690wrn.1\n\tfor ; Tue, 05 Sep 2017 05:52:24 -0700 (PDT)","from localhost (ip-89-177-125-82.net.upcbroadband.cz.\n\t[89.177.125.82]) by smtp.gmail.com with ESMTPSA id\n\ta69sm272562wme.29.2017.09.05.05.52.22\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tTue, 05 Sep 2017 05:52:22 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=resnulli-us.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:in-reply-to:user-agent;\n\tbh=b6eellusjk8M3t2MTvNsApWWeZuabWVuDMf73PYRNTs=;\n\tb=w77X7BrNsxRn1f7+rxwA47xnf8QxbN1PYWmsuV/iqOEezeu6EH42uAdPvLZPA5aHC7\n\tkJFWJPLPytSyt6vlmDm438ef47TyMyg8xoI1qm8siCCNsDFNacN+Xt/KS0d5g8WJx2b3\n\tFMiLkJkxxOy6JQizcLwiSMPqOSG9RoZeSEWaESFtRxYkexAoRmGo+xQsW13fevLN2yeH\n\tesfP+gOPOZcUB/y+6T7NX5AAKsP/yr9tu8rcZ0z/ONFstnGq1zSNkrEapO6h1nNptdoK\n\tVnMjvr3r6xVY6moSnexqwvVOPZU0V5R6/nbRuGPP04eLM6VTBzZxf4arWn7nBgEc+FQr\n\teYUw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:in-reply-to:user-agent;\n\tbh=b6eellusjk8M3t2MTvNsApWWeZuabWVuDMf73PYRNTs=;\n\tb=sMocxClEDFkvzHCkTDeetDfb0e6DQprgnwPxuYIKTI1KAnrsDwxkD9ZGx1IflsLH3p\n\tMYGQZWMowpUNLL7UAA99ht27tyEoHtsL5UpAuHxIuQ4ZYgrD6JDfCeQhHoRPbVBvXxKw\n\twE8s+bHyO3iayR6cElka2E6EljhHJa3KVXXgilFQNITxb7Oe7RGU7m1+Bz4kEqxJQPe5\n\tGHsPdLyF6urTcDUxbJchcAdmJzQDF1L00NkV3o3I0KBAYbcKEOaNUexqb9kJKWcEYkiQ\n\tFHRHJFrPbmbwu8gKMrs6rp3gHyg7j76t35bwzQE4Q+b04AeUkABNURSHnoafCc5/Tkzj\n\teSKw==","X-Gm-Message-State":"AHPjjUhRK6c6ogERyaJ85EC52vPv0lFlJDa5AHG5DoI1KifHc3IregNm\n\tZdwKSIoTTFX0bDv3","X-Google-Smtp-Source":"ADKCNb7KWwmMblpDEb5O91hjtnT1kSodziYLWtXylPjOF1GQoy8g/4/fCO1BwfO7WIaez7jHvOExKg==","X-Received":"by 10.223.170.137 with SMTP id h9mr2151059wrc.91.1504615943398; \n\tTue, 05 Sep 2017 05:52:23 -0700 (PDT)","Date":"Tue, 5 Sep 2017 14:52:21 +0200","From":"Jiri Pirko ","To":"Jakub Kicinski ","Cc":"netdev@vger.kernel.org, oss-drivers@netronome.com","Subject":"Re: [PATCH net] net: sched: don't use GFP_KERNEL under spin lock","Message-ID":"<20170905125221.GA7936@nanopsycho>","References":"<20170905105442.30972-1-jakub.kicinski@netronome.com>\n\t<20170905115948.2fd38785@cakuba.netronome.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20170905115948.2fd38785@cakuba.netronome.com>","User-Agent":"Mutt/1.8.3 (2017-05-23)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1763388,"web_url":"http://patchwork.ozlabs.org/comment/1763388/","msgid":"<1504620621.15310.39.camel@edumazet-glaptop3.roam.corp.google.com>","list_archive_url":null,"date":"2017-09-05T14:10:21","subject":"Re: [PATCH net] net: sched: don't use GFP_KERNEL under spin lock","submitter":{"id":2404,"url":"http://patchwork.ozlabs.org/api/people/2404/","name":"Eric Dumazet","email":"eric.dumazet@gmail.com"},"content":"On Tue, 2017-09-05 at 03:54 -0700, Jakub Kicinski wrote:\n> The new TC IDR code uses GFP_KERNEL under spinlocks. Which leads\n> to:\n\n> ...\n> \n> Fixes: 65a206c01e8e (\"net/sched: Change act_api and act_xxx modules to use IDR\")\n> Signed-off-by: Jakub Kicinski \n> Reviewed-by: Simon Horman \n> ---\n> net/sched/act_api.c | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/net/sched/act_api.c b/net/sched/act_api.c\n> index 0eb545bcb247..a48e4b45722d 100644\n> --- a/net/sched/act_api.c\n> +++ b/net/sched/act_api.c\n> @@ -298,7 +298,7 @@ int tcf_idr_create(struct tc_action_net *tn, u32 index, struct nlattr *est,\n> \tif (!index) {\n\n\n\t\tidr_preload(GFP_KERNEL);\n\n> \t\tspin_lock_bh(&idrinfo->lock);\n> \t\terr = idr_alloc_ext(idr, NULL, &idr_index, 1, 0,\n> -\t\t\t\t GFP_KERNEL);\n> +\t\t\t\t GFP_ATOMIC);\n> \t\tspin_unlock_bh(&idrinfo->lock);\n> \t\tif (err) {\n> err3:\n> @@ -309,7 +309,7 @@ int tcf_idr_create(struct tc_action_net *tn, u32 index, struct nlattr *est,\n> \t} else {\n\n\t\tidr_preload(GFP_KERNEL);\n\n> \t\tspin_lock_bh(&idrinfo->lock);\n> \t\terr = idr_alloc_ext(idr, NULL, NULL, index, index + 1,\n> -\t\t\t\t GFP_KERNEL);\n> +\t\t\t\t GFP_ATOMIC);\n> \t\tspin_unlock_bh(&idrinfo->lock);\n> \t\tif (err)\n> \t\t\tgoto err3;","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"SjMYq+NY\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xmpX25jYKz9t2R\n\tfor ;\n\tWed, 6 Sep 2017 00:10:26 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751409AbdIEOKY (ORCPT );\n\tTue, 5 Sep 2017 10:10:24 -0400","from mail-pg0-f65.google.com ([74.125.83.65]:34014 \"EHLO\n\tmail-pg0-f65.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751348AbdIEOKX (ORCPT\n\t); Tue, 5 Sep 2017 10:10:23 -0400","by mail-pg0-f65.google.com with SMTP id v82so1412576pgb.1\n\tfor ; Tue, 05 Sep 2017 07:10:23 -0700 (PDT)","from [192.168.86.171] (c-67-180-167-114.hsd1.ca.comcast.net.\n\t[67.180.167.114]) by smtp.googlemail.com with ESMTPSA id\n\td5sm1763526pfg.26.2017.09.05.07.10.22\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tTue, 05 Sep 2017 07:10:22 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=message-id:subject:from:to:cc:date:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=2KyNciDw2QtCisXWSlqXYW9uwOwV1zBYLGs+69CUCHM=;\n\tb=SjMYq+NYYbMjlL3ASpaQEFKx17twEVKDoVNqdH0egATI1V16UBfckYDI9FsdrC/7v8\n\twsFwoC2L6PeZyv1+678W+RxoDt38MKBrqcf7Mf1ofzAPJDzrQvuGROlJdNW7uzSG5HsA\n\tM/Hk0mdfBA8x0O8r36GsUABfp4b4v2CZQvhtWnDD7x0GjND8IgJG4c48VsatBy/F+lRe\n\trKqi5t625vfRkmj6IGLLyjsS5CG2lFMzltnR50BBpl/dAbmnfg9Wg1JqKdtbqaRf+jGh\n\tPd/06VcH4Z2cYIqUi4lwRZ0L7lhKeyE7ovSiyHkGQKbKh9hfkVHwtuQ68/3qSFZVI+NA\n\tv3ig==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=2KyNciDw2QtCisXWSlqXYW9uwOwV1zBYLGs+69CUCHM=;\n\tb=p3ad9XTMWwRDaqQCsJ3KyqhLk/veKSPSBFIy7ec41sCi7kUfLduD/yMUcwCql+jUPH\n\tr/Xlom2Hm8UCSO8sd5BY0AluXCrK+pk0Qs15Gj7jp83W6j7dbLntzyGZ4H7HCulWbsZR\n\tetN7cTZ1J4jeoJ2e2xBuQGHnjgrdHMT9WrwwXIoePBs5knXOOKSdHlHbL19rXQkb+NOZ\n\t1SvRh4P8Pz9P+M1IoHuFKbhUCqGciNCFfoPJO0cwvQaFyAicClCPN/Nt8tzDNAi4hPrR\n\tDphGgJNN4OcUbGKB+GZheT2OjyNVjDaIXvHZ7m1OWNaQCcgrAuikmYzKkbnVmaU8Z1xB\n\t8m/g==","X-Gm-Message-State":"AHPjjUjx+1ABtZy2m7pbhgE3ceFFrSyMUCO1YALq+NYOv4HiQorgMdoG\n\t/B54QWKf+Xm5tg==","X-Google-Smtp-Source":"ADKCNb5wxoPL1NaAEfgt1gyqwg8dwGchTgRoVJaecwhWGVPltAX0hS6kWeFJNSjdxt8HJ7DCITr47A==","X-Received":"by 10.84.246.195 with SMTP id j3mr2734728plt.91.1504620623286;\n\tTue, 05 Sep 2017 07:10:23 -0700 (PDT)","Message-ID":"<1504620621.15310.39.camel@edumazet-glaptop3.roam.corp.google.com>","Subject":"Re: [PATCH net] net: sched: don't use GFP_KERNEL under spin lock","From":"Eric Dumazet ","To":"Jakub Kicinski ","Cc":"netdev@vger.kernel.org, jiri@resnulli.us,\n\tChris Mi , xiyou.wangcong@gmail.com,\n\tjhs@mojatatu.com, oss-drivers@netronome.com","Date":"Tue, 05 Sep 2017 07:10:21 -0700","In-Reply-To":"<20170905105442.30972-1-jakub.kicinski@netronome.com>","References":"<20170905105442.30972-1-jakub.kicinski@netronome.com>","Content-Type":"text/plain; charset=\"UTF-8\"","X-Mailer":"Evolution 3.10.4-0ubuntu2 ","Mime-Version":"1.0","Content-Transfer-Encoding":"7bit","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1763399,"web_url":"http://patchwork.ozlabs.org/comment/1763399/","msgid":"<20170905152551.748e4af2@cakuba.netronome.com>","list_archive_url":null,"date":"2017-09-05T14:25:51","subject":"Re: [oss-drivers] Re: [PATCH net] net: sched: don't use GFP_KERNEL\n\tunder spin lock","submitter":{"id":17220,"url":"http://patchwork.ozlabs.org/api/people/17220/","name":"Jakub Kicinski","email":"kubakici@wp.pl"},"content":"On Tue, 5 Sep 2017 14:52:21 +0200, Jiri Pirko wrote:\n> Tue, Sep 05, 2017 at 12:59:48PM CEST, kubakici@wp.pl wrote:\n> >Jiri, FWIW I also just noticed these, but they seem related to the\n> >earlier TC chain work? \n> \n> What do you do to trigger this?\n\nSorry, I wasted a bit of time there because kmemleak takes surprisingly\nlong to notice the memory leak... In the end this is sufficient:\n\n modprobe nfp\n ifconfig p4p1 10.8.1.1/24 up\n tc qdisc add dev p4p1 handle ffff: ingress\n tc filter add dev p4p1 parent ffff: protocol 802.1Q flower vlan_id 600 \\\n action mirred egress redirect dev p4p1\n tc filter del dev p4p1 parent ffff:\n rmmod nfp","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=wp.pl header.i=@wp.pl header.b=\"m0Mzw1ok\";\n\tdkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xmpsz2g99z9t1t\n\tfor ;\n\tWed, 6 Sep 2017 00:25:59 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751863AbdIEOZ6 (ORCPT );\n\tTue, 5 Sep 2017 10:25:58 -0400","from mx4.wp.pl ([212.77.101.11]:11326 \"EHLO mx4.wp.pl\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1751846AbdIEOZ4 (ORCPT );\n\tTue, 5 Sep 2017 10:25:56 -0400","(wp-smtpd smtp.wp.pl 22001 invoked from network);\n\t5 Sep 2017 16:25:54 +0200","from host-79-78-33-110.static.as9105.net (HELO\n\tcakuba.netronome.com) (kubakici@wp.pl@[79.78.33.110])\n\t(envelope-sender )\n\tby smtp.wp.pl (WP-SMTPD) with ECDHE-RSA-AES256-GCM-SHA384 encrypted\n\tSMTP for ; 5 Sep 2017 16:25:54 +0200"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=wp.pl; s=1024a;\n\tt=1504621554; bh=/U/Pc6sNLWDTKMF0pkdCmMeKF6qQZJxc3JA735m+U04=;\n\th=From:To:Cc:Subject;\n\tb=m0Mzw1okuUf0XMVJvpPpOsLINIyqjmjL0izuL+6HMrOZ9F+CNRDAKo2IQx4ORhInE\n\tkWcO0gmGfYnCpvEPGUZhiZuC7Z4f4fN9N+MPROxM1Gaut/RejWg1XlaGWhR1udAjG/\n\tPln5jeLflHHL1BYVzIEO6FSYwZBiXprK6HLlv9NU=","Date":"Tue, 5 Sep 2017 15:25:51 +0100","From":"Jakub Kicinski ","To":"Jiri Pirko ","Cc":"netdev@vger.kernel.org, oss-drivers@netronome.com","Subject":"Re: [oss-drivers] Re: [PATCH net] net: sched: don't use GFP_KERNEL\n\tunder spin lock","Message-ID":"<20170905152551.748e4af2@cakuba.netronome.com>","In-Reply-To":"<20170905125221.GA7936@nanopsycho>","References":"<20170905105442.30972-1-jakub.kicinski@netronome.com>\n\t<20170905115948.2fd38785@cakuba.netronome.com>\n\t<20170905125221.GA7936@nanopsycho>","MIME-Version":"1.0","Content-Type":"text/plain; charset=US-ASCII","Content-Transfer-Encoding":"7bit","X-WP-MailID":"5bbbc7cfd4c1c84eef16ec54127b5de3","X-WP-AV":"skaner antywirusowy Poczty Wirtualnej Polski","X-WP-SPAM":"NO 000000A [cXM0] ","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1763405,"web_url":"http://patchwork.ozlabs.org/comment/1763405/","msgid":"<20170905143125.GD7936@nanopsycho>","list_archive_url":null,"date":"2017-09-05T14:31:25","subject":"Re: [oss-drivers] Re: [PATCH net] net: sched: don't use GFP_KERNEL\n\tunder spin lock","submitter":{"id":15321,"url":"http://patchwork.ozlabs.org/api/people/15321/","name":"Jiri Pirko","email":"jiri@resnulli.us"},"content":"Tue, Sep 05, 2017 at 04:25:51PM CEST, kubakici@wp.pl wrote:\n>On Tue, 5 Sep 2017 14:52:21 +0200, Jiri Pirko wrote:\n>> Tue, Sep 05, 2017 at 12:59:48PM CEST, kubakici@wp.pl wrote:\n>> >Jiri, FWIW I also just noticed these, but they seem related to the\n>> >earlier TC chain work? \n>> \n>> What do you do to trigger this?\n>\n>Sorry, I wasted a bit of time there because kmemleak takes surprisingly\n>long to notice the memory leak... In the end this is sufficient:\n>\n> modprobe nfp\n> ifconfig p4p1 10.8.1.1/24 up\n> tc qdisc add dev p4p1 handle ffff: ingress\n> tc filter add dev p4p1 parent ffff: protocol 802.1Q flower vlan_id 600 \\\n> action mirred egress redirect dev p4p1\n> tc filter del dev p4p1 parent ffff:\n> rmmod nfp\n\nWill try. Thanks!","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=resnulli-us.20150623.gappssmtp.com\n\theader.i=@resnulli-us.20150623.gappssmtp.com\n\theader.b=\"BvBh5bV8\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xmq0P2SwHz9t1t\n\tfor ;\n\tWed, 6 Sep 2017 00:31:33 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751967AbdIEOba (ORCPT );\n\tTue, 5 Sep 2017 10:31:30 -0400","from mail-wr0-f195.google.com ([209.85.128.195]:36480 \"EHLO\n\tmail-wr0-f195.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751647AbdIEOb2 (ORCPT\n\t); Tue, 5 Sep 2017 10:31:28 -0400","by mail-wr0-f195.google.com with SMTP id 40so1808964wrv.3\n\tfor ; Tue, 05 Sep 2017 07:31:27 -0700 (PDT)","from localhost (ip-89-177-125-82.net.upcbroadband.cz.\n\t[89.177.125.82]) by smtp.gmail.com with ESMTPSA id\n\tx187sm677642wme.46.2017.09.05.07.31.25\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tTue, 05 Sep 2017 07:31:26 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=resnulli-us.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:in-reply-to:user-agent;\n\tbh=uyddcAtCi7K92U4E9FrmJEaXTCstA6gh9sRSP2z1R70=;\n\tb=BvBh5bV8X8q6yqedzPHttaReSKTzeaxOoKFnCMNZVtIkYGq2G40LtRA3ky/sswnAKG\n\tUJqOmRG8ul2FCw+VdTYGK49wEWnZxViTmZQykmYqBIRQ21YjKiHN28ybz+1JOZTCXTpz\n\t6e21ReXTmhHHzG+ZwyFxmQHDauyOAxVPtmF7FGVf4KrbeKGvdW7ubKpngptTYGETtvn5\n\t2cnxT3wruwWy4y9n1uxNekhC9v2yMRH2BZK+Xg1mqo7gvuK90IbpU0kP6rrCgiVmbpYi\n\t+6JG1ZzHejUpYO8sFGncP/FZfcoknb47/5HF7vGBt/UAuCbQwzTxQQ+Hr2WGBdJyQw9P\n\tKURg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:in-reply-to:user-agent;\n\tbh=uyddcAtCi7K92U4E9FrmJEaXTCstA6gh9sRSP2z1R70=;\n\tb=Lxl55e/VoQ+ojIBsSYPcxcGbAw8j2BSQuDMW2UhHwMvPtuksDT5Dmqxs5nt+cfSRzy\n\tZU0oznvUdLWJ5+TxET7RW5COzAiJAnqg55SAjF3zCOCAcEO9dQZQAdNhuK59IdNuTNac\n\tq2GRtzQcERDJRQrYiy8nySY3cadd+8PsLDfgecyB6i3JDfG5F8NGSfC4FgEF3v6jgVCe\n\tlBTSMmc3677sE/+K4qhlWX+OyQYvhjs4jnkCKjRwWY45IjyW5FZNgNtqsip2EUIYXdXl\n\tvLe37Cu+Kd2YyQdafBpEj1PkVw24RuLG7QN7ducEnW4atloGXChbnZPHOvVmQuPKwuBO\n\toS1Q==","X-Gm-Message-State":"AHPjjUjn0eo8oNRRloGQDpjR5oqso5d4ykeofYZ5rBgkOw8uVtPHNFh4\n\t5+D1sS9CpkNHwdHR","X-Google-Smtp-Source":"ADKCNb4lUPBxwxIVu4BiChWEGGy9inUeb1eZuX2cFqIPCOps9Db5KZcctRUXBXVFpB56NAkmsmoPSQ==","X-Received":"by 10.223.176.114 with SMTP id g47mr2887232wra.146.1504621887109;\n\tTue, 05 Sep 2017 07:31:27 -0700 (PDT)","Date":"Tue, 5 Sep 2017 16:31:25 +0200","From":"Jiri Pirko ","To":"Jakub Kicinski ","Cc":"netdev@vger.kernel.org, oss-drivers@netronome.com","Subject":"Re: [oss-drivers] Re: [PATCH net] net: sched: don't use GFP_KERNEL\n\tunder spin lock","Message-ID":"<20170905143125.GD7936@nanopsycho>","References":"<20170905105442.30972-1-jakub.kicinski@netronome.com>\n\t<20170905115948.2fd38785@cakuba.netronome.com>\n\t<20170905125221.GA7936@nanopsycho>\n\t<20170905152551.748e4af2@cakuba.netronome.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20170905152551.748e4af2@cakuba.netronome.com>","User-Agent":"Mutt/1.8.3 (2017-05-23)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}}]