[{"id":1763235,"web_url":"http://patchwork.ozlabs.org/comment/1763235/","msgid":"<3f705786-30f3-64b3-113c-4bdebe1282c8@acm.org>","list_archive_url":null,"date":"2017-09-05T11:18:30","subject":"Re: [C++/ARM Patch] PR 81942 (\"ICE on empty constexpr constructor\n\twith C++14\")","submitter":{"id":9970,"url":"http://patchwork.ozlabs.org/api/people/9970/","name":"Nathan Sidwell","email":"nathan@acm.org"},"content":"On 09/05/2017 06:19 AM, Paolo Carlini wrote:\n\n> in this ICE on valid, a gcc_assert fires when a GOTO_EXPR is handled by \n> cxx_eval_constant_expression which is the translation of a \"return;\" on \n> a targetm.cxx.cdtor_returns_this target (like ARM):\n\n> I think the right way to handle this is marking such special labels with \n> a LABEL_DECL_CDTOR flag and using it in the returns helper function (we \n> already use a similar strategy with LABEL_DECL_BREAK and \n> LABEL_DECL_CONTINUE and the breaks and continues helpers). Then \n> adjusting the ICEing gcc_assert is trivial. Tested x86_64-linux and \n> aarch64-linux.\n\nOK.\n\n(heh, i notice we call the hook 'cdtor_returns_this', but AFAICT it only \napplies to ctors. Not your problem though.)\n\nnathan","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","mailing list gcc-patches@gcc.gnu.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=gcc.gnu.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=gcc-patches-return-461487-incoming=patchwork.ozlabs.org@gcc.gnu.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org\n\theader.b=\"GTjuJ29j\"; dkim-atps=neutral","sourceware.org; auth=none"],"Received":["from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xmkjz59pvz9sPk\n\tfor ;\n\tTue, 5 Sep 2017 21:18:46 +1000 (AEST)","(qmail 5173 invoked by alias); 5 Sep 2017 11:18:39 -0000","(qmail 5163 invoked by uid 89); 5 Sep 2017 11:18:39 -0000","from mail-yw0-f182.google.com (HELO mail-yw0-f182.google.com)\n\t(209.85.161.182) by sourceware.org\n\t(qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP;\n\tTue, 05 Sep 2017 11:18:34 +0000","by mail-yw0-f182.google.com with SMTP id w204so11542650ywg.3 for\n\t; Tue, 05 Sep 2017 04:18:34 -0700 (PDT)","from ?IPv6:2620:10d:c0a3:20fb:7500:e7fb:4a6f:2254?\n\t([2620:10d:c091:200::16fd]) by smtp.googlemail.com with\n\tESMTPSA id e193sm87527ywa.79.2017.09.05.04.18.31\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256\n\tbits=128/128); Tue, 05 Sep 2017 04:18:31 -0700 (PDT)"],"DomainKey-Signature":"a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id\n\t:list-unsubscribe:list-archive:list-post:list-help:sender\n\t:subject:to:cc:references:from:message-id:date:mime-version\n\t:in-reply-to:content-type:content-transfer-encoding; q=dns; s=\n\tdefault; b=ODN5Q20ohRPKURHvSZYTLEIy+Y3OEj0wfK8E8rumirK7xwGDx4o5U\n\t74d4lwrUp5UTqo+hqm6AIXO6SIoSI1RirmsHCNmpeIVB+/cSSb1T2PyvKzGciCQM\n\tO9cDFqcPWUCLfrUDIkitHC9ugBc5LAyDh5DVw2KoTgvMRvjjoZE6Sg=","DKIM-Signature":"v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id\n\t:list-unsubscribe:list-archive:list-post:list-help:sender\n\t:subject:to:cc:references:from:message-id:date:mime-version\n\t:in-reply-to:content-type:content-transfer-encoding; s=default;\n\tbh=w5lZD75X5Ep+FPwJXP0OB0VHxEc=; b=GTjuJ29j6hj/2FrJ3k3tUne6Yf0U\n\tygXLMSgG4rPkxVVYDKVWoRMVABloypNxjk3qjU5JhSzLVogtkJhoLIwyllpINdaG\n\tygXJR5q1Iv52s4PLzC9fNbA1RqYTxtXUlx2l3mT1y4NF9emgdenhM2X6YH/jxjEH\n\tdiEyTxyrzyauwJ8=","Mailing-List":"contact gcc-patches-help@gcc.gnu.org; run by ezmlm","Precedence":"bulk","List-Id":"","List-Unsubscribe":"","List-Archive":"","List-Post":"","List-Help":"","Sender":"gcc-patches-owner@gcc.gnu.org","X-Virus-Found":"No","X-Spam-SWARE-Status":"No, score=-1.4 required=5.0 tests=BAYES_00,\n\tFREEMAIL_FROM, RCVD_IN_DNSWL_NONE, RCVD_IN_SORBS_SPAM,\n\tSPF_PASS autolearn=no version=3.3.2 spammy=","X-HELO":"mail-yw0-f182.google.com","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net;\n\ts=20161025;\n\th=x-gm-message-state:sender:subject:to:cc:references:from:message-id\n\t:date:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=3q1rRd4+CM+Y6bPZz9K8zQkCh2rkLArJDkcg0vRTYVo=;\n\tb=oQaaB8w71AD68WNyb3P7QeJ/IeJnav19UPEMtDzE/3qqdk6W5yQ5nZGZ673NjQ7vO0\n\tVFA9+DX3VEhPiJAn96Feqiw0YJcbURGnjDFJGJ0Baetdx9UbypMTt0/UTt40oaWTKoJB\n\tHUUrWKoKUwwHKEbdzfH6UtMcIA9D41BKgoOP2ZFanmiFsaNiMnZwx+iI1PmfWPynhqVP\n\tHBPqSS9jBumHY/GH9JijM3OrdVQfIxRbjhlcl3fEsK2iFFN18447Xqipl5UMmDjEsgQj\n\tNuWRmRAAVnJNgopjEtjTcrobjk0aYlbDfdZzJX6TktkShAJpDHVA0dwLuyMs8IovGqre\n\tkEww==","X-Gm-Message-State":"AHPjjUiMD2EALQumQXUa4ZomrOcoJUeUaVGEbnlqKvQQUtu7e6cZWyFU\t5i2+KABV3wKHiw==","X-Google-Smtp-Source":"ADKCNb7PoEkxCbOYXRUbimxnlfmMJuR/K0CpMIPwKyoBRjO2TLE7xpQMWpyfL4KXQATSddpxlOwPng==","X-Received":"by 10.37.129.2 with SMTP id o2mr2849765ybk.182.1504610312429;\n\tTue, 05 Sep 2017 04:18:32 -0700 (PDT)","Subject":"Re: [C++/ARM Patch] PR 81942 (\"ICE on empty constexpr constructor\n\twith C++14\")","To":"Paolo Carlini ,\n\t\"gcc-patches@gcc.gnu.org\" ","Cc":"Jason Merrill ","References":"<25f223e6-8b85-d81a-51f0-2dec92838338@oracle.com>","From":"Nathan Sidwell ","Message-ID":"<3f705786-30f3-64b3-113c-4bdebe1282c8@acm.org>","Date":"Tue, 5 Sep 2017 07:18:30 -0400","User-Agent":"Mozilla/5.0 (X11; Linux x86_64;\n\trv:52.0) Gecko/20100101 Thunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<25f223e6-8b85-d81a-51f0-2dec92838338@oracle.com>","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Transfer-Encoding":"7bit"}}]