[{"id":1763600,"web_url":"http://patchwork.ozlabs.org/comment/1763600/","msgid":"<20170905213604.61141da0@windsurf.lan>","list_archive_url":null,"date":"2017-09-05T19:36:04","subject":"Re: [Buildroot] [PATCH] libqmi: udev and qmi-over-mbim are optional","submitter":{"id":2230,"url":"http://patchwork.ozlabs.org/api/people/2230/","name":"Thomas Petazzoni","email":"thomas.petazzoni@free-electrons.com"},"content":"Hello,\n\nOn Tue, 5 Sep 2017 12:03:27 +0200, Aleksander Morgado wrote:\n> Don't always build without udev, as qmi-firmware-update would be very\n> very limited in that case. Instead, make it optional: if there is udev\n> support in the setup, require libgudev and configure using --with-udev\n> explicitly; otherwise just --without-udev.\n> \n> Also, add the qmi-over-mbim feature as optional, and require libmbim\n> if we're building with it enabled.\n> \n> Signed-off-by: Aleksander Morgado \n> ---\n> package/libqmi/Config.in | 18 ++++++++++++++++++\n> package/libqmi/libqmi.mk | 18 ++++++++++++++++--\n> 2 files changed, 34 insertions(+), 2 deletions(-)\n> \n> diff --git a/package/libqmi/Config.in b/package/libqmi/Config.in\n> index f1d111b7c..a536650b5 100644\n> --- a/package/libqmi/Config.in\n> +++ b/package/libqmi/Config.in\n> @@ -10,6 +10,24 @@ config BR2_PACKAGE_LIBQMI\n> \n> \t http://www.freedesktop.org/wiki/Software/libqmi/\n> \n> +if BR2_PACKAGE_LIBQMI\n> +\n> +config BR2_PACKAGE_LIBQMI_UDEV\n> +\tbool \"qmi-firmware-update udev support\"\n> +\tdepends on BR2_PACKAGE_HAS_UDEV\n> +\tselect BR2_PACKAGE_LIBGUDEV\n\nlibgudev has plenty of other dependencies that you need to propagate\nhere.\n\n> +\thelp\n> +\t This option enables udev support in the qmi-firmware-update tool\n> +\n> +config BR2_PACKAGE_LIBQMI_MBIM_QMUX\n> +\tbool \"QMI-over-MBIM support\"\n> +\tselect BR2_PACKAGE_LIBMBIM\n\n... and libmbim also has plenty of dependencies that you need to\npropagate here, including BR2_PACKAGE_HAS_UDEV.\n\nAll in all, isn't it simpler to get rid of those options, and simply do:\n\nifeq ($(BR2_PACKAGE_LIBGUDEV),y)\n... enable support\nelse\n... disable support\nendif\n\nifeq ($(BR2_PACKAGE_LIBMBIM),y)\n... enable support\nelse\n... disable support\nendif\n\nThanks!\n\nThomas","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","buildroot@lists.busybox.net"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","buildroot@osuosl.org"],"Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=busybox.net\n\t(client-ip=140.211.166.138; helo=whitealder.osuosl.org;\n\tenvelope-from=buildroot-bounces@busybox.net;\n\treceiver=)","Received":["from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xmxlx3mhFz9sNV\n\tfor ;\n\tWed, 6 Sep 2017 05:36:13 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id C7FC1878D4;\n\tTue, 5 Sep 2017 19:36:09 +0000 (UTC)","from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id z4Br6OM13KW6; Tue, 5 Sep 2017 19:36:08 +0000 (UTC)","from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 3D4CB8781C;\n\tTue, 5 Sep 2017 19:36:08 +0000 (UTC)","from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id CCD971CEAF2\n\tfor ;\n\tTue, 5 Sep 2017 19:36:06 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id C6E088781C\n\tfor ;\n\tTue, 5 Sep 2017 19:36:06 +0000 (UTC)","from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id TqM9eU+5QNRx for ;\n\tTue, 5 Sep 2017 19:36:06 +0000 (UTC)","from mail.free-electrons.com (mail.free-electrons.com [62.4.15.54])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 02E14865D6\n\tfor ; Tue, 5 Sep 2017 19:36:05 +0000 (UTC)","by mail.free-electrons.com (Postfix, from userid 110)\n\tid 252B42068C; Tue, 5 Sep 2017 21:36:04 +0200 (CEST)","from windsurf.lan (LFbn-1-15130-153.w86-206.abo.wanadoo.fr\n\t[86.206.236.153])\n\tby mail.free-electrons.com (Postfix) with ESMTPSA id 026EA207A1;\n\tTue, 5 Sep 2017 21:36:03 +0200 (CEST)"],"X-Virus-Scanned":["amavisd-new at osuosl.org","amavisd-new at osuosl.org"],"X-Greylist":"domain auto-whitelisted by SQLgrey-1.7.6","Date":"Tue, 5 Sep 2017 21:36:04 +0200","From":"Thomas Petazzoni ","To":"Aleksander Morgado ","Message-ID":"<20170905213604.61141da0@windsurf.lan>","In-Reply-To":"<20170905100327.21421-1-aleksander@aleksander.es>","References":"<20170905100327.21421-1-aleksander@aleksander.es>","Organization":"Free Electrons","X-Mailer":"Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-redhat-linux-gnu)","MIME-Version":"1.0","Cc":"buildroot@buildroot.org","Subject":"Re: [Buildroot] [PATCH] libqmi: udev and qmi-over-mbim are optional","X-BeenThere":"buildroot@busybox.net","X-Mailman-Version":"2.1.18-1","Precedence":"list","List-Id":"Discussion and development of buildroot ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"buildroot-bounces@busybox.net","Sender":"\"buildroot\" "}},{"id":1763608,"web_url":"http://patchwork.ozlabs.org/comment/1763608/","msgid":"","list_archive_url":null,"date":"2017-09-05T19:45:19","subject":"Re: [Buildroot] [PATCH] libqmi: udev and qmi-over-mbim are optional","submitter":{"id":48681,"url":"http://patchwork.ozlabs.org/api/people/48681/","name":"Aleksander Morgado","email":"aleksander@aleksander.es"},"content":"Hey\n\n>\n> On Tue, 5 Sep 2017 12:03:27 +0200, Aleksander Morgado wrote:\n>> Don't always build without udev, as qmi-firmware-update would be very\n>> very limited in that case. Instead, make it optional: if there is udev\n>> support in the setup, require libgudev and configure using --with-udev\n>> explicitly; otherwise just --without-udev.\n>>\n>> Also, add the qmi-over-mbim feature as optional, and require libmbim\n>> if we're building with it enabled.\n>>\n>> Signed-off-by: Aleksander Morgado \n>> ---\n>> package/libqmi/Config.in | 18 ++++++++++++++++++\n>> package/libqmi/libqmi.mk | 18 ++++++++++++++++--\n>> 2 files changed, 34 insertions(+), 2 deletions(-)\n>>\n>> diff --git a/package/libqmi/Config.in b/package/libqmi/Config.in\n>> index f1d111b7c..a536650b5 100644\n>> --- a/package/libqmi/Config.in\n>> +++ b/package/libqmi/Config.in\n>> @@ -10,6 +10,24 @@ config BR2_PACKAGE_LIBQMI\n>>\n>> http://www.freedesktop.org/wiki/Software/libqmi/\n>>\n>> +if BR2_PACKAGE_LIBQMI\n>> +\n>> +config BR2_PACKAGE_LIBQMI_UDEV\n>> + bool \"qmi-firmware-update udev support\"\n>> + depends on BR2_PACKAGE_HAS_UDEV\n>> + select BR2_PACKAGE_LIBGUDEV\n>\n> libgudev has plenty of other dependencies that you need to propagate\n> here.\n>\n>> + help\n>> + This option enables udev support in the qmi-firmware-update tool\n>> +\n>> +config BR2_PACKAGE_LIBQMI_MBIM_QMUX\n>> + bool \"QMI-over-MBIM support\"\n>> + select BR2_PACKAGE_LIBMBIM\n>\n> ... and libmbim also has plenty of dependencies that you need to\n> propagate here, including BR2_PACKAGE_HAS_UDEV.\n>\n\nOh, I assumed that was somehow automatic... Does this mean that if the\ndeps of a library are updated at some point in time, all the apps\ndepending on the library also need to get updated to add the new dep?\n\n> All in all, isn't it simpler to get rid of those options, and simply do:\n>\n> ifeq ($(BR2_PACKAGE_LIBGUDEV),y)\n> ... enable support\n> else\n> ... disable support\n> endif\n>\n> ifeq ($(BR2_PACKAGE_LIBMBIM),y)\n> ... enable support\n> else\n> ... disable support\n> endif\n>\n\nYes, probably that's a much simpler option. Will suggest a new patch.\n\nThanks for reviewing!","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","buildroot@lists.busybox.net"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","buildroot@osuosl.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=busybox.net\n\t(client-ip=140.211.166.137; helo=fraxinus.osuosl.org;\n\tenvelope-from=buildroot-bounces@busybox.net;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=aleksander-es.20150623.gappssmtp.com\n\theader.i=@aleksander-es.20150623.gappssmtp.com\n\theader.b=\"eYad88nS\"; dkim-atps=neutral"],"Received":["from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xmxz03nnrz9sNV\n\tfor ;\n\tWed, 6 Sep 2017 05:45:48 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 7D7FD86D61;\n\tTue, 5 Sep 2017 19:45:46 +0000 (UTC)","from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id siiu1Mp-Ahwc; Tue, 5 Sep 2017 19:45:45 +0000 (UTC)","from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id BCB3286CE5;\n\tTue, 5 Sep 2017 19:45:45 +0000 (UTC)","from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ash.osuosl.org (Postfix) with ESMTP id 57E411C104C\n\tfor ;\n\tTue, 5 Sep 2017 19:45:43 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 4DF2286CE5\n\tfor ;\n\tTue, 5 Sep 2017 19:45:43 +0000 (UTC)","from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id cX77Z9EOCHZ8 for ;\n\tTue, 5 Sep 2017 19:45:42 +0000 (UTC)","from mail-wm0-f68.google.com (mail-wm0-f68.google.com\n\t[74.125.82.68])\n\tby fraxinus.osuosl.org (Postfix) with ESMTPS id DC73886ACB\n\tfor ; Tue, 5 Sep 2017 19:45:41 +0000 (UTC)","by mail-wm0-f68.google.com with SMTP id p17so3741620wmd.3\n\tfor ; Tue, 05 Sep 2017 12:45:41 -0700 (PDT)","by 10.80.186.25 with HTTP; Tue, 5 Sep 2017 12:45:19 -0700 (PDT)"],"X-Virus-Scanned":["amavisd-new at osuosl.org","amavisd-new at osuosl.org"],"X-Greylist":"from auto-whitelisted by SQLgrey-1.7.6","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=aleksander-es.20150623.gappssmtp.com; s=20150623;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=8xcF+ms/UJzuBitvHuDV4rHn0VFD1E5G/1CjFKBXCmM=;\n\tb=eYad88nSLEpOLqF2kvGVY87Frrp4p9hT2pehChvz6whtPGL6rJGvvtLNcLOHXvVVU/\n\tDwOmZQN2UY3FFG3zfMVjt6O7Zo9wJEqdWOs0AqHsSEVLhjZIfF7JQRUsTif6MEvTrPXU\n\tHgv1oudSQotcgkLCxZmEvnQ/7xd+XLL09Z+D1q/hi1CmOIdrYzp0UgQU/8kvYNhIXENh\n\t0wQRxnCQdAjpiMNGxeVoAAxXHrj1fVnTGfpy4ZFoJL90uvQOp8kzPHTNaWIuhiu3EDkN\n\tCHVXtkJdh8OzgUcV/1r9RlGY/iZYiqwTwoU0Obe7fRYYyK9aH0AgGVT5wdizPL2/NWOk\n\tUtBw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=8xcF+ms/UJzuBitvHuDV4rHn0VFD1E5G/1CjFKBXCmM=;\n\tb=ts6zsZPrq3D52LJbvkwTC3Ft0S+K0SvdR8l+plRH6KNKbhSGteuZRB3+f7P26Il+J/\n\tTyyfcJjxt32GIpZ7sAhLQDFxfCmVgXVkKAoYuIRFiwRen8BsyxWhfXAbHlbqjLbWJmP5\n\tyFqJH4aCjKUGu8+YzOcnWZt5AtYiZhApLbA+spfEoOio1kBZy5Y9v/bfzv9Pz5L3md3u\n\tfPGAuvIPxZSIMteYLRH+JN01grcMMNU+R7Frq8SmSC9CTYbyJVf821l7CHXbqZ+45IvU\n\txpjXTIn7/2zN7yeM/hz1oTiWFAzn56RuSiE+5RFPun4q/uwuUQDiM5x0sE4g3b/2zqdr\n\tPxcw==","X-Gm-Message-State":"AHPjjUh3e+ewq3SGIGds7m3YJt/Pu2k0FWNSdAkw1EsRYzKeaXzRpmuB\n\tiS2xgGNBHuRJHIi/ecLL0yKyn4weUjR2jRw=","X-Google-Smtp-Source":"ADKCNb6KJWtsHbH3RGARLbOQspZGCXHXgKMol0J1GjntrpjI5p0rf7VAsF3OwnWqRocdAwAbGkYvmA250ZjgsOs1XJQ=","X-Received":"by 10.80.215.26 with SMTP id t26mr4126244edi.155.1504640740356; \n\tTue, 05 Sep 2017 12:45:40 -0700 (PDT)","MIME-Version":"1.0","X-Originating-IP":"[83.40.186.116]","In-Reply-To":"<20170905213604.61141da0@windsurf.lan>","References":"<20170905100327.21421-1-aleksander@aleksander.es>\n\t<20170905213604.61141da0@windsurf.lan>","From":"Aleksander Morgado ","Date":"Tue, 5 Sep 2017 21:45:19 +0200","Message-ID":"","To":"Thomas Petazzoni ","Cc":"buildroot@buildroot.org","Subject":"Re: [Buildroot] [PATCH] libqmi: udev and qmi-over-mbim are optional","X-BeenThere":"buildroot@busybox.net","X-Mailman-Version":"2.1.18-1","Precedence":"list","List-Id":"Discussion and development of buildroot ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"buildroot-bounces@busybox.net","Sender":"\"buildroot\" "}},{"id":1763840,"web_url":"http://patchwork.ozlabs.org/comment/1763840/","msgid":"<20170906085409.5de05fa2@windsurf.lan>","list_archive_url":null,"date":"2017-09-06T06:54:09","subject":"Re: [Buildroot] [PATCH] libqmi: udev and qmi-over-mbim are optional","submitter":{"id":2230,"url":"http://patchwork.ozlabs.org/api/people/2230/","name":"Thomas Petazzoni","email":"thomas.petazzoni@free-electrons.com"},"content":"Hello,\n\nOn Tue, 5 Sep 2017 21:45:19 +0200, Aleksander Morgado wrote:\n\n> > ... and libmbim also has plenty of dependencies that you need to\n> > propagate here, including BR2_PACKAGE_HAS_UDEV.\n> > \n> \n> Oh, I assumed that was somehow automatic... Does this mean that if the\n> deps of a library are updated at some point in time, all the apps\n> depending on the library also need to get updated to add the new dep?\n\nYes, exactly. When we review patches adding new dependencies to an\nexisting package, we are always careful that those new dependencies are\npropagated.\n\n> Yes, probably that's a much simpler option. Will suggest a new patch.\n\nThanks!\n\nThomas","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","buildroot@lists.busybox.net"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","buildroot@osuosl.org"],"Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=busybox.net\n\t(client-ip=140.211.166.133; helo=hemlock.osuosl.org;\n\tenvelope-from=buildroot-bounces@busybox.net;\n\treceiver=)","Received":["from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xnDpX6KyTz9sNd\n\tfor ;\n\tWed, 6 Sep 2017 16:54:28 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id ADBB089AAF;\n\tWed, 6 Sep 2017 06:54:24 +0000 (UTC)","from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id tvNuJEMa4M-o; Wed, 6 Sep 2017 06:54:23 +0000 (UTC)","from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 5AACF89AA6;\n\tWed, 6 Sep 2017 06:54:23 +0000 (UTC)","from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ash.osuosl.org (Postfix) with ESMTP id D59DC1C409A\n\tfor ;\n\tWed, 6 Sep 2017 06:54:21 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id C882E87728\n\tfor ;\n\tWed, 6 Sep 2017 06:54:21 +0000 (UTC)","from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 9KzvszCTA1mH for ;\n\tWed, 6 Sep 2017 06:54:21 +0000 (UTC)","from mail.free-electrons.com (mail.free-electrons.com [62.4.15.54])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 1991C87716\n\tfor ; Wed, 6 Sep 2017 06:54:21 +0000 (UTC)","by mail.free-electrons.com (Postfix, from userid 110)\n\tid 34E4A209D0; Wed, 6 Sep 2017 08:54:19 +0200 (CEST)","from windsurf.lan (LStLambert-657-1-97-87.w90-63.abo.wanadoo.fr\n\t[90.63.216.87])\n\tby mail.free-electrons.com (Postfix) with ESMTPSA id 0E0EE2088B;\n\tWed, 6 Sep 2017 08:54:09 +0200 (CEST)"],"X-Virus-Scanned":["amavisd-new at osuosl.org","amavisd-new at osuosl.org"],"X-Greylist":"domain auto-whitelisted by SQLgrey-1.7.6","Date":"Wed, 6 Sep 2017 08:54:09 +0200","From":"Thomas Petazzoni ","To":"Aleksander Morgado ","Message-ID":"<20170906085409.5de05fa2@windsurf.lan>","In-Reply-To":"","References":"<20170905100327.21421-1-aleksander@aleksander.es>\n\t<20170905213604.61141da0@windsurf.lan>\n\t","Organization":"Free Electrons","X-Mailer":"Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-redhat-linux-gnu)","MIME-Version":"1.0","Cc":"buildroot@buildroot.org","Subject":"Re: [Buildroot] [PATCH] libqmi: udev and qmi-over-mbim are optional","X-BeenThere":"buildroot@busybox.net","X-Mailman-Version":"2.1.18-1","Precedence":"list","List-Id":"Discussion and development of buildroot ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"buildroot-bounces@busybox.net","Sender":"\"buildroot\" "}},{"id":1763916,"web_url":"http://patchwork.ozlabs.org/comment/1763916/","msgid":"","list_archive_url":null,"date":"2017-09-06T08:38:25","subject":"Re: [Buildroot] [PATCH] libqmi: udev and qmi-over-mbim are optional","submitter":{"id":48681,"url":"http://patchwork.ozlabs.org/api/people/48681/","name":"Aleksander Morgado","email":"aleksander@aleksander.es"},"content":">\n> All in all, isn't it simpler to get rid of those options, and simply do:\n>\n> ifeq ($(BR2_PACKAGE_LIBGUDEV),y)\n> ... enable support\n\nWhen doing this, should I also include a direct dependency on\nlibgudev, so that libgudev is built before libqmi always?\nLIBQMI_DEPENDENCIES += libgudev\n\n> else\n> ... disable support\n> endif\n>","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","buildroot@lists.busybox.net"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","buildroot@osuosl.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=busybox.net\n\t(client-ip=140.211.166.136; helo=silver.osuosl.org;\n\tenvelope-from=buildroot-bounces@busybox.net;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=aleksander-es.20150623.gappssmtp.com\n\theader.i=@aleksander-es.20150623.gappssmtp.com\n\theader.b=\"kpTBrjNo\"; dkim-atps=neutral"],"Received":["from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xnH730rm1z9sNd\n\tfor ;\n\tWed, 6 Sep 2017 18:38:55 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 7FA31230F3;\n\tWed, 6 Sep 2017 08:38:51 +0000 (UTC)","from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id re8nwSz8ehom; Wed, 6 Sep 2017 08:38:50 +0000 (UTC)","from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id 0641022D5F;\n\tWed, 6 Sep 2017 08:38:50 +0000 (UTC)","from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id 25F101C1777\n\tfor ;\n\tWed, 6 Sep 2017 08:38:49 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 1FE18873C1\n\tfor ;\n\tWed, 6 Sep 2017 08:38:49 +0000 (UTC)","from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id uFO42wIUPAwu for ;\n\tWed, 6 Sep 2017 08:38:48 +0000 (UTC)","from mail-wm0-f68.google.com (mail-wm0-f68.google.com\n\t[74.125.82.68])\n\tby whitealder.osuosl.org (Postfix) with ESMTPS id AF09487230\n\tfor ; Wed, 6 Sep 2017 08:38:47 +0000 (UTC)","by mail-wm0-f68.google.com with SMTP id 187so4791100wmn.0\n\tfor ; Wed, 06 Sep 2017 01:38:47 -0700 (PDT)","by 10.80.225.71 with HTTP; Wed, 6 Sep 2017 01:38:25 -0700 (PDT)"],"X-Virus-Scanned":["amavisd-new at osuosl.org","amavisd-new at osuosl.org"],"X-Greylist":"from auto-whitelisted by SQLgrey-1.7.6","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=aleksander-es.20150623.gappssmtp.com; s=20150623;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=+ee3F2IznnSA9SX4mxzytuF9g6oqMEE7hPEAYyQqxDI=;\n\tb=kpTBrjNoCYH5l7BPwG0/72Vi8RYWdugaPun1IvezG8lNO3rr+Qx3LLCMjk84e69yXx\n\tO/zhAXQI0SY87dACNWze1Mb4xWXagdganEill9bVxya6VUQUxyr0WD9L9NccYcgG9HiB\n\tfFect30zrNM0U2jv+32I+gT4dkJYaH4FpC+Qc60NMwWDESgmz5Y3Uq50Eux84wRTCTh0\n\tahTdZRxElSKKXUoq1jhC0aflpZOj6cOzkwC7XRZtCsd/ZkQ2djGYDxo1vJZHU3vvKxFL\n\tfXmmkieZdLj/qeNDxzZkG+MaBR3Uynt+0zKXxNaF/FnwwKxl1snfByCIclt+v5GAWSd5\n\tsIhw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=+ee3F2IznnSA9SX4mxzytuF9g6oqMEE7hPEAYyQqxDI=;\n\tb=ErZfohSIhjMT3bOi3Yuq9/urievJBn7LZZ/kDMjmsD9p0l2sl7TMxmAy4L3Un87CQM\n\tVbPiSatv2WDFrHJoA5coG27s7XxGEdr3uitkT6176GXp5vB3skb7bnmD7JhF5FX4IOz7\n\tBMZCxemwlDmhQlD6XkWzCZ6UkhEvdCIumMfOPBMQ1tsgGQPqh+8Dcp1JWO4A+tccjxXE\n\tla/tO0LH5+Dn3OkztbuCRmt1TpXSjT3mMBh83J4hIUSDxAS3Qtje0FX+8kwjFP/Uk8NZ\n\tGRzb/T0vA+sayNkJP+2pcaE9q+t8OOZRQi+05A+UUERdqg51P32CWxX563a4nVPG7h6y\n\tUeOg==","X-Gm-Message-State":"AHPjjUgP4QBrxbo0Ll128uaGv16mzkBmjRi1j1HYZs7Tk8DFiV8Zd4/X\n\tkoiIi2y9cWawMH+uqta6cjXluyiHL6sdkxsfXw==","X-Google-Smtp-Source":"ADKCNb6GYV4WCTM5l/zpycGnOCltCNT4pHafha4qFINazbCqhmsPRILXPESvwYhlNDd5wftSmKJs9y0eEnYDR/gR2cc=","X-Received":"by 10.80.179.207 with SMTP id t15mr5423827edd.204.1504687125984; \n\tWed, 06 Sep 2017 01:38:45 -0700 (PDT)","MIME-Version":"1.0","X-Originating-IP":"[83.40.186.116]","In-Reply-To":"<20170905213604.61141da0@windsurf.lan>","References":"<20170905100327.21421-1-aleksander@aleksander.es>\n\t<20170905213604.61141da0@windsurf.lan>","From":"Aleksander Morgado ","Date":"Wed, 6 Sep 2017 10:38:25 +0200","Message-ID":"","To":"Thomas Petazzoni ","Cc":"buildroot@buildroot.org","Subject":"Re: [Buildroot] [PATCH] libqmi: udev and qmi-over-mbim are optional","X-BeenThere":"buildroot@busybox.net","X-Mailman-Version":"2.1.18-1","Precedence":"list","List-Id":"Discussion and development of buildroot ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"buildroot-bounces@busybox.net","Sender":"\"buildroot\" "}},{"id":1764033,"web_url":"http://patchwork.ozlabs.org/comment/1764033/","msgid":"<20170906133245.716cbbc6@windsurf.lan>","list_archive_url":null,"date":"2017-09-06T11:32:45","subject":"Re: [Buildroot] [PATCH] libqmi: udev and qmi-over-mbim are optional","submitter":{"id":2230,"url":"http://patchwork.ozlabs.org/api/people/2230/","name":"Thomas Petazzoni","email":"thomas.petazzoni@free-electrons.com"},"content":"Hello,\n\nOn Wed, 6 Sep 2017 10:38:25 +0200, Aleksander Morgado wrote:\n\n> > All in all, isn't it simpler to get rid of those options, and simply do:\n> >\n> > ifeq ($(BR2_PACKAGE_LIBGUDEV),y)\n> > ... enable support \n> \n> When doing this, should I also include a direct dependency on\n> libgudev, so that libgudev is built before libqmi always?\n> LIBQMI_DEPENDENCIES += libgudev\n\nWell, if you don't do this, libgudev is not guaranteed to be built\nbefore libqmi, so you would get a build failure, right ?\n\nThe canonical way to express optional dependencies is:\n\nifeq ($(BR2_PACKAGE_FOO),y)\nBAR_DEPENDENCIES += foo\nBAR_CONF_OPTS += --enable-foo\nelse\nBAR_CONF_OPTS += --disable-foo\nendif\n\nBest regards,\n\nThomas","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","buildroot@lists.busybox.net"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","buildroot@osuosl.org"],"Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=busybox.net\n\t(client-ip=140.211.166.133; helo=hemlock.osuosl.org;\n\tenvelope-from=buildroot-bounces@busybox.net;\n\treceiver=)","Received":["from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xnLzm2QsMz9s9Y\n\tfor ;\n\tWed, 6 Sep 2017 21:32:52 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id BD2E0894D5;\n\tWed, 6 Sep 2017 11:32:50 +0000 (UTC)","from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id k7gGAuzqRmss; Wed, 6 Sep 2017 11:32:50 +0000 (UTC)","from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 321B188DD2;\n\tWed, 6 Sep 2017 11:32:50 +0000 (UTC)","from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id C39721C097A\n\tfor ;\n\tWed, 6 Sep 2017 11:32:48 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id BC750878A4\n\tfor ;\n\tWed, 6 Sep 2017 11:32:48 +0000 (UTC)","from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id mk-u32vizlmf for ;\n\tWed, 6 Sep 2017 11:32:47 +0000 (UTC)","from mail.free-electrons.com (mail.free-electrons.com [62.4.15.54])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id A24AF86638\n\tfor ; Wed, 6 Sep 2017 11:32:47 +0000 (UTC)","by mail.free-electrons.com (Postfix, from userid 110)\n\tid 04266209C6; Wed, 6 Sep 2017 13:32:45 +0200 (CEST)","from windsurf.lan (LStLambert-657-1-97-87.w90-63.abo.wanadoo.fr\n\t[90.63.216.87])\n\tby mail.free-electrons.com (Postfix) with ESMTPSA id D8DDD2079E;\n\tWed, 6 Sep 2017 13:32:44 +0200 (CEST)"],"X-Virus-Scanned":["amavisd-new at osuosl.org","amavisd-new at osuosl.org"],"X-Greylist":"domain auto-whitelisted by SQLgrey-1.7.6","Date":"Wed, 6 Sep 2017 13:32:45 +0200","From":"Thomas Petazzoni ","To":"Aleksander Morgado ","Message-ID":"<20170906133245.716cbbc6@windsurf.lan>","In-Reply-To":"","References":"<20170905100327.21421-1-aleksander@aleksander.es>\n\t<20170905213604.61141da0@windsurf.lan>\n\t","Organization":"Free Electrons","X-Mailer":"Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-redhat-linux-gnu)","MIME-Version":"1.0","Cc":"buildroot@buildroot.org","Subject":"Re: [Buildroot] [PATCH] libqmi: udev and qmi-over-mbim are optional","X-BeenThere":"buildroot@busybox.net","X-Mailman-Version":"2.1.18-1","Precedence":"list","List-Id":"Discussion and development of buildroot ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"buildroot-bounces@busybox.net","Sender":"\"buildroot\" "}}]