[{"id":1765511,"web_url":"http://patchwork.ozlabs.org/comment/1765511/","msgid":"<20170908164815.GE7356@vergenet.net>","list_archive_url":null,"date":"2017-09-08T16:48:16","subject":"Re: [ovs-dev] [PATCH v2 8/8] netdev-dpdk: set FDIR config","submitter":{"id":64714,"url":"http://patchwork.ozlabs.org/api/people/64714/","name":"Simon Horman","email":"simon.horman@netronome.com"},"content":"On Tue, Sep 05, 2017 at 05:23:01PM +0800, Yuanhan Liu wrote:\n> From: Finn Christensen \n> \n> The Intel i40e PMD driver requires the fdir mode set to\n> RTE_FDIR_MODE_PERFECT, otherwise, the flow creation would\n> be failed.\n\nThis appears to update a setting that is used more broadly than\nwith the hardware cited above. I'd value some discussion\nof whether that is safe/appropriate/etc... ?\n\n...","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","ovs-dev@mail.linuxfoundation.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=netronome-com.20150623.gappssmtp.com\n\theader.i=@netronome-com.20150623.gappssmtp.com\n\theader.b=\"gBVQvrmx\"; dkim-atps=neutral"],"Received":["from mail.linuxfoundation.org (mail.linuxfoundation.org\n\t[140.211.169.12])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xpjv93Bhmz9s7h\n\tfor ;\n\tSat, 9 Sep 2017 02:48:37 +1000 (AEST)","from mail.linux-foundation.org (localhost [127.0.0.1])\n\tby mail.linuxfoundation.org (Postfix) with ESMTP id 115B5BC6;\n\tFri, 8 Sep 2017 16:48:18 +0000 (UTC)","from smtp1.linuxfoundation.org (smtp1.linux-foundation.org\n\t[172.17.192.35])\n\tby mail.linuxfoundation.org (Postfix) with ESMTPS id 890E5B49\n\tfor ; Fri, 8 Sep 2017 16:48:17 +0000 (UTC)","from mail-wm0-f42.google.com (mail-wm0-f42.google.com\n\t[74.125.82.42])\n\tby smtp1.linuxfoundation.org (Postfix) with ESMTPS id 1C56546D\n\tfor ; Fri, 8 Sep 2017 16:48:17 +0000 (UTC)","by mail-wm0-f42.google.com with SMTP id i189so8210788wmf.1\n\tfor ; Fri, 08 Sep 2017 09:48:16 -0700 (PDT)","from vergenet.net (53.red-80-24-208.staticip.rima-tde.net.\n\t[80.24.208.53]) by smtp.gmail.com with ESMTPSA id\n\tg7sm1404518wrb.78.2017.09.08.09.48.14\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tFri, 08 Sep 2017 09:48:15 -0700 (PDT)"],"X-Greylist":"whitelisted by SQLgrey-1.7.6","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=netronome-com.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:in-reply-to:user-agent;\n\tbh=Fx//y45sdPJ/R1VAdd8XHKrrkBE4E9XCdYtOxLCf4tM=;\n\tb=gBVQvrmxmjewOwJ/QpNET+KcnVFw4i86YY4sTuZNyuogih1RkR8GyfRTJzLknz/tbY\n\tFlTaf8SglRQXOO2STd5jUUlk6h5uGn/LEaaIM/Q22LLhNuhCCRhLA5f4uOaRapjhrMe5\n\tYjc7MBvMHXcrPFeeYR1opS6+SlA8v8lKW2LyhohoISQ+e36rg/O3XFGDzWfvKHHvuvb8\n\tNyLZ58Yl3D2vbOgaDGpJZIxP7RNzDURtAXYeWAGD0ucBHq9atTmR5lqYAYA/dBBMPSwb\n\tik8qhE0ylOqAQQxScEUpavOuinnH1RnYbzRTg+GSmVLuVQatPjdHVixw+c74wr+4axCA\n\tzZuw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:in-reply-to:user-agent;\n\tbh=Fx//y45sdPJ/R1VAdd8XHKrrkBE4E9XCdYtOxLCf4tM=;\n\tb=Bj2nhDzpr7lw4JlKRxWnBk1phvO7TDjh/uISHGMIvkG9e7EToj0dYFvQRFIYtUETs0\n\tGquPb7zP0vjpbHeexTrFjf19B2RYiWMFEyr9HToxF/GRbJZ84OgiJH4SyLDeh0kY7BrZ\n\tI3FV2CjgQ/KKl5FO1Nm2XKwRHsuSD3JX+m4d/X1echnmhx87jHJGRKfDsKfv1QRRAuUG\n\tJy71JSS4gdmpVq3RonqD/kWxVuEjeNojhcvrWGiK0TusPpvxCDNiPKPERTAZE7Q83hT7\n\te4ff8ev2lB8wndmbCv2y5DAR0d3oMZFq3seDKMgHC5kYP2MQ9e7cndyTensFTk/ofLEt\n\tzJDA==","X-Gm-Message-State":"AHPjjUjgpf6qNf8p42hHbW/P1mhn/9HuCpPGrKnWANXd5O/7iBVMcUBL\n\tG4ERs5IASz2r+AdPA5LxyEM9vzkjRLE=","X-Google-Smtp-Source":"AOwi7QDPvtC6/e/MnmgMFGQxw90y3/u/fb8hlo0KSC0k3Wu+JewsaHMPbO7n6o2m3Om2EIkp9bODaA==","X-Received":"by 10.28.188.86 with SMTP id m83mr1996792wmf.83.1504889295766;\n\tFri, 08 Sep 2017 09:48:15 -0700 (PDT)","Date":"Fri, 8 Sep 2017 18:48:16 +0200","From":"Simon Horman ","To":"Yuanhan Liu ","Message-ID":"<20170908164815.GE7356@vergenet.net>","References":"<1504603381-30071-1-git-send-email-yliu@fridaylinux.org>\n\t<1504603381-30071-9-git-send-email-yliu@fridaylinux.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<1504603381-30071-9-git-send-email-yliu@fridaylinux.org>","User-Agent":"Mutt/1.5.23 (2014-03-12)","X-Spam-Status":"No, score=0.0 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,\n\tRCVD_IN_DNSWL_NONE autolearn=disabled version=3.3.1","X-Spam-Checker-Version":"SpamAssassin 3.3.1 (2010-03-16) on\n\tsmtp1.linux-foundation.org","Cc":"dev@openvswitch.org","Subject":"Re: [ovs-dev] [PATCH v2 8/8] netdev-dpdk: set FDIR config","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.12","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"ovs-dev-bounces@openvswitch.org","Errors-To":"ovs-dev-bounces@openvswitch.org"}},{"id":1766059,"web_url":"http://patchwork.ozlabs.org/comment/1766059/","msgid":"<20170911062039.GO9736@yliu-home>","list_archive_url":null,"date":"2017-09-11T06:20:39","subject":"Re: [ovs-dev] [PATCH v2 8/8] netdev-dpdk: set FDIR config","submitter":{"id":72215,"url":"http://patchwork.ozlabs.org/api/people/72215/","name":"Yuanhan Liu","email":"yliu@fridaylinux.org"},"content":"On Fri, Sep 08, 2017 at 06:48:16PM +0200, Simon Horman wrote:\n> On Tue, Sep 05, 2017 at 05:23:01PM +0800, Yuanhan Liu wrote:\n> > From: Finn Christensen \n> > \n> > The Intel i40e PMD driver requires the fdir mode set to\n> > RTE_FDIR_MODE_PERFECT, otherwise, the flow creation would\n> > be failed.\n> \n> This appears to update a setting that is used more broadly than\n> with the hardware cited above. I'd value some discussion\n> of whether that is safe/appropriate/etc... ?\n\nSure, and comments are welcome. For Mellanox, AFAIK, the setting is\nignored.\n\n\t--yliu","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","ovs-dev@mail.linuxfoundation.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=fridaylinux-org.20150623.gappssmtp.com\n\theader.i=@fridaylinux-org.20150623.gappssmtp.com\n\theader.b=\"dueiNset\"; dkim-atps=neutral"],"Received":["from mail.linuxfoundation.org (mail.linuxfoundation.org\n\t[140.211.169.12])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xrHqS1nqkz9s76\n\tfor ;\n\tMon, 11 Sep 2017 16:20:52 +1000 (AEST)","from mail.linux-foundation.org (localhost [127.0.0.1])\n\tby mail.linuxfoundation.org (Postfix) with ESMTP id 46793AA6;\n\tMon, 11 Sep 2017 06:20:50 +0000 (UTC)","from smtp1.linuxfoundation.org (smtp1.linux-foundation.org\n\t[172.17.192.35])\n\tby mail.linuxfoundation.org (Postfix) with ESMTPS id 780DEA91\n\tfor ; Mon, 11 Sep 2017 06:20:49 +0000 (UTC)","from mail-pg0-f44.google.com (mail-pg0-f44.google.com\n\t[74.125.83.44])\n\tby smtp1.linuxfoundation.org (Postfix) with ESMTPS id 1F515E0\n\tfor ; Mon, 11 Sep 2017 06:20:49 +0000 (UTC)","by mail-pg0-f44.google.com with SMTP id j16so3417558pga.1\n\tfor ; Sun, 10 Sep 2017 23:20:49 -0700 (PDT)","from yliu-home ([45.63.61.64]) by smtp.gmail.com with ESMTPSA id\n\ty74sm14596543pfa.164.2017.09.10.23.20.45\n\t(version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tSun, 10 Sep 2017 23:20:47 -0700 (PDT)"],"X-Greylist":"whitelisted by SQLgrey-1.7.6","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=fridaylinux-org.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:in-reply-to:user-agent;\n\tbh=QO/QvyqqN99ufqZSm6v4cWjAWa534e1b+49iI6hI5Ng=;\n\tb=dueiNsetgmzrmrnvpgTfQum4W7oaToT0Pd7BHixY2RL5o8RmOta3leuaxrLx3+dRvQ\n\tDU2o7NBj31aIvbrsyV9Ri0NiN2PfQsbR4mdiegUFgEzg2Kzj31TFWUqliDnjrOfbr+Fg\n\tZ065ZCf7anUkIXNhiFyNwtE/QxItqpuN9xX5Oq/hJGLJ2mXQGTE9uSsoSgk2+GolYqtQ\n\tja5/0PL4sNJvstNLqkZThWQ/mNztYW+DObeUHKd0RR60uVyy8rAkgyqElQcxhof7BiiA\n\tqD9nK0TeoPWC+veAljNFiDv5LmB4IFJH8o6PSMva5YTi06n+3qrVBHPheIsr5Ie7Vx2q\n\td1ug==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:in-reply-to:user-agent;\n\tbh=QO/QvyqqN99ufqZSm6v4cWjAWa534e1b+49iI6hI5Ng=;\n\tb=nSBoGrwFOJGzpB9Gz9t+zsGYY97YW6O7fOsirPMgtYhclDgG6y+bBdHVm035p/kwWW\n\tncOIGOvoczqGcGyWa6lsk/M4ACMUnvW+2VHpXBNNr8NlvOUojfqmgpQ2Ys70X6esePmD\n\tI4ACe/1KDYkOJAUXXj3FXWcf790u22sqcJ2z4Y/wfUvquyXGRGkgUWbSAWnUEYK5xyBu\n\t3V1RVHSSLrmuKsvVT+7a9SHSwA4wT4q/nDxTNWdjPA561WoXuAo4eGBSOT6/qfwEq1el\n\tFGgOoiZS5xHNwTDmGO7vafBTozfW0UxBzietVfUPKMx24Nw2DYe7E0QlW6a6/hY/xEsB\n\tHMJA==","X-Gm-Message-State":"AHPjjUiRVCIP8Ho0JZItwtO0Z8JZtad15eS85JxSzi3fMoYXB7Q1mD8T\n\tEi7E3w89jZ4HTZ3H","X-Google-Smtp-Source":"ADKCNb55lHyFJ2iSow3bEGKEueOKIFAkP6jqriBpolfiYa/9HOsKIJLSWuEpjFONW1i4O1Y8p7HFiA==","X-Received":"by 10.98.245.74 with SMTP id n71mr11094969pfh.102.1505110848820; \n\tSun, 10 Sep 2017 23:20:48 -0700 (PDT)","Date":"Mon, 11 Sep 2017 14:20:39 +0800","From":"Yuanhan Liu ","To":"Simon Horman ","Message-ID":"<20170911062039.GO9736@yliu-home>","References":"<1504603381-30071-1-git-send-email-yliu@fridaylinux.org>\n\t<1504603381-30071-9-git-send-email-yliu@fridaylinux.org>\n\t<20170908164815.GE7356@vergenet.net>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20170908164815.GE7356@vergenet.net>","User-Agent":"Mutt/1.5.24 (2015-08-30)","X-Spam-Status":"No, score=0.0 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,\n\tRCVD_IN_DNSWL_NONE autolearn=disabled version=3.3.1","X-Spam-Checker-Version":"SpamAssassin 3.3.1 (2010-03-16) on\n\tsmtp1.linux-foundation.org","Cc":"dev@openvswitch.org","Subject":"Re: [ovs-dev] [PATCH v2 8/8] netdev-dpdk: set FDIR config","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.12","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"ovs-dev-bounces@openvswitch.org","Errors-To":"ovs-dev-bounces@openvswitch.org"}},{"id":1766104,"web_url":"http://patchwork.ozlabs.org/comment/1766104/","msgid":"<2EF2F5C0CC56984AA024D0B180335FCB4221DE68@IRSMSX102.ger.corp.intel.com>","list_archive_url":null,"date":"2017-09-11T07:42:57","subject":"Re: [ovs-dev] [PATCH v2 8/8] netdev-dpdk: set FDIR config","submitter":{"id":67440,"url":"http://patchwork.ozlabs.org/api/people/67440/","name":"Chandran, Sugesh","email":"sugesh.chandran@intel.com"},"content":"Regards\n_Sugesh\n\n\n> -----Original Message-----\n> From: ovs-dev-bounces@openvswitch.org [mailto:ovs-dev-\n> bounces@openvswitch.org] On Behalf Of Yuanhan Liu\n> Sent: Tuesday, September 5, 2017 10:23 AM\n> To: dev@openvswitch.org\n> Subject: [ovs-dev] [PATCH v2 8/8] netdev-dpdk: set FDIR config\n> \n> From: Finn Christensen \n> \n> The Intel i40e PMD driver requires the fdir mode set to\n> RTE_FDIR_MODE_PERFECT, otherwise, the flow creation would be failed.\n[Sugesh] this means it doesn't honor the flow masks which passed onto rte_flow_*?\n> \n> Co-authored-by: Yuanhan Liu \n> Signed-off-by: Finn Christensen \n> Signed-off-by: Yuanhan Liu \n> ---\n> ---\n> lib/netdev-dpdk.c | 3 +++\n> 1 file changed, 3 insertions(+)\n> \n> diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c index e363c92..beb7b68\n> 100644\n> --- a/lib/netdev-dpdk.c\n> +++ b/lib/netdev-dpdk.c\n> @@ -177,6 +177,9 @@ static const struct rte_eth_conf port_conf = {\n> .txmode = {\n> .mq_mode = ETH_MQ_TX_NONE,\n> },\n> + .fdir_conf = {\n> + .mode = RTE_FDIR_MODE_PERFECT,\n> + },\n> };\n> \n> /*\n> --\n> 2.7.4\n> \n> _______________________________________________\n> dev mailing list\n> dev@openvswitch.org\n> https://mail.openvswitch.org/mailman/listinfo/ovs-dev","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","ovs-dev@mail.linuxfoundation.org"],"Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=)","Received":["from mail.linuxfoundation.org (mail.linuxfoundation.org\n\t[140.211.169.12])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xrKg40zy8z9s7F\n\tfor ;\n\tMon, 11 Sep 2017 17:43:44 +1000 (AEST)","from mail.linux-foundation.org (localhost [127.0.0.1])\n\tby mail.linuxfoundation.org (Postfix) with ESMTP id DC6CDB12;\n\tMon, 11 Sep 2017 07:43:01 +0000 (UTC)","from smtp1.linuxfoundation.org (smtp1.linux-foundation.org\n\t[172.17.192.35])\n\tby mail.linuxfoundation.org (Postfix) with ESMTPS id 1961F5A7\n\tfor ; Mon, 11 Sep 2017 07:43:01 +0000 (UTC)","from mga14.intel.com (mga14.intel.com [192.55.52.115])\n\tby smtp1.linuxfoundation.org (Postfix) with ESMTPS id ACB40A1\n\tfor ; Mon, 11 Sep 2017 07:43:00 +0000 (UTC)","from fmsmga004.fm.intel.com ([10.253.24.48])\n\tby fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t11 Sep 2017 00:43:00 -0700","from irsmsx153.ger.corp.intel.com ([163.33.192.75])\n\tby fmsmga004.fm.intel.com with ESMTP; 11 Sep 2017 00:42:59 -0700","from irsmsx111.ger.corp.intel.com (10.108.20.4) by\n\tIRSMSX153.ger.corp.intel.com (163.33.192.75) with Microsoft SMTP\n\tServer (TLS) id 14.3.319.2; Mon, 11 Sep 2017 08:42:58 +0100","from irsmsx102.ger.corp.intel.com ([169.254.2.59]) by\n\tirsmsx111.ger.corp.intel.com ([169.254.2.30]) with mapi id\n\t14.03.0319.002; Mon, 11 Sep 2017 08:42:58 +0100"],"X-Greylist":"domain auto-whitelisted by SQLgrey-1.7.6","X-ExtLoop1":"1","X-IronPort-AV":"E=Sophos;i=\"5.42,376,1500966000\"; d=\"scan'208\";a=\"310217804\"","From":"\"Chandran, Sugesh\" ","To":"'Yuanhan Liu' , \"dev@openvswitch.org\"\n\t","Thread-Topic":"[ovs-dev] [PATCH v2 8/8] netdev-dpdk: set FDIR config","Thread-Index":"AQHTJimP9HuhVbRUNEaNJEmtDMrOxaKuKvaQ","Date":"Mon, 11 Sep 2017 07:42:57 +0000","Message-ID":"<2EF2F5C0CC56984AA024D0B180335FCB4221DE68@IRSMSX102.ger.corp.intel.com>","References":"<1504603381-30071-1-git-send-email-yliu@fridaylinux.org>\n\t<1504603381-30071-9-git-send-email-yliu@fridaylinux.org>","In-Reply-To":"<1504603381-30071-9-git-send-email-yliu@fridaylinux.org>","Accept-Language":"en-US","Content-Language":"en-US","X-MS-Has-Attach":"","X-MS-TNEF-Correlator":"","x-titus-metadata-40":"eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNTg3YWZmMWUtOTQ4Yi00NGEwLWE5NmYtMTM5NGY3OWJhNDczIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX1BVQkxJQyJ9XX1dfSwiU3ViamVjdExhYmVscyI6W10sIlRNQ1ZlcnNpb24iOiIxNi41LjkuMyIsIlRydXN0ZWRMYWJlbEhhc2giOiJWbVNRUTNMWGxabkNmTUpKV29vMVwvWTVoUTJybkNkUkE2TXh4dFdteFpwaz0ifQ==","x-ctpclassification":"CTP_PUBLIC","dlp-product":"dlpe-windows","dlp-version":"11.0.0.116","dlp-reaction":"no-action","x-originating-ip":"[163.33.239.181]","MIME-Version":"1.0","X-Spam-Status":"No, score=-5.0 required=5.0 tests=RCVD_IN_DNSWL_HI,\n\tRP_MATCHES_RCVD autolearn=disabled version=3.3.1","X-Spam-Checker-Version":"SpamAssassin 3.3.1 (2010-03-16) on\n\tsmtp1.linux-foundation.org","Subject":"Re: [ovs-dev] [PATCH v2 8/8] netdev-dpdk: set FDIR config","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.12","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"ovs-dev-bounces@openvswitch.org","Errors-To":"ovs-dev-bounces@openvswitch.org"}},{"id":1766114,"web_url":"http://patchwork.ozlabs.org/comment/1766114/","msgid":"<20170911075441.GR9736@yliu-home>","list_archive_url":null,"date":"2017-09-11T07:54:41","subject":"Re: [ovs-dev] [PATCH v2 8/8] netdev-dpdk: set FDIR config","submitter":{"id":72215,"url":"http://patchwork.ozlabs.org/api/people/72215/","name":"Yuanhan Liu","email":"yliu@fridaylinux.org"},"content":"On Mon, Sep 11, 2017 at 07:42:57AM +0000, Chandran, Sugesh wrote:\n> \n> \n> Regards\n> _Sugesh\n> \n> \n> > -----Original Message-----\n> > From: ovs-dev-bounces@openvswitch.org [mailto:ovs-dev-\n> > bounces@openvswitch.org] On Behalf Of Yuanhan Liu\n> > Sent: Tuesday, September 5, 2017 10:23 AM\n> > To: dev@openvswitch.org\n> > Subject: [ovs-dev] [PATCH v2 8/8] netdev-dpdk: set FDIR config\n> > \n> > From: Finn Christensen \n> > \n> > The Intel i40e PMD driver requires the fdir mode set to\n> > RTE_FDIR_MODE_PERFECT, otherwise, the flow creation would be failed.\n> [Sugesh] this means it doesn't honor the flow masks which passed onto rte_flow_*?\n\nIIRC, that's what I found after divig the code. It's an issue reported/fixed\nby Finn. I also don't have the nic for testing.\n\n\t--yliu","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","ovs-dev@mail.linuxfoundation.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=fridaylinux-org.20150623.gappssmtp.com\n\theader.i=@fridaylinux-org.20150623.gappssmtp.com\n\theader.b=\"N/HzQanE\"; dkim-atps=neutral"],"Received":["from mail.linuxfoundation.org (mail.linuxfoundation.org\n\t[140.211.169.12])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xrKvy5cPCz9s81\n\tfor ;\n\tMon, 11 Sep 2017 17:54:54 +1000 (AEST)","from mail.linux-foundation.org (localhost [127.0.0.1])\n\tby mail.linuxfoundation.org (Postfix) with ESMTP id 5E768AD5;\n\tMon, 11 Sep 2017 07:54:52 +0000 (UTC)","from smtp1.linuxfoundation.org (smtp1.linux-foundation.org\n\t[172.17.192.35])\n\tby mail.linuxfoundation.org (Postfix) with ESMTPS id 054149FA\n\tfor ; Mon, 11 Sep 2017 07:54:51 +0000 (UTC)","from mail-pf0-f179.google.com (mail-pf0-f179.google.com\n\t[209.85.192.179])\n\tby smtp1.linuxfoundation.org (Postfix) with ESMTPS id B1CE6180\n\tfor ; Mon, 11 Sep 2017 07:54:50 +0000 (UTC)","by mail-pf0-f179.google.com with SMTP id e1so12921635pfk.1\n\tfor ; Mon, 11 Sep 2017 00:54:50 -0700 (PDT)","from yliu-home ([45.63.61.64]) by smtp.gmail.com with ESMTPSA id\n\ts184sm14690889pfb.123.2017.09.11.00.54.47\n\t(version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tMon, 11 Sep 2017 00:54:48 -0700 (PDT)"],"X-Greylist":"whitelisted by SQLgrey-1.7.6","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=fridaylinux-org.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:in-reply-to:user-agent;\n\tbh=1VF3+RBTJnH7ZCY/kRAvSrISz41DKuUnaa+E8AN3Swc=;\n\tb=N/HzQanEWt5+spUIuJxEV6nhp/i0wnkftT2vwqkwQmPvc8GNGxBbtEHjdPeqAnVuWC\n\tNjoSUcSFOmlwtsSlUqz9MZ4lK0xNuwB8Ehs9rrRUCtu9H5LQfwJJYyOkuY71OeImxV0n\n\tpUGObK2sAR1fE0HqeIcljUkNoqRnHywv/AbIvVyKEyFc4jRFpfY2KtqJgP8owS2mwE77\n\tO9vJ4e4ZrW9CBYGX7vjHgqZYXijuRZkluBozB2raZJITuiZSZTCIuJ0CZobOQl0PWYIi\n\tdYAwXKmpchTQPdckqn4vodBw2SRnVHz7iOj5dwsv9Edzl5f3kJRP5h+Rz1aXQiCAmLRC\n\tyotA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:in-reply-to:user-agent;\n\tbh=1VF3+RBTJnH7ZCY/kRAvSrISz41DKuUnaa+E8AN3Swc=;\n\tb=rJB4Ka1LIsr/c/lcu9/XOkCKSK3M5l/lycVzIqo4qYsjrLuIE0vaD7F1/5gIUyl8yz\n\tBvLDiNGF1i+vqqau3V+lXNgwYcKLHuS+2OvryB1XGDb/e57eF+lYy1LxHalG267DHE5P\n\tgjgnDBBIiEs2NTGU4G78jQjaoBhKviABBpyGyehMxV/3VZiscbhvF0WLu3/WN4GRTv2I\n\tth8Y6y7HGk1hQ/YidBvn3yDO/h2W7mv0Nc3eGBoE9Yr+XKXm6En8rYnYQ73Qtp9RdfSH\n\ti6nzcxdMGXeD52UEc2OZOwTQi1fAH+dsV/7J86jUyzaAv/AhZXU79VzxPSEnKOVXtJRh\n\tBJQw==","X-Gm-Message-State":"AHPjjUgXpR4XxdlAculndZTCj8+YhJg3F6AqaV8FYjLTzSTDHWWZs5f3\n\tuMokP3G12LfsbgBa","X-Google-Smtp-Source":"ADKCNb7wWujeLzpqrEkO+yPowJgh2g5IaXhF1i20cwy+e6WfwkxmEiS/6rXq9eOWC49fYtQyIOeGFQ==","X-Received":"by 10.98.75.193 with SMTP id d62mr11272641pfj.281.1505116490191; \n\tMon, 11 Sep 2017 00:54:50 -0700 (PDT)","Date":"Mon, 11 Sep 2017 15:54:41 +0800","From":"Yuanhan Liu ","To":"\"Chandran, Sugesh\" ","Message-ID":"<20170911075441.GR9736@yliu-home>","References":"<1504603381-30071-1-git-send-email-yliu@fridaylinux.org>\n\t<1504603381-30071-9-git-send-email-yliu@fridaylinux.org>\n\t<2EF2F5C0CC56984AA024D0B180335FCB4221DE68@IRSMSX102.ger.corp.intel.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<2EF2F5C0CC56984AA024D0B180335FCB4221DE68@IRSMSX102.ger.corp.intel.com>","User-Agent":"Mutt/1.5.24 (2015-08-30)","X-Spam-Status":"No, score=0.5 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,\n\tRCVD_IN_DNSWL_NONE,\n\tRCVD_IN_SORBS_SPAM autolearn=disabled version=3.3.1","X-Spam-Checker-Version":"SpamAssassin 3.3.1 (2010-03-16) on\n\tsmtp1.linux-foundation.org","Cc":"\"dev@openvswitch.org\" ","Subject":"Re: [ovs-dev] [PATCH v2 8/8] netdev-dpdk: set FDIR config","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.12","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"ovs-dev-bounces@openvswitch.org","Errors-To":"ovs-dev-bounces@openvswitch.org"}},{"id":1766121,"web_url":"http://patchwork.ozlabs.org/comment/1766121/","msgid":"","list_archive_url":null,"date":"2017-09-11T08:14:28","subject":"Re: [ovs-dev] [PATCH v2 8/8] netdev-dpdk: set FDIR config","submitter":{"id":72305,"url":"http://patchwork.ozlabs.org/api/people/72305/","name":"Finn Christensen","email":"fc@napatech.com"},"content":"-----Original Message-----\nFrom: ovs-dev-bounces@openvswitch.org [mailto:ovs-dev-bounces@openvswitch.org] On Behalf Of Yuanhan Liu\nSent: 11. september 2017 09:55\nTo: Chandran, Sugesh \nCc: dev@openvswitch.org\nSubject: Re: [ovs-dev] [PATCH v2 8/8] netdev-dpdk: set FDIR config\n\nOn Mon, Sep 11, 2017 at 07:42:57AM +0000, Chandran, Sugesh wrote:\n> \n> \n> Regards\n> _Sugesh\n> \n> \n> > -----Original Message-----\n> > From: ovs-dev-bounces@openvswitch.org [mailto:ovs-dev- \n> > bounces@openvswitch.org] On Behalf Of Yuanhan Liu\n> > Sent: Tuesday, September 5, 2017 10:23 AM\n> > To: dev@openvswitch.org\n> > Subject: [ovs-dev] [PATCH v2 8/8] netdev-dpdk: set FDIR config\n> > \n> > From: Finn Christensen \n> > \n> > The Intel i40e PMD driver requires the fdir mode set to \n> > RTE_FDIR_MODE_PERFECT, otherwise, the flow creation would be failed.\n> [Sugesh] this means it doesn't honor the flow masks which passed onto rte_flow_*?\n\nIIRC, that's what I found after divig the code. It's an issue reported/fixed by Finn. I also don't have the nic for testing.\n\n[Finn] Yes, this was needed to make our test setup using an XL710 work, with the rte_flow implementation.\nIt's a while ago so I don't exactly remember how we ended up with this solution. However, we are definitely not\nIntel XL710 experts, so there might be other ways to achieve the rte_flow functionality.\nThis issue, and problem raised about the overall change in configuration impact on NICs using this setting (Napatech \ndoes not use it), I think should be reviewed/verified by NIC vendors using it.\n\n\t--yliu","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","ovs-dev@mail.linuxfoundation.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=napatech.com header.i=@napatech.com\n\theader.b=\"El1PYRa7\"; dkim-atps=neutral"],"Received":["from mail.linuxfoundation.org (mail.linuxfoundation.org\n\t[140.211.169.12])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xrLLh6s1qz9s81\n\tfor ;\n\tMon, 11 Sep 2017 18:14:36 +1000 (AEST)","from mail.linux-foundation.org (localhost [127.0.0.1])\n\tby mail.linuxfoundation.org (Postfix) with ESMTP id 6F21FAB8;\n\tMon, 11 Sep 2017 08:14:34 +0000 (UTC)","from smtp1.linuxfoundation.org (smtp1.linux-foundation.org\n\t[172.17.192.35])\n\tby mail.linuxfoundation.org (Postfix) with ESMTPS id 50FA28E3\n\tfor ; Mon, 11 Sep 2017 08:14:32 +0000 (UTC)","from mail01.napatech.com (mail01.napatech.com [188.120.77.121])\n\tby smtp1.linuxfoundation.org (Postfix) with ESMTPS id 683A218F\n\tfor ; Mon, 11 Sep 2017 08:14:31 +0000 (UTC)","from cph-gen-exch02.napatech.com (10.240.1.84) by\n\tcph-gen-exch02.napatech.com (10.240.1.84) with Microsoft SMTP Server\n\t(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id\n\t15.1.1034.26; Mon, 11 Sep 2017 10:14:28 +0200","from cph-gen-exch02.napatech.com ([fe80::581:51a1:ac3f:84e]) by\n\tcph-gen-exch02.napatech.com ([fe80::581:51a1:ac3f:84e%12]) with mapi\n\tid 15.01.1034.026; Mon, 11 Sep 2017 10:14:28 +0200"],"X-Greylist":"domain auto-whitelisted by SQLgrey-1.7.6","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=napatech.com; i=@napatech.com; q=dns/txt; s=mar2017;\n\tt=1505117670; x=1536653670;\n\th=from:to:cc:subject:date:message-id:references:\n\tin-reply-to:content-transfer-encoding:mime-version;\n\tbh=tgTEkjD7T2Zv+gdWNur5aHyMbUHXmH6WtIKstnpvfzE=;\n\tb=El1PYRa7o85LPyjHfQw2QJGzHbzio1T0WJJJOlnYzTv8pMfo1q0TzTpB\n\tjVsvIjzeYxsPPAGbnFIKwu/i/xLYgQpANjTSSflIm14Lin7a1vueZmP59\n\tLsTkiVrfsniSE7qGQUgD/+VWhJZtvpj1w4B/lS1wo01Bhn/xbubCN4hi+\n\tPCimiuMmYBAYgofx5XPTwB768isEPkTAkE6CKJhQrfHNBwm0198CtTydx\n\tz0u1KJIvkyTSudiN4spKBPCOQIwds4L1jmohLzBFkH9YhAFLK1B9uOg3Q\n\tRzfgyq60Z15hyop2HnOigTsrBHdQ+/vRi0dv5PTJ3EsMCcEYAZH5wIMey Q==;","IronPort-PHdr":"9a23:Uf81OhS2FnWJjI4Z0b4JfrNtt9psv+yvbD5Q0YIujvd0So/mwa6zZheN2/xhgRfzUJnB7Loc0qyN4vGmAj1Lsc3JmUtBWaQEbwUCh8QSkl5oK+++Imq/EsTXaTcnFt9JTl5v8iLzG0FUHMHjew+a+SXqvnYdFRrlKAV6OPn+FJLMgMSrzeCy/IDYbxlViDanb75/KBG7oR/fu8QSjodvKag8wQbVr3VVfOhb2XlmLk+JkRbm4cew8p9j8yBOtP8k6sVNT6b0cbkmQLJBFDgpPHw768PttRnYUAuA/WAcXXkMkhpJGAfK8hf3VYrsvyTgt+p93C6aPdDqTb0xRD+v4btnRAPuhSwaLDMy7n3ZhdJsg6JauBKhpgJww4jIYIGOKfFyerrRcc4GSWZdW8pcUTFKDIGhYIsVF+cPPfhWoZThp1UArhW+CwujBOLzxTFHiXD7xrE60/0jEQ3awAAsA8wCvXLJp9v1LqcSVuW1wbHIwzXCafNW3yr25ZbIchA7oPGMRq5wftTXyUk0CQzFiEibpIvrPzyJzekNtXKU7/J6WuKzlWEotwFxriKzyccrj4nEn4QYwU3K+yV+xYY6P9y4SEhjbN6jCJtfqSeaN5VtQsIsQmFopDo1yr0ctZ68ZigKx5IqzAPcZfyfa4WE/w7vWPyPLTp3mH5pYq+ziwyx/EWv0uHwS9W43ExUoidKjtXArG0B2wDJ5sSZRPZw+l+t2TiR2A3Q9u1JJEU5mKrYJpI8x7M9locfvl7eEiLzgkr5kKGbdksh9+Wr5OnofLPrrYKGOYBukAHxKKEul9S6AeQ/LwcBQXCW+f+51L3/5U35R6hKjuEunqnZrp/aIcMbq7a8AwBP04Yj7wyzDzG839QAh3YHMExKdw6Hj4TzJ17OJ/X4Ae++g1Sqjjhr2+jLMqD9DpnXMHTOn6vtcaxg50JGywc+wshT55dOBbEAJPLzVFXxtNvdDhIhPQy73/3qCNNn2YMGQ22PHrGWP7/SsVOS+u0vJOyMaJcPuDnhM/gl++LujXghlFAAY6apw4AaaHegHvt4JUWZf2Hsg9kAEWcWogU+TPbmiFqYUT5cND6OWPcN+zg9CIugRaPCW8j5kbiAwQ+1BJxab3FCC1aRATHvbYrSH79GQyKbJMN7mzpAHYO8RII61Vvm4BTnxLd8Lqzf+iQeuYjq0vB04fHekVc58jkiXOqH1GTYYWBymCsjRyU3x7xyp1dwzB/X36NQhfVAHMBe7PMPWQA/Y82Ph9dmAsz/D1qSNuyCT0yrF5D/WWk8","X-IronPort-Anti-Spam-Filtered":"true","X-IronPort-Anti-Spam-Result":"A2GTAAAVRbZZ/1QB8ApbGgEBAQECAQEBAQgBAQEBFQEBAQECAQEBAQgBAQEBhBOBFQeOEZISlimCBgwKGAuFGwKEUxgBAQEBAQEBAQEBAQKBEIIzJAENcgEBAQEBAQEBAUwCDV0BAQEBAwEBODEDCwwEAgEIDgMEAQEBHgkHJwsUCQgCBA4FCBOKJq9LizQBAQEBAQEBAQEBAQEBAQEBAQEBAQEYBYMrg1KBY4MohFcBAYYSBYl/iRCNZYdbjG2SepR+AgICAgkCGoE5H4FGdxVKhxt2h1OBI4EPAQEB","X-IPAS-Result":"A2GTAAAVRbZZ/1QB8ApbGgEBAQECAQEBAQgBAQEBFQEBAQECAQEBAQgBAQEBhBOBFQeOEZISlimCBgwKGAuFGwKEUxgBAQEBAQEBAQEBAQKBEIIzJAENcgEBAQEBAQEBAUwCDV0BAQEBAwEBODEDCwwEAgEIDgMEAQEBHgkHJwsUCQgCBA4FCBOKJq9LizQBAQEBAQEBAQEBAQEBAQEBAQEBAQEYBYMrg1KBY4MohFcBAYYSBYl/iRCNZYdbjG2SepR+AgICAgkCGoE5H4FGdxVKhxt2h1OBI4EPAQEB","From":"Finn Christensen ","To":"Yuanhan Liu , \"Chandran, Sugesh\"\n\t","Thread-Topic":"[ovs-dev] [PATCH v2 8/8] netdev-dpdk: set FDIR config","Thread-Index":"AQHTJii2lNwhttGaYU+sb+Hi6lfzl6KvNVKAgAADR4CAACKa0A==","Date":"Mon, 11 Sep 2017 08:14:28 +0000","Message-ID":"","References":"<1504603381-30071-1-git-send-email-yliu@fridaylinux.org>\n\t<1504603381-30071-9-git-send-email-yliu@fridaylinux.org>\n\t<2EF2F5C0CC56984AA024D0B180335FCB4221DE68@IRSMSX102.ger.corp.intel.com>\n\t<20170911075441.GR9736@yliu-home>","In-Reply-To":"<20170911075441.GR9736@yliu-home>","Accept-Language":"da-DK, en-US","Content-Language":"en-US","X-MS-Has-Attach":"","X-MS-TNEF-Correlator":"","x-originating-ip":"[10.240.10.239]","MIME-Version":"1.0","X-Spam-Status":"No, score=-2.4 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,\n\tDKIM_VALID_AU,RCVD_IN_DNSWL_MED,RP_MATCHES_RCVD autolearn=disabled\n\tversion=3.3.1","X-Spam-Checker-Version":"SpamAssassin 3.3.1 (2010-03-16) on\n\tsmtp1.linux-foundation.org","Cc":"\"dev@openvswitch.org\" ","Subject":"Re: [ovs-dev] [PATCH v2 8/8] netdev-dpdk: set FDIR config","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.12","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"ovs-dev-bounces@openvswitch.org","Errors-To":"ovs-dev-bounces@openvswitch.org"}},{"id":1766755,"web_url":"http://patchwork.ozlabs.org/comment/1766755/","msgid":"","list_archive_url":null,"date":"2017-09-12T08:35:32","subject":"Re: [ovs-dev] [PATCH v2 8/8] netdev-dpdk: set FDIR config","submitter":{"id":68212,"url":"http://patchwork.ozlabs.org/api/people/68212/","name":"Darrell Ball","email":"dball@vmware.com"},"content":"On 9/10/17, 11:21 PM, \"ovs-dev-bounces@openvswitch.org on behalf of Yuanhan Liu\" wrote:\n\n On Fri, Sep 08, 2017 at 06:48:16PM +0200, Simon Horman wrote:\n > On Tue, Sep 05, 2017 at 05:23:01PM +0800, Yuanhan Liu wrote:\n > > From: Finn Christensen \n > > \n > > The Intel i40e PMD driver requires the fdir mode set to\n > > RTE_FDIR_MODE_PERFECT, otherwise, the flow creation would\n > > be failed.\n > \n > This appears to update a setting that is used more broadly than\n > with the hardware cited above. I'd value some discussion\n > of whether that is safe/appropriate/etc... ?\n \n Sure, and comments are welcome. For Mellanox, AFAIK, the setting is\n ignored.\n\n\n[Darrell] There was an earlier request that we explain the setting with a comment in the code itself. It is selectively honoured.\n\nFlow Director setting modes: none, signature or perfect.\nEnumerator:\nRTE_FDIR_MODE_NONE \tDisable FDIR support.\nRTE_FDIR_MODE_SIGNATURE \tEnable FDIR signature filter mode.\nRTE_FDIR_MODE_PERFECT \tEnable FDIR perfect filter mode.\nRTE_FDIR_MODE_PERFECT_MAC_VLAN \tEnable FDIR filter mode - MAC VLAN.\nRTE_FDIR_MODE_PERFECT_TUNNEL \tEnable FDIR filter mode - tunnel.\n\n\n\n \n \t--yliu\n _______________________________________________\n dev mailing list\n dev@openvswitch.org\n https://urldefense.proofpoint.com/v2/url?u=https-3A__mail.openvswitch.org_mailman_listinfo_ovs-2Ddev&d=DwICAg&c=uilaK90D4TOVoH58JNXRgQ&r=BVhFA09CGX7JQ5Ih-uZnsw&m=HgMbtZrcMFWRL4NcADpvGei5A-3TvTB8rd9Zodnc-b4&s=RF8VUON-r0t8-dSvGpKAdhrd8q8Zdl8Vjmj9d1Eev8I&e=","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","ovs-dev@mail.linuxfoundation.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=onevmw.onmicrosoft.com\n\theader.i=@onevmw.onmicrosoft.com header.b=\"LOfa0RtD\"; \n\tdkim-atps=neutral","spf=none (sender IP is )\n\tsmtp.mailfrom=dball@vmware.com; "],"Received":["from mail.linuxfoundation.org (mail.linuxfoundation.org\n\t[140.211.169.12])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xrymW0z0rz9s7g\n\tfor ;\n\tTue, 12 Sep 2017 18:35:39 +1000 (AEST)","from mail.linux-foundation.org (localhost [127.0.0.1])\n\tby mail.linuxfoundation.org (Postfix) with ESMTP id 6A94FAB9;\n\tTue, 12 Sep 2017 08:35:36 +0000 (UTC)","from smtp1.linuxfoundation.org (smtp1.linux-foundation.org\n\t[172.17.192.35])\n\tby mail.linuxfoundation.org (Postfix) with ESMTPS id DCB0BAB6\n\tfor ; Tue, 12 Sep 2017 08:35:34 +0000 (UTC)","from NAM03-CO1-obe.outbound.protection.outlook.com\n\t(mail-co1nam03on0074.outbound.protection.outlook.com [104.47.40.74])\n\tby smtp1.linuxfoundation.org (Postfix) with ESMTPS id 68CC6127\n\tfor ; Tue, 12 Sep 2017 08:35:34 +0000 (UTC)","from BLUPR05MB611.namprd05.prod.outlook.com (10.141.204.27) by\n\tBLUPR05MB306.namprd05.prod.outlook.com (10.141.23.148) with Microsoft\n\tSMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id\n\t15.20.56.4; Tue, 12 Sep 2017 08:35:32 +0000","from BLUPR05MB611.namprd05.prod.outlook.com ([10.141.204.27]) by\n\tBLUPR05MB611.namprd05.prod.outlook.com ([10.141.204.27]) with mapi id\n\t15.20.0056.010; Tue, 12 Sep 2017 08:35:32 +0000"],"X-Greylist":"whitelisted by SQLgrey-1.7.6","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=onevmw.onmicrosoft.com; s=selector1-vmware-com;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version;\n\tbh=BCvucPdxWzNmVOuq9qiZsYaD0pozI7RDSEpKRcFDXtU=;\n\tb=LOfa0RtDPfTr6IDucVUY0KXpCm1kvVKn71w7cfGIcjP8SjLewogLiZmiE3nDUnGJ/qJV4BmNziBvaB6DN60rIDGmHMHOfdd50AOnRwsHjS/iWYU+/hUqhRsdieIDxESZpUp5uXhWDZwFVdsGWzLp+30bwcZvqqaEQjJ3sAIWZcY=","From":"Darrell Ball ","To":"Yuanhan Liu , Simon Horman\n\t","Thread-Topic":"[ovs-dev] [PATCH v2 8/8] netdev-dpdk: set FDIR config","Thread-Index":"AQHTJii3HaN7Ulg3vUOiAKNi8TBjIKKrODcAgAQHpICAAUKqgA==","Date":"Tue, 12 Sep 2017 08:35:32 +0000","Message-ID":"","References":"<1504603381-30071-1-git-send-email-yliu@fridaylinux.org>\n\t<1504603381-30071-9-git-send-email-yliu@fridaylinux.org>\n\t<20170908164815.GE7356@vergenet.net>\n\t<20170911062039.GO9736@yliu-home>","In-Reply-To":"<20170911062039.GO9736@yliu-home>","Accept-Language":"en-US","Content-Language":"en-US","X-MS-Has-Attach":"","X-MS-TNEF-Correlator":"","user-agent":"Microsoft-MacOutlook/f.25.0.170815","authentication-results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=onevmw.onmicrosoft.com\n\theader.i=@onevmw.onmicrosoft.com header.b=\"LOfa0RtD\"; \n\tdkim-atps=neutral","spf=none (sender IP is )\n\tsmtp.mailfrom=dball@vmware.com; "],"x-originating-ip":"[73.162.236.45]","x-ms-publictraffictype":"Email","x-microsoft-exchange-diagnostics":"1; BLUPR05MB306;\n\t20:ThkOm93ZK+zeT1GR3quvAcFOon/e0V/IhdFFERJGxqXQvesg29cOHR7EDckMmipMko1eY2HSFg7mxccb+2E5xAU+kEe5QmChz8waPSyOTG3esQrIJ+CG82EXDc3AhqQ7gXjHIyFkTekIi1z8fIKHbnPcfYzItnsczQdaQ9+aXCU=","x-ms-exchange-antispam-srfa-diagnostics":"SSOS;","x-ms-office365-filtering-correlation-id":"85a83aff-72b2-4709-4998-08d4f9b93b75","x-microsoft-antispam":"UriScan:; BCL:0; PCL:0;\n\tRULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(300000503095)(300135400095)(2017052603199)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);\n\tSRVR:BLUPR05MB306; ","x-ms-traffictypediagnostic":"BLUPR05MB306:","x-exchange-antispam-report-test":"UriScan:(10436049006162)(216315784871565);","x-microsoft-antispam-prvs":"","x-exchange-antispam-report-cfa-test":"BCL:0; PCL:0;\n\tRULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(93006095)(93001095)(10201501046)(100000703101)(100105400095)(3002001)(6041248)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(20161123564025)(20161123558100)(20161123560025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);\n\tSRVR:BLUPR05MB306; BCL:0; PCL:0;\n\tRULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);\n\tSRVR:BLUPR05MB306; ","x-forefront-prvs":"042857DBB5","x-forefront-antispam-report":"SFV:NSPM;\n\tSFS:(10009020)(6009001)(24454002)(377454003)(189002)(199003)(8676002)(3660700001)(81166006)(3280700002)(6436002)(33656002)(68736007)(97736004)(105586002)(39060400002)(6506006)(14454004)(966005)(25786009)(101416001)(189998001)(4326008)(316002)(106356001)(2900100001)(81156014)(6306002)(93886005)(8936002)(6512007)(82746002)(53936002)(7736002)(2906002)(6246003)(77096006)(6116002)(2950100002)(5660300001)(102836003)(3846002)(229853002)(76176999)(478600001)(99286003)(50986999)(53546010)(575784001)(83716003)(6486002)(83506001)(305945005)(66066001)(54356999)(4001350100001)(86362001)(36756003);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:BLUPR05MB306;\n\tH:BLUPR05MB611.namprd05.prod.outlook.com; FPR:; SPF:None;\n\tPTR:InfoNoRecords; MX:1; A:1; LANG:en; ","received-spf":"None (protection.outlook.com: vmware.com does not designate\n\tpermitted sender hosts)","spamdiagnosticoutput":"1:99","spamdiagnosticmetadata":"NSPM","Content-ID":"","MIME-Version":"1.0","X-OriginatorOrg":"vmware.com","X-MS-Exchange-CrossTenant-originalarrivaltime":"12 Sep 2017 08:35:32.6797\n\t(UTC)","X-MS-Exchange-CrossTenant-fromentityheader":"Hosted","X-MS-Exchange-CrossTenant-id":"b39138ca-3cee-4b4a-a4d6-cd83d9dd62f0","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"BLUPR05MB306","X-Spam-Status":"No, score=0.0 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,\n\tRCVD_IN_DNSWL_NONE autolearn=disabled version=3.3.1","X-Spam-Checker-Version":"SpamAssassin 3.3.1 (2010-03-16) on\n\tsmtp1.linux-foundation.org","Cc":"\"dev@openvswitch.org\" ","Subject":"Re: [ovs-dev] [PATCH v2 8/8] netdev-dpdk: set FDIR config","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.12","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"ovs-dev-bounces@openvswitch.org","Errors-To":"ovs-dev-bounces@openvswitch.org"}},{"id":1767452,"web_url":"http://patchwork.ozlabs.org/comment/1767452/","msgid":"<31CFAB88-6AC5-48F7-8B8C-B1F506DC6FA8@vmware.com>","list_archive_url":null,"date":"2017-09-13T01:57:22","subject":"Re: [ovs-dev] [PATCH v2 8/8] netdev-dpdk: set FDIR config","submitter":{"id":68212,"url":"http://patchwork.ozlabs.org/api/people/68212/","name":"Darrell Ball","email":"dball@vmware.com"},"content":"On 9/11/17, 1:14 AM, \"ovs-dev-bounces@openvswitch.org on behalf of Finn Christensen\" wrote:\n\n -----Original Message-----\n From: ovs-dev-bounces@openvswitch.org [mailto:ovs-dev-bounces@openvswitch.org] On Behalf Of Yuanhan Liu\n Sent: 11. september 2017 09:55\n To: Chandran, Sugesh \n Cc: dev@openvswitch.org\n Subject: Re: [ovs-dev] [PATCH v2 8/8] netdev-dpdk: set FDIR config\n \n On Mon, Sep 11, 2017 at 07:42:57AM +0000, Chandran, Sugesh wrote:\n > \n > \n > Regards\n > _Sugesh\n > \n > \n > > -----Original Message-----\n > > From: ovs-dev-bounces@openvswitch.org [mailto:ovs-dev- \n > > bounces@openvswitch.org] On Behalf Of Yuanhan Liu\n > > Sent: Tuesday, September 5, 2017 10:23 AM\n > > To: dev@openvswitch.org\n > > Subject: [ovs-dev] [PATCH v2 8/8] netdev-dpdk: set FDIR config\n > > \n > > From: Finn Christensen \n > > \n > > The Intel i40e PMD driver requires the fdir mode set to \n > > RTE_FDIR_MODE_PERFECT, otherwise, the flow creation would be failed.\n > [Sugesh] this means it doesn't honor the flow masks which passed onto rte_flow_*?\n \n IIRC, that's what I found after divig the code. It's an issue reported/fixed by Finn. I also don't have the nic for testing.\n \n [Finn] Yes, this was needed to make our test setup using an XL710 work, with the rte_flow implementation.\n It's a while ago so I don't exactly remember how we ended up with this solution. However, we are definitely not\n Intel XL710 experts, so there might be other ways to achieve the rte_flow functionality.\n This issue, and problem raised about the overall change in configuration impact on NICs using this setting (Napatech \n does not use it), I think should be reviewed/verified by NIC vendors using it.\n\n\n[Darrell] We need to confirm the masking in the flow (but from what I see, it is ignored as Sugesh mentioned),\n which would be a significant difference.\n I guess we need input from Intel flow director folks to be sure and check if this can be done otherwise.\n What about the 82599 as another example ?\n \n \n \n \n\n \n \t--yliu\n _______________________________________________\n dev mailing list\n dev@openvswitch.org\n https://urldefense.proofpoint.com/v2/url?u=https-3A__mail.openvswitch.org_mailman_listinfo_ovs-2Ddev&d=DwICAg&c=uilaK90D4TOVoH58JNXRgQ&r=BVhFA09CGX7JQ5Ih-uZnsw&m=MnFLi9pqa8AAxTecf0rx1ZIKcaMXyRz3GI8IUJSNBgE&s=mzq2ViO4y-0Dg2ViC_jgcIvw4dmc39-_BjWqDKrpG2A&e= \n _______________________________________________\n dev mailing list\n dev@openvswitch.org\n https://urldefense.proofpoint.com/v2/url?u=https-3A__mail.openvswitch.org_mailman_listinfo_ovs-2Ddev&d=DwICAg&c=uilaK90D4TOVoH58JNXRgQ&r=BVhFA09CGX7JQ5Ih-uZnsw&m=MnFLi9pqa8AAxTecf0rx1ZIKcaMXyRz3GI8IUJSNBgE&s=mzq2ViO4y-0Dg2ViC_jgcIvw4dmc39-_BjWqDKrpG2A&e=","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","ovs-dev@mail.linuxfoundation.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=onevmw.onmicrosoft.com\n\theader.i=@onevmw.onmicrosoft.com header.b=\"CxVdKLYw\"; \n\tdkim-atps=neutral","spf=none (sender IP is )\n\tsmtp.mailfrom=dball@vmware.com; "],"Received":["from mail.linuxfoundation.org (mail.linuxfoundation.org\n\t[140.211.169.12])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xsPtg5R79z9sPs\n\tfor ;\n\tWed, 13 Sep 2017 11:57:29 +1000 (AEST)","from mail.linux-foundation.org (localhost [127.0.0.1])\n\tby mail.linuxfoundation.org (Postfix) with ESMTP id EA5FEAAB;\n\tWed, 13 Sep 2017 01:57:27 +0000 (UTC)","from smtp1.linuxfoundation.org (smtp1.linux-foundation.org\n\t[172.17.192.35])\n\tby mail.linuxfoundation.org (Postfix) with ESMTPS id B51B29F8\n\tfor ; Wed, 13 Sep 2017 01:57:26 +0000 (UTC)","from NAM03-BY2-obe.outbound.protection.outlook.com\n\t(mail-by2nam03on0053.outbound.protection.outlook.com [104.47.42.53])\n\tby smtp1.linuxfoundation.org (Postfix) with ESMTPS id E8A8512A\n\tfor ; Wed, 13 Sep 2017 01:57:25 +0000 (UTC)","from BLUPR05MB611.namprd05.prod.outlook.com (10.141.204.27) by\n\tBLUPR05MB1874.namprd05.prod.outlook.com (10.162.215.148) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id\n\t15.20.56.4; Wed, 13 Sep 2017 01:57:23 +0000","from BLUPR05MB611.namprd05.prod.outlook.com ([10.141.204.27]) by\n\tBLUPR05MB611.namprd05.prod.outlook.com ([10.141.204.27]) with mapi id\n\t15.20.0056.010; Wed, 13 Sep 2017 01:57:23 +0000"],"X-Greylist":"whitelisted by SQLgrey-1.7.6","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=onevmw.onmicrosoft.com; s=selector1-vmware-com;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version;\n\tbh=LdzJSzqereXfPkwjOA8nETeoj49hxill9opkdWiHWiw=;\n\tb=CxVdKLYwrWR9SDXUdmGTUouh7RPMhPbDFAALZqB32IG09g+e0OTIrYKYMcjVNaXxwiYDhYka558oTUrfpCrxpiE4SF09OX4Zl7mDZ2S9rOw6X+efHa+5qaRIriDz5zyd4jgJLg+HBqHFVhy8+MeP53s10gZBcogHUHyvJXZb+X8=","From":"Darrell Ball ","To":"Finn Christensen , Yuanhan Liu , \n\t\"Chandran, Sugesh\" ","Thread-Topic":"[ovs-dev] [PATCH v2 8/8] netdev-dpdk: set FDIR config","Thread-Index":"AQHTJii3HaN7Ulg3vUOiAKNi8TBjIKKvVtmAgAADR4CAAAWHAIACRfUA","Date":"Wed, 13 Sep 2017 01:57:22 +0000","Message-ID":"<31CFAB88-6AC5-48F7-8B8C-B1F506DC6FA8@vmware.com>","References":"<1504603381-30071-1-git-send-email-yliu@fridaylinux.org>\n\t<1504603381-30071-9-git-send-email-yliu@fridaylinux.org>\n\t<2EF2F5C0CC56984AA024D0B180335FCB4221DE68@IRSMSX102.ger.corp.intel.com>\n\t<20170911075441.GR9736@yliu-home>\n\t","In-Reply-To":"","Accept-Language":"en-US","Content-Language":"en-US","X-MS-Has-Attach":"","X-MS-TNEF-Correlator":"","user-agent":"Microsoft-MacOutlook/f.25.0.170815","authentication-results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=onevmw.onmicrosoft.com\n\theader.i=@onevmw.onmicrosoft.com header.b=\"CxVdKLYw\"; \n\tdkim-atps=neutral","spf=none (sender IP is )\n\tsmtp.mailfrom=dball@vmware.com; "],"x-originating-ip":"[73.162.236.45]","x-ms-publictraffictype":"Email","x-microsoft-exchange-diagnostics":"1; BLUPR05MB1874;\n\t20:zmWYbWSfKuTVsGd0cEwch8SFDaCUnLe2ORz8e3Q7u51ztN6ta7k3cHHLL+6SQ+jFKAu4A8UHaDljFXrsTXcVSKqILYdeW97PPzIzQAEFwz1aImT6e9NhLylx01Q0hNewXae5ET4Vcv4bRRz8NsvmQZNNi+LJsKdroSf+hn7zOGc=","x-ms-exchange-antispam-srfa-diagnostics":"SSOS;","x-ms-office365-filtering-correlation-id":"f669a426-bc1f-462d-8f5d-08d4fa4ac6a3","x-microsoft-antispam":"UriScan:; BCL:0; PCL:0;\n\tRULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(300000503095)(300135400095)(2017052603199)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);\n\tSRVR:BLUPR05MB1874; ","x-ms-traffictypediagnostic":"BLUPR05MB1874:","x-exchange-antispam-report-test":"UriScan:(10436049006162)(216315784871565)(228905959029699); ","x-microsoft-antispam-prvs":"","x-exchange-antispam-report-cfa-test":"BCL:0; PCL:0;\n\tRULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(93006095)(93001095)(10201501046)(3002001)(100000703101)(100105400095)(6041248)(20161123560025)(20161123555025)(20161123564025)(20161123562025)(20161123558100)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);\n\tSRVR:BLUPR05MB1874; BCL:0; PCL:0;\n\tRULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);\n\tSRVR:BLUPR05MB1874; ","x-forefront-prvs":"042957ACD7","x-forefront-antispam-report":"SFV:NSPM;\n\tSFS:(10009020)(6009001)(366002)(346002)(39860400002)(376002)(189002)(24454002)(13464003)(377454003)(199003)(106356001)(6436002)(2900100001)(53936002)(229853002)(105586002)(82746002)(93886005)(6486002)(305945005)(6506006)(77096006)(86362001)(575784001)(189998001)(2906002)(4326008)(2950100002)(81156014)(81166006)(8676002)(68736007)(8936002)(3660700001)(99286003)(97736004)(3280700002)(6512007)(6306002)(7736002)(66066001)(6246003)(33656002)(6116002)(102836003)(101416001)(36756003)(3846002)(25786009)(478600001)(14454004)(83716003)(83506001)(316002)(5660300001)(4001350100001)(50986999)(76176999)(966005)(54356999)(53546010);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:BLUPR05MB1874;\n\tH:BLUPR05MB611.namprd05.prod.outlook.com; FPR:; SPF:None;\n\tPTR:InfoNoRecords; MX:1; A:1; LANG:en; ","received-spf":"None (protection.outlook.com: vmware.com does not designate\n\tpermitted sender hosts)","spamdiagnosticoutput":"1:99","spamdiagnosticmetadata":"NSPM","Content-ID":"<3DF0E6981E8E9349B9BA4ECB35C16FCB@namprd05.prod.outlook.com>","MIME-Version":"1.0","X-OriginatorOrg":"vmware.com","X-MS-Exchange-CrossTenant-originalarrivaltime":"13 Sep 2017 01:57:23.0558\n\t(UTC)","X-MS-Exchange-CrossTenant-fromentityheader":"Hosted","X-MS-Exchange-CrossTenant-id":"b39138ca-3cee-4b4a-a4d6-cd83d9dd62f0","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"BLUPR05MB1874","X-Spam-Status":"No, score=0.0 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,\n\tRCVD_IN_DNSWL_NONE autolearn=disabled version=3.3.1","X-Spam-Checker-Version":"SpamAssassin 3.3.1 (2010-03-16) on\n\tsmtp1.linux-foundation.org","Cc":"\"dev@openvswitch.org\" ","Subject":"Re: [ovs-dev] [PATCH v2 8/8] netdev-dpdk: set FDIR config","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.12","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"ovs-dev-bounces@openvswitch.org","Errors-To":"ovs-dev-bounces@openvswitch.org"}},{"id":1768314,"web_url":"http://patchwork.ozlabs.org/comment/1768314/","msgid":"<20170914031837.GF2050@yliu-home>","list_archive_url":null,"date":"2017-09-14T03:18:37","subject":"Re: [ovs-dev] [PATCH v2 8/8] netdev-dpdk: set FDIR config","submitter":{"id":72215,"url":"http://patchwork.ozlabs.org/api/people/72215/","name":"Yuanhan Liu","email":"yliu@fridaylinux.org"},"content":"On Wed, Sep 13, 2017 at 01:57:22AM +0000, Darrell Ball wrote:\n> \n> \n> On 9/11/17, 1:14 AM, \"ovs-dev-bounces@openvswitch.org on behalf of Finn Christensen\" wrote:\n> \n> -----Original Message-----\n> From: ovs-dev-bounces@openvswitch.org [mailto:ovs-dev-bounces@openvswitch.org] On Behalf Of Yuanhan Liu\n> Sent: 11. september 2017 09:55\n> To: Chandran, Sugesh \n> Cc: dev@openvswitch.org\n> Subject: Re: [ovs-dev] [PATCH v2 8/8] netdev-dpdk: set FDIR config\n> \n> On Mon, Sep 11, 2017 at 07:42:57AM +0000, Chandran, Sugesh wrote:\n> > \n> > \n> > Regards\n> > _Sugesh\n> > \n> > \n> > > -----Original Message-----\n> > > From: ovs-dev-bounces@openvswitch.org [mailto:ovs-dev- \n> > > bounces@openvswitch.org] On Behalf Of Yuanhan Liu\n> > > Sent: Tuesday, September 5, 2017 10:23 AM\n> > > To: dev@openvswitch.org\n> > > Subject: [ovs-dev] [PATCH v2 8/8] netdev-dpdk: set FDIR config\n> > > \n> > > From: Finn Christensen \n> > > \n> > > The Intel i40e PMD driver requires the fdir mode set to \n> > > RTE_FDIR_MODE_PERFECT, otherwise, the flow creation would be failed.\n> > [Sugesh] this means it doesn't honor the flow masks which passed onto rte_flow_*?\n> \n> IIRC, that's what I found after divig the code. It's an issue reported/fixed by Finn. I also don't have the nic for testing.\n> \n> [Finn] Yes, this was needed to make our test setup using an XL710 work, with the rte_flow implementation.\n> It's a while ago so I don't exactly remember how we ended up with this solution. However, we are definitely not\n> Intel XL710 experts, so there might be other ways to achieve the rte_flow functionality.\n> This issue, and problem raised about the overall change in configuration impact on NICs using this setting (Napatech \n> does not use it), I think should be reviewed/verified by NIC vendors using it.\n> \n> \n> [Darrell] We need to confirm the masking in the flow (but from what I see, it is ignored as Sugesh mentioned),\n> which would be a significant difference.\n> I guess we need input from Intel flow director folks to be sure and check if this can be done otherwise.\n> What about the 82599 as another example ?\n\n\nI will leave this to Intel folks.\n\n\t--yliu","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","ovs-dev@mail.linuxfoundation.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=fridaylinux-org.20150623.gappssmtp.com\n\theader.i=@fridaylinux-org.20150623.gappssmtp.com\n\theader.b=\"1wJONe1U\"; dkim-atps=neutral"],"Received":["from mail.linuxfoundation.org (mail.linuxfoundation.org\n\t[140.211.169.12])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xt3f35W67z9sP1\n\tfor ;\n\tThu, 14 Sep 2017 13:18:51 +1000 (AEST)","from mail.linux-foundation.org (localhost [127.0.0.1])\n\tby mail.linuxfoundation.org (Postfix) with ESMTP id EF9C8A64;\n\tThu, 14 Sep 2017 03:18:47 +0000 (UTC)","from smtp1.linuxfoundation.org (smtp1.linux-foundation.org\n\t[172.17.192.35])\n\tby mail.linuxfoundation.org (Postfix) with ESMTPS id D1A8F258\n\tfor ; Thu, 14 Sep 2017 03:18:45 +0000 (UTC)","from mail-pg0-f41.google.com (mail-pg0-f41.google.com\n\t[74.125.83.41])\n\tby smtp1.linuxfoundation.org (Postfix) with ESMTPS id 5BC59127\n\tfor ; Thu, 14 Sep 2017 03:18:45 +0000 (UTC)","by mail-pg0-f41.google.com with SMTP id d8so4028712pgt.4\n\tfor ; Wed, 13 Sep 2017 20:18:45 -0700 (PDT)","from yliu-home ([45.63.61.64]) by smtp.gmail.com with ESMTPSA id\n\tg66sm32811976pfj.161.2017.09.13.20.18.42\n\t(version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tWed, 13 Sep 2017 20:18:43 -0700 (PDT)"],"X-Greylist":"whitelisted by SQLgrey-1.7.6","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=fridaylinux-org.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:in-reply-to:user-agent;\n\tbh=CnmDVaklobeJFtcB/VKDIsMgOfZfqswgMGAL5xPvqCg=;\n\tb=1wJONe1Uhw5d5pa7sPhMB9uCpvsN+zbYBycamEnNavOC9OSoKDUO34gd5nzqaYeW+6\n\tyzNagA2HPRe3eX3jrnDkOhKIGI+kcS/sKY7S2EfgvbEbrDgGOdjKIMB/S3P7MjuTl1Jx\n\t/vYzZ1tOKmGXDTWJaClQC3edGm+g7nnKFZdnj2xYow8FEFCVODFY2NVG0z6RbyyVEtM9\n\tp9KycKhSQ1797BlVkTmUpS6/OvlK1kACI5vyW4EPktDhCh7yP5EOh3T+kd5lJRKZAYWu\n\t6iEYWqol4otKEHWI7w+Farpe+wUiBSqD0+S4hInI9shcYZktnnjHrqrpf11JCmQgIK5L\n\t2F/A==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:in-reply-to:user-agent;\n\tbh=CnmDVaklobeJFtcB/VKDIsMgOfZfqswgMGAL5xPvqCg=;\n\tb=fh90scUxm9dPKlaowryCEOTaRl8+xAlMaODITHH4D0e+p/Caezm6gQ+xykC8qlTo5C\n\tG9D12SGhogHU5VBocGKzPJJJJVpDscQC9aLiOeXgL4pAatHponWS0Vx2FJGkU/SAsxNT\n\t0pnF8fpm4DmRaeh0k+5y92bXeZxxSc1AJGnOBpnhkUXt2OIBa28cFNIV+KKXIw9Z0m1o\n\tppSUOFd9lRfsv2cwcEt/PANjz8Jltx6yp/kDCYbP8Lwa9AEUcuxSvQZX+wMpSGNaYeNx\n\tmrc57TQ2v6/RQhlKlss+kDP3iwOxVfVnUSHlSfsNobLL7JzaDe0Z+EmMxmYPaKRAAo4e\n\te+9w==","X-Gm-Message-State":"AHPjjUjjsVP2vgMXoXjJ4Lkdx80LALPM8mW61JAzSOEE0+XJApCSDHfx\n\ts6Y7jxxezRdNpafM","X-Google-Smtp-Source":"ADKCNb5SRNQJTpe1X/CmX0fMqzPKDQtSVW+ZgB6xy7tykxONcFV9Y2RT6UUfb9Asrx3UzTmpkXSLXw==","X-Received":"by 10.84.131.79 with SMTP id 73mr22976888pld.281.1505359124966; \n\tWed, 13 Sep 2017 20:18:44 -0700 (PDT)","Date":"Thu, 14 Sep 2017 11:18:37 +0800","From":"Yuanhan Liu ","To":"Darrell Ball ","Message-ID":"<20170914031837.GF2050@yliu-home>","References":"<1504603381-30071-1-git-send-email-yliu@fridaylinux.org>\n\t<1504603381-30071-9-git-send-email-yliu@fridaylinux.org>\n\t<2EF2F5C0CC56984AA024D0B180335FCB4221DE68@IRSMSX102.ger.corp.intel.com>\n\t<20170911075441.GR9736@yliu-home>\n\t\n\t<31CFAB88-6AC5-48F7-8B8C-B1F506DC6FA8@vmware.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<31CFAB88-6AC5-48F7-8B8C-B1F506DC6FA8@vmware.com>","User-Agent":"Mutt/1.5.24 (2015-08-30)","X-Spam-Status":"No, score=0.5 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,\n\tRCVD_IN_DNSWL_NONE,\n\tRCVD_IN_SORBS_SPAM autolearn=disabled version=3.3.1","X-Spam-Checker-Version":"SpamAssassin 3.3.1 (2010-03-16) on\n\tsmtp1.linux-foundation.org","Cc":"\"dev@openvswitch.org\" ","Subject":"Re: [ovs-dev] [PATCH v2 8/8] netdev-dpdk: set FDIR config","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.12","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"ovs-dev-bounces@openvswitch.org","Errors-To":"ovs-dev-bounces@openvswitch.org"}},{"id":1768753,"web_url":"http://patchwork.ozlabs.org/comment/1768753/","msgid":"<2EF2F5C0CC56984AA024D0B180335FCB42221BF6@IRSMSX102.ger.corp.intel.com>","list_archive_url":null,"date":"2017-09-14T17:36:20","subject":"Re: [ovs-dev] [PATCH v2 8/8] netdev-dpdk: set FDIR config","submitter":{"id":67440,"url":"http://patchwork.ozlabs.org/api/people/67440/","name":"Chandran, Sugesh","email":"sugesh.chandran@intel.com"},"content":"Regards\n_Sugesh\n\n> -----Original Message-----\n> From: Yuanhan Liu [mailto:yliu@fridaylinux.org]\n> Sent: Thursday, September 14, 2017 4:19 AM\n> To: Darrell Ball \n> Cc: Finn Christensen ; Chandran, Sugesh\n> ; dev@openvswitch.org\n> Subject: Re: [ovs-dev] [PATCH v2 8/8] netdev-dpdk: set FDIR config\n> \n> On Wed, Sep 13, 2017 at 01:57:22AM +0000, Darrell Ball wrote:\n> >\n> >\n> > On 9/11/17, 1:14 AM, \"ovs-dev-bounces@openvswitch.org on behalf of\n> Finn Christensen\" fc@napatech.com> wrote:\n> >\n> > -----Original Message-----\n> > From: ovs-dev-bounces@openvswitch.org [mailto:ovs-dev-\n> bounces@openvswitch.org] On Behalf Of Yuanhan Liu\n> > Sent: 11. september 2017 09:55\n> > To: Chandran, Sugesh \n> > Cc: dev@openvswitch.org\n> > Subject: Re: [ovs-dev] [PATCH v2 8/8] netdev-dpdk: set FDIR config\n> >\n> > On Mon, Sep 11, 2017 at 07:42:57AM +0000, Chandran, Sugesh wrote:\n> > >\n> > >\n> > > Regards\n> > > _Sugesh\n> > >\n> > >\n> > > > -----Original Message-----\n> > > > From: ovs-dev-bounces@openvswitch.org [mailto:ovs-dev-\n> > > > bounces@openvswitch.org] On Behalf Of Yuanhan Liu\n> > > > Sent: Tuesday, September 5, 2017 10:23 AM\n> > > > To: dev@openvswitch.org\n> > > > Subject: [ovs-dev] [PATCH v2 8/8] netdev-dpdk: set FDIR config\n> > > >\n> > > > From: Finn Christensen \n> > > >\n> > > > The Intel i40e PMD driver requires the fdir mode set to\n> > > > RTE_FDIR_MODE_PERFECT, otherwise, the flow creation would be\n> failed.\n> > > [Sugesh] this means it doesn't honor the flow masks which passed onto\n> rte_flow_*?\n> >\n> > IIRC, that's what I found after divig the code. It's an issue reported/fixed\n> by Finn. I also don't have the nic for testing.\n> >\n> > [Finn] Yes, this was needed to make our test setup using an XL710 work,\n> with the rte_flow implementation.\n> > It's a while ago so I don't exactly remember how we ended up with this\n> solution. However, we are definitely not\n> > Intel XL710 experts, so there might be other ways to achieve the\n> rte_flow functionality.\n> > This issue, and problem raised about the overall change in configuration\n> impact on NICs using this setting (Napatech\n> > does not use it), I think should be reviewed/verified by NIC vendors\n> using it.\n> >\n> >\n> > [Darrell] We need to confirm the masking in the flow (but from what I see,\n> it is ignored as Sugesh mentioned),\n> > which would be a significant difference.\n> > I guess we need input from Intel flow director folks to be sure and\n> check if this can be done otherwise.\n> > What about the 82599 as another example ?\n> \n> \n> I will leave this to Intel folks.\n[Sugesh] From the 82599 datasheet \n\n=======\nThe 82599 support two types of filtering modes (static setting by the FDIRCTRL.PerfectMatch\nbit):\n* Perfect match filters - The hardware checks a match between the masked fields of\nthe received packets and the programmed filters. Masked fields should be\nprogrammed as zeros in the filter context. The 82599 support up to 8 K - 2 perfect\nmatch filters.\n* Signature filters - The hardware checks a match between a hash-based signature of\nthe masked fields of the received packet. The 82599 supports up to 32 K - 2\nsignature filters.\n* Notation - The Perfect Match fields and Signature field are denoted as Flow ID fields.\nThe 82599 supports masking / range for the previously described fields. These masks are\ndefined globally for all filters in the FDIR...M register.\n=======\nSo my understanding is even if it can support masking, the mask is global and not per flow.\n\nAgain I will confirm this and provide more details.\n\n> \n> \t--yliu","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","ovs-dev@mail.linuxfoundation.org"],"Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=)","Received":["from mail.linuxfoundation.org (mail.linuxfoundation.org\n\t[140.211.169.12])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xtQgY5qMYz9s3w\n\tfor ;\n\tFri, 15 Sep 2017 03:36:25 +1000 (AEST)","from mail.linux-foundation.org (localhost [127.0.0.1])\n\tby mail.linuxfoundation.org (Postfix) with ESMTP id 11A86B30;\n\tThu, 14 Sep 2017 17:36:24 +0000 (UTC)","from smtp1.linuxfoundation.org (smtp1.linux-foundation.org\n\t[172.17.192.35])\n\tby mail.linuxfoundation.org (Postfix) with ESMTPS id 8610CB15\n\tfor ; Thu, 14 Sep 2017 17:36:23 +0000 (UTC)","from mga11.intel.com (mga11.intel.com [192.55.52.93])\n\tby smtp1.linuxfoundation.org (Postfix) with ESMTPS id EDBAE203\n\tfor ; Thu, 14 Sep 2017 17:36:22 +0000 (UTC)","from fmsmga001.fm.intel.com ([10.253.24.23])\n\tby fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t14 Sep 2017 10:36:22 -0700","from irsmsx106.ger.corp.intel.com ([163.33.3.31])\n\tby fmsmga001.fm.intel.com with ESMTP; 14 Sep 2017 10:36:21 -0700","from irsmsx102.ger.corp.intel.com ([169.254.2.59]) by\n\tIRSMSX106.ger.corp.intel.com ([169.254.8.36]) with mapi id\n\t14.03.0319.002; Thu, 14 Sep 2017 18:36:20 +0100"],"X-Greylist":"domain auto-whitelisted by SQLgrey-1.7.6","X-ExtLoop1":"1","X-IronPort-AV":"E=Sophos; i=\"5.42,394,1500966000\"; d=\"scan'208\";\n\ta=\"1195141512\"","From":"\"Chandran, Sugesh\" ","To":"Yuanhan Liu , Darrell Ball ","Thread-Topic":"[ovs-dev] [PATCH v2 8/8] netdev-dpdk: set FDIR config","Thread-Index":"AQHTJimP9HuhVbRUNEaNJEmtDMrOxaKuKvaQgAEeZYCAAAWHAIACu04AgAGpCICAAPu0UA==","Date":"Thu, 14 Sep 2017 17:36:20 +0000","Message-ID":"<2EF2F5C0CC56984AA024D0B180335FCB42221BF6@IRSMSX102.ger.corp.intel.com>","References":"<1504603381-30071-1-git-send-email-yliu@fridaylinux.org>\n\t<1504603381-30071-9-git-send-email-yliu@fridaylinux.org>\n\t<2EF2F5C0CC56984AA024D0B180335FCB4221DE68@IRSMSX102.ger.corp.intel.com>\n\t<20170911075441.GR9736@yliu-home>\n\t\n\t<31CFAB88-6AC5-48F7-8B8C-B1F506DC6FA8@vmware.com>\n\t<20170914031837.GF2050@yliu-home>","In-Reply-To":"<20170914031837.GF2050@yliu-home>","Accept-Language":"en-US","Content-Language":"en-US","X-MS-Has-Attach":"","X-MS-TNEF-Correlator":"","x-titus-metadata-40":"eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYzdhOTkxNmQtOGJmOS00NjhmLTk0MTEtYzUwODQzYjdjOWMzIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IlN6emoyeHo3NktodDZKRjJtdFcycXlBZHJtRnZGeXFTRXp3OGl3VHRvWHc9In0=","x-ctpclassification":"CTP_IC","dlp-product":"dlpe-windows","dlp-version":"11.0.0.116","dlp-reaction":"no-action","x-originating-ip":"[163.33.239.180]","MIME-Version":"1.0","X-Spam-Status":"No, score=-5.0 required=5.0 tests=RCVD_IN_DNSWL_HI,\n\tRP_MATCHES_RCVD autolearn=disabled version=3.3.1","X-Spam-Checker-Version":"SpamAssassin 3.3.1 (2010-03-16) on\n\tsmtp1.linux-foundation.org","Cc":"\"dev@openvswitch.org\" ","Subject":"Re: [ovs-dev] [PATCH v2 8/8] netdev-dpdk: set FDIR config","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.12","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"ovs-dev-bounces@openvswitch.org","Errors-To":"ovs-dev-bounces@openvswitch.org"}},{"id":1768755,"web_url":"http://patchwork.ozlabs.org/comment/1768755/","msgid":"<58C6CB9F-4EEA-45FA-B6B4-D932599FC03C@vmware.com>","list_archive_url":null,"date":"2017-09-14T17:46:05","subject":"Re: [ovs-dev] [PATCH v2 8/8] netdev-dpdk: set FDIR config","submitter":{"id":68212,"url":"http://patchwork.ozlabs.org/api/people/68212/","name":"Darrell Ball","email":"dball@vmware.com"},"content":"On 9/14/17, 10:36 AM, \"Chandran, Sugesh\" wrote:\r\n\r\n \r\n \r\n Regards\r\n _Sugesh\r\n \r\n > -----Original Message-----\r\n > From: Yuanhan Liu [mailto:yliu@fridaylinux.org]\r\n > Sent: Thursday, September 14, 2017 4:19 AM\r\n > To: Darrell Ball \r\n > Cc: Finn Christensen ; Chandran, Sugesh\r\n > ; dev@openvswitch.org\r\n > Subject: Re: [ovs-dev] [PATCH v2 8/8] netdev-dpdk: set FDIR config\r\n > \r\n > On Wed, Sep 13, 2017 at 01:57:22AM +0000, Darrell Ball wrote:\r\n > >\r\n > >\r\n > > On 9/11/17, 1:14 AM, \"ovs-dev-bounces@openvswitch.org on behalf of\r\n > Finn Christensen\" fc@napatech.com> wrote:\r\n > >\r\n > > -----Original Message-----\r\n > > From: ovs-dev-bounces@openvswitch.org [mailto:ovs-dev-\r\n > bounces@openvswitch.org] On Behalf Of Yuanhan Liu\r\n > > Sent: 11. september 2017 09:55\r\n > > To: Chandran, Sugesh \r\n > > Cc: dev@openvswitch.org\r\n > > Subject: Re: [ovs-dev] [PATCH v2 8/8] netdev-dpdk: set FDIR config\r\n > >\r\n > > On Mon, Sep 11, 2017 at 07:42:57AM +0000, Chandran, Sugesh wrote:\r\n > > >\r\n > > >\r\n > > > Regards\r\n > > > _Sugesh\r\n > > >\r\n > > >\r\n > > > > -----Original Message-----\r\n > > > > From: ovs-dev-bounces@openvswitch.org [mailto:ovs-dev-\r\n > > > > bounces@openvswitch.org] On Behalf Of Yuanhan Liu\r\n > > > > Sent: Tuesday, September 5, 2017 10:23 AM\r\n > > > > To: dev@openvswitch.org\r\n > > > > Subject: [ovs-dev] [PATCH v2 8/8] netdev-dpdk: set FDIR config\r\n > > > >\r\n > > > > From: Finn Christensen \r\n > > > >\r\n > > > > The Intel i40e PMD driver requires the fdir mode set to\r\n > > > > RTE_FDIR_MODE_PERFECT, otherwise, the flow creation would be\r\n > failed.\r\n > > > [Sugesh] this means it doesn't honor the flow masks which passed onto\r\n > rte_flow_*?\r\n > >\r\n > > IIRC, that's what I found after divig the code. It's an issue reported/fixed\r\n > by Finn. I also don't have the nic for testing.\r\n > >\r\n > > [Finn] Yes, this was needed to make our test setup using an XL710 work,\r\n > with the rte_flow implementation.\r\n > > It's a while ago so I don't exactly remember how we ended up with this\r\n > solution. However, we are definitely not\r\n > > Intel XL710 experts, so there might be other ways to achieve the\r\n > rte_flow functionality.\r\n > > This issue, and problem raised about the overall change in configuration\r\n > impact on NICs using this setting (Napatech\r\n > > does not use it), I think should be reviewed/verified by NIC vendors\r\n > using it.\r\n > >\r\n > >\r\n > > [Darrell] We need to confirm the masking in the flow (but from what I see,\r\n > it is ignored as Sugesh mentioned),\r\n > > which would be a significant difference.\r\n > > I guess we need input from Intel flow director folks to be sure and\r\n > check if this can be done otherwise.\r\n > > What about the 82599 as another example ?\r\n > \r\n > \r\n > I will leave this to Intel folks.\r\n [Sugesh] From the 82599 datasheet \r\n \r\n =======\r\n The 82599 support two types of filtering modes (static setting by the FDIRCTRL.PerfectMatch\r\n bit):\r\n * Perfect match filters - The hardware checks a match between the masked fields of\r\n the received packets and the programmed filters. Masked fields should be\r\n programmed as zeros in the filter context. The 82599 support up to 8 K - 2 perfect\r\n match filters.\r\n * Signature filters - The hardware checks a match between a hash-based signature of\r\n the masked fields of the received packet. The 82599 supports up to 32 K - 2\r\n signature filters.\r\n * Notation - The Perfect Match fields and Signature field are denoted as Flow ID fields.\r\n The 82599 supports masking / range for the previously described fields. These masks are\r\n defined globally for all filters in the FDIR...M register.\r\n =======\r\n So my understanding is even if it can support masking, the mask is global and not per flow.\r\n\r\n[Darrell] That was my interpretation as well; same across flow director usages.\r\n\r\n Again I will confirm this and provide more details.\r\n\r\n[Darrell] One question is – ‘is there some way to enable per flow masking’ with this config ?\r\n A second request is – ‘is there another option than RTE_FDIR_MODE_PERFECT\r\n or similar’ to use to achieve the result ?\r\n\r\n \r\n > \r\n > \t--yliu","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","ovs-dev@mail.linuxfoundation.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=onevmw.onmicrosoft.com\n\theader.i=@onevmw.onmicrosoft.com header.b=\"ZIBBaBVK\"; \n\tdkim-atps=neutral","spf=none (sender IP is )\n\tsmtp.mailfrom=dball@vmware.com; "],"Received":["from mail.linuxfoundation.org (mail.linuxfoundation.org\n\t[140.211.169.12])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xtQtq2KNJz9s72\n\tfor ;\n\tFri, 15 Sep 2017 03:46:11 +1000 (AEST)","from mail.linux-foundation.org (localhost [127.0.0.1])\n\tby mail.linuxfoundation.org (Postfix) with ESMTP id 19425941;\n\tThu, 14 Sep 2017 17:46:09 +0000 (UTC)","from smtp1.linuxfoundation.org (smtp1.linux-foundation.org\n\t[172.17.192.35])\n\tby mail.linuxfoundation.org (Postfix) with ESMTPS id D823C516\n\tfor ; Thu, 14 Sep 2017 17:46:07 +0000 (UTC)","from NAM01-SN1-obe.outbound.protection.outlook.com\n\t(mail-sn1nam01on0089.outbound.protection.outlook.com [104.47.32.89])\n\tby smtp1.linuxfoundation.org (Postfix) with ESMTPS id 32D423CB\n\tfor ; Thu, 14 Sep 2017 17:46:07 +0000 (UTC)","from BLUPR05MB611.namprd05.prod.outlook.com (10.141.204.27) by\n\tBLUPR05MB292.namprd05.prod.outlook.com (10.141.23.27) with Microsoft\n\tSMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id\n\t15.20.77.5; Thu, 14 Sep 2017 17:46:05 +0000","from BLUPR05MB611.namprd05.prod.outlook.com ([10.141.204.27]) by\n\tBLUPR05MB611.namprd05.prod.outlook.com ([10.141.204.27]) with mapi id\n\t15.20.0077.005; Thu, 14 Sep 2017 17:46:05 +0000"],"X-Greylist":"whitelisted by SQLgrey-1.7.6","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=onevmw.onmicrosoft.com; s=selector1-vmware-com;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version;\n\tbh=0BiEifCSyguSFU07+XBr8Sv06SSEfb9AiZo7MIx3YNo=;\n\tb=ZIBBaBVKNOKyX1O/OT3Pk/MJzjJdO/fopcDHph8+AeD0VMR/5vPyu5JidQysTbj+Dr5KUUfsP245BXeUw4kC+T9VefqWmEvtzFIyc9WquH/ApsOcKFK80B4dWeDE1d5SMn/UXdNfFGil4zt1pWqFMiQlXwv83SCz3hIIO/nXzKQ=","From":"Darrell Ball ","To":"\"Chandran, Sugesh\" , Yuanhan Liu\n\t","Thread-Topic":"[ovs-dev] [PATCH v2 8/8] netdev-dpdk: set FDIR config","Thread-Index":"AQHTJii3HaN7Ulg3vUOiAKNi8TBjIKKvVtmAgAADR4CAAAWHAIACRfUAgAIeYYCAAO+lAP//jV8A","Date":"Thu, 14 Sep 2017 17:46:05 +0000","Message-ID":"<58C6CB9F-4EEA-45FA-B6B4-D932599FC03C@vmware.com>","References":"<1504603381-30071-1-git-send-email-yliu@fridaylinux.org>\n\t<1504603381-30071-9-git-send-email-yliu@fridaylinux.org>\n\t<2EF2F5C0CC56984AA024D0B180335FCB4221DE68@IRSMSX102.ger.corp.intel.com>\n\t<20170911075441.GR9736@yliu-home>\n\t\n\t<31CFAB88-6AC5-48F7-8B8C-B1F506DC6FA8@vmware.com>\n\t<20170914031837.GF2050@yliu-home>\n\t<2EF2F5C0CC56984AA024D0B180335FCB42221BF6@IRSMSX102.ger.corp.intel.com>","In-Reply-To":"<2EF2F5C0CC56984AA024D0B180335FCB42221BF6@IRSMSX102.ger.corp.intel.com>","Accept-Language":"en-US","Content-Language":"en-US","X-MS-Has-Attach":"","X-MS-TNEF-Correlator":"","user-agent":"Microsoft-MacOutlook/f.25.0.170815","x-originating-ip":"[73.162.236.45]","x-ms-publictraffictype":"Email","x-microsoft-exchange-diagnostics":"1; BLUPR05MB292;\n\t20:IIORyircNT+IIuu+bCxWZA5c2R4fG6pZZF+V+MVFcvdCHS0KtRBpwbCgpkVe8iTW+3DwlvFazSVwhv36AW3K6ST79X9CFL9e1xbm/3LnzkXVu0vAlhiikgoigvNZqhRZz1fkrDK+ZbmehSvObRbx5RaK5zL9XHad3oeh5GM2OsI=","x-ms-exchange-antispam-srfa-diagnostics":"SSOS;","x-ms-office365-filtering-correlation-id":"137c429a-f6d1-4763-ba61-08d4fb987932","x-microsoft-antispam":"UriScan:; BCL:0; PCL:0;\n\tRULEID:(300000500095)(300135000095)(300000501095)(300135300095)(300000502095)(300135100095)(22001)(2017030254152)(300000503095)(300135400095)(2017052603199)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);\n\tSRVR:BLUPR05MB292; ","x-ms-traffictypediagnostic":"BLUPR05MB292:","authentication-results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=onevmw.onmicrosoft.com\n\theader.i=@onevmw.onmicrosoft.com header.b=\"ZIBBaBVK\"; \n\tdkim-atps=neutral","spf=none (sender IP is )\n\tsmtp.mailfrom=dball@vmware.com; "],"x-exchange-antispam-report-test":"UriScan:(61668805478150)(216315784871565)(228905959029699); ","x-microsoft-antispam-prvs":"","x-exchange-antispam-report-cfa-test":"BCL:0; PCL:0;\n\tRULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(100000703101)(100105400095)(93006095)(93001095)(10201501046)(3002001)(6041248)(20161123564025)(20161123560025)(20161123558100)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123562025)(20161123555025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);\n\tSRVR:BLUPR05MB292; BCL:0; PCL:0;\n\tRULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);\n\tSRVR:BLUPR05MB292; ","x-forefront-prvs":"0430FA5CB7","x-forefront-antispam-report":"SFV:NSPM;\n\tSFS:(10009020)(6009001)(346002)(376002)(24454002)(13464003)(199003)(377454003)(189002)(53936002)(189998001)(106356001)(105586002)(6506006)(6436002)(77096006)(478600001)(316002)(6486002)(86362001)(81156014)(81166006)(8676002)(7736002)(6246003)(99286003)(93886005)(33656002)(6512007)(8936002)(229853002)(54906002)(305945005)(4326008)(83506001)(4001350100001)(82746002)(25786009)(97736004)(2906002)(6116002)(3846002)(102836003)(83716003)(2950100002)(2900100001)(68736007)(3280700002)(101416001)(50986999)(53546010)(66066001)(54356999)(14454004)(3660700001)(5660300001)(36756003)(76176999);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:BLUPR05MB292;\n\tH:BLUPR05MB611.namprd05.prod.outlook.com; FPR:; SPF:None;\n\tPTR:InfoNoRecords; A:1; MX:1; LANG:en; ","received-spf":"None (protection.outlook.com: vmware.com does not designate\n\tpermitted sender hosts)","spamdiagnosticoutput":"1:99","spamdiagnosticmetadata":"NSPM","Content-ID":"<413069D080D73347AA691155F905240B@namprd05.prod.outlook.com>","MIME-Version":"1.0","X-OriginatorOrg":"vmware.com","X-MS-Exchange-CrossTenant-originalarrivaltime":"14 Sep 2017 17:46:05.1957\n\t(UTC)","X-MS-Exchange-CrossTenant-fromentityheader":"Hosted","X-MS-Exchange-CrossTenant-id":"b39138ca-3cee-4b4a-a4d6-cd83d9dd62f0","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"BLUPR05MB292","X-Spam-Status":"No, score=0.0 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,\n\tRCVD_IN_DNSWL_NONE autolearn=disabled version=3.3.1","X-Spam-Checker-Version":"SpamAssassin 3.3.1 (2010-03-16) on\n\tsmtp1.linux-foundation.org","Cc":"\"dev@openvswitch.org\" ","Subject":"Re: [ovs-dev] [PATCH v2 8/8] netdev-dpdk: set FDIR config","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.12","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Sender":"ovs-dev-bounces@openvswitch.org","Errors-To":"ovs-dev-bounces@openvswitch.org"}},{"id":1771865,"web_url":"http://patchwork.ozlabs.org/comment/1771865/","msgid":"<2EF2F5C0CC56984AA024D0B180335FCB5254FAB8@IRSMSX103.ger.corp.intel.com>","list_archive_url":null,"date":"2017-09-20T13:47:17","subject":"Re: [ovs-dev] [PATCH v2 8/8] netdev-dpdk: set FDIR config","submitter":{"id":67440,"url":"http://patchwork.ozlabs.org/api/people/67440/","name":"Chandran, Sugesh","email":"sugesh.chandran@intel.com"},"content":"Regards\r\n_Sugesh\r\n\r\n\r\n> -----Original Message-----\r\n> From: Darrell Ball [mailto:dball@vmware.com]\r\n> Sent: Thursday, September 14, 2017 6:46 PM\r\n> To: Chandran, Sugesh ; Yuanhan Liu\r\n> \r\n> Cc: Finn Christensen ; dev@openvswitch.org\r\n> Subject: Re: [ovs-dev] [PATCH v2 8/8] netdev-dpdk: set FDIR config\r\n> \r\n> \r\n> \r\n> On 9/14/17, 10:36 AM, \"Chandran, Sugesh\" \r\n> wrote:\r\n> \r\n> \r\n> \r\n> Regards\r\n> _Sugesh\r\n> \r\n> > -----Original Message-----\r\n> > From: Yuanhan Liu [mailto:yliu@fridaylinux.org]\r\n> > Sent: Thursday, September 14, 2017 4:19 AM\r\n> > To: Darrell Ball \r\n> > Cc: Finn Christensen ; Chandran, Sugesh\r\n> > ; dev@openvswitch.org\r\n> > Subject: Re: [ovs-dev] [PATCH v2 8/8] netdev-dpdk: set FDIR config\r\n> >\r\n> > On Wed, Sep 13, 2017 at 01:57:22AM +0000, Darrell Ball wrote:\r\n> > >\r\n> > >\r\n> > > On 9/11/17, 1:14 AM, \"ovs-dev-bounces@openvswitch.org on behalf of\r\n> > Finn Christensen\" > fc@napatech.com> wrote:\r\n> > >\r\n> > > -----Original Message-----\r\n> > > From: ovs-dev-bounces@openvswitch.org [mailto:ovs-dev-\r\n> > bounces@openvswitch.org] On Behalf Of Yuanhan Liu\r\n> > > Sent: 11. september 2017 09:55\r\n> > > To: Chandran, Sugesh \r\n> > > Cc: dev@openvswitch.org\r\n> > > Subject: Re: [ovs-dev] [PATCH v2 8/8] netdev-dpdk: set FDIR config\r\n> > >\r\n> > > On Mon, Sep 11, 2017 at 07:42:57AM +0000, Chandran, Sugesh wrote:\r\n> > > >\r\n> > > >\r\n> > > > Regards\r\n> > > > _Sugesh\r\n> > > >\r\n> > > >\r\n> > > > > -----Original Message-----\r\n> > > > > From: ovs-dev-bounces@openvswitch.org [mailto:ovs-dev-\r\n> > > > > bounces@openvswitch.org] On Behalf Of Yuanhan Liu\r\n> > > > > Sent: Tuesday, September 5, 2017 10:23 AM\r\n> > > > > To: dev@openvswitch.org\r\n> > > > > Subject: [ovs-dev] [PATCH v2 8/8] netdev-dpdk: set FDIR config\r\n> > > > >\r\n> > > > > From: Finn Christensen \r\n> > > > >\r\n> > > > > The Intel i40e PMD driver requires the fdir mode set to\r\n> > > > > RTE_FDIR_MODE_PERFECT, otherwise, the flow creation would be\r\n> > failed.\r\n> > > > [Sugesh] this means it doesn't honor the flow masks which passed\r\n> onto\r\n> > rte_flow_*?\r\n> > >\r\n> > > IIRC, that's what I found after divig the code. It's an issue reported/fixed\r\n> > by Finn. I also don't have the nic for testing.\r\n> > >\r\n> > > [Finn] Yes, this was needed to make our test setup using an XL710 work,\r\n> > with the rte_flow implementation.\r\n> > > It's a while ago so I don't exactly remember how we ended up with this\r\n> > solution. However, we are definitely not\r\n> > > Intel XL710 experts, so there might be other ways to achieve the\r\n> > rte_flow functionality.\r\n> > > This issue, and problem raised about the overall change in configuration\r\n> > impact on NICs using this setting (Napatech\r\n> > > does not use it), I think should be reviewed/verified by NIC vendors\r\n> > using it.\r\n> > >\r\n> > >\r\n> > > [Darrell] We need to confirm the masking in the flow (but from what I see,\r\n> > it is ignored as Sugesh mentioned),\r\n> > > which would be a significant difference.\r\n> > > I guess we need input from Intel flow director folks to be sure and\r\n> > check if this can be done otherwise.\r\n> > > What about the 82599 as another example ?\r\n> >\r\n> >\r\n> > I will leave this to Intel folks.\r\n> [Sugesh] From the 82599 datasheet\r\n> \r\n> =======\r\n> The 82599 support two types of filtering modes (static setting by the\r\n> FDIRCTRL.PerfectMatch\r\n> bit):\r\n> * Perfect match filters - The hardware checks a match between the masked\r\n> fields of\r\n> the received packets and the programmed filters. Masked fields should be\r\n> programmed as zeros in the filter context. The 82599 support up to 8 K - 2\r\n> perfect\r\n> match filters.\r\n> * Signature filters - The hardware checks a match between a hash-based\r\n> signature of\r\n> the masked fields of the received packet. The 82599 supports up to 32 K - 2\r\n> signature filters.\r\n> * Notation - The Perfect Match fields and Signature field are denoted as Flow\r\n> ID fields.\r\n> The 82599 supports masking / range for the previously described fields. These\r\n> masks are\r\n> defined globally for all filters in the FDIR...M register.\r\n> =======\r\n> So my understanding is even if it can support masking, the mask is global and\r\n> not per flow.\r\n> \r\n> [Darrell] That was my interpretation as well; same across flow director usages.\r\n> \r\n> Again I will confirm this and provide more details.\r\n> \r\n> [Darrell] One question is – ‘is there some way to enable per flow masking’ with\r\n> this config ?\r\n[Sugesh] No for Intel NIC. It’s a silicon limitation on Fortville. The mask is a global config.\r\n> A second request is – ‘is there another option than\r\n> RTE_FDIR_MODE_PERFECT\r\n> or similar’ to use to achieve the result ?\r\n[Sugesh] For Fortville this is the only option that can use for per flow.\r\n\r\n> \r\n> \r\n> >\r\n> > \t--yliu\r\n>","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","ovs-dev@mail.linuxfoundation.org"],"Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=)","Received":["from mail.linuxfoundation.org (mail.linuxfoundation.org\n\t[140.211.169.12])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xy1Jd0H6xz9s7h\n\tfor ;\n\tWed, 20 Sep 2017 23:47:27 +1000 (AEST)","from mail.linux-foundation.org (localhost [127.0.0.1])\n\tby mail.linuxfoundation.org (Postfix) with ESMTP id 08734BA2;\n\tWed, 20 Sep 2017 13:47:24 +0000 (UTC)","from smtp1.linuxfoundation.org (smtp1.linux-foundation.org\n\t[172.17.192.35])\n\tby mail.linuxfoundation.org (Postfix) with ESMTPS id 5E59EB88\n\tfor ; Wed, 20 Sep 2017 13:47:22 +0000 (UTC)","from mga11.intel.com (mga11.intel.com [192.55.52.93])\n\tby smtp1.linuxfoundation.org (Postfix) with ESMTPS id A81E743A\n\tfor ; Wed, 20 Sep 2017 13:47:21 +0000 (UTC)","from orsmga002.jf.intel.com ([10.7.209.21])\n\tby fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t20 Sep 2017 06:47:21 -0700","from irsmsx151.ger.corp.intel.com ([163.33.192.59])\n\tby orsmga002.jf.intel.com with ESMTP; 20 Sep 2017 06:47:19 -0700","from irsmsx112.ger.corp.intel.com (10.108.20.5) by\n\tIRSMSX151.ger.corp.intel.com (163.33.192.59) with Microsoft SMTP\n\tServer (TLS) id 14.3.319.2; Wed, 20 Sep 2017 14:47:18 +0100","from irsmsx103.ger.corp.intel.com ([169.254.3.49]) by\n\tirsmsx112.ger.corp.intel.com ([169.254.1.142]) with mapi id\n\t14.03.0319.002; Wed, 20 Sep 2017 14:47:18 +0100"],"X-Greylist":"domain auto-whitelisted by SQLgrey-1.7.6","X-ExtLoop1":"1","X-IronPort-AV":"E=Sophos;i=\"5.42,421,1500966000\"; d=\"scan'208\";a=\"137505052\"","From":"\"Chandran, Sugesh\" ","To":"Darrell Ball , Yuanhan Liu ","Thread-Topic":"[ovs-dev] [PATCH v2 8/8] netdev-dpdk: set FDIR config","Thread-Index":"AQHTJimP9HuhVbRUNEaNJEmtDMrOxaKuKvaQgAEeZYCAAAWHAIACu04AgAGpCICAAPu0UP//9qqAgAk7xvA=","Date":"Wed, 20 Sep 2017 13:47:17 +0000","Message-ID":"<2EF2F5C0CC56984AA024D0B180335FCB5254FAB8@IRSMSX103.ger.corp.intel.com>","References":"<1504603381-30071-1-git-send-email-yliu@fridaylinux.org>\n\t<1504603381-30071-9-git-send-email-yliu@fridaylinux.org>\n\t<2EF2F5C0CC56984AA024D0B180335FCB4221DE68@IRSMSX102.ger.corp.intel.com>\n\t<20170911075441.GR9736@yliu-home>\n\t\n\t<31CFAB88-6AC5-48F7-8B8C-B1F506DC6FA8@vmware.com>\n\t<20170914031837.GF2050@yliu-home>\n\t<2EF2F5C0CC56984AA024D0B180335FCB42221BF6@IRSMSX102.ger.corp.intel.com>\n\t<58C6CB9F-4EEA-45FA-B6B4-D932599FC03C@vmware.com>","In-Reply-To":"<58C6CB9F-4EEA-45FA-B6B4-D932599FC03C@vmware.com>","Accept-Language":"en-US","Content-Language":"en-US","X-MS-Has-Attach":"","X-MS-TNEF-Correlator":"","dlp-product":"dlpe-windows","dlp-version":"11.0.0.116","dlp-reaction":"no-action","x-originating-ip":"[163.33.239.181]","MIME-Version":"1.0","X-Spam-Status":"No, score=-5.0 required=5.0 tests=RCVD_IN_DNSWL_HI,\n\tRP_MATCHES_RCVD autolearn=disabled version=3.3.1","X-Spam-Checker-Version":"SpamAssassin 3.3.1 (2010-03-16) on\n\tsmtp1.linux-foundation.org","Cc":"\"dev@openvswitch.org\" ","Subject":"Re: [ovs-dev] [PATCH v2 8/8] netdev-dpdk: set FDIR config","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.12","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Sender":"ovs-dev-bounces@openvswitch.org","Errors-To":"ovs-dev-bounces@openvswitch.org"}},{"id":1772520,"web_url":"http://patchwork.ozlabs.org/comment/1772520/","msgid":"<51599B01-8D6E-4441-A9FF-7067BDE8BD28@vmware.com>","list_archive_url":null,"date":"2017-09-21T08:04:45","subject":"Re: [ovs-dev] [PATCH v2 8/8] netdev-dpdk: set FDIR config","submitter":{"id":68212,"url":"http://patchwork.ozlabs.org/api/people/68212/","name":"Darrell Ball","email":"dball@vmware.com"},"content":"Hi Yuanhan/Finn\r\n\r\nI think we may need to caveat the Fortville nics due to the global mask\r\nlimitation; we also discussed this in the dpdk meeting yesterday.\r\n\r\nWhat do you think ?\r\n\r\nThanks Darrell\r\n\r\nOn 9/20/17, 6:47 AM, \"Chandran, Sugesh\" wrote:\r\n\r\n \r\n \r\n Regards\r\n _Sugesh\r\n \r\n \r\n > -----Original Message-----\r\n > From: Darrell Ball [mailto:dball@vmware.com]\r\n > Sent: Thursday, September 14, 2017 6:46 PM\r\n > To: Chandran, Sugesh ; Yuanhan Liu\r\n > \r\n > Cc: Finn Christensen ; dev@openvswitch.org\r\n > Subject: Re: [ovs-dev] [PATCH v2 8/8] netdev-dpdk: set FDIR config\r\n > \r\n > \r\n > \r\n > On 9/14/17, 10:36 AM, \"Chandran, Sugesh\" \r\n > wrote:\r\n > \r\n > \r\n > \r\n > Regards\r\n > _Sugesh\r\n > \r\n > > -----Original Message-----\r\n > > From: Yuanhan Liu [mailto:yliu@fridaylinux.org]\r\n > > Sent: Thursday, September 14, 2017 4:19 AM\r\n > > To: Darrell Ball \r\n > > Cc: Finn Christensen ; Chandran, Sugesh\r\n > > ; dev@openvswitch.org\r\n > > Subject: Re: [ovs-dev] [PATCH v2 8/8] netdev-dpdk: set FDIR config\r\n > >\r\n > > On Wed, Sep 13, 2017 at 01:57:22AM +0000, Darrell Ball wrote:\r\n > > >\r\n > > >\r\n > > > On 9/11/17, 1:14 AM, \"ovs-dev-bounces@openvswitch.org on behalf of\r\n > > Finn Christensen\" > fc@napatech.com> wrote:\r\n > > >\r\n > > > -----Original Message-----\r\n > > > From: ovs-dev-bounces@openvswitch.org [mailto:ovs-dev-\r\n > > bounces@openvswitch.org] On Behalf Of Yuanhan Liu\r\n > > > Sent: 11. september 2017 09:55\r\n > > > To: Chandran, Sugesh \r\n > > > Cc: dev@openvswitch.org\r\n > > > Subject: Re: [ovs-dev] [PATCH v2 8/8] netdev-dpdk: set FDIR config\r\n > > >\r\n > > > On Mon, Sep 11, 2017 at 07:42:57AM +0000, Chandran, Sugesh wrote:\r\n > > > >\r\n > > > >\r\n > > > > Regards\r\n > > > > _Sugesh\r\n > > > >\r\n > > > >\r\n > > > > > -----Original Message-----\r\n > > > > > From: ovs-dev-bounces@openvswitch.org [mailto:ovs-dev-\r\n > > > > > bounces@openvswitch.org] On Behalf Of Yuanhan Liu\r\n > > > > > Sent: Tuesday, September 5, 2017 10:23 AM\r\n > > > > > To: dev@openvswitch.org\r\n > > > > > Subject: [ovs-dev] [PATCH v2 8/8] netdev-dpdk: set FDIR config\r\n > > > > >\r\n > > > > > From: Finn Christensen \r\n > > > > >\r\n > > > > > The Intel i40e PMD driver requires the fdir mode set to\r\n > > > > > RTE_FDIR_MODE_PERFECT, otherwise, the flow creation would be\r\n > > failed.\r\n > > > > [Sugesh] this means it doesn't honor the flow masks which passed\r\n > onto\r\n > > rte_flow_*?\r\n > > >\r\n > > > IIRC, that's what I found after divig the code. It's an issue reported/fixed\r\n > > by Finn. I also don't have the nic for testing.\r\n > > >\r\n > > > [Finn] Yes, this was needed to make our test setup using an XL710 work,\r\n > > with the rte_flow implementation.\r\n > > > It's a while ago so I don't exactly remember how we ended up with this\r\n > > solution. However, we are definitely not\r\n > > > Intel XL710 experts, so there might be other ways to achieve the\r\n > > rte_flow functionality.\r\n > > > This issue, and problem raised about the overall change in configuration\r\n > > impact on NICs using this setting (Napatech\r\n > > > does not use it), I think should be reviewed/verified by NIC vendors\r\n > > using it.\r\n > > >\r\n > > >\r\n > > > [Darrell] We need to confirm the masking in the flow (but from what I see,\r\n > > it is ignored as Sugesh mentioned),\r\n > > > which would be a significant difference.\r\n > > > I guess we need input from Intel flow director folks to be sure and\r\n > > check if this can be done otherwise.\r\n > > > What about the 82599 as another example ?\r\n > >\r\n > >\r\n > > I will leave this to Intel folks.\r\n > [Sugesh] From the 82599 datasheet\r\n > \r\n > =======\r\n > The 82599 support two types of filtering modes (static setting by the\r\n > FDIRCTRL.PerfectMatch\r\n > bit):\r\n > * Perfect match filters - The hardware checks a match between the masked\r\n > fields of\r\n > the received packets and the programmed filters. Masked fields should be\r\n > programmed as zeros in the filter context. The 82599 support up to 8 K - 2\r\n > perfect\r\n > match filters.\r\n > * Signature filters - The hardware checks a match between a hash-based\r\n > signature of\r\n > the masked fields of the received packet. The 82599 supports up to 32 K - 2\r\n > signature filters.\r\n > * Notation - The Perfect Match fields and Signature field are denoted as Flow\r\n > ID fields.\r\n > The 82599 supports masking / range for the previously described fields. These\r\n > masks are\r\n > defined globally for all filters in the FDIR...M register.\r\n > =======\r\n > So my understanding is even if it can support masking, the mask is global and\r\n > not per flow.\r\n > \r\n > [Darrell] That was my interpretation as well; same across flow director usages.\r\n > \r\n > Again I will confirm this and provide more details.\r\n > \r\n > [Darrell] One question is – ‘is there some way to enable per flow masking’ with\r\n > this config ?\r\n [Sugesh] No for Intel NIC. It’s a silicon limitation on Fortville. The mask is a global config.\r\n > A second request is – ‘is there another option than\r\n > RTE_FDIR_MODE_PERFECT\r\n > or similar’ to use to achieve the result ?\r\n [Sugesh] For Fortville this is the only option that can use for per flow.\r\n \r\n > \r\n > \r\n > >\r\n > > \t--yliu\r\n >","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","ovs-dev@mail.linuxfoundation.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=onevmw.onmicrosoft.com\n\theader.i=@onevmw.onmicrosoft.com header.b=\"Yhr7IRbo\"; \n\tdkim-atps=neutral","spf=none (sender IP is )\n\tsmtp.mailfrom=dball@vmware.com; "],"Received":["from mail.linuxfoundation.org (mail.linuxfoundation.org\n\t[140.211.169.12])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xyTg56RPmz9t3C\n\tfor ;\n\tThu, 21 Sep 2017 18:05:05 +1000 (AEST)","from mail.linux-foundation.org (localhost [127.0.0.1])\n\tby mail.linuxfoundation.org (Postfix) with ESMTP id 3F7E0B14;\n\tThu, 21 Sep 2017 08:04:49 +0000 (UTC)","from smtp1.linuxfoundation.org (smtp1.linux-foundation.org\n\t[172.17.192.35])\n\tby mail.linuxfoundation.org (Postfix) with ESMTPS id 69B20B12\n\tfor ; Thu, 21 Sep 2017 08:04:48 +0000 (UTC)","from NAM01-SN1-obe.outbound.protection.outlook.com\n\t(mail-sn1nam01on0068.outbound.protection.outlook.com [104.47.32.68])\n\tby smtp1.linuxfoundation.org (Postfix) with ESMTPS id 8BAF9163\n\tfor ; Thu, 21 Sep 2017 08:04:47 +0000 (UTC)","from MWHPR05MB3406.namprd05.prod.outlook.com (10.174.175.155) by\n\tMWHPR05MB3405.namprd05.prod.outlook.com (10.174.175.154) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id\n\t15.20.77.5; Thu, 21 Sep 2017 08:04:45 +0000","from MWHPR05MB3406.namprd05.prod.outlook.com ([10.174.175.155]) by\n\tMWHPR05MB3406.namprd05.prod.outlook.com ([10.174.175.155]) with\n\tmapi id 15.20.0077.007; Thu, 21 Sep 2017 08:04:45 +0000"],"X-Greylist":"whitelisted by SQLgrey-1.7.6","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=onevmw.onmicrosoft.com; s=selector1-vmware-com;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version;\n\tbh=Lsk0MTa3uqx7qGH/VeqdK8wvqw86XHS3vdzDjvawyiQ=;\n\tb=Yhr7IRbo3g4N65i4zqiWGojeAi5MspYC41HtNJqRnvFb36bD42PoQxSQcBUNZsq4KpDk+0rEvTQDWVR30ezI6YNzz95W8MXwnM8hVLb0aVBEl7S6gcft+lvK4636fDRCPjiX+ofpgo/fguKyeFVgte+cwxl53+K4Sp9tWFY2I8c=","From":"Darrell Ball ","To":"\"Chandran, Sugesh\" , Yuanhan Liu\n\t","Thread-Topic":"[ovs-dev] [PATCH v2 8/8] netdev-dpdk: set FDIR config","Thread-Index":"AQHTJii3HaN7Ulg3vUOiAKNi8TBjIKKvVtmAgAADR4CAAAWHAIACRfUAgAIeYYCAAO+lAP//jV8AgAmgn4CAATKgAA==","Date":"Thu, 21 Sep 2017 08:04:45 +0000","Message-ID":"<51599B01-8D6E-4441-A9FF-7067BDE8BD28@vmware.com>","References":"<1504603381-30071-1-git-send-email-yliu@fridaylinux.org>\n\t<1504603381-30071-9-git-send-email-yliu@fridaylinux.org>\n\t<2EF2F5C0CC56984AA024D0B180335FCB4221DE68@IRSMSX102.ger.corp.intel.com>\n\t<20170911075441.GR9736@yliu-home>\n\t\n\t<31CFAB88-6AC5-48F7-8B8C-B1F506DC6FA8@vmware.com>\n\t<20170914031837.GF2050@yliu-home>\n\t<2EF2F5C0CC56984AA024D0B180335FCB42221BF6@IRSMSX102.ger.corp.intel.com>\n\t<58C6CB9F-4EEA-45FA-B6B4-D932599FC03C@vmware.com>\n\t<2EF2F5C0CC56984AA024D0B180335FCB5254FAB8@IRSMSX103.ger.corp.intel.com>","In-Reply-To":"<2EF2F5C0CC56984AA024D0B180335FCB5254FAB8@IRSMSX103.ger.corp.intel.com>","Accept-Language":"en-US","Content-Language":"en-US","X-MS-Has-Attach":"","X-MS-TNEF-Correlator":"","user-agent":"Microsoft-MacOutlook/f.26.0.170902","authentication-results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=onevmw.onmicrosoft.com\n\theader.i=@onevmw.onmicrosoft.com header.b=\"Yhr7IRbo\"; \n\tdkim-atps=neutral","spf=none (sender IP is )\n\tsmtp.mailfrom=dball@vmware.com; "],"x-originating-ip":"[73.162.236.45]","x-ms-publictraffictype":"Email","x-microsoft-exchange-diagnostics":"1; MWHPR05MB3405;\n\t20:MIzH6A0RuoeYwhYejoPgf179lCLJdFyd4WL15DEiocVXmdNxFYeYc6Sdrh3F8ZVtKgDfPLuk/VIBI20AXhSWCDkJlcSRpxJGR3OFILPeZbJhYlXfxUVvJwO0FcbY+UpXNZHVbuEi139Z8mlu7+kFnLKXeU1p51t5nd6FVa1DqHo=","x-ms-exchange-antispam-srfa-diagnostics":"SSOS;","x-ms-office365-filtering-correlation-id":"f6e50c06-9fb5-4215-2b5b-08d500c76c02","x-microsoft-antispam":"UriScan:; BCL:0; PCL:0;\n\tRULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(300000503095)(300135400095)(2017052603199)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);\n\tSRVR:MWHPR05MB3405; ","x-ms-traffictypediagnostic":"MWHPR05MB3405:","x-exchange-antispam-report-test":"UriScan:(61668805478150)(216315784871565)(228905959029699); ","x-microsoft-antispam-prvs":"","x-exchange-antispam-report-cfa-test":"BCL:0; PCL:0;\n\tRULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(10201501046)(93006095)(93001095)(3002001)(100000703101)(100105400095)(6041248)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123558100)(20161123562025)(20161123555025)(20161123560025)(20161123564025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);\n\tSRVR:MWHPR05MB3405; BCL:0; PCL:0;\n\tRULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);\n\tSRVR:MWHPR05MB3405; ","x-forefront-prvs":"04371797A5","x-forefront-antispam-report":"SFV:NSPM;\n\tSFS:(10009020)(6009001)(376002)(346002)(76104003)(199003)(24454002)(377454003)(189002)(13464003)(2906002)(6506006)(83506001)(97736004)(3660700001)(6436002)(66066001)(81166006)(105586002)(478600001)(8676002)(86362001)(81156014)(3846002)(54906003)(82746002)(102836003)(33656002)(3280700002)(68736007)(76176999)(6116002)(5660300001)(83716003)(36756003)(2900100001)(189998001)(54356999)(25786009)(229853002)(106356001)(53936002)(53546010)(305945005)(6486002)(6246003)(58126008)(77096006)(7736002)(14454004)(101416001)(2950100002)(8936002)(4326008)(6512007)(316002)(93886005)(110136005)(50986999)(99286003);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:MWHPR05MB3405;\n\tH:MWHPR05MB3406.namprd05.prod.outlook.com; FPR:; SPF:None;\n\tPTR:InfoNoRecords; A:1; MX:1; LANG:en; ","received-spf":"None (protection.outlook.com: vmware.com does not designate\n\tpermitted sender hosts)","spamdiagnosticoutput":"1:99","spamdiagnosticmetadata":"NSPM","Content-ID":"<7256B80760D5F84A9998712980DA8EB2@namprd05.prod.outlook.com>","MIME-Version":"1.0","X-OriginatorOrg":"vmware.com","X-MS-Exchange-CrossTenant-originalarrivaltime":"21 Sep 2017 08:04:45.1804\n\t(UTC)","X-MS-Exchange-CrossTenant-fromentityheader":"Hosted","X-MS-Exchange-CrossTenant-id":"b39138ca-3cee-4b4a-a4d6-cd83d9dd62f0","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"MWHPR05MB3405","X-Spam-Status":"No, score=0.0 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,\n\tRCVD_IN_DNSWL_NONE autolearn=disabled version=3.3.1","X-Spam-Checker-Version":"SpamAssassin 3.3.1 (2010-03-16) on\n\tsmtp1.linux-foundation.org","Cc":"\"dev@openvswitch.org\" ","Subject":"Re: [ovs-dev] [PATCH v2 8/8] netdev-dpdk: set FDIR config","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.12","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Sender":"ovs-dev-bounces@openvswitch.org","Errors-To":"ovs-dev-bounces@openvswitch.org"}},{"id":1772575,"web_url":"http://patchwork.ozlabs.org/comment/1772575/","msgid":"<20170921085434.GD2251@yliu-home>","list_archive_url":null,"date":"2017-09-21T08:54:35","subject":"Re: [ovs-dev] [PATCH v2 8/8] netdev-dpdk: set FDIR config","submitter":{"id":72215,"url":"http://patchwork.ozlabs.org/api/people/72215/","name":"Yuanhan Liu","email":"yliu@fridaylinux.org"},"content":"On Thu, Sep 21, 2017 at 08:04:45AM +0000, Darrell Ball wrote:\n> Hi Yuanhan/Finn\n> \n> I think we may need to caveat the Fortville nics due to the global mask\n> limitation;\n\nSorry, I didn't follow you. Like how? Or what specifically I could/should\ndo?\n\n\t--yliu\n\n> we also discussed this in the dpdk meeting yesterday.\n> \n> What do you think ?\n> \n> Thanks Darrell\n> \n> On 9/20/17, 6:47 AM, \"Chandran, Sugesh\" wrote:\n> \n> \n> \n> Regards\n> _Sugesh\n> \n> \n> > -----Original Message-----\n> > From: Darrell Ball [mailto:dball@vmware.com]\n> > Sent: Thursday, September 14, 2017 6:46 PM\n> > To: Chandran, Sugesh ; Yuanhan Liu\n> > \n> > Cc: Finn Christensen ; dev@openvswitch.org\n> > Subject: Re: [ovs-dev] [PATCH v2 8/8] netdev-dpdk: set FDIR config\n> > \n> > \n> > \n> > On 9/14/17, 10:36 AM, \"Chandran, Sugesh\" \n> > wrote:\n> > \n> > \n> > \n> > Regards\n> > _Sugesh\n> > \n> > > -----Original Message-----\n> > > From: Yuanhan Liu [mailto:yliu@fridaylinux.org]\n> > > Sent: Thursday, September 14, 2017 4:19 AM\n> > > To: Darrell Ball \n> > > Cc: Finn Christensen ; Chandran, Sugesh\n> > > ; dev@openvswitch.org\n> > > Subject: Re: [ovs-dev] [PATCH v2 8/8] netdev-dpdk: set FDIR config\n> > >\n> > > On Wed, Sep 13, 2017 at 01:57:22AM +0000, Darrell Ball wrote:\n> > > >\n> > > >\n> > > > On 9/11/17, 1:14 AM, \"ovs-dev-bounces@openvswitch.org on behalf of\n> > > Finn Christensen\" > > fc@napatech.com> wrote:\n> > > >\n> > > > -----Original Message-----\n> > > > From: ovs-dev-bounces@openvswitch.org [mailto:ovs-dev-\n> > > bounces@openvswitch.org] On Behalf Of Yuanhan Liu\n> > > > Sent: 11. september 2017 09:55\n> > > > To: Chandran, Sugesh \n> > > > Cc: dev@openvswitch.org\n> > > > Subject: Re: [ovs-dev] [PATCH v2 8/8] netdev-dpdk: set FDIR config\n> > > >\n> > > > On Mon, Sep 11, 2017 at 07:42:57AM +0000, Chandran, Sugesh wrote:\n> > > > >\n> > > > >\n> > > > > Regards\n> > > > > _Sugesh\n> > > > >\n> > > > >\n> > > > > > -----Original Message-----\n> > > > > > From: ovs-dev-bounces@openvswitch.org [mailto:ovs-dev-\n> > > > > > bounces@openvswitch.org] On Behalf Of Yuanhan Liu\n> > > > > > Sent: Tuesday, September 5, 2017 10:23 AM\n> > > > > > To: dev@openvswitch.org\n> > > > > > Subject: [ovs-dev] [PATCH v2 8/8] netdev-dpdk: set FDIR config\n> > > > > >\n> > > > > > From: Finn Christensen \n> > > > > >\n> > > > > > The Intel i40e PMD driver requires the fdir mode set to\n> > > > > > RTE_FDIR_MODE_PERFECT, otherwise, the flow creation would be\n> > > failed.\n> > > > > [Sugesh] this means it doesn't honor the flow masks which passed\n> > onto\n> > > rte_flow_*?\n> > > >\n> > > > IIRC, that's what I found after divig the code. It's an issue reported/fixed\n> > > by Finn. I also don't have the nic for testing.\n> > > >\n> > > > [Finn] Yes, this was needed to make our test setup using an XL710 work,\n> > > with the rte_flow implementation.\n> > > > It's a while ago so I don't exactly remember how we ended up with this\n> > > solution. However, we are definitely not\n> > > > Intel XL710 experts, so there might be other ways to achieve the\n> > > rte_flow functionality.\n> > > > This issue, and problem raised about the overall change in configuration\n> > > impact on NICs using this setting (Napatech\n> > > > does not use it), I think should be reviewed/verified by NIC vendors\n> > > using it.\n> > > >\n> > > >\n> > > > [Darrell] We need to confirm the masking in the flow (but from what I see,\n> > > it is ignored as Sugesh mentioned),\n> > > > which would be a significant difference.\n> > > > I guess we need input from Intel flow director folks to be sure and\n> > > check if this can be done otherwise.\n> > > > What about the 82599 as another example ?\n> > >\n> > >\n> > > I will leave this to Intel folks.\n> > [Sugesh] From the 82599 datasheet\n> > \n> > =======\n> > The 82599 support two types of filtering modes (static setting by the\n> > FDIRCTRL.PerfectMatch\n> > bit):\n> > * Perfect match filters - The hardware checks a match between the masked\n> > fields of\n> > the received packets and the programmed filters. Masked fields should be\n> > programmed as zeros in the filter context. The 82599 support up to 8 K - 2\n> > perfect\n> > match filters.\n> > * Signature filters - The hardware checks a match between a hash-based\n> > signature of\n> > the masked fields of the received packet. The 82599 supports up to 32 K - 2\n> > signature filters.\n> > * Notation - The Perfect Match fields and Signature field are denoted as Flow\n> > ID fields.\n> > The 82599 supports masking / range for the previously described fields. These\n> > masks are\n> > defined globally for all filters in the FDIR...M register.\n> > =======\n> > So my understanding is even if it can support masking, the mask is global and\n> > not per flow.\n> > \n> > [Darrell] That was my interpretation as well; same across flow director usages.\n> > \n> > Again I will confirm this and provide more details.\n> > \n> > [Darrell] One question is – ‘is there some way to enable per flow masking’ with\n> > this config ?\n> [Sugesh] No for Intel NIC. It’s a silicon limitation on Fortville. The mask is a global config.\n> > A second request is – ‘is there another option than\n> > RTE_FDIR_MODE_PERFECT\n> > or similar’ to use to achieve the result ?\n> [Sugesh] For Fortville this is the only option that can use for per flow.\n> \n> > \n> > \n> > >\n> > > \t--yliu\n> > \n> \n> \n>","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","ovs-dev@mail.linuxfoundation.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=fridaylinux-org.20150623.gappssmtp.com\n\theader.i=@fridaylinux-org.20150623.gappssmtp.com\n\theader.b=\"EjEifq5M\"; dkim-atps=neutral"],"Received":["from mail.linuxfoundation.org (mail.linuxfoundation.org\n\t[140.211.169.12])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xyVmS6rZSz9sBZ\n\tfor ;\n\tThu, 21 Sep 2017 18:54:48 +1000 (AEST)","from mail.linux-foundation.org (localhost [127.0.0.1])\n\tby mail.linuxfoundation.org (Postfix) with ESMTP id 28F32B7F;\n\tThu, 21 Sep 2017 08:54:46 +0000 (UTC)","from smtp1.linuxfoundation.org (smtp1.linux-foundation.org\n\t[172.17.192.35])\n\tby mail.linuxfoundation.org (Postfix) with ESMTPS id 59246B7A\n\tfor ; Thu, 21 Sep 2017 08:54:44 +0000 (UTC)","from mail-pf0-f177.google.com (mail-pf0-f177.google.com\n\t[209.85.192.177])\n\tby smtp1.linuxfoundation.org (Postfix) with ESMTPS id 632231A6\n\tfor ; Thu, 21 Sep 2017 08:54:43 +0000 (UTC)","by mail-pf0-f177.google.com with SMTP id y29so2921561pff.0\n\tfor ; Thu, 21 Sep 2017 01:54:43 -0700 (PDT)","from yliu-home ([45.63.61.64]) by smtp.gmail.com with ESMTPSA id\n\tw9sm1596925pfg.129.2017.09.21.01.54.40\n\t(version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tThu, 21 Sep 2017 01:54:41 -0700 (PDT)"],"X-Greylist":"whitelisted by SQLgrey-1.7.6","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=fridaylinux-org.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to\n\t:user-agent; bh=lTA2CrRwSYqctyfnljjYz+SQo10GTcHrHoXFgv4BZJo=;\n\tb=EjEifq5MrbI+b0ylv9vIa1q6B+Ti3ordmw30Ed9aJCTdD4NTN0RSOfmhB2Eg81aQTY\n\t0sNOnVakcDxZRMCSFKhmAG88HKnxIBqMWetOV8n7DBp0YMB6QiZbBkqB/8unccZmV904\n\t4fHVzI9xa68qMxaVCTjDPt6Y0eMEkgSkrFgDixXE22yWroKI3U6y9PbJlTFyIO3wFCm4\n\tMAv/M0WXjpkwGsrd+s2+eZLXT8KOWGXoLrZWiSmqllN8WzTyCNSXf7SpqcbwudpIS9eW\n\tqPC3R9rIwRFleb3vLcz/k8Zdmzhf9tDXdeYnlJYhBxxI1ENwWE/nJXRTyPwAol5+kmNg\n\tjhtg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to:user-agent;\n\tbh=lTA2CrRwSYqctyfnljjYz+SQo10GTcHrHoXFgv4BZJo=;\n\tb=iPp1KHS7Z7PQFVCFWiwho8tdlQvgfUboPXwbWkUtLebRhikeDhZwL4G7XPj1/Vv7KN\n\ta9BhyeW5lfJYzPyi43UUK/GOk2mdAolqHiqyWQXRxuf0WgXog1Zl8TpclD/Ei7aeRiJa\n\tIKAJa6Z4rv1DZuXjZsXUuiGYORrY5TTY3NFE1MNYcdQx8MVPwUNH89svKCn7ji/sEHCU\n\t4VB6VDKdeUyRzNPWZ/la434usmxyu/MrKU5sbVFoiYwrRAf3pEmpSxAGxj9ruFa01FTs\n\t/z9eqjOd1hLJ0GE1AXgaCOVeeFsNuqXj+fMK0aJaRTEN4LfnmNAR6NHgGLt7LTk4ofaL\n\txw3w==","X-Gm-Message-State":"AHPjjUi5NUKI5Y/AWUq8RagoVr0hEtH9wDpwSajHHVO7Ze+nXocbPSTb\n\tV8iQsq9lf6eixb67skoDY43s3g==","X-Google-Smtp-Source":"AOwi7QDsDKA45UlH3RwsZjsD2FM1UQjS2byTFs4TTJrJsJqVBZkgZJ6RAkBQ5pvpaAJ8D33P/cm9Pw==","X-Received":"by 10.84.238.137 with SMTP id v9mr4930056plk.180.1505984083011; \n\tThu, 21 Sep 2017 01:54:43 -0700 (PDT)","Date":"Thu, 21 Sep 2017 16:54:35 +0800","From":"Yuanhan Liu ","To":"Darrell Ball ","Message-ID":"<20170921085434.GD2251@yliu-home>","References":"<1504603381-30071-9-git-send-email-yliu@fridaylinux.org>\n\t<2EF2F5C0CC56984AA024D0B180335FCB4221DE68@IRSMSX102.ger.corp.intel.com>\n\t<20170911075441.GR9736@yliu-home>\n\t\n\t<31CFAB88-6AC5-48F7-8B8C-B1F506DC6FA8@vmware.com>\n\t<20170914031837.GF2050@yliu-home>\n\t<2EF2F5C0CC56984AA024D0B180335FCB42221BF6@IRSMSX102.ger.corp.intel.com>\n\t<58C6CB9F-4EEA-45FA-B6B4-D932599FC03C@vmware.com>\n\t<2EF2F5C0CC56984AA024D0B180335FCB5254FAB8@IRSMSX103.ger.corp.intel.com>\n\t<51599B01-8D6E-4441-A9FF-7067BDE8BD28@vmware.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<51599B01-8D6E-4441-A9FF-7067BDE8BD28@vmware.com>","User-Agent":"Mutt/1.5.24 (2015-08-30)","X-Spam-Status":"No, score=0.0 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,\n\tRCVD_IN_DNSWL_NONE autolearn=disabled version=3.3.1","X-Spam-Checker-Version":"SpamAssassin 3.3.1 (2010-03-16) on\n\tsmtp1.linux-foundation.org","Cc":"\"dev@openvswitch.org\" ","Subject":"Re: [ovs-dev] [PATCH v2 8/8] netdev-dpdk: set FDIR config","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.12","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Sender":"ovs-dev-bounces@openvswitch.org","Errors-To":"ovs-dev-bounces@openvswitch.org"}},{"id":1772580,"web_url":"http://patchwork.ozlabs.org/comment/1772580/","msgid":"","list_archive_url":null,"date":"2017-09-21T09:00:10","subject":"Re: [ovs-dev] [PATCH v2 8/8] netdev-dpdk: set FDIR config","submitter":{"id":68212,"url":"http://patchwork.ozlabs.org/api/people/68212/","name":"Darrell Ball","email":"dball@vmware.com"},"content":"On 9/21/17, 1:54 AM, \"Yuanhan Liu\" wrote:\r\n\r\n On Thu, Sep 21, 2017 at 08:04:45AM +0000, Darrell Ball wrote:\r\n > Hi Yuanhan/Finn\r\n > \r\n > I think we may need to caveat the Fortville nics due to the global mask\r\n > limitation;\r\n \r\n Sorry, I didn't follow you. Like how? Or what specifically I could/should\r\n do?\r\n\r\n\r\nI meant to say that we would not need this patch 8, since it can only allow exact match anyways.\r\nThis would not fit well with the other nics support and the overall design.\r\nWe would also add some comments to the documentation describing the non-support for Fortville\r\nfor the feature.\r\n\r\nDarrell\r\n \r\n \t--yliu\r\n \r\n > we also discussed this in the dpdk meeting yesterday.\r\n > \r\n > What do you think ?\r\n > \r\n > Thanks Darrell\r\n > \r\n > On 9/20/17, 6:47 AM, \"Chandran, Sugesh\" wrote:\r\n > \r\n > \r\n > \r\n > Regards\r\n > _Sugesh\r\n > \r\n > \r\n > > -----Original Message-----\r\n > > From: Darrell Ball [mailto:dball@vmware.com]\r\n > > Sent: Thursday, September 14, 2017 6:46 PM\r\n > > To: Chandran, Sugesh ; Yuanhan Liu\r\n > > \r\n > > Cc: Finn Christensen ; dev@openvswitch.org\r\n > > Subject: Re: [ovs-dev] [PATCH v2 8/8] netdev-dpdk: set FDIR config\r\n > > \r\n > > \r\n > > \r\n > > On 9/14/17, 10:36 AM, \"Chandran, Sugesh\" \r\n > > wrote:\r\n > > \r\n > > \r\n > > \r\n > > Regards\r\n > > _Sugesh\r\n > > \r\n > > > -----Original Message-----\r\n > > > From: Yuanhan Liu [mailto:yliu@fridaylinux.org]\r\n > > > Sent: Thursday, September 14, 2017 4:19 AM\r\n > > > To: Darrell Ball \r\n > > > Cc: Finn Christensen ; Chandran, Sugesh\r\n > > > ; dev@openvswitch.org\r\n > > > Subject: Re: [ovs-dev] [PATCH v2 8/8] netdev-dpdk: set FDIR config\r\n > > >\r\n > > > On Wed, Sep 13, 2017 at 01:57:22AM +0000, Darrell Ball wrote:\r\n > > > >\r\n > > > >\r\n > > > > On 9/11/17, 1:14 AM, \"ovs-dev-bounces@openvswitch.org on behalf of\r\n > > > Finn Christensen\" > > fc@napatech.com> wrote:\r\n > > > >\r\n > > > > -----Original Message-----\r\n > > > > From: ovs-dev-bounces@openvswitch.org [mailto:ovs-dev-\r\n > > > bounces@openvswitch.org] On Behalf Of Yuanhan Liu\r\n > > > > Sent: 11. september 2017 09:55\r\n > > > > To: Chandran, Sugesh \r\n > > > > Cc: dev@openvswitch.org\r\n > > > > Subject: Re: [ovs-dev] [PATCH v2 8/8] netdev-dpdk: set FDIR config\r\n > > > >\r\n > > > > On Mon, Sep 11, 2017 at 07:42:57AM +0000, Chandran, Sugesh wrote:\r\n > > > > >\r\n > > > > >\r\n > > > > > Regards\r\n > > > > > _Sugesh\r\n > > > > >\r\n > > > > >\r\n > > > > > > -----Original Message-----\r\n > > > > > > From: ovs-dev-bounces@openvswitch.org [mailto:ovs-dev-\r\n > > > > > > bounces@openvswitch.org] On Behalf Of Yuanhan Liu\r\n > > > > > > Sent: Tuesday, September 5, 2017 10:23 AM\r\n > > > > > > To: dev@openvswitch.org\r\n > > > > > > Subject: [ovs-dev] [PATCH v2 8/8] netdev-dpdk: set FDIR config\r\n > > > > > >\r\n > > > > > > From: Finn Christensen \r\n > > > > > >\r\n > > > > > > The Intel i40e PMD driver requires the fdir mode set to\r\n > > > > > > RTE_FDIR_MODE_PERFECT, otherwise, the flow creation would be\r\n > > > failed.\r\n > > > > > [Sugesh] this means it doesn't honor the flow masks which passed\r\n > > onto\r\n > > > rte_flow_*?\r\n > > > >\r\n > > > > IIRC, that's what I found after divig the code. It's an issue reported/fixed\r\n > > > by Finn. I also don't have the nic for testing.\r\n > > > >\r\n > > > > [Finn] Yes, this was needed to make our test setup using an XL710 work,\r\n > > > with the rte_flow implementation.\r\n > > > > It's a while ago so I don't exactly remember how we ended up with this\r\n > > > solution. However, we are definitely not\r\n > > > > Intel XL710 experts, so there might be other ways to achieve the\r\n > > > rte_flow functionality.\r\n > > > > This issue, and problem raised about the overall change in configuration\r\n > > > impact on NICs using this setting (Napatech\r\n > > > > does not use it), I think should be reviewed/verified by NIC vendors\r\n > > > using it.\r\n > > > >\r\n > > > >\r\n > > > > [Darrell] We need to confirm the masking in the flow (but from what I see,\r\n > > > it is ignored as Sugesh mentioned),\r\n > > > > which would be a significant difference.\r\n > > > > I guess we need input from Intel flow director folks to be sure and\r\n > > > check if this can be done otherwise.\r\n > > > > What about the 82599 as another example ?\r\n > > >\r\n > > >\r\n > > > I will leave this to Intel folks.\r\n > > [Sugesh] From the 82599 datasheet\r\n > > \r\n > > =======\r\n > > The 82599 support two types of filtering modes (static setting by the\r\n > > FDIRCTRL.PerfectMatch\r\n > > bit):\r\n > > * Perfect match filters - The hardware checks a match between the masked\r\n > > fields of\r\n > > the received packets and the programmed filters. Masked fields should be\r\n > > programmed as zeros in the filter context. The 82599 support up to 8 K - 2\r\n > > perfect\r\n > > match filters.\r\n > > * Signature filters - The hardware checks a match between a hash-based\r\n > > signature of\r\n > > the masked fields of the received packet. The 82599 supports up to 32 K - 2\r\n > > signature filters.\r\n > > * Notation - The Perfect Match fields and Signature field are denoted as Flow\r\n > > ID fields.\r\n > > The 82599 supports masking / range for the previously described fields. These\r\n > > masks are\r\n > > defined globally for all filters in the FDIR...M register.\r\n > > =======\r\n > > So my understanding is even if it can support masking, the mask is global and\r\n > > not per flow.\r\n > > \r\n > > [Darrell] That was my interpretation as well; same across flow director usages.\r\n > > \r\n > > Again I will confirm this and provide more details.\r\n > > \r\n > > [Darrell] One question is – ‘is there some way to enable per flow masking’ with\r\n > > this config ?\r\n > [Sugesh] No for Intel NIC. It’s a silicon limitation on Fortville. The mask is a global config.\r\n > > A second request is – ‘is there another option than\r\n > > RTE_FDIR_MODE_PERFECT\r\n > > or similar’ to use to achieve the result ?\r\n > [Sugesh] For Fortville this is the only option that can use for per flow.\r\n > \r\n > > \r\n > > \r\n > > >\r\n > > > \t--yliu\r\n > > \r\n > \r\n > \r\n >","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","ovs-dev@mail.linuxfoundation.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=onevmw.onmicrosoft.com\n\theader.i=@onevmw.onmicrosoft.com header.b=\"Sx7HNgrM\"; \n\tdkim-atps=neutral","spf=none (sender IP is )\n\tsmtp.mailfrom=dball@vmware.com; "],"Received":["from mail.linuxfoundation.org (mail.linuxfoundation.org\n\t[140.211.169.12])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xyVtx2Jgmz9t3w\n\tfor ;\n\tThu, 21 Sep 2017 19:00:25 +1000 (AEST)","from mail.linux-foundation.org (localhost [127.0.0.1])\n\tby mail.linuxfoundation.org (Postfix) with ESMTP id 6C822BAF;\n\tThu, 21 Sep 2017 09:00:16 +0000 (UTC)","from smtp1.linuxfoundation.org (smtp1.linux-foundation.org\n\t[172.17.192.35])\n\tby mail.linuxfoundation.org (Postfix) with ESMTPS id 5880BB8B\n\tfor ; Thu, 21 Sep 2017 09:00:14 +0000 (UTC)","from NAM02-SN1-obe.outbound.protection.outlook.com\n\t(mail-sn1nam02on0049.outbound.protection.outlook.com [104.47.36.49])\n\tby smtp1.linuxfoundation.org (Postfix) with ESMTPS id 7F65F1AE\n\tfor ; Thu, 21 Sep 2017 09:00:13 +0000 (UTC)","from MWHPR05MB3406.namprd05.prod.outlook.com (10.174.175.155) by\n\tMWHPR05MB3407.namprd05.prod.outlook.com (10.174.175.156) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id\n\t15.20.77.5; Thu, 21 Sep 2017 09:00:10 +0000","from MWHPR05MB3406.namprd05.prod.outlook.com ([10.174.175.155]) by\n\tMWHPR05MB3406.namprd05.prod.outlook.com ([10.174.175.155]) with\n\tmapi id 15.20.0077.007; Thu, 21 Sep 2017 09:00:10 +0000"],"X-Greylist":"whitelisted by SQLgrey-1.7.6","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=onevmw.onmicrosoft.com; s=selector1-vmware-com;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version;\n\tbh=kWELRbhxZKqxxlpj6Yte5GVb7IaDGgXI5ZsiVSjIlZg=;\n\tb=Sx7HNgrMkVGvzGo+qz92T5JhDZ2g0uwxK7di24ABn/8Xf5tQSb10kMn7Q/rdS3TOV4QH5HlAYCQq2YXtG8fo0qoGzpTJlIGjHXEO+AkHDtU2eyF3R7BpDyYnTcKMulMRwE8784+7rDOFQGxsYyIlzH2MvU1Ap/A1G0L3r8W5p1A=","From":"Darrell Ball ","To":"Yuanhan Liu ","Thread-Topic":"[ovs-dev] [PATCH v2 8/8] netdev-dpdk: set FDIR config","Thread-Index":"AQHTJii3HaN7Ulg3vUOiAKNi8TBjIKKvVtmAgAADR4CAAAWHAIACRfUAgAIeYYCAAO+lAP//jV8AgAmgn4CAATKgAIAADe2AgAABjwA=","Date":"Thu, 21 Sep 2017 09:00:10 +0000","Message-ID":"","References":"<1504603381-30071-9-git-send-email-yliu@fridaylinux.org>\n\t<2EF2F5C0CC56984AA024D0B180335FCB4221DE68@IRSMSX102.ger.corp.intel.com>\n\t<20170911075441.GR9736@yliu-home>\n\t\n\t<31CFAB88-6AC5-48F7-8B8C-B1F506DC6FA8@vmware.com>\n\t<20170914031837.GF2050@yliu-home>\n\t<2EF2F5C0CC56984AA024D0B180335FCB42221BF6@IRSMSX102.ger.corp.intel.com>\n\t<58C6CB9F-4EEA-45FA-B6B4-D932599FC03C@vmware.com>\n\t<2EF2F5C0CC56984AA024D0B180335FCB5254FAB8@IRSMSX103.ger.corp.intel.com>\n\t<51599B01-8D6E-4441-A9FF-7067BDE8BD28@vmware.com>\n\t<20170921085434.GD2251@yliu-home>","In-Reply-To":"<20170921085434.GD2251@yliu-home>","Accept-Language":"en-US","Content-Language":"en-US","X-MS-Has-Attach":"","X-MS-TNEF-Correlator":"","user-agent":"Microsoft-MacOutlook/f.26.0.170902","authentication-results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=onevmw.onmicrosoft.com\n\theader.i=@onevmw.onmicrosoft.com header.b=\"Sx7HNgrM\"; \n\tdkim-atps=neutral","spf=none (sender IP is )\n\tsmtp.mailfrom=dball@vmware.com; "],"x-originating-ip":"[73.162.236.45]","x-ms-publictraffictype":"Email","x-microsoft-exchange-diagnostics":"1; MWHPR05MB3407;\n\t20:iuRC75v58vZKn0ceP7RmhtzG7ltzIzMRor0E+BhZNBIpYyIOQbMtGSaZlirF+t1Sy4JVNfTZvcGMIzBSuG0esWFm4jHXffXbd0M5hzfJjMoz0DA5cytllrHh+guhlHl4UEUYj6DG1+DMV+FJGk5R44aiIiZSIGOoxTSrP7PgCxA=","x-ms-exchange-antispam-srfa-diagnostics":"SSOS;","x-ms-office365-filtering-correlation-id":"894c5d7e-046c-429c-493b-08d500cf2a09","x-microsoft-antispam":"UriScan:; BCL:0; PCL:0;\n\tRULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(300000503095)(300135400095)(2017052603199)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);\n\tSRVR:MWHPR05MB3407; ","x-ms-traffictypediagnostic":"MWHPR05MB3407:","x-exchange-antispam-report-test":"UriScan:(61668805478150)(216315784871565)(228905959029699); ","x-microsoft-antispam-prvs":"","x-exchange-antispam-report-cfa-test":"BCL:0; PCL:0;\n\tRULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(10201501046)(93006095)(93001095)(100000703101)(100105400095)(3002001)(6041248)(20161123564025)(20161123558100)(20161123555025)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123560025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);\n\tSRVR:MWHPR05MB3407; BCL:0; PCL:0;\n\tRULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);\n\tSRVR:MWHPR05MB3407; ","x-forefront-prvs":"04371797A5","x-forefront-antispam-report":"SFV:NSPM;\n\tSFS:(10009020)(6009001)(346002)(376002)(13464003)(24454002)(377454003)(76104003)(189002)(199003)(36756003)(93886005)(25786009)(77096006)(5660300001)(6116002)(102836003)(3846002)(478600001)(101416001)(54356999)(50986999)(8676002)(105586002)(76176999)(3280700002)(6486002)(3660700001)(97736004)(33656002)(2906002)(81156014)(8936002)(189998001)(6436002)(82746002)(2950100002)(99286003)(7736002)(58126008)(6246003)(305945005)(66066001)(53936002)(6916009)(2900100001)(6512007)(53546010)(14454004)(68736007)(4326008)(83716003)(83506001)(316002)(106356001)(86362001)(6506006)(81166006)(229853002)(54906003);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:MWHPR05MB3407;\n\tH:MWHPR05MB3406.namprd05.prod.outlook.com; FPR:; SPF:None;\n\tPTR:InfoNoRecords; MX:1; A:1; LANG:en; ","received-spf":"None (protection.outlook.com: vmware.com does not designate\n\tpermitted sender hosts)","spamdiagnosticoutput":"1:99","spamdiagnosticmetadata":"NSPM","Content-ID":"<1087C4CC78B23F44893E05A685EBA128@namprd05.prod.outlook.com>","MIME-Version":"1.0","X-OriginatorOrg":"vmware.com","X-MS-Exchange-CrossTenant-originalarrivaltime":"21 Sep 2017 09:00:10.4243\n\t(UTC)","X-MS-Exchange-CrossTenant-fromentityheader":"Hosted","X-MS-Exchange-CrossTenant-id":"b39138ca-3cee-4b4a-a4d6-cd83d9dd62f0","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"MWHPR05MB3407","X-Spam-Status":"No, score=0.0 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,\n\tRCVD_IN_DNSWL_NONE autolearn=disabled version=3.3.1","X-Spam-Checker-Version":"SpamAssassin 3.3.1 (2010-03-16) on\n\tsmtp1.linux-foundation.org","Cc":"\"dev@openvswitch.org\" ","Subject":"Re: [ovs-dev] [PATCH v2 8/8] netdev-dpdk: set FDIR config","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.12","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Sender":"ovs-dev-bounces@openvswitch.org","Errors-To":"ovs-dev-bounces@openvswitch.org"}},{"id":1772586,"web_url":"http://patchwork.ozlabs.org/comment/1772586/","msgid":"<53d45181e2ed4530b472ca30f0488e06@napatech.com>","list_archive_url":null,"date":"2017-09-21T09:05:23","subject":"Re: [ovs-dev] [PATCH v2 8/8] netdev-dpdk: set FDIR config","submitter":{"id":72305,"url":"http://patchwork.ozlabs.org/api/people/72305/","name":"Finn Christensen","email":"fc@napatech.com"},"content":"-----Original Message-----\r\n From: Darrell Ball [mailto:dball@vmware.com]\r\n Sent: 21. september 2017 11:00\r\n To: Yuanhan Liu \r\n Cc: Chandran, Sugesh ; Finn Christensen\r\n ; dev@openvswitch.org\r\n Subject: Re: [ovs-dev] [PATCH v2 8/8] netdev-dpdk: set FDIR config\r\n \r\n \r\n \r\n On 9/21/17, 1:54 AM, \"Yuanhan Liu\" wrote:\r\n \r\n On Thu, Sep 21, 2017 at 08:04:45AM +0000, Darrell Ball wrote:\r\n > Hi Yuanhan/Finn\r\n >\r\n > I think we may need to caveat the Fortville nics due to the global mask\r\n > limitation;\r\n \r\n Sorry, I didn't follow you. Like how? Or what specifically I could/should\r\n do?\r\n \r\n \r\n I meant to say that we would not need this patch 8, since it can only allow\r\n exact match anyways.\r\n This would not fit well with the other nics support and the overall design.\r\n We would also add some comments to the documentation describing the\r\n non-support for Fortville for the feature.\r\n \r\n Darrell\r\n\r\n[Finn] Agreed. This will not work well.\r\n \r\n \t--yliu\r\n \r\n > we also discussed this in the dpdk meeting yesterday.\r\n >\r\n > What do you think ?\r\n >\r\n > Thanks Darrell\r\n >\r\n > On 9/20/17, 6:47 AM, \"Chandran, Sugesh\"\r\n wrote:\r\n >\r\n >\r\n >\r\n > Regards\r\n > _Sugesh\r\n >\r\n >\r\n > > -----Original Message-----\r\n > > From: Darrell Ball [mailto:dball@vmware.com]\r\n > > Sent: Thursday, September 14, 2017 6:46 PM\r\n > > To: Chandran, Sugesh ; Yuanhan Liu\r\n > > \r\n > > Cc: Finn Christensen ; dev@openvswitch.org\r\n > > Subject: Re: [ovs-dev] [PATCH v2 8/8] netdev-dpdk: set FDIR config\r\n > >\r\n > >\r\n > >\r\n > > On 9/14/17, 10:36 AM, \"Chandran, Sugesh\"\r\n \r\n > > wrote:\r\n > >\r\n > >\r\n > >\r\n > > Regards\r\n > > _Sugesh\r\n > >\r\n > > > -----Original Message-----\r\n > > > From: Yuanhan Liu [mailto:yliu@fridaylinux.org]\r\n > > > Sent: Thursday, September 14, 2017 4:19 AM\r\n > > > To: Darrell Ball \r\n > > > Cc: Finn Christensen ; Chandran, Sugesh\r\n > > > ; dev@openvswitch.org\r\n > > > Subject: Re: [ovs-dev] [PATCH v2 8/8] netdev-dpdk: set FDIR\r\n config\r\n > > >\r\n > > > On Wed, Sep 13, 2017 at 01:57:22AM +0000, Darrell Ball wrote:\r\n > > > >\r\n > > > >\r\n > > > > On 9/11/17, 1:14 AM, \"ovs-dev-bounces@openvswitch.org\r\n on behalf of\r\n > > > Finn Christensen\" > > fc@napatech.com> wrote:\r\n > > > >\r\n > > > > -----Original Message-----\r\n > > > > From: ovs-dev-bounces@openvswitch.org [mailto:ovs-dev-\r\n > > > bounces@openvswitch.org] On Behalf Of Yuanhan Liu\r\n > > > > Sent: 11. september 2017 09:55\r\n > > > > To: Chandran, Sugesh \r\n > > > > Cc: dev@openvswitch.org\r\n > > > > Subject: Re: [ovs-dev] [PATCH v2 8/8] netdev-dpdk: set\r\n FDIR config\r\n > > > >\r\n > > > > On Mon, Sep 11, 2017 at 07:42:57AM +0000, Chandran,\r\n Sugesh wrote:\r\n > > > > >\r\n > > > > >\r\n > > > > > Regards\r\n > > > > > _Sugesh\r\n > > > > >\r\n > > > > >\r\n > > > > > > -----Original Message-----\r\n > > > > > > From: ovs-dev-bounces@openvswitch.org [mailto:ovs-\r\n dev-\r\n > > > > > > bounces@openvswitch.org] On Behalf Of Yuanhan Liu\r\n > > > > > > Sent: Tuesday, September 5, 2017 10:23 AM\r\n > > > > > > To: dev@openvswitch.org\r\n > > > > > > Subject: [ovs-dev] [PATCH v2 8/8] netdev-dpdk: set\r\n FDIR config\r\n > > > > > >\r\n > > > > > > From: Finn Christensen \r\n > > > > > >\r\n > > > > > > The Intel i40e PMD driver requires the fdir mode set to\r\n > > > > > > RTE_FDIR_MODE_PERFECT, otherwise, the flow\r\n creation would be\r\n > > > failed.\r\n > > > > > [Sugesh] this means it doesn't honor the flow masks\r\n which passed\r\n > > onto\r\n > > > rte_flow_*?\r\n > > > >\r\n > > > > IIRC, that's what I found after divig the code. It's an issue\r\n reported/fixed\r\n > > > by Finn. I also don't have the nic for testing.\r\n > > > >\r\n > > > > [Finn] Yes, this was needed to make our test setup using an\r\n XL710 work,\r\n > > > with the rte_flow implementation.\r\n > > > > It's a while ago so I don't exactly remember how we ended\r\n up with this\r\n > > > solution. However, we are definitely not\r\n > > > > Intel XL710 experts, so there might be other ways to\r\n achieve the\r\n > > > rte_flow functionality.\r\n > > > > This issue, and problem raised about the overall change in\r\n configuration\r\n > > > impact on NICs using this setting (Napatech\r\n > > > > does not use it), I think should be reviewed/verified by NIC\r\n vendors\r\n > > > using it.\r\n > > > >\r\n > > > >\r\n > > > > [Darrell] We need to confirm the masking in the flow (but\r\n from what I see,\r\n > > > it is ignored as Sugesh mentioned),\r\n > > > > which would be a significant difference.\r\n > > > > I guess we need input from Intel flow director folks to\r\n be sure and\r\n > > > check if this can be done otherwise.\r\n > > > > What about the 82599 as another example ?\r\n > > >\r\n > > >\r\n > > > I will leave this to Intel folks.\r\n > > [Sugesh] From the 82599 datasheet\r\n > >\r\n > > =======\r\n > > The 82599 support two types of filtering modes (static setting by\r\n the\r\n > > FDIRCTRL.PerfectMatch\r\n > > bit):\r\n > > * Perfect match filters - The hardware checks a match between\r\n the masked\r\n > > fields of\r\n > > the received packets and the programmed filters. Masked fields\r\n should be\r\n > > programmed as zeros in the filter context. The 82599 support up\r\n to 8 K - 2\r\n > > perfect\r\n > > match filters.\r\n > > * Signature filters - The hardware checks a match between a\r\n hash-based\r\n > > signature of\r\n > > the masked fields of the received packet. The 82599 supports up\r\n to 32 K - 2\r\n > > signature filters.\r\n > > * Notation - The Perfect Match fields and Signature field are\r\n denoted as Flow\r\n > > ID fields.\r\n > > The 82599 supports masking / range for the previously described\r\n fields. These\r\n > > masks are\r\n > > defined globally for all filters in the FDIR...M register.\r\n > > =======\r\n > > So my understanding is even if it can support masking, the mask\r\n is global and\r\n > > not per flow.\r\n > >\r\n > > [Darrell] That was my interpretation as well; same across flow\r\n director usages.\r\n > >\r\n > > Again I will confirm this and provide more details.\r\n > >\r\n > > [Darrell] One question is – ‘is there some way to enable per flow\r\n masking’ with\r\n > > this config ?\r\n > [Sugesh] No for Intel NIC. It’s a silicon limitation on Fortville. The\r\n mask is a global config.\r\n > > A second request is – ‘is there another option than\r\n > > RTE_FDIR_MODE_PERFECT\r\n > > or similar’ to use to achieve the result ?\r\n > [Sugesh] For Fortville this is the only option that can use for per flow.\r\n >\r\n > >\r\n > >\r\n > > >\r\n > > > \t--yliu\r\n > >\r\n >\r\n >\r\n >","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","ovs-dev@mail.linuxfoundation.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=napatech.com header.i=@napatech.com\n\theader.b=\"VkZsvDUn\"; dkim-atps=neutral"],"Received":["from mail.linuxfoundation.org (mail.linuxfoundation.org\n\t[140.211.169.12])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xyW0t4p0rz9t3w\n\tfor ;\n\tThu, 21 Sep 2017 19:05:34 +1000 (AEST)","from mail.linux-foundation.org (localhost [127.0.0.1])\n\tby mail.linuxfoundation.org (Postfix) with ESMTP id 84D84B8F;\n\tThu, 21 Sep 2017 09:05:32 +0000 (UTC)","from smtp1.linuxfoundation.org (smtp1.linux-foundation.org\n\t[172.17.192.35])\n\tby mail.linuxfoundation.org (Postfix) with ESMTPS id 0E159B8E\n\tfor ; Thu, 21 Sep 2017 09:05:31 +0000 (UTC)","from mail01.napatech.com (mail01.napatech.com [188.120.77.121])\n\tby smtp1.linuxfoundation.org (Postfix) with ESMTPS id 74CC41A6\n\tfor ; Thu, 21 Sep 2017 09:05:28 +0000 (UTC)","from cph-gen-exch02.napatech.com (10.240.1.84) by\n\tcph-gen-exch02.napatech.com (10.240.1.84) with Microsoft SMTP Server\n\t(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id\n\t15.1.1034.26; Thu, 21 Sep 2017 11:05:23 +0200","from cph-gen-exch02.napatech.com ([fe80::581:51a1:ac3f:84e]) by\n\tcph-gen-exch02.napatech.com ([fe80::581:51a1:ac3f:84e%12]) with mapi\n\tid 15.01.1034.026; Thu, 21 Sep 2017 11:05:23 +0200"],"X-Greylist":"domain auto-whitelisted by SQLgrey-1.7.6","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=napatech.com; i=@napatech.com; q=dns/txt; s=mar2017;\n\tt=1505984728; x=1537520728;\n\th=from:to:cc:subject:date:message-id:references:\n\tin-reply-to:content-transfer-encoding:mime-version;\n\tbh=3pG6JTiR2t/4xmVPY3PRy1GhPZiv7OqdM264+V+CRCo=;\n\tb=VkZsvDUnUfoHp36W1v6frlM9EnJ1avnGZtiL9ntHBB8UMWvDUwMOjHlq\n\t6vprBdWYvo1LJ/DSyd8M0YPJzLukd1WO9/9PsarLWeqmUq4PnhuWBJNd5\n\tuoDs61kj7bcJV6Jw+qf2regltM3lmtWzaOWwaMXoNsw+Ex/4oiI8g8r7N\n\t9a57++/ZLE6Uin5ywlS1qqM4vOw4yxP1J5LJvFBLql6l1gSyNwhZxymu1\n\tLOOCzTeEWOz61Ttgi7HAFCyfx43UulST0BLOgZIG4Bvimb29DrV4x8hOx\n\tdARwGW3STkiK7r6QscgzfAVwaFB8KAYJOOSr5YaSd0d6gwmG5REt9HcSc w==;","IronPort-PHdr":"9a23:4J4exx0Z5rDFZxxmsmDT+DRfVm0co7zxezQtwd8ZseIQKvad9pjvdHbS+e9qxAeQG96KurQa0aGO7OjJYi8p2d65qncMcZhBBVcuqP49uEgeOvODElDxN/XwbiY3T4xoXV5h+GynYwAOQJ6tL1LdrWev4jEMBx7xKRR6JvjvGo7Vks+7y/2+94fdbghMgDexe7J/IAu5oQnNtMQdnJdvJLs2xhbVuHVDZv5YxXlvJVKdnhb84tm/8Zt++ClOuPwv6tBNX7zic6s3UbJXAjImM3so5MLwrhnMURGP5noHXWoIlBdDHhXI4wv7Xpf1tSv6q/Z91SyHNsD4Ubw4RTKv5LpwRRT2lCkIKSI28GDPisxxkq1bpg6hpwdiyILQeY2ZKeZycr/Ycd4cWGFPXNteVzZZD428cYUBEvYBM+hboYnzpVQOrAexCwajC+701j9HnX320bEm3+g9EwzL2hErEdIUsHTTqdX4LKccUeGzzKnO0D7OcfNW2S386IjTbhAuv/eMXalufsrX1EIiEA3FgUmLpIzjJTyVzv4Cs3SF4OV8VeKjkXIoqwZ0ojW2wMonl4rHhpoNx1zZ6Sl12pg5KNKkREJhfNKoCphdui6CO4drXs8uWX9ktSkmxrEcpJK3YDIGxIkpyhPRc/CHfZaH7xH/WOuUJDp1hHFodK+6ihuy7ESv0PDwW8yu31lWoCdFnNzBu3MC2hPN7MWMV+Fz8V272TmV0gDe8uREIUcpmqXFM5Mh2bswloYLsUTEAy/2hF36jK+IeUUg/eil8+Hnba/npp+YLYN0jBvxMrw0lcyjH+s3LggOU3KH9uS70b3v5Uz5QLNUgf0qiqTVrYzWKd4FqqO2HwNZyJsv5wy8AjqpyNgYmGMILFNBeBKJlYjpPFTOLej2DfijmFmsli1kx+jcMb39HJrCMnjDnK39crZ67k5Q0BAzwsxH55JIFrEBJ+r+VVLvu9zGFRI5NBS0zPjhCNVjzYMfV2OPArOFP6PSq1OI4fgvI+bfLLMS7Rr0MeIo4/qmp3Y9nRdJcaOg2Z8/dnWnF+5rZU6eZCyoyuYcGGEKtwx2aO33wAmTVT9OT3ioXq419zU6Dp+2S4DZSdb+rqaG2XKVH5tQLktGEFGXDXrubIiCE6MCYwqUK9dojjEPVf6qTIp3hkLmjxPz17cydrmcwSYfr5+2kYEtv+A=","X-IronPort-Anti-Spam-Filtered":"true","X-IronPort-Anti-Spam-Result":"A2FuAAAhgMNZ/1QB8ApdGQEBAQEBAQEBAQEBBwEBAQEBFAEBAQEBAQEBAQEBBwEBAQEBhSgHg2+KIJFrlimCEgqFOwIahRMYAQEBAQEBAQEBAQECgRCCMyQBgkABAQEBAgEjETcODAQCAQYCDgMEAQEBAgIjAwICAjAUAQgIAgQBDQUIE4oQiV6dZoInin4BAQEBAQEBAQEBAQEBAQEBAQEBAQEdgQ6CHYNTgWSDKIgOgmAFigiJF410lE6TBJUNAgICAgkCGoE5H4FGdxWFYR2BZ3aIEoEQAQEB","X-IPAS-Result":"A2FuAAAhgMNZ/1QB8ApdGQEBAQEBAQEBAQEBBwEBAQEBFAEBAQEBAQEBAQEBBwEBAQEBhSgHg2+KIJFrlimCEgqFOwIahRMYAQEBAQEBAQEBAQECgRCCMyQBgkABAQEBAgEjETcODAQCAQYCDgMEAQEBAgIjAwICAjAUAQgIAgQBDQUIE4oQiV6dZoInin4BAQEBAQEBAQEBAQEBAQEBAQEBAQEdgQ6CHYNTgWSDKIgOgmAFigiJF410lE6TBJUNAgICAgkCGoE5H4FGdxWFYR2BZ3aIEoEQAQEB","From":"Finn Christensen ","To":"Darrell Ball , Yuanhan Liu ","Thread-Topic":"[ovs-dev] [PATCH v2 8/8] netdev-dpdk: set FDIR config","Thread-Index":"AQHTJii2lNwhttGaYU+sb+Hi6lfzl6KvNVKAgAADR4CAACKa0IACnjsAgAGpCICAAO+lAIAAArmAgAkrRYCAATKhgIAADeyAgAABjwCAACKDoA==","Date":"Thu, 21 Sep 2017 09:05:23 +0000","Message-ID":"<53d45181e2ed4530b472ca30f0488e06@napatech.com>","References":"<1504603381-30071-9-git-send-email-yliu@fridaylinux.org>\n\t<2EF2F5C0CC56984AA024D0B180335FCB4221DE68@IRSMSX102.ger.corp.intel.com>\n\t<20170911075441.GR9736@yliu-home>\n\t\n\t<31CFAB88-6AC5-48F7-8B8C-B1F506DC6FA8@vmware.com>\n\t<20170914031837.GF2050@yliu-home>\n\t<2EF2F5C0CC56984AA024D0B180335FCB42221BF6@IRSMSX102.ger.corp.intel.com>\n\t<58C6CB9F-4EEA-45FA-B6B4-D932599FC03C@vmware.com>\n\t<2EF2F5C0CC56984AA024D0B180335FCB5254FAB8@IRSMSX103.ger.corp.intel.com>\n\t<51599B01-8D6E-4441-A9FF-7067BDE8BD28@vmware.com>\n\t<20170921085434.GD2251@yliu-home>\n\t","In-Reply-To":"","Accept-Language":"da-DK, en-US","Content-Language":"en-US","X-MS-Has-Attach":"","X-MS-TNEF-Correlator":"","x-originating-ip":"[10.240.10.133]","MIME-Version":"1.0","X-Spam-Status":"No, score=-2.4 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,\n\tDKIM_VALID_AU,RCVD_IN_DNSWL_MED,RP_MATCHES_RCVD autolearn=disabled\n\tversion=3.3.1","X-Spam-Checker-Version":"SpamAssassin 3.3.1 (2010-03-16) on\n\tsmtp1.linux-foundation.org","Cc":"\"dev@openvswitch.org\" ","Subject":"Re: [ovs-dev] [PATCH v2 8/8] netdev-dpdk: set FDIR config","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.12","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Sender":"ovs-dev-bounces@openvswitch.org","Errors-To":"ovs-dev-bounces@openvswitch.org"}},{"id":1772587,"web_url":"http://patchwork.ozlabs.org/comment/1772587/","msgid":"<20170921090710.GA1514@yliu-home>","list_archive_url":null,"date":"2017-09-21T09:07:10","subject":"Re: [ovs-dev] [PATCH v2 8/8] netdev-dpdk: set FDIR config","submitter":{"id":72215,"url":"http://patchwork.ozlabs.org/api/people/72215/","name":"Yuanhan Liu","email":"yliu@fridaylinux.org"},"content":"On Thu, Sep 21, 2017 at 09:00:10AM +0000, Darrell Ball wrote:\n> \n> \n> On 9/21/17, 1:54 AM, \"Yuanhan Liu\" wrote:\n> \n> On Thu, Sep 21, 2017 at 08:04:45AM +0000, Darrell Ball wrote:\n> > Hi Yuanhan/Finn\n> > \n> > I think we may need to caveat the Fortville nics due to the global mask\n> > limitation;\n> \n> Sorry, I didn't follow you. Like how? Or what specifically I could/should\n> do?\n> \n> \n> I meant to say that we would not need this patch 8, since it can only allow exact match anyways.\n> This would not fit well with the other nics support and the overall design.\n> We would also add some comments to the documentation describing the non-support for Fortville\n> for the feature.\n\nI see. Thanks.\n\n\t--yliu\n> \n> > we also discussed this in the dpdk meeting yesterday.\n> > \n> > What do you think ?\n> > \n> > Thanks Darrell\n> > \n> > On 9/20/17, 6:47 AM, \"Chandran, Sugesh\" wrote:\n> > \n> > \n> > \n> > Regards\n> > _Sugesh\n> > \n> > \n> > > -----Original Message-----\n> > > From: Darrell Ball [mailto:dball@vmware.com]\n> > > Sent: Thursday, September 14, 2017 6:46 PM\n> > > To: Chandran, Sugesh ; Yuanhan Liu\n> > > \n> > > Cc: Finn Christensen ; dev@openvswitch.org\n> > > Subject: Re: [ovs-dev] [PATCH v2 8/8] netdev-dpdk: set FDIR config\n> > > \n> > > \n> > > \n> > > On 9/14/17, 10:36 AM, \"Chandran, Sugesh\" \n> > > wrote:\n> > > \n> > > \n> > > \n> > > Regards\n> > > _Sugesh\n> > > \n> > > > -----Original Message-----\n> > > > From: Yuanhan Liu [mailto:yliu@fridaylinux.org]\n> > > > Sent: Thursday, September 14, 2017 4:19 AM\n> > > > To: Darrell Ball \n> > > > Cc: Finn Christensen ; Chandran, Sugesh\n> > > > ; dev@openvswitch.org\n> > > > Subject: Re: [ovs-dev] [PATCH v2 8/8] netdev-dpdk: set FDIR config\n> > > >\n> > > > On Wed, Sep 13, 2017 at 01:57:22AM +0000, Darrell Ball wrote:\n> > > > >\n> > > > >\n> > > > > On 9/11/17, 1:14 AM, \"ovs-dev-bounces@openvswitch.org on behalf of\n> > > > Finn Christensen\" > > > fc@napatech.com> wrote:\n> > > > >\n> > > > > -----Original Message-----\n> > > > > From: ovs-dev-bounces@openvswitch.org [mailto:ovs-dev-\n> > > > bounces@openvswitch.org] On Behalf Of Yuanhan Liu\n> > > > > Sent: 11. september 2017 09:55\n> > > > > To: Chandran, Sugesh \n> > > > > Cc: dev@openvswitch.org\n> > > > > Subject: Re: [ovs-dev] [PATCH v2 8/8] netdev-dpdk: set FDIR config\n> > > > >\n> > > > > On Mon, Sep 11, 2017 at 07:42:57AM +0000, Chandran, Sugesh wrote:\n> > > > > >\n> > > > > >\n> > > > > > Regards\n> > > > > > _Sugesh\n> > > > > >\n> > > > > >\n> > > > > > > -----Original Message-----\n> > > > > > > From: ovs-dev-bounces@openvswitch.org [mailto:ovs-dev-\n> > > > > > > bounces@openvswitch.org] On Behalf Of Yuanhan Liu\n> > > > > > > Sent: Tuesday, September 5, 2017 10:23 AM\n> > > > > > > To: dev@openvswitch.org\n> > > > > > > Subject: [ovs-dev] [PATCH v2 8/8] netdev-dpdk: set FDIR config\n> > > > > > >\n> > > > > > > From: Finn Christensen \n> > > > > > >\n> > > > > > > The Intel i40e PMD driver requires the fdir mode set to\n> > > > > > > RTE_FDIR_MODE_PERFECT, otherwise, the flow creation would be\n> > > > failed.\n> > > > > > [Sugesh] this means it doesn't honor the flow masks which passed\n> > > onto\n> > > > rte_flow_*?\n> > > > >\n> > > > > IIRC, that's what I found after divig the code. It's an issue reported/fixed\n> > > > by Finn. I also don't have the nic for testing.\n> > > > >\n> > > > > [Finn] Yes, this was needed to make our test setup using an XL710 work,\n> > > > with the rte_flow implementation.\n> > > > > It's a while ago so I don't exactly remember how we ended up with this\n> > > > solution. However, we are definitely not\n> > > > > Intel XL710 experts, so there might be other ways to achieve the\n> > > > rte_flow functionality.\n> > > > > This issue, and problem raised about the overall change in configuration\n> > > > impact on NICs using this setting (Napatech\n> > > > > does not use it), I think should be reviewed/verified by NIC vendors\n> > > > using it.\n> > > > >\n> > > > >\n> > > > > [Darrell] We need to confirm the masking in the flow (but from what I see,\n> > > > it is ignored as Sugesh mentioned),\n> > > > > which would be a significant difference.\n> > > > > I guess we need input from Intel flow director folks to be sure and\n> > > > check if this can be done otherwise.\n> > > > > What about the 82599 as another example ?\n> > > >\n> > > >\n> > > > I will leave this to Intel folks.\n> > > [Sugesh] From the 82599 datasheet\n> > > \n> > > =======\n> > > The 82599 support two types of filtering modes (static setting by the\n> > > FDIRCTRL.PerfectMatch\n> > > bit):\n> > > * Perfect match filters - The hardware checks a match between the masked\n> > > fields of\n> > > the received packets and the programmed filters. Masked fields should be\n> > > programmed as zeros in the filter context. The 82599 support up to 8 K - 2\n> > > perfect\n> > > match filters.\n> > > * Signature filters - The hardware checks a match between a hash-based\n> > > signature of\n> > > the masked fields of the received packet. The 82599 supports up to 32 K - 2\n> > > signature filters.\n> > > * Notation - The Perfect Match fields and Signature field are denoted as Flow\n> > > ID fields.\n> > > The 82599 supports masking / range for the previously described fields. These\n> > > masks are\n> > > defined globally for all filters in the FDIR...M register.\n> > > =======\n> > > So my understanding is even if it can support masking, the mask is global and\n> > > not per flow.\n> > > \n> > > [Darrell] That was my interpretation as well; same across flow director usages.\n> > > \n> > > Again I will confirm this and provide more details.\n> > > \n> > > [Darrell] One question is – ‘is there some way to enable per flow masking’ with\n> > > this config ?\n> > [Sugesh] No for Intel NIC. It’s a silicon limitation on Fortville. The mask is a global config.\n> > > A second request is – ‘is there another option than\n> > > RTE_FDIR_MODE_PERFECT\n> > > or similar’ to use to achieve the result ?\n> > [Sugesh] For Fortville this is the only option that can use for per flow.\n> > \n> > > \n> > > \n> > > >\n> > > > \t--yliu\n> > > \n> > \n> > \n> > \n> \n>","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","ovs-dev@mail.linuxfoundation.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=fridaylinux-org.20150623.gappssmtp.com\n\theader.i=@fridaylinux-org.20150623.gappssmtp.com\n\theader.b=\"JUdXNKai\"; dkim-atps=neutral"],"Received":["from mail.linuxfoundation.org (mail.linuxfoundation.org\n\t[140.211.169.12])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xyW2y5Sttz9sBZ\n\tfor ;\n\tThu, 21 Sep 2017 19:07:22 +1000 (AEST)","from mail.linux-foundation.org (localhost [127.0.0.1])\n\tby mail.linuxfoundation.org (Postfix) with ESMTP id 0C9FFBC6;\n\tThu, 21 Sep 2017 09:07:21 +0000 (UTC)","from smtp1.linuxfoundation.org (smtp1.linux-foundation.org\n\t[172.17.192.35])\n\tby mail.linuxfoundation.org (Postfix) with ESMTPS id BA0A8B8C\n\tfor ; Thu, 21 Sep 2017 09:07:19 +0000 (UTC)","from mail-pf0-f179.google.com (mail-pf0-f179.google.com\n\t[209.85.192.179])\n\tby smtp1.linuxfoundation.org (Postfix) with ESMTPS id 0BA77271\n\tfor ; Thu, 21 Sep 2017 09:07:18 +0000 (UTC)","by mail-pf0-f179.google.com with SMTP id r68so2933675pfj.3\n\tfor ; Thu, 21 Sep 2017 02:07:18 -0700 (PDT)","from yliu-home ([45.63.61.64]) by smtp.gmail.com with ESMTPSA id\n\td186sm1757443pfd.117.2017.09.21.02.07.15\n\t(version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tThu, 21 Sep 2017 02:07:16 -0700 (PDT)"],"X-Greylist":"whitelisted by SQLgrey-1.7.6","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=fridaylinux-org.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to\n\t:user-agent; bh=yaolhInYDKsSF2FY5v3TUX01tjLHKdvyyMDov17UpmA=;\n\tb=JUdXNKaiyP5a1PA0NSBPqrEVz42/Lr6tLC7SCuUQMCGInfwi6kkeW+uR6KFuEFdWQ3\n\tybwqPlZvlNxrKs4lHIF+wlzSq++WO8Nq6c7x00fCrm04IeVc8tNeyxpwVFD20g8phP49\n\tpet3iqzyJgBWBynaTuIiT9sikPqmXzpfzWiW1/1xYJwjShoJ6ywFAnBxCMtMxciWsZm6\n\tablgkyVpnd3kvli3AWQPyzs/bN6t0m/NRZF6KQR0r6BJE2LLOTyvX+929LV6BK/fx4UJ\n\t3hKVGdVjKVvN4uwjatVLEXLar6Segb0lYTGys9S31lBXdZXi1sQ+bpqetR85wBr3znyj\n\tdvAQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to:user-agent;\n\tbh=yaolhInYDKsSF2FY5v3TUX01tjLHKdvyyMDov17UpmA=;\n\tb=Mlpd5HIFyJtz2cix9Sn5/KQEjdhZl1kwCcKIUUP82iF203YRPPL3VSQo1D9eb71ZBF\n\tr3fYCgbwn7dO17ZiFTt15/2Q2ebEdyMbSqM7nMDQgbUiS8mJiY1usZ+zvjcQi+oKo1UC\n\tt5PEXochnbKNvsbqr+kb2WeTwuXEKpZ2DtzBjAkzZygjuotoqT6y1p73XAwaL79tmxrK\n\tbv8LiYFO/Vr62e9myTvqv+HVwk7Td3tgiaB73O79FvEsfAYzMNdrucw2Ul1SIT4PYLio\n\ts+5hFV+CvCceNsLk02TYLX3JzkwN3IeF6M+33mb13eb0gYaYdkzMbdqs3DhXuX0GpMx6\n\tGQwA==","X-Gm-Message-State":"AHPjjUgG0EiQrgSSHTis5ZfuiD/SX9nmB5i4+wwi4KCf6sG+rZDT4Rj8\n\t3U+Ci7KO5/NwxJQWjfhufdzWopJthX4=","X-Google-Smtp-Source":"AOwi7QBYNnbe7FyKTGAYQqHAq2PW0BGwVoha5/GbXNdanVRz1aVZg4a3CbxAveU8ER+mnm7fVf34Sw==","X-Received":"by 10.98.27.8 with SMTP id b8mr4999632pfb.21.1505984838589;\n\tThu, 21 Sep 2017 02:07:18 -0700 (PDT)","Date":"Thu, 21 Sep 2017 17:07:10 +0800","From":"Yuanhan Liu ","To":"Darrell Ball ","Message-ID":"<20170921090710.GA1514@yliu-home>","References":"<20170911075441.GR9736@yliu-home>\n\t\n\t<31CFAB88-6AC5-48F7-8B8C-B1F506DC6FA8@vmware.com>\n\t<20170914031837.GF2050@yliu-home>\n\t<2EF2F5C0CC56984AA024D0B180335FCB42221BF6@IRSMSX102.ger.corp.intel.com>\n\t<58C6CB9F-4EEA-45FA-B6B4-D932599FC03C@vmware.com>\n\t<2EF2F5C0CC56984AA024D0B180335FCB5254FAB8@IRSMSX103.ger.corp.intel.com>\n\t<51599B01-8D6E-4441-A9FF-7067BDE8BD28@vmware.com>\n\t<20170921085434.GD2251@yliu-home>\n\t","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"","User-Agent":"Mutt/1.5.24 (2015-08-30)","X-Spam-Status":"No, score=0.5 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,\n\tRCVD_IN_DNSWL_NONE,\n\tRCVD_IN_SORBS_SPAM autolearn=disabled version=3.3.1","X-Spam-Checker-Version":"SpamAssassin 3.3.1 (2010-03-16) on\n\tsmtp1.linux-foundation.org","Cc":"\"dev@openvswitch.org\" ","Subject":"Re: [ovs-dev] [PATCH v2 8/8] netdev-dpdk: set FDIR config","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.12","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Sender":"ovs-dev-bounces@openvswitch.org","Errors-To":"ovs-dev-bounces@openvswitch.org"}}]