[{"id":1765049,"web_url":"http://patchwork.ozlabs.org/comment/1765049/","msgid":"<20170907.200023.2239628642365916828.davem@davemloft.net>","list_archive_url":null,"date":"2017-09-08T03:00:23","subject":"Re: [PATCH net] ip6_gre: update mtu properly in ip6gre_err","submitter":{"id":15,"url":"http://patchwork.ozlabs.org/api/people/15/","name":"David Miller","email":"davem@davemloft.net"},"content":"From: Xin Long \nDate: Tue, 5 Sep 2017 17:26:33 +0800\n\n> Now when probessing ICMPV6_PKT_TOOBIG, ip6gre_err only subtracts the\n> offset of gre header from mtu info. The expected mtu of gre device\n> should also subtract gre header. Otherwise, the next packets still\n> can't be sent out.\n> \n> Jianlin found this issue when using the topo:\n> client(ip6gre)<---->(nic1)route(nic2)<----->(ip6gre)server\n> \n> and reducing nic2's mtu, then both tcp and sctp's performance with\n> big size data became 0.\n> \n> This patch is to fix it by also subtracting grehdr (tun->tun_hlen)\n> from mtu info when updating gre device's mtu in ip6gre_err(). It\n> also needs to subtract ETH_HLEN if gre dev'type is ARPHRD_ETHER.\n> \n> Reported-by: Jianlin Shi \n> Signed-off-by: Xin Long \n\nApplied and queued up for -stable, thanks.","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xpMWd1bWnz9sMN\n\tfor ;\n\tFri, 8 Sep 2017 13:00:29 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1754051AbdIHDA1 (ORCPT );\n\tThu, 7 Sep 2017 23:00:27 -0400","from shards.monkeyblade.net ([184.105.139.130]:41586 \"EHLO\n\tshards.monkeyblade.net\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1753132AbdIHDA0 (ORCPT\n\t); Thu, 7 Sep 2017 23:00:26 -0400","from localhost (74-93-104-98-Washington.hfc.comcastbusiness.net\n\t[74.93.104.98]) (using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(Client did not present a certificate)\n\t(Authenticated sender: davem-davemloft)\n\tby shards.monkeyblade.net (Postfix) with ESMTPSA id A375712D8FCD3;\n\tThu, 7 Sep 2017 20:00:25 -0700 (PDT)"],"Date":"Thu, 07 Sep 2017 20:00:23 -0700 (PDT)","Message-Id":"<20170907.200023.2239628642365916828.davem@davemloft.net>","To":"lucien.xin@gmail.com","Cc":"netdev@vger.kernel.org","Subject":"Re: [PATCH net] ip6_gre: update mtu properly in ip6gre_err","From":"David Miller ","In-Reply-To":"","References":"","X-Mailer":"Mew version 6.7 on Emacs 25.2 / Mule 6.0 (HANACHIRUSATO)","Mime-Version":"1.0","Content-Type":"Text/Plain; charset=us-ascii","Content-Transfer-Encoding":"7bit","X-Greylist":"Sender succeeded SMTP AUTH, not delayed by\n\tmilter-greylist-4.5.12 (shards.monkeyblade.net\n\t[149.20.54.216]); Thu, 07 Sep 2017 20:00:25 -0700 (PDT)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}}]