[{"id":1765932,"web_url":"http://patchwork.ozlabs.org/comment/1765932/","msgid":"","list_archive_url":null,"date":"2017-09-10T10:28:17","subject":"Re: [PATCH] cifs: hide unused functions","submitter":{"id":703,"url":"http://patchwork.ozlabs.org/api/people/703/","name":"Geert Uytterhoeven","email":"geert@linux-m68k.org"},"content":"On Tue, Sep 5, 2017 at 11:24 AM, Arnd Bergmann wrote:\n> The newly added SMB2+ attribute support causes unused function\n> warnings when CONFIG_CIFS_XATTR is disabled:\n>\n> fs/cifs/smb2ops.c:563:1: error: 'smb2_set_ea' defined but not used [-Werror=unused-function]\n> smb2_set_ea(const unsigned int xid, struct cifs_tcon *tcon,\n> fs/cifs/smb2ops.c:513:1: error: 'smb2_query_eas' defined but not used [-Werror=unused-function]\n> smb2_query_eas(const unsigned int xid, struct cifs_tcon *tcon,\n>\n> This adds another #ifdef around the affected functions.\n>\n> Fixes: 5517554e4313 (\"cifs: Add support for writing attributes on SMB2+\")\n> Fixes: 95907fea4fd8 (\"cifs: Add support for reading attributes on SMB2+\")\n> Signed-off-by: Arnd Bergmann \n\nAcked-by: Geert Uytterhoeven \n\nGr{oetje,eeting}s,\n\n Geert\n\n--\nGeert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org\n\nIn personal conversations with technical people, I call myself a hacker. But\nwhen I'm talking to journalists I just say \"programmer\" or something like that.\n -- Linus Torvalds\n--\nTo unsubscribe from this list: send the line \"unsubscribe linux-cifs\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-cifs-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"o3DigVVc\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xqnMS68Mwz9sBZ\n\tfor ;\n\tSun, 10 Sep 2017 20:28:20 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751356AbdIJK2T (ORCPT );\n\tSun, 10 Sep 2017 06:28:19 -0400","from mail-pf0-f170.google.com ([209.85.192.170]:36737 \"EHLO\n\tmail-pf0-f170.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751346AbdIJK2S (ORCPT\n\t); Sun, 10 Sep 2017 06:28:18 -0400","by mail-pf0-f170.google.com with SMTP id e199so10234352pfh.3;\n\tSun, 10 Sep 2017 03:28:18 -0700 (PDT)","by 10.100.160.13 with HTTP; Sun, 10 Sep 2017 03:28:17 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc;\n\tbh=CMfR1cjdguVD1P2PjdHj/6D95WG8cBsRl2LwqbPzJpY=;\n\tb=o3DigVVcS6OYi0y3+qT4uxhMK/BptGAOSS3cAbHUrpAJ5d6zZAqgwmiXpRTkGQmShE\n\t78DV6G1yxBwIxPQSeY8tMfXZBAHA//ZguRvumcD2uATPsLtCJ5kaSyyhKFFyQ8b/462i\n\tUP0JK5zBfL/HBujjipmqNlEmi0v/A+QrmBuKUR4xPOkE+6ZBakQaBSNhsytTPj5fJM16\n\t9iLOwKNme6JR558+8ooXVIlbFqT8mS1ImpKrXmwdlaoXuIavkNKTcjIZCTRX5rGT+uPC\n\tkzCzqqPMVQY5LvLgvipD+GZnHeXiesS9XrOxxFpbs4bQtb7SUij2mHSECkPxYt3zKGpy\n\tCTWw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:sender:in-reply-to:references:from\n\t:date:message-id:subject:to:cc;\n\tbh=CMfR1cjdguVD1P2PjdHj/6D95WG8cBsRl2LwqbPzJpY=;\n\tb=HLciEVl8TXA3Bm9mVZ4oEbRf/pTALshPToS4n1h0IC0aCRFMPCWkYnMAGrZSdEkrjC\n\tHiG5mLrLixLb104tKJHQuiNpOxcWLcFgJlp29JlXDfOvriR0oInN3HxT+v3iae4m/ISg\n\tlMzYurvQBDKXyfoZQto63XOqzVojlb0Kbrch8iA81ixdPaJxXBlcRcbazjAfnAc+yKR7\n\tu7OHDJcERcBYnAcTl1JO5A9keUQCsr74BY++0NhzriTjl1w1zephOV0tXFQTZBOx+wNe\n\txTlOql3apFT/Gio7I9sCq+oY89syZxACpZcztIn9WZOvlezrHCUKYpkBA5cKIV5lTmZg\n\t1+AQ==","X-Gm-Message-State":"AHPjjUhiS6YdZKYTImcSMchksAzgmeyDJna3rXBPDT/V2wryDYyi38zo\n\tZnPH1OWfY8raO3RXh6h9u1ezkTmDIw==","X-Google-Smtp-Source":"ADKCNb7gHJ7SxYpMHe4n5+dysIV8RtGnbTeZFSUbvX7T8aXU8iVT4xukBuyQOdWMwTe18ycYTCNG2dcSVF4rJV6LAjI=","X-Received":"by 10.84.232.14 with SMTP id h14mr9726255plk.274.1505039298145; \n\tSun, 10 Sep 2017 03:28:18 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<20170905092440.2172429-1-arnd@arndb.de>","References":"<20170905092440.2172429-1-arnd@arndb.de>","From":"Geert Uytterhoeven ","Date":"Sun, 10 Sep 2017 12:28:17 +0200","X-Google-Sender-Auth":"F-wyQOuD8ndo7rNw2bhiW8JH82M","Message-ID":"","Subject":"Re: [PATCH] cifs: hide unused functions","To":"Arnd Bergmann ","Cc":"Steve French ,\n\tPavel Shilovsky ,\n\tSachin Prabhu , Aurelien Aptel ,\n\tRonnie Sahlberg ,\n\tlinux-cifs@vger.kernel.org, samba-technical@lists.samba.org,\n\t\"linux-kernel@vger.kernel.org\" ","Content-Type":"text/plain; charset=\"UTF-8\"","Sender":"linux-cifs-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-cifs@vger.kernel.org"}},{"id":1769806,"web_url":"http://patchwork.ozlabs.org/comment/1769806/","msgid":"","list_archive_url":null,"date":"2017-09-17T22:03:10","subject":"Re: [PATCH] cifs: hide unused functions","submitter":{"id":510,"url":"http://patchwork.ozlabs.org/api/people/510/","name":"Steve French","email":"smfrench@gmail.com"},"content":"merged into cifs-2.6.git for-next\n\nOn Sun, Sep 10, 2017 at 5:28 AM, Geert Uytterhoeven\n wrote:\n> On Tue, Sep 5, 2017 at 11:24 AM, Arnd Bergmann wrote:\n>> The newly added SMB2+ attribute support causes unused function\n>> warnings when CONFIG_CIFS_XATTR is disabled:\n>>\n>> fs/cifs/smb2ops.c:563:1: error: 'smb2_set_ea' defined but not used [-Werror=unused-function]\n>> smb2_set_ea(const unsigned int xid, struct cifs_tcon *tcon,\n>> fs/cifs/smb2ops.c:513:1: error: 'smb2_query_eas' defined but not used [-Werror=unused-function]\n>> smb2_query_eas(const unsigned int xid, struct cifs_tcon *tcon,\n>>\n>> This adds another #ifdef around the affected functions.\n>>\n>> Fixes: 5517554e4313 (\"cifs: Add support for writing attributes on SMB2+\")\n>> Fixes: 95907fea4fd8 (\"cifs: Add support for reading attributes on SMB2+\")\n>> Signed-off-by: Arnd Bergmann \n>\n> Acked-by: Geert Uytterhoeven \n>\n> Gr{oetje,eeting}s,\n>\n> Geert\n>\n> --\n> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org\n>\n> In personal conversations with technical people, I call myself a hacker. But\n> when I'm talking to journalists I just say \"programmer\" or something like that.\n> -- Linus Torvalds\n> --\n> To unsubscribe from this list: send the line \"unsubscribe linux-cifs\" in\n> the body of a message to majordomo@vger.kernel.org\n> More majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-cifs-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"p1ym9liF\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xwNSQ5PWrz9s4q\n\tfor ;\n\tMon, 18 Sep 2017 08:03:34 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751533AbdIQWDc (ORCPT );\n\tSun, 17 Sep 2017 18:03:32 -0400","from mail-pg0-f65.google.com ([74.125.83.65]:36570 \"EHLO\n\tmail-pg0-f65.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751352AbdIQWDb (ORCPT\n\t); Sun, 17 Sep 2017 18:03:31 -0400","by mail-pg0-f65.google.com with SMTP id d8so4255168pgt.3;\n\tSun, 17 Sep 2017 15:03:31 -0700 (PDT)","by 10.100.140.202 with HTTP; Sun, 17 Sep 2017 15:03:10 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=AmvU3c1c1WJZLyQXD/ZOWhfDLjvFC0fG5dKF7b+Q4DM=;\n\tb=p1ym9liFDGpw6CG74/P0+6zUGBhIcHT1Rvyl3eu/boDaF6a/R5xww464XBv3I5pfXY\n\tM/Mldg6ECaEDkigKlyYCsZ6SWta7zxoejH+a+MSWmGMJOZb8jbw3QJ0XT6oj6eOshlKi\n\tkiW5WQHrX9vaut8OWvtWMw8x8R7JKkNBN4wFV/iGilfDtLW2gJVAUcnCSKBy9QQboEL+\n\tRBW3b/YoieQAhPEOBIpYtnPxlztl0+DxpueEtEoiSt5LM8x9EsfTBVeMEDXVAwMxaGqM\n\tX2Bktw/GVoTjsX2p5F3T7xk90FcL1SiBppYjmrPWn9aXHYwYw5oFIzhocr7Wqrx3yhmy\n\tTVxA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=AmvU3c1c1WJZLyQXD/ZOWhfDLjvFC0fG5dKF7b+Q4DM=;\n\tb=n0MuZjUn/PlWV0nBCtDTUeeXfDDZl+LAgTdX8HDOTAWYtyKxUKhIzPCYGplsWPc8xE\n\tA3BnxzAg6TXts10oO/pxVd6lMPV0sRIkKtTEVlKny2qn4yvNQ2Kof3npOFRnJ1dS8gHV\n\tP918le0umgJRxeS/ehDp9QEQN8yNy4lx///NlcS5t2SDnczBNRoHeXXb7QsjVbtePW99\n\t14PusylEJAytWjq2gLPNWeCqhEiiHiNcP+C32B2Yipb9PQ4dovNh7CfOO2vZre+mmESv\n\t26HeOkHg3/Wku8ibHwzQa85kONp5Ye9Ot9UgySuMzDogR9/EaoOmvQ6EAbHUuPqTKmv9\n\tEAhw==","X-Gm-Message-State":"AHPjjUiDNtPwQ+pNHf7MsSPuuUsefmDrNAx8EqosDDtlLbboNRMeiZnw\n\tjJxxktN/PH3HfHJU2/OItN5BXWCL2MuKa6wzLPg=","X-Google-Smtp-Source":"ADKCNb7D8ajSJTNUEPfdRb5uFvuf7WuYlcIVUsMNGVZA3GQnXMrPYEWqEyVS71BXKWAnhuISQTQXCG4hlUkBzaMho/M=","X-Received":"by 10.99.111.9 with SMTP id k9mr21481518pgc.439.1505685811059;\n\tSun, 17 Sep 2017 15:03:31 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"","References":"<20170905092440.2172429-1-arnd@arndb.de>\n\t","From":"Steve French ","Date":"Sun, 17 Sep 2017 17:03:10 -0500","Message-ID":"","Subject":"Re: [PATCH] cifs: hide unused functions","To":"Geert Uytterhoeven ","Cc":"Arnd Bergmann , Steve French ,\n\tPavel Shilovsky ,\n\tSachin Prabhu , Aurelien Aptel ,\n\tRonnie Sahlberg ,\n\t\"linux-cifs@vger.kernel.org\" ,\n\tsamba-technical ,\n\t\"linux-kernel@vger.kernel.org\" ","Content-Type":"text/plain; charset=\"UTF-8\"","Sender":"linux-cifs-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-cifs@vger.kernel.org"}}]