[{"id":1763475,"web_url":"http://patchwork.ozlabs.org/comment/1763475/","msgid":"<20170905.091255.625612405262199546.davem@davemloft.net>","list_archive_url":null,"date":"2017-09-05T16:12:55","subject":"Re: [PATCH] soc: ti/knav_dma: include dmaengine header","submitter":{"id":15,"url":"http://patchwork.ozlabs.org/api/people/15/","name":"David Miller","email":"davem@davemloft.net"},"content":"From: Arnd Bergmann \nDate: Tue, 5 Sep 2017 10:31:35 +0200\n\n> A header file cleanup apparently caused a build regression\n> with one driver using the knav infrastructure:\n> \n> In file included from drivers/net/ethernet/ti/netcp_core.c:30:0:\n> include/linux/soc/ti/knav_dma.h:129:30: error: field 'direction' has incomplete type\n> enum dma_transfer_direction direction;\n> ^~~~~~~~~\n> drivers/net/ethernet/ti/netcp_core.c: In function 'netcp_txpipe_open':\n> drivers/net/ethernet/ti/netcp_core.c:1349:21: error: 'DMA_MEM_TO_DEV' undeclared (first use in this function); did you mean 'DMA_MEMORY_MAP'?\n> config.direction = DMA_MEM_TO_DEV;\n> ^~~~~~~~~~~~~~\n> DMA_MEMORY_MAP\n> drivers/net/ethernet/ti/netcp_core.c:1349:21: note: each undeclared identifier is reported only once for each function it appears in\n> drivers/net/ethernet/ti/netcp_core.c: In function 'netcp_setup_navigator_resources':\n> drivers/net/ethernet/ti/netcp_core.c:1659:22: error: 'DMA_DEV_TO_MEM' undeclared (first use in this function); did you mean 'DMA_DESC_HOST'?\n> config.direction = DMA_DEV_TO_MEM;\n> \n> As the header is no longer included implicitly through netdevice.h,\n> we should include it in the header that references the enum.\n> \n> Fixes: 0dd5759dbb1c (\"net: remove dmaengine.h inclusion from netdevice.h\")\n> Signed-off-by: Arnd Bergmann \n> ---\n> If the cleanup patch hasn't been submitted for mainline yet, please\n> add this fixup to the net-next tree, otherwise I'll merge it through\n> arm-soc.\n\nApplied to net-next.","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xmsFQ48zqz9s7f\n\tfor ;\n\tWed, 6 Sep 2017 02:12:58 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752119AbdIEQM5 (ORCPT );\n\tTue, 5 Sep 2017 12:12:57 -0400","from shards.monkeyblade.net ([184.105.139.130]:34368 \"EHLO\n\tshards.monkeyblade.net\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1750858AbdIEQM4 (ORCPT\n\t); Tue, 5 Sep 2017 12:12:56 -0400","from localhost (74-93-104-98-Washington.hfc.comcastbusiness.net\n\t[74.93.104.98]) (using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(Client did not present a certificate)\n\t(Authenticated sender: davem-davemloft)\n\tby shards.monkeyblade.net (Postfix) with ESMTPSA id 6C05613D75C4E;\n\tTue, 5 Sep 2017 09:12:55 -0700 (PDT)"],"Date":"Tue, 05 Sep 2017 09:12:55 -0700 (PDT)","Message-Id":"<20170905.091255.625612405262199546.davem@davemloft.net>","To":"arnd@arndb.de","Cc":"arm@kernel.org, dave.jiang@intel.com, netdev@vger.kernel.org,\n\tm-karicheri2@ti.com, linux-kernel@vger.kernel.org","Subject":"Re: [PATCH] soc: ti/knav_dma: include dmaengine header","From":"David Miller ","In-Reply-To":"<20170905083146.1289546-1-arnd@arndb.de>","References":"<20170905083146.1289546-1-arnd@arndb.de>","X-Mailer":"Mew version 6.7 on Emacs 25.2 / Mule 6.0 (HANACHIRUSATO)","Mime-Version":"1.0","Content-Type":"Text/Plain; charset=us-ascii","Content-Transfer-Encoding":"7bit","X-Greylist":"Sender succeeded SMTP AUTH, not delayed by\n\tmilter-greylist-4.5.12 (shards.monkeyblade.net\n\t[149.20.54.216]); Tue, 05 Sep 2017 09:12:55 -0700 (PDT)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}}]