[{"id":1763343,"web_url":"http://patchwork.ozlabs.org/comment/1763343/","msgid":"","list_archive_url":null,"date":"2017-09-05T13:05:11","subject":"Re: [PATCH v2 5/6] gpu: host1x: Fix incorrect comment for\n\tchannel_request","submitter":{"id":18124,"url":"http://patchwork.ozlabs.org/api/people/18124/","name":"Dmitry Osipenko","email":"digetx@gmail.com"},"content":"On 05.09.2017 11:10, Mikko Perttunen wrote:\n> This function actually doesn't sleep in the version that was merged.\n> \n> Signed-off-by: Mikko Perttunen \n> ---\n> drivers/gpu/host1x/channel.c | 3 +--\n> 1 file changed, 1 insertion(+), 2 deletions(-)\n> \n> diff --git a/drivers/gpu/host1x/channel.c b/drivers/gpu/host1x/channel.c\n> index db9b91d1384c..2fb93c27c1d9 100644\n> --- a/drivers/gpu/host1x/channel.c\n> +++ b/drivers/gpu/host1x/channel.c\n> @@ -128,8 +128,7 @@ static struct host1x_channel *acquire_unused_channel(struct host1x *host)\n> * host1x_channel_request() - Allocate a channel\n> * @device: Host1x unit this channel will be used to send commands to\n> *\n> - * Allocates a new host1x channel for @device. If there are no free channels,\n> - * this will sleep until one becomes available. May return NULL if CDMA\n> + * Allocates a new host1x channel for @device. May return NULL if CDMA\n> * initialization fails.\n> */\n> struct host1x_channel *host1x_channel_request(struct device *dev)\n> \n\nReviewed-by: Dmitry Osipenko ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-tegra-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"qq4gE6IJ\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xmn4s3Tj7z9t1t\n\tfor ;\n\tTue, 5 Sep 2017 23:05:17 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751316AbdIENFQ (ORCPT );\n\tTue, 5 Sep 2017 09:05:16 -0400","from mail-lf0-f65.google.com ([209.85.215.65]:32925 \"EHLO\n\tmail-lf0-f65.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1750955AbdIENFP (ORCPT\n\t); Tue, 5 Sep 2017 09:05:15 -0400","by mail-lf0-f65.google.com with SMTP id y15so1730605lfd.0;\n\tTue, 05 Sep 2017 06:05:14 -0700 (PDT)","from [192.168.1.145] (ppp109-252-91-9.pppoe.spdop.ru.\n\t[109.252.91.9]) by smtp.googlemail.com with ESMTPSA id\n\tb15sm107892lfl.36.2017.09.05.06.05.12\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tTue, 05 Sep 2017 06:05:12 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=subject:to:cc:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:content-transfer-encoding; \n\tbh=B4ex2HfBfXcfQZyOqDdtzNefrA+qVW9vwttk5pEwqHc=;\n\tb=qq4gE6IJlmthrtfDbw+9ia5LJ74sX1qgixU5FPjwX3BVH5mI3OtUTbZvifMmFaho6B\n\tTiE+udXEzpYu6PVrcMD/C1rq1T987km82Y3g8fZS1bQVeH0A8KbMhyV88FD54WNGQDHF\n\tmx/2RLfv3Jzn8goFLpset4YB61YqTyIYYOrrAh3+cZDEiIM7tzb9OEJVb+mMwHRhqido\n\ta6LiqvCOghitbASSOo3eUtseyMyZuM5vuUHpkyhEvHU2IKI9judpC4GkbARW/fSHLoTW\n\tJy1k+EUT62OufhivavcKgvEBRag1GdxIi/B7XppoVw2I4RCVlvq02NnxBGUE9mpH4j3i\n\tvBwQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:cc:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=B4ex2HfBfXcfQZyOqDdtzNefrA+qVW9vwttk5pEwqHc=;\n\tb=Iw5f5jcXtAwNzeUvQAftBMLxAwWobCUBPtFwsBqHLcNINLqunxdSgslKOIYl5Znm1z\n\tobza5hTnXGDX+MJuQtVwiRiqMMZF6vWw5a6xxfn0mRtKC6w4jp9d5z6PKitZ+zLtVAKP\n\tRtey69TESzOCyPjF86EYAKp0c2whuEhXsC3NyWVg6nVHEyUuGgm8OFm3R46IQUKMmwiT\n\trAj4crbgbD3JGQPxwcdrDPeQHxxuNmw7qz45gUyeyNQJ7qq0q5yaSDnqIkp9xRBpQVDQ\n\teLF3Rz2jGcnRppsg/f6np1py41I3p+gUrNB/0mxaqmDaqwT6orQbkvifHvZmi60O2coa\n\tsDcA==","X-Gm-Message-State":"AHPjjUjstQNVMqjqhxrHVv1KzgRdzsYBdGgJSBzXKBij0kH71QS3LnXb\n\t9P1+20GxR5epU0BTzmw=","X-Google-Smtp-Source":"ADKCNb5ghjzUtAuRyGMdvH/ItipgdxcpeYDjFnNTBDibCWmsSe5GWbZ8fB7AbMICzx6M43BZQa+isA==","X-Received":"by 10.25.90.10 with SMTP id o10mr1427476lfb.61.1504616713709;\n\tTue, 05 Sep 2017 06:05:13 -0700 (PDT)","Subject":"Re: [PATCH v2 5/6] gpu: host1x: Fix incorrect comment for\n\tchannel_request","To":"Mikko Perttunen , thierry.reding@gmail.com,\n\tjonathanh@nvidia.com","Cc":"dri-devel@lists.freedesktop.org, linux-tegra@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org","References":"<20170905081029.19769-1-mperttunen@nvidia.com>\n\t<20170905081029.19769-6-mperttunen@nvidia.com>","From":"Dmitry Osipenko ","Message-ID":"","Date":"Tue, 5 Sep 2017 16:05:11 +0300","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170905081029.19769-6-mperttunen@nvidia.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","Sender":"linux-tegra-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-tegra@vger.kernel.org"}}]