[{"id":1763476,"web_url":"http://patchwork.ozlabs.org/comment/1763476/","msgid":"<20170905.091243.2291345820364652641.davem@davemloft.net>","list_archive_url":null,"date":"2017-09-05T16:12:43","subject":"Re: [PATCH] net/ncsi: fix ncsi_vlan_rx_{add,kill}_vid references","submitter":{"id":15,"url":"http://patchwork.ozlabs.org/api/people/15/","name":"David Miller","email":"davem@davemloft.net"},"content":"From: Arnd Bergmann \nDate: Tue, 5 Sep 2017 10:05:47 +0200\n\n> We get a new link error in allmodconfig kernels after ftgmac100\n> started using the ncsi helpers:\n> \n> ERROR: \"ncsi_vlan_rx_kill_vid\" [drivers/net/ethernet/faraday/ftgmac100.ko] undefined!\n> ERROR: \"ncsi_vlan_rx_add_vid\" [drivers/net/ethernet/faraday/ftgmac100.ko] undefined!\n> \n> Related to that, we get another error when CONFIG_NET_NCSI is disabled:\n> \n> drivers/net/ethernet/faraday/ftgmac100.c:1626:25: error: 'ncsi_vlan_rx_add_vid' undeclared here (not in a function); did you mean 'ncsi_start_dev'?\n> drivers/net/ethernet/faraday/ftgmac100.c:1627:26: error: 'ncsi_vlan_rx_kill_vid' undeclared here (not in a function); did you mean 'ncsi_vlan_rx_add_vid'?\n> \n> This fixes both problems at once, using a 'static inline' stub helper\n> for the disabled case, and exporting the functions when they are present.\n> \n> Fixes: 51564585d8c6 (\"ftgmac100: Support NCSI VLAN filtering when available\")\n> Fixes: 21acf63013ed (\"net/ncsi: Configure VLAN tag filter\")\n> Signed-off-by: Arnd Bergmann \n\nApplied.","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xmsFl1k7nz9s7f\n\tfor ;\n\tWed, 6 Sep 2017 02:13:15 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752091AbdIEQMr (ORCPT );\n\tTue, 5 Sep 2017 12:12:47 -0400","from shards.monkeyblade.net ([184.105.139.130]:34352 \"EHLO\n\tshards.monkeyblade.net\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1750858AbdIEQMo (ORCPT\n\t); Tue, 5 Sep 2017 12:12:44 -0400","from localhost (74-93-104-98-Washington.hfc.comcastbusiness.net\n\t[74.93.104.98]) (using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(Client did not present a certificate)\n\t(Authenticated sender: davem-davemloft)\n\tby shards.monkeyblade.net (Postfix) with ESMTPSA id 1A11713D75C46;\n\tTue, 5 Sep 2017 09:12:44 -0700 (PDT)"],"Date":"Tue, 05 Sep 2017 09:12:43 -0700 (PDT)","Message-Id":"<20170905.091243.2291345820364652641.davem@davemloft.net>","To":"arnd@arndb.de","Cc":"gwshan@linux.vnet.ibm.com, sam@mendozajonas.com, joel@jms.id.au,\n\tnetdev@vger.kernel.org, linux-kernel@vger.kernel.org","Subject":"Re: [PATCH] net/ncsi: fix ncsi_vlan_rx_{add,kill}_vid references","From":"David Miller ","In-Reply-To":"<20170905080615.1131665-1-arnd@arndb.de>","References":"<20170905080615.1131665-1-arnd@arndb.de>","X-Mailer":"Mew version 6.7 on Emacs 25.2 / Mule 6.0 (HANACHIRUSATO)","Mime-Version":"1.0","Content-Type":"Text/Plain; charset=us-ascii","Content-Transfer-Encoding":"7bit","X-Greylist":"Sender succeeded SMTP AUTH, not delayed by\n\tmilter-greylist-4.5.12 (shards.monkeyblade.net\n\t[149.20.54.216]); Tue, 05 Sep 2017 09:12:44 -0700 (PDT)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}}]