[{"id":1778017,"web_url":"http://patchwork.ozlabs.org/comment/1778017/","msgid":"","list_archive_url":null,"date":"2017-10-01T14:44:35","subject":"Re: [RFC v3 2/7] platform/x86: intel_pmc_ipc: Use MFD framework to\n\tcreate dependent devices","submitter":{"id":4675,"url":"http://patchwork.ozlabs.org/api/people/4675/","name":"Andy Shevchenko","email":"andy.shevchenko@gmail.com"},"content":"On Tue, Sep 5, 2017 at 8:37 AM,\n wrote:\n> From: Kuppuswamy Sathyanarayanan \n>\n> Currently, we have lot of repetitive code in dependent device resource\n> allocation and device creation handling code. This logic can be improved if\n> we use MFD framework for dependent device creation. This patch adds this\n> support.\n>\n\n> + punit_cell.id = -1;\n\n> + return devm_mfd_add_devices(&pdev->dev, PLATFORM_DEVID_AUTO,\n> + &punit_cell, 1, NULL, 0, NULL);\n\nIIRC you don't need to file cell ID in case of DEVID_AUTO.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-rtc-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"nL+8W8t/\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3y4p3W4gRcz9t3f\n\tfor ;\n\tMon, 2 Oct 2017 01:44:39 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751063AbdJAOoi (ORCPT );\n\tSun, 1 Oct 2017 10:44:38 -0400","from mail-qk0-f176.google.com ([209.85.220.176]:52966 \"EHLO\n\tmail-qk0-f176.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751028AbdJAOoh (ORCPT\n\t); Sun, 1 Oct 2017 10:44:37 -0400","by mail-qk0-f176.google.com with SMTP id b15so1101837qkg.9;\n\tSun, 01 Oct 2017 07:44:36 -0700 (PDT)","by 10.12.190.196 with HTTP; Sun, 1 Oct 2017 07:44:35 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=r4iGrxN/k2ulMvXLF7zehYNjfG4JcdnQ+oZ8rPbVm0I=;\n\tb=nL+8W8t/Faj7gFS6YTgoVIxUSVuDwcm+LuHF+z/6MnthVy5lW6Wuf3Ne/F+GfyaOvo\n\t3x5V8aSw2snV5KaGazPe7whYgwCFTnrV/QOOjKmgH3nQyQEDmRbrGZkZimk9i9CTLTle\n\tlNa81ceYjmOjU35t/M1IOUGC34GV4AeD7pxHhnhH3kXlVX0OMta6HhoDDzmDUtQ+DoQV\n\tNWOCSib+vR/mTs3e6WwUUnZxDfJVYNEibXHVM3cXje1Sl1+Iovokide7u0DF/zVL4c/2\n\tAmOxNl6h1ophID9X0JMFOeNP1XkVPuNIevo8OhX4tAlvHagciUR0Gv9JdG8ghHfdAFJ7\n\tPw/w==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=r4iGrxN/k2ulMvXLF7zehYNjfG4JcdnQ+oZ8rPbVm0I=;\n\tb=lbOTd18xzClBe18iIRGRVWm/V8YURCFaw2voTsl5JartiQnkaQZWztBTrWYvanhrkF\n\tLHzihx7/hWFRbjxz7MnzW0pjxoU8bNCLFD4noK5O9JO5wE3mZgJGaDczcweGyASb1MFe\n\tFLs1gR6lnB6yyr1/eY56UG+wdJ7d//t2SEWY1bgItblF+ux3GZH1/hmdUdW0wHK/vkOT\n\tqdC93ZVxU3UQD87EvgmsFAE/KQFEbzxtPhLDBqvn9P07va7mpi7VLRdqFfhO4dqHT9yY\n\t4eqUijImb/D39ml7SfC/9wI+WnBvGbK2zM86oEYRlNuTteiJgvZ6Zj2L6sOO24Zh7uBY\n\tKYcg==","X-Gm-Message-State":"AMCzsaW4f2L33MjFh19mQQoIwEOk+mIJpYpGp6YRnM3v4/ld7w7sCIHz\n\tefS89goxR4ZH1xnPGO6N72eZpMLLTfaN5EvCS5g=","X-Google-Smtp-Source":"AOwi7QB1hmfLvSp/PeU84UhNftBhw/wbkHH2gekoRGHC5JuAeQxDivdIXiAnlqd9oDbUlOj4j4OSpt21RhI7igYgEBs=","X-Received":"by 10.55.160.21 with SMTP id j21mr2505765qke.242.1506869076369; \n\tSun, 01 Oct 2017 07:44:36 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<3e7a05561840a7dd4fa945e4969edb834d9870b6.1504588701.git.sathyanarayanan.kuppuswamy@linux.intel.com>","References":"\n\t<3e7a05561840a7dd4fa945e4969edb834d9870b6.1504588701.git.sathyanarayanan.kuppuswamy@linux.intel.com>","From":"Andy Shevchenko ","Date":"Sun, 1 Oct 2017 17:44:35 +0300","Message-ID":"","Subject":"Re: [RFC v3 2/7] platform/x86: intel_pmc_ipc: Use MFD framework to\n\tcreate dependent devices","To":"Kuppuswamy Sathyanarayanan ","Cc":"Alessandro Zummo ,\n\t\"x86@kernel.org\" , Wim Van Sebroeck ,\n\tIngo Molnar ,\n\tAlexandre Belloni ,\n\tZha Qipeng , \"H. Peter Anvin\" ,\n\t\"dvhart@infradead.org\" ,\n\tThomas Gleixner , Lee Jones ,\n\tAndy Shevchenko ,\n\tSouvik Kumar Chakravarty ,\n\tlinux-rtc@vger.kernel.org, linux-watchdog@vger.kernel.org,\n\t\"linux-kernel@vger.kernel.org\" ,\n\tPlatform Driver ,\n\tSathyanarayanan Kuppuswamy Natarajan ","Content-Type":"text/plain; charset=\"UTF-8\"","Sender":"linux-rtc-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-rtc@vger.kernel.org"}},{"id":1779337,"web_url":"http://patchwork.ozlabs.org/comment/1779337/","msgid":"<6b854d35-6430-c790-3608-15cefac03a52@linux.intel.com>","list_archive_url":null,"date":"2017-10-04T01:00:15","subject":"Re: [RFC v3 2/7] platform/x86: intel_pmc_ipc: Use MFD framework to\n\tcreate dependent devices","submitter":{"id":66129,"url":"http://patchwork.ozlabs.org/api/people/66129/","name":"Kuppuswamy Sathyanarayanan","email":"sathyanarayanan.kuppuswamy@linux.intel.com"},"content":"Hi Andy,\n\n\nOn 10/01/2017 07:44 AM, Andy Shevchenko wrote:\n> On Tue, Sep 5, 2017 at 8:37 AM,\n> wrote:\n>> From: Kuppuswamy Sathyanarayanan \n>>\n>> Currently, we have lot of repetitive code in dependent device resource\n>> allocation and device creation handling code. This logic can be improved if\n>> we use MFD framework for dependent device creation. This patch adds this\n>> support.\n>>\n>> + punit_cell.id = -1;\nI will remove this line in next version.\n>> + return devm_mfd_add_devices(&pdev->dev, PLATFORM_DEVID_AUTO,\n>> + &punit_cell, 1, NULL, 0, NULL);\n> IIRC you don't need to file cell ID in case of DEVID_AUTO.\nI am planning to use DEVID_NONE here to match the current behavior. \nUnless you have some concerns?\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-rtc-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3y6HdB41flz9t2V\n\tfor ;\n\tWed, 4 Oct 2017 12:00:30 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751336AbdJDBA3 (ORCPT );\n\tTue, 3 Oct 2017 21:00:29 -0400","from mga02.intel.com ([134.134.136.20]:32941 \"EHLO mga02.intel.com\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1751315AbdJDBA2 (ORCPT );\n\tTue, 3 Oct 2017 21:00:28 -0400","from orsmga005.jf.intel.com ([10.7.209.41])\n\tby orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t03 Oct 2017 18:00:27 -0700","from linux.intel.com ([10.54.29.200])\n\tby orsmga005.jf.intel.com with ESMTP; 03 Oct 2017 18:00:27 -0700","from [10.7.198.92] (skuppusw-desk.jf.intel.com [10.7.198.92])\n\tby linux.intel.com (Postfix) with ESMTP id 630095802D8;\n\tTue, 3 Oct 2017 18:00:27 -0700 (PDT)"],"X-ExtLoop1":"1","X-IronPort-AV":"E=Sophos;i=\"5.42,475,1500966000\"; d=\"scan'208\";a=\"156371418\"","Reply-To":"sathyanarayanan.kuppuswamy@linux.intel.com","Subject":"Re: [RFC v3 2/7] platform/x86: intel_pmc_ipc: Use MFD framework to\n\tcreate dependent devices","To":"Andy Shevchenko ","Cc":"Alessandro Zummo ,\n\t\"x86@kernel.org\" , Wim Van Sebroeck ,\n\tIngo Molnar ,\n\tAlexandre Belloni ,\n\tZha Qipeng , \"H. Peter Anvin\" ,\n\t\"dvhart@infradead.org\" ,\n\tThomas Gleixner , Lee Jones ,\n\tAndy Shevchenko ,\n\tSouvik Kumar Chakravarty ,\n\tlinux-rtc@vger.kernel.org, linux-watchdog@vger.kernel.org,\n\t\"linux-kernel@vger.kernel.org\" ,\n\tPlatform Driver ,\n\tSathyanarayanan Kuppuswamy Natarajan ","References":"\n\t<3e7a05561840a7dd4fa945e4969edb834d9870b6.1504588701.git.sathyanarayanan.kuppuswamy@linux.intel.com>\n\t","From":"sathyanarayanan kuppuswamy \n\t","Organization":"Intel","Message-ID":"<6b854d35-6430-c790-3608-15cefac03a52@linux.intel.com>","Date":"Tue, 3 Oct 2017 18:00:15 -0700","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Transfer-Encoding":"7bit","Content-Language":"en-US","Sender":"linux-rtc-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-rtc@vger.kernel.org"}},{"id":1779760,"web_url":"http://patchwork.ozlabs.org/comment/1779760/","msgid":"","list_archive_url":null,"date":"2017-10-04T12:34:29","subject":"Re: [RFC v3 2/7] platform/x86: intel_pmc_ipc: Use MFD framework to\n\tcreate dependent devices","submitter":{"id":4675,"url":"http://patchwork.ozlabs.org/api/people/4675/","name":"Andy Shevchenko","email":"andy.shevchenko@gmail.com"},"content":"On Wed, Oct 4, 2017 at 4:00 AM, sathyanarayanan kuppuswamy\n wrote:\n> On 10/01/2017 07:44 AM, Andy Shevchenko wrote:\n>> On Tue, Sep 5, 2017 at 8:37 AM,\n\n>>> + punit_cell.id = -1;\n>\n> I will remove this line in next version.\n>>>\n>>> + return devm_mfd_add_devices(&pdev->dev, PLATFORM_DEVID_AUTO,\n>>> + &punit_cell, 1, NULL, 0, NULL);\n>>\n>> IIRC you don't need to file cell ID in case of DEVID_AUTO.\n>\n> I am planning to use DEVID_NONE here to match the current behavior. Unless\n> you have some concerns?\n\nPreventing behaviour is a good thing to do.\nIn either way cell.id can be leaved 0.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-rtc-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"qtxm1qjE\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3y6b2F5MDSz9t16\n\tfor ;\n\tWed, 4 Oct 2017 23:34:45 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751996AbdJDMec (ORCPT );\n\tWed, 4 Oct 2017 08:34:32 -0400","from mail-qt0-f195.google.com ([209.85.216.195]:49322 \"EHLO\n\tmail-qt0-f195.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751699AbdJDMea (ORCPT\n\t); Wed, 4 Oct 2017 08:34:30 -0400","by mail-qt0-f195.google.com with SMTP id o3so18797787qte.6;\n\tWed, 04 Oct 2017 05:34:30 -0700 (PDT)","by 10.12.190.196 with HTTP; Wed, 4 Oct 2017 05:34:29 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=9MInKgd/ubotUfcs6erf5+OvWuHiySNKwy7Ofpo3Kvo=;\n\tb=qtxm1qjEc2xDv1j5BFv4tq+BULgGKc8VI1adxbgi+xwQqMj1Mav/dMSDnsd/wjrD16\n\tyrZny5BxanUUIKH2jvAc9N9e2hQQl0alwt8kyd8JJxC/IOgb3QowXaoJ1acPjuX2iOzh\n\txu4cY4l6IY+gHK5+9J5AgsLTbm2LnHjgWyQie1BOF2eoxyO7BbHuZjSAqjvFZBOTMIoP\n\tCv4YhhymP9/PUrQLe7h5JStauIvfFYw06loTrXcP8DOXqrSnDOoQmCu1GTRE73ZEasUP\n\t27ybU0FQGuAbjYed2CqGgG0+FUbRLN/2fSgZbEeQmXgfKFgvktka0ZeH7Fcw3i9VO4VE\n\t6P6A==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=9MInKgd/ubotUfcs6erf5+OvWuHiySNKwy7Ofpo3Kvo=;\n\tb=TW0HW1otDy+fCGwfqh+XJUuJwp1P29DOCIN5zMcM+EEj3ArslwUSRCtKTu3Eric1XG\n\tGQnDwutUJVwSWQCq292eSo/PNmP43kNWNxHOAzacaHDYoks9XBM0Sf5eTwLtWG4XU/AI\n\td5DbwB9zbGjHpHqP2yqeoTqALSPJ1kQ4v/NEo1e7MiVxc62rc/jTvf43baMsAMlbq5TV\n\tzhCpMRHGLkF7LHvhtmUxRl4sQJe+M+lzM8TDw6wSOUKI8i8erB5+b6kgGpg2F1hGTkk2\n\tq9KCH3WTHi9FMIErXfWkhiCHuGu+CnWaVLPr2ClP1tZD58HqRwpuRAnLdhPrHEtL9lVb\n\t/RtQ==","X-Gm-Message-State":"AMCzsaXMZzHgqq5jowDY8CR7QE6aRj+dPR2kr1axVmrahHUqD5H804Zx\n\tFdxFRikvfQtE6vQ5MVHu7rLiUmADB3U04BW7gnw=","X-Google-Smtp-Source":"AOwi7QAk8Eub4hYlKGWQz+SjJIgtI5HGbEFyWhbekXsT4idB1TWUtsqIv9OND3F2vKzfMRrOXOabcu8fGVNxybubxYk=","X-Received":"by 10.237.59.91 with SMTP id q27mr28865605qte.340.1507120469770; \n\tWed, 04 Oct 2017 05:34:29 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<6b854d35-6430-c790-3608-15cefac03a52@linux.intel.com>","References":"\n\t<3e7a05561840a7dd4fa945e4969edb834d9870b6.1504588701.git.sathyanarayanan.kuppuswamy@linux.intel.com>\n\t\n\t<6b854d35-6430-c790-3608-15cefac03a52@linux.intel.com>","From":"Andy Shevchenko ","Date":"Wed, 4 Oct 2017 15:34:29 +0300","Message-ID":"","Subject":"Re: [RFC v3 2/7] platform/x86: intel_pmc_ipc: Use MFD framework to\n\tcreate dependent devices","To":"Kuppuswamy Sathyanarayanan ","Cc":"Alessandro Zummo ,\n\t\"x86@kernel.org\" , Wim Van Sebroeck ,\n\tIngo Molnar ,\n\tAlexandre Belloni ,\n\tZha Qipeng , \"H. Peter Anvin\" ,\n\t\"dvhart@infradead.org\" ,\n\tThomas Gleixner , Lee Jones ,\n\tAndy Shevchenko ,\n\tSouvik Kumar Chakravarty ,\n\tlinux-rtc@vger.kernel.org, linux-watchdog@vger.kernel.org,\n\t\"linux-kernel@vger.kernel.org\" ,\n\tPlatform Driver ,\n\tSathyanarayanan Kuppuswamy Natarajan ","Content-Type":"text/plain; charset=\"UTF-8\"","Sender":"linux-rtc-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-rtc@vger.kernel.org"}}]