[{"id":1765405,"web_url":"http://patchwork.ozlabs.org/comment/1765405/","msgid":"<87wp59gtwu.fsf@linaro.org>","list_archive_url":null,"date":"2017-09-08T14:13:37","subject":"Re: [Qemu-devel] [PATCH v6 02/12] qemu.py: Add \"wait()\" method","submitter":{"id":39532,"url":"http://patchwork.ozlabs.org/api/people/39532/","name":"Alex Bennée","email":"alex.bennee@linaro.org"},"content":"Fam Zheng writes:\n\n> Signed-off-by: Fam Zheng \n> Reviewed-by: Stefan Hajnoczi \n\nReviewed-by: Alex Bennée \n\n> ---\n> scripts/qemu.py | 7 +++++++\n> 1 file changed, 7 insertions(+)\n>\n> diff --git a/scripts/qemu.py b/scripts/qemu.py\n> index 880e3e8219..153f2d1564 100644\n> --- a/scripts/qemu.py\n> +++ b/scripts/qemu.py\n> @@ -143,6 +143,13 @@ class QEMUMachine(object):\n> self._post_shutdown()\n> raise\n>\n> + def wait(self):\n> + '''Wait for the VM to power off'''\n> + self._popen.wait()\n> + self._qmp.close()\n> + self._load_io_log()\n> + self._post_shutdown()\n> +\n> def shutdown(self):\n> '''Terminate the VM and clean up'''\n> if self.is_running():\n\n\n--\nAlex Bennée","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"YV01tMOr\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xpfT427wxz9s7G\n\tfor ;\n\tSat, 9 Sep 2017 00:14:16 +1000 (AEST)","from localhost ([::1]:45647 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dqK2w-0003fK-3V\n\tfor incoming@patchwork.ozlabs.org; Fri, 08 Sep 2017 10:14:14 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:47500)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dqK2R-0003dq-RK\n\tfor qemu-devel@nongnu.org; Fri, 08 Sep 2017 10:13:44 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dqK2N-0006zL-SI\n\tfor qemu-devel@nongnu.org; Fri, 08 Sep 2017 10:13:43 -0400","from mail-wm0-x235.google.com ([2a00:1450:400c:c09::235]:43353)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from )\n\tid 1dqK2N-0006y5-Li\n\tfor qemu-devel@nongnu.org; Fri, 08 Sep 2017 10:13:39 -0400","by mail-wm0-x235.google.com with SMTP id f145so6387281wme.0\n\tfor ; Fri, 08 Sep 2017 07:13:39 -0700 (PDT)","from zen.linaro.local ([81.128.185.34])\n\tby smtp.gmail.com with ESMTPSA id\n\tw204sm1235492wmw.32.2017.09.08.07.13.37\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tFri, 08 Sep 2017 07:13:37 -0700 (PDT)","from zen (localhost [127.0.0.1])\n\tby zen.linaro.local (Postfix) with ESMTPS id 170363E00A6;\n\tFri, 8 Sep 2017 15:13:37 +0100 (BST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;\n\th=references:user-agent:from:to:cc:subject:in-reply-to:date\n\t:message-id:mime-version:content-transfer-encoding;\n\tbh=B4ZSQ3evyeicSID1dlGoXwjOiNhtY3XpKG1rEhq4JyQ=;\n\tb=YV01tMOrGvoiSwAZUrcgTvV1Znwr6IrMiO/VsXCJL/TOtHZNRjg0qBBOCQS3EPdRYN\n\tN4AIHoVTdWiDGALYxQ/ki1U0H45yp/Hp7rgMEizujfDUoEXMgsfHUPqnmP19pyeGNmC/\n\taGPcVLJzGJZfRMMgcKVMBLRrn521hU8u/4JDE=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:references:user-agent:from:to:cc:subject\n\t:in-reply-to:date:message-id:mime-version:content-transfer-encoding; \n\tbh=B4ZSQ3evyeicSID1dlGoXwjOiNhtY3XpKG1rEhq4JyQ=;\n\tb=tVUZTvlarygBhqwOvVcpJvW6Qn4Ue5+Z0QeSDJX1iSmWTO6JV3r2svhmiXMFnvrMzq\n\td9dzBo3Z+61h5EcIBHZhELIwOuRoGEBoaKHTNUkZd3MhChv1R90DIjsW8Fi/yfSxZzjw\n\twFWF2aGI4pcCXYhZqFUJXuIxk8SVRZinhYU5vLSfT8hLimTUrjo86/ul5IHpERwEhFcY\n\tYC8sM1250kgzfE3QTSl54t2eptzh9xGz8P9WCPVta59IuUsbej4K+XhfA0EDQqoes0jy\n\ty1r9eGogRv0lsEot8TpzhBFpSkwTnzyHdqF+0aEAjtj69dMhhgA9mV5bH4vF8KHjS8Co\n\toHAQ==","X-Gm-Message-State":"AHPjjUi4g1hBkrBv4hWyALIDdzaGdq/EqmFFXlTZjcxHrepJCWS0EqHH\n\tYnQRzXoE+HZF9o0Ehjs8+mSD8Q==","X-Google-Smtp-Source":"AOwi7QBArw3p8PViMwiq7R6HRB3nfLdBimAehfMp3CAZZWIwo60rhZMwgQOXNEcw7slkmkoNcr14YQ==","X-Received":"by 10.28.87.1 with SMTP id l1mr1647147wmb.99.1504880018528;\n\tFri, 08 Sep 2017 07:13:38 -0700 (PDT)","References":"<20170905021201.25684-1-famz@redhat.com>\n\t<20170905021201.25684-3-famz@redhat.com>","User-agent":"mu4e 0.9.19; emacs 25.2.50.3","From":"Alex =?utf-8?q?Benn=C3=A9e?= ","To":"Fam Zheng ","In-reply-to":"<20170905021201.25684-3-famz@redhat.com>","Date":"Fri, 08 Sep 2017 15:13:37 +0100","Message-ID":"<87wp59gtwu.fsf@linaro.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"8bit","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2a00:1450:400c:c09::235","Subject":"Re: [Qemu-devel] [PATCH v6 02/12] qemu.py: Add \"wait()\" method","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Peter Maydell , qemu-devel@nongnu.org, Philippe\n\t=?utf-8?q?Mathieu-Daud=C3=A9?= ,\n\tKamil Rytarowski , stefanha@redhat.com, \n\tCleber Rosa , pbonzini@redhat.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]