[{"id":1765404,"web_url":"http://patchwork.ozlabs.org/comment/1765404/","msgid":"<87y3ppgty2.fsf@linaro.org>","list_archive_url":null,"date":"2017-09-08T14:12:53","subject":"Re: [Qemu-devel] [PATCH v6 01/12] gitignore: Ignore vm test images","submitter":{"id":39532,"url":"http://patchwork.ozlabs.org/api/people/39532/","name":"Alex Bennée","email":"alex.bennee@linaro.org"},"content":"Fam Zheng writes:\n\n> Signed-off-by: Fam Zheng \n> ---\n> .gitignore | 1 +\n> tests/.gitignore | 1 +\n> 2 files changed, 2 insertions(+)\n>\n> diff --git a/.gitignore b/.gitignore\n> index cf65316863..40acfcb9e2 100644\n> --- a/.gitignore\n> +++ b/.gitignore\n> @@ -52,6 +52,7 @@\n> /vscclient\n> /vhost-user-scsi\n> /fsdev/virtfs-proxy-helper\n> +*.tmp\n\nI'm not sure we should be dumping anything in the rootdir, .gitignored\nor not.\n\n> *.[1-9]\n> *.a\n> *.aux\n> diff --git a/tests/.gitignore b/tests/.gitignore\n> index fed0189a5a..cf6d99c91e 100644\n> --- a/tests/.gitignore\n> +++ b/tests/.gitignore\n> @@ -95,3 +95,4 @@ test-filter-mirror\n> test-filter-redirector\n> *-test\n> qapi-schema/*.test.*\n> +vm/*.img\n\n\n--\nAlex Bennée","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"T0KkAXDJ\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xpfS25XVvz9sBd\n\tfor ;\n\tSat, 9 Sep 2017 00:13:22 +1000 (AEST)","from localhost ([::1]:45645 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dqK24-0003Gj-TT\n\tfor incoming@patchwork.ozlabs.org; Fri, 08 Sep 2017 10:13:20 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:47229)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dqK1l-0003GM-3O\n\tfor qemu-devel@nongnu.org; Fri, 08 Sep 2017 10:13:01 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dqK1h-0005y6-3u\n\tfor qemu-devel@nongnu.org; Fri, 08 Sep 2017 10:13:01 -0400","from mail-wm0-x229.google.com ([2a00:1450:400c:c09::229]:43340)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from )\n\tid 1dqK1g-0005w0-Si\n\tfor qemu-devel@nongnu.org; Fri, 08 Sep 2017 10:12:57 -0400","by mail-wm0-x229.google.com with SMTP id f145so6382762wme.0\n\tfor ; Fri, 08 Sep 2017 07:12:56 -0700 (PDT)","from zen.linaro.local ([81.128.185.34])\n\tby smtp.gmail.com with ESMTPSA id\n\tv78sm1907734wmv.48.2017.09.08.07.12.54\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tFri, 08 Sep 2017 07:12:54 -0700 (PDT)","from zen (localhost [127.0.0.1])\n\tby zen.linaro.local (Postfix) with ESMTPS id 02C643E00A6;\n\tFri, 8 Sep 2017 15:12:54 +0100 (BST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;\n\th=references:user-agent:from:to:cc:subject:in-reply-to:date\n\t:message-id:mime-version:content-transfer-encoding;\n\tbh=CKi4JuS3MCr15tb6gh8wdufMwKVQB58UEoycw5Q+Ars=;\n\tb=T0KkAXDJXKtThgn0V4nGy+ZPgRMQvKW9Ozq9odI1JqwL7/nplqnYWp4+27K6rNBPwt\n\ttHqasSqs0Q/AkXDWbMYiIm32oD9US7rJZUiJvwPI6o9D6y5kefnLrk4bz5v6uGexLU5q\n\tXd7i7IfI7tV+1kmknB99QdMSbWMyzAhVZHjO0=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:references:user-agent:from:to:cc:subject\n\t:in-reply-to:date:message-id:mime-version:content-transfer-encoding; \n\tbh=CKi4JuS3MCr15tb6gh8wdufMwKVQB58UEoycw5Q+Ars=;\n\tb=ZKmVUiJYb6bylTYB0AjC5x8jS70vfJi14WylM359JWyusR15RPB2ElUq73AlWkchYK\n\tUUpXJsZ7DhUMANJey/Q4cJxaKEdFgVqrIXLvwL1q3ShMLKZ+2LnlRr7rHtkLwI3wdmeb\n\tJPQaGPmF+HDo3MtGOF2LPJAv2DpG2BSw0nrtP8BJ8krtkqwxhRkTJbICKxWLwF1lv//C\n\t9jXwi4/jXXeBZBJ7t6l2LLc/kF/8wGT8z/RB4FSqgWZETVWQadOp0NkiLcijaeI00AUP\n\tYD9zm9Vz1wMxSTnFZ0iW/lWY7j01SCnZzOXK0Eq7MZuEQj8PZEYBrU/xRNSyEEKumcic\n\tm0Bw==","X-Gm-Message-State":"AHPjjUh/SwUlJPj6HX0D43GoJ0alCSe587ucIo63POeOkmjkASewx5aU\n\t5A/0dTlgeJysewZZ","X-Google-Smtp-Source":"AOwi7QCeobMVpKAw6gYGkhQeCqONJLdBRveEJud+TuSFIvlHGMRzODdKw06ERXGFI0KfdxUZpzBctA==","X-Received":"by 10.28.131.197 with SMTP id f188mr1867387wmd.71.1504879975560; \n\tFri, 08 Sep 2017 07:12:55 -0700 (PDT)","References":"<20170905021201.25684-1-famz@redhat.com>\n\t<20170905021201.25684-2-famz@redhat.com>","User-agent":"mu4e 0.9.19; emacs 25.2.50.3","From":"Alex =?utf-8?q?Benn=C3=A9e?= ","To":"Fam Zheng ","In-reply-to":"<20170905021201.25684-2-famz@redhat.com>","Date":"Fri, 08 Sep 2017 15:12:53 +0100","Message-ID":"<87y3ppgty2.fsf@linaro.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"8bit","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2a00:1450:400c:c09::229","Subject":"Re: [Qemu-devel] [PATCH v6 01/12] gitignore: Ignore vm test images","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Peter Maydell , qemu-devel@nongnu.org, Philippe\n\t=?utf-8?q?Mathieu-Daud=C3=A9?= ,\n\tKamil Rytarowski , stefanha@redhat.com, \n\tCleber Rosa , pbonzini@redhat.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1765651,"web_url":"http://patchwork.ozlabs.org/comment/1765651/","msgid":"<20170908231217.GA18677@lemon.lan>","list_archive_url":null,"date":"2017-09-08T23:12:17","subject":"Re: [Qemu-devel] [PATCH v6 01/12] gitignore: Ignore vm test images","submitter":{"id":24872,"url":"http://patchwork.ozlabs.org/api/people/24872/","name":"Fam Zheng","email":"famz@redhat.com"},"content":"On Fri, 09/08 15:12, Alex Bennée wrote:\n> \n> Fam Zheng writes:\n> \n> > Signed-off-by: Fam Zheng \n> > ---\n> > .gitignore | 1 +\n> > tests/.gitignore | 1 +\n> > 2 files changed, 2 insertions(+)\n> >\n> > diff --git a/.gitignore b/.gitignore\n> > index cf65316863..40acfcb9e2 100644\n> > --- a/.gitignore\n> > +++ b/.gitignore\n> > @@ -52,6 +52,7 @@\n> > /vscclient\n> > /vhost-user-scsi\n> > /fsdev/virtfs-proxy-helper\n> > +*.tmp\n> \n> I'm not sure we should be dumping anything in the rootdir, .gitignored\n> or not.\n\nIt used to be /tests/vm/*.tmp but Philippe asked for a generic rule in previous\nreviewing. I think it makes sense, we can also unify the docker-src.* pattern by\nmaking the directory names to have a .tmp suffix later.\n\nFam","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx01.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx01.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=famz@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xptQp0jwnz9sCZ\n\tfor ;\n\tSat, 9 Sep 2017 09:13:04 +1000 (AEST)","from localhost ([::1]:47595 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dqSSJ-00009i-T4\n\tfor incoming@patchwork.ozlabs.org; Fri, 08 Sep 2017 19:12:59 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:58442)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dqSRo-000097-R3\n\tfor qemu-devel@nongnu.org; Fri, 08 Sep 2017 19:12:29 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dqSRj-0004rm-QN\n\tfor qemu-devel@nongnu.org; Fri, 08 Sep 2017 19:12:28 -0400","from mx1.redhat.com ([209.132.183.28]:37290)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dqSRj-0004ot-K5\n\tfor qemu-devel@nongnu.org; Fri, 08 Sep 2017 19:12:23 -0400","from smtp.corp.redhat.com\n\t(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 9AB5B81DEF;\n\tFri, 8 Sep 2017 23:12:21 +0000 (UTC)","from localhost (ovpn-12-23.pek2.redhat.com [10.72.12.23])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id EA2C760E3A;\n\tFri, 8 Sep 2017 23:12:18 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 9AB5B81DEF","Date":"Sat, 9 Sep 2017 07:12:17 +0800","From":"Fam Zheng ","To":"Alex =?iso-8859-1?q?Benn=E9e?= ","Message-ID":"<20170908231217.GA18677@lemon.lan>","References":"<20170905021201.25684-1-famz@redhat.com>\n\t<20170905021201.25684-2-famz@redhat.com>\n\t<87y3ppgty2.fsf@linaro.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","In-Reply-To":"<87y3ppgty2.fsf@linaro.org>","User-Agent":"Mutt/1.8.3 (2017-05-23)","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.12","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.25]);\n\tFri, 08 Sep 2017 23:12:21 +0000 (UTC)","Content-Transfer-Encoding":"quoted-printable","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v6 01/12] gitignore: Ignore vm test images","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Peter Maydell , qemu-devel@nongnu.org, Philippe\n\t=?iso-8859-1?q?Mathieu-Daud=E9?= ,\n\tKamil Rytarowski , stefanha@redhat.com, \n\tCleber Rosa , pbonzini@redhat.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]