[{"id":1763495,"web_url":"http://patchwork.ozlabs.org/comment/1763495/","msgid":"<20170905093501.2f1fbbfc@xeon-e3>","list_archive_url":null,"date":"2017-09-05T16:35:01","subject":"Re: [PATCH iproute2 master 2/2] bpf: consolidate dumps to use\n\tbpf_dump_prog_info","submitter":{"id":21389,"url":"http://patchwork.ozlabs.org/api/people/21389/","name":"Stephen Hemminger","email":"stephen@networkplumber.org"},"content":"On Tue, 5 Sep 2017 02:24:32 +0200\nDaniel Borkmann wrote:\n\n> Consolidate dump of prog info to use bpf_dump_prog_info() when possible.\n> Moving forward, we want to have a consistent output for BPF progs when\n> being dumped. E.g. in cls/act case we used to dump tag as a separate\n> netlink attribute before we had BPF_OBJ_GET_INFO_BY_FD bpf(2) command.\n> \n> Move dumping tag into bpf_dump_prog_info() as well, and only dump the\n> netlink attribute for older kernels. Also, reuse bpf_dump_prog_info()\n> for XDP case, so we can dump tag and whether program was jited, which\n> we currently don't show.\n> \n> Signed-off-by: Daniel Borkmann \n\nI applied this to master, and resolved conflicts with net-next.\nBut the dump with JSON of xdp is now incomplete.","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=networkplumber-org.20150623.gappssmtp.com\n\theader.i=@networkplumber-org.20150623.gappssmtp.com\n\theader.b=\"yIO834gK\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xmsl46n4hz9s7C\n\tfor ;\n\tWed, 6 Sep 2017 02:35:12 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752165AbdIEQfK (ORCPT );\n\tTue, 5 Sep 2017 12:35:10 -0400","from mail-pg0-f47.google.com ([74.125.83.47]:38650 \"EHLO\n\tmail-pg0-f47.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751774AbdIEQfJ (ORCPT\n\t); Tue, 5 Sep 2017 12:35:09 -0400","by mail-pg0-f47.google.com with SMTP id v66so10267586pgb.5\n\tfor ; Tue, 05 Sep 2017 09:35:09 -0700 (PDT)","from xeon-e3 (76-14-207-240.or.wavecable.com. [76.14.207.240])\n\tby smtp.gmail.com with ESMTPSA id\n\ti84sm3111234pfj.105.2017.09.05.09.35.08\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tTue, 05 Sep 2017 09:35:08 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=KZXD6jcdDPAOWCQ8kNXzUTOuJyw/YQ3wJAh8gB/t+oU=;\n\tb=yIO834gKBG5i93GEIEo/zB6ygtTvyDqn6oRsexHyj0CT3OWvPNQAfOHp/Fa8aQf6BS\n\tcB011V/5ab/xF6+m9BQvF3BXVfpkg6+9Ldv3lIV/SFHqUzoSAOwdKiXNmNe9UDYlGJqO\n\tNGoKPIdTJCmaDN/aVz7H3U2Apvfnu8CWsWMesilpjH2tJi1djM6MW9JLfH5x2K6D+Xe+\n\ttkEBv00I1XFDdGiR8efjC29Jd7UfPO6dafPVbkIcTH7L+J/iJvgrWildsBuBGPeJZa7M\n\tW56DgQRSKr0mW/rILyWxFQN39+MCnmbjfvZqphTAC9z4srt7JfQeHQaCJt6s9OnUc7lF\n\tFM2A==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=KZXD6jcdDPAOWCQ8kNXzUTOuJyw/YQ3wJAh8gB/t+oU=;\n\tb=ShAO16MSLAkWf6oSy5GhaLdbmCczGT/7SRV+4ozPaQyiQom8FPuKW7L3Oboju42Pry\n\tmpkXOpFjNlyvK400L23gUI6CWfbUgkLjabLKSjZKGrj9vB+4tFOYNTfjm9N22+caObIS\n\t/+/lRpLfgPy7KDtp9GdXbjMw4NNDKQHUk/Fqrn0zuIkiBbu3+RO1kq28a6efFXR8JGU/\n\tElOzlZmtmjCHHe+WuiookEyNTPabVMCxzchCLfWcYz/llPmOECYmXSJfbuJRfnnPRz3u\n\tt6OxoHZt0RKUaq9is5pn5k3e15Kn5QKdz7u+A1xw3qjSnDCnefBU/5U1lEr6/QWiZOAX\n\trmcw==","X-Gm-Message-State":"AHPjjUjY7ALLLaxPCzYbGDs/rhvLU+JoZwPjnQ6cEFAHYAAnnIvo7Ydy\n\ts4pA2OMwZHDc42b9","X-Google-Smtp-Source":"ADKCNb4QYfJpguC64rvvga59UGDL1uogtExdwxvbMOGR/mHsDoY5hcsICcVKjlb42HyIUn/2WdYD0w==","X-Received":"by 10.101.78.7 with SMTP id r7mr4801748pgt.64.1504629308780;\n\tTue, 05 Sep 2017 09:35:08 -0700 (PDT)","Date":"Tue, 5 Sep 2017 09:35:01 -0700","From":"Stephen Hemminger ","To":"Daniel Borkmann ","Cc":"ast@fb.com, netdev@vger.kernel.org","Subject":"Re: [PATCH iproute2 master 2/2] bpf: consolidate dumps to use\n\tbpf_dump_prog_info","Message-ID":"<20170905093501.2f1fbbfc@xeon-e3>","In-Reply-To":"<1e96ef342a4f34ee8c8119ee8cc1ed7092ea5ced.1504570627.git.daniel@iogearbox.net>","References":"\n\t<1e96ef342a4f34ee8c8119ee8cc1ed7092ea5ced.1504570627.git.daniel@iogearbox.net>","MIME-Version":"1.0","Content-Type":"text/plain; charset=US-ASCII","Content-Transfer-Encoding":"7bit","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1763498,"web_url":"http://patchwork.ozlabs.org/comment/1763498/","msgid":"<59AED2B7.2010000@iogearbox.net>","list_archive_url":null,"date":"2017-09-05T16:37:11","subject":"Re: [PATCH iproute2 master 2/2] bpf: consolidate dumps to use\n\tbpf_dump_prog_info","submitter":{"id":65705,"url":"http://patchwork.ozlabs.org/api/people/65705/","name":"Daniel Borkmann","email":"daniel@iogearbox.net"},"content":"On 09/05/2017 06:35 PM, Stephen Hemminger wrote:\n[...]\n> I applied this to master, and resolved conflicts with net-next.\n> But the dump with JSON of xdp is now incomplete.\n\nOk, I will check it out, and send a follow-up to make it\ncomplete again.","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xmsnV2ds3z9s7c\n\tfor ;\n\tWed, 6 Sep 2017 02:37:18 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752087AbdIEQhP (ORCPT );\n\tTue, 5 Sep 2017 12:37:15 -0400","from www62.your-server.de ([213.133.104.62]:57420 \"EHLO\n\twww62.your-server.de\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751774AbdIEQhP (ORCPT\n\t); Tue, 5 Sep 2017 12:37:15 -0400","from [92.105.166.74] (helo=localhost.localdomain)\n\tby www62.your-server.de with esmtpsa (TLSv1.2:DHE-RSA-AES256-SHA:256)\n\t(Exim 4.85_2) (envelope-from )\n\tid 1dpGqe-0007Ft-CA; Tue, 05 Sep 2017 18:37:12 +0200"],"Message-ID":"<59AED2B7.2010000@iogearbox.net>","Date":"Tue, 05 Sep 2017 18:37:11 +0200","From":"Daniel Borkmann ","User-Agent":"Mozilla/5.0 (X11; Linux x86_64;\n\trv:31.0) Gecko/20100101 Thunderbird/31.7.0","MIME-Version":"1.0","To":"Stephen Hemminger ","CC":"ast@fb.com, netdev@vger.kernel.org","Subject":"Re: [PATCH iproute2 master 2/2] bpf: consolidate dumps to use\n\tbpf_dump_prog_info","References":"\n\t<1e96ef342a4f34ee8c8119ee8cc1ed7092ea5ced.1504570627.git.daniel@iogearbox.net>\n\t<20170905093501.2f1fbbfc@xeon-e3>","In-Reply-To":"<20170905093501.2f1fbbfc@xeon-e3>","Content-Type":"text/plain; charset=windows-1252; format=flowed","Content-Transfer-Encoding":"7bit","X-Authenticated-Sender":"daniel@iogearbox.net","X-Virus-Scanned":"Clear (ClamAV 0.99.2/23776/Tue Sep 5 14:35:47 2017)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}}]