[{"id":1765723,"web_url":"http://patchwork.ozlabs.org/comment/1765723/","msgid":"","list_archive_url":null,"date":"2017-09-09T04:53:33","subject":"Re: [U-Boot] [PATCH v3 02/14] fdt: Introduce helper method\n\tfdt_overlay_apply_verbose()","submitter":{"id":6170,"url":"http://patchwork.ozlabs.org/api/people/6170/","name":"Simon Glass","email":"sjg@chromium.org"},"content":"On 4 September 2017 at 14:12, Pantelis Antoniou\n wrote:\n> Introduce fdt_overlay_apply_verbose, a method that applies an\n> overlay but in the case of an error produces a helpful message.\n>\n> In addition if a base tree is found to be missing the __symbols__\n> node the message will point out that the probable reason is that\n> the base tree was miscompiled without the -@ option.\n>\n> Signed-off-by: Pantelis Antoniou \n> ---\n> common/fdt_support.c | 31 +++++++++++++++++++++++++++++++\n> include/fdt_support.h | 2 ++\n> 2 files changed, 33 insertions(+)\n\nAcked-by: Simon Glass \n\nBTW I'd prefer to have the function comments in the header, but this\nfile is mixed, so OK.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=google.com header.i=@google.com\n\theader.b=\"QQzctogX\"; \n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"jvHFwjgZ\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xq2FW28tzz9sBZ\n\tfor ;\n\tSat, 9 Sep 2017 15:05:35 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid F118BC21F58; Sat, 9 Sep 2017 04:57:43 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 6365FC21E78;\n\tSat, 9 Sep 2017 04:55:46 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid DBBFAC21DEF; Sat, 9 Sep 2017 04:55:44 +0000 (UTC)","from mail-qt0-f174.google.com (mail-qt0-f174.google.com\n\t[209.85.216.174])\n\tby lists.denx.de (Postfix) with ESMTPS id 4EE73C21DEF\n\tfor ; Sat, 9 Sep 2017 04:53:55 +0000 (UTC)","by mail-qt0-f174.google.com with SMTP id b1so923398qtc.4\n\tfor ; Fri, 08 Sep 2017 21:53:55 -0700 (PDT)","by 10.200.37.200 with HTTP; Fri, 8 Sep 2017 21:53:33 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.0 required=5.0 tests=RCVD_IN_DNSWL_NONE,\n\tRCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,\n\tT_DKIM_INVALID autolearn=unavailable\n\tautolearn_force=no version=3.4.0","DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n\ts=20161025; \n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc;\n\tbh=NosNkrMsw/WcZc4i2r0M7PLc3NIpb7Hmiwiinh+Tkdo=;\n\tb=QQzctogX3Gp7vkcxlrz8CcUae0Yg3HvjTsbDMxJa/aVP8k272OqEcmv00YJ2nT411W\n\tLxMHVVVxY6TKkqzbqB/lmfAtEfNH8fplrHQuhG6GNQMpZwXTs3mKlRvpsY1oixeX6b2a\n\tXD0XYuv2msXmut+x0Bm54sRf3dTqi+s5GC4PSu4fYUvmNFZ1x3zOeYx92WySliloiY4e\n\tLIfce3aHNlvSZfc6bXgBFqisPYIjusgMh+ISYaA3wUm7GKWk7HJYeQ4zuFanuUh3Elue\n\tQqZJ0lNC2HssXluxQdRQlzLzoEQFniSSWGfRF3eEDroVqEvw2Wo6wkNS8CVlwrdRQiP7\n\t79GQ==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc;\n\tbh=NosNkrMsw/WcZc4i2r0M7PLc3NIpb7Hmiwiinh+Tkdo=;\n\tb=jvHFwjgZBWkYdGmBAbbYHQ6zCL8CLOG6t0XMW91r3L9Z+1Xm1vnTx1Pnm9+BwZR8Fe\n\tvmxN+VVhj87oz3b/GWWAtXgLMZBMHHbEc0cmAEuVJ+jCrT6JKiAnFg6QocKI4ElaFYXS\n\tal1u9un0E0DGf7V5Yf29L02SwNvCfuWCI4jIk="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:sender:in-reply-to:references:from\n\t:date:message-id:subject:to:cc;\n\tbh=NosNkrMsw/WcZc4i2r0M7PLc3NIpb7Hmiwiinh+Tkdo=;\n\tb=s4mLsVBOIUxuZFb4iPDbTfud2rD2+QuGM8y95t2c8Jgel5WpmJznwFPFGinMQ9amyC\n\tMMdmlxakSMcxtM2T4xz4ysYbmBNIabX1yt3LkcuV+LLD4nfTtcd4LQuorub1slLmbNHX\n\t/PnAK7O+sgJ2IXgbSb3ja0SLZWJ2ybmF0iu3XOrWjrO7kuLenC701lHcAkIJZAjFYgpF\n\t2qMnfBaLUFRHyvd3+hRltk2xLIQ7+asksTWyFx9+JjnOxV1XqiCpi/wp6pEDARTD1kwC\n\teYgPP0eax9KrK5GA5lcJMNu2xxpOVtiH7fGn6VCmVC90Q6p1YTB6ArLOrb1PbEKbFwFK\n\tgQoA==","X-Gm-Message-State":"AHPjjUgzesCnPgvm0sci5p6YN0v8yuycG7vaBzRPGHoLRNHcXQS8nVj3\n\tu9F2Cok+20FSFqPnxXPACpeOA0xo3t7dsPReQUoXnQ==","X-Google-Smtp-Source":"AOwi7QDG/U/0qrq/5hsHD4UCDpxsEh/u+YCPjYnYDoPVD5nobReX2iPQg3xCRyyjJJw19e13q5RNVyhhW/FxSgiqxyQ=","X-Received":"by 10.200.23.252 with SMTP id r57mr7543870qtk.76.1504932834085; \n\tFri, 08 Sep 2017 21:53:54 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<1504555943-12893-3-git-send-email-pantelis.antoniou@konsulko.com>","References":"<1504555943-12893-1-git-send-email-pantelis.antoniou@konsulko.com>\n\t<1504555943-12893-3-git-send-email-pantelis.antoniou@konsulko.com>","From":"Simon Glass ","Date":"Fri, 8 Sep 2017 22:53:33 -0600","X-Google-Sender-Auth":"FvFB9Kqxejk16S-OG9svi7Jx4Sg","Message-ID":"","To":"Pantelis Antoniou ","Cc":"Marek Vasut , Tom Rini ,\n\tTero Kristo ,\n\tU-Boot Mailing List , \n\tMaxime Ripard ,\n\tStefan Roese , Alan Ott ","Subject":"Re: [U-Boot] [PATCH v3 02/14] fdt: Introduce helper method\n\tfdt_overlay_apply_verbose()","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}},{"id":1769413,"web_url":"http://patchwork.ozlabs.org/comment/1769413/","msgid":"","list_archive_url":null,"date":"2017-09-15T19:25:30","subject":"Re: [U-Boot] [PATCH v3 02/14] fdt: Introduce helper method\n\tfdt_overlay_apply_verbose()","submitter":{"id":12501,"url":"http://patchwork.ozlabs.org/api/people/12501/","name":"Simon Glass","email":"sjg@google.com"},"content":"On 4 September 2017 at 14:12, Pantelis Antoniou\n wrote:\n> Introduce fdt_overlay_apply_verbose, a method that applies an\n> overlay but in the case of an error produces a helpful message.\n>\n> In addition if a base tree is found to be missing the __symbols__\n> node the message will point out that the probable reason is that\n> the base tree was miscompiled without the -@ option.\n>\n> Signed-off-by: Pantelis Antoniou \n> ---\n> common/fdt_support.c | 31 +++++++++++++++++++++++++++++++\n> include/fdt_support.h | 2 ++\n> 2 files changed, 33 insertions(+)\n\nAcked-by: Simon Glass \n\nBTW I'd prefer to have the function comments in the header, but this\nfile is mixed, so OK.\n\nApplied to u-boot-fdt thanks!","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=google.com header.i=@google.com\n\theader.b=\"Q9GqAjN0\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xv5hp5KSGz9s7g\n\tfor ;\n\tSat, 16 Sep 2017 05:54:50 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 7DDF1C22545; Fri, 15 Sep 2017 19:40:50 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 46CDDC2231B;\n\tFri, 15 Sep 2017 19:40:48 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 5F810C222F6; Fri, 15 Sep 2017 19:27:04 +0000 (UTC)","from mail-io0-f171.google.com (mail-io0-f171.google.com\n\t[209.85.223.171])\n\tby lists.denx.de (Postfix) with ESMTPS id 8251CC22008\n\tfor ; Fri, 15 Sep 2017 19:25:32 +0000 (UTC)","by mail-io0-f171.google.com with SMTP id z187so10812237ioz.12\n\tfor ; Fri, 15 Sep 2017 12:25:32 -0700 (PDT)","from 480794996271 named unknown by gmailapi.google.com with\n\tHTTPREST; Fri, 15 Sep 2017 12:25:30 -0700"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=0.0 required=5.0 tests=RCVD_IN_DNSWL_NONE,\n\tRCVD_IN_MSPIKE_H2, T_DKIM_INVALID,\n\tUNPARSEABLE_RELAY autolearn=unavailable\n\tautolearn_force=no version=3.4.0","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n\ts=20161025; \n\th=mime-version:sender:from:in-reply-to:references:date:message-id\n\t:subject:to:cc;\n\tbh=S6bF0+/sRYrSQhi7Hop7jSqf5oKLSrGbL54Z2MJIDxQ=;\n\tb=Q9GqAjN0ECDmYsKBWp0p9j5hF2eHjsc/SpQUSuobkdTub2CrykaFKiSNoFL+59Qmxk\n\tktPHrpJbVnQBn+s2j9/IIX409vWO1V3sE8Ms1ZipLsj5XN6+UJmLohzajDsUvaPxTIKq\n\tgHbRkib4xsZMU7P+zFb8Sr96Bz0HroNBIe5zZ0ckU6+7+GW6E9urz5XPpFPg9Q4uxSXD\n\tvxZxfEVJpMfVX+ukVnffPnkUsJiB+wiDBUHn81pGiRpz4X6Jp3Zli8s2uFI46osOYQOq\n\tLgVwjO9oMheGjHQUGfzIXlHK/uAdDfJdGS8JB7bArTB+w87P3mU6SBPl4HYpYImTCmsN\n\tL0Cg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:sender:from:in-reply-to:references\n\t:date:message-id:subject:to:cc;\n\tbh=S6bF0+/sRYrSQhi7Hop7jSqf5oKLSrGbL54Z2MJIDxQ=;\n\tb=KphQyuQt5WPYRfgqaX7BilIsOcSz//gjCvoKzOh/VB8xlXZJP1obGJgHrsXPSc/c/u\n\tU3R5gFhUxUBZ2WZlCquT8G8iRW92NEjT7hMVtbsoVUyqrDug8RwQeIhVPylH/NdUiJPg\n\tIS4W0t3xgtNS3yuX+BNe0FmoZu6Fcbou2gTBGpkXeCSHRdbPwvd+Py9M87SqcCCpOdp+\n\t5/hMUWg7hyaZ9uaeoiCKfLy1hmr279+DJe2j6RF5f5bX1T8hP+thHy2zp57IYvEWsUKW\n\tTi9MiqVM2ipkK1ux3GbAcXMUpqPM5zIxOnFzM75O4ayPyjEORXTsdz7v8QyCWYbRla2i\n\tzcRQ==","X-Gm-Message-State":"AHPjjUhoYeykciAlKapn+utvg1U+Mca113QlpNLiWHMw2WZPX3fD9ivS\n\tvCGgzPQM2igr+pPBo1Cw2FOpweYEv8vq2QOHfwn3IA==","X-Google-Smtp-Source":"AOwi7QB5FI/tAekdsJzD1m53AqopKIbj7BDgq6yAwOG8HFf70Twb8lLtW6FuZJmn1pz0Lavo3A5EN9ooZRVMCnaWYfc=","X-Received":"by 10.202.181.198 with SMTP id\n\te189mr18706988oif.300.1505503531185; \n\tFri, 15 Sep 2017 12:25:31 -0700 (PDT)","MIME-Version":"1.0","From":"sjg@google.com","In-Reply-To":"","References":"\n\t<1504555943-12893-1-git-send-email-pantelis.antoniou@konsulko.com>\n\t<1504555943-12893-3-git-send-email-pantelis.antoniou@konsulko.com>","Date":"Fri, 15 Sep 2017 12:25:30 -0700","X-Google-Sender-Auth":"QjZfFAIszYc7CM8WkhhdBZPKASE","Message-ID":"","To":"Simon Glass ","Cc":"Marek Vasut , Tom Rini ,\n\tPantelis Antoniou ,\n\tTero Kristo ,\n\tU-Boot Mailing List , \n\tMaxime Ripard ,\n\tStefan Roese , Alan Ott ","Subject":"Re: [U-Boot] [PATCH v3 02/14] fdt: Introduce helper method\n\tfdt_overlay_apply_verbose()","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}}]