[{"id":1764284,"web_url":"http://patchwork.ozlabs.org/comment/1764284/","msgid":"<26D9FDECA4FBDD4AADA65D8E2FC68A4A10EA9ACE@ORSMSX104.amr.corp.intel.com>","list_archive_url":null,"date":"2017-09-06T17:42:33","subject":"Re: [Intel-wired-lan] [net-next PATCH V2] ixgbe: add counter for\n\ttimes rx pages gets allocated, not recycled","submitter":{"id":66945,"url":"http://patchwork.ozlabs.org/api/people/66945/","name":"Bowers, AndrewX","email":"andrewx.bowers@intel.com"},"content":"> -----Original Message-----\n> From: Intel-wired-lan [mailto:intel-wired-lan-bounces@osuosl.org] On\n> Behalf Of Jesper Dangaard Brouer\n> Sent: Monday, September 4, 2017 11:40 AM\n> To: intel-wired-lan@lists.osuosl.org; Kirsher, Jeffrey T\n> \n> Cc: netdev@vger.kernel.org; Jesper Dangaard Brouer \n> Subject: [Intel-wired-lan] [net-next PATCH V2] ixgbe: add counter for times\n> rx pages gets allocated, not recycled\n> \n> The ixgbe driver have page recycle scheme based around the RX-ring queue,\n> where a RX page is shared between two packets. Based on the refcnt, the\n> driver can determine if the RX-page is currently only used by a single packet,\n> if so it can then directly refill/recycle the RX-slot by with the opposite \"side\"\n> of the page.\n> \n> While this is a clever trick, it is hard to determine when this recycling is\n> successful and when it fails. Adding a counter, which is available via ethtool --\n> statistics as 'alloc_rx_page'. Which counts the number of times the recycle\n> fails and the real page allocator is invoked. When interpreting the stats, do\n> remember that every alloc will serve two packets.\n> \n> The counter is collected per rx_ring, but is summed and ethtool exported as\n> 'alloc_rx_page'. It would be relevant to know what rx_ring that cannot keep\n> up, but that can be exported later if someone experience a need for this.\n> \n> Signed-off-by: Jesper Dangaard Brouer \n> ---\n> drivers/net/ethernet/intel/ixgbe/ixgbe.h | 2 ++\n> drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c | 1 +\n> drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 4 ++++\n> 3 files changed, 7 insertions(+)\n\nTested-by: Andrew Bowers ","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.133; helo=hemlock.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=)","Received":["from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xnWBW5vGSz9t2d\n\tfor ;\n\tThu, 7 Sep 2017 03:42:42 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id B1F6789BE4;\n\tWed, 6 Sep 2017 17:42:39 +0000 (UTC)","from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id hv+qb7d8B4rr; Wed, 6 Sep 2017 17:42:37 +0000 (UTC)","from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id C99E089BE2;\n\tWed, 6 Sep 2017 17:42:37 +0000 (UTC)","from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id 7FB601BFB44\n\tfor ;\n\tWed, 6 Sep 2017 17:42:36 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 78CB930B59\n\tfor ;\n\tWed, 6 Sep 2017 17:42:36 +0000 (UTC)","from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id Y-0xEBCtiP2z for ;\n\tWed, 6 Sep 2017 17:42:35 +0000 (UTC)","from mga02.intel.com (mga02.intel.com [134.134.136.20])\n\tby silver.osuosl.org (Postfix) with ESMTPS id A4A222E0D6\n\tfor ;\n\tWed, 6 Sep 2017 17:42:35 +0000 (UTC)","from orsmga005.jf.intel.com ([10.7.209.41])\n\tby orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t06 Sep 2017 10:42:34 -0700","from orsmsx107.amr.corp.intel.com ([10.22.240.5])\n\tby orsmga005.jf.intel.com with ESMTP; 06 Sep 2017 10:42:34 -0700","from orsmsx151.amr.corp.intel.com (10.22.226.38) by\n\tORSMSX107.amr.corp.intel.com (10.22.240.5) with Microsoft SMTP Server\n\t(TLS) id 14.3.319.2; Wed, 6 Sep 2017 10:42:34 -0700","from orsmsx104.amr.corp.intel.com ([169.254.4.142]) by\n\tORSMSX151.amr.corp.intel.com ([169.254.7.34]) with mapi id\n\t14.03.0319.002; Wed, 6 Sep 2017 10:42:34 -0700"],"X-Virus-Scanned":["amavisd-new at osuosl.org","amavisd-new at osuosl.org"],"X-Greylist":"domain auto-whitelisted by SQLgrey-1.7.6","X-ExtLoop1":"1","X-IronPort-AV":"E=Sophos;i=\"5.42,354,1500966000\"; d=\"scan'208\";a=\"146200047\"","From":"\"Bowers, AndrewX\" ","To":"\"intel-wired-lan@lists.osuosl.org\" ","Thread-Topic":"[Intel-wired-lan] [net-next PATCH V2] ixgbe: add counter for\n\ttimes rx pages gets allocated, not recycled","Thread-Index":"AQHTJa1OGymmK/n83EOJWjo7woEVpaKoI5Vg","Date":"Wed, 6 Sep 2017 17:42:33 +0000","Message-ID":"<26D9FDECA4FBDD4AADA65D8E2FC68A4A10EA9ACE@ORSMSX104.amr.corp.intel.com>","References":"<150455042211.455.6804897285651927718.stgit@firesoul>","In-Reply-To":"<150455042211.455.6804897285651927718.stgit@firesoul>","Accept-Language":"en-US","Content-Language":"en-US","X-MS-Has-Attach":"","X-MS-TNEF-Correlator":"","x-titus-metadata-40":"eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMDQyZDEyYjktNzJkYy00NTYxLWE4OTMtNTM5YWVkNWQ4YzFhIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6InVyM2hNeE9ZXC9JNlAxWm5RTE5yUmorajJcL214UEJEV2FMZDNaS21peGhYTT0ifQ==","x-ctpclassification":"CTP_IC","dlp-product":"dlpe-windows","dlp-version":"11.0.0.116","dlp-reaction":"no-action","x-originating-ip":"[10.22.254.138]","MIME-Version":"1.0","Subject":"Re: [Intel-wired-lan] [net-next PATCH V2] ixgbe: add counter for\n\ttimes rx pages gets allocated, not recycled","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.18-1","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n\t","List-Unsubscribe":", \n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":", \n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" "}}]