[{"id":1763611,"web_url":"http://patchwork.ozlabs.org/comment/1763611/","msgid":"","list_archive_url":null,"date":"2017-09-05T19:46:28","subject":"Re: [Buildroot] [PATCH] libmbim: udev is optional","submitter":{"id":48681,"url":"http://patchwork.ozlabs.org/api/people/48681/","name":"Aleksander Morgado","email":"aleksander@aleksander.es"},"content":"Hey,\n\nOn Mon, Sep 4, 2017 at 7:03 PM, Aleksander Morgado\n wrote:\n> Don't require udev/libgudev when building libmbim, just make it\n> optional. If there is udev support in the setup, require libgudev and\n> configure using --with-udev explicitly; otherwise just --without-udev.\n>\n> Signed-off-by: Aleksander Morgado \n\nPlease ignore this patch, I'll avoid having extra options in a follow\nup version.\n\n> ---\n> package/libmbim/Config.in | 16 +++++++++++-----\n> package/libmbim/libmbim.mk | 9 ++++++++-\n> 2 files changed, 19 insertions(+), 6 deletions(-)\n>\n> diff --git a/package/libmbim/Config.in b/package/libmbim/Config.in\n> index 4f8059264..35fceca67 100644\n> --- a/package/libmbim/Config.in\n> +++ b/package/libmbim/Config.in\n> @@ -2,8 +2,6 @@ config BR2_PACKAGE_LIBMBIM\n> bool \"libmbim\"\n> depends on BR2_USE_WCHAR # libglib2\n> depends on BR2_TOOLCHAIN_HAS_THREADS # libglib2\n> - depends on BR2_PACKAGE_HAS_UDEV\n> - select BR2_PACKAGE_LIBGUDEV\n> select BR2_PACKAGE_LIBGLIB2\n> help\n> libmbim is a glib-based library for talking to WWAN modems and\n> @@ -12,6 +10,14 @@ config BR2_PACKAGE_LIBMBIM\n>\n> http://www.freedesktop.org/wiki/Software/libmbim/\n>\n> -comment \"libmbim needs udev /dev management and a toolchain w/ wchar, threads\"\n> - depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS || \\\n> - !BR2_PACKAGE_HAS_UDEV\n> +if BR2_PACKAGE_LIBMBIM\n> +config BR2_PACKAGE_LIBMBIM_UDEV\n> + bool \"udev support\"\n> + depends on BR2_PACKAGE_HAS_UDEV\n> + select BR2_PACKAGE_LIBGUDEV\n> + help\n> + This option enables udev support in libmbim\n> +endif\n> +\n> +comment \"libmbim needs a toolchain w/ wchar, threads\"\n> + depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS\n> diff --git a/package/libmbim/libmbim.mk b/package/libmbim/libmbim.mk\n> index 33e500e53..03291a27f 100644\n> --- a/package/libmbim/libmbim.mk\n> +++ b/package/libmbim/libmbim.mk\n> @@ -11,9 +11,16 @@ LIBMBIM_LICENSE = LGPL-2.0+ (library), GPL-2.0+ (programs)\n> LIBMBIM_LICENSE_FILES = COPYING\n> LIBMBIM_INSTALL_STAGING = YES\n>\n> -LIBMBIM_DEPENDENCIES = libglib2 udev libgudev\n> +LIBMBIM_DEPENDENCIES = libglib2\n>\n> # we don't want -Werror\n> LIBMBIM_CONF_OPTS = --enable-more-warnings=no\n>\n> +ifeq ($(BR2_PACKAGE_LIBMBIM_UDEV),y)\n> +LIBMBIM_DEPENDENCIES += libgudev\n> +LIBMBIM_CONF_OPTS += --with-udev\n> +else\n> +LIBMBIM_CONF_OPTS += --without-udev\n> +endif\n> +\n> $(eval $(autotools-package))\n> --\n> 2.13.1\n>","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","buildroot@lists.busybox.net"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","buildroot@osuosl.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=busybox.net\n\t(client-ip=140.211.166.138; helo=whitealder.osuosl.org;\n\tenvelope-from=buildroot-bounces@busybox.net;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=aleksander-es.20150623.gappssmtp.com\n\theader.i=@aleksander-es.20150623.gappssmtp.com\n\theader.b=\"JA7JN/Tx\"; dkim-atps=neutral"],"Received":["from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xmy0K1qbpz9sNV\n\tfor ;\n\tWed, 6 Sep 2017 05:46:57 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 7754D87912;\n\tTue, 5 Sep 2017 19:46:55 +0000 (UTC)","from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id Pp0ytyMOModh; Tue, 5 Sep 2017 19:46:52 +0000 (UTC)","from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id B43A38789F;\n\tTue, 5 Sep 2017 19:46:52 +0000 (UTC)","from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id 066CE1C0E93\n\tfor ;\n\tTue, 5 Sep 2017 19:46:52 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id F134788B11\n\tfor ;\n\tTue, 5 Sep 2017 19:46:51 +0000 (UTC)","from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id N9OTASvqhlI8 for ;\n\tTue, 5 Sep 2017 19:46:50 +0000 (UTC)","from mail-wm0-f65.google.com (mail-wm0-f65.google.com\n\t[74.125.82.65])\n\tby hemlock.osuosl.org (Postfix) with ESMTPS id 7CE6888967\n\tfor ; Tue, 5 Sep 2017 19:46:50 +0000 (UTC)","by mail-wm0-f65.google.com with SMTP id u26so3722211wma.5\n\tfor ; Tue, 05 Sep 2017 12:46:50 -0700 (PDT)","by 10.80.186.25 with HTTP; Tue, 5 Sep 2017 12:46:28 -0700 (PDT)"],"X-Virus-Scanned":["amavisd-new at osuosl.org","amavisd-new at osuosl.org"],"X-Greylist":"from auto-whitelisted by SQLgrey-1.7.6","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=aleksander-es.20150623.gappssmtp.com; s=20150623;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=d5oQAKWsIG6BBmBenvJu9Th7nMzf8dYmvy3VK9L1Ei0=;\n\tb=JA7JN/TxTf2GBNj6CtI/xJlRs0Cn5YzyOjtgxPLc5FXgB9MA6eUu9k1XH8faIGgYp3\n\tgjzZZ0FgM0gYjnP7wIiD5XkuLH6a7n98t7HMU0AGb5Onr4dHqJnOkxREbkttiLIOiDpq\n\tWRHzIqVolMp82ji8G5nVKMQBQMBPZD/XVvu0XkQC3b/93VWQhJkjJrHX2gXCJfX5GEuf\n\tt1ZRmhRRPeQFg9ojItFIwb3Vb9QvjB8xq8zsrgLsAPqrbPanEDNPB2wlL2cc7tSUY+4p\n\tB4kH7LcvRif5+KOV/nnMvNlT4Zf8QW3v68XyrfrEjhY1zhLrUFibJz1QkWuirzsBowSD\n\tngjA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=d5oQAKWsIG6BBmBenvJu9Th7nMzf8dYmvy3VK9L1Ei0=;\n\tb=cMTo3ymVlMeYKBMlhlhI6b+j/U0957YFSVj+i0nARxqXnFw4367kqmgU15ETRPrXlx\n\t+OuY3Tpb6nryUFNHuOM0/iF+gm+gFPQaonKUcnklaJPPX2t/fa1Hg9MQ/FbfSphed549\n\tzcu51xX9vC5RPKbNtNGc/GYJMNf6DaQpXnYSSv+6lt86Uyl0Yezmt6KNtLM8AipczMwB\n\tQBg68c5eqvjjQPBjAdh9xqgeqv5IMNVtmcGICyJrLcEJMJdKSmxLhJ3XrvykjGxoFX90\n\tbz3jhBCNh1Oh/+8r/p1SOzQWvacayFEENGnf4NkZKYNu708ggMgA2GjhyKeIbTb3s7Kq\n\tIIXg==","X-Gm-Message-State":"AHPjjUgMzipyKhvUIVBAup8ap7uMgTpk3CATwXVrVHL/Wg2vp6Nur+vX\n\t3T6wHqlcZoBynp7lmC6LPQOGGd+Z2vlZs48=","X-Google-Smtp-Source":"ADKCNb6W89nkvb4U6vxBrNy9lrQx64CUpwJskjoWuoZjTYXpQXbfwX1LtKKWx19EQYv+u2VK6jls0DiKKkwevFQyT40=","X-Received":"by 10.80.137.242 with SMTP id h47mr3998259edh.124.1504640808854; \n\tTue, 05 Sep 2017 12:46:48 -0700 (PDT)","MIME-Version":"1.0","X-Originating-IP":"[83.40.186.116]","In-Reply-To":"<20170904170324.5426-1-aleksander@aleksander.es>","References":"<20170904170324.5426-1-aleksander@aleksander.es>","From":"Aleksander Morgado ","Date":"Tue, 5 Sep 2017 21:46:28 +0200","Message-ID":"","To":"buildroot@buildroot.org","Cc":"Thomas Petazzoni ,\n\tAleksander Morgado ","Subject":"Re: [Buildroot] [PATCH] libmbim: udev is optional","X-BeenThere":"buildroot@busybox.net","X-Mailman-Version":"2.1.18-1","Precedence":"list","List-Id":"Discussion and development of buildroot ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"buildroot-bounces@busybox.net","Sender":"\"buildroot\" "}}]