[{"id":1762797,"web_url":"http://patchwork.ozlabs.org/comment/1762797/","msgid":"","list_archive_url":null,"date":"2017-09-04T17:16:10","subject":"Re: [Qemu-devel] [PATCH v2] target/m68k: Switch fpu_rom from\n\tmake_floatx80() to make_floatx80_init()","submitter":{"id":70924,"url":"http://patchwork.ozlabs.org/api/people/70924/","name":"Philippe Mathieu-Daudé","email":"f4bug@amsat.org"},"content":"On Mon, Sep 4, 2017 at 1:46 PM, Kamil Rytarowski wrote:\n> GCC 4.7.2 on SunOS reports that the values assigned to array members are not\n> real constants:\n>\n> target/m68k/fpu_helper.c:32:5: error: initializer element is not constant\n> target/m68k/fpu_helper.c:32:5: error: (near initialization for 'fpu_rom[0]')\n> rules.mak:66: recipe for target 'target/m68k/fpu_helper.o' failed\n>\n> Convert the array to make_floatx80_init() to fix it.\n> Replace floatx80_pi-like constants with make_floatx80_init() as they are\n> defined as make_floatx80().\n>\n> This fixes build on SmartOS (Joyent).\n>\n> Signed-off-by: Kamil Rytarowski \n\nReviewed-by: Philippe Mathieu-Daudé \n\n> ---\n> target/m68k/fpu_helper.c | 44 ++++++++++++++++++++++----------------------\n> 1 file changed, 22 insertions(+), 22 deletions(-)\n>\n> diff --git a/target/m68k/fpu_helper.c b/target/m68k/fpu_helper.c\n> index bdfc537c68..8afd319ede 100644\n> --- a/target/m68k/fpu_helper.c\n> +++ b/target/m68k/fpu_helper.c\n> @@ -29,28 +29,28 @@\n> */\n>\n> static const floatx80 fpu_rom[128] = {\n> - [0x00] = floatx80_pi, /* Pi */\n> - [0x0b] = make_floatx80(0x3ffd, 0x9a209a84fbcff798ULL), /* Log10(2) */\n> - [0x0c] = make_floatx80(0x4000, 0xadf85458a2bb4a9aULL), /* e */\n> - [0x0d] = make_floatx80(0x3fff, 0xb8aa3b295c17f0bcULL), /* Log2(e) */\n> - [0x0e] = make_floatx80(0x3ffd, 0xde5bd8a937287195ULL), /* Log10(e) */\n> - [0x0f] = floatx80_zero, /* Zero */\n> - [0x30] = floatx80_ln2, /* ln(2) */\n> - [0x31] = make_floatx80(0x4000, 0x935d8dddaaa8ac17ULL), /* ln(10) */\n> - [0x32] = floatx80_one, /* 10^0 */\n> - [0x33] = make_floatx80(0x4002, 0xa000000000000000ULL), /* 10^1 */\n> - [0x34] = make_floatx80(0x4005, 0xc800000000000000ULL), /* 10^2 */\n> - [0x35] = make_floatx80(0x400c, 0x9c40000000000000ULL), /* 10^4 */\n> - [0x36] = make_floatx80(0x4019, 0xbebc200000000000ULL), /* 10^8 */\n> - [0x37] = make_floatx80(0x4034, 0x8e1bc9bf04000000ULL), /* 10^16 */\n> - [0x38] = make_floatx80(0x4069, 0x9dc5ada82b70b59eULL), /* 10^32 */\n> - [0x39] = make_floatx80(0x40d3, 0xc2781f49ffcfa6d5ULL), /* 10^64 */\n> - [0x3a] = make_floatx80(0x41a8, 0x93ba47c980e98ce0ULL), /* 10^128 */\n> - [0x3b] = make_floatx80(0x4351, 0xaa7eebfb9df9de8eULL), /* 10^256 */\n> - [0x3c] = make_floatx80(0x46a3, 0xe319a0aea60e91c7ULL), /* 10^512 */\n> - [0x3d] = make_floatx80(0x4d48, 0xc976758681750c17ULL), /* 10^1024 */\n> - [0x3e] = make_floatx80(0x5a92, 0x9e8b3b5dc53d5de5ULL), /* 10^2048 */\n> - [0x3f] = make_floatx80(0x7525, 0xc46052028a20979bULL), /* 10^4096 */\n> + [0x00] = make_floatx80_init(0x4000, 0x0c90fdaa22168c235LL), /* Pi */\n> + [0x0b] = make_floatx80_init(0x3ffd, 0x9a209a84fbcff798ULL), /* Log10(2) */\n> + [0x0c] = make_floatx80_init(0x4000, 0xadf85458a2bb4a9aULL), /* e */\n> + [0x0d] = make_floatx80_init(0x3fff, 0xb8aa3b295c17f0bcULL), /* Log2(e) */\n> + [0x0e] = make_floatx80_init(0x3ffd, 0xde5bd8a937287195ULL), /* Log10(e) */\n> + [0x0f] = make_floatx80_init(0x0000, 0x00000000000000000LL), /* Zero */\n> + [0x30] = make_floatx80_init(0x3ffe, 0x0b17217f7d1cf79acLL), /* ln(2) */\n> + [0x31] = make_floatx80_init(0x4000, 0x935d8dddaaa8ac17ULL), /* ln(10) */\n> + [0x32] = make_floatx80_init(0x3fff, 0x08000000000000000LL), /* 10^0 */\n> + [0x33] = make_floatx80_init(0x4002, 0xa000000000000000ULL), /* 10^1 */\n> + [0x34] = make_floatx80_init(0x4005, 0xc800000000000000ULL), /* 10^2 */\n> + [0x35] = make_floatx80_init(0x400c, 0x9c40000000000000ULL), /* 10^4 */\n> + [0x36] = make_floatx80_init(0x4019, 0xbebc200000000000ULL), /* 10^8 */\n> + [0x37] = make_floatx80_init(0x4034, 0x8e1bc9bf04000000ULL), /* 10^16 */\n> + [0x38] = make_floatx80_init(0x4069, 0x9dc5ada82b70b59eULL), /* 10^32 */\n> + [0x39] = make_floatx80_init(0x40d3, 0xc2781f49ffcfa6d5ULL), /* 10^64 */\n> + [0x3a] = make_floatx80_init(0x41a8, 0x93ba47c980e98ce0ULL), /* 10^128 */\n> + [0x3b] = make_floatx80_init(0x4351, 0xaa7eebfb9df9de8eULL), /* 10^256 */\n> + [0x3c] = make_floatx80_init(0x46a3, 0xe319a0aea60e91c7ULL), /* 10^512 */\n> + [0x3d] = make_floatx80_init(0x4d48, 0xc976758681750c17ULL), /* 10^1024 */\n> + [0x3e] = make_floatx80_init(0x5a92, 0x9e8b3b5dc53d5de5ULL), /* 10^2048 */\n> + [0x3f] = make_floatx80_init(0x7525, 0xc46052028a20979bULL), /* 10^4096 */\n> };\n>\n> int32_t HELPER(reds32)(CPUM68KState *env, FPReg *val)\n> --\n> 2.14.1\n>\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"stAj1yHC\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xmGjh4nRXz9sNq\n\tfor ;\n\tTue, 5 Sep 2017 03:16:55 +1000 (AEST)","from localhost ([::1]:54979 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1douzV-0000x7-Ae\n\tfor incoming@patchwork.ozlabs.org; Mon, 04 Sep 2017 13:16:53 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:38389)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from )\n\tid 1douyv-0000ux-F7\n\tfor qemu-devel@nongnu.org; Mon, 04 Sep 2017 13:16:22 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from )\n\tid 1douyq-0005zs-MS\n\tfor qemu-devel@nongnu.org; Mon, 04 Sep 2017 13:16:17 -0400","from mail-io0-x241.google.com ([2607:f8b0:4001:c06::241]:37281)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from )\n\tid 1douyq-0005zS-Fk\n\tfor qemu-devel@nongnu.org; Mon, 04 Sep 2017 13:16:12 -0400","by mail-io0-x241.google.com with SMTP id i200so537013ioa.4\n\tfor ; Mon, 04 Sep 2017 10:16:12 -0700 (PDT)","by 10.2.76.68 with HTTP; Mon, 4 Sep 2017 10:16:10 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc:content-transfer-encoding;\n\tbh=z9FhxSY6qlpjNqw5+UQYK36/LJvkDDKUXsrgkTv50rI=;\n\tb=stAj1yHC/UXLNJ3x5rWELh/YLf41XkP1hmU2poQX1gzWZNc3RCUx+UFpEJu9JziiWD\n\tgCUbpv8y1VozWgHufIgSVJBsToH7Mh/0hSeN9ODkjk12MHr1lhohAx5f3pguPHjXJAHV\n\tx6DeCVyo7H0AWi+LU+Z6JhVGhXwkzz5kyDo9Y4yM5Jp1I3j58zp20+MG/1awjT+viVxK\n\tIrCsCwR31bXsKIXKf7MXtPfA1q3uiV7QKFm5EUGxV8I9/+C9tbNgAb3qrZZOdvrnc6pa\n\t1XC531F4cblSDbjDGr9R+vSJVzLyY0aIiePYFGpNyxPyPNeAUkSCYc83bK1tVM1k2pHZ\n\tg2Rg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:sender:in-reply-to:references:from\n\t:date:message-id:subject:to:cc:content-transfer-encoding;\n\tbh=z9FhxSY6qlpjNqw5+UQYK36/LJvkDDKUXsrgkTv50rI=;\n\tb=S/FB8jdX329SL7MPpig7Dp0Vo+kV5TqV/ycMM6AQBdf6skYTtYu8wF5Dyx0DP7Bqs5\n\tAsh8pMZK/OulUfJss3E5pJbY1ykiYWNWGd+XwXSrTfXKn6ChLdQAja126ZOcyJZPZdkw\n\t8aVD9QdjXTTFANXEkdi3E8jfSgalg6/O/pFp0QthrD+U8BsEgMDQ92+h66MEtviWPXvF\n\tB3yXOfsQCz0qF6VJnWksv+V3E18X7jBlOCEc/60tJ53JwVhRiGGX69HTj59qpbZys5+T\n\t9Y8127XbcXjZ3ceSuXOhKb6ykXTEiHypEWyQnuHhozhJtDnU3FdkB6S1qw+7pfQL/WZz\n\tV6ZQ==","X-Gm-Message-State":"AHPjjUgQIaLKwwfJYN9X9/k8fKi6yA5TagOPOXytOyLGFBCpWoakLzSM\n\tJKebzZCfn4vYgw3SN1cmc9vkky1hkw==","X-Google-Smtp-Source":"ADKCNb7amM3iNqlVQaGQe4LiWVcL7a/gbGIb1yq1UmkmKk9NNl7kiN5nmFJP0Wuo2rxH3la1BijaRXvRYu3chLTjtDU=","X-Received":"by 10.36.208.195 with SMTP id m186mr1445697itg.163.1504545371723;\n\tMon, 04 Sep 2017 10:16:11 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<20170904164659.26915-1-n54@gmx.com>","References":"<20170903163130.14288-1-n54@gmx.com>\n\t<20170904164659.26915-1-n54@gmx.com>","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","Date":"Mon, 4 Sep 2017 14:16:10 -0300","X-Google-Sender-Auth":"B2uvBlgvIx2CsMo5V6RE-BxCBl8","Message-ID":"","To":"Kamil Rytarowski ","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2607:f8b0:4001:c06::241","Subject":"Re: [Qemu-devel] [PATCH v2] target/m68k: Switch fpu_rom from\n\tmake_floatx80() to make_floatx80_init()","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Peter Maydell ,\n\tLaurent Vivier ,\n\t\"qemu-devel@nongnu.org Developers\" ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1762802,"web_url":"http://patchwork.ozlabs.org/comment/1762802/","msgid":"<0deb4442-a7a5-45e5-bc5c-5fad2a7c9385@vivier.eu>","list_archive_url":null,"date":"2017-09-04T17:23:10","subject":"Re: [Qemu-devel] [PATCH v2] target/m68k: Switch fpu_rom from\n\tmake_floatx80() to make_floatx80_init()","submitter":{"id":2628,"url":"http://patchwork.ozlabs.org/api/people/2628/","name":"Laurent Vivier","email":"laurent@vivier.eu"},"content":"Le 04/09/2017 à 18:46, Kamil Rytarowski a écrit :\n> GCC 4.7.2 on SunOS reports that the values assigned to array members are not\n> real constants:\n> \n> target/m68k/fpu_helper.c:32:5: error: initializer element is not constant\n> target/m68k/fpu_helper.c:32:5: error: (near initialization for 'fpu_rom[0]')\n> rules.mak:66: recipe for target 'target/m68k/fpu_helper.o' failed\n> \n> Convert the array to make_floatx80_init() to fix it.\n> Replace floatx80_pi-like constants with make_floatx80_init() as they are\n> defined as make_floatx80().\n> \n> This fixes build on SmartOS (Joyent).\n> \n> Signed-off-by: Kamil Rytarowski \n> ---\n> target/m68k/fpu_helper.c | 44 ++++++++++++++++++++++----------------------\n> 1 file changed, 22 insertions(+), 22 deletions(-)\n> \n> diff --git a/target/m68k/fpu_helper.c b/target/m68k/fpu_helper.c\n> index bdfc537c68..8afd319ede 100644\n> --- a/target/m68k/fpu_helper.c\n> +++ b/target/m68k/fpu_helper.c\n> @@ -29,28 +29,28 @@\n> */\n> \n> static const floatx80 fpu_rom[128] = {\n> - [0x00] = floatx80_pi, /* Pi */\n> - [0x0b] = make_floatx80(0x3ffd, 0x9a209a84fbcff798ULL), /* Log10(2) */\n> - [0x0c] = make_floatx80(0x4000, 0xadf85458a2bb4a9aULL), /* e */\n> - [0x0d] = make_floatx80(0x3fff, 0xb8aa3b295c17f0bcULL), /* Log2(e) */\n> - [0x0e] = make_floatx80(0x3ffd, 0xde5bd8a937287195ULL), /* Log10(e) */\n> - [0x0f] = floatx80_zero, /* Zero */\n> - [0x30] = floatx80_ln2, /* ln(2) */\n> - [0x31] = make_floatx80(0x4000, 0x935d8dddaaa8ac17ULL), /* ln(10) */\n> - [0x32] = floatx80_one, /* 10^0 */\n> - [0x33] = make_floatx80(0x4002, 0xa000000000000000ULL), /* 10^1 */\n> - [0x34] = make_floatx80(0x4005, 0xc800000000000000ULL), /* 10^2 */\n> - [0x35] = make_floatx80(0x400c, 0x9c40000000000000ULL), /* 10^4 */\n> - [0x36] = make_floatx80(0x4019, 0xbebc200000000000ULL), /* 10^8 */\n> - [0x37] = make_floatx80(0x4034, 0x8e1bc9bf04000000ULL), /* 10^16 */\n> - [0x38] = make_floatx80(0x4069, 0x9dc5ada82b70b59eULL), /* 10^32 */\n> - [0x39] = make_floatx80(0x40d3, 0xc2781f49ffcfa6d5ULL), /* 10^64 */\n> - [0x3a] = make_floatx80(0x41a8, 0x93ba47c980e98ce0ULL), /* 10^128 */\n> - [0x3b] = make_floatx80(0x4351, 0xaa7eebfb9df9de8eULL), /* 10^256 */\n> - [0x3c] = make_floatx80(0x46a3, 0xe319a0aea60e91c7ULL), /* 10^512 */\n> - [0x3d] = make_floatx80(0x4d48, 0xc976758681750c17ULL), /* 10^1024 */\n> - [0x3e] = make_floatx80(0x5a92, 0x9e8b3b5dc53d5de5ULL), /* 10^2048 */\n> - [0x3f] = make_floatx80(0x7525, 0xc46052028a20979bULL), /* 10^4096 */\n> + [0x00] = make_floatx80_init(0x4000, 0x0c90fdaa22168c235LL), /* Pi */\n\nshould be make_floatx80_init(0x4000, 0xc90fdaa22168c235ULL)\n\n> + [0x0b] = make_floatx80_init(0x3ffd, 0x9a209a84fbcff798ULL), /* Log10(2) */\n> + [0x0c] = make_floatx80_init(0x4000, 0xadf85458a2bb4a9aULL), /* e */\n> + [0x0d] = make_floatx80_init(0x3fff, 0xb8aa3b295c17f0bcULL), /* Log2(e) */\n> + [0x0e] = make_floatx80_init(0x3ffd, 0xde5bd8a937287195ULL), /* Log10(e) */\n> + [0x0f] = make_floatx80_init(0x0000, 0x00000000000000000LL), /* Zero */\n\n make_floatx80_init(0x0000, 0x0000000000000000ULL)\n\n> + [0x30] = make_floatx80_init(0x3ffe, 0x0b17217f7d1cf79acLL), /* ln(2) */\n\n make_floatx80_init(0x3ffe, 0xb17217f7d1cf79acULL)\n\n> + [0x31] = make_floatx80_init(0x4000, 0x935d8dddaaa8ac17ULL), /* ln(10) */\n> + [0x32] = make_floatx80_init(0x3fff, 0x08000000000000000LL), /* 10^0 */\n\n make_floatx80_init(0x3fff, 0x8000000000000000ULL)\n\n> + [0x33] = make_floatx80_init(0x4002, 0xa000000000000000ULL), /* 10^1 */\n> + [0x34] = make_floatx80_init(0x4005, 0xc800000000000000ULL), /* 10^2 */\n> + [0x35] = make_floatx80_init(0x400c, 0x9c40000000000000ULL), /* 10^4 */\n> + [0x36] = make_floatx80_init(0x4019, 0xbebc200000000000ULL), /* 10^8 */\n> + [0x37] = make_floatx80_init(0x4034, 0x8e1bc9bf04000000ULL), /* 10^16 */\n> + [0x38] = make_floatx80_init(0x4069, 0x9dc5ada82b70b59eULL), /* 10^32 */\n> + [0x39] = make_floatx80_init(0x40d3, 0xc2781f49ffcfa6d5ULL), /* 10^64 */\n> + [0x3a] = make_floatx80_init(0x41a8, 0x93ba47c980e98ce0ULL), /* 10^128 */\n> + [0x3b] = make_floatx80_init(0x4351, 0xaa7eebfb9df9de8eULL), /* 10^256 */\n> + [0x3c] = make_floatx80_init(0x46a3, 0xe319a0aea60e91c7ULL), /* 10^512 */\n> + [0x3d] = make_floatx80_init(0x4d48, 0xc976758681750c17ULL), /* 10^1024 */\n> + [0x3e] = make_floatx80_init(0x5a92, 0x9e8b3b5dc53d5de5ULL), /* 10^2048 */\n> + [0x3f] = make_floatx80_init(0x7525, 0xc46052028a20979bULL), /* 10^4096 */\n> };\n> \n> int32_t HELPER(reds32)(CPUM68KState *env, FPReg *val)\n> \n\nThanks,\nLaurent","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xmGsl5M9lz9t2R\n\tfor ;\n\tTue, 5 Sep 2017 03:23:54 +1000 (AEST)","from localhost ([::1]:54996 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dov6F-0003O5-Tu\n\tfor incoming@patchwork.ozlabs.org; Mon, 04 Sep 2017 13:23:51 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:39790)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dov5m-0003NR-VS\n\tfor qemu-devel@nongnu.org; Mon, 04 Sep 2017 13:23:27 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dov5i-0002At-0o\n\tfor qemu-devel@nongnu.org; Mon, 04 Sep 2017 13:23:22 -0400","from mout.kundenserver.de ([217.72.192.75]:58824)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from ) id 1dov5h-00029V-NV\n\tfor qemu-devel@nongnu.org; Mon, 04 Sep 2017 13:23:17 -0400","from [192.168.100.1] ([78.238.229.36]) by mrelayeu.kundenserver.de\n\t(mreue104 [212.227.15.183]) with ESMTPSA (Nemesis) id\n\t0M3jdZ-1dWylU1OE5-00rKRv; Mon, 04 Sep 2017 19:23:13 +0200"],"To":"Kamil Rytarowski ","References":"<20170903163130.14288-1-n54@gmx.com>\n\t<20170904164659.26915-1-n54@gmx.com>","From":"Laurent Vivier ","Message-ID":"<0deb4442-a7a5-45e5-bc5c-5fad2a7c9385@vivier.eu>","Date":"Mon, 4 Sep 2017 19:23:10 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170904164659.26915-1-n54@gmx.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"8bit","X-Provags-ID":"V03:K0:6IhHoYCj83Fk/mWWXGNcWP0Slm/P73T0pBAN8y9++ad1tVPUKaG\n\talhodhEMSYIw83xbSjBvCctw3jLnJc/71Z1oKJzwTRNIhJD0g+ziiK4h0mH4d6T725RSCws\n\t+kepuokT0IqnuJW7SppYViZQA22O2Qygk8LG4WpZOEDYb22NwQNPVQTlFdfqXyhct7uFo9V\n\thMWlmNeZ2up6HP0eDXcyA==","X-UI-Out-Filterresults":"notjunk:1; V01:K0:jlWUIzUhdpY=:iaTiH6hPd9rdMEhEz+ftPd\n\tE/WjldPY6tGTKJLlS1Td0d1tSqAcISLmVzukTOmNfNibLkNdZWXn+PR0g8W9QprrDvXQdCzrG\n\tRW43xi2MghEpCqrKaAePt9g3ifWukxi3u3iJkRwHyFpz1wXG/MpW8MdSP/bRvo3A/MmYkirOs\n\tSVMZpuw2rtD35c8qBfmdPrvAjmQLVTB8KSPYRuKR3Y0p1jjG34bVDjdl5Kk3q0vQUtzFJ9++a\n\tLVPi9Gx40L1K6s3MsDzfRJW61wjAz4AIuLeN+Ohu28fRAGUvLh3zOZ5JQkFJ94wWaIk+X2sXL\n\td5EcSRsKHgNEFqB+S7e+Tc41SRShGpNmRhlxLeLjGGTva1Qx8NBCUvsSB4J2eCz6ylm0oflL+\n\tCo0FzMI97g4O2rbPGFcquXwqCCn0PM4yOzBkxl2fxC039+oGafV+WIRQxvNguVHQ/Pv1Osnhg\n\tEMwrTBlxBtEKD9GvWEmWGM3fcDTV1077VuN/LHbDHuRg2gbLxxVNn5ls2d5d/ihYggu5ba+3a\n\tsXZqfYBUIPuLhBiwn7cybd7tpPCbJdGLwr4cR7JK6VyZvr6L7pJrBHpdkMVgAmbeRyH18LaRW\n\tK+OLAppju2G+Xe/P6TB2+Avb/HzwFNJ+kyPqGzYIk+gyuCDPYooUzcc9Tq4wZScIWgHOLz8As\n\tZvUSmkZkUIKtPal83FITUMwa0/uVHt8HNkXxz8Ix15ju8d0kCe994U7SHKB7chlwQyy65N8lG\n\tg2rjpkpafTcRNT4fAkhOjI2AY724MvojYRoUaLuBz5WwffDH7SUwUxc+GE4=","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"217.72.192.75","Subject":"Re: [Qemu-devel] [PATCH v2] target/m68k: Switch fpu_rom from\n\tmake_floatx80() to make_floatx80_init()","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"peter.maydell@linaro.org, qemu-devel@nongnu.org, f4bug@amsat.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1762825,"web_url":"http://patchwork.ozlabs.org/comment/1762825/","msgid":"","list_archive_url":null,"date":"2017-09-04T18:01:56","subject":"Re: [Qemu-devel] [PATCH v2] target/m68k: Switch fpu_rom from\n\tmake_floatx80() to make_floatx80_init()","submitter":{"id":70924,"url":"http://patchwork.ozlabs.org/api/people/70924/","name":"Philippe Mathieu-Daudé","email":"f4bug@amsat.org"},"content":"On 09/04/2017 02:23 PM, Laurent Vivier wrote:\n> Le 04/09/2017 à 18:46, Kamil Rytarowski a écrit :\n>> GCC 4.7.2 on SunOS reports that the values assigned to array members are not\n>> real constants:\n>>\n>> target/m68k/fpu_helper.c:32:5: error: initializer element is not constant\n>> target/m68k/fpu_helper.c:32:5: error: (near initialization for 'fpu_rom[0]')\n>> rules.mak:66: recipe for target 'target/m68k/fpu_helper.o' failed\n>>\n>> Convert the array to make_floatx80_init() to fix it.\n>> Replace floatx80_pi-like constants with make_floatx80_init() as they are\n>> defined as make_floatx80().\n>>\n>> This fixes build on SmartOS (Joyent).\n>>\n>> Signed-off-by: Kamil Rytarowski \n>> ---\n>> target/m68k/fpu_helper.c | 44 ++++++++++++++++++++++----------------------\n>> 1 file changed, 22 insertions(+), 22 deletions(-)\n>>\n>> diff --git a/target/m68k/fpu_helper.c b/target/m68k/fpu_helper.c\n>> index bdfc537c68..8afd319ede 100644\n>> --- a/target/m68k/fpu_helper.c\n>> +++ b/target/m68k/fpu_helper.c\n>> @@ -29,28 +29,28 @@\n>> */\n>> \n>> static const floatx80 fpu_rom[128] = {\n>> - [0x00] = floatx80_pi, /* Pi */\n>> - [0x0b] = make_floatx80(0x3ffd, 0x9a209a84fbcff798ULL), /* Log10(2) */\n>> - [0x0c] = make_floatx80(0x4000, 0xadf85458a2bb4a9aULL), /* e */\n>> - [0x0d] = make_floatx80(0x3fff, 0xb8aa3b295c17f0bcULL), /* Log2(e) */\n>> - [0x0e] = make_floatx80(0x3ffd, 0xde5bd8a937287195ULL), /* Log10(e) */\n>> - [0x0f] = floatx80_zero, /* Zero */\n>> - [0x30] = floatx80_ln2, /* ln(2) */\n>> - [0x31] = make_floatx80(0x4000, 0x935d8dddaaa8ac17ULL), /* ln(10) */\n>> - [0x32] = floatx80_one, /* 10^0 */\n>> - [0x33] = make_floatx80(0x4002, 0xa000000000000000ULL), /* 10^1 */\n>> - [0x34] = make_floatx80(0x4005, 0xc800000000000000ULL), /* 10^2 */\n>> - [0x35] = make_floatx80(0x400c, 0x9c40000000000000ULL), /* 10^4 */\n>> - [0x36] = make_floatx80(0x4019, 0xbebc200000000000ULL), /* 10^8 */\n>> - [0x37] = make_floatx80(0x4034, 0x8e1bc9bf04000000ULL), /* 10^16 */\n>> - [0x38] = make_floatx80(0x4069, 0x9dc5ada82b70b59eULL), /* 10^32 */\n>> - [0x39] = make_floatx80(0x40d3, 0xc2781f49ffcfa6d5ULL), /* 10^64 */\n>> - [0x3a] = make_floatx80(0x41a8, 0x93ba47c980e98ce0ULL), /* 10^128 */\n>> - [0x3b] = make_floatx80(0x4351, 0xaa7eebfb9df9de8eULL), /* 10^256 */\n>> - [0x3c] = make_floatx80(0x46a3, 0xe319a0aea60e91c7ULL), /* 10^512 */\n>> - [0x3d] = make_floatx80(0x4d48, 0xc976758681750c17ULL), /* 10^1024 */\n>> - [0x3e] = make_floatx80(0x5a92, 0x9e8b3b5dc53d5de5ULL), /* 10^2048 */\n>> - [0x3f] = make_floatx80(0x7525, 0xc46052028a20979bULL), /* 10^4096 */\n>> + [0x00] = make_floatx80_init(0x4000, 0x0c90fdaa22168c235LL), /* Pi */\n> \n> should be make_floatx80_init(0x4000, 0xc90fdaa22168c235ULL)\n\noops I missed the sign, thankfully you did a careful review!\n\n> \n>> + [0x0b] = make_floatx80_init(0x3ffd, 0x9a209a84fbcff798ULL), /* Log10(2) */\n>> + [0x0c] = make_floatx80_init(0x4000, 0xadf85458a2bb4a9aULL), /* e */\n>> + [0x0d] = make_floatx80_init(0x3fff, 0xb8aa3b295c17f0bcULL), /* Log2(e) */\n>> + [0x0e] = make_floatx80_init(0x3ffd, 0xde5bd8a937287195ULL), /* Log10(e) */\n>> + [0x0f] = make_floatx80_init(0x0000, 0x00000000000000000LL), /* Zero */\n> \n> make_floatx80_init(0x0000, 0x0000000000000000ULL)\n> \n>> + [0x30] = make_floatx80_init(0x3ffe, 0x0b17217f7d1cf79acLL), /* ln(2) */\n> \n> make_floatx80_init(0x3ffe, 0xb17217f7d1cf79acULL)\n> \n>> + [0x31] = make_floatx80_init(0x4000, 0x935d8dddaaa8ac17ULL), /* ln(10) */\n>> + [0x32] = make_floatx80_init(0x3fff, 0x08000000000000000LL), /* 10^0 */\n> \n> make_floatx80_init(0x3fff, 0x8000000000000000ULL)\n> \n>> + [0x33] = make_floatx80_init(0x4002, 0xa000000000000000ULL), /* 10^1 */\n>> + [0x34] = make_floatx80_init(0x4005, 0xc800000000000000ULL), /* 10^2 */\n>> + [0x35] = make_floatx80_init(0x400c, 0x9c40000000000000ULL), /* 10^4 */\n>> + [0x36] = make_floatx80_init(0x4019, 0xbebc200000000000ULL), /* 10^8 */\n>> + [0x37] = make_floatx80_init(0x4034, 0x8e1bc9bf04000000ULL), /* 10^16 */\n>> + [0x38] = make_floatx80_init(0x4069, 0x9dc5ada82b70b59eULL), /* 10^32 */\n>> + [0x39] = make_floatx80_init(0x40d3, 0xc2781f49ffcfa6d5ULL), /* 10^64 */\n>> + [0x3a] = make_floatx80_init(0x41a8, 0x93ba47c980e98ce0ULL), /* 10^128 */\n>> + [0x3b] = make_floatx80_init(0x4351, 0xaa7eebfb9df9de8eULL), /* 10^256 */\n>> + [0x3c] = make_floatx80_init(0x46a3, 0xe319a0aea60e91c7ULL), /* 10^512 */\n>> + [0x3d] = make_floatx80_init(0x4d48, 0xc976758681750c17ULL), /* 10^1024 */\n>> + [0x3e] = make_floatx80_init(0x5a92, 0x9e8b3b5dc53d5de5ULL), /* 10^2048 */\n>> + [0x3f] = make_floatx80_init(0x7525, 0xc46052028a20979bULL), /* 10^4096 */\n>> };\n>> \n>> int32_t HELPER(reds32)(CPUM68KState *env, FPReg *val)\n>>\n> \n> Thanks,\n> Laurent\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"TLNafztS\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xmHkX2sNpz9s7h\n\tfor ;\n\tTue, 5 Sep 2017 04:02:44 +1000 (AEST)","from localhost ([::1]:55107 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dovhq-00084R-Hu\n\tfor incoming@patchwork.ozlabs.org; Mon, 04 Sep 2017 14:02:42 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:49695)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from )\n\tid 1dovhF-000811-1T\n\tfor qemu-devel@nongnu.org; Mon, 04 Sep 2017 14:02:09 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from )\n\tid 1dovhA-0007Jg-8v\n\tfor qemu-devel@nongnu.org; Mon, 04 Sep 2017 14:02:05 -0400","from mail-qt0-x241.google.com ([2607:f8b0:400d:c0d::241]:38376)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from )\n\tid 1dovhA-0007JW-3o\n\tfor qemu-devel@nongnu.org; Mon, 04 Sep 2017 14:02:00 -0400","by mail-qt0-x241.google.com with SMTP id 12so724946qtn.5\n\tfor ; Mon, 04 Sep 2017 11:01:59 -0700 (PDT)","from [192.168.1.10] ([181.93.89.178])\n\tby smtp.gmail.com with ESMTPSA id\n\tg9sm4961492qta.77.2017.09.04.11.01.57\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tMon, 04 Sep 2017 11:01:58 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=sender:subject:to:cc:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:content-transfer-encoding; \n\tbh=ZhNcEnWvXAvXAj8SUvv9GqjFb5tHl1ILaETageRyXaw=;\n\tb=TLNafztSmcaUAs5q/M3S69EZAcO8Q8/v8wVUUacxn2Im9f8yfIuFXl4MYE7biMVWPs\n\tnLFKQyx36CV6hMhZiekdW4uCeiYJa1s/zv9ZYQ9gPTBIGRTqMM2cw1u5UQbgzbzQjrKm\n\tYE3jitZU19pUcJJGv3rhAPSSs3WQ24/PwF1vUyJDOvPB4299PFoQupb5h8/kvla/AVwf\n\txq2MjH0XkIz08bs9kDCrw/nfW/2U7rhfSvts9tl1bUMN9jVgI0+J0HJsgB9eLgAEyWqJ\n\tstYeVB9X/ARL2ncTu4Ka6xBwoWm9RGt10g61O2lAR0sl8XtHtV1B8kB+GriooUeblRGo\n\tTqkw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:sender:subject:to:cc:references:from:message-id\n\t:date:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=ZhNcEnWvXAvXAj8SUvv9GqjFb5tHl1ILaETageRyXaw=;\n\tb=L3aNNSbZa3OUWLgvtHqafSIjxEG5KdIyKoKX9Bq/IC5IdZMzYShjapAFTH4lnCBodM\n\tyW6Eu+41HOQyx57XBZVuPa1CVMXNdj66RmIUcIBLneFOCwjGX5EoaNYj9ToAQPGwaAnR\n\tRNnDYAiwy2Wma5N/a/Q07NOezZu0htVtxxQbAitbDz3A8TCMwMm9yXGLB9mqboZc1yxC\n\tatKcjxmp6NM45uxL+p/I4q9wKO3AhxRkLSG4vAulm8x7wV1Yftc5zYo4bYprtSrwWfw/\n\torwJ2iY+S2lXrrSPzZor6dorcs+IoHOyYccUdzEKeg7wMQqVYNf0I4gQ9YYrKu5bAoWW\n\tgykA==","X-Gm-Message-State":"AHPjjUiQBTQrC7N3mqqq1Npnq2oXllxfGfaT7jVfmVSPp8B3PLo7of50\n\tpDjJ6WauuwFZDw==","X-Google-Smtp-Source":"ADKCNb4+Tvdq8ZjfiGTha8osnoMSkb7HgfqPlgv5QfySmvECn7W5qesFAVni8+4DzByK+QfUOQKfuQ==","X-Received":"by 10.200.23.37 with SMTP id w34mr1957762qtj.260.1504548119454; \n\tMon, 04 Sep 2017 11:01:59 -0700 (PDT)","To":"Laurent Vivier , Kamil Rytarowski ","References":"<20170903163130.14288-1-n54@gmx.com>\n\t<20170904164659.26915-1-n54@gmx.com>\n\t<0deb4442-a7a5-45e5-bc5c-5fad2a7c9385@vivier.eu>","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","Message-ID":"","Date":"Mon, 4 Sep 2017 15:01:56 -0300","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<0deb4442-a7a5-45e5-bc5c-5fad2a7c9385@vivier.eu>","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Language":"en-US","Content-Transfer-Encoding":"8bit","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2607:f8b0:400d:c0d::241","Subject":"Re: [Qemu-devel] [PATCH v2] target/m68k: Switch fpu_rom from\n\tmake_floatx80() to make_floatx80_init()","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"peter.maydell@linaro.org, qemu-devel@nongnu.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]