[{"id":1763111,"web_url":"http://patchwork.ozlabs.org/comment/1763111/","msgid":"","list_archive_url":null,"date":"2017-09-05T09:14:43","subject":"Re: [Qemu-devel] [PATCH v2 17/19] s390x: CPU hot unplug via\n\tdevice_del cannot work","submitter":{"id":590,"url":"http://patchwork.ozlabs.org/api/people/590/","name":"Christian Borntraeger","email":"borntraeger@de.ibm.com"},"content":"On 09/04/2017 05:43 PM, David Hildenbrand wrote:\n> device_del on a CPU will currently do nothing. Let's emmit an error\n> telling that this is will never work (there is no architecture support\n> on s390x). Error message copied from ppc.\n> \n> (qemu) device_del cpu1\n> device_del cpu1\n> CPU hot unplug not supported on this machine\n\nGiven the fact that I get the question about unplug _every_ time when I give a presentation\nabout KVM on z, I will try to get some architecture folks look at this. Maybe we can define\nsomething very simple like \"if the CPU is in the stopped state we can remove this and just\npiggy back on the existing sclp EVENT_QUAL_CPU_CHANGE notification\".\n\nSo maybe add \"currently\"\n\n\n> \n> Signed-off-by: David Hildenbrand \n> ---\n> hw/s390x/s390-virtio-ccw.c | 10 ++++++++++\n> 1 file changed, 10 insertions(+)\n> \n> diff --git a/hw/s390x/s390-virtio-ccw.c b/hw/s390x/s390-virtio-ccw.c\n> index 22a8a1b45d..dd149567bb 100644\n> --- a/hw/s390x/s390-virtio-ccw.c\n> +++ b/hw/s390x/s390-virtio-ccw.c\n> @@ -338,6 +338,15 @@ static void s390_machine_device_plug(HotplugHandler *hotplug_dev,\n> }\n> }\n> \n> +static void s390_machine_device_unplug_request(HotplugHandler *hotplug_dev,\n> + DeviceState *dev, Error **errp)\n> +{\n> + if (object_dynamic_cast(OBJECT(dev), TYPE_CPU)) {\n> + error_setg(errp, \"CPU hot unplug not supported on this machine\");\n> + return;\n> + }\n> +}\n> +\n> static HotplugHandler *s390_get_hotplug_handler(MachineState *machine,\n> DeviceState *dev)\n> {\n> @@ -387,6 +396,7 @@ static void ccw_machine_class_init(ObjectClass *oc, void *data)\n> mc->max_cpus = 248;\n> mc->get_hotplug_handler = s390_get_hotplug_handler;\n> hc->plug = s390_machine_device_plug;\n> + hc->unplug_request = s390_machine_device_unplug_request;\n> nc->nmi_monitor_handler = s390_nmi;\n> }\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xmgzn4k72z9s7m\n\tfor ;\n\tTue, 5 Sep 2017 19:15:33 +1000 (AEST)","from localhost ([::1]:57617 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dp9xD-0005rK-PU\n\tfor incoming@patchwork.ozlabs.org; Tue, 05 Sep 2017 05:15:31 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:37631)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dp9we-0005lE-7W\n\tfor qemu-devel@nongnu.org; Tue, 05 Sep 2017 05:15:00 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dp9wZ-0004Qu-IX\n\tfor qemu-devel@nongnu.org; Tue, 05 Sep 2017 05:14:56 -0400","from mx0a-001b2d01.pphosted.com ([148.163.156.1]:40259)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dp9wZ-0004PP-9d\n\tfor qemu-devel@nongnu.org; Tue, 05 Sep 2017 05:14:51 -0400","from pps.filterd (m0098394.ppops.net [127.0.0.1])\n\tby mx0a-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id\n\tv859E2tE025500\n\tfor ; Tue, 5 Sep 2017 05:14:50 -0400","from e06smtp14.uk.ibm.com (e06smtp14.uk.ibm.com [195.75.94.110])\n\tby mx0a-001b2d01.pphosted.com with ESMTP id 2csqt5mx8c-1\n\t(version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT)\n\tfor ; Tue, 05 Sep 2017 05:14:49 -0400","from localhost\n\tby e06smtp14.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use\n\tOnly! Violators will be prosecuted\n\tfor from ;\n\tTue, 5 Sep 2017 10:14:47 +0100","from b06cxnps3074.portsmouth.uk.ibm.com (9.149.109.194)\n\tby e06smtp14.uk.ibm.com (192.168.101.144) with IBM ESMTP SMTP\n\tGateway: Authorized Use Only! Violators will be prosecuted; \n\tTue, 5 Sep 2017 10:14:44 +0100","from d06av24.portsmouth.uk.ibm.com (mk.ibm.com [9.149.105.60])\n\tby b06cxnps3074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with\n\tESMTP id v859EhSi6357024; Tue, 5 Sep 2017 09:14:43 GMT","from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id 5E41D42041;\n\tTue, 5 Sep 2017 10:11:15 +0100 (BST)","from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id 2223C4203F;\n\tTue, 5 Sep 2017 10:11:15 +0100 (BST)","from oc7330422307.ibm.com (unknown [9.152.224.49])\n\tby d06av24.portsmouth.uk.ibm.com (Postfix) with ESMTP;\n\tTue, 5 Sep 2017 10:11:15 +0100 (BST)"],"To":"David Hildenbrand , qemu-devel@nongnu.org","References":"<20170904154316.4148-1-david@redhat.com>\n\t<20170904154316.4148-18-david@redhat.com>","From":"Christian Borntraeger ","Date":"Tue, 5 Sep 2017 11:14:43 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.0","MIME-Version":"1.0","In-Reply-To":"<20170904154316.4148-18-david@redhat.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-TM-AS-GCONF":"00","x-cbid":"17090509-0016-0000-0000-000004E8B4AF","X-IBM-AV-DETECTION":"SAVI=unused REMOTE=unused XFE=unused","x-cbparentid":"17090509-0017-0000-0000-0000282242C5","Message-Id":"","X-Proofpoint-Virus-Version":"vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-09-05_04:, , signatures=0","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n\tspamscore=0 suspectscore=0\n\tmalwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam\n\tadjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000\n\tdefinitions=main-1709050143","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 3.x [generic] [fuzzy]","X-Received-From":"148.163.156.1","Subject":"Re: [Qemu-devel] [PATCH v2 17/19] s390x: CPU hot unplug via\n\tdevice_del cannot work","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"thuth@redhat.com, cohuck@redhat.com,\n\tRichard Henderson ,\n\tAlexander Graf , Eduardo Habkost ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1763273,"web_url":"http://patchwork.ozlabs.org/comment/1763273/","msgid":"","list_archive_url":null,"date":"2017-09-05T12:01:14","subject":"Re: [Qemu-devel] [PATCH v2 17/19] s390x: CPU hot unplug via\n\tdevice_del cannot work","submitter":{"id":70402,"url":"http://patchwork.ozlabs.org/api/people/70402/","name":"David Hildenbrand","email":"david@redhat.com"},"content":"On 05.09.2017 11:14, Christian Borntraeger wrote:\n> On 09/04/2017 05:43 PM, David Hildenbrand wrote:\n>> device_del on a CPU will currently do nothing. Let's emmit an error\n>> telling that this is will never work (there is no architecture support\n>> on s390x). Error message copied from ppc.\n>>\n>> (qemu) device_del cpu1\n>> device_del cpu1\n>> CPU hot unplug not supported on this machine\n> \n> Given the fact that I get the question about unplug _every_ time when I give a presentation\n> about KVM on z, I will try to get some architecture folks look at this. Maybe we can define\n> something very simple like \"if the CPU is in the stopped state we can remove this and just\n> piggy back on the existing sclp EVENT_QUAL_CPU_CHANGE notification\".\n> \n> So maybe add \"currently\"\n\nUnfortunately it might not be that easy.\n\nWe would have to find a way that existing OS's don't break. If a guest\nOS is not prepared for CPUs to get removed, we might run into\ninconsistencies when simply deleting CPUs that are in the STOPPED state.\n\nEspecially, these CPUs would still show up in the guest as \"offline\".\nWonder what would then happen trying to \"online\" these.\n\nBut yes, I can add \"currently\".","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx06.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx06.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=david@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xmlhM0XSvz9sPs\n\tfor ;\n\tTue, 5 Sep 2017 22:02:27 +1000 (AEST)","from localhost ([::1]:58442 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dpCYj-0004vC-47\n\tfor incoming@patchwork.ozlabs.org; Tue, 05 Sep 2017 08:02:25 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:36272)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dpCY2-0004qJ-4B\n\tfor qemu-devel@nongnu.org; Tue, 05 Sep 2017 08:01:46 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dpCXs-0006XF-Kk\n\tfor qemu-devel@nongnu.org; Tue, 05 Sep 2017 08:01:42 -0400","from mx1.redhat.com ([209.132.183.28]:46666)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dpCXs-0006Wx-F5\n\tfor qemu-devel@nongnu.org; Tue, 05 Sep 2017 08:01:32 -0400","from smtp.corp.redhat.com\n\t(int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 75C7A3E2AA;\n\tTue, 5 Sep 2017 12:01:31 +0000 (UTC)","from [10.36.118.35] (unknown [10.36.118.35])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 533D87FB8D;\n\tTue, 5 Sep 2017 12:01:15 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 75C7A3E2AA","To":"Christian Borntraeger , qemu-devel@nongnu.org","References":"<20170904154316.4148-1-david@redhat.com>\n\t<20170904154316.4148-18-david@redhat.com>\n\t","From":"David Hildenbrand ","Organization":"Red Hat GmbH","Message-ID":"","Date":"Tue, 5 Sep 2017 14:01:14 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.13","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.30]);\n\tTue, 05 Sep 2017 12:01:31 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v2 17/19] s390x: CPU hot unplug via\n\tdevice_del cannot work","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"thuth@redhat.com, cohuck@redhat.com,\n\tRichard Henderson ,\n\tAlexander Graf , Eduardo Habkost ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1763281,"web_url":"http://patchwork.ozlabs.org/comment/1763281/","msgid":"<41bbb466-4b9d-1c7e-f622-38a867b1db65@de.ibm.com>","list_archive_url":null,"date":"2017-09-05T12:14:21","subject":"Re: [Qemu-devel] [PATCH v2 17/19] s390x: CPU hot unplug via\n\tdevice_del cannot work","submitter":{"id":590,"url":"http://patchwork.ozlabs.org/api/people/590/","name":"Christian Borntraeger","email":"borntraeger@de.ibm.com"},"content":"On 09/05/2017 02:01 PM, David Hildenbrand wrote:\n> On 05.09.2017 11:14, Christian Borntraeger wrote:\n>> On 09/04/2017 05:43 PM, David Hildenbrand wrote:\n>>> device_del on a CPU will currently do nothing. Let's emmit an error\n>>> telling that this is will never work (there is no architecture support\n>>> on s390x). Error message copied from ppc.\n>>>\n>>> (qemu) device_del cpu1\n>>> device_del cpu1\n>>> CPU hot unplug not supported on this machine\n>>\n>> Given the fact that I get the question about unplug _every_ time when I give a presentation\n>> about KVM on z, I will try to get some architecture folks look at this. Maybe we can define\n>> something very simple like \"if the CPU is in the stopped state we can remove this and just\n>> piggy back on the existing sclp EVENT_QUAL_CPU_CHANGE notification\".\n>>\n>> So maybe add \"currently\"\n> \n> Unfortunately it might not be that easy.\n> \n> We would have to find a way that existing OS's don't break. If a guest\n> OS is not prepared for CPUs to get removed, we might run into\n> inconsistencies when simply deleting CPUs that are in the STOPPED state.\n\nYes, this needs to be validated across all things.\n> \n> Especially, these CPUs would still show up in the guest as \"offline\".\n> Wonder what would then happen trying to \"online\" these.\n\nThe main use case seems to be, that the admin does not want to allow a guest\nto online back a guest CPU if it was taken away from the configuration. \nSo maybe we could simply fail a SIGP START for those.\n\nOr we might go one level below and only allow an unplug if the CPU is in\nthe deconfigured state and we would then have to forbid the configuration\nstep. Right now SCLP_CMDW_(DE)CONFIGURE_CPU seems to be unimplemented in\nQEMU.\n\nAnyway, we need some architecture agreement here first (something that is\nalso ok with LPAR and z/VM).\n\n\n> But yes, I can add \"currently\".\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xmlz2235Mz9sRV\n\tfor ;\n\tTue, 5 Sep 2017 22:15:09 +1000 (AEST)","from localhost ([::1]:58596 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dpCl0-0000wY-Hq\n\tfor incoming@patchwork.ozlabs.org; Tue, 05 Sep 2017 08:15:06 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:43114)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dpCkU-0000vt-If\n\tfor qemu-devel@nongnu.org; Tue, 05 Sep 2017 08:14:39 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dpCkN-0006gN-SC\n\tfor qemu-devel@nongnu.org; Tue, 05 Sep 2017 08:14:34 -0400","from mx0b-001b2d01.pphosted.com ([148.163.158.5]:42058\n\thelo=mx0a-001b2d01.pphosted.com)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dpCkN-0006fs-L9\n\tfor qemu-devel@nongnu.org; Tue, 05 Sep 2017 08:14:27 -0400","from pps.filterd (m0098414.ppops.net [127.0.0.1])\n\tby mx0b-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id\n\tv85CDbUu088488\n\tfor ; Tue, 5 Sep 2017 08:14:26 -0400","from e06smtp13.uk.ibm.com (e06smtp13.uk.ibm.com [195.75.94.109])\n\tby mx0b-001b2d01.pphosted.com with ESMTP id 2csrt0hpt8-1\n\t(version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT)\n\tfor ; Tue, 05 Sep 2017 08:14:26 -0400","from localhost\n\tby e06smtp13.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use\n\tOnly! Violators will be prosecuted\n\tfor from ;\n\tTue, 5 Sep 2017 13:14:24 +0100","from b06cxnps4076.portsmouth.uk.ibm.com (9.149.109.198)\n\tby e06smtp13.uk.ibm.com (192.168.101.143) with IBM ESMTP SMTP\n\tGateway: Authorized Use Only! Violators will be prosecuted; \n\tTue, 5 Sep 2017 13:14:22 +0100","from d06av24.portsmouth.uk.ibm.com (d06av24.portsmouth.uk.ibm.com\n\t[9.149.105.60])\n\tby b06cxnps4076.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with\n\tESMTP id v85CEM0w19726590; Tue, 5 Sep 2017 12:14:22 GMT","from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id 088E74203F;\n\tTue, 5 Sep 2017 13:10:54 +0100 (BST)","from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id C78AA42042;\n\tTue, 5 Sep 2017 13:10:53 +0100 (BST)","from oc7330422307.ibm.com (unknown [9.152.224.49])\n\tby d06av24.portsmouth.uk.ibm.com (Postfix) with ESMTP;\n\tTue, 5 Sep 2017 13:10:53 +0100 (BST)"],"To":"David Hildenbrand , qemu-devel@nongnu.org","References":"<20170904154316.4148-1-david@redhat.com>\n\t<20170904154316.4148-18-david@redhat.com>\n\t\n\t","From":"Christian Borntraeger ","Date":"Tue, 5 Sep 2017 14:14:21 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.0","MIME-Version":"1.0","In-Reply-To":"","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-TM-AS-GCONF":"00","x-cbid":"17090512-0012-0000-0000-00000574BC03","X-IBM-AV-DETECTION":"SAVI=unused REMOTE=unused XFE=unused","x-cbparentid":"17090512-0013-0000-0000-000018ECF285","Message-Id":"<41bbb466-4b9d-1c7e-f622-38a867b1db65@de.ibm.com>","X-Proofpoint-Virus-Version":"vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-09-05_06:, , signatures=0","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n\tspamscore=0 suspectscore=0\n\tmalwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam\n\tadjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000\n\tdefinitions=main-1709050187","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 3.x [generic] [fuzzy]","X-Received-From":"148.163.158.5","Subject":"Re: [Qemu-devel] [PATCH v2 17/19] s390x: CPU hot unplug via\n\tdevice_del cannot work","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"thuth@redhat.com, cohuck@redhat.com,\n\tRichard Henderson ,\n\tAlexander Graf , Eduardo Habkost ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1763327,"web_url":"http://patchwork.ozlabs.org/comment/1763327/","msgid":"<20170905145417.05fa0fae.cohuck@redhat.com>","list_archive_url":null,"date":"2017-09-05T12:54:17","subject":"Re: [Qemu-devel] [PATCH v2 17/19] s390x: CPU hot unplug via\n\tdevice_del cannot work","submitter":{"id":71914,"url":"http://patchwork.ozlabs.org/api/people/71914/","name":"Cornelia Huck","email":"cohuck@redhat.com"},"content":"On Tue, 5 Sep 2017 14:14:21 +0200\nChristian Borntraeger wrote:\n\n> On 09/05/2017 02:01 PM, David Hildenbrand wrote:\n> > On 05.09.2017 11:14, Christian Borntraeger wrote: \n> >> On 09/04/2017 05:43 PM, David Hildenbrand wrote: \n> >>> device_del on a CPU will currently do nothing. Let's emmit an error\n> >>> telling that this is will never work (there is no architecture support\n> >>> on s390x). Error message copied from ppc.\n> >>>\n> >>> (qemu) device_del cpu1\n> >>> device_del cpu1\n> >>> CPU hot unplug not supported on this machine \n> >>\n> >> Given the fact that I get the question about unplug _every_ time when I give a presentation\n> >> about KVM on z, I will try to get some architecture folks look at this. Maybe we can define\n> >> something very simple like \"if the CPU is in the stopped state we can remove this and just\n> >> piggy back on the existing sclp EVENT_QUAL_CPU_CHANGE notification\".\n> >>\n> >> So maybe add \"currently\" \n> > \n> > Unfortunately it might not be that easy.\n> > \n> > We would have to find a way that existing OS's don't break. If a guest\n> > OS is not prepared for CPUs to get removed, we might run into\n> > inconsistencies when simply deleting CPUs that are in the STOPPED state. \n> \n> Yes, this needs to be validated across all things.\n> > \n> > Especially, these CPUs would still show up in the guest as \"offline\".\n> > Wonder what would then happen trying to \"online\" these. \n> \n> The main use case seems to be, that the admin does not want to allow a guest\n> to online back a guest CPU if it was taken away from the configuration. \n> So maybe we could simply fail a SIGP START for those.\n> \n> Or we might go one level below and only allow an unplug if the CPU is in\n> the deconfigured state and we would then have to forbid the configuration\n> step.\n\nHaving the cpu in the unconfigured state as a requirement also makes\nthis less likely to break for older OSs, I guess.\n\n> Right now SCLP_CMDW_(DE)CONFIGURE_CPU seems to be unimplemented in\n> QEMU.\n\nSounds like something we'd like to have in the future?\n\n(Btw, what does cpuplugd trigger? Offline/online or\ndeconfigure/configure?)\n\n> \n> Anyway, we need some architecture agreement here first (something that is\n> also ok with LPAR and z/VM).\n\nCertainly.\n\n> > But yes, I can add \"currently\".\n\nYes, that makes sense.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx04.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx04.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=cohuck@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xmms1152kz9t16\n\tfor ;\n\tTue, 5 Sep 2017 22:55:01 +1000 (AEST)","from localhost ([::1]:58770 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dpDNb-0005h6-At\n\tfor incoming@patchwork.ozlabs.org; Tue, 05 Sep 2017 08:54:59 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:36487)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dpDNB-0005gn-Pi\n\tfor qemu-devel@nongnu.org; Tue, 05 Sep 2017 08:54:38 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dpDN2-0002RE-6e\n\tfor qemu-devel@nongnu.org; Tue, 05 Sep 2017 08:54:33 -0400","from mx1.redhat.com ([209.132.183.28]:37860)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dpDN1-0002Q1-UG\n\tfor qemu-devel@nongnu.org; Tue, 05 Sep 2017 08:54:24 -0400","from smtp.corp.redhat.com\n\t(int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id E935915E922;\n\tTue, 5 Sep 2017 12:54:22 +0000 (UTC)","from gondolin (dhcp-192-215.str.redhat.com [10.33.192.215])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 83AF380C63;\n\tTue, 5 Sep 2017 12:54:19 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com E935915E922","Date":"Tue, 5 Sep 2017 14:54:17 +0200","From":"Cornelia Huck ","To":"Christian Borntraeger ","Message-ID":"<20170905145417.05fa0fae.cohuck@redhat.com>","In-Reply-To":"<41bbb466-4b9d-1c7e-f622-38a867b1db65@de.ibm.com>","References":"<20170904154316.4148-1-david@redhat.com>\n\t<20170904154316.4148-18-david@redhat.com>\n\t\n\t\n\t<41bbb466-4b9d-1c7e-f622-38a867b1db65@de.ibm.com>","Organization":"Red Hat GmbH","MIME-Version":"1.0","Content-Type":"text/plain; charset=US-ASCII","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.14","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.28]);\n\tTue, 05 Sep 2017 12:54:23 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v2 17/19] s390x: CPU hot unplug via\n\tdevice_del cannot work","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"thuth@redhat.com, Eduardo Habkost ,\n\tDavid Hildenbrand ,\n\tRichard Henderson ,\n\tAlexander Graf , qemu-devel@nongnu.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1763347,"web_url":"http://patchwork.ozlabs.org/comment/1763347/","msgid":"","list_archive_url":null,"date":"2017-09-05T13:09:51","subject":"Re: [Qemu-devel] [PATCH v2 17/19] s390x: CPU hot unplug via\n\tdevice_del cannot work","submitter":{"id":590,"url":"http://patchwork.ozlabs.org/api/people/590/","name":"Christian Borntraeger","email":"borntraeger@de.ibm.com"},"content":"On 09/05/2017 02:54 PM, Cornelia Huck wrote:\n[...]\n> Having the cpu in the unconfigured state as a requirement also makes\n> this less likely to break for older OSs, I guess.\n> \n>> Right now SCLP_CMDW_(DE)CONFIGURE_CPU seems to be unimplemented in\n>> QEMU.\n> \n> Sounds like something we'd like to have in the future?\n> \n> (Btw, what does cpuplugd trigger? Offline/online or\n> deconfigure/configure?)\n\noffline/online via sigp stop/start. When we hotplug we already\nprovide the new cpu in the configured state (like z/VM).","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=208.118.235.17; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [208.118.235.17])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xmnCB5kMzz9t24\n\tfor ;\n\tTue, 5 Sep 2017 23:10:46 +1000 (AEST)","from localhost ([::1]:58842 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dpDcq-00051E-F5\n\tfor incoming@patchwork.ozlabs.org; Tue, 05 Sep 2017 09:10:44 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:42014)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dpDcI-0004x2-3g\n\tfor qemu-devel@nongnu.org; Tue, 05 Sep 2017 09:10:14 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dpDc8-00068x-P6\n\tfor qemu-devel@nongnu.org; Tue, 05 Sep 2017 09:10:10 -0400","from mx0a-001b2d01.pphosted.com ([148.163.156.1]:55722)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dpDc8-000680-FG\n\tfor qemu-devel@nongnu.org; Tue, 05 Sep 2017 09:10:00 -0400","from pps.filterd (m0098396.ppops.net [127.0.0.1])\n\tby mx0a-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id\n\tv85D90Z2096666\n\tfor ; Tue, 5 Sep 2017 09:09:59 -0400","from e06smtp11.uk.ibm.com (e06smtp11.uk.ibm.com [195.75.94.107])\n\tby mx0a-001b2d01.pphosted.com with ESMTP id 2csv9nh15s-1\n\t(version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT)\n\tfor ; Tue, 05 Sep 2017 09:09:58 -0400","from localhost\n\tby e06smtp11.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use\n\tOnly! Violators will be prosecuted\n\tfor from ;\n\tTue, 5 Sep 2017 14:09:55 +0100","from b06cxnps4074.portsmouth.uk.ibm.com (9.149.109.196)\n\tby e06smtp11.uk.ibm.com (192.168.101.141) with IBM ESMTP SMTP\n\tGateway: Authorized Use Only! Violators will be prosecuted; \n\tTue, 5 Sep 2017 14:09:52 +0100","from d06av21.portsmouth.uk.ibm.com (d06av21.portsmouth.uk.ibm.com\n\t[9.149.105.232])\n\tby b06cxnps4074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with\n\tESMTP id v85D9qkc21889260; Tue, 5 Sep 2017 13:09:52 GMT","from d06av21.portsmouth.uk.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id 255CD5203F;\n\tTue, 5 Sep 2017 13:05:11 +0100 (BST)","from oc7330422307.ibm.com (unknown [9.152.224.49])\n\tby d06av21.portsmouth.uk.ibm.com (Postfix) with ESMTP id E16E552047; \n\tTue, 5 Sep 2017 13:05:10 +0100 (BST)"],"To":"Cornelia Huck ","References":"<20170904154316.4148-1-david@redhat.com>\n\t<20170904154316.4148-18-david@redhat.com>\n\t\n\t\n\t<41bbb466-4b9d-1c7e-f622-38a867b1db65@de.ibm.com>\n\t<20170905145417.05fa0fae.cohuck@redhat.com>","From":"Christian Borntraeger ","Date":"Tue, 5 Sep 2017 15:09:51 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.0","MIME-Version":"1.0","In-Reply-To":"<20170905145417.05fa0fae.cohuck@redhat.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-TM-AS-GCONF":"00","x-cbid":"17090513-0040-0000-0000-000003F5B6C7","X-IBM-AV-DETECTION":"SAVI=unused REMOTE=unused XFE=unused","x-cbparentid":"17090513-0041-0000-0000-000020962D94","Message-Id":"","X-Proofpoint-Virus-Version":"vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-09-05_07:, , signatures=0","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n\tspamscore=0 suspectscore=0\n\tmalwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam\n\tadjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000\n\tdefinitions=main-1709050201","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 3.x [generic] [fuzzy]","X-Received-From":"148.163.156.1","Subject":"Re: [Qemu-devel] [PATCH v2 17/19] s390x: CPU hot unplug via\n\tdevice_del cannot work","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"thuth@redhat.com, Eduardo Habkost ,\n\tDavid Hildenbrand ,\n\tRichard Henderson ,\n\tAlexander Graf , qemu-devel@nongnu.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1764299,"web_url":"http://patchwork.ozlabs.org/comment/1764299/","msgid":"<40d23c4e-2761-24ae-5f5a-3db9b478ffd2@linux.vnet.ibm.com>","list_archive_url":null,"date":"2017-09-06T18:13:34","subject":"Re: [Qemu-devel] [PATCH v2 17/19] s390x: CPU hot unplug via\n\tdevice_del cannot work","submitter":{"id":26065,"url":"http://patchwork.ozlabs.org/api/people/26065/","name":"Matthew Rosato","email":"mjrosato@linux.vnet.ibm.com"},"content":"On 09/04/2017 11:43 AM, David Hildenbrand wrote:\n> device_del on a CPU will currently do nothing. Let's emmit an error\n> telling that this is will never work (there is no architecture support\n> on s390x). Error message copied from ppc.\n> \n> (qemu) device_del cpu1\n> device_del cpu1\n> CPU hot unplug not supported on this machine\n> \n> Signed-off-by: David Hildenbrand \n\nArchitecture discussions aside, this code will work as-is to prevent CPU\nunplug. Add \"currently\" as Christian suggests and:\n\nReviewed-by: Matthew Rosato \n\n> ---\n> hw/s390x/s390-virtio-ccw.c | 10 ++++++++++\n> 1 file changed, 10 insertions(+)\n> \n> diff --git a/hw/s390x/s390-virtio-ccw.c b/hw/s390x/s390-virtio-ccw.c\n> index 22a8a1b45d..dd149567bb 100644\n> --- a/hw/s390x/s390-virtio-ccw.c\n> +++ b/hw/s390x/s390-virtio-ccw.c\n> @@ -338,6 +338,15 @@ static void s390_machine_device_plug(HotplugHandler *hotplug_dev,\n> }\n> }\n> \n> +static void s390_machine_device_unplug_request(HotplugHandler *hotplug_dev,\n> + DeviceState *dev, Error **errp)\n> +{\n> + if (object_dynamic_cast(OBJECT(dev), TYPE_CPU)) {\n> + error_setg(errp, \"CPU hot unplug not supported on this machine\");\n> + return;\n> + }\n> +}\n> +\n> static HotplugHandler *s390_get_hotplug_handler(MachineState *machine,\n> DeviceState *dev)\n> {\n> @@ -387,6 +396,7 @@ static void ccw_machine_class_init(ObjectClass *oc, void *data)\n> mc->max_cpus = 248;\n> mc->get_hotplug_handler = s390_get_hotplug_handler;\n> hc->plug = s390_machine_device_plug;\n> + hc->unplug_request = s390_machine_device_unplug_request;\n> nc->nmi_monitor_handler = s390_nmi;\n> }\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xnWth5wY4z9rxl\n\tfor ;\n\tThu, 7 Sep 2017 04:14:04 +1000 (AEST)","from localhost ([::1]:37388 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dpepu-0001UI-WC\n\tfor incoming@patchwork.ozlabs.org; Wed, 06 Sep 2017 14:14:03 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:48373)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dpepb-0001Tw-UU\n\tfor qemu-devel@nongnu.org; Wed, 06 Sep 2017 14:13:44 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dpepX-0003er-UE\n\tfor qemu-devel@nongnu.org; Wed, 06 Sep 2017 14:13:43 -0400","from mx0b-001b2d01.pphosted.com ([148.163.158.5]:54225\n\thelo=mx0a-001b2d01.pphosted.com)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dpepX-0003ed-O8\n\tfor qemu-devel@nongnu.org; Wed, 06 Sep 2017 14:13:39 -0400","from pps.filterd (m0098417.ppops.net [127.0.0.1])\n\tby mx0a-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id\n\tv86I8m2U062807\n\tfor ; Wed, 6 Sep 2017 14:13:39 -0400","from e19.ny.us.ibm.com (e19.ny.us.ibm.com [129.33.205.209])\n\tby mx0a-001b2d01.pphosted.com with ESMTP id 2cth6xpbw3-1\n\t(version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT)\n\tfor ; Wed, 06 Sep 2017 14:13:38 -0400","from localhost\n\tby e19.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use\n\tOnly! Violators will be prosecuted\n\tfor from ;\n\tWed, 6 Sep 2017 14:13:38 -0400","from b01cxnp22036.gho.pok.ibm.com (9.57.198.26)\n\tby e19.ny.us.ibm.com (146.89.104.206) with IBM ESMTP SMTP Gateway:\n\tAuthorized Use Only! Violators will be prosecuted; \n\tWed, 6 Sep 2017 14:13:35 -0400","from b01ledav002.gho.pok.ibm.com (b01ledav002.gho.pok.ibm.com\n\t[9.57.199.107])\n\tby b01cxnp22036.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP\n\tid v86IDZ4f31522876; Wed, 6 Sep 2017 18:13:35 GMT","from b01ledav002.gho.pok.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id B9F37124049;\n\tWed, 6 Sep 2017 14:10:53 -0400 (EDT)","from [9.60.84.204] (unknown [9.60.84.204])\n\tby b01ledav002.gho.pok.ibm.com (Postfix) with ESMTP id 804B612403F;\n\tWed, 6 Sep 2017 14:10:53 -0400 (EDT)"],"To":"David Hildenbrand , qemu-devel@nongnu.org","References":"<20170904154316.4148-1-david@redhat.com>\n\t<20170904154316.4148-18-david@redhat.com>","From":"Matthew Rosato ","Date":"Wed, 6 Sep 2017 14:13:34 -0400","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<20170904154316.4148-18-david@redhat.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-TM-AS-GCONF":"00","x-cbid":"17090618-0056-0000-0000-000003C4029C","X-IBM-SpamModules-Scores":"","X-IBM-SpamModules-Versions":"BY=3.00007678; HX=3.00000241; KW=3.00000007;\n\tPH=3.00000004; SC=3.00000226; SDB=6.00913181; UDB=6.00458298;\n\tIPR=6.00693444; \n\tBA=6.00005574; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009;\n\tZB=6.00000000; \n\tZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00017036;\n\tXFM=3.00000015; UTC=2017-09-06 18:13:38","X-IBM-AV-DETECTION":"SAVI=unused REMOTE=unused XFE=unused","x-cbparentid":"17090618-0057-0000-0000-000007FB0290","Message-Id":"<40d23c4e-2761-24ae-5f5a-3db9b478ffd2@linux.vnet.ibm.com>","X-Proofpoint-Virus-Version":"vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-09-06_06:, , signatures=0","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n\tspamscore=0 suspectscore=0\n\tmalwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam\n\tadjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000\n\tdefinitions=main-1709060257","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 3.x [generic] [fuzzy]","X-Received-From":"148.163.158.5","Subject":"Re: [Qemu-devel] [PATCH v2 17/19] s390x: CPU hot unplug via\n\tdevice_del cannot work","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"thuth@redhat.com, Eduardo Habkost ,\n\tcohuck@redhat.com, Richard Henderson ,\n\tAlexander Graf , borntraeger@de.ibm.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]