[{"id":1763302,"web_url":"http://patchwork.ozlabs.org/comment/1763302/","msgid":"<20170905143801.1dc39cb1.cohuck@redhat.com>","list_archive_url":null,"date":"2017-09-05T12:38:01","subject":"Re: [Qemu-devel] [PATCH v2 08/19] s390x: move sclp_service_call()\n\tto interrupt.c","submitter":{"id":71914,"url":"http://patchwork.ozlabs.org/api/people/71914/","name":"Cornelia Huck","email":"cohuck@redhat.com"},"content":"On Mon, 4 Sep 2017 17:43:05 +0200\nDavid Hildenbrand wrote:\n\n> Fix up includes and rename it to s390x_*.\n\nI'm not quite sure whether that is the right direction: servc is just an\ninstruction that does something and then happens to also generate an\ninterrupt on conclusion. I'll think a bit more about it.\n\n> cpu.h is now free of externally implemented functions.\n> \n> Signed-off-by: David Hildenbrand \n> ---\n> hw/s390x/sclp.c | 51 +---------------------------------------------\n> include/hw/s390x/sclp.h | 1 +\n> target/s390x/cpu.h | 5 +----\n> target/s390x/interrupt.c | 49 ++++++++++++++++++++++++++++++++++++++++++++\n> target/s390x/kvm.c | 2 +-\n> target/s390x/misc_helper.c | 2 +-\n> 6 files changed, 54 insertions(+), 56 deletions(-)","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx07.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx07.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=cohuck@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xmmVy66kJz9sRm\n\tfor ;\n\tTue, 5 Sep 2017 22:39:22 +1000 (AEST)","from localhost ([::1]:58702 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dpD8S-0003iu-W1\n\tfor incoming@patchwork.ozlabs.org; Tue, 05 Sep 2017 08:39:21 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:57538)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dpD7T-0003Rc-Lo\n\tfor qemu-devel@nongnu.org; Tue, 05 Sep 2017 08:38:29 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dpD7K-0007F3-4F\n\tfor qemu-devel@nongnu.org; Tue, 05 Sep 2017 08:38:19 -0400","from mx1.redhat.com ([209.132.183.28]:47682)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dpD7J-0007Eo-UE\n\tfor qemu-devel@nongnu.org; Tue, 05 Sep 2017 08:38:10 -0400","from smtp.corp.redhat.com\n\t(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id C4828C0578F1;\n\tTue, 5 Sep 2017 12:38:08 +0000 (UTC)","from gondolin (dhcp-192-215.str.redhat.com [10.33.192.215])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 309B1835D7;\n\tTue, 5 Sep 2017 12:38:03 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com C4828C0578F1","Date":"Tue, 5 Sep 2017 14:38:01 +0200","From":"Cornelia Huck ","To":"David Hildenbrand ","Message-ID":"<20170905143801.1dc39cb1.cohuck@redhat.com>","In-Reply-To":"<20170904154316.4148-9-david@redhat.com>","References":"<20170904154316.4148-1-david@redhat.com>\n\t<20170904154316.4148-9-david@redhat.com>","Organization":"Red Hat GmbH","MIME-Version":"1.0","Content-Type":"text/plain; charset=US-ASCII","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.12","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.31]);\n\tTue, 05 Sep 2017 12:38:08 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v2 08/19] s390x: move sclp_service_call()\n\tto interrupt.c","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"thuth@redhat.com, Eduardo Habkost ,\n\tRichard Henderson ,\n\tqemu-devel@nongnu.org, Alexander Graf ,\n\tborntraeger@de.ibm.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1763308,"web_url":"http://patchwork.ozlabs.org/comment/1763308/","msgid":"","list_archive_url":null,"date":"2017-09-05T12:42:19","subject":"Re: [Qemu-devel] [PATCH v2 08/19] s390x: move sclp_service_call()\n\tto interrupt.c","submitter":{"id":70402,"url":"http://patchwork.ozlabs.org/api/people/70402/","name":"David Hildenbrand","email":"david@redhat.com"},"content":"On 05.09.2017 14:38, Cornelia Huck wrote:\n> On Mon, 4 Sep 2017 17:43:05 +0200\n> David Hildenbrand wrote:\n> \n>> Fix up includes and rename it to s390x_*.\n> \n> I'm not quite sure whether that is the right direction: servc is just an\n> instruction that does something and then happens to also generate an\n> interrupt on conclusion. I'll think a bit more about it.\n> \n\nHaving CPU related stuff in sclp looks also wrong. Feel free to skip\nthis patch, should be unrelated to the following patches.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx10.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx10.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=david@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xmmfL4Rx6z9sRV\n\tfor ;\n\tTue, 5 Sep 2017 22:45:46 +1000 (AEST)","from localhost ([::1]:58741 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dpDEe-0000iH-Nv\n\tfor incoming@patchwork.ozlabs.org; Tue, 05 Sep 2017 08:45:44 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:59694)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dpDBU-0006sK-O8\n\tfor qemu-devel@nongnu.org; Tue, 05 Sep 2017 08:42:33 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dpDBQ-0002AM-70\n\tfor qemu-devel@nongnu.org; Tue, 05 Sep 2017 08:42:28 -0400","from mx1.redhat.com ([209.132.183.28]:59294)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dpDBQ-00029r-0y\n\tfor qemu-devel@nongnu.org; Tue, 05 Sep 2017 08:42:24 -0400","from smtp.corp.redhat.com\n\t(int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 1395F272CD;\n\tTue, 5 Sep 2017 12:42:23 +0000 (UTC)","from [10.36.118.35] (unknown [10.36.118.35])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 862B484D06;\n\tTue, 5 Sep 2017 12:42:20 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 1395F272CD","To":"Cornelia Huck ","References":"<20170904154316.4148-1-david@redhat.com>\n\t<20170904154316.4148-9-david@redhat.com>\n\t<20170905143801.1dc39cb1.cohuck@redhat.com>","From":"David Hildenbrand ","Organization":"Red Hat GmbH","Message-ID":"","Date":"Tue, 5 Sep 2017 14:42:19 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170905143801.1dc39cb1.cohuck@redhat.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.14","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.39]);\n\tTue, 05 Sep 2017 12:42:23 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v2 08/19] s390x: move sclp_service_call()\n\tto interrupt.c","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"thuth@redhat.com, Eduardo Habkost ,\n\tRichard Henderson ,\n\tqemu-devel@nongnu.org, Alexander Graf ,\n\tborntraeger@de.ibm.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1763310,"web_url":"http://patchwork.ozlabs.org/comment/1763310/","msgid":"","list_archive_url":null,"date":"2017-09-05T12:46:28","subject":"Re: [Qemu-devel] [PATCH v2 08/19] s390x: move sclp_service_call()\n\tto interrupt.c","submitter":{"id":590,"url":"http://patchwork.ozlabs.org/api/people/590/","name":"Christian Borntraeger","email":"borntraeger@de.ibm.com"},"content":"On 09/05/2017 02:42 PM, David Hildenbrand wrote:\n> On 05.09.2017 14:38, Cornelia Huck wrote:\n>> On Mon, 4 Sep 2017 17:43:05 +0200\n>> David Hildenbrand wrote:\n>>\n>>> Fix up includes and rename it to s390x_*.\n>>\n>> I'm not quite sure whether that is the right direction: servc is just an\n>> instruction that does something and then happens to also generate an\n>> interrupt on conclusion. I'll think a bit more about it.\n>>\n> \n> Having CPU related stuff in sclp looks also wrong. Feel free to skip\n> this patch, should be unrelated to the following patches.\n\nI think having the sclp instruction handler in sclp (as today) is\nthe best compromise.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xmmhG6QmMz9sRm\n\tfor ;\n\tTue, 5 Sep 2017 22:47:26 +1000 (AEST)","from localhost ([::1]:58747 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dpDGG-00021Y-VL\n\tfor incoming@patchwork.ozlabs.org; Tue, 05 Sep 2017 08:47:25 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:33625)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dpDFd-0001wN-7j\n\tfor qemu-devel@nongnu.org; Tue, 05 Sep 2017 08:46:49 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dpDFV-00053z-KX\n\tfor qemu-devel@nongnu.org; Tue, 05 Sep 2017 08:46:45 -0400","from mx0a-001b2d01.pphosted.com ([148.163.156.1]:50465)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dpDFV-00053X-Az\n\tfor qemu-devel@nongnu.org; Tue, 05 Sep 2017 08:46:37 -0400","from pps.filterd (m0098410.ppops.net [127.0.0.1])\n\tby mx0a-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id\n\tv85CieIc026025\n\tfor ; Tue, 5 Sep 2017 08:46:36 -0400","from e06smtp12.uk.ibm.com (e06smtp12.uk.ibm.com [195.75.94.108])\n\tby mx0a-001b2d01.pphosted.com with ESMTP id 2csq84s5h2-1\n\t(version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT)\n\tfor ; Tue, 05 Sep 2017 08:46:35 -0400","from localhost\n\tby e06smtp12.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use\n\tOnly! Violators will be prosecuted\n\tfor from ;\n\tTue, 5 Sep 2017 13:46:33 +0100","from b06cxnps3074.portsmouth.uk.ibm.com (9.149.109.194)\n\tby e06smtp12.uk.ibm.com (192.168.101.142) with IBM ESMTP SMTP\n\tGateway: Authorized Use Only! Violators will be prosecuted; \n\tTue, 5 Sep 2017 13:46:29 +0100","from d06av24.portsmouth.uk.ibm.com (mk.ibm.com [9.149.105.60])\n\tby b06cxnps3074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with\n\tESMTP id v85CkTLa22872158; Tue, 5 Sep 2017 12:46:29 GMT","from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id 9917742045;\n\tTue, 5 Sep 2017 13:43:00 +0100 (BST)","from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id 606D242041;\n\tTue, 5 Sep 2017 13:43:00 +0100 (BST)","from oc7330422307.ibm.com (unknown [9.152.224.49])\n\tby d06av24.portsmouth.uk.ibm.com (Postfix) with ESMTP;\n\tTue, 5 Sep 2017 13:43:00 +0100 (BST)"],"To":"David Hildenbrand , Cornelia Huck ","References":"<20170904154316.4148-1-david@redhat.com>\n\t<20170904154316.4148-9-david@redhat.com>\n\t<20170905143801.1dc39cb1.cohuck@redhat.com>\n\t","From":"Christian Borntraeger ","Date":"Tue, 5 Sep 2017 14:46:28 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.0","MIME-Version":"1.0","In-Reply-To":"","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-TM-AS-GCONF":"00","x-cbid":"17090512-0008-0000-0000-00000492B61E","X-IBM-AV-DETECTION":"SAVI=unused REMOTE=unused XFE=unused","x-cbparentid":"17090512-0009-0000-0000-00001E231B50","Message-Id":"","X-Proofpoint-Virus-Version":"vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-09-05_07:, , signatures=0","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n\tspamscore=0 suspectscore=0\n\tmalwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam\n\tadjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000\n\tdefinitions=main-1709050195","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 3.x [generic] [fuzzy]","X-Received-From":"148.163.156.1","Subject":"Re: [Qemu-devel] [PATCH v2 08/19] s390x: move sclp_service_call()\n\tto interrupt.c","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"thuth@redhat.com, Richard Henderson ,\n\tqemu-devel@nongnu.org, Eduardo Habkost ,\n\tAlexander Graf ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1763326,"web_url":"http://patchwork.ozlabs.org/comment/1763326/","msgid":"","list_archive_url":null,"date":"2017-09-05T12:52:44","subject":"Re: [Qemu-devel] [PATCH v2 08/19] s390x: move sclp_service_call()\n\tto interrupt.c","submitter":{"id":66152,"url":"http://patchwork.ozlabs.org/api/people/66152/","name":"Thomas Huth","email":"thuth@redhat.com"},"content":"On 05.09.2017 14:46, Christian Borntraeger wrote:\n> \n> \n> On 09/05/2017 02:42 PM, David Hildenbrand wrote:\n>> On 05.09.2017 14:38, Cornelia Huck wrote:\n>>> On Mon, 4 Sep 2017 17:43:05 +0200\n>>> David Hildenbrand wrote:\n>>>\n>>>> Fix up includes and rename it to s390x_*.\n>>>\n>>> I'm not quite sure whether that is the right direction: servc is just an\n>>> instruction that does something and then happens to also generate an\n>>> interrupt on conclusion. I'll think a bit more about it.\n>>>\n>>\n>> Having CPU related stuff in sclp looks also wrong. Feel free to skip\n>> this patch, should be unrelated to the following patches.\n> \n> I think having the sclp instruction handler in sclp (as today) is\n> the best compromise.\n\n+1\n\nBut maybe you could at least move the prototype to sclp.h instead?\n\n Thomas","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx10.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx10.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=thuth@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xmmqG6Y12z9t24\n\tfor ;\n\tTue, 5 Sep 2017 22:53:29 +1000 (AEST)","from localhost ([::1]:58768 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dpDM6-00056K-EM\n\tfor incoming@patchwork.ozlabs.org; Tue, 05 Sep 2017 08:53:26 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:36039)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dpDLg-000568-8L\n\tfor qemu-devel@nongnu.org; Tue, 05 Sep 2017 08:53:04 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dpDLb-0001Ps-MU\n\tfor qemu-devel@nongnu.org; Tue, 05 Sep 2017 08:53:00 -0400","from mx1.redhat.com ([209.132.183.28]:48752)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dpDLb-0001Oc-H0\n\tfor qemu-devel@nongnu.org; Tue, 05 Sep 2017 08:52:55 -0400","from smtp.corp.redhat.com\n\t(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 86EF65114F;\n\tTue, 5 Sep 2017 12:52:53 +0000 (UTC)","from [10.36.116.114] (ovpn-116-114.ams2.redhat.com [10.36.116.114])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id 3BBC3835C4;\n\tTue, 5 Sep 2017 12:52:46 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 86EF65114F","To":"Christian Borntraeger ,\n\tDavid Hildenbrand , Cornelia Huck ","References":"<20170904154316.4148-1-david@redhat.com>\n\t<20170904154316.4148-9-david@redhat.com>\n\t<20170905143801.1dc39cb1.cohuck@redhat.com>\n\t\n\t","From":"Thomas Huth ","Message-ID":"","Date":"Tue, 5 Sep 2017 14:52:44 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.12","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.39]);\n\tTue, 05 Sep 2017 12:52:53 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v2 08/19] s390x: move sclp_service_call()\n\tto interrupt.c","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Alexander Graf ,\n\tRichard Henderson ,\n\tqemu-devel@nongnu.org, Eduardo Habkost ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1763330,"web_url":"http://patchwork.ozlabs.org/comment/1763330/","msgid":"<20170905145553.64def7f0.cohuck@redhat.com>","list_archive_url":null,"date":"2017-09-05T12:55:53","subject":"Re: [Qemu-devel] [PATCH v2 08/19] s390x: move sclp_service_call()\n\tto interrupt.c","submitter":{"id":71914,"url":"http://patchwork.ozlabs.org/api/people/71914/","name":"Cornelia Huck","email":"cohuck@redhat.com"},"content":"On Tue, 5 Sep 2017 14:52:44 +0200\nThomas Huth wrote:\n\n> On 05.09.2017 14:46, Christian Borntraeger wrote:\n> > \n> > \n> > On 09/05/2017 02:42 PM, David Hildenbrand wrote: \n> >> On 05.09.2017 14:38, Cornelia Huck wrote: \n> >>> On Mon, 4 Sep 2017 17:43:05 +0200\n> >>> David Hildenbrand wrote:\n> >>> \n> >>>> Fix up includes and rename it to s390x_*. \n> >>>\n> >>> I'm not quite sure whether that is the right direction: servc is just an\n> >>> instruction that does something and then happens to also generate an\n> >>> interrupt on conclusion. I'll think a bit more about it.\n> >>> \n> >>\n> >> Having CPU related stuff in sclp looks also wrong. Feel free to skip\n> >> this patch, should be unrelated to the following patches. \n> > \n> > I think having the sclp instruction handler in sclp (as today) is\n> > the best compromise. \n> \n> +1\n> \n> But maybe you could at least move the prototype to sclp.h instead?\n\nThat would be a good compromise.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx03.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx03.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=cohuck@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xmmtx6j13z9t1t\n\tfor ;\n\tTue, 5 Sep 2017 22:56:41 +1000 (AEST)","from localhost ([::1]:58777 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dpDPE-0006Zk-3H\n\tfor incoming@patchwork.ozlabs.org; Tue, 05 Sep 2017 08:56:40 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:37152)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dpDOp-0006ZJ-7Z\n\tfor qemu-devel@nongnu.org; Tue, 05 Sep 2017 08:56:19 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dpDOk-0003tA-Jn\n\tfor qemu-devel@nongnu.org; Tue, 05 Sep 2017 08:56:15 -0400","from mx1.redhat.com ([209.132.183.28]:44704)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dpDOk-0003sb-D5\n\tfor qemu-devel@nongnu.org; Tue, 05 Sep 2017 08:56:10 -0400","from smtp.corp.redhat.com\n\t(int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 1745B7571C;\n\tTue, 5 Sep 2017 12:56:09 +0000 (UTC)","from gondolin (dhcp-192-215.str.redhat.com [10.33.192.215])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id D416E80C75;\n\tTue, 5 Sep 2017 12:55:55 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 1745B7571C","Date":"Tue, 5 Sep 2017 14:55:53 +0200","From":"Cornelia Huck ","To":"Thomas Huth ","Message-ID":"<20170905145553.64def7f0.cohuck@redhat.com>","In-Reply-To":"","References":"<20170904154316.4148-1-david@redhat.com>\n\t<20170904154316.4148-9-david@redhat.com>\n\t<20170905143801.1dc39cb1.cohuck@redhat.com>\n\t\n\t\n\t","Organization":"Red Hat GmbH","MIME-Version":"1.0","Content-Type":"text/plain; charset=US-ASCII","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.14","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.27]);\n\tTue, 05 Sep 2017 12:56:09 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v2 08/19] s390x: move sclp_service_call()\n\tto interrupt.c","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Eduardo Habkost ,\n\tDavid Hildenbrand , \n\tRichard Henderson ,\n\tAlexander Graf , qemu-devel@nongnu.org,\n\tChristian Borntraeger ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]