[{"id":1764518,"web_url":"http://patchwork.ozlabs.org/comment/1764518/","msgid":"<6742b40c-7cec-fc54-a274-e25fc25eb86b@redhat.com>","list_archive_url":null,"date":"2017-09-07T05:59:56","subject":"Re: [Qemu-devel] [PATCH v2 09/19] target/s390x: use\n\ttrigger_pgm_exception() in s390_cpu_handle_mmu_fault()","submitter":{"id":66152,"url":"http://patchwork.ozlabs.org/api/people/66152/","name":"Thomas Huth","email":"thuth@redhat.com"},"content":"On 04.09.2017 17:43, David Hildenbrand wrote:\n> This looks cleaner. linux-user will not use the ilen field, so setting\n> it doesn't do any harm.\n> \n> Signed-off-by: David Hildenbrand \n> ---\n> target/s390x/excp_helper.c | 3 +--\n> 1 file changed, 1 insertion(+), 2 deletions(-)\n> \n> diff --git a/target/s390x/excp_helper.c b/target/s390x/excp_helper.c\n> index 361f970db3..14d3160e92 100644\n> --- a/target/s390x/excp_helper.c\n> +++ b/target/s390x/excp_helper.c\n> @@ -59,8 +59,7 @@ int s390_cpu_handle_mmu_fault(CPUState *cs, vaddr address,\n> {\n> S390CPU *cpu = S390_CPU(cs);\n> \n> - cs->exception_index = EXCP_PGM;\n> - cpu->env.int_pgm_code = PGM_ADDRESSING;\n> + trigger_pgm_exception(&cpu->env, PGM_ADDRESSING, ILEN_AUTO);\n> /* On real machines this value is dropped into LowMem. Since this\n> is userland, simply put this someplace that cpu_loop can find it. */\n> cpu->env.__excp_addr = address;\n> \n\nReviewed-by: Thomas Huth ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx08.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx08.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=thuth@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xnqZ52Fvvz9s0Z\n\tfor ;\n\tThu, 7 Sep 2017 16:00:45 +1000 (AEST)","from localhost ([::1]:38930 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dpprn-0005Oy-G0\n\tfor incoming@patchwork.ozlabs.org; Thu, 07 Sep 2017 02:00:43 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:38896)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dpprL-0005Mu-N3\n\tfor qemu-devel@nongnu.org; Thu, 07 Sep 2017 02:00:21 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dpprE-0003R2-Ac\n\tfor qemu-devel@nongnu.org; Thu, 07 Sep 2017 02:00:15 -0400","from mx1.redhat.com ([209.132.183.28]:43278)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dpprE-0003Qm-4u\n\tfor qemu-devel@nongnu.org; Thu, 07 Sep 2017 02:00:08 -0400","from smtp.corp.redhat.com\n\t(int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id E4979C0587E0;\n\tThu, 7 Sep 2017 06:00:06 +0000 (UTC)","from [10.36.116.66] (ovpn-116-66.ams2.redhat.com [10.36.116.66])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id 4926A7F5BC;\n\tThu, 7 Sep 2017 05:59:58 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com E4979C0587E0","To":"David Hildenbrand , qemu-devel@nongnu.org","References":"<20170904154316.4148-1-david@redhat.com>\n\t<20170904154316.4148-10-david@redhat.com>","From":"Thomas Huth ","Message-ID":"<6742b40c-7cec-fc54-a274-e25fc25eb86b@redhat.com>","Date":"Thu, 7 Sep 2017 07:59:56 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170904154316.4148-10-david@redhat.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.13","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.32]);\n\tThu, 07 Sep 2017 06:00:07 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v2 09/19] target/s390x: use\n\ttrigger_pgm_exception() in s390_cpu_handle_mmu_fault()","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"borntraeger@de.ibm.com, cohuck@redhat.com,\n\tRichard Henderson ,\n\tAlexander Graf , Eduardo Habkost ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]