[{"id":1764303,"web_url":"http://patchwork.ozlabs.org/comment/1764303/","msgid":"<2c620927-0406-2fc1-895c-09ffc2e44a4e@linux.vnet.ibm.com>","list_archive_url":null,"date":"2017-09-06T18:16:34","subject":"Re: [Qemu-devel] [PATCH v2 11/19] s390x: allow only 1 CPU with TCG","submitter":{"id":26065,"url":"http://patchwork.ozlabs.org/api/people/26065/","name":"Matthew Rosato","email":"mjrosato@linux.vnet.ibm.com"},"content":"On 09/04/2017 11:43 AM, David Hildenbrand wrote:\n> Specifying more than 1 CPU (e.g. -smp 5) leads to SIGP errors (the\n> guest tries to bring these CPUs up but fails), because we don't support\n> multiple CPUs on s390x under TCG.\n> \n> Let's bail out if more than 1 is specified, so we don't raise people's\n> hope. Make it a define, so we can easily bump it up later.\n> \n> Signed-off-by: David Hildenbrand \n> ---\n\nMakes sense. Ran the described environment without this patch (errors)\nand again with this patch (graceful exit w/ message).\n\nTested-by: Matthew Rosato \n\n> hw/s390x/s390-virtio-ccw.c | 7 +++++++\n> target/s390x/cpu.h | 2 ++\n> 2 files changed, 9 insertions(+)\n> \n> diff --git a/hw/s390x/s390-virtio-ccw.c b/hw/s390x/s390-virtio-ccw.c\n> index f67b4b5d58..f7ca20d77a 100644\n> --- a/hw/s390x/s390-virtio-ccw.c\n> +++ b/hw/s390x/s390-virtio-ccw.c\n> @@ -23,6 +23,7 @@\n> #include \"hw/s390x/css.h\"\n> #include \"virtio-ccw.h\"\n> #include \"qemu/config-file.h\"\n> +#include \"qemu/error-report.h\"\n> #include \"s390-pci-bus.h\"\n> #include \"hw/s390x/storage-keys.h\"\n> #include \"hw/s390x/storage-attributes.h\"\n> @@ -55,6 +56,12 @@ static void s390_init_cpus(MachineState *machine)\n> if (machine->cpu_model == NULL) {\n> machine->cpu_model = s390_default_cpu_model_name();\n> }\n> + if (tcg_enabled() && max_cpus > S390_TCG_MAX_CPUS) {\n> + error_report(\"Number of SMP CPUs requested (%d) exceeds max CPUs \"\n> + \"supported by TCG (%d) on s390x\", max_cpus,\n> + S390_TCG_MAX_CPUS);\n> + exit(1);\n> + }\n> \n> cpu_states = g_new0(S390CPU *, max_cpus);\n> \n> diff --git a/target/s390x/cpu.h b/target/s390x/cpu.h\n> index 147aceba28..dca6aa9aae 100644\n> --- a/target/s390x/cpu.h\n> +++ b/target/s390x/cpu.h\n> @@ -209,6 +209,8 @@ static inline S390CPU *s390_env_get_cpu(CPUS390XState *env)\n> \n> #define ENV_OFFSET offsetof(S390CPU, env)\n> \n> +#define S390_TCG_MAX_CPUS 1\n> +\n> #ifndef CONFIG_USER_ONLY\n> extern const struct VMStateDescription vmstate_s390_cpu;\n> #endif\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xnWyH3YN6z9t2c\n\tfor ;\n\tThu, 7 Sep 2017 04:17:10 +1000 (AEST)","from localhost ([::1]:37401 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dpesu-0002oA-1I\n\tfor incoming@patchwork.ozlabs.org; Wed, 06 Sep 2017 14:17:08 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:49144)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dpesX-0002nX-Gl\n\tfor qemu-devel@nongnu.org; Wed, 06 Sep 2017 14:16:50 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dpesT-00051r-G5\n\tfor qemu-devel@nongnu.org; Wed, 06 Sep 2017 14:16:45 -0400","from mx0b-001b2d01.pphosted.com ([148.163.158.5]:43652\n\thelo=mx0a-001b2d01.pphosted.com)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dpesT-000509-A6\n\tfor qemu-devel@nongnu.org; Wed, 06 Sep 2017 14:16:41 -0400","from pps.filterd (m0098416.ppops.net [127.0.0.1])\n\tby mx0b-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id\n\tv86IEVIl138062\n\tfor ; Wed, 6 Sep 2017 14:16:40 -0400","from e11.ny.us.ibm.com (e11.ny.us.ibm.com [129.33.205.201])\n\tby mx0b-001b2d01.pphosted.com with ESMTP id 2ctmrwf77s-1\n\t(version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT)\n\tfor ; Wed, 06 Sep 2017 14:16:40 -0400","from localhost\n\tby e11.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use\n\tOnly! Violators will be prosecuted\n\tfor from ;\n\tWed, 6 Sep 2017 14:16:40 -0400","from b01cxnp23033.gho.pok.ibm.com (9.57.198.28)\n\tby e11.ny.us.ibm.com (146.89.104.198) with IBM ESMTP SMTP Gateway:\n\tAuthorized Use Only! Violators will be prosecuted; \n\tWed, 6 Sep 2017 14:16:36 -0400","from b01ledav002.gho.pok.ibm.com (b01ledav002.gho.pok.ibm.com\n\t[9.57.199.107])\n\tby b01cxnp23033.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP\n\tid v86IGZGx59048090; Wed, 6 Sep 2017 18:16:35 GMT","from b01ledav002.gho.pok.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id 4B98812403D;\n\tWed, 6 Sep 2017 14:13:54 -0400 (EDT)","from [9.60.84.204] (unknown [9.60.84.204])\n\tby b01ledav002.gho.pok.ibm.com (Postfix) with ESMTP id 127AC124035;\n\tWed, 6 Sep 2017 14:13:54 -0400 (EDT)"],"To":"David Hildenbrand , qemu-devel@nongnu.org","References":"<20170904154316.4148-1-david@redhat.com>\n\t<20170904154316.4148-12-david@redhat.com>","From":"Matthew Rosato ","Date":"Wed, 6 Sep 2017 14:16:34 -0400","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<20170904154316.4148-12-david@redhat.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-TM-AS-GCONF":"00","x-cbid":"17090618-2213-0000-0000-000002161818","X-IBM-SpamModules-Scores":"","X-IBM-SpamModules-Versions":"BY=3.00007678; HX=3.00000241; KW=3.00000007;\n\tPH=3.00000004; SC=3.00000226; SDB=6.00913183; UDB=6.00458299;\n\tIPR=6.00693445; \n\tBA=6.00005574; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009;\n\tZB=6.00000000; \n\tZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00017036;\n\tXFM=3.00000015; UTC=2017-09-06 18:16:38","X-IBM-AV-DETECTION":"SAVI=unused REMOTE=unused XFE=unused","x-cbparentid":"17090618-2214-0000-0000-000057747326","Message-Id":"<2c620927-0406-2fc1-895c-09ffc2e44a4e@linux.vnet.ibm.com>","X-Proofpoint-Virus-Version":"vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-09-06_06:, , signatures=0","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n\tspamscore=0 suspectscore=0\n\tmalwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam\n\tadjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000\n\tdefinitions=main-1709060258","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 3.x [generic] [fuzzy]","X-Received-From":"148.163.158.5","Subject":"Re: [Qemu-devel] [PATCH v2 11/19] s390x: allow only 1 CPU with TCG","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"thuth@redhat.com, Eduardo Habkost ,\n\tcohuck@redhat.com, Richard Henderson ,\n\tAlexander Graf , borntraeger@de.ibm.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1764386,"web_url":"http://patchwork.ozlabs.org/comment/1764386/","msgid":"<6b3e9c2b-4cb7-fdf8-5f9b-ff7ebbf52d1e@linaro.org>","list_archive_url":null,"date":"2017-09-06T21:20:09","subject":"Re: [Qemu-devel] [PATCH v2 11/19] s390x: allow only 1 CPU with TCG","submitter":{"id":72104,"url":"http://patchwork.ozlabs.org/api/people/72104/","name":"Richard Henderson","email":"richard.henderson@linaro.org"},"content":"On 09/06/2017 11:16 AM, Matthew Rosato wrote:\n> On 09/04/2017 11:43 AM, David Hildenbrand wrote:\n>> Specifying more than 1 CPU (e.g. -smp 5) leads to SIGP errors (the\n>> guest tries to bring these CPUs up but fails), because we don't support\n>> multiple CPUs on s390x under TCG.\n>>\n>> Let's bail out if more than 1 is specified, so we don't raise people's\n>> hope. Make it a define, so we can easily bump it up later.\n>>\n>> Signed-off-by: David Hildenbrand \n>> ---\n> \n> Makes sense. Ran the described environment without this patch (errors)\n> and again with this patch (graceful exit w/ message).\n> \n> Tested-by: Matthew Rosato \n\nCan someone review\n\n http://patchwork.ozlabs.org/patch/760010/\n\nwhich does at least start to add the SIGP support.\n\nOnce tcg can bring up 2 cpus, I see no reason it couldn't bring up N. I don't\nsee the point of the define.\n\n\nr~","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"CoyjtyP/\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xnc2G5r2Bz9s7f\n\tfor ;\n\tThu, 7 Sep 2017 07:20:53 +1000 (AEST)","from localhost ([::1]:37816 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dphkg-0002v7-ST\n\tfor incoming@patchwork.ozlabs.org; Wed, 06 Sep 2017 17:20:50 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:35546)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dphk9-0002tg-Dn\n\tfor qemu-devel@nongnu.org; Wed, 06 Sep 2017 17:20:18 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dphk6-0003rz-9z\n\tfor qemu-devel@nongnu.org; Wed, 06 Sep 2017 17:20:17 -0400","from mail-pg0-x231.google.com ([2607:f8b0:400e:c05::231]:37525)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from )\n\tid 1dphk6-0003rO-2V\n\tfor qemu-devel@nongnu.org; Wed, 06 Sep 2017 17:20:14 -0400","by mail-pg0-x231.google.com with SMTP id d8so17314902pgt.4\n\tfor ; Wed, 06 Sep 2017 14:20:13 -0700 (PDT)","from bigtime.twiddle.net (97-126-108-236.tukw.qwest.net.\n\t[97.126.108.236]) by smtp.gmail.com with ESMTPSA id\n\tr16sm856253pfk.178.2017.09.06.14.20.11\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tWed, 06 Sep 2017 14:20:11 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;\n\th=subject:to:cc:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:content-transfer-encoding; \n\tbh=P2HC1vHP2DEb1jEvaiVegA7nakk9UwVubkDzQDCjj2o=;\n\tb=CoyjtyP/31t4SrXrgx4AQjbBnmkMWuBJTPz/kFJUAKusoCFrBdKlfP+7bZUcQuHPnq\n\tga5s0gQpklv77flrjKNI6pNgVrLJPyLA+r1fPxjd6rJq6rrrQdjoQN+aL5511tqbMpip\n\tSdjx9EMvJImMof7jb4X6oYOD+P2aFHYwWGhMU=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:cc:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=P2HC1vHP2DEb1jEvaiVegA7nakk9UwVubkDzQDCjj2o=;\n\tb=pMWhVWmnkP7ORls1n1bV8s5+bjQouBILM/SWbs5msHiRu2UDPlYezIwQDrtI6Eah3Z\n\tMSkbCYXBWJ5zU33fydOeiPM20HyGpU61kpgw77wSIwE4PCn1C7wlszyMZKg+BLGGzJCv\n\taBUA7aPUKvEMIBTcymVahY96xZMXNWzgtRYMtUn8Mr4rF1f4oqEhrqunhq9LONwNWgZI\n\tu9wNtL03BS9U8HS8GExzDS85QjAItZnGqr4P04vB7heuUKZ0noT+xREuorZY0G4O/eqM\n\tRpIRCEHSLsc4RYc/ItzhidF8F3SJiksYFRCy2X7cA6Cx1CPybhm4Wmrv3auAP3iEy4Ox\n\tLARA==","X-Gm-Message-State":"AHPjjUhXjlQ6Q+hn4j555wfnKbrR9gTqyeXpbEJZeF2vZ5dkxkOhQ4mY\n\tgyvzdH3z/Q6c7O3t","X-Google-Smtp-Source":"ADKCNb5nCZtveqjoz2M+snPZbzg6L171fRGWeffVLey7j8dX+cPUf7LB5Q8crELjtTMSiXQTLWaowA==","X-Received":"by 10.84.210.107 with SMTP id z98mr529090plh.216.1504732812627; \n\tWed, 06 Sep 2017 14:20:12 -0700 (PDT)","To":"Matthew Rosato ,\n\tDavid Hildenbrand , qemu-devel@nongnu.org","References":"<20170904154316.4148-1-david@redhat.com>\n\t<20170904154316.4148-12-david@redhat.com>\n\t<2c620927-0406-2fc1-895c-09ffc2e44a4e@linux.vnet.ibm.com>","From":"Richard Henderson ","Message-ID":"<6b3e9c2b-4cb7-fdf8-5f9b-ff7ebbf52d1e@linaro.org>","Date":"Wed, 6 Sep 2017 14:20:09 -0700","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<2c620927-0406-2fc1-895c-09ffc2e44a4e@linux.vnet.ibm.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2607:f8b0:400e:c05::231","Subject":"Re: [Qemu-devel] [PATCH v2 11/19] s390x: allow only 1 CPU with TCG","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"borntraeger@de.ibm.com, thuth@redhat.com, cohuck@redhat.com,\n\tEduardo Habkost , Alexander Graf ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1764706,"web_url":"http://patchwork.ozlabs.org/comment/1764706/","msgid":"","list_archive_url":null,"date":"2017-09-07T12:49:49","subject":"Re: [Qemu-devel] [PATCH v2 11/19] s390x: allow only 1 CPU with TCG","submitter":{"id":70402,"url":"http://patchwork.ozlabs.org/api/people/70402/","name":"David Hildenbrand","email":"david@redhat.com"},"content":"On 06.09.2017 23:20, Richard Henderson wrote:\n> On 09/06/2017 11:16 AM, Matthew Rosato wrote:\n>> On 09/04/2017 11:43 AM, David Hildenbrand wrote:\n>>> Specifying more than 1 CPU (e.g. -smp 5) leads to SIGP errors (the\n>>> guest tries to bring these CPUs up but fails), because we don't support\n>>> multiple CPUs on s390x under TCG.\n>>>\n>>> Let's bail out if more than 1 is specified, so we don't raise people's\n>>> hope. Make it a define, so we can easily bump it up later.\n>>>\n>>> Signed-off-by: David Hildenbrand \n>>> ---\n>>\n>> Makes sense. Ran the described environment without this patch (errors)\n>> and again with this patch (graceful exit w/ message).\n>>\n>> Tested-by: Matthew Rosato \n> \n> Can someone review\n> \n> http://patchwork.ozlabs.org/patch/760010/\n> \n\nYes, we also discovered that patch during review of v1.\n\n> which does at least start to add the SIGP support.\n> \n> Once tcg can bring up 2 cpus, I see no reason it couldn't bring up N. I don't\n> see the point of the define.\n> \n\nConny requested a define. So it boils down to\n\na) no define just as in v1\nb) a define like S390_TCG_SMP_SUPPORTED\n\nWhat do you suggest?\n\n> \n> r~\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx04.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx04.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=david@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xp0fy5mfhz9s4s\n\tfor ;\n\tThu, 7 Sep 2017 22:50:34 +1000 (AEST)","from localhost ([::1]:40340 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dpwGO-0003bT-Uf\n\tfor incoming@patchwork.ozlabs.org; Thu, 07 Sep 2017 08:50:32 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:44174)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dpwFu-0003ZW-O4\n\tfor qemu-devel@nongnu.org; Thu, 07 Sep 2017 08:50:10 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dpwFl-0005R3-Fp\n\tfor qemu-devel@nongnu.org; Thu, 07 Sep 2017 08:50:02 -0400","from mx1.redhat.com ([209.132.183.28]:43900)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dpwFl-0005QP-8o\n\tfor qemu-devel@nongnu.org; Thu, 07 Sep 2017 08:49:53 -0400","from smtp.corp.redhat.com\n\t(int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 1BB0A80461;\n\tThu, 7 Sep 2017 12:49:52 +0000 (UTC)","from [10.36.116.130] (ovpn-116-130.ams2.redhat.com [10.36.116.130])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 5D9E661B96;\n\tThu, 7 Sep 2017 12:49:50 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 1BB0A80461","To":"Richard Henderson ,\n\tMatthew Rosato , qemu-devel@nongnu.org","References":"<20170904154316.4148-1-david@redhat.com>\n\t<20170904154316.4148-12-david@redhat.com>\n\t<2c620927-0406-2fc1-895c-09ffc2e44a4e@linux.vnet.ibm.com>\n\t<6b3e9c2b-4cb7-fdf8-5f9b-ff7ebbf52d1e@linaro.org>","From":"David Hildenbrand ","Organization":"Red Hat GmbH","Message-ID":"","Date":"Thu, 7 Sep 2017 14:49:49 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<6b3e9c2b-4cb7-fdf8-5f9b-ff7ebbf52d1e@linaro.org>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.14","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.28]);\n\tThu, 07 Sep 2017 12:49:52 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v2 11/19] s390x: allow only 1 CPU with TCG","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"borntraeger@de.ibm.com, thuth@redhat.com, cohuck@redhat.com,\n\tEduardo Habkost , Alexander Graf ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1764707,"web_url":"http://patchwork.ozlabs.org/comment/1764707/","msgid":"<20170907145140.5e7e0b19.cohuck@redhat.com>","list_archive_url":null,"date":"2017-09-07T12:51:40","subject":"Re: [Qemu-devel] [PATCH v2 11/19] s390x: allow only 1 CPU with TCG","submitter":{"id":71914,"url":"http://patchwork.ozlabs.org/api/people/71914/","name":"Cornelia Huck","email":"cohuck@redhat.com"},"content":"On Thu, 7 Sep 2017 14:49:49 +0200\nDavid Hildenbrand wrote:\n\n> On 06.09.2017 23:20, Richard Henderson wrote:\n> > On 09/06/2017 11:16 AM, Matthew Rosato wrote: \n> >> On 09/04/2017 11:43 AM, David Hildenbrand wrote: \n> >>> Specifying more than 1 CPU (e.g. -smp 5) leads to SIGP errors (the\n> >>> guest tries to bring these CPUs up but fails), because we don't support\n> >>> multiple CPUs on s390x under TCG.\n> >>>\n> >>> Let's bail out if more than 1 is specified, so we don't raise people's\n> >>> hope. Make it a define, so we can easily bump it up later.\n> >>>\n> >>> Signed-off-by: David Hildenbrand \n> >>> --- \n> >>\n> >> Makes sense. Ran the described environment without this patch (errors)\n> >> and again with this patch (graceful exit w/ message).\n> >>\n> >> Tested-by: Matthew Rosato \n> > \n> > Can someone review\n> > \n> > http://patchwork.ozlabs.org/patch/760010/\n> > \n> \n> Yes, we also discovered that patch during review of v1.\n> \n> > which does at least start to add the SIGP support.\n> > \n> > Once tcg can bring up 2 cpus, I see no reason it couldn't bring up N. I don't\n> > see the point of the define.\n> > \n> \n> Conny requested a define. So it boils down to\n> \n> a) no define just as in v1\n> b) a define like S390_TCG_SMP_SUPPORTED\n> \n> What do you suggest?\n\nFWIW, I'd prefer b).\n\n> \n> > \n> > r~\n> > \n> \n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx09.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx09.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=cohuck@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xp0j46R36z9s4s\n\tfor ;\n\tThu, 7 Sep 2017 22:52:23 +1000 (AEST)","from localhost ([::1]:40346 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dpwI8-0004IB-0T\n\tfor incoming@patchwork.ozlabs.org; Thu, 07 Sep 2017 08:52:20 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:44806)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dpwHh-0004Hi-Uq\n\tfor qemu-devel@nongnu.org; Thu, 07 Sep 2017 08:51:58 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dpwHd-00077u-5h\n\tfor qemu-devel@nongnu.org; Thu, 07 Sep 2017 08:51:54 -0400","from mx1.redhat.com ([209.132.183.28]:60204)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dpwHc-00076O-WD\n\tfor qemu-devel@nongnu.org; Thu, 07 Sep 2017 08:51:49 -0400","from smtp.corp.redhat.com\n\t(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 02E9E4E909;\n\tThu, 7 Sep 2017 12:51:48 +0000 (UTC)","from gondolin (dhcp-192-215.str.redhat.com [10.33.192.215])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 74E3B1881A;\n\tThu, 7 Sep 2017 12:51:42 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 02E9E4E909","Date":"Thu, 7 Sep 2017 14:51:40 +0200","From":"Cornelia Huck ","To":"David Hildenbrand ","Message-ID":"<20170907145140.5e7e0b19.cohuck@redhat.com>","In-Reply-To":"","References":"<20170904154316.4148-1-david@redhat.com>\n\t<20170904154316.4148-12-david@redhat.com>\n\t<2c620927-0406-2fc1-895c-09ffc2e44a4e@linux.vnet.ibm.com>\n\t<6b3e9c2b-4cb7-fdf8-5f9b-ff7ebbf52d1e@linaro.org>\n\t","Organization":"Red Hat GmbH","MIME-Version":"1.0","Content-Type":"text/plain; charset=US-ASCII","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.12","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.38]);\n\tThu, 07 Sep 2017 12:51:48 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v2 11/19] s390x: allow only 1 CPU with TCG","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Matthew Rosato , thuth@redhat.com,\n\tEduardo Habkost ,\n\tRichard Henderson ,\n\tAlexander Graf , qemu-devel@nongnu.org,\n\tborntraeger@de.ibm.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1768766,"web_url":"http://patchwork.ozlabs.org/comment/1768766/","msgid":"<24e458ff-39c8-7407-62ad-46568e150c5d@redhat.com>","list_archive_url":null,"date":"2017-09-14T18:13:49","subject":"Re: [Qemu-devel] [PATCH v2 11/19] s390x: allow only 1 CPU with TCG","submitter":{"id":70402,"url":"http://patchwork.ozlabs.org/api/people/70402/","name":"David Hildenbrand","email":"david@redhat.com"},"content":"On 06.09.2017 23:20, Richard Henderson wrote:\n> On 09/06/2017 11:16 AM, Matthew Rosato wrote:\n>> On 09/04/2017 11:43 AM, David Hildenbrand wrote:\n>>> Specifying more than 1 CPU (e.g. -smp 5) leads to SIGP errors (the\n>>> guest tries to bring these CPUs up but fails), because we don't support\n>>> multiple CPUs on s390x under TCG.\n>>>\n>>> Let's bail out if more than 1 is specified, so we don't raise people's\n>>> hope. Make it a define, so we can easily bump it up later.\n>>>\n>>> Signed-off-by: David Hildenbrand \n>>> ---\n>>\n>> Makes sense. Ran the described environment without this patch (errors)\n>> and again with this patch (graceful exit w/ message).\n>>\n>> Tested-by: Matthew Rosato \n> \n> Can someone review\n> \n> http://patchwork.ozlabs.org/patch/760010/\n> \n> which does at least start to add the SIGP support.\n\nFWIW, I started factoring out today KVM SIGP code to make it usable by TCG.\n\nI also started adding the missing SIGP instructions the kernel handles\nfor KVM. I dropped the old TCG SIGP handling code and completely reuse\nthe new SIGP code. I already got boot/reboot/shutdown properly running\n(implementing STOP and RESTART interrupts like KVM has).\n\nBut its still quite hacky and there are is a bunch of stuff to clean up,\nespecially:\n- external interrupt handling (the queue approach we have right now is\n no good for external calls and emergency signals)\n- floating interrupt support (io interrupts always going to CPU 0 is a\n hack)\n\nI think I can at least implement SIGP properly and fix the external call\nstuff. floating interrupts might require more thought.\n\nAurelien, please tell me if you are currently still working on this, so\nwe can coordinate.\n\nThanks!\n\n> \n> Once tcg can bring up 2 cpus, I see no reason it couldn't bring up N. I don't\n> see the point of the define.\n> \n> \n> r~\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx05.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx05.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=david@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xtRWb4zdMz9s7c\n\tfor ;\n\tFri, 15 Sep 2017 04:14:35 +1000 (AEST)","from localhost ([::1]:49339 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dsYen-00067G-OM\n\tfor incoming@patchwork.ozlabs.org; Thu, 14 Sep 2017 14:14:33 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:37135)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dsYeI-00065p-F3\n\tfor qemu-devel@nongnu.org; Thu, 14 Sep 2017 14:14:03 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dsYeE-0007KA-Fl\n\tfor qemu-devel@nongnu.org; Thu, 14 Sep 2017 14:14:02 -0400","from mx1.redhat.com ([209.132.183.28]:49942)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dsYeE-0007JC-AA\n\tfor qemu-devel@nongnu.org; Thu, 14 Sep 2017 14:13:58 -0400","from smtp.corp.redhat.com\n\t(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 6D26513A4C;\n\tThu, 14 Sep 2017 18:13:56 +0000 (UTC)","from [10.97.116.56] (ovpn-116-56.gru2.redhat.com [10.97.116.56])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 154486F947;\n\tThu, 14 Sep 2017 18:13:51 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 6D26513A4C","To":"Richard Henderson ,\n\tMatthew Rosato , qemu-devel@nongnu.org","References":"<20170904154316.4148-1-david@redhat.com>\n\t<20170904154316.4148-12-david@redhat.com>\n\t<2c620927-0406-2fc1-895c-09ffc2e44a4e@linux.vnet.ibm.com>\n\t<6b3e9c2b-4cb7-fdf8-5f9b-ff7ebbf52d1e@linaro.org>","From":"David Hildenbrand ","Organization":"Red Hat GmbH","Message-ID":"<24e458ff-39c8-7407-62ad-46568e150c5d@redhat.com>","Date":"Thu, 14 Sep 2017 20:13:49 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<6b3e9c2b-4cb7-fdf8-5f9b-ff7ebbf52d1e@linaro.org>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.11","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.29]);\n\tThu, 14 Sep 2017 18:13:56 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v2 11/19] s390x: allow only 1 CPU with TCG","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"thuth@redhat.com, Eduardo Habkost ,\n\tcohuck@redhat.com, \n\tAlexander Graf , borntraeger@de.ibm.com,\n\tAurelien Jarno ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1768998,"web_url":"http://patchwork.ozlabs.org/comment/1768998/","msgid":"<20170915093808.4cd4d0ae.cohuck@redhat.com>","list_archive_url":null,"date":"2017-09-15T07:38:08","subject":"Re: [Qemu-devel] [PATCH v2 11/19] s390x: allow only 1 CPU with TCG","submitter":{"id":71914,"url":"http://patchwork.ozlabs.org/api/people/71914/","name":"Cornelia Huck","email":"cohuck@redhat.com"},"content":"On Thu, 14 Sep 2017 20:13:49 +0200\nDavid Hildenbrand wrote:\n\n> FWIW, I started factoring out today KVM SIGP code to make it usable by TCG.\n> \n> I also started adding the missing SIGP instructions the kernel handles\n> for KVM. I dropped the old TCG SIGP handling code and completely reuse\n> the new SIGP code. I already got boot/reboot/shutdown properly running\n> (implementing STOP and RESTART interrupts like KVM has).\n\nCool!\n\n> \n> But its still quite hacky and there are is a bunch of stuff to clean up,\n> especially:\n> - external interrupt handling (the queue approach we have right now is\n> no good for external calls and emergency signals)\n> - floating interrupt support (io interrupts always going to CPU 0 is a\n> hack)\n> \n> I think I can at least implement SIGP properly and fix the external call\n> stuff. floating interrupts might require more thought.\n\nI'm wondering whether something should move into the qemu version of\nthe flic. I'm also wondering whether we should look to the kvm floating\ninterrupt code for inspiration.\n\n(I have 'look at floating interrupts with tcg' on my todo list as\nwell :)","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx06.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx06.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=cohuck@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xtnMg0TrTz9t2Z\n\tfor ;\n\tFri, 15 Sep 2017 17:38:52 +1000 (AEST)","from localhost ([::1]:51759 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dslD7-0005gu-QJ\n\tfor incoming@patchwork.ozlabs.org; Fri, 15 Sep 2017 03:38:49 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:48890)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dslCg-0005gc-GD\n\tfor qemu-devel@nongnu.org; Fri, 15 Sep 2017 03:38:23 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dslCb-0003uL-JT\n\tfor qemu-devel@nongnu.org; Fri, 15 Sep 2017 03:38:22 -0400","from mx1.redhat.com ([209.132.183.28]:45344)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dslCb-0003uF-DC\n\tfor qemu-devel@nongnu.org; Fri, 15 Sep 2017 03:38:17 -0400","from smtp.corp.redhat.com\n\t(int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id F10DF356E6;\n\tFri, 15 Sep 2017 07:38:15 +0000 (UTC)","from gondolin (ovpn-117-60.ams2.redhat.com [10.36.117.60])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 938DF69AC1;\n\tFri, 15 Sep 2017 07:38:11 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com F10DF356E6","Date":"Fri, 15 Sep 2017 09:38:08 +0200","From":"Cornelia Huck ","To":"David Hildenbrand ","Message-ID":"<20170915093808.4cd4d0ae.cohuck@redhat.com>","In-Reply-To":"<24e458ff-39c8-7407-62ad-46568e150c5d@redhat.com>","References":"<20170904154316.4148-1-david@redhat.com>\n\t<20170904154316.4148-12-david@redhat.com>\n\t<2c620927-0406-2fc1-895c-09ffc2e44a4e@linux.vnet.ibm.com>\n\t<6b3e9c2b-4cb7-fdf8-5f9b-ff7ebbf52d1e@linaro.org>\n\t<24e458ff-39c8-7407-62ad-46568e150c5d@redhat.com>","Organization":"Red Hat GmbH","MIME-Version":"1.0","Content-Type":"text/plain; charset=US-ASCII","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.15","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.30]);\n\tFri, 15 Sep 2017 07:38:16 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v2 11/19] s390x: allow only 1 CPU with TCG","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Matthew Rosato , thuth@redhat.com,\n\tEduardo Habkost ,\n\tRichard Henderson ,\n\tAlexander Graf , qemu-devel@nongnu.org,\n\tborntraeger@de.ibm.com, Aurelien Jarno ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]