[{"id":1763078,"web_url":"http://patchwork.ozlabs.org/comment/1763078/","msgid":"<3ff50714-ccfa-7471-063d-ebef989590f1@de.ibm.com>","list_archive_url":null,"date":"2017-09-05T08:54:09","subject":"Re: [Qemu-devel] [PATCH v2 04/19] s390x: rename s390-virtio.h to\n\ts390-virtio-hcall.h","submitter":{"id":590,"url":"http://patchwork.ozlabs.org/api/people/590/","name":"Christian Borntraeger","email":"borntraeger@de.ibm.com"},"content":"On 09/04/2017 05:43 PM, David Hildenbrand wrote:\n> The only interface left, so let's properly rename it.\n> \n> Reviewed-by: Thomas Huth \n> Signed-off-by: David Hildenbrand \n\nAcked-by: Christian Borntraeger \n\n> ---\n> hw/s390x/s390-virtio-ccw.c | 2 +-\n> hw/s390x/s390-virtio-hcall.c | 2 +-\n> hw/s390x/{s390-virtio.h => s390-virtio-hcall.h} | 8 ++++----\n> 3 files changed, 6 insertions(+), 6 deletions(-)\n> rename hw/s390x/{s390-virtio.h => s390-virtio-hcall.h} (77%)\n> \n> diff --git a/hw/s390x/s390-virtio-ccw.c b/hw/s390x/s390-virtio-ccw.c\n> index 4c3a3e177b..f67b4b5d58 100644\n> --- a/hw/s390x/s390-virtio-ccw.c\n> +++ b/hw/s390x/s390-virtio-ccw.c\n> @@ -16,7 +16,7 @@\n> #include \"cpu.h\"\n> #include \"hw/boards.h\"\n> #include \"exec/address-spaces.h\"\n> -#include \"s390-virtio.h\"\n> +#include \"hw/s390x/s390-virtio-hcall.h\"\n> #include \"hw/s390x/sclp.h\"\n> #include \"hw/s390x/s390_flic.h\"\n> #include \"hw/s390x/ioinst.h\"\n> diff --git a/hw/s390x/s390-virtio-hcall.c b/hw/s390x/s390-virtio-hcall.c\n> index 23d67d6170..ec7cf8beb3 100644\n> --- a/hw/s390x/s390-virtio-hcall.c\n> +++ b/hw/s390x/s390-virtio-hcall.c\n> @@ -11,7 +11,7 @@\n> \n> #include \"qemu/osdep.h\"\n> #include \"cpu.h\"\n> -#include \"hw/s390x/s390-virtio.h\"\n> +#include \"hw/s390x/s390-virtio-hcall.h\"\n> \n> #define MAX_DIAG_SUBCODES 255\n> \n> diff --git a/hw/s390x/s390-virtio.h b/hw/s390x/s390-virtio-hcall.h\n> similarity index 77%\n> rename from hw/s390x/s390-virtio.h\n> rename to hw/s390x/s390-virtio-hcall.h\n> index d984cd4115..59fcba3a06 100644\n> --- a/hw/s390x/s390-virtio.h\n> +++ b/hw/s390x/s390-virtio-hcall.h\n> @@ -1,5 +1,5 @@\n> /*\n> - * Virtio interfaces for s390\n> + * Support for virtio hypercalls on s390x\n> *\n> * Copyright 2012 IBM Corp.\n> * Author(s): Cornelia Huck \n> @@ -9,12 +9,12 @@\n> * directory.\n> */\n> \n> -#ifndef HW_S390_VIRTIO_H\n> -#define HW_S390_VIRTIO_H\n> +#ifndef HW_S390_VIRTIO_HCALL_H\n> +#define HW_S390_VIRTIO_HCALL_H\n> \n> #include \"standard-headers/asm-s390/kvm_virtio.h\"\n> #include \"standard-headers/asm-s390/virtio-ccw.h\"\n> \n> typedef int (*s390_virtio_fn)(const uint64_t *args);\n> void s390_register_virtio_hypercall(uint64_t code, s390_virtio_fn fn);\n> -#endif\n> +#endif /* HW_S390_VIRTIO_HCALL_H */\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xmgWn40xQz9sPk\n\tfor ;\n\tTue, 5 Sep 2017 18:54:45 +1000 (AEST)","from localhost ([::1]:57483 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dp9d5-0007LY-LC\n\tfor incoming@patchwork.ozlabs.org; Tue, 05 Sep 2017 04:54:43 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:56146)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dp9cj-0007Ju-PH\n\tfor qemu-devel@nongnu.org; Tue, 05 Sep 2017 04:54:26 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dp9ce-0007CI-V8\n\tfor qemu-devel@nongnu.org; Tue, 05 Sep 2017 04:54:21 -0400","from mx0b-001b2d01.pphosted.com ([148.163.158.5]:56099\n\thelo=mx0a-001b2d01.pphosted.com)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dp9ce-0007C7-P3\n\tfor qemu-devel@nongnu.org; Tue, 05 Sep 2017 04:54:16 -0400","from pps.filterd (m0098417.ppops.net [127.0.0.1])\n\tby mx0a-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id\n\tv858s7OR082602\n\tfor ; Tue, 5 Sep 2017 04:54:16 -0400","from e06smtp13.uk.ibm.com (e06smtp13.uk.ibm.com [195.75.94.109])\n\tby mx0a-001b2d01.pphosted.com with ESMTP id 2csq86p0en-1\n\t(version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT)\n\tfor ; Tue, 05 Sep 2017 04:54:15 -0400","from localhost\n\tby e06smtp13.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use\n\tOnly! Violators will be prosecuted\n\tfor from ;\n\tTue, 5 Sep 2017 09:54:14 +0100","from b06cxnps4075.portsmouth.uk.ibm.com (9.149.109.197)\n\tby e06smtp13.uk.ibm.com (192.168.101.143) with IBM ESMTP SMTP\n\tGateway: Authorized Use Only! Violators will be prosecuted; \n\tTue, 5 Sep 2017 09:54:10 +0100","from d06av24.portsmouth.uk.ibm.com (mk.ibm.com [9.149.105.60])\n\tby b06cxnps4075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with\n\tESMTP id v858sAWs15401194; Tue, 5 Sep 2017 08:54:10 GMT","from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id 0701642045;\n\tTue, 5 Sep 2017 09:50:42 +0100 (BST)","from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id C102942041;\n\tTue, 5 Sep 2017 09:50:41 +0100 (BST)","from oc7330422307.ibm.com (unknown [9.152.224.49])\n\tby d06av24.portsmouth.uk.ibm.com (Postfix) with ESMTP;\n\tTue, 5 Sep 2017 09:50:41 +0100 (BST)"],"To":"David Hildenbrand , qemu-devel@nongnu.org","References":"<20170904154316.4148-1-david@redhat.com>\n\t<20170904154316.4148-5-david@redhat.com>","From":"Christian Borntraeger ","Date":"Tue, 5 Sep 2017 10:54:09 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.0","MIME-Version":"1.0","In-Reply-To":"<20170904154316.4148-5-david@redhat.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-TM-AS-GCONF":"00","x-cbid":"17090508-0012-0000-0000-00000574ADF9","X-IBM-AV-DETECTION":"SAVI=unused REMOTE=unused XFE=unused","x-cbparentid":"17090508-0013-0000-0000-000018ECE365","Message-Id":"<3ff50714-ccfa-7471-063d-ebef989590f1@de.ibm.com>","X-Proofpoint-Virus-Version":"vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-09-05_04:, , signatures=0","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n\tspamscore=0 suspectscore=0\n\tmalwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam\n\tadjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000\n\tdefinitions=main-1709050137","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 3.x [generic] [fuzzy]","X-Received-From":"148.163.158.5","Subject":"Re: [Qemu-devel] [PATCH v2 04/19] s390x: rename s390-virtio.h to\n\ts390-virtio-hcall.h","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"thuth@redhat.com, cohuck@redhat.com,\n\tRichard Henderson ,\n\tAlexander Graf , Eduardo Habkost ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]