[{"id":1763291,"web_url":"http://patchwork.ozlabs.org/comment/1763291/","msgid":"<20170905142524.116b44be.cohuck@redhat.com>","list_archive_url":null,"date":"2017-09-05T12:25:24","subject":"Re: [Qemu-devel] [PATCH v2 01/19] exec, dump, i386, ppc,\n\ts390x: don't include exec/cpu-all.h explicitly","submitter":{"id":71914,"url":"http://patchwork.ozlabs.org/api/people/71914/","name":"Cornelia Huck","email":"cohuck@redhat.com"},"content":"On Mon, 4 Sep 2017 17:42:58 +0200\nDavid Hildenbrand wrote:\n\n> All but a handfull of filles include exec/cpu-all.h via cpu.h only.\n\nYou had some extra 'l's around? :)\n\ns/handfull/handful/ and s/filles/files/\n\n(I can fix while applying)\n\n> As these files already include cpu.h, let's just drop the additional\n> include.\n> \n> Signed-off-by: David Hildenbrand \n> ---\n> dump.c | 1 -\n> exec.c | 2 --\n> target/i386/arch_dump.c | 1 -\n> target/i386/arch_memory_mapping.c | 1 -\n> target/i386/svm_helper.c | 1 -\n> target/ppc/arch_dump.c | 1 -\n> target/s390x/arch_dump.c | 1 -\n> 7 files changed, 8 deletions(-)\n\nThis looks obviously correct; would not mind acks, though.\n\n> \n> diff --git a/dump.c b/dump.c\n> index a79773d0f7..2ef6a678e8 100644\n> --- a/dump.c\n> +++ b/dump.c\n> @@ -15,7 +15,6 @@\n> #include \"qemu/cutils.h\"\n> #include \"elf.h\"\n> #include \"cpu.h\"\n> -#include \"exec/cpu-all.h\"\n> #include \"exec/hwaddr.h\"\n> #include \"monitor/monitor.h\"\n> #include \"sysemu/kvm.h\"\n> diff --git a/exec.c b/exec.c\n> index d20c34ca83..d109de2014 100644\n> --- a/exec.c\n> +++ b/exec.c\n> @@ -23,7 +23,6 @@\n> \n> #include \"qemu/cutils.h\"\n> #include \"cpu.h\"\n> -#include \"exec/exec-all.h\"\n> #include \"exec/target_page.h\"\n> #include \"tcg.h\"\n> #include \"hw/qdev-core.h\"\n> @@ -56,7 +55,6 @@\n> #endif\n> \n> #endif\n> -#include \"exec/cpu-all.h\"\n> #include \"qemu/rcu_queue.h\"\n> #include \"qemu/main-loop.h\"\n> #include \"translate-all.h\"\n> diff --git a/target/i386/arch_dump.c b/target/i386/arch_dump.c\n> index e682904052..35b55fc200 100644\n> --- a/target/i386/arch_dump.c\n> +++ b/target/i386/arch_dump.c\n> @@ -13,7 +13,6 @@\n> \n> #include \"qemu/osdep.h\"\n> #include \"cpu.h\"\n> -#include \"exec/cpu-all.h\"\n> #include \"sysemu/dump.h\"\n> #include \"elf.h\"\n> #include \"sysemu/memory_mapping.h\"\n> diff --git a/target/i386/arch_memory_mapping.c b/target/i386/arch_memory_mapping.c\n> index 647cff2829..271cb5e41b 100644\n> --- a/target/i386/arch_memory_mapping.c\n> +++ b/target/i386/arch_memory_mapping.c\n> @@ -13,7 +13,6 @@\n> \n> #include \"qemu/osdep.h\"\n> #include \"cpu.h\"\n> -#include \"exec/cpu-all.h\"\n> #include \"sysemu/memory_mapping.h\"\n> \n> /* PAE Paging or IA-32e Paging */\n> diff --git a/target/i386/svm_helper.c b/target/i386/svm_helper.c\n> index 59e8b5091c..f479239875 100644\n> --- a/target/i386/svm_helper.c\n> +++ b/target/i386/svm_helper.c\n> @@ -19,7 +19,6 @@\n> \n> #include \"qemu/osdep.h\"\n> #include \"cpu.h\"\n> -#include \"exec/cpu-all.h\"\n> #include \"exec/helper-proto.h\"\n> #include \"exec/exec-all.h\"\n> #include \"exec/cpu_ldst.h\"\n> diff --git a/target/ppc/arch_dump.c b/target/ppc/arch_dump.c\n> index 8e9397aa58..beb7268e57 100644\n> --- a/target/ppc/arch_dump.c\n> +++ b/target/ppc/arch_dump.c\n> @@ -15,7 +15,6 @@\n> #include \"qemu/osdep.h\"\n> #include \"cpu.h\"\n> #include \"elf.h\"\n> -#include \"exec/cpu-all.h\"\n> #include \"sysemu/dump.h\"\n> #include \"sysemu/kvm.h\"\n> \n> diff --git a/target/s390x/arch_dump.c b/target/s390x/arch_dump.c\n> index 9b0bf92698..6f61ff95af 100644\n> --- a/target/s390x/arch_dump.c\n> +++ b/target/s390x/arch_dump.c\n> @@ -15,7 +15,6 @@\n> #include \"cpu.h\"\n> #include \"internal.h\"\n> #include \"elf.h\"\n> -#include \"exec/cpu-all.h\"\n> #include \"sysemu/dump.h\"\n> \n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx10.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx10.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=cohuck@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xmmCc5py2z9sRV\n\tfor ;\n\tTue, 5 Sep 2017 22:26:03 +1000 (AEST)","from localhost ([::1]:58650 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dpCvY-0005Lq-Sf\n\tfor incoming@patchwork.ozlabs.org; Tue, 05 Sep 2017 08:26:00 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:47742)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dpCvB-0005LU-20\n\tfor qemu-devel@nongnu.org; Tue, 05 Sep 2017 08:25:41 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dpCv6-0004C7-8a\n\tfor qemu-devel@nongnu.org; Tue, 05 Sep 2017 08:25:37 -0400","from mx1.redhat.com ([209.132.183.28]:47686)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dpCv6-0004Bk-0Q\n\tfor qemu-devel@nongnu.org; Tue, 05 Sep 2017 08:25:32 -0400","from smtp.corp.redhat.com\n\t(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id E9D14272C2;\n\tTue, 5 Sep 2017 12:25:30 +0000 (UTC)","from gondolin (dhcp-192-215.str.redhat.com [10.33.192.215])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 5E6B6DA0E1;\n\tTue, 5 Sep 2017 12:25:26 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com E9D14272C2","Date":"Tue, 5 Sep 2017 14:25:24 +0200","From":"Cornelia Huck ","To":"David Hildenbrand ","Message-ID":"<20170905142524.116b44be.cohuck@redhat.com>","In-Reply-To":"<20170904154316.4148-2-david@redhat.com>","References":"<20170904154316.4148-1-david@redhat.com>\n\t<20170904154316.4148-2-david@redhat.com>","Organization":"Red Hat GmbH","MIME-Version":"1.0","Content-Type":"text/plain; charset=US-ASCII","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.11","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.39]);\n\tTue, 05 Sep 2017 12:25:31 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v2 01/19] exec, dump, i386, ppc,\n\ts390x: don't include exec/cpu-all.h explicitly","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"thuth@redhat.com, Eduardo Habkost ,\n\tRichard Henderson ,\n\tqemu-devel@nongnu.org, Alexander Graf ,\n\tborntraeger@de.ibm.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1764514,"web_url":"http://patchwork.ozlabs.org/comment/1764514/","msgid":"<934be1e8-469e-6d54-bcc1-21e12da2e408@redhat.com>","list_archive_url":null,"date":"2017-09-07T05:46:39","subject":"Re: [Qemu-devel] [PATCH v2 01/19] exec, dump, i386, ppc,\n\ts390x: don't include exec/cpu-all.h explicitly","submitter":{"id":66152,"url":"http://patchwork.ozlabs.org/api/people/66152/","name":"Thomas Huth","email":"thuth@redhat.com"},"content":"On 04.09.2017 17:42, David Hildenbrand wrote:\n> All but a handfull of filles include exec/cpu-all.h via cpu.h only.\n> As these files already include cpu.h, let's just drop the additional\n> include.\n> \n> Signed-off-by: David Hildenbrand \n> ---\n> dump.c | 1 -\n> exec.c | 2 --\n> target/i386/arch_dump.c | 1 -\n> target/i386/arch_memory_mapping.c | 1 -\n> target/i386/svm_helper.c | 1 -\n> target/ppc/arch_dump.c | 1 -\n> target/s390x/arch_dump.c | 1 -\n> 7 files changed, 8 deletions(-)\n> \n> diff --git a/dump.c b/dump.c\n> index a79773d0f7..2ef6a678e8 100644\n> --- a/dump.c\n> +++ b/dump.c\n> @@ -15,7 +15,6 @@\n> #include \"qemu/cutils.h\"\n> #include \"elf.h\"\n> #include \"cpu.h\"\n> -#include \"exec/cpu-all.h\"\n> #include \"exec/hwaddr.h\"\n> #include \"monitor/monitor.h\"\n> #include \"sysemu/kvm.h\"\n> diff --git a/exec.c b/exec.c\n> index d20c34ca83..d109de2014 100644\n> --- a/exec.c\n> +++ b/exec.c\n> @@ -23,7 +23,6 @@\n> \n> #include \"qemu/cutils.h\"\n> #include \"cpu.h\"\n> -#include \"exec/exec-all.h\"\n\nYou should maybe mention exec-all.h in the patch description, too.\n(I think it can be dropped here because it is included by\ntranslate-all.h already).\n\nIf you tweak the patch description:\nReviewed-by: Thomas Huth ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx02.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx02.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=thuth@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xnqGd1fTyz9s83\n\tfor ;\n\tThu, 7 Sep 2017 15:47:19 +1000 (AEST)","from localhost ([::1]:38911 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dppek-0002XC-Pv\n\tfor incoming@patchwork.ozlabs.org; Thu, 07 Sep 2017 01:47:17 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:36221)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dppeP-0002X6-An\n\tfor qemu-devel@nongnu.org; Thu, 07 Sep 2017 01:46:54 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dppeK-0007WE-GW\n\tfor qemu-devel@nongnu.org; Thu, 07 Sep 2017 01:46:53 -0400","from mx1.redhat.com ([209.132.183.28]:54662)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dppeK-0007Vx-A7\n\tfor qemu-devel@nongnu.org; Thu, 07 Sep 2017 01:46:48 -0400","from smtp.corp.redhat.com\n\t(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 02520883B8;\n\tThu, 7 Sep 2017 05:46:47 +0000 (UTC)","from [10.36.116.66] (ovpn-116-66.ams2.redhat.com [10.36.116.66])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id D6ADB6058F;\n\tThu, 7 Sep 2017 05:46:41 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 02520883B8","To":"David Hildenbrand , qemu-devel@nongnu.org","References":"<20170904154316.4148-1-david@redhat.com>\n\t<20170904154316.4148-2-david@redhat.com>","From":"Thomas Huth ","Message-ID":"<934be1e8-469e-6d54-bcc1-21e12da2e408@redhat.com>","Date":"Thu, 7 Sep 2017 07:46:39 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170904154316.4148-2-david@redhat.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.11","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.26]);\n\tThu, 07 Sep 2017 05:46:47 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v2 01/19] exec, dump, i386, ppc,\n\ts390x: don't include exec/cpu-all.h explicitly","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"borntraeger@de.ibm.com, cohuck@redhat.com,\n\tRichard Henderson ,\n\tAlexander Graf , Eduardo Habkost ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1764702,"web_url":"http://patchwork.ozlabs.org/comment/1764702/","msgid":"<4cb9db9c-7294-abde-92eb-8247ae354d86@redhat.com>","list_archive_url":null,"date":"2017-09-07T12:41:21","subject":"Re: [Qemu-devel] [PATCH v2 01/19] exec, dump, i386, ppc,\n\ts390x: don't include exec/cpu-all.h explicitly","submitter":{"id":70402,"url":"http://patchwork.ozlabs.org/api/people/70402/","name":"David Hildenbrand","email":"david@redhat.com"},"content":"On 07.09.2017 07:46, Thomas Huth wrote:\n>> #include \"qemu/cutils.h\"\n>> #include \"cpu.h\"\n>> -#include \"exec/exec-all.h\"\n> You should maybe mention exec-all.h in the patch description, too.\n> (I think it can be dropped here because it is included by\n> translate-all.h already).\n> \n> If you tweak the patch description:\n> Reviewed-by: Thomas Huth \n\nI'll just drop that hunk although it can also be removed.\n\nYes, this was not included on purpose - these similar names still\nconfuse me :)","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx09.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx09.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=david@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xp0TC63lvz9sCZ\n\tfor ;\n\tThu, 7 Sep 2017 22:42:07 +1000 (AEST)","from localhost ([::1]:40317 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dpw8D-000883-W7\n\tfor incoming@patchwork.ozlabs.org; Thu, 07 Sep 2017 08:42:06 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:41670)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dpw7d-00085V-IE\n\tfor qemu-devel@nongnu.org; Thu, 07 Sep 2017 08:41:34 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dpw7Z-0007da-1c\n\tfor qemu-devel@nongnu.org; Thu, 07 Sep 2017 08:41:29 -0400","from mx1.redhat.com ([209.132.183.28]:52170)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dpw7Y-0007cp-Rc\n\tfor qemu-devel@nongnu.org; Thu, 07 Sep 2017 08:41:24 -0400","from smtp.corp.redhat.com\n\t(int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id BA0654E909;\n\tThu, 7 Sep 2017 12:41:23 +0000 (UTC)","from [10.36.116.130] (ovpn-116-130.ams2.redhat.com [10.36.116.130])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 1D1A361B70;\n\tThu, 7 Sep 2017 12:41:21 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com BA0654E909","To":"Thomas Huth , qemu-devel@nongnu.org","References":"<20170904154316.4148-1-david@redhat.com>\n\t<20170904154316.4148-2-david@redhat.com>\n\t<934be1e8-469e-6d54-bcc1-21e12da2e408@redhat.com>","From":"David Hildenbrand ","Organization":"Red Hat GmbH","Message-ID":"<4cb9db9c-7294-abde-92eb-8247ae354d86@redhat.com>","Date":"Thu, 7 Sep 2017 14:41:21 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<934be1e8-469e-6d54-bcc1-21e12da2e408@redhat.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.14","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.38]);\n\tThu, 07 Sep 2017 12:41:23 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v2 01/19] exec, dump, i386, ppc,\n\ts390x: don't include exec/cpu-all.h explicitly","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"borntraeger@de.ibm.com, cohuck@redhat.com,\n\tRichard Henderson ,\n\tAlexander Graf , Eduardo Habkost ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1764712,"web_url":"http://patchwork.ozlabs.org/comment/1764712/","msgid":"<20170907151107.6959cd86.cohuck@redhat.com>","list_archive_url":null,"date":"2017-09-07T13:11:07","subject":"Re: [Qemu-devel] [PATCH v2 01/19] exec, dump, i386, ppc,\n\ts390x: don't include exec/cpu-all.h explicitly","submitter":{"id":71914,"url":"http://patchwork.ozlabs.org/api/people/71914/","name":"Cornelia Huck","email":"cohuck@redhat.com"},"content":"On Thu, 7 Sep 2017 14:41:21 +0200\nDavid Hildenbrand wrote:\n\n> On 07.09.2017 07:46, Thomas Huth wrote:\n> >> #include \"qemu/cutils.h\"\n> >> #include \"cpu.h\"\n> >> -#include \"exec/exec-all.h\" \n> > You should maybe mention exec-all.h in the patch description, too.\n> > (I think it can be dropped here because it is included by\n> > translate-all.h already).\n> > \n> > If you tweak the patch description:\n> > Reviewed-by: Thomas Huth \n> \n> I'll just drop that hunk although it can also be removed.\n> \n> Yes, this was not included on purpose - these similar names still\n> confuse me :)\n> \n\nNot only you :)\n\nIf we can do a sweep of exec-all.h as well, it should be a separate\npatch.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx10.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx10.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=cohuck@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xp17W5H58z9sPk\n\tfor ;\n\tThu, 7 Sep 2017 23:11:50 +1000 (AEST)","from localhost ([::1]:40440 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dpway-0002SV-7g\n\tfor incoming@patchwork.ozlabs.org; Thu, 07 Sep 2017 09:11:48 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:50951)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dpwaZ-0002Ry-Ig\n\tfor qemu-devel@nongnu.org; Thu, 07 Sep 2017 09:11:28 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dpwaU-0004kr-Hu\n\tfor qemu-devel@nongnu.org; Thu, 07 Sep 2017 09:11:23 -0400","from mx1.redhat.com ([209.132.183.28]:56347)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dpwaU-0004jt-BG\n\tfor qemu-devel@nongnu.org; Thu, 07 Sep 2017 09:11:18 -0400","from smtp.corp.redhat.com\n\t(int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 3BB7C61D28;\n\tThu, 7 Sep 2017 13:11:16 +0000 (UTC)","from gondolin (dhcp-192-215.str.redhat.com [10.33.192.215])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 965126062B;\n\tThu, 7 Sep 2017 13:11:09 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 3BB7C61D28","Date":"Thu, 7 Sep 2017 15:11:07 +0200","From":"Cornelia Huck ","To":"David Hildenbrand ","Message-ID":"<20170907151107.6959cd86.cohuck@redhat.com>","In-Reply-To":"<4cb9db9c-7294-abde-92eb-8247ae354d86@redhat.com>","References":"<20170904154316.4148-1-david@redhat.com>\n\t<20170904154316.4148-2-david@redhat.com>\n\t<934be1e8-469e-6d54-bcc1-21e12da2e408@redhat.com>\n\t<4cb9db9c-7294-abde-92eb-8247ae354d86@redhat.com>","Organization":"Red Hat GmbH","MIME-Version":"1.0","Content-Type":"text/plain; charset=US-ASCII","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.13","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.39]);\n\tThu, 07 Sep 2017 13:11:16 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v2 01/19] exec, dump, i386, ppc,\n\ts390x: don't include exec/cpu-all.h explicitly","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Thomas Huth , Eduardo Habkost ,\n\tRichard Henderson ,\n\tqemu-devel@nongnu.org, Alexander Graf ,\n\tborntraeger@de.ibm.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]