[{"id":1764843,"web_url":"http://patchwork.ozlabs.org/comment/1764843/","msgid":"<20170907191159.767509da.cohuck@redhat.com>","list_archive_url":null,"date":"2017-09-07T17:11:59","subject":"Re: [Qemu-devel] [PATCH v2 19/19] s390x: get rid of\n\tcpu_s390x_create()","submitter":{"id":71914,"url":"http://patchwork.ozlabs.org/api/people/71914/","name":"Cornelia Huck","email":"cohuck@redhat.com"},"content":"On Mon, 4 Sep 2017 17:43:16 +0200\nDavid Hildenbrand wrote:\n\n> Now that there is only one user of cpu_s390x_create() left, make cpu\n> creation looks like on x86.\n> - Perform the model/properties split and checks in s390_init_cpus()\n> - Parse features only once without having to remember if already parsed\n> - Pass only the typename to s390x_new_cpu()\n> - Use the typename of an existing CPU for hotplug via cpu-add\n> \n> Signed-off-by: David Hildenbrand \n> ---\n> hw/s390x/s390-virtio-ccw.c | 29 +++++++++++++++++++++++++++--\n> target/s390x/cpu.h | 2 +-\n> target/s390x/helper.c | 45 ++-------------------------------------------\n> target/s390x/internal.h | 1 -\n> 4 files changed, 30 insertions(+), 47 deletions(-)\n\nLGTM","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx06.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx06.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=cohuck@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xp6TM74Lzz9sRY\n\tfor ;\n\tFri, 8 Sep 2017 03:12:37 +1000 (AEST)","from localhost ([::1]:41437 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dq0Lz-0000n9-Be\n\tfor incoming@patchwork.ozlabs.org; Thu, 07 Sep 2017 13:12:35 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:39470)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dq0Ld-0000mr-DM\n\tfor qemu-devel@nongnu.org; Thu, 07 Sep 2017 13:12:18 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dq0LY-0008TB-Le\n\tfor qemu-devel@nongnu.org; Thu, 07 Sep 2017 13:12:13 -0400","from mx1.redhat.com ([209.132.183.28]:6168)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dq0LY-0008Sf-FR\n\tfor qemu-devel@nongnu.org; Thu, 07 Sep 2017 13:12:08 -0400","from smtp.corp.redhat.com\n\t(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 6D83B3683C;\n\tThu, 7 Sep 2017 17:12:07 +0000 (UTC)","from gondolin (ovpn-116-101.ams2.redhat.com [10.36.116.101])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 5B19678C1E;\n\tThu, 7 Sep 2017 17:12:01 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 6D83B3683C","Date":"Thu, 7 Sep 2017 19:11:59 +0200","From":"Cornelia Huck ","To":"David Hildenbrand ","Message-ID":"<20170907191159.767509da.cohuck@redhat.com>","In-Reply-To":"<20170904154316.4148-20-david@redhat.com>","References":"<20170904154316.4148-1-david@redhat.com>\n\t<20170904154316.4148-20-david@redhat.com>","Organization":"Red Hat GmbH","MIME-Version":"1.0","Content-Type":"text/plain; charset=US-ASCII","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.12","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.30]);\n\tThu, 07 Sep 2017 17:12:07 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v2 19/19] s390x: get rid of\n\tcpu_s390x_create()","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"thuth@redhat.com, Eduardo Habkost ,\n\tRichard Henderson ,\n\tqemu-devel@nongnu.org, Alexander Graf ,\n\tborntraeger@de.ibm.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]