[{"id":1766723,"web_url":"http://patchwork.ozlabs.org/comment/1766723/","msgid":"","list_archive_url":null,"date":"2017-09-12T07:39:30","subject":"Re: [PATCH -next] pinctrl: sprd: fix build errors and dependencies","submitter":{"id":7055,"url":"http://patchwork.ozlabs.org/api/people/7055/","name":"Linus Walleij","email":"linus.walleij@linaro.org"},"content":"On Mon, Sep 4, 2017 at 5:35 PM, Randy Dunlap wrote:\n\n> From: Randy Dunlap \n>\n> Fix build errors when CONFIG_OF is not enabled.\n> Also, the pinctrl-sprd-sc9860 driver uses functions from the pinctrl-sprd\n> driver, so the former should depend on the latter driver.\n>\n> ../drivers/pinctrl/sprd/pinctrl-sprd.c: In function 'sprd_dt_node_to_map':\n> ../drivers/pinctrl/sprd/pinctrl-sprd.c:290:2: error: implicit declaration of function 'pinconf_generic_parse_dt_config' [-Werror=implicit-function-declaration]\n> ret = pinconf_generic_parse_dt_config(np, pctldev, &configs,\n> ^\n> ../drivers/pinctrl/sprd/pinctrl-sprd.c: At top level:\n> ../drivers/pinctrl/sprd/pinctrl-sprd.c:844:44: error: array type has incomplete element type\n> static const struct pinconf_generic_params sprd_dt_params[] = {\n> ^\n> Signed-off-by: Randy Dunlap \n> Cc: Baolin Wang \n> Cc: Linus Walleij \n> Cc: linux-gpio@vger.kernel.org\n\nPatch applied for fixes.\n\nYours,\nLinus Walleij\n--\nTo unsubscribe from this list: send the line \"unsubscribe linux-gpio\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-gpio-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"OmQRdmL6\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xrxWz1dLdz9s83\n\tfor ;\n\tTue, 12 Sep 2017 17:39:43 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751318AbdILHjc (ORCPT );\n\tTue, 12 Sep 2017 03:39:32 -0400","from mail-it0-f47.google.com ([209.85.214.47]:37773 \"EHLO\n\tmail-it0-f47.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751292AbdILHjb (ORCPT\n\t); Tue, 12 Sep 2017 03:39:31 -0400","by mail-it0-f47.google.com with SMTP id o200so26238410itg.0\n\tfor ;\n\tTue, 12 Sep 2017 00:39:31 -0700 (PDT)","by 10.79.164.78 with HTTP; Tue, 12 Sep 2017 00:39:30 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=1mle3fRv2e31wi1sR/aBueG5ficFWtU26RpUk4jyvlY=;\n\tb=OmQRdmL6XcbBUsz7+tYUUJsPP915z1fdL6ZZPgK/VlgelBZx7kgxh26Ova+nruq5wP\n\tYLDNGs2NgC5sF2LVF2C/JVIqgPgrE04wYZC+15KA1ootDZ6yZkZbTU5sQYhAWgpOTqkI\n\te+oKi7r0vMSQ0MfQheieUm5yBbtqtUWYaH0W0=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=1mle3fRv2e31wi1sR/aBueG5ficFWtU26RpUk4jyvlY=;\n\tb=YLlsQ3IuqQFv7qkbfBLLv3X/9JBqNMTnL+sG9TJavNPDldp25nkwakniHQ/+8tdFKo\n\tPzwDFIzXL8q6pARWgwjPdaASrjZOPShuqvtz32W+B0YBBab3TTbeIycFoNAg6W9JngqG\n\tY7uCmxs812XtszOlVFyvOBEjJIE3VaO6/CLsXboLxvW1dXyXCnpfYBMOPJslCI9qHHQ+\n\tRkWUEjtMAsiu1tcz0g/ML/cfaBu95opjty+RVVQbfP88/dgRfQIc3TOeJ/AIOd3GnUKy\n\tgZfmyg8ZPRy2WitmlKp+E+lEIDLFzH8INaAWzhlFCFoINJ9EluxQi23hzqYi/np2USvs\n\tbJBQ==","X-Gm-Message-State":"AHPjjUgDAbw9xiMjRl/64GI6tvXeezZGR9ioLucnwCIgu46Ap2jT2N7T\n\tnOnes25p7JjlBq/3pUGinTCvAmg5y9YPDO58Yr9k5g==","X-Google-Smtp-Source":"AOwi7QB2mw4QBVjR8EOAbG04eKis5fEv5gyZJScea74YN8ZBI1SH3BgI/p/F4sUzW68tfDLdDIBDMKPeIDf7MAbiUTs=","X-Received":"by 10.36.39.17 with SMTP id g17mr16045575ita.69.1505201970720;\n\tTue, 12 Sep 2017 00:39:30 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"","References":"","From":"Linus Walleij ","Date":"Tue, 12 Sep 2017 09:39:30 +0200","Message-ID":"","Subject":"Re: [PATCH -next] pinctrl: sprd: fix build errors and dependencies","To":"Randy Dunlap ","Cc":"LKML ,\n\tBaolin Wang ,\n\t\"linux-gpio@vger.kernel.org\" ","Content-Type":"text/plain; charset=\"UTF-8\"","Sender":"linux-gpio-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-gpio@vger.kernel.org"}}]