[{"id":1763676,"web_url":"http://patchwork.ozlabs.org/comment/1763676/","msgid":"<20170905.144153.67687828247988369.davem@davemloft.net>","list_archive_url":null,"date":"2017-09-05T21:41:53","subject":"Re: [PATCH net-next] rxrpc: Make service connection lookup always\n\tcheck for retry","submitter":{"id":15,"url":"http://patchwork.ozlabs.org/api/people/15/","name":"David Miller","email":"davem@davemloft.net"},"content":"From: David Howells \nDate: Mon, 04 Sep 2017 15:28:28 +0100\n\n> When an RxRPC service packet comes in, the target connection is looked up\n> by an rb-tree search under RCU and a read-locked seqlock; the seqlock retry\n> check is, however, currently skipped if we got a match, but probably\n> shouldn't be in case the connection we found gets replaced whilst we're\n> doing a search.\n> \n> Make the lookup procedure always go through need_seqretry(), even if the\n> lookup was successful. This makes sure we always pick up on a write-lock\n> event.\n> \n> On the other hand, since we don't take a ref on the object, but rely on RCU\n> to prevent its destruction after dropping the seqlock, I'm not sure this is\n> necessary.\n> \n> Signed-off-by: David Howells \n\nApplied, thanks David.","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xn0YB0BC8z9t2R\n\tfor ;\n\tWed, 6 Sep 2017 07:42:06 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1753341AbdIEVl4 (ORCPT );\n\tTue, 5 Sep 2017 17:41:56 -0400","from shards.monkeyblade.net ([184.105.139.130]:39690 \"EHLO\n\tshards.monkeyblade.net\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1752719AbdIEVly (ORCPT\n\t); Tue, 5 Sep 2017 17:41:54 -0400","from localhost (74-93-104-98-Washington.hfc.comcastbusiness.net\n\t[74.93.104.98]) (using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(Client did not present a certificate)\n\t(Authenticated sender: davem-davemloft)\n\tby shards.monkeyblade.net (Postfix) with ESMTPSA id 6147A13DBCDEB;\n\tTue, 5 Sep 2017 14:41:54 -0700 (PDT)"],"Date":"Tue, 05 Sep 2017 14:41:53 -0700 (PDT)","Message-Id":"<20170905.144153.67687828247988369.davem@davemloft.net>","To":"dhowells@redhat.com","Cc":"netdev@vger.kernel.org, linux-afs@lists.infradead.org,\n\tlinux-kernel@vger.kernel.org","Subject":"Re: [PATCH net-next] rxrpc: Make service connection lookup always\n\tcheck for retry","From":"David Miller ","In-Reply-To":"<150453530801.20359.17059994007095255872.stgit@warthog.procyon.org.uk>","References":"<150453530801.20359.17059994007095255872.stgit@warthog.procyon.org.uk>","X-Mailer":"Mew version 6.7 on Emacs 25.2 / Mule 6.0 (HANACHIRUSATO)","Mime-Version":"1.0","Content-Type":"Text/Plain; charset=us-ascii","Content-Transfer-Encoding":"7bit","X-Greylist":"Sender succeeded SMTP AUTH, not delayed by\n\tmilter-greylist-4.5.12 (shards.monkeyblade.net\n\t[149.20.54.216]); Tue, 05 Sep 2017 14:41:54 -0700 (PDT)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}}]