[{"id":1762721,"web_url":"http://patchwork.ozlabs.org/comment/1762721/","msgid":"","list_archive_url":null,"date":"2017-09-04T15:03:09","subject":"Re: [Qemu-devel] [PATCH 3/6] cpu: rename cpu_parse_features() to\n\tcpu_parse_cpu_model()","submitter":{"id":70924,"url":"http://patchwork.ozlabs.org/api/people/70924/","name":"Philippe Mathieu-Daudé","email":"f4bug@amsat.org"},"content":"Hi Igor,\n\nOn 09/04/2017 11:00 AM, Igor Mammedov wrote:\n> function not just parses features but also converts CPU model\n> name to CPU type, rename it to reflect what it actualy does.\n\nWhy not squash this with your 1st patch \"split cpu_generic_init()\"?\n\n> \n> Signed-off-by: Igor Mammedov \n> ---\n> include/qom/cpu.h | 4 ++--\n> qom/cpu.c | 4 ++--\n> 2 files changed, 4 insertions(+), 4 deletions(-)\n> \n> diff --git a/include/qom/cpu.h b/include/qom/cpu.h\n> index 392ae75..a718daf 100644\n> --- a/include/qom/cpu.h\n> +++ b/include/qom/cpu.h\n> @@ -643,7 +643,7 @@ ObjectClass *cpu_class_by_name(const char *typename, const char *cpu_model);\n> CPUState *cpu_create(const char *typename);\n> \n> /**\n> - * cpu_parse_features:\n> + * cpu_parse_cpu_model:\n> * @typename: The CPU base type or CPU type.\n> * @cpu_model: The model string including optional parameters.\n> *\n> @@ -652,7 +652,7 @@ CPUState *cpu_create(const char *typename);\n> * Returns: type of CPU to create or prints error and terminates process\n> * if an error occurred.\n> */\n> -const char *cpu_parse_features(const char *typename, const char *cpu_model);\n> +const char *cpu_parse_cpu_model(const char *typename, const char *cpu_model);\n> \n> /**\n> * cpu_generic_init:\n> diff --git a/qom/cpu.c b/qom/cpu.c\n> index 307d638..199ad57 100644\n> --- a/qom/cpu.c\n> +++ b/qom/cpu.c\n> @@ -66,7 +66,7 @@ CPUState *cpu_create(const char *typename)\n> return cpu;\n> }\n> \n> -const char *cpu_parse_features(const char *typename, const char *cpu_model)\n> +const char *cpu_parse_cpu_model(const char *typename, const char *cpu_model)\n> {\n> ObjectClass *oc;\n> CPUClass *cc;\n> @@ -99,7 +99,7 @@ CPUState *cpu_generic_init(const char *typename, const char *cpu_model)\n> /* TODO: all callers of cpu_generic_init() need to be converted to\n> * call cpu_parse_features() only once, before calling cpu_generic_init().\n> */\n> - const char *cpu_type = cpu_parse_features(typename, cpu_model);\n> + const char *cpu_type = cpu_parse_cpu_model(typename, cpu_model);\n> \n> assert(cpu_type);\n> return cpu_create(cpu_type);\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"SXMtP5Z+\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xmCsB0xNcz9s4s\n\tfor ;\n\tTue, 5 Sep 2017 01:08:14 +1000 (AEST)","from localhost ([::1]:53627 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dosyy-0007yU-5B\n\tfor incoming@patchwork.ozlabs.org; Mon, 04 Sep 2017 11:08:12 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:42748)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from )\n\tid 1dosvU-0005JQ-Av\n\tfor qemu-devel@nongnu.org; Mon, 04 Sep 2017 11:06:46 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from )\n\tid 1dosuA-0003lK-Cl\n\tfor qemu-devel@nongnu.org; Mon, 04 Sep 2017 11:04:36 -0400","from mail-qt0-x244.google.com ([2607:f8b0:400d:c0d::244]:34000)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from )\n\tid 1dosuA-0003kR-7o\n\tfor qemu-devel@nongnu.org; Mon, 04 Sep 2017 11:03:14 -0400","by mail-qt0-x244.google.com with SMTP id v20so428420qtg.1\n\tfor ; Mon, 04 Sep 2017 08:03:14 -0700 (PDT)","from [192.168.1.10] ([181.93.89.178])\n\tby smtp.gmail.com with ESMTPSA id\n\t69sm4959360qte.95.2017.09.04.08.03.11\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tMon, 04 Sep 2017 08:03:12 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=sender:subject:to:cc:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:content-transfer-encoding; \n\tbh=+O1AyBCXAGZ4HUgaMVx7V3sLOr1N2GL11p2UHi1Gh2w=;\n\tb=SXMtP5Z+UBbJT5kZ6Ux/WRyesQ34xDYNKJS+Yn71ZWxtLcAzFQwCVZi7HiFmFwdDvX\n\tVYFa951RvjqDQ5gxZzSnpCdQBKn9BS2PmJTuHTUYRW2uWyfvZOeFwpxQGoA05aFfKgJh\n\tyH3ENH2ULuftDN7CPXS7Tfn4KdLKpquKSEw8YIatu1h6d58wbBie7ENQ9LEBHtptU6Fi\n\tS5PUHik9lqqVG5tusYGq6LQqG14aUtXS5d1GDz+PDeBo3RXxz9+/3cOMMAFQeI9q/jeI\n\tQEDxOL1Uzg5/LTRTYw1nq8hJOxQqYAc/15X8i/RMi5y1Gfl/P/XGkk4YEsBF8+7KwLwS\n\t2FCg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:sender:subject:to:cc:references:from:message-id\n\t:date:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=+O1AyBCXAGZ4HUgaMVx7V3sLOr1N2GL11p2UHi1Gh2w=;\n\tb=bscL8/qxLazhCrDC0lXQUlJBeweme6uBoxvApH7R8k83elF1U9HFFDV2kVxm9vPzFd\n\tA/KaCtevxNNPKWuYfwJNYm2JvL+VbxRrvmVBauM7A/zVftPMwHH0jNGJMfutC/V0AjVD\n\tSOJi9FKrCQ9kPd/ZvV98ug6LolSVH6TeIjm3IhHn+1eyz7gKbdLGVZtQXcT9vyOAi28g\n\tjlIEZYlxyM2djID/jPaWNy1+mSZPUIB8V+KoboV1Y3tWykUcKxnx+6WcaVaNeR+SPsly\n\tX5tPH7oQfqbWnRrzm2tgTydTiREhRvwUciFBygIZlwu0Of6eA33l/zv0ETjw5L7GBxEa\n\tOS3A==","X-Gm-Message-State":"AHPjjUiXerS7FwwotkgS/CAKNSitz6W+JKJ+UXTvdE+sIOL+ai6jYd4g\n\tGPqJn7i8Vk8BYQ==","X-Google-Smtp-Source":"ADKCNb4JQJfHiAeo8PYuzuIAyD4zCtDySVrxU3+rB6wkXG8ODPvtAsXPxVVIlJruM2TfPdPKNq5Uvg==","X-Received":"by 10.200.53.236 with SMTP id l41mr1159900qtb.24.1504537393442; \n\tMon, 04 Sep 2017 08:03:13 -0700 (PDT)","To":"Igor Mammedov , qemu-devel@nongnu.org","References":"<1504533662-198084-1-git-send-email-imammedo@redhat.com>\n\t<1504533662-198084-4-git-send-email-imammedo@redhat.com>","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","Message-ID":"","Date":"Mon, 4 Sep 2017 12:03:09 -0300","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<1504533662-198084-4-git-send-email-imammedo@redhat.com>","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2607:f8b0:400d:c0d::244","Subject":"Re: [Qemu-devel] [PATCH 3/6] cpu: rename cpu_parse_features() to\n\tcpu_parse_cpu_model()","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Andrew Jones , Eduardo Habkost ,\n\tRichard Henderson ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1762844,"web_url":"http://patchwork.ozlabs.org/comment/1762844/","msgid":"<20170904210649.1266364c@Igors-MacBook-Pro.local>","list_archive_url":null,"date":"2017-09-04T19:06:49","subject":"Re: [Qemu-devel] [PATCH 3/6] cpu: rename cpu_parse_features() to\n\tcpu_parse_cpu_model()","submitter":{"id":11305,"url":"http://patchwork.ozlabs.org/api/people/11305/","name":"Igor Mammedov","email":"imammedo@redhat.com"},"content":"On Mon, 4 Sep 2017 12:03:09 -0300\nPhilippe Mathieu-Daudé wrote:\n\n> Hi Igor,\n> \n> On 09/04/2017 11:00 AM, Igor Mammedov wrote:\n> > function not just parses features but also converts CPU model\n> > name to CPU type, rename it to reflect what it actualy does.\n> \n> Why not squash this with your 1st patch \"split cpu_generic_init()\"?\nthere I went with current/exiting way to call that part of code,\nand here I'm renaming it to show what it does exactly.\n\nBut I don't have any preference here, so I can squash this patch\ninto 1/6 on respin, if you prefer.\n\n> \n> > \n> > Signed-off-by: Igor Mammedov \n> > ---\n> > include/qom/cpu.h | 4 ++--\n> > qom/cpu.c | 4 ++--\n> > 2 files changed, 4 insertions(+), 4 deletions(-)\n> > \n> > diff --git a/include/qom/cpu.h b/include/qom/cpu.h\n> > index 392ae75..a718daf 100644\n> > --- a/include/qom/cpu.h\n> > +++ b/include/qom/cpu.h\n> > @@ -643,7 +643,7 @@ ObjectClass *cpu_class_by_name(const char *typename, const char *cpu_model);\n> > CPUState *cpu_create(const char *typename);\n> > \n> > /**\n> > - * cpu_parse_features:\n> > + * cpu_parse_cpu_model:\n> > * @typename: The CPU base type or CPU type.\n> > * @cpu_model: The model string including optional parameters.\n> > *\n> > @@ -652,7 +652,7 @@ CPUState *cpu_create(const char *typename);\n> > * Returns: type of CPU to create or prints error and terminates process\n> > * if an error occurred.\n> > */\n> > -const char *cpu_parse_features(const char *typename, const char *cpu_model);\n> > +const char *cpu_parse_cpu_model(const char *typename, const char *cpu_model);\n> > \n> > /**\n> > * cpu_generic_init:\n> > diff --git a/qom/cpu.c b/qom/cpu.c\n> > index 307d638..199ad57 100644\n> > --- a/qom/cpu.c\n> > +++ b/qom/cpu.c\n> > @@ -66,7 +66,7 @@ CPUState *cpu_create(const char *typename)\n> > return cpu;\n> > }\n> > \n> > -const char *cpu_parse_features(const char *typename, const char *cpu_model)\n> > +const char *cpu_parse_cpu_model(const char *typename, const char *cpu_model)\n> > {\n> > ObjectClass *oc;\n> > CPUClass *cc;\n> > @@ -99,7 +99,7 @@ CPUState *cpu_generic_init(const char *typename, const char *cpu_model)\n> > /* TODO: all callers of cpu_generic_init() need to be converted to\n> > * call cpu_parse_features() only once, before calling cpu_generic_init().\n> > */\n> > - const char *cpu_type = cpu_parse_features(typename, cpu_model);\n> > + const char *cpu_type = cpu_parse_cpu_model(typename, cpu_model);\n> > \n> > assert(cpu_type);\n> > return cpu_create(cpu_type);\n> >","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx04.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx04.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=imammedo@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xmK9R0ZMdz9s7c\n\tfor ;\n\tTue, 5 Sep 2017 05:07:38 +1000 (AEST)","from localhost ([::1]:55302 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dowie-0000EG-IB\n\tfor incoming@patchwork.ozlabs.org; Mon, 04 Sep 2017 15:07:36 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:35563)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dowi4-0000Dv-HV\n\tfor qemu-devel@nongnu.org; Mon, 04 Sep 2017 15:07:05 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dowhz-0007sh-RX\n\tfor qemu-devel@nongnu.org; Mon, 04 Sep 2017 15:07:00 -0400","from mx1.redhat.com ([209.132.183.28]:36550)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dowhz-0007qw-In\n\tfor qemu-devel@nongnu.org; Mon, 04 Sep 2017 15:06:55 -0400","from smtp.corp.redhat.com\n\t(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 787F770000;\n\tMon, 4 Sep 2017 19:06:54 +0000 (UTC)","from Igors-MacBook-Pro.local (unknown [10.36.112.11])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 31C766047B;\n\tMon, 4 Sep 2017 19:06:49 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 787F770000","Date":"Mon, 4 Sep 2017 21:06:49 +0200","From":"Igor Mammedov ","To":"Philippe =?utf-8?q?Mathieu-Daud=C3=A9?= ","Message-ID":"<20170904210649.1266364c@Igors-MacBook-Pro.local>","In-Reply-To":"","References":"<1504533662-198084-1-git-send-email-imammedo@redhat.com>\n\t<1504533662-198084-4-git-send-email-imammedo@redhat.com>\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"quoted-printable","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.11","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.28]);\n\tMon, 04 Sep 2017 19:06:54 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH 3/6] cpu: rename cpu_parse_features() to\n\tcpu_parse_cpu_model()","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Andrew Jones , Richard Henderson , \n\tqemu-devel@nongnu.org, Eduardo Habkost ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1762983,"web_url":"http://patchwork.ozlabs.org/comment/1762983/","msgid":"<2d12d972-ae16-49e5-1c39-ca43cb0a4bb9@redhat.com>","list_archive_url":null,"date":"2017-09-05T05:38:13","subject":"Re: [Qemu-devel] [PATCH 3/6] cpu: rename cpu_parse_features() to\n\tcpu_parse_cpu_model()","submitter":{"id":66152,"url":"http://patchwork.ozlabs.org/api/people/66152/","name":"Thomas Huth","email":"thuth@redhat.com"},"content":"On 04.09.2017 21:06, Igor Mammedov wrote:\n> On Mon, 4 Sep 2017 12:03:09 -0300\n> Philippe Mathieu-Daudé wrote:\n> \n>> Hi Igor,\n>>\n>> On 09/04/2017 11:00 AM, Igor Mammedov wrote:\n>>> function not just parses features but also converts CPU model\n>>> name to CPU type, rename it to reflect what it actualy does.\n>>\n>> Why not squash this with your 1st patch \"split cpu_generic_init()\"?\n> there I went with current/exiting way to call that part of code,\n> and here I'm renaming it to show what it does exactly.\n> \n> But I don't have any preference here, so I can squash this patch\n> into 1/6 on respin, if you prefer.\n\n+1 for squashing\n\n Thomas","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx01.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx01.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=thuth@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xmb9q1K3Yz9sNq\n\tfor ;\n\tTue, 5 Sep 2017 15:38:53 +1000 (AEST)","from localhost ([::1]:56956 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dp6ZV-0002I0-W1\n\tfor incoming@patchwork.ozlabs.org; Tue, 05 Sep 2017 01:38:50 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:43167)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dp6Z5-0002Hl-91\n\tfor qemu-devel@nongnu.org; Tue, 05 Sep 2017 01:38:28 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dp6Z0-0005ID-Dr\n\tfor qemu-devel@nongnu.org; Tue, 05 Sep 2017 01:38:23 -0400","from mx1.redhat.com ([209.132.183.28]:55360)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dp6Z0-0005Hr-7e\n\tfor qemu-devel@nongnu.org; Tue, 05 Sep 2017 01:38:18 -0400","from smtp.corp.redhat.com\n\t(int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 19D257574D;\n\tTue, 5 Sep 2017 05:38:17 +0000 (UTC)","from [10.36.116.114] (ovpn-116-114.ams2.redhat.com [10.36.116.114])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id 6976639BA;\n\tTue, 5 Sep 2017 05:38:15 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 19D257574D","To":"Igor Mammedov , =?utf-8?q?Philippe_Mathieu-Daud?=\n\t=?utf-8?b?w6k=?= ","References":"<1504533662-198084-1-git-send-email-imammedo@redhat.com>\n\t<1504533662-198084-4-git-send-email-imammedo@redhat.com>\n\t\n\t<20170904210649.1266364c@Igors-MacBook-Pro.local>","From":"Thomas Huth ","Message-ID":"<2d12d972-ae16-49e5-1c39-ca43cb0a4bb9@redhat.com>","Date":"Tue, 5 Sep 2017 07:38:13 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170904210649.1266364c@Igors-MacBook-Pro.local>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.15","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.25]);\n\tTue, 05 Sep 2017 05:38:17 +0000 (UTC)","Content-Transfer-Encoding":"quoted-printable","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH 3/6] cpu: rename cpu_parse_features() to\n\tcpu_parse_cpu_model()","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Andrew Jones , qemu-devel@nongnu.org,\n\tEduardo Habkost ,\n\tRichard Henderson ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1766354,"web_url":"http://patchwork.ozlabs.org/comment/1766354/","msgid":"<20170911170726.71c3fcba@nial.brq.redhat.com>","list_archive_url":null,"date":"2017-09-11T15:07:26","subject":"Re: [Qemu-devel] [PATCH 3/6] cpu: rename cpu_parse_features() to\n\tcpu_parse_cpu_model()","submitter":{"id":11305,"url":"http://patchwork.ozlabs.org/api/people/11305/","name":"Igor Mammedov","email":"imammedo@redhat.com"},"content":"On Tue, 5 Sep 2017 07:38:13 +0200\nThomas Huth wrote:\n\n> On 04.09.2017 21:06, Igor Mammedov wrote:\n> > On Mon, 4 Sep 2017 12:03:09 -0300\n> > Philippe Mathieu-Daudé wrote:\n> > \n> >> Hi Igor,\n> >>\n> >> On 09/04/2017 11:00 AM, Igor Mammedov wrote: \n> >>> function not just parses features but also converts CPU model\n> >>> name to CPU type, rename it to reflect what it actualy does. \n> >>\n> >> Why not squash this with your 1st patch \"split cpu_generic_init()\"? \n> > there I went with current/exiting way to call that part of code,\n> > and here I'm renaming it to show what it does exactly.\n> > \n> > But I don't have any preference here, so I can squash this patch\n> > into 1/6 on respin, if you prefer. \n> \n> +1 for squashing\nok, will do on respin\n\n> \n> Thomas\n> \n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx02.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx02.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=imammedo@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xrWWs3RmVz9s4q\n\tfor ;\n\tTue, 12 Sep 2017 01:08:09 +1000 (AEST)","from localhost ([::1]:58303 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1drQJj-00058Z-IL\n\tfor incoming@patchwork.ozlabs.org; Mon, 11 Sep 2017 11:08:07 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:40249)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1drQJB-00055W-Ea\n\tfor qemu-devel@nongnu.org; Mon, 11 Sep 2017 11:07:34 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1drQJ8-0001ZR-AB\n\tfor qemu-devel@nongnu.org; Mon, 11 Sep 2017 11:07:33 -0400","from mx1.redhat.com ([209.132.183.28]:34010)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1drQJ8-0001ZA-4Q\n\tfor qemu-devel@nongnu.org; Mon, 11 Sep 2017 11:07:30 -0400","from smtp.corp.redhat.com\n\t(int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 35BFBB5C1B;\n\tMon, 11 Sep 2017 15:07:29 +0000 (UTC)","from nial.brq.redhat.com (unknown [10.43.2.209])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id A09555C8B3;\n\tMon, 11 Sep 2017 15:07:27 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 35BFBB5C1B","Date":"Mon, 11 Sep 2017 17:07:26 +0200","From":"Igor Mammedov ","To":"Thomas Huth ","Message-ID":"<20170911170726.71c3fcba@nial.brq.redhat.com>","In-Reply-To":"<2d12d972-ae16-49e5-1c39-ca43cb0a4bb9@redhat.com>","References":"<1504533662-198084-1-git-send-email-imammedo@redhat.com>\n\t<1504533662-198084-4-git-send-email-imammedo@redhat.com>\n\t\n\t<20170904210649.1266364c@Igors-MacBook-Pro.local>\n\t<2d12d972-ae16-49e5-1c39-ca43cb0a4bb9@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"quoted-printable","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.16","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.26]);\n\tMon, 11 Sep 2017 15:07:29 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH 3/6] cpu: rename cpu_parse_features() to\n\tcpu_parse_cpu_model()","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"qemu-devel@nongnu.org, Andrew Jones , Philippe\n\t=?utf-8?q?Mathieu-Daud=C3=A9?= ,\n\tEduardo Habkost ,\n\tRichard Henderson ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]