[{"id":1762982,"web_url":"http://patchwork.ozlabs.org/comment/1762982/","msgid":"<34e928aa-b4da-189f-4ef4-58372e31fba4@canonical.com>","list_archive_url":null,"date":"2017-09-05T05:31:34","subject":"ACK: [PATCH] uefi: uefirttime: constify static array dayofmonth","submitter":{"id":10593,"url":"http://patchwork.ozlabs.org/api/people/10593/","name":"Alex Hung","email":"alex.hung@canonical.com"},"content":"On 2017-09-04 06:16 AM, Colin King wrote:\n> From: Colin Ian King \n> \n> The static and read-only array can also be made const\n> \n> Signed-off-by: Colin Ian King \n> ---\n> src/uefi/uefirttime/uefirttime.c | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/uefi/uefirttime/uefirttime.c b/src/uefi/uefirttime/uefirttime.c\n> index 621f53b6..7998f7fd 100644\n> --- a/src/uefi/uefirttime/uefirttime.c\n> +++ b/src/uefi/uefirttime/uefirttime.c\n> @@ -36,7 +36,7 @@\n> \t\t((year) % 4 == 0 && ((year) % 100 != 0 || (year) % 400 == 0))\n> \n> static int fd;\n> -static uint32_t dayofmonth[12] = {31, 29, 31, 30, 31, 30, 31, 31, 30, 31, 30, 31};\n> +static const uint32_t dayofmonth[12] = { 31, 29, 31, 30, 31, 30, 31, 31, 30, 31, 30, 31 };\n> \n> static bool dayvalid(EFI_TIME *Time)\n> {\n> \n\n\nAcked-by: Alex Hung ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.ubuntu.com\n\t(client-ip=91.189.94.19; helo=huckleberry.canonical.com;\n\tenvelope-from=fwts-devel-bounces@lists.ubuntu.com;\n\treceiver=)","Received":["from huckleberry.canonical.com (huckleberry.canonical.com\n\t[91.189.94.19])\n\tby ozlabs.org (Postfix) with ESMTP id 3xmb1R1cRhz9sNq;\n\tTue, 5 Sep 2017 15:31:39 +1000 (AEST)","from localhost ([127.0.0.1] helo=huckleberry.canonical.com)\n\tby huckleberry.canonical.com with esmtp (Exim 4.86_2)\n\t(envelope-from )\n\tid 1dp6SY-0002YQ-1n; Tue, 05 Sep 2017 05:31:38 +0000","from youngberry.canonical.com ([91.189.89.112])\n\tby huckleberry.canonical.com with esmtps\n\t(TLS1.0:DHE_RSA_AES_128_CBC_SHA1:128)\n\t(Exim 4.86_2) (envelope-from )\n\tid 1dp6SX-0002YD-DQ\n\tfor fwts-devel@lists.ubuntu.com; Tue, 05 Sep 2017 05:31:37 +0000","from mail-pg0-f71.google.com ([74.125.83.71])\n\tby youngberry.canonical.com with esmtps\n\t(TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.76) (envelope-from )\n\tid 1dp6SX-0001d9-1v\n\tfor fwts-devel@lists.ubuntu.com; Tue, 05 Sep 2017 05:31:37 +0000","by mail-pg0-f71.google.com with SMTP id r133so3115165pgr.0\n\tfor ;\n\tMon, 04 Sep 2017 22:31:36 -0700 (PDT)","from [192.168.1.125] ([207.102.104.225])\n\tby smtp.gmail.com with ESMTPSA id\n\tr30sm13895802pgu.5.2017.09.04.22.31.34\n\tfor \n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tMon, 04 Sep 2017 22:31:34 -0700 (PDT)"],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=+QOZO4SWq3rjHLX7M3OvTplrZveJzbdkEwTV44HGFDc=;\n\tb=hH1rrDUswSAKuXZamAZKAiD08vMhrv0dgermnLEDwdtd+N3mfeOVGxv4KsEMN+JQIi\n\tXpUqz7v6oyTHGx3qBJNw2T5DJaB3RtPWbxXTMDrBqj9vSRZ6OxVzK4kvgpfk2aD8hiyg\n\t2UsLhN0VZp2k23YRice9xh+bUNw4vyaA4YxHKugKTG+vptrhSFG+MhY7IUKH5YJW9oRd\n\tZBifZjEV9Uraqi4ZsyX8n6yve6d4DCog62rKe4X6Eoga86vJXDQOADTjBxLSTF/lnGxi\n\t6bJABuJF0qm0KfWS8IgPcsQiDTKkBGJBxFqfSj13h6Ym9KYoMHojc+yhMPRARUA7YW84\n\td1DQ==","X-Gm-Message-State":"AHPjjUjlZKopncgGNKZvAeYqRNNBCfodhfnOvq/F3b5/6ZxiMGsG80HU\n\trpBavljQtmnr1bjVGBJmF2iATsT9TNktgVgIvbftu5OU7hyVotJoPvXoulfcyy+6caDJx2CIsQa\n\t8EaTMZowINu7FGH8WSAI0KsN5t8Bh0pU=","X-Received":["by 10.84.233.66 with SMTP id k2mr3002589plt.49.1504589495594;\n\tMon, 04 Sep 2017 22:31:35 -0700 (PDT)","by 10.84.233.66 with SMTP id k2mr3002583plt.49.1504589495469;\n\tMon, 04 Sep 2017 22:31:35 -0700 (PDT)"],"X-Google-Smtp-Source":"ADKCNb7viCrUGrGkMJYkUoVDJcmM6A3WIpso9r/UIEchxD/D+SHeRwFOq7ChmIJuNoWI+/xsJf7KMQ==","Subject":"ACK: [PATCH] uefi: uefirttime: constify static array dayofmonth","To":"fwts-devel@lists.ubuntu.com","References":"<20170904131601.19434-1-colin.king@canonical.com>","From":"Alex Hung ","Message-ID":"<34e928aa-b4da-189f-4ef4-58372e31fba4@canonical.com>","Date":"Mon, 4 Sep 2017 22:31:34 -0700","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<20170904131601.19434-1-colin.king@canonical.com>","Content-Language":"en-US","X-BeenThere":"fwts-devel@lists.ubuntu.com","X-Mailman-Version":"2.1.20","Precedence":"list","List-Id":"Firmware Test Suite Development ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Transfer-Encoding":"base64","Content-Type":"text/plain; charset=\"utf-8\"; Format=\"flowed\"","Errors-To":"fwts-devel-bounces@lists.ubuntu.com","Sender":"\"fwts-devel\" "}},{"id":1763906,"web_url":"http://patchwork.ozlabs.org/comment/1763906/","msgid":"","list_archive_url":null,"date":"2017-09-06T08:22:07","subject":"ACK: [PATCH] uefi: uefirttime: constify static array dayofmonth","submitter":{"id":14061,"url":"http://patchwork.ozlabs.org/api/people/14061/","name":"Ivan Hu","email":"ivan.hu@canonical.com"},"content":"On 09/04/2017 09:16 PM, Colin King wrote:\n> From: Colin Ian King \n> \n> The static and read-only array can also be made const\n> \n> Signed-off-by: Colin Ian King \n> ---\n> src/uefi/uefirttime/uefirttime.c | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/uefi/uefirttime/uefirttime.c b/src/uefi/uefirttime/uefirttime.c\n> index 621f53b6..7998f7fd 100644\n> --- a/src/uefi/uefirttime/uefirttime.c\n> +++ b/src/uefi/uefirttime/uefirttime.c\n> @@ -36,7 +36,7 @@\n> \t\t((year) % 4 == 0 && ((year) % 100 != 0 || (year) % 400 == 0))\n> \n> static int fd;\n> -static uint32_t dayofmonth[12] = {31, 29, 31, 30, 31, 30, 31, 31, 30, 31, 30, 31};\n> +static const uint32_t dayofmonth[12] = { 31, 29, 31, 30, 31, 30, 31, 31, 30, 31, 30, 31 };\n> \n> static bool dayvalid(EFI_TIME *Time)\n> {\n> \n\nAcked-by: Ivan Hu ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.ubuntu.com\n\t(client-ip=91.189.94.19; helo=huckleberry.canonical.com;\n\tenvelope-from=fwts-devel-bounces@lists.ubuntu.com;\n\treceiver=)","Received":["from huckleberry.canonical.com (huckleberry.canonical.com\n\t[91.189.94.19])\n\tby ozlabs.org (Postfix) with ESMTP id 3xnGln11h8z9s9Y;\n\tWed, 6 Sep 2017 18:22:13 +1000 (AEST)","from localhost ([127.0.0.1] helo=huckleberry.canonical.com)\n\tby huckleberry.canonical.com with esmtp (Exim 4.86_2)\n\t(envelope-from )\n\tid 1dpVb9-0008G2-VZ; Wed, 06 Sep 2017 08:22:11 +0000","from youngberry.canonical.com ([91.189.89.112])\n\tby huckleberry.canonical.com with esmtps\n\t(TLS1.0:DHE_RSA_AES_128_CBC_SHA1:128)\n\t(Exim 4.86_2) (envelope-from )\n\tid 1dpVb8-0008Fv-Km\n\tfor fwts-devel@lists.ubuntu.com; Wed, 06 Sep 2017 08:22:10 +0000","from [175.181.155.140] (helo=[192.168.31.95])\n\tby youngberry.canonical.com with esmtpsa\n\t(TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.76) (envelope-from )\n\tid 1dpVb8-0002dQ-59\n\tfor fwts-devel@lists.ubuntu.com; Wed, 06 Sep 2017 08:22:10 +0000"],"Subject":"ACK: [PATCH] uefi: uefirttime: constify static array dayofmonth","To":"fwts-devel@lists.ubuntu.com","References":"<20170904131601.19434-1-colin.king@canonical.com>","From":"ivanhu ","Message-ID":"","Date":"Wed, 6 Sep 2017 16:22:07 +0800","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<20170904131601.19434-1-colin.king@canonical.com>","Content-Language":"en-GB","X-BeenThere":"fwts-devel@lists.ubuntu.com","X-Mailman-Version":"2.1.20","Precedence":"list","List-Id":"Firmware Test Suite Development ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Transfer-Encoding":"base64","Content-Type":"text/plain; charset=\"utf-8\"; Format=\"flowed\"","Errors-To":"fwts-devel-bounces@lists.ubuntu.com","Sender":"\"fwts-devel\" "}}]