[{"id":1762980,"web_url":"http://patchwork.ozlabs.org/comment/1762980/","msgid":"<364c8225-a775-24fa-f55c-f02da44d340b@canonical.com>","list_archive_url":null,"date":"2017-09-05T05:31:13","subject":"ACK: [PATCH] uefi: uefidump: make array uefidump_info_table const","submitter":{"id":10593,"url":"http://patchwork.ozlabs.org/api/people/10593/","name":"Alex Hung","email":"alex.hung@canonical.com"},"content":"On 2017-09-04 06:07 AM, Colin King wrote:\n> From: Colin Ian King \n> \n> Array uefidump_info_table is static and read-only so make it\n> also const\n> \n> Signed-off-by: Colin Ian King \n> ---\n> src/uefi/uefidump/uefidump.c | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/uefi/uefidump/uefidump.c b/src/uefi/uefidump/uefidump.c\n> index 305d2d6a..c4c44b1a 100644\n> --- a/src/uefi/uefidump/uefidump.c\n> +++ b/src/uefi/uefidump/uefidump.c\n> @@ -1379,7 +1379,7 @@ static void uefidump_info_syspreporder(fwts_framework *fw, fwts_uefi_var *var)\n> \tfree(str);\n> }\n> \n> -static uefidump_info uefidump_info_table[] = {\n> +static const uefidump_info uefidump_info_table[] = {\n> \t{ \"PlatformLangCodes\",\tuefidump_info_platform_langcodes },\n> \t{ \"PlatformLang\",\tuefidump_info_platform_lang },\n> \t{ \"BootOptionSupport\", \tuefidump_info_bootoptionsupport },\n> @@ -1420,7 +1420,7 @@ static void uefidump_var(fwts_framework *fw, fwts_uefi_var *var)\n> {\n> \tchar varname[512];\n> \tchar guid_str[37];\n> -\tuefidump_info *info;\n> +\tconst uefidump_info *info;\n> \n> \tfwts_uefi_get_varname(varname, sizeof(varname), var);\n> \n> \n\nAcked-by: Alex Hung ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.ubuntu.com\n\t(client-ip=91.189.94.19; helo=huckleberry.canonical.com;\n\tenvelope-from=fwts-devel-bounces@lists.ubuntu.com;\n\treceiver=)","Received":["from huckleberry.canonical.com (huckleberry.canonical.com\n\t[91.189.94.19])\n\tby ozlabs.org (Postfix) with ESMTP id 3xmb142458z9sNq;\n\tTue, 5 Sep 2017 15:31:20 +1000 (AEST)","from localhost ([127.0.0.1] helo=huckleberry.canonical.com)\n\tby huckleberry.canonical.com with esmtp (Exim 4.86_2)\n\t(envelope-from )\n\tid 1dp6SE-0002Ui-U0; Tue, 05 Sep 2017 05:31:18 +0000","from youngberry.canonical.com ([91.189.89.112])\n\tby huckleberry.canonical.com with esmtps\n\t(TLS1.0:DHE_RSA_AES_128_CBC_SHA1:128)\n\t(Exim 4.86_2) (envelope-from )\n\tid 1dp6SC-0002US-RR\n\tfor fwts-devel@lists.ubuntu.com; Tue, 05 Sep 2017 05:31:16 +0000","from mail-pf0-f198.google.com ([209.85.192.198])\n\tby youngberry.canonical.com with esmtps\n\t(TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.76) (envelope-from )\n\tid 1dp6SC-0001cp-Fy\n\tfor fwts-devel@lists.ubuntu.com; Tue, 05 Sep 2017 05:31:16 +0000","by mail-pf0-f198.google.com with SMTP id g13so4985931pfm.0\n\tfor ;\n\tMon, 04 Sep 2017 22:31:16 -0700 (PDT)","from [192.168.1.125] ([207.102.104.225])\n\tby smtp.gmail.com with ESMTPSA id\n\t188sm12408762pfe.171.2017.09.04.22.31.14\n\tfor \n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tMon, 04 Sep 2017 22:31:14 -0700 (PDT)"],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=RAMyM46U4eqDk2pNxYYK831bZ+cRDw3K/zI5dKFocSw=;\n\tb=rW2LtKGoztWhDx6Rk/ycS18BAwmCOaQakfiq54EeYG/wARUrw5sDjkKJ0F5vy5uLOa\n\tlVE7hdoiFfQqVcLDIkBAZcWPUTozDnGHK2HQHLg8Q2pPdUx8L77Es5p4mlOklVfL2X1O\n\t2wM4A+kXt99Z4S6bhSxcT249gGzozKHFcK0bAb+J3PpIm38hkwDPMnmesAgldfFDYZD3\n\t+ebS0mp7MYPvg05fVyc22U44rZe55vd/kxj4zUfYnY6gtfgB1WlE8J7mRnaoSnl9Sgn6\n\tCaNSo/Wu5/yMBddV9b1XOZjRK2VdALQOmfqQEfqeYAeUV1HnuQJVVO9oGzNzto/qtynK\n\teQIg==","X-Gm-Message-State":"AHPjjUgXx+Agi62nRKe6B7QtWIj7hYzdvq3DIQzLgaX9DwuK8loc8Rdp\n\tSEc/K5rG7JK+UBP19XkvAWnN6XDnBrrlUjKMOqavZ1i8fRBtjpiYbt16W1j3NkfbVfZyvJ5dteP\n\tudhxJo+VYtEMQe1clHP+qijGA/DvfeN0=","X-Received":["by 10.98.196.206 with SMTP id h75mr2512680pfk.35.1504589474951; \n\tMon, 04 Sep 2017 22:31:14 -0700 (PDT)","by 10.98.196.206 with SMTP id h75mr2512676pfk.35.1504589474766; \n\tMon, 04 Sep 2017 22:31:14 -0700 (PDT)"],"X-Google-Smtp-Source":"ADKCNb7QLkLK+Iy9bPXt6qa1ZUUNCq/9thQ6HOAr8U5yZP/jfSD7ipJrZqSDDKIpGf9VEe5P65V6dw==","Subject":"ACK: [PATCH] uefi: uefidump: make array uefidump_info_table const","To":"fwts-devel@lists.ubuntu.com","References":"<20170904130703.12844-1-colin.king@canonical.com>","From":"Alex Hung ","Message-ID":"<364c8225-a775-24fa-f55c-f02da44d340b@canonical.com>","Date":"Mon, 4 Sep 2017 22:31:13 -0700","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<20170904130703.12844-1-colin.king@canonical.com>","Content-Language":"en-US","X-BeenThere":"fwts-devel@lists.ubuntu.com","X-Mailman-Version":"2.1.20","Precedence":"list","List-Id":"Firmware Test Suite Development ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Transfer-Encoding":"base64","Content-Type":"text/plain; charset=\"utf-8\"; Format=\"flowed\"","Errors-To":"fwts-devel-bounces@lists.ubuntu.com","Sender":"\"fwts-devel\" "}},{"id":1763903,"web_url":"http://patchwork.ozlabs.org/comment/1763903/","msgid":"<3e968931-1eb7-4d6b-63a0-d86250b7bce2@canonical.com>","list_archive_url":null,"date":"2017-09-06T08:21:22","subject":"ACK: [PATCH] uefi: uefidump: make array uefidump_info_table const","submitter":{"id":14061,"url":"http://patchwork.ozlabs.org/api/people/14061/","name":"Ivan Hu","email":"ivan.hu@canonical.com"},"content":"On 09/04/2017 09:07 PM, Colin King wrote:\n> From: Colin Ian King \n> \n> Array uefidump_info_table is static and read-only so make it\n> also const\n> \n> Signed-off-by: Colin Ian King \n> ---\n> src/uefi/uefidump/uefidump.c | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/uefi/uefidump/uefidump.c b/src/uefi/uefidump/uefidump.c\n> index 305d2d6a..c4c44b1a 100644\n> --- a/src/uefi/uefidump/uefidump.c\n> +++ b/src/uefi/uefidump/uefidump.c\n> @@ -1379,7 +1379,7 @@ static void uefidump_info_syspreporder(fwts_framework *fw, fwts_uefi_var *var)\n> \tfree(str);\n> }\n> \n> -static uefidump_info uefidump_info_table[] = {\n> +static const uefidump_info uefidump_info_table[] = {\n> \t{ \"PlatformLangCodes\",\tuefidump_info_platform_langcodes },\n> \t{ \"PlatformLang\",\tuefidump_info_platform_lang },\n> \t{ \"BootOptionSupport\", \tuefidump_info_bootoptionsupport },\n> @@ -1420,7 +1420,7 @@ static void uefidump_var(fwts_framework *fw, fwts_uefi_var *var)\n> {\n> \tchar varname[512];\n> \tchar guid_str[37];\n> -\tuefidump_info *info;\n> +\tconst uefidump_info *info;\n> \n> \tfwts_uefi_get_varname(varname, sizeof(varname), var);\n> \n> \n\nAcked-by: Ivan Hu ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.ubuntu.com\n\t(client-ip=91.189.94.19; helo=huckleberry.canonical.com;\n\tenvelope-from=fwts-devel-bounces@lists.ubuntu.com;\n\treceiver=)","Received":["from huckleberry.canonical.com (huckleberry.canonical.com\n\t[91.189.94.19])\n\tby ozlabs.org (Postfix) with ESMTP id 3xnGkx4spjz9s9Y;\n\tWed, 6 Sep 2017 18:21:29 +1000 (AEST)","from localhost ([127.0.0.1] helo=huckleberry.canonical.com)\n\tby huckleberry.canonical.com with esmtp (Exim 4.86_2)\n\t(envelope-from )\n\tid 1dpVaS-000892-Fb; Wed, 06 Sep 2017 08:21:28 +0000","from youngberry.canonical.com ([91.189.89.112])\n\tby huckleberry.canonical.com with esmtps\n\t(TLS1.0:DHE_RSA_AES_128_CBC_SHA1:128)\n\t(Exim 4.86_2) (envelope-from )\n\tid 1dpVaQ-00088v-CQ\n\tfor fwts-devel@lists.ubuntu.com; Wed, 06 Sep 2017 08:21:26 +0000","from [175.181.155.140] (helo=[192.168.31.95])\n\tby youngberry.canonical.com with esmtpsa\n\t(TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.76) (envelope-from )\n\tid 1dpVaP-0002bF-SD\n\tfor fwts-devel@lists.ubuntu.com; Wed, 06 Sep 2017 08:21:26 +0000"],"Subject":"ACK: [PATCH] uefi: uefidump: make array uefidump_info_table const","To":"fwts-devel@lists.ubuntu.com","References":"<20170904130703.12844-1-colin.king@canonical.com>","From":"ivanhu ","Message-ID":"<3e968931-1eb7-4d6b-63a0-d86250b7bce2@canonical.com>","Date":"Wed, 6 Sep 2017 16:21:22 +0800","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<20170904130703.12844-1-colin.king@canonical.com>","Content-Language":"en-GB","X-BeenThere":"fwts-devel@lists.ubuntu.com","X-Mailman-Version":"2.1.20","Precedence":"list","List-Id":"Firmware Test Suite Development ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Transfer-Encoding":"base64","Content-Type":"text/plain; charset=\"utf-8\"; Format=\"flowed\"","Errors-To":"fwts-devel-bounces@lists.ubuntu.com","Sender":"\"fwts-devel\" "}}]